)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"b243f19395eaac090024fd208d8cfaf13f9f0383","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"663cff5d_71dcdfc7","updated":"2026-07-22 03:25:05.000000000","message":"recheck","commit_id":"3c0dd49b9499cb59fed5c303aef397013e71e494"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"d8b544c96fc664042bedb8fff8ed25206eb16095","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"326e53c9_ab97a673","updated":"2026-07-22 22:00:53.000000000","message":"Can you please also add a release note for the change","commit_id":"4af7ff0e70a92ff88def099cf207143461e128b9"}],"nova/templates/daemonset-compute.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"d8b544c96fc664042bedb8fff8ed25206eb16095","unresolved":true,"context_lines":[{"line_number":113,"context_line":"      hostPID: true"},{"line_number":114,"context_line":"      hostIPC: true"},{"line_number":115,"context_line":"      dnsPolicy: ClusterFirstWithHostNet"},{"line_number":116,"context_line":"      terminationGracePeriodSeconds: {{ $envAll.Values.pod.lifecycle.termination_grace_period.compute.timeout | default \"30\" }}"},{"line_number":117,"context_line":"      initContainers:"},{"line_number":118,"context_line":"{{ tuple $envAll \"pod_dependency\" $mounts_nova_compute_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":119,"context_line":"        - name: nova-compute-init"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6078f997_c27966c4","line":116,"updated":"2026-07-22 22:00:53.000000000","message":"Probably here it also have to be 180 by default","commit_id":"4af7ff0e70a92ff88def099cf207143461e128b9"},{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"94cd4d6555e8faa59f9769940d84fd3b40efb0df","unresolved":true,"context_lines":[{"line_number":113,"context_line":"      hostPID: true"},{"line_number":114,"context_line":"      hostIPC: true"},{"line_number":115,"context_line":"      dnsPolicy: ClusterFirstWithHostNet"},{"line_number":116,"context_line":"      terminationGracePeriodSeconds: {{ $envAll.Values.pod.lifecycle.termination_grace_period.compute.timeout | default \"30\" }}"},{"line_number":117,"context_line":"      initContainers:"},{"line_number":118,"context_line":"{{ tuple $envAll \"pod_dependency\" $mounts_nova_compute_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":119,"context_line":"        - name: nova-compute-init"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"87718ba4_0d50fca3","line":116,"in_reply_to":"3c31cb4e_ab94e69a","updated":"2026-07-23 17:18:45.000000000","message":"We don\u0027t have strict policy regarding this. For this case removing defaults from template files seems reasonable.","commit_id":"4af7ff0e70a92ff88def099cf207143461e128b9"},{"author":{"_account_id":38728,"name":"Amit Mahajan","display_name":"Amit Mahajan","email":"Amit.Mahajan@windriver.com","username":"amahajan"},"change_message_id":"2766a9e5094f211ac8512aba7440351a51b3e871","unresolved":true,"context_lines":[{"line_number":113,"context_line":"      hostPID: true"},{"line_number":114,"context_line":"      hostIPC: true"},{"line_number":115,"context_line":"      dnsPolicy: ClusterFirstWithHostNet"},{"line_number":116,"context_line":"      terminationGracePeriodSeconds: {{ $envAll.Values.pod.lifecycle.termination_grace_period.compute.timeout | default \"30\" }}"},{"line_number":117,"context_line":"      initContainers:"},{"line_number":118,"context_line":"{{ tuple $envAll \"pod_dependency\" $mounts_nova_compute_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":119,"context_line":"        - name: nova-compute-init"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3c31cb4e_ab94e69a","line":116,"in_reply_to":"6078f997_c27966c4","updated":"2026-07-23 16:44:37.000000000","message":"Do the default values for the configurable parameters via values.yaml make sense? As these are configurable values, so these can change again in some future release. Is it worth to duplicate such configurable parameters?","commit_id":"4af7ff0e70a92ff88def099cf207143461e128b9"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"489ada9b3c935433c1399e5ead19d25faf7cad4c","unresolved":true,"context_lines":[{"line_number":113,"context_line":"      hostPID: true"},{"line_number":114,"context_line":"      hostIPC: true"},{"line_number":115,"context_line":"      dnsPolicy: ClusterFirstWithHostNet"},{"line_number":116,"context_line":"      terminationGracePeriodSeconds: {{ $envAll.Values.pod.lifecycle.termination_grace_period.compute.timeout | default \"30\" }}"},{"line_number":117,"context_line":"      initContainers:"},{"line_number":118,"context_line":"{{ tuple $envAll \"pod_dependency\" $mounts_nova_compute_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":119,"context_line":"        - name: nova-compute-init"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"cb8ea6bb_71cb2d30","line":116,"in_reply_to":"6686afff_e3dfef36","updated":"2026-07-25 01:01:09.000000000","message":"You\u0027re setting the value new here as 30. The ask is to not do that. Get it done.","commit_id":"4af7ff0e70a92ff88def099cf207143461e128b9"},{"author":{"_account_id":38728,"name":"Amit Mahajan","display_name":"Amit Mahajan","email":"Amit.Mahajan@windriver.com","username":"amahajan"},"change_message_id":"96b8c1e23fc51347b4aa0d56990826353239c5dd","unresolved":true,"context_lines":[{"line_number":113,"context_line":"      hostPID: true"},{"line_number":114,"context_line":"      hostIPC: true"},{"line_number":115,"context_line":"      dnsPolicy: ClusterFirstWithHostNet"},{"line_number":116,"context_line":"      terminationGracePeriodSeconds: {{ $envAll.Values.pod.lifecycle.termination_grace_period.compute.timeout | default \"30\" }}"},{"line_number":117,"context_line":"      initContainers:"},{"line_number":118,"context_line":"{{ tuple $envAll \"pod_dependency\" $mounts_nova_compute_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":119,"context_line":"        - name: nova-compute-init"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6686afff_e3dfef36","line":116,"in_reply_to":"87718ba4_0d50fca3","updated":"2026-07-24 16:15:43.000000000","message":"IMO, removing defaults for this case and other such cases as well should be taken as a separate activity. Scope of this PR should be kept limited to the original problem it is tackling.","commit_id":"4af7ff0e70a92ff88def099cf207143461e128b9"},{"author":{"_account_id":38728,"name":"Amit Mahajan","display_name":"Amit Mahajan","email":"Amit.Mahajan@windriver.com","username":"amahajan"},"change_message_id":"1aa308513fc39306c95d6ce6538159e0d4fbcee7","unresolved":false,"context_lines":[{"line_number":113,"context_line":"      hostPID: true"},{"line_number":114,"context_line":"      hostIPC: true"},{"line_number":115,"context_line":"      dnsPolicy: ClusterFirstWithHostNet"},{"line_number":116,"context_line":"      terminationGracePeriodSeconds: {{ $envAll.Values.pod.lifecycle.termination_grace_period.compute.timeout | default \"30\" }}"},{"line_number":117,"context_line":"      initContainers:"},{"line_number":118,"context_line":"{{ tuple $envAll \"pod_dependency\" $mounts_nova_compute_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":119,"context_line":"        - name: nova-compute-init"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1d055bd1_0620dd5b","line":116,"in_reply_to":"cb8ea6bb_71cb2d30","updated":"2026-07-28 13:55:41.000000000","message":"Done.","commit_id":"4af7ff0e70a92ff88def099cf207143461e128b9"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"489ada9b3c935433c1399e5ead19d25faf7cad4c","unresolved":true,"context_lines":[{"line_number":113,"context_line":"      hostPID: true"},{"line_number":114,"context_line":"      hostIPC: true"},{"line_number":115,"context_line":"      dnsPolicy: ClusterFirstWithHostNet"},{"line_number":116,"context_line":"      terminationGracePeriodSeconds: {{ $envAll.Values.pod.lifecycle.termination_grace_period.compute.timeout | default \"30\" }}"},{"line_number":117,"context_line":"      initContainers:"},{"line_number":118,"context_line":"{{ tuple $envAll \"pod_dependency\" $mounts_nova_compute_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":119,"context_line":"        - name: nova-compute-init"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"14441de9_96199ba4","line":116,"updated":"2026-07-25 01:01:09.000000000","message":"```suggestion\n      terminationGracePeriodSeconds: {{ $envAll.Values.pod.lifecycle.termination_grace_period.compute.timeout }}\n```","commit_id":"7b7147514d84732ad6332ed7941bb815d01d745a"},{"author":{"_account_id":38728,"name":"Amit Mahajan","display_name":"Amit Mahajan","email":"Amit.Mahajan@windriver.com","username":"amahajan"},"change_message_id":"1aa308513fc39306c95d6ce6538159e0d4fbcee7","unresolved":false,"context_lines":[{"line_number":113,"context_line":"      hostPID: true"},{"line_number":114,"context_line":"      hostIPC: true"},{"line_number":115,"context_line":"      dnsPolicy: ClusterFirstWithHostNet"},{"line_number":116,"context_line":"      terminationGracePeriodSeconds: {{ $envAll.Values.pod.lifecycle.termination_grace_period.compute.timeout | default \"30\" }}"},{"line_number":117,"context_line":"      initContainers:"},{"line_number":118,"context_line":"{{ tuple $envAll \"pod_dependency\" $mounts_nova_compute_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":119,"context_line":"        - name: nova-compute-init"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d357ac2d_974cb588","line":116,"in_reply_to":"14441de9_96199ba4","updated":"2026-07-28 13:55:41.000000000","message":"Done","commit_id":"7b7147514d84732ad6332ed7941bb815d01d745a"}],"nova/templates/deployment-conductor.yaml":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"489ada9b3c935433c1399e5ead19d25faf7cad4c","unresolved":true,"context_lines":[{"line_number":88,"context_line":"{{ if $envAll.Values.pod.tolerations.nova.enabled }}"},{"line_number":89,"context_line":"{{ tuple $envAll \"nova\" | include \"helm-toolkit.snippets.kubernetes_tolerations\" | indent 6 }}"},{"line_number":90,"context_line":"{{ end }}"},{"line_number":91,"context_line":"      terminationGracePeriodSeconds: {{ $envAll.Values.pod.lifecycle.termination_grace_period.conductor.timeout | default \"30\" }}"},{"line_number":92,"context_line":"      initContainers:"},{"line_number":93,"context_line":"{{ tuple $envAll \"conductor\" $mounts_nova_conductor_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":94,"context_line":"      containers:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5923091e_92582d5a","line":91,"updated":"2026-07-25 01:01:09.000000000","message":"```suggestion\n      terminationGracePeriodSeconds: {{ $envAll.Values.pod.lifecycle.termination_grace_period.conductor.timeout }}\n```","commit_id":"7b7147514d84732ad6332ed7941bb815d01d745a"},{"author":{"_account_id":38728,"name":"Amit Mahajan","display_name":"Amit Mahajan","email":"Amit.Mahajan@windriver.com","username":"amahajan"},"change_message_id":"1aa308513fc39306c95d6ce6538159e0d4fbcee7","unresolved":false,"context_lines":[{"line_number":88,"context_line":"{{ if $envAll.Values.pod.tolerations.nova.enabled }}"},{"line_number":89,"context_line":"{{ tuple $envAll \"nova\" | include \"helm-toolkit.snippets.kubernetes_tolerations\" | indent 6 }}"},{"line_number":90,"context_line":"{{ end }}"},{"line_number":91,"context_line":"      terminationGracePeriodSeconds: {{ $envAll.Values.pod.lifecycle.termination_grace_period.conductor.timeout | default \"30\" }}"},{"line_number":92,"context_line":"      initContainers:"},{"line_number":93,"context_line":"{{ tuple $envAll \"conductor\" $mounts_nova_conductor_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":94,"context_line":"      containers:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0a1ca36b_71897e78","line":91,"in_reply_to":"5923091e_92582d5a","updated":"2026-07-28 13:55:41.000000000","message":"Done","commit_id":"7b7147514d84732ad6332ed7941bb815d01d745a"}],"nova/templates/deployment-scheduler.yaml":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"489ada9b3c935433c1399e5ead19d25faf7cad4c","unresolved":true,"context_lines":[{"line_number":88,"context_line":"{{ if $envAll.Values.pod.tolerations.nova.enabled }}"},{"line_number":89,"context_line":"{{ tuple $envAll \"nova\" | include \"helm-toolkit.snippets.kubernetes_tolerations\" | indent 6 }}"},{"line_number":90,"context_line":"{{ end }}"},{"line_number":91,"context_line":"      terminationGracePeriodSeconds: {{ $envAll.Values.pod.lifecycle.termination_grace_period.scheduler.timeout | default \"30\" }}"},{"line_number":92,"context_line":"      initContainers:"},{"line_number":93,"context_line":"{{ tuple $envAll \"scheduler\" $mounts_nova_scheduler_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":94,"context_line":"      containers:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7b57d34d_5088385b","line":91,"updated":"2026-07-25 01:01:09.000000000","message":"```suggestion\n      terminationGracePeriodSeconds: {{ $envAll.Values.pod.lifecycle.termination_grace_period.scheduler.timeout }}\n```","commit_id":"7b7147514d84732ad6332ed7941bb815d01d745a"},{"author":{"_account_id":38728,"name":"Amit Mahajan","display_name":"Amit Mahajan","email":"Amit.Mahajan@windriver.com","username":"amahajan"},"change_message_id":"1aa308513fc39306c95d6ce6538159e0d4fbcee7","unresolved":false,"context_lines":[{"line_number":88,"context_line":"{{ if $envAll.Values.pod.tolerations.nova.enabled }}"},{"line_number":89,"context_line":"{{ tuple $envAll \"nova\" | include \"helm-toolkit.snippets.kubernetes_tolerations\" | indent 6 }}"},{"line_number":90,"context_line":"{{ end }}"},{"line_number":91,"context_line":"      terminationGracePeriodSeconds: {{ $envAll.Values.pod.lifecycle.termination_grace_period.scheduler.timeout | default \"30\" }}"},{"line_number":92,"context_line":"      initContainers:"},{"line_number":93,"context_line":"{{ tuple $envAll \"scheduler\" $mounts_nova_scheduler_init | include \"helm-toolkit.snippets.kubernetes_entrypoint_init_container\" | indent 8 }}"},{"line_number":94,"context_line":"      containers:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5aaacca9_d39bb531","line":91,"in_reply_to":"7b57d34d_5088385b","updated":"2026-07-28 13:55:41.000000000","message":"Done","commit_id":"7b7147514d84732ad6332ed7941bb815d01d745a"}],"nova/values.yaml":[{"author":{"_account_id":3009,"name":"Vladimir Kozhukalov","email":"kozhukalov@gmail.com","username":"kozhukalov"},"change_message_id":"8c7f7e7862a5f70f09a4a67a9b3a4b04e31210f9","unresolved":true,"context_lines":[{"line_number":2484,"context_line":"        timeout: 30"},{"line_number":2485,"context_line":"      osapi:"},{"line_number":2486,"context_line":"        timeout: 30"},{"line_number":2487,"context_line":"      compute:"},{"line_number":2488,"context_line":"        timeout: 30"},{"line_number":2489,"context_line":"      conductor:"},{"line_number":2490,"context_line":"        timeout: 30"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6305bda7_441162b0","line":2487,"updated":"2026-07-22 14:33:00.000000000","message":"is it worth it to set them all 180 by default?","commit_id":"3c0dd49b9499cb59fed5c303aef397013e71e494"},{"author":{"_account_id":38728,"name":"Amit Mahajan","display_name":"Amit Mahajan","email":"Amit.Mahajan@windriver.com","username":"amahajan"},"change_message_id":"18886da92c2b7390bd62db12f8dacfe898181059","unresolved":false,"context_lines":[{"line_number":2484,"context_line":"        timeout: 30"},{"line_number":2485,"context_line":"      osapi:"},{"line_number":2486,"context_line":"        timeout: 30"},{"line_number":2487,"context_line":"      compute:"},{"line_number":2488,"context_line":"        timeout: 30"},{"line_number":2489,"context_line":"      conductor:"},{"line_number":2490,"context_line":"        timeout: 30"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7e549dd3_c7e3d31a","line":2487,"in_reply_to":"6305bda7_441162b0","updated":"2026-07-22 15:15:59.000000000","message":"Changed the defaults for all the components to 180s.","commit_id":"3c0dd49b9499cb59fed5c303aef397013e71e494"}]}