)]}'
{"doc/admin-guide-cloud/source/telemetry-data-collection.rst":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1a9e6bbd5f81187befbd788e907e42d848a6c62c","unresolved":false,"context_lines":[{"line_number":633,"context_line":""},{"line_number":634,"context_line":"Meter definitions"},{"line_number":635,"context_line":"-----------------"},{"line_number":636,"context_line":"Meters configuration by default, is stored in separate configuration"},{"line_number":637,"context_line":"files, called :file:`ceilometer/meter/data/meter.yaml` file."},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"A standard meter definition looks like the following::"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da20952f_2da32051","line":636,"updated":"2015-08-27 19:15:06.000000000","message":"I would start this with stating that we now define in a configuration file which meters we are storing as samples from the notifications emitted by other OpenStack services. Also please mention that this was added in the Liberty release as this guide is not versioned.","commit_id":"35c5ea4e4293537ab33dd2568e94652aee3daea9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1a9e6bbd5f81187befbd788e907e42d848a6c62c","unresolved":false,"context_lines":[{"line_number":634,"context_line":"Meter definitions"},{"line_number":635,"context_line":"-----------------"},{"line_number":636,"context_line":"Meters configuration by default, is stored in separate configuration"},{"line_number":637,"context_line":"files, called :file:`ceilometer/meter/data/meter.yaml` file."},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"A standard meter definition looks like the following::"},{"line_number":640,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da20952f_0d597cfe","line":637,"updated":"2015-08-27 19:15:06.000000000","message":"Do we have more files already or we only provide the possibility to have multiple ones?","commit_id":"35c5ea4e4293537ab33dd2568e94652aee3daea9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1a9e6bbd5f81187befbd788e907e42d848a6c62c","unresolved":false,"context_lines":[{"line_number":649,"context_line":"        project_id: \u0027path to project id eg: $.payload.owner\u0027"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"The definition above shows a simple meter definition with some fields."},{"line_number":652,"context_line":"The ``name``, ``event_type``, ``type``, ``unit`` and ``volume`` are require fields."},{"line_number":653,"context_line":"A generic notification handler consumes the notification message and"},{"line_number":654,"context_line":"matches with the meters defined in the `meter.yaml` file. If there"},{"line_number":655,"context_line":"is a match on the event type, samples are generated for the meter."}],"source_content_type":"text/x-rst","patch_set":1,"id":"da20952f_8d826c93","line":652,"updated":"2015-08-27 19:15:06.000000000","message":"... with some fields, from which ``name``, ``event_type``, ``type``, ``unit`` and ``volume`` are required.","commit_id":"35c5ea4e4293537ab33dd2568e94652aee3daea9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1a9e6bbd5f81187befbd788e907e42d848a6c62c","unresolved":false,"context_lines":[{"line_number":651,"context_line":"The definition above shows a simple meter definition with some fields."},{"line_number":652,"context_line":"The ``name``, ``event_type``, ``type``, ``unit`` and ``volume`` are require fields."},{"line_number":653,"context_line":"A generic notification handler consumes the notification message and"},{"line_number":654,"context_line":"matches with the meters defined in the `meter.yaml` file. If there"},{"line_number":655,"context_line":"is a match on the event type, samples are generated for the meter."},{"line_number":656,"context_line":"The values that need to be searched in the notification message are set"},{"line_number":657,"context_line":"with a jsonpath starting with ``$.``. For example, if we need to"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da20952f_cd0dc43f","line":654,"updated":"2015-08-27 19:15:06.000000000","message":"I\u0027m not sure we need to mention in this guide the notification handler.\n\nIs the matching done by the \u0027name\u0027 field?","commit_id":"35c5ea4e4293537ab33dd2568e94652aee3daea9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1a9e6bbd5f81187befbd788e907e42d848a6c62c","unresolved":false,"context_lines":[{"line_number":653,"context_line":"A generic notification handler consumes the notification message and"},{"line_number":654,"context_line":"matches with the meters defined in the `meter.yaml` file. If there"},{"line_number":655,"context_line":"is a match on the event type, samples are generated for the meter."},{"line_number":656,"context_line":"The values that need to be searched in the notification message are set"},{"line_number":657,"context_line":"with a jsonpath starting with ``$.``. For example, if we need to"},{"line_number":658,"context_line":"lookup the volume information from the message, its set as a jsonpath"},{"line_number":659,"context_line":"`$.payload.size\u0027."}],"source_content_type":"text/x-rst","patch_set":1,"id":"da20952f_20cec7b4","line":656,"updated":"2015-08-27 19:15:06.000000000","message":"I would describe this part at least in a separate paragraph.\n\nI would phrase this part somehow like this:\n\nIf you take a look at the `meter.yaml` file it contains the sample definitions for all the meters that Telemetry ise collecting from notifications. The value of each field is specified by using jsonpath in order to find the right value in the notification message. In order to be able to specify the right field you need to be aware of the format of the consumed notification. For instance, if you need the ``size`` information from the payload you can define it like the following::\n\n  $.payload.size","commit_id":"35c5ea4e4293537ab33dd2568e94652aee3daea9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1a9e6bbd5f81187befbd788e907e42d848a6c62c","unresolved":false,"context_lines":[{"line_number":660,"context_line":""},{"line_number":661,"context_line":"There are cases where multiple meters need to be defined in a single"},{"line_number":662,"context_line":"meter definition. The following is the meter definition example"},{"line_number":663,"context_line":"showing how to define multi meters::"},{"line_number":664,"context_line":""},{"line_number":665,"context_line":"    ---"},{"line_number":666,"context_line":"    metric:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"da20952f_40065bcf","line":663,"updated":"2015-08-27 19:15:06.000000000","message":"Suggestion:\n\nThere are cases when a notification message contains multiple meters. You can use \u0027*\u0027 in the metric definition to capture all these meters as samples. You can use wildcards as the below example shows::","commit_id":"35c5ea4e4293537ab33dd2568e94652aee3daea9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1a9e6bbd5f81187befbd788e907e42d848a6c62c","unresolved":false,"context_lines":[{"line_number":676,"context_line":"In the above example, the ``name`` field is a json path with matching"},{"line_number":677,"context_line":"a list of meter names defined in the notification message."},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"More complex operations can be handled with json paths. For example in the"},{"line_number":680,"context_line":"following example, ``volume`` and ``resource_id`` fields perform an arithmetic"},{"line_number":681,"context_line":"and string concatenation::"},{"line_number":682,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da20952f_00270365","line":679,"updated":"2015-08-27 19:15:06.000000000","message":"You can even use complex operations with the help of jsonpath. In the following example ...","commit_id":"35c5ea4e4293537ab33dd2568e94652aee3daea9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1a9e6bbd5f81187befbd788e907e42d848a6c62c","unresolved":false,"context_lines":[{"line_number":692,"context_line":""},{"line_number":693,"context_line":"There are some existence meters defined in the `meter.yaml`. These"},{"line_number":694,"context_line":"meters have a ``volume`` as 1 and are at the bottom of the yaml file"},{"line_number":695,"context_line":"with a note suggesting that these will be deprecated in M release."},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"For example, the meter definition for existence meters is as follows::"},{"line_number":698,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da20952f_20b807e5","line":695,"updated":"2015-08-27 19:15:06.000000000","message":"If I remember correctly we will remove them in M. Also please use Mitaka as release name.","commit_id":"35c5ea4e4293537ab33dd2568e94652aee3daea9"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"1a9e6bbd5f81187befbd788e907e42d848a6c62c","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        project_id: $.payload.tenant_id"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"By default, these meters will not be loaded. To load these meters, flip"},{"line_number":712,"context_line":"the `disable_non_metric_meters` configuration option."},{"line_number":713,"context_line":""},{"line_number":714,"context_line":".. _telemetry-transformers:"},{"line_number":715,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"da20952f_20afa795","line":712,"updated":"2015-08-27 19:15:06.000000000","message":"... option in the ceilometer.conf configuration file.","commit_id":"35c5ea4e4293537ab33dd2568e94652aee3daea9"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"ad328c4967f651dc316f2d2209bbb5876d73a9d3","unresolved":false,"context_lines":[{"line_number":633,"context_line":""},{"line_number":634,"context_line":"Meter definitions"},{"line_number":635,"context_line":"-----------------"},{"line_number":636,"context_line":"Meters definitions by default, are stored in separate configuration"},{"line_number":637,"context_line":"file, called :file:`ceilometer/meter/data/meter.yaml`. This is essentially"},{"line_number":638,"context_line":"a replacement for prior approach of writing notification handlers to consume"},{"line_number":639,"context_line":"specific topics."}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_e3821052","line":636,"updated":"2015-08-27 23:38:07.000000000","message":"By default, meters definitions are stored...\n\nThough it\u0027s better to avoid passive voice if possible.","commit_id":"7af0498b9f03f5237857ba577b28119e382e9990"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"c7d46244d88f493d588c9ba426a17fa218120e68","unresolved":false,"context_lines":[{"line_number":633,"context_line":""},{"line_number":634,"context_line":"Meter definitions"},{"line_number":635,"context_line":"-----------------"},{"line_number":636,"context_line":"Meters definitions by default, are stored in separate configuration"},{"line_number":637,"context_line":"file, called :file:`ceilometer/meter/data/meter.yaml`. This is essentially"},{"line_number":638,"context_line":"a replacement for prior approach of writing notification handlers to consume"},{"line_number":639,"context_line":"specific topics."}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_e4d0d655","line":636,"in_reply_to":"da20952f_e3821052","updated":"2015-08-28 00:58:36.000000000","message":"Try:\n\n\"Store default meter definitions in a separate configuration file, called ...\"","commit_id":"7af0498b9f03f5237857ba577b28119e382e9990"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"c7d46244d88f493d588c9ba426a17fa218120e68","unresolved":false,"context_lines":[{"line_number":635,"context_line":"-----------------"},{"line_number":636,"context_line":"Meters definitions by default, are stored in separate configuration"},{"line_number":637,"context_line":"file, called :file:`ceilometer/meter/data/meter.yaml`. This is essentially"},{"line_number":638,"context_line":"a replacement for prior approach of writing notification handlers to consume"},{"line_number":639,"context_line":"specific topics."},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"A standard meter definition looks like the following::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_84c0fa7d","line":638,"updated":"2015-08-28 00:58:36.000000000","message":"\"This is a replacement for prior...\"","commit_id":"7af0498b9f03f5237857ba577b28119e382e9990"},{"author":{"_account_id":14396,"name":"Alexander Adamov","email":"aadamov@mirantis.com","username":"Alexander"},"change_message_id":"7b39a581e26649a71749fae32df6624ecc081ff2","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        resource_id: \u0027path to resouce id eg: $.payload.id\u0027"},{"line_number":651,"context_line":"        project_id: \u0027path to project id eg: $.payload.owner\u0027"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"The definition above shows a simple meter definition with some fields."},{"line_number":654,"context_line":"The ``name``, ``event_type``, ``type``, ``unit`` and ``volume`` are required"},{"line_number":655,"context_line":"fields. A generic notification handler consumes the notification message and"},{"line_number":656,"context_line":"matches with the meters defined in the `meter.yaml` file. If there"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_1fce595a","line":653,"updated":"2015-08-28 13:23:19.000000000","message":"\"with some fields.\" - does not bring more information here, therefore can be removed","commit_id":"7af0498b9f03f5237857ba577b28119e382e9990"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"ad328c4967f651dc316f2d2209bbb5876d73a9d3","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        project_id: \u0027path to project id eg: $.payload.owner\u0027"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"The definition above shows a simple meter definition with some fields."},{"line_number":654,"context_line":"The ``name``, ``event_type``, ``type``, ``unit`` and ``volume`` are required"},{"line_number":655,"context_line":"fields. A generic notification handler consumes the notification message and"},{"line_number":656,"context_line":"matches with the meters defined in the `meter.yaml` file. If there"},{"line_number":657,"context_line":"is a match on the event type, samples are generated for the meter."}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_03edc424","line":654,"updated":"2015-08-27 23:38:07.000000000","message":"A comma after ``unit``","commit_id":"7af0498b9f03f5237857ba577b28119e382e9990"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"c7d46244d88f493d588c9ba426a17fa218120e68","unresolved":false,"context_lines":[{"line_number":652,"context_line":""},{"line_number":653,"context_line":"The definition above shows a simple meter definition with some fields."},{"line_number":654,"context_line":"The ``name``, ``event_type``, ``type``, ``unit`` and ``volume`` are required"},{"line_number":655,"context_line":"fields. A generic notification handler consumes the notification message and"},{"line_number":656,"context_line":"matches with the meters defined in the `meter.yaml` file. If there"},{"line_number":657,"context_line":"is a match on the event type, samples are generated for the meter."},{"line_number":658,"context_line":"The values that need to be searched in the notification message are set"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_644cc642","line":655,"updated":"2015-08-28 00:58:36.000000000","message":"Passive voice, consider revision","commit_id":"7af0498b9f03f5237857ba577b28119e382e9990"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"ad328c4967f651dc316f2d2209bbb5876d73a9d3","unresolved":false,"context_lines":[{"line_number":653,"context_line":"The definition above shows a simple meter definition with some fields."},{"line_number":654,"context_line":"The ``name``, ``event_type``, ``type``, ``unit`` and ``volume`` are required"},{"line_number":655,"context_line":"fields. A generic notification handler consumes the notification message and"},{"line_number":656,"context_line":"matches with the meters defined in the `meter.yaml` file. If there"},{"line_number":657,"context_line":"is a match on the event type, samples are generated for the meter."},{"line_number":658,"context_line":"The values that need to be searched in the notification message are set"},{"line_number":659,"context_line":"with a jsonpath starting with ``$.``. For example, if we need to"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_03d4e444","line":656,"updated":"2015-08-27 23:38:07.000000000","message":":file:`meter.yaml`","commit_id":"7af0498b9f03f5237857ba577b28119e382e9990"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"ad328c4967f651dc316f2d2209bbb5876d73a9d3","unresolved":false,"context_lines":[{"line_number":656,"context_line":"matches with the meters defined in the `meter.yaml` file. If there"},{"line_number":657,"context_line":"is a match on the event type, samples are generated for the meter."},{"line_number":658,"context_line":"The values that need to be searched in the notification message are set"},{"line_number":659,"context_line":"with a jsonpath starting with ``$.``. For example, if we need to"},{"line_number":660,"context_line":"lookup the volume information from the message, its set as a jsonpath"},{"line_number":661,"context_line":"``$.payload.size``."},{"line_number":662,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_43517cd7","line":659,"updated":"2015-08-27 23:38:07.000000000","message":"Is it jsonpath or json path as in the lines below?","commit_id":"7af0498b9f03f5237857ba577b28119e382e9990"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"ad328c4967f651dc316f2d2209bbb5876d73a9d3","unresolved":false,"context_lines":[{"line_number":657,"context_line":"is a match on the event type, samples are generated for the meter."},{"line_number":658,"context_line":"The values that need to be searched in the notification message are set"},{"line_number":659,"context_line":"with a jsonpath starting with ``$.``. For example, if we need to"},{"line_number":660,"context_line":"lookup the volume information from the message, its set as a jsonpath"},{"line_number":661,"context_line":"``$.payload.size``."},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"There are cases where multiple meters need to be defined in a single"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_a341780d","line":660,"updated":"2015-08-27 23:38:07.000000000","message":"its --\u003e it is","commit_id":"7af0498b9f03f5237857ba577b28119e382e9990"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"c7d46244d88f493d588c9ba426a17fa218120e68","unresolved":false,"context_lines":[{"line_number":660,"context_line":"lookup the volume information from the message, its set as a jsonpath"},{"line_number":661,"context_line":"``$.payload.size``."},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"There are cases where multiple meters need to be defined in a single"},{"line_number":664,"context_line":"meter definition. The following is the meter definition example"},{"line_number":665,"context_line":"showing how to define multi meters::"},{"line_number":666,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_e4b696db","line":663,"updated":"2015-08-28 00:58:36.000000000","message":"Passive voice here too, consider revising :)","commit_id":"7af0498b9f03f5237857ba577b28119e382e9990"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"ad328c4967f651dc316f2d2209bbb5876d73a9d3","unresolved":false,"context_lines":[{"line_number":678,"context_line":"In the above example, the ``name`` field is a json path with matching"},{"line_number":679,"context_line":"a list of meter names defined in the notification message."},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"More complex operations can be handled with json paths. For example in the"},{"line_number":682,"context_line":"following example, ``volume`` and ``resource_id`` fields perform an arithmetic"},{"line_number":683,"context_line":"and string concatenation::"},{"line_number":684,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_03d70424","line":681,"updated":"2015-08-27 23:38:07.000000000","message":"In the example below, ``volume`` and ``resource_id`` fields perform...","commit_id":"7af0498b9f03f5237857ba577b28119e382e9990"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"ad328c4967f651dc316f2d2209bbb5876d73a9d3","unresolved":false,"context_lines":[{"line_number":692,"context_line":"      resource_id: $.payload.host + \"_\" + $.payload.nodename"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"There are some existence meters defined in the `meter.yaml`. These"},{"line_number":696,"context_line":"meters have a ``volume`` as 1 and are at the bottom of the yaml file"},{"line_number":697,"context_line":"with a note suggesting that these will be deprecated in M release."},{"line_number":698,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_8378f42c","line":695,"updated":"2015-08-27 23:38:07.000000000","message":":file:`meter.yaml` file","commit_id":"7af0498b9f03f5237857ba577b28119e382e9990"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"ad328c4967f651dc316f2d2209bbb5876d73a9d3","unresolved":false,"context_lines":[{"line_number":694,"context_line":""},{"line_number":695,"context_line":"There are some existence meters defined in the `meter.yaml`. These"},{"line_number":696,"context_line":"meters have a ``volume`` as 1 and are at the bottom of the yaml file"},{"line_number":697,"context_line":"with a note suggesting that these will be deprecated in M release."},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"For example, the meter definition for existence meters is as follows::"},{"line_number":700,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_a335f846","line":697,"updated":"2015-08-27 23:38:07.000000000","message":"M --\u003e Mitaka","commit_id":"7af0498b9f03f5237857ba577b28119e382e9990"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"ad328c4967f651dc316f2d2209bbb5876d73a9d3","unresolved":false,"context_lines":[{"line_number":710,"context_line":"        user_id: $.payload.user_id"},{"line_number":711,"context_line":"        project_id: $.payload.tenant_id"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"By default, these meters will not be loaded. To load these meters, flip"},{"line_number":714,"context_line":"the `disable_non_metric_meters` configuration option."},{"line_number":715,"context_line":""},{"line_number":716,"context_line":".. _telemetry-transformers:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"da20952f_1e1e7b63","line":713,"updated":"2015-08-27 23:38:07.000000000","message":"These meters are not loaded by default.","commit_id":"7af0498b9f03f5237857ba577b28119e382e9990"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"03747185e875853251dee1b240666215c6ae83bf","unresolved":false,"context_lines":[{"line_number":633,"context_line":""},{"line_number":634,"context_line":"Meter definitions"},{"line_number":635,"context_line":"-----------------"},{"line_number":636,"context_line":"By default, in Liberty release, Meters definitions are stored in a separate"},{"line_number":637,"context_line":"configuration file, called :file:`ceilometer/meter/data/meter.yaml`. This is"},{"line_number":638,"context_line":"a replacement for prior approach of writing notification handlers to consume"},{"line_number":639,"context_line":"specific topics."}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_3d2317a9","line":636,"updated":"2015-08-28 18:22:40.000000000","message":"I would explain this part more from usage point of view. Before this change it was totally hidden for the operators/administrators that how the filtering from notifications is done. So I would start with something like this:\n\nThe Telemetry module collects a subset of the meters by filtering notifications emitted by other OpenStack services. Starting with the Liberty release you can find the meter definitions in a separate configuration file, called :file:`ceilometer/meter/data/meter.yaml`.\n\nI would drop the sentence about the notification handlers, I think that one should go to the Developers guide that lives together with the code.\n\nAlso I think we could add a warning/note here that the file should be modified with care as the collected meters will differ from the list in this docco in case of changes.","commit_id":"2aec02e2b596a5b380eef3faeda5e60d4a70a797"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"03747185e875853251dee1b240666215c6ae83bf","unresolved":false,"context_lines":[{"line_number":657,"context_line":""},{"line_number":658,"context_line":"If you take a look at the :file:`meter.yaml` file it contains the sample"},{"line_number":659,"context_line":"definitions for all the meters that Telemetry is collecting from"},{"line_number":660,"context_line":"notifications. The value of each field is specified by using jsonpath in"},{"line_number":661,"context_line":"order to find the right value from the notification message. In order to be"},{"line_number":662,"context_line":"able to specify the right field you need to be aware of the format of the"},{"line_number":663,"context_line":"consumed notification. The values that need to be searched in the notification"}],"source_content_type":"text/x-rst","patch_set":3,"id":"da20952f_1d3f3388","line":660,"updated":"2015-08-28 18:22:40.000000000","message":"You still use both \u0027jsonpath\u0027 and \u0027json path\u0027 in the docco. Is that intentional?","commit_id":"2aec02e2b596a5b380eef3faeda5e60d4a70a797"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"882e141d6595f9d6fe2ee1104f3c5eb73c1b65e5","unresolved":false,"context_lines":[{"line_number":629,"context_line":""},{"line_number":630,"context_line":"The event filter uses the same filtering logic as the meter pipeline."},{"line_number":631,"context_line":""},{"line_number":632,"context_line":".. _telemetry-meter-definitions:"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"Meter definitions"},{"line_number":635,"context_line":"-----------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da20952f_4f963694","line":632,"updated":"2015-08-29 18:16:58.000000000","message":"I\u0027ve just realized that the placement of this section is not good. Please put it after the \u0027Transformers\u0027 section, because that logically belongs under the \u0027Pipeline configuration\u0027 one and then we can have the \u0027Meter definitions\u0027 on the same level as \u0027Pipeline configuration\u0027.","commit_id":"ff37968d9273e72ad99a375c38209b6ade0b9d29"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"85b1b7f5058498fa7220c4452ac710b7eeeff861","unresolved":false,"context_lines":[{"line_number":642,"context_line":""},{"line_number":643,"context_line":".. note::"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    The :file:`meter.yaml` file should be modified with care. Unless intended"},{"line_number":646,"context_line":"    do not remove any existing meter definitions from the file. Also note, the"},{"line_number":647,"context_line":"    collected meters can differ in some cases from what is referenced in the"},{"line_number":648,"context_line":"    documentation."}],"source_content_type":"text/x-rst","patch_set":5,"id":"da20952f_38f77c5a","line":645,"updated":"2015-08-31 02:50:37.000000000","message":"Please align the \"The\" underneath the \"N\" for note.","commit_id":"ff37968d9273e72ad99a375c38209b6ade0b9d29"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"85b1b7f5058498fa7220c4452ac710b7eeeff861","unresolved":false,"context_lines":[{"line_number":643,"context_line":".. note::"},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    The :file:`meter.yaml` file should be modified with care. Unless intended"},{"line_number":646,"context_line":"    do not remove any existing meter definitions from the file. Also note, the"},{"line_number":647,"context_line":"    collected meters can differ in some cases from what is referenced in the"},{"line_number":648,"context_line":"    documentation."},{"line_number":649,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"da20952f_f364c7b9","line":646,"updated":"2015-08-31 02:50:37.000000000","message":"\"Also, the collected...\" - no need for \u0027note\u0027 here","commit_id":"ff37968d9273e72ad99a375c38209b6ade0b9d29"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"85b1b7f5058498fa7220c4452ac710b7eeeff861","unresolved":false,"context_lines":[{"line_number":661,"context_line":""},{"line_number":662,"context_line":"The definition above shows a simple meter definition with some fields,"},{"line_number":663,"context_line":"from which ``name``, ``event_type``, ``type``, ``unit``, and ``volume``"},{"line_number":664,"context_line":"are required.If there is a match on the event type, samples are generated"},{"line_number":665,"context_line":"for the meter."},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"If you take a look at the :file:`meter.yaml` file it contains the sample"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da20952f_33679fb8","line":664,"updated":"2015-08-31 02:50:37.000000000","message":"Space needed between \u0027required\u0027 and \u0027if\u0027","commit_id":"ff37968d9273e72ad99a375c38209b6ade0b9d29"},{"author":{"_account_id":14643,"name":"Olga Gusarenko","email":"ogusarenko@mirantis.com","username":"Olga"},"change_message_id":"12b6cf200e9c8bc7875cd4ddf587d06ca60801ca","unresolved":false,"context_lines":[{"line_number":664,"context_line":"are required.If there is a match on the event type, samples are generated"},{"line_number":665,"context_line":"for the meter."},{"line_number":666,"context_line":""},{"line_number":667,"context_line":"If you take a look at the :file:`meter.yaml` file it contains the sample"},{"line_number":668,"context_line":"definitions for all the meters that Telemetry is collecting from"},{"line_number":669,"context_line":"notifications. The value of each field is specified by using json path in"},{"line_number":670,"context_line":"order to find the right value from the notification message. In order to be"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da20952f_bcd05b20","line":667,"updated":"2015-08-31 06:24:24.000000000","message":"f you take a look at the :file:`meter.yaml` file, it contains ... --\u003e comma before \"it\"","commit_id":"ff37968d9273e72ad99a375c38209b6ade0b9d29"},{"author":{"_account_id":14643,"name":"Olga Gusarenko","email":"ogusarenko@mirantis.com","username":"Olga"},"change_message_id":"12b6cf200e9c8bc7875cd4ddf587d06ca60801ca","unresolved":false,"context_lines":[{"line_number":672,"context_line":"consumed notification. The values that need to be searched in the notification"},{"line_number":673,"context_line":"message are set with a json path starting with ``$.`` For instance, if you need"},{"line_number":674,"context_line":"the ``size`` information from the payload you can define it like the"},{"line_number":675,"context_line":"following::"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    ``$.payload.size``"},{"line_number":678,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"da20952f_bc04db49","line":675,"updated":"2015-08-31 06:24:24.000000000","message":"Do we need a separate code-block here? As far as I understand, this is an illustration of how to define some values in the meter definition. If so, you can use only inline markup here:\n\n..., you can define it like ``$.payload.size``.","commit_id":"ff37968d9273e72ad99a375c38209b6ade0b9d29"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"882e141d6595f9d6fe2ee1104f3c5eb73c1b65e5","unresolved":false,"context_lines":[{"line_number":674,"context_line":"the ``size`` information from the payload you can define it like the"},{"line_number":675,"context_line":"following::"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    ``$.payload.size``"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"You might see cases where notification message contains multiple meters."},{"line_number":680,"context_line":"You can use ``*`` in the meter definition to capture all the meters and"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da20952f_cff00601","line":677,"updated":"2015-08-29 18:16:58.000000000","message":"I think you can remove \u0027``\u0027 as it does not work as formatting in the example block.","commit_id":"ff37968d9273e72ad99a375c38209b6ade0b9d29"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"85b1b7f5058498fa7220c4452ac710b7eeeff861","unresolved":false,"context_lines":[{"line_number":674,"context_line":"the ``size`` information from the payload you can define it like the"},{"line_number":675,"context_line":"following::"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    ``$.payload.size``"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"You might see cases where notification message contains multiple meters."},{"line_number":680,"context_line":"You can use ``*`` in the meter definition to capture all the meters and"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da20952f_73f8b7c3","line":677,"in_reply_to":"da20952f_cff00601","updated":"2015-08-31 02:50:37.000000000","message":"Yes, please remove the backslashes here.\nIt would be better if you could please remove the :: after following and do:\n\n.. code-block:: console\n   $.payload.size","commit_id":"ff37968d9273e72ad99a375c38209b6ade0b9d29"},{"author":{"_account_id":14396,"name":"Alexander Adamov","email":"aadamov@mirantis.com","username":"Alexander"},"change_message_id":"692da81f4f30591cbc9a386f505f891609bd83d8","unresolved":false,"context_lines":[{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    ``$.payload.size``"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":"You might see cases where notification message contains multiple meters."},{"line_number":680,"context_line":"You can use ``*`` in the meter definition to capture all the meters and"},{"line_number":681,"context_line":"generate samples respectively. You can use wild cards as shown in the"},{"line_number":682,"context_line":"following example::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da20952f_e4e37fd7","line":679,"updated":"2015-08-31 16:27:02.000000000","message":"A notification message may contain multiple meters.","commit_id":"ff37968d9273e72ad99a375c38209b6ade0b9d29"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"85b1b7f5058498fa7220c4452ac710b7eeeff861","unresolved":false,"context_lines":[{"line_number":709,"context_line":"      resource_id: $.payload.host + \"_\" + $.payload.nodename"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"There are some existence meters defined in the :file:`meter.yaml`. These"},{"line_number":713,"context_line":"meters have a ``volume`` as 1 and are at the bottom of the yaml file"},{"line_number":714,"context_line":"with a note suggesting that these will be removed in Mitaka release."},{"line_number":715,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"da20952f_53e9f3e4","line":712,"updated":"2015-08-31 02:50:37.000000000","message":"Passive voice, consider revision \n\n\"You will find some existence meters in the :file\"...\"","commit_id":"ff37968d9273e72ad99a375c38209b6ade0b9d29"},{"author":{"_account_id":14643,"name":"Olga Gusarenko","email":"ogusarenko@mirantis.com","username":"Olga"},"change_message_id":"12b6cf200e9c8bc7875cd4ddf587d06ca60801ca","unresolved":false,"context_lines":[{"line_number":710,"context_line":""},{"line_number":711,"context_line":""},{"line_number":712,"context_line":"There are some existence meters defined in the :file:`meter.yaml`. These"},{"line_number":713,"context_line":"meters have a ``volume`` as 1 and are at the bottom of the yaml file"},{"line_number":714,"context_line":"with a note suggesting that these will be removed in Mitaka release."},{"line_number":715,"context_line":""},{"line_number":716,"context_line":"For example, the meter definition for existence meters is as follows::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da20952f_dcc98f5a","line":713,"updated":"2015-08-31 06:24:24.000000000","message":"``1``  --\u003e as it is a value please wrap it in backticks","commit_id":"ff37968d9273e72ad99a375c38209b6ade0b9d29"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"85b1b7f5058498fa7220c4452ac710b7eeeff861","unresolved":false,"context_lines":[{"line_number":728,"context_line":"        project_id: $.payload.tenant_id"},{"line_number":729,"context_line":""},{"line_number":730,"context_line":"These meters are not loaded by default. To load these meters, flip"},{"line_number":731,"context_line":"the `disable_non_metric_meters` option in the ceilometer.conf"},{"line_number":732,"context_line":"configuration file."},{"line_number":733,"context_line":""},{"line_number":734,"context_line":".. _telemetry-transformers:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da20952f_13effbe9","line":731,"updated":"2015-08-31 02:50:37.000000000","message":":file:`ceilometer.conf`","commit_id":"ff37968d9273e72ad99a375c38209b6ade0b9d29"},{"author":{"_account_id":14643,"name":"Olga Gusarenko","email":"ogusarenko@mirantis.com","username":"Olga"},"change_message_id":"12b6cf200e9c8bc7875cd4ddf587d06ca60801ca","unresolved":false,"context_lines":[{"line_number":730,"context_line":"These meters are not loaded by default. To load these meters, flip"},{"line_number":731,"context_line":"the `disable_non_metric_meters` option in the ceilometer.conf"},{"line_number":732,"context_line":"configuration file."},{"line_number":733,"context_line":""},{"line_number":734,"context_line":".. _telemetry-transformers:"},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"Transformers"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da20952f_3c068b86","line":733,"updated":"2015-08-31 06:24:24.000000000","message":"this should read --\u003e the :file:`ceilometer.conf` file (remove \"configuration\")","commit_id":"ff37968d9273e72ad99a375c38209b6ade0b9d29"}]}