)]}'
{"doc/networking-guide/source/adv_config_qos.rst":[{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"36e8f569749d4905e73bf9d8e8c15b1ad4dce6a6","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The purpose of this page is to describe how the features and"},{"line_number":6,"context_line":"functionality available in OpenStack (using neutron networking) as of"},{"line_number":7,"context_line":"the Liberty release. It is intended to serve as a guide for how to use QoS"},{"line_number":8,"context_line":"functionality."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"In the network jargon QoS (Quality of Service) is about limiting, prioritizing"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_33c6c668","line":7,"updated":"2015-09-17 02:08:32.000000000","message":"Expand QoS here, not below. First reference to the acronym should be expanded (as in Aditi\u0027s suggestion below)","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"39eaf3f66a809939b62abec136ab5a926f852d4f","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"The purpose of this page is to describe how the features and"},{"line_number":6,"context_line":"functionality available in OpenStack (using neutron networking) as of"},{"line_number":7,"context_line":"the Liberty release. It is intended to serve as a guide for how to use QoS"},{"line_number":8,"context_line":"functionality."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"In the network jargon QoS (Quality of Service) is about limiting, prioritizing"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_91ac3c8d","line":7,"in_reply_to":"ba15a1d1_33c6c668","updated":"2015-09-17 22:01:46.000000000","message":"Done","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":17096,"name":"Aditi Rajagopal","email":"arajagopal@us.ibm.com","username":"aditirajagopal"},"change_message_id":"52fdfd94428f33f75b40b127b750ee39c987b273","unresolved":false,"context_lines":[{"line_number":5,"context_line":"The purpose of this page is to describe how the features and"},{"line_number":6,"context_line":"functionality available in OpenStack (using neutron networking) as of"},{"line_number":7,"context_line":"the Liberty release. It is intended to serve as a guide for how to use QoS"},{"line_number":8,"context_line":"functionality."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"In the network jargon QoS (Quality of Service) is about limiting, prioritizing"},{"line_number":11,"context_line":"or guaranteeing speed of traffic, in this case, on neutron ports."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_24e1ad9a","line":8,"updated":"2015-09-16 19:37:33.000000000","message":"I think this portion should be simplified \u0026 reworded...here is a suggestion:\n\n\"This page serves as a guide for how to use the \"Quality of Service\" (QoS) functionality of OpenStack Neutron Networking\"","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"39eaf3f66a809939b62abec136ab5a926f852d4f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"The purpose of this page is to describe how the features and"},{"line_number":6,"context_line":"functionality available in OpenStack (using neutron networking) as of"},{"line_number":7,"context_line":"the Liberty release. It is intended to serve as a guide for how to use QoS"},{"line_number":8,"context_line":"functionality."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"In the network jargon QoS (Quality of Service) is about limiting, prioritizing"},{"line_number":11,"context_line":"or guaranteeing speed of traffic, in this case, on neutron ports."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_51b9c4ca","line":8,"in_reply_to":"ba15a1d1_24e1ad9a","updated":"2015-09-17 22:01:46.000000000","message":"Done","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"36e8f569749d4905e73bf9d8e8c15b1ad4dce6a6","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"In the network jargon QoS (Quality of Service) is about limiting, prioritizing"},{"line_number":11,"context_line":"or guaranteeing speed of traffic, in this case, on neutron ports."},{"line_number":12,"context_line":"For example we could mark traffic to be handled with higher priority"},{"line_number":13,"context_line":"by switches/routers (IP/VLAN headers), or we may want to set minimum or maximum"},{"line_number":14,"context_line":"bandwidth constraints on certain types of traffic (realtime traffic needs"},{"line_number":15,"context_line":"to be processed with higher priority: Voice over IP, streaming, ..., to reduce"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_33ab2677","line":12,"updated":"2015-09-17 02:08:32.000000000","message":"Remove the passive voice here","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"39eaf3f66a809939b62abec136ab5a926f852d4f","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"In the network jargon QoS (Quality of Service) is about limiting, prioritizing"},{"line_number":11,"context_line":"or guaranteeing speed of traffic, in this case, on neutron ports."},{"line_number":12,"context_line":"For example we could mark traffic to be handled with higher priority"},{"line_number":13,"context_line":"by switches/routers (IP/VLAN headers), or we may want to set minimum or maximum"},{"line_number":14,"context_line":"bandwidth constraints on certain types of traffic (realtime traffic needs"},{"line_number":15,"context_line":"to be processed with higher priority: Voice over IP, streaming, ..., to reduce"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_fc946f8b","line":12,"in_reply_to":"ba15a1d1_33ab2677","updated":"2015-09-17 22:01:46.000000000","message":"Done","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"36e8f569749d4905e73bf9d8e8c15b1ad4dce6a6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"For example we could mark traffic to be handled with higher priority"},{"line_number":13,"context_line":"by switches/routers (IP/VLAN headers), or we may want to set minimum or maximum"},{"line_number":14,"context_line":"bandwidth constraints on certain types of traffic (realtime traffic needs"},{"line_number":15,"context_line":"to be processed with higher priority: Voice over IP, streaming, ..., to reduce"},{"line_number":16,"context_line":"latency), or the administrator of a cloud may want to offer different service levels"},{"line_number":17,"context_line":"based on the available network bandwidth."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_b3adf685","line":15,"updated":"2015-09-17 02:08:32.000000000","message":"Is this to be filled in?","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"39eaf3f66a809939b62abec136ab5a926f852d4f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"For example we could mark traffic to be handled with higher priority"},{"line_number":13,"context_line":"by switches/routers (IP/VLAN headers), or we may want to set minimum or maximum"},{"line_number":14,"context_line":"bandwidth constraints on certain types of traffic (realtime traffic needs"},{"line_number":15,"context_line":"to be processed with higher priority: Voice over IP, streaming, ..., to reduce"},{"line_number":16,"context_line":"latency), or the administrator of a cloud may want to offer different service levels"},{"line_number":17,"context_line":"based on the available network bandwidth."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_7cefff1d","line":15,"in_reply_to":"ba15a1d1_b3adf685","updated":"2015-09-17 22:01:46.000000000","message":"I have rewritten this whole paragraph. let me know if the new version is better.","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":17096,"name":"Aditi Rajagopal","email":"arajagopal@us.ibm.com","username":"aditirajagopal"},"change_message_id":"52fdfd94428f33f75b40b127b750ee39c987b273","unresolved":false,"context_lines":[{"line_number":14,"context_line":"bandwidth constraints on certain types of traffic (realtime traffic needs"},{"line_number":15,"context_line":"to be processed with higher priority: Voice over IP, streaming, ..., to reduce"},{"line_number":16,"context_line":"latency), or the administrator of a cloud may want to offer different service levels"},{"line_number":17,"context_line":"based on the available network bandwidth."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The basics"},{"line_number":20,"context_line":"~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_8410b95a","line":17,"updated":"2015-09-16 19:37:33.000000000","message":"Here is another proposed rewrite/reorganization. \n\nNeutron Quality of Service (QoS), refers to limiting, prioritizing, or guaranteeing traffic management on neutron ports. As a cloud administrator, here are some examples on how Neutron QoS can be used:\n\n* We can mark traffic to be handled with higher priority by switches.routers (IP/VPAN headers)\n* We can set the minimum/maximum bandwidth constraints on certain types of traffic (realtime traffic needs to be processed with higher priority: Voice over IP, streaming, ...., to reduce latency)\n* We can offer different service levels based on the available bandwidth","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"39eaf3f66a809939b62abec136ab5a926f852d4f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"bandwidth constraints on certain types of traffic (realtime traffic needs"},{"line_number":15,"context_line":"to be processed with higher priority: Voice over IP, streaming, ..., to reduce"},{"line_number":16,"context_line":"latency), or the administrator of a cloud may want to offer different service levels"},{"line_number":17,"context_line":"based on the available network bandwidth."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The basics"},{"line_number":20,"context_line":"~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_3cf507ec","line":17,"in_reply_to":"ba15a1d1_8410b95a","updated":"2015-09-17 22:01:46.000000000","message":"I have rewritten this whole paragraph. let me know if the new version is better.\nIf not I can use this option.","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"36e8f569749d4905e73bf9d8e8c15b1ad4dce6a6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"The basics"},{"line_number":20,"context_line":"~~~~~~~~~~"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Quality of Service advanced service is designed as a service plugin. The"},{"line_number":23,"context_line":"service is decoupled from the rest of Neutron code on multiple levels."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"QoS extends core resources (ports, networks) without using mixins inherited"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_73cc3e6a","line":22,"updated":"2015-09-17 02:08:32.000000000","message":"You can use QoS here","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"39eaf3f66a809939b62abec136ab5a926f852d4f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"The basics"},{"line_number":20,"context_line":"~~~~~~~~~~"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Quality of Service advanced service is designed as a service plugin. The"},{"line_number":23,"context_line":"service is decoupled from the rest of Neutron code on multiple levels."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"QoS extends core resources (ports, networks) without using mixins inherited"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_3c5ae7f2","line":22,"in_reply_to":"ba15a1d1_73cc3e6a","updated":"2015-09-17 22:01:46.000000000","message":"Done","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":17096,"name":"Aditi Rajagopal","email":"arajagopal@us.ibm.com","username":"aditirajagopal"},"change_message_id":"52fdfd94428f33f75b40b127b750ee39c987b273","unresolved":false,"context_lines":[{"line_number":20,"context_line":"~~~~~~~~~~"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Quality of Service advanced service is designed as a service plugin. The"},{"line_number":23,"context_line":"service is decoupled from the rest of Neutron code on multiple levels."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"QoS extends core resources (ports, networks) without using mixins inherited"},{"line_number":26,"context_line":"from plugins but through an ml2 extension driver."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_776c35d0","line":23,"updated":"2015-09-16 19:37:33.000000000","message":"I think this can be simiplified to the following:\n\n\"Quality of Service (QoS) is an advance service plugin. QoS is decoupled from the rest of the Neutron code on multiple levels\"","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"39eaf3f66a809939b62abec136ab5a926f852d4f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"~~~~~~~~~~"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Quality of Service advanced service is designed as a service plugin. The"},{"line_number":23,"context_line":"service is decoupled from the rest of Neutron code on multiple levels."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"QoS extends core resources (ports, networks) without using mixins inherited"},{"line_number":26,"context_line":"from plugins but through an ml2 extension driver."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_3c118704","line":23,"in_reply_to":"ba15a1d1_776c35d0","updated":"2015-09-17 22:01:46.000000000","message":"I like it! Thanks!","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"36e8f569749d4905e73bf9d8e8c15b1ad4dce6a6","unresolved":false,"context_lines":[{"line_number":23,"context_line":"service is decoupled from the rest of Neutron code on multiple levels."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"QoS extends core resources (ports, networks) without using mixins inherited"},{"line_number":26,"context_line":"from plugins but through an ml2 extension driver."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Details about the DB models, API extension, and use cases can be found"},{"line_number":29,"context_line":"here: `qos spec \u003chttp://specs.openstack.org/openstack/neutron-specs/specs/liberty/qos-api-extension.html\u003e`"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_13e4e2de","line":26,"updated":"2015-09-17 02:08:32.000000000","message":"Is this meant to be a capital \u0027M\u002712?","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"39eaf3f66a809939b62abec136ab5a926f852d4f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"service is decoupled from the rest of Neutron code on multiple levels."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"QoS extends core resources (ports, networks) without using mixins inherited"},{"line_number":26,"context_line":"from plugins but through an ml2 extension driver."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Details about the DB models, API extension, and use cases can be found"},{"line_number":29,"context_line":"here: `qos spec \u003chttp://specs.openstack.org/openstack/neutron-specs/specs/liberty/qos-api-extension.html\u003e`"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_5c2f9b3e","line":26,"in_reply_to":"ba15a1d1_13e4e2de","updated":"2015-09-17 22:01:46.000000000","message":"no, it has to be ml2 with is the name of the extension driver.","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"4bade015ee5f9f8ecb8bafa218361140389f992b","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Things not in the scope of this document include:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* This is a placeholder"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Supported QoS rule types"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_8e8a1d1a","line":37,"updated":"2015-09-16 17:02:58.000000000","message":"Guess this patch is still a WIP?","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"39eaf3f66a809939b62abec136ab5a926f852d4f","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Things not in the scope of this document include:"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"* This is a placeholder"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Supported QoS rule types"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_7c329fa8","line":37,"in_reply_to":"ba15a1d1_8e8a1d1a","updated":"2015-09-17 22:01:46.000000000","message":"Yes, Ajo will add more details.","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"36e8f569749d4905e73bf9d8e8c15b1ad4dce6a6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Supported QoS rule types"},{"line_number":41,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Any plugin or Ml2 mechanism driver can claim support for some QoS rule types by"},{"line_number":44,"context_line":"providing a plugin/driver class property called \u0027supported_qos_rule_types\u0027 that"},{"line_number":45,"context_line":"should return a list of strings that correspond to QoS rule types (for the list"},{"line_number":46,"context_line":"of all rule types, see: neutron.extensions.qos.VALID_RULE_TYPES)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_73d3de04","line":43,"updated":"2015-09-17 02:08:32.000000000","message":"Capital M or lowercase?","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"39eaf3f66a809939b62abec136ab5a926f852d4f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"Supported QoS rule types"},{"line_number":41,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Any plugin or Ml2 mechanism driver can claim support for some QoS rule types by"},{"line_number":44,"context_line":"providing a plugin/driver class property called \u0027supported_qos_rule_types\u0027 that"},{"line_number":45,"context_line":"should return a list of strings that correspond to QoS rule types (for the list"},{"line_number":46,"context_line":"of all rule types, see: neutron.extensions.qos.VALID_RULE_TYPES)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_3c28a732","line":43,"in_reply_to":"ba15a1d1_73d3de04","updated":"2015-09-17 22:01:46.000000000","message":"Good catch!  :-)","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"36e8f569749d4905e73bf9d8e8c15b1ad4dce6a6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Any plugin or Ml2 mechanism driver can claim support for some QoS rule types by"},{"line_number":44,"context_line":"providing a plugin/driver class property called \u0027supported_qos_rule_types\u0027 that"},{"line_number":45,"context_line":"should return a list of strings that correspond to QoS rule types (for the list"},{"line_number":46,"context_line":"of all rule types, see: neutron.extensions.qos.VALID_RULE_TYPES)."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"In the most simple case, the property can be represented by a simple Python"},{"line_number":49,"context_line":"list defined on the class."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_130b828f","line":46,"updated":"2015-09-17 02:08:32.000000000","message":"Is this meant to be a link to another page?","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"39eaf3f66a809939b62abec136ab5a926f852d4f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"Any plugin or Ml2 mechanism driver can claim support for some QoS rule types by"},{"line_number":44,"context_line":"providing a plugin/driver class property called \u0027supported_qos_rule_types\u0027 that"},{"line_number":45,"context_line":"should return a list of strings that correspond to QoS rule types (for the list"},{"line_number":46,"context_line":"of all rule types, see: neutron.extensions.qos.VALID_RULE_TYPES)."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"In the most simple case, the property can be represented by a simple Python"},{"line_number":49,"context_line":"list defined on the class."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_dc23ab54","line":46,"in_reply_to":"ba15a1d1_130b828f","updated":"2015-09-17 22:01:46.000000000","message":"No, it is a section of the code.. I will fix it.","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"36e8f569749d4905e73bf9d8e8c15b1ad4dce6a6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"For Ml2 plugin, the list of supported QoS rule types is defined as a common"},{"line_number":52,"context_line":"subset of rules supported by all active mechanism drivers."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Note: the list of supported rule types reported by core plugin is not enforced"},{"line_number":55,"context_line":"when accessing QoS rule resources. This is mostly because then we would not be"},{"line_number":56,"context_line":"able to create any rules while at least one ml2 driver in gate lacks support"},{"line_number":57,"context_line":"for QoS (at the moment of writing, linuxbridge is such a driver)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_d300aa68","line":54,"updated":"2015-09-17 02:08:32.000000000","message":".. note::\n   The list of supported... \u003c- passive voice","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"39eaf3f66a809939b62abec136ab5a926f852d4f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"For Ml2 plugin, the list of supported QoS rule types is defined as a common"},{"line_number":52,"context_line":"subset of rules supported by all active mechanism drivers."},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Note: the list of supported rule types reported by core plugin is not enforced"},{"line_number":55,"context_line":"when accessing QoS rule resources. This is mostly because then we would not be"},{"line_number":56,"context_line":"able to create any rules while at least one ml2 driver in gate lacks support"},{"line_number":57,"context_line":"for QoS (at the moment of writing, linuxbridge is such a driver)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_7ce37fd9","line":54,"in_reply_to":"ba15a1d1_d300aa68","updated":"2015-09-17 22:01:46.000000000","message":"I find it hard to not use passive voice here.. any suggestions?","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"36e8f569749d4905e73bf9d8e8c15b1ad4dce6a6","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Note: the list of supported rule types reported by core plugin is not enforced"},{"line_number":55,"context_line":"when accessing QoS rule resources. This is mostly because then we would not be"},{"line_number":56,"context_line":"able to create any rules while at least one ml2 driver in gate lacks support"},{"line_number":57,"context_line":"for QoS (at the moment of writing, linuxbridge is such a driver)."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_93f7928a","line":56,"updated":"2015-09-17 02:08:32.000000000","message":"Lowercase or uppercase M?","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"39eaf3f66a809939b62abec136ab5a926f852d4f","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Note: the list of supported rule types reported by core plugin is not enforced"},{"line_number":55,"context_line":"when accessing QoS rule resources. This is mostly because then we would not be"},{"line_number":56,"context_line":"able to create any rules while at least one ml2 driver in gate lacks support"},{"line_number":57,"context_line":"for QoS (at the moment of writing, linuxbridge is such a driver)."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_fc930f59","line":56,"in_reply_to":"ba15a1d1_93f7928a","updated":"2015-09-17 22:01:46.000000000","message":"Done","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"36e8f569749d4905e73bf9d8e8c15b1ad4dce6a6","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"On server side:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* enable qos service in service_plugins;"},{"line_number":68,"context_line":"* set the needed notification_drivers in [qos] section (message_queue is the default);"},{"line_number":69,"context_line":"* for ml2, add \u0027qos\u0027 to extension_drivers in [ml2] section."},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_1332a25f","line":67,"updated":"2015-09-17 02:08:32.000000000","message":"Capitals for the start of each of these sentences, and no need for the semi-colon at the end of each line","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"39eaf3f66a809939b62abec136ab5a926f852d4f","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"On server side:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* enable qos service in service_plugins;"},{"line_number":68,"context_line":"* set the needed notification_drivers in [qos] section (message_queue is the default);"},{"line_number":69,"context_line":"* for ml2, add \u0027qos\u0027 to extension_drivers in [ml2] section."},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_1cb3630b","line":67,"in_reply_to":"ba15a1d1_1332a25f","updated":"2015-09-17 22:01:46.000000000","message":"Done","commit_id":"1da99eaaae4739b007de294bd0bd90ff8fdb39db"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"2f1a3f0102de6b69ca8c482e7062f15a586834fc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Things not in the scope of this document include:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"* This is a placeholder"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ba15a1d1_687ababe","line":35,"updated":"2015-09-18 17:01:17.000000000","message":"I am just going to remove this section, It seems that we have nothing to include here.","commit_id":"9622de7e155bf422fa1d751b37b9ab05b76b0090"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"c553ab70581570e21997c059c2ea464c5ef764e1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"functionality of OpenStack Neutron Networking"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"In the network jargon QoS is about limiting, prioritizing or guaranteeing"},{"line_number":9,"context_line":"speed of traffic, in this case, on neutron ports."},{"line_number":10,"context_line":"For instance, network switches and routers can mark traffic in order to be"},{"line_number":11,"context_line":"handled with higher priority. Certain network traffic such as Voice over IP"},{"line_number":12,"context_line":"and video streaming requires to be transmitted with minimal bandwidth"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_8d8f07cc","line":9,"updated":"2015-09-20 06:01:13.000000000","message":"QoS is not only about speed. It\u0027s about bandwidth, latency, jitter and reliability.","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"functionality of OpenStack Neutron Networking"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"In the network jargon QoS is about limiting, prioritizing or guaranteeing"},{"line_number":9,"context_line":"speed of traffic, in this case, on neutron ports."},{"line_number":10,"context_line":"For instance, network switches and routers can mark traffic in order to be"},{"line_number":11,"context_line":"handled with higher priority. Certain network traffic such as Voice over IP"},{"line_number":12,"context_line":"and video streaming requires to be transmitted with minimal bandwidth"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_037078db","line":9,"in_reply_to":"ba15a1d1_8d8f07cc","updated":"2015-09-21 22:27:41.000000000","message":"re-writing this part","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ab7b07a930c9e1e92eada77d4f44a338429e5e2f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"For instance, network switches and routers can mark traffic in order to be"},{"line_number":11,"context_line":"handled with higher priority. Certain network traffic such as Voice over IP"},{"line_number":12,"context_line":"and video streaming requires to be transmitted with minimal bandwidth"},{"line_number":13,"context_line":"constraints. A system without network QoS configuration, all traffic is"},{"line_number":14,"context_line":"transmitted on a \"best-effort\" manner making impossible to guaranteed a"},{"line_number":15,"context_line":"service level agreement with the final users."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_fa01853a","line":13,"updated":"2015-09-21 11:21:27.000000000","message":"On a system..","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"For instance, network switches and routers can mark traffic in order to be"},{"line_number":11,"context_line":"handled with higher priority. Certain network traffic such as Voice over IP"},{"line_number":12,"context_line":"and video streaming requires to be transmitted with minimal bandwidth"},{"line_number":13,"context_line":"constraints. A system without network QoS configuration, all traffic is"},{"line_number":14,"context_line":"transmitted on a \"best-effort\" manner making impossible to guaranteed a"},{"line_number":15,"context_line":"service level agreement with the final users."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_2f88fd21","line":13,"in_reply_to":"ba15a1d1_fa01853a","updated":"2015-09-21 22:27:41.000000000","message":"Done","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ab7b07a930c9e1e92eada77d4f44a338429e5e2f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"handled with higher priority. Certain network traffic such as Voice over IP"},{"line_number":12,"context_line":"and video streaming requires to be transmitted with minimal bandwidth"},{"line_number":13,"context_line":"constraints. A system without network QoS configuration, all traffic is"},{"line_number":14,"context_line":"transmitted on a \"best-effort\" manner making impossible to guaranteed a"},{"line_number":15,"context_line":"service level agreement with the final users."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_bafb0d47","line":14,"updated":"2015-09-21 11:21:27.000000000","message":"on -\u003e in, guarantee","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"handled with higher priority. Certain network traffic such as Voice over IP"},{"line_number":12,"context_line":"and video streaming requires to be transmitted with minimal bandwidth"},{"line_number":13,"context_line":"constraints. A system without network QoS configuration, all traffic is"},{"line_number":14,"context_line":"transmitted on a \"best-effort\" manner making impossible to guaranteed a"},{"line_number":15,"context_line":"service level agreement with the final users."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_0f85f905","line":14,"in_reply_to":"ba15a1d1_bafb0d47","updated":"2015-09-21 22:27:41.000000000","message":"Done","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ab7b07a930c9e1e92eada77d4f44a338429e5e2f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"and video streaming requires to be transmitted with minimal bandwidth"},{"line_number":13,"context_line":"constraints. A system without network QoS configuration, all traffic is"},{"line_number":14,"context_line":"transmitted on a \"best-effort\" manner making impossible to guaranteed a"},{"line_number":15,"context_line":"service level agreement with the final users."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The basics"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_9a996922","line":15,"updated":"2015-09-21 11:21:27.000000000","message":"the final users -\u003e final users","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"and video streaming requires to be transmitted with minimal bandwidth"},{"line_number":13,"context_line":"constraints. A system without network QoS configuration, all traffic is"},{"line_number":14,"context_line":"transmitted on a \"best-effort\" manner making impossible to guaranteed a"},{"line_number":15,"context_line":"service level agreement with the final users."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The basics"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_4f92114d","line":15,"in_reply_to":"ba15a1d1_9a996922","updated":"2015-09-21 22:27:41.000000000","message":"Done","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"c553ab70581570e21997c059c2ea464c5ef764e1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"The basics"},{"line_number":19,"context_line":"----------"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Quality of Service (QoS) is an advance service plugin. QoS is decoupled"},{"line_number":22,"context_line":"from the rest of the Neutron code on multiple levels."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"QoS extends core resources (ports, networks) without using mixins inherited"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_2dbb5b77","line":21,"updated":"2015-09-20 06:01:13.000000000","message":"advance\u003d\u003eadvanced","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"The basics"},{"line_number":19,"context_line":"----------"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Quality of Service (QoS) is an advance service plugin. QoS is decoupled"},{"line_number":22,"context_line":"from the rest of the Neutron code on multiple levels."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"QoS extends core resources (ports, networks) without using mixins inherited"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_ef98c56c","line":21,"in_reply_to":"ba15a1d1_2dbb5b77","updated":"2015-09-21 22:27:41.000000000","message":"Done","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ab7b07a930c9e1e92eada77d4f44a338429e5e2f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Quality of Service (QoS) is an advance service plugin. QoS is decoupled"},{"line_number":22,"context_line":"from the rest of the Neutron code on multiple levels."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"QoS extends core resources (ports, networks) without using mixins inherited"},{"line_number":25,"context_line":"from plugins but through an ml2 extension driver."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Details about the DB models, API extension, and use cases can be found"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_9a1c0979","line":24,"updated":"2015-09-21 11:21:27.000000000","message":"Am I still reading the user guide?.. Why those dev only details here? I believe next section is also mostly irrelevant.","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":21,"context_line":"Quality of Service (QoS) is an advance service plugin. QoS is decoupled"},{"line_number":22,"context_line":"from the rest of the Neutron code on multiple levels."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"QoS extends core resources (ports, networks) without using mixins inherited"},{"line_number":25,"context_line":"from plugins but through an ml2 extension driver."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Details about the DB models, API extension, and use cases can be found"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_4fb9b1ca","line":24,"in_reply_to":"ba15a1d1_9a1c0979","updated":"2015-09-21 22:27:41.000000000","message":"The networking guide should provide as many details as possible on this area. It will help to Operators to understand why and how","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"c553ab70581570e21997c059c2ea464c5ef764e1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from the rest of the Neutron code on multiple levels."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"QoS extends core resources (ports, networks) without using mixins inherited"},{"line_number":25,"context_line":"from plugins but through an ml2 extension driver."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Details about the DB models, API extension, and use cases can be found"},{"line_number":28,"context_line":"here: `qos spec \u003chttp://specs.openstack.org/openstack/neutron-specs/specs/liberty/qos-api-extension.html\u003e`"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_4dc00fe1","line":25,"updated":"2015-09-20 06:01:13.000000000","message":"from\u003d\u003eby","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from the rest of the Neutron code on multiple levels."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"QoS extends core resources (ports, networks) without using mixins inherited"},{"line_number":25,"context_line":"from plugins but through an ml2 extension driver."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Details about the DB models, API extension, and use cases can be found"},{"line_number":28,"context_line":"here: `qos spec \u003chttp://specs.openstack.org/openstack/neutron-specs/specs/liberty/qos-api-extension.html\u003e`"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_aff88d7d","line":25,"in_reply_to":"ba15a1d1_4dc00fe1","updated":"2015-09-21 22:27:41.000000000","message":"Done","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ab7b07a930c9e1e92eada77d4f44a338429e5e2f","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Supported QoS rule types"},{"line_number":32,"context_line":"------------------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Any plugin or ml2 mechanism driver can claim support for some QoS rule types by"},{"line_number":35,"context_line":"providing a plugin/driver class property called \u0027supported_qos_rule_types\u0027 that"},{"line_number":36,"context_line":"should return a list of strings that correspond to QoS rule types:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_7de80f17","line":33,"updated":"2015-09-21 11:21:27.000000000","message":"Note that currently a single rule type is supported - badnwidth limit.","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Supported QoS rule types"},{"line_number":32,"context_line":"------------------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Any plugin or ml2 mechanism driver can claim support for some QoS rule types by"},{"line_number":35,"context_line":"providing a plugin/driver class property called \u0027supported_qos_rule_types\u0027 that"},{"line_number":36,"context_line":"should return a list of strings that correspond to QoS rule types:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_cff3819e","line":33,"in_reply_to":"ba15a1d1_7de80f17","updated":"2015-09-21 22:27:41.000000000","message":"It is already mentioned at the end of this section.","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"06a21d6b5776a6b29378e57d72723060d721b541","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Any plugin or ml2 mechanism driver can claim support for some QoS rule types by"},{"line_number":35,"context_line":"providing a plugin/driver class property called \u0027supported_qos_rule_types\u0027 that"},{"line_number":36,"context_line":"should return a list of strings that correspond to QoS rule types:"},{"line_number":37,"context_line":"`\u003chttps://github.com/openstack/neutron/blob/master/neutron/services/qos/qos_consts.py\u003e`"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"In the most simple case, the property can be represented by a simple Python"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_443544f5","line":36,"updated":"2015-09-20 23:54:37.000000000","message":"that returns a list*","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Any plugin or ml2 mechanism driver can claim support for some QoS rule types by"},{"line_number":35,"context_line":"providing a plugin/driver class property called \u0027supported_qos_rule_types\u0027 that"},{"line_number":36,"context_line":"should return a list of strings that correspond to QoS rule types:"},{"line_number":37,"context_line":"`\u003chttps://github.com/openstack/neutron/blob/master/neutron/services/qos/qos_consts.py\u003e`"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"In the most simple case, the property can be represented by a simple Python"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_4f2e91fb","line":36,"in_reply_to":"ba15a1d1_443544f5","updated":"2015-09-21 22:27:41.000000000","message":"Done","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"06a21d6b5776a6b29378e57d72723060d721b541","unresolved":false,"context_lines":[{"line_number":42,"context_line":"For ml2 plugin, the list of supported QoS rule types is defined as a common"},{"line_number":43,"context_line":"subset of rules supported by all active mechanism drivers."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Note: the list of supported rule types reported by core plugin is not enforced"},{"line_number":46,"context_line":"when accessing QoS rule resources. This is mostly because then we would not be"},{"line_number":47,"context_line":"able to create any rules while at least one ml2 driver in gate lacks support"},{"line_number":48,"context_line":"for QoS (at the moment of writing, linuxbridge is such a driver)."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_e439f8f3","line":45,"updated":"2015-09-20 23:54:37.000000000","message":".. note::\n   The list of supported rule types...","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"06a21d6b5776a6b29378e57d72723060d721b541","unresolved":false,"context_lines":[{"line_number":47,"context_line":"able to create any rules while at least one ml2 driver in gate lacks support"},{"line_number":48,"context_line":"for QoS (at the moment of writing, linuxbridge is such a driver)."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"For the Liberty release only bandwidth limit rules are supported."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Configuration"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_043f4cd7","line":50,"updated":"2015-09-20 23:54:37.000000000","message":"Is this sentence a part of the note?","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":47,"context_line":"able to create any rules while at least one ml2 driver in gate lacks support"},{"line_number":48,"context_line":"for QoS (at the moment of writing, linuxbridge is such a driver)."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"For the Liberty release only bandwidth limit rules are supported."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Configuration"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_8f726910","line":50,"in_reply_to":"ba15a1d1_043f4cd7","updated":"2015-09-21 22:27:41.000000000","message":"Done","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ab7b07a930c9e1e92eada77d4f44a338429e5e2f","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"Configuration"},{"line_number":54,"context_line":"-------------"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"To enable the service, the following steps should be followed:"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"On server side:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_fd409f37","line":55,"updated":"2015-09-21 11:21:27.000000000","message":"Explicitly note that QoS currently works with ml2 only. And maybe also mention that e.g. LB is not supported (so sr-iov + ovs are only reference drivers that are enabled for qos).","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"c553ab70581570e21997c059c2ea464c5ef764e1","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"On server side:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* Enable qos service in service_plugins."},{"line_number":61,"context_line":"* Set the needed notification_drivers in [qos] section"},{"line_number":62,"context_line":"  (message_queue is the default)."},{"line_number":63,"context_line":"* For ml2, add \u0027qos\u0027 to extension_drivers in [ml2] section."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_0dba176f","line":60,"updated":"2015-09-20 06:01:13.000000000","message":"better add an example here","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"c553ab70581570e21997c059c2ea464c5ef764e1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"On server side:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* Enable qos service in service_plugins."},{"line_number":61,"context_line":"* Set the needed notification_drivers in [qos] section"},{"line_number":62,"context_line":"  (message_queue is the default)."},{"line_number":63,"context_line":"* For ml2, add \u0027qos\u0027 to extension_drivers in [ml2] section."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_2d627b17","line":61,"updated":"2015-09-20 06:01:13.000000000","message":"I suggest to explain what is notification driver, probably in previous section","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ab7b07a930c9e1e92eada77d4f44a338429e5e2f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"On server side:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"* Enable qos service in service_plugins."},{"line_number":61,"context_line":"* Set the needed notification_drivers in [qos] section"},{"line_number":62,"context_line":"  (message_queue is the default)."},{"line_number":63,"context_line":"* For ml2, add \u0027qos\u0027 to extension_drivers in [ml2] section."},{"line_number":64,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_5d242bae","line":61,"in_reply_to":"ba15a1d1_2d627b17","updated":"2015-09-21 11:21:27.000000000","message":"Yes. And also, for existing implementations, there is only one notification driver, so not sure it\u0027s worth being mentioned here at all. The default should work for everyone?","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"c553ab70581570e21997c059c2ea464c5ef764e1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  (message_queue is the default)."},{"line_number":63,"context_line":"* For ml2, add \u0027qos\u0027 to extension_drivers in [ml2] section."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"On agent side (OVS):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* add \u0027qos\u0027 to extensions in [agent] section."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_0d71b7e0","line":65,"updated":"2015-09-20 06:01:13.000000000","message":"what about SR-IOV?","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ab7b07a930c9e1e92eada77d4f44a338429e5e2f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  (message_queue is the default)."},{"line_number":63,"context_line":"* For ml2, add \u0027qos\u0027 to extension_drivers in [ml2] section."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"On agent side (OVS):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* add \u0027qos\u0027 to extensions in [agent] section."},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_1d6553e0","line":65,"in_reply_to":"ba15a1d1_0d71b7e0","updated":"2015-09-21 11:21:27.000000000","message":"for sr-iov, it\u0027s actually the same.","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"06a21d6b5776a6b29378e57d72723060d721b541","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"On agent side (OVS):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* add \u0027qos\u0027 to extensions in [agent] section."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Trusted tenants policy.json configuration"},{"line_number":70,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_a42460c6","line":67,"updated":"2015-09-20 23:54:37.000000000","message":"Add*","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"On agent side (OVS):"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* add \u0027qos\u0027 to extensions in [agent] section."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"Trusted tenants policy.json configuration"},{"line_number":70,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_efe765aa","line":67,"in_reply_to":"ba15a1d1_a42460c6","updated":"2015-09-21 22:27:41.000000000","message":"Done","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ab7b07a930c9e1e92eada77d4f44a338429e5e2f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Trusted tenants policy.json configuration"},{"line_number":70,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"If tenants are trusted to administrate their own QoS policies in"},{"line_number":73,"context_line":"your cloud: neutron\u0027s policy.json can be modified to allow this."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Modify /etc/neutron/policy.json policy entries as follow::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_9d9f23b4","line":72,"updated":"2015-09-21 11:21:27.000000000","message":"administer","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":69,"context_line":"Trusted tenants policy.json configuration"},{"line_number":70,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"If tenants are trusted to administrate their own QoS policies in"},{"line_number":73,"context_line":"your cloud: neutron\u0027s policy.json can be modified to allow this."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Modify /etc/neutron/policy.json policy entries as follow::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_2f955de3","line":72,"in_reply_to":"ba15a1d1_9d9f23b4","updated":"2015-09-21 22:27:41.000000000","message":"what about configure?","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"06a21d6b5776a6b29378e57d72723060d721b541","unresolved":false,"context_lines":[{"line_number":70,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"If tenants are trusted to administrate their own QoS policies in"},{"line_number":73,"context_line":"your cloud: neutron\u0027s policy.json can be modified to allow this."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Modify /etc/neutron/policy.json policy entries as follow::"},{"line_number":76,"context_line":"     \"get_policy\": \"rule:regular_user\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_c42154b6","line":73,"updated":"2015-09-20 23:54:37.000000000","message":"your cloud, neutron\u0027s :file:`policy.json` or ``policy.json``","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"06a21d6b5776a6b29378e57d72723060d721b541","unresolved":false,"context_lines":[{"line_number":72,"context_line":"If tenants are trusted to administrate their own QoS policies in"},{"line_number":73,"context_line":"your cloud: neutron\u0027s policy.json can be modified to allow this."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Modify /etc/neutron/policy.json policy entries as follow::"},{"line_number":76,"context_line":"     \"get_policy\": \"rule:regular_user\","},{"line_number":77,"context_line":"     \"create_policy\": \"rule:regular_user\","},{"line_number":78,"context_line":"     \"update_policy\": \"rule:regular_user\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_642e48a7","line":75,"updated":"2015-09-20 23:54:37.000000000","message":"``/etc/neutron/policy.json``","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ab7b07a930c9e1e92eada77d4f44a338429e5e2f","unresolved":false,"context_lines":[{"line_number":72,"context_line":"If tenants are trusted to administrate their own QoS policies in"},{"line_number":73,"context_line":"your cloud: neutron\u0027s policy.json can be modified to allow this."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Modify /etc/neutron/policy.json policy entries as follow::"},{"line_number":76,"context_line":"     \"get_policy\": \"rule:regular_user\","},{"line_number":77,"context_line":"     \"create_policy\": \"rule:regular_user\","},{"line_number":78,"context_line":"     \"update_policy\": \"rule:regular_user\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_bdb8e72b","line":75,"updated":"2015-09-21 11:21:27.000000000","message":"as follows","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":72,"context_line":"If tenants are trusted to administrate their own QoS policies in"},{"line_number":73,"context_line":"your cloud: neutron\u0027s policy.json can be modified to allow this."},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"Modify /etc/neutron/policy.json policy entries as follow::"},{"line_number":76,"context_line":"     \"get_policy\": \"rule:regular_user\","},{"line_number":77,"context_line":"     \"create_policy\": \"rule:regular_user\","},{"line_number":78,"context_line":"     \"update_policy\": \"rule:regular_user\","}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_ef9e8506","line":75,"in_reply_to":"ba15a1d1_bdb8e72b","updated":"2015-09-21 22:27:41.000000000","message":"Done","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"06a21d6b5776a6b29378e57d72723060d721b541","unresolved":false,"context_lines":[{"line_number":87,"context_line":"User workflow"},{"line_number":88,"context_line":"-------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"QoS policies are only created by admins with the default policy.json."},{"line_number":91,"context_line":"Therefore, you should have the Cloud Operator to set up them in"},{"line_number":92,"context_line":"behalf of the Cloud tenants."},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_2417f055","line":90,"updated":"2015-09-20 23:54:37.000000000","message":"ditto for the policy.json","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":87,"context_line":"User workflow"},{"line_number":88,"context_line":"-------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"QoS policies are only created by admins with the default policy.json."},{"line_number":91,"context_line":"Therefore, you should have the Cloud Operator to set up them in"},{"line_number":92,"context_line":"behalf of the Cloud tenants."},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_4fbf7160","line":90,"in_reply_to":"ba15a1d1_2417f055","updated":"2015-09-21 22:27:41.000000000","message":"Done","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"c553ab70581570e21997c059c2ea464c5ef764e1","unresolved":false,"context_lines":[{"line_number":88,"context_line":"-------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"QoS policies are only created by admins with the default policy.json."},{"line_number":91,"context_line":"Therefore, you should have the Cloud Operator to set up them in"},{"line_number":92,"context_line":"behalf of the Cloud tenants."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"If tenants are trusted to create their own policies, check the trusted tenants"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_ad768bd6","line":91,"updated":"2015-09-20 06:01:13.000000000","message":"in\u003d\u003eon","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":88,"context_line":"-------------"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"QoS policies are only created by admins with the default policy.json."},{"line_number":91,"context_line":"Therefore, you should have the Cloud Operator to set up them in"},{"line_number":92,"context_line":"behalf of the Cloud tenants."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"If tenants are trusted to create their own policies, check the trusted tenants"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_efb5257e","line":91,"in_reply_to":"ba15a1d1_ad768bd6","updated":"2015-09-21 22:27:41.000000000","message":"Done","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"06a21d6b5776a6b29378e57d72723060d721b541","unresolved":false,"context_lines":[{"line_number":92,"context_line":"behalf of the Cloud tenants."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"If tenants are trusted to create their own policies, check the trusted tenants"},{"line_number":95,"context_line":"policy.json configuration section."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"First, create a qos policy and bandwidth rules:"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_441c6477","line":95,"updated":"2015-09-20 23:54:37.000000000","message":"This one too :)","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":92,"context_line":"behalf of the Cloud tenants."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"If tenants are trusted to create their own policies, check the trusted tenants"},{"line_number":95,"context_line":"policy.json configuration section."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"First, create a qos policy and bandwidth rules:"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_afb08d8c","line":95,"in_reply_to":"ba15a1d1_441c6477","updated":"2015-09-21 22:27:41.000000000","message":"Done","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"06a21d6b5776a6b29378e57d72723060d721b541","unresolved":false,"context_lines":[{"line_number":94,"context_line":"If tenants are trusted to create their own policies, check the trusted tenants"},{"line_number":95,"context_line":"policy.json configuration section."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"First, create a qos policy and bandwidth rules:"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. code-block:: console"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_04166c55","line":97,"updated":"2015-09-20 23:54:37.000000000","message":"QoS*","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ab7b07a930c9e1e92eada77d4f44a338429e5e2f","unresolved":false,"context_lines":[{"line_number":94,"context_line":"If tenants are trusted to create their own policies, check the trusted tenants"},{"line_number":95,"context_line":"policy.json configuration section."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"First, create a qos policy and bandwidth rules:"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. code-block:: console"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_bde6a742","line":97,"updated":"2015-09-21 11:21:27.000000000","message":"rules?.. we allow a single bw_limit rule per policy.","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":94,"context_line":"If tenants are trusted to create their own policies, check the trusted tenants"},{"line_number":95,"context_line":"policy.json configuration section."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"First, create a qos policy and bandwidth rules:"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":".. code-block:: console"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_2f4a3d84","line":97,"in_reply_to":"ba15a1d1_bde6a742","updated":"2015-09-21 22:27:41.000000000","message":"Done","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"06a21d6b5776a6b29378e57d72723060d721b541","unresolved":false,"context_lines":[{"line_number":129,"context_line":".. code-block:: console"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    $ neutron port-list"},{"line_number":132,"context_line":"    +--------------------------------------+------+-------------------+------------------------------------------------------------------------------------------------------------+"},{"line_number":133,"context_line":"    | id                                   | name | mac_address       | fixed_ips                                                                                                  |"},{"line_number":134,"context_line":"    +--------------------------------------+------+-------------------+------------------------------------------------------------------------------------------------------------+"},{"line_number":135,"context_line":"    | 0271d1d9-1b16-4410-bd74-82cdf6dcb5b3 |      | fa:16:3e:6b:92:e0 | {\"subnet_id\": \"f38b89fd-356a-4acf-bf27-a355288d4df5\", \"ip_address\": \"10.0.0.1\"}                            |"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_a40b002b","line":132,"updated":"2015-09-20 23:54:37.000000000","message":"Does this table render properly? Check. It\u0027s all out of line here. It needs to be wrapped at 78 characters.","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":129,"context_line":".. code-block:: console"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    $ neutron port-list"},{"line_number":132,"context_line":"    +--------------------------------------+------+-------------------+------------------------------------------------------------------------------------------------------------+"},{"line_number":133,"context_line":"    | id                                   | name | mac_address       | fixed_ips                                                                                                  |"},{"line_number":134,"context_line":"    +--------------------------------------+------+-------------------+------------------------------------------------------------------------------------------------------------+"},{"line_number":135,"context_line":"    | 0271d1d9-1b16-4410-bd74-82cdf6dcb5b3 |      | fa:16:3e:6b:92:e0 | {\"subnet_id\": \"f38b89fd-356a-4acf-bf27-a355288d4df5\", \"ip_address\": \"10.0.0.1\"}                            |"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_cf59415d","line":132,"in_reply_to":"ba15a1d1_a40b002b","updated":"2015-09-21 22:27:41.000000000","message":"This is going to be hard.. Should I cut some columns?","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"06a21d6b5776a6b29378e57d72723060d721b541","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    $ neutron port-create private --qos-policy-id bw-limiter"},{"line_number":160,"context_line":"    Created a new port:"},{"line_number":161,"context_line":"    +-----------------------+-------------------------------------------------------------------------------------------------------------+"},{"line_number":162,"context_line":"    | Field                 | Value                                                                                                       |"},{"line_number":163,"context_line":"    +-----------------------+-------------------------------------------------------------------------------------------------------------+"},{"line_number":164,"context_line":"    | admin_state_up        | True                                                                                                        |"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_c4087430","line":161,"updated":"2015-09-20 23:54:37.000000000","message":"Same here I\u0027m afraid","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    $ neutron port-create private --qos-policy-id bw-limiter"},{"line_number":160,"context_line":"    Created a new port:"},{"line_number":161,"context_line":"    +-----------------------+-------------------------------------------------------------------------------------------------------------+"},{"line_number":162,"context_line":"    | Field                 | Value                                                                                                       |"},{"line_number":163,"context_line":"    +-----------------------+-------------------------------------------------------------------------------------------------------------+"},{"line_number":164,"context_line":"    | admin_state_up        | True                                                                                                        |"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_4f3451fa","line":161,"in_reply_to":"ba15a1d1_c4087430","updated":"2015-09-21 22:27:41.000000000","message":"same response, need guidance.","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"c553ab70581570e21997c059c2ea464c5ef764e1","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"Networks can also be attached to a QoS policy. The meaning of this is that"},{"line_number":185,"context_line":"any compute port connected to the network will use the network policy by"},{"line_number":186,"context_line":"default unless the port has an specific policy attached to it. Network owned"},{"line_number":187,"context_line":"ports are excluded from network policy application."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"In order to attach a QoS policy to a network we can update an existing"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_cd73bfe6","line":186,"updated":"2015-09-20 06:01:13.000000000","message":"an\u003d\u003ea","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"06a21d6b5776a6b29378e57d72723060d721b541","unresolved":false,"context_lines":[{"line_number":199,"context_line":"-------------------------"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"Administrators are able to enforce policies on tenant ports or networks,"},{"line_number":202,"context_line":"as long as the policy is not shared, the tenant won\u0027t be able to detach"},{"line_number":203,"context_line":"any policy attached to a network or port."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"If the policy is shared, the tenant will be able to attach or detach such"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_84027c0a","line":202,"updated":"2015-09-20 23:54:37.000000000","message":"will not* \u003c- avoid using contractions please :)","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":199,"context_line":"-------------------------"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"Administrators are able to enforce policies on tenant ports or networks,"},{"line_number":202,"context_line":"as long as the policy is not shared, the tenant won\u0027t be able to detach"},{"line_number":203,"context_line":"any policy attached to a network or port."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"If the policy is shared, the tenant will be able to attach or detach such"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_cf2061b3","line":202,"in_reply_to":"ba15a1d1_84027c0a","updated":"2015-09-21 22:27:41.000000000","message":"Done","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"06a21d6b5776a6b29378e57d72723060d721b541","unresolved":false,"context_lines":[{"line_number":203,"context_line":"any policy attached to a network or port."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"If the policy is shared, the tenant will be able to attach or detach such"},{"line_number":206,"context_line":"policy from it\u0027s own ports and networks."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"In the future we plan to introduce tenant default policies, so any network"},{"line_number":209,"context_line":"or port will be initialized with an specific policy."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_1ffeb505","line":206,"updated":"2015-09-20 23:54:37.000000000","message":"its*","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":203,"context_line":"any policy attached to a network or port."},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"If the policy is shared, the tenant will be able to attach or detach such"},{"line_number":206,"context_line":"policy from it\u0027s own ports and networks."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"In the future we plan to introduce tenant default policies, so any network"},{"line_number":209,"context_line":"or port will be initialized with an specific policy."}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_2f18fd83","line":206,"in_reply_to":"ba15a1d1_1ffeb505","updated":"2015-09-21 22:27:41.000000000","message":"Done","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ab7b07a930c9e1e92eada77d4f44a338429e5e2f","unresolved":false,"context_lines":[{"line_number":205,"context_line":"If the policy is shared, the tenant will be able to attach or detach such"},{"line_number":206,"context_line":"policy from it\u0027s own ports and networks."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"In the future we plan to introduce tenant default policies, so any network"},{"line_number":209,"context_line":"or port will be initialized with an specific policy."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Rule modification"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_5d5c2bed","line":208,"updated":"2015-09-21 11:21:27.000000000","message":"Who are \u0027we\u0027?.. And overall, should we even mention dev plans in user guide?","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":205,"context_line":"If the policy is shared, the tenant will be able to attach or detach such"},{"line_number":206,"context_line":"policy from it\u0027s own ports and networks."},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"In the future we plan to introduce tenant default policies, so any network"},{"line_number":209,"context_line":"or port will be initialized with an specific policy."},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Rule modification"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_4f1bf180","line":208,"in_reply_to":"ba15a1d1_5d5c2bed","updated":"2015-09-21 22:27:41.000000000","message":"removing this part","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ab7b07a930c9e1e92eada77d4f44a338429e5e2f","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Rule modification"},{"line_number":212,"context_line":"-----------------"},{"line_number":213,"context_line":"Rules can be modified in runtime, rule modifications will be immediately"},{"line_number":214,"context_line":"propagated to any attached port."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_9d0963e0","line":213,"updated":"2015-09-21 11:21:27.000000000","message":"immediately?.. I don\u0027t believe it. Eventually would be a more realistic word.","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"ead9c602f914aa93f7fee05ab0842b63495080a8","unresolved":false,"context_lines":[{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Rule modification"},{"line_number":212,"context_line":"-----------------"},{"line_number":213,"context_line":"Rules can be modified in runtime, rule modifications will be immediately"},{"line_number":214,"context_line":"propagated to any attached port."},{"line_number":215,"context_line":""},{"line_number":216,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_cf07011c","line":213,"in_reply_to":"ba15a1d1_9d0963e0","updated":"2015-09-21 22:27:41.000000000","message":"Done    ;-)   Ajo was optimistic here!!","commit_id":"789d01bb4c2ae3d683d146a39d020286e0d27bc3"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"d723e2277c5de5b941b30e5cfce78e981a751ed0","unresolved":false,"context_lines":[{"line_number":40,"context_line":"returns a list of strings that correspond to QoS rule types:"},{"line_number":41,"context_line":"`\u003chttps://github.com/openstack/neutron/blob/master/neutron/services/qos/qos_consts.py\u003e`"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":".. note:: For the Liberty release only bandwidth limit rules are supported."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"In the most simple case, the property can be represented by a simple Python"},{"line_number":46,"context_line":"list defined on the class."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba15a1d1_9b906497","line":43,"updated":"2015-09-22 03:04:33.000000000","message":"This needs to be on the line below.\n\n.. note::\n   For the Liberty \n\n^^ as above","commit_id":"7a0774791d0a647a6594432949469aa11971cd95"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ac80622cd399430dcbf9633dc65784bb2142d610","unresolved":false,"context_lines":[{"line_number":40,"context_line":"returns a list of strings that correspond to QoS rule types:"},{"line_number":41,"context_line":"`\u003chttps://github.com/openstack/neutron/blob/master/neutron/services/qos/qos_consts.py\u003e`"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":".. note:: For the Liberty release only bandwidth limit rules are supported."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"In the most simple case, the property can be represented by a simple Python"},{"line_number":46,"context_line":"list defined on the class."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba15a1d1_6c2fd83e","line":43,"in_reply_to":"ba15a1d1_9b906497","updated":"2015-09-22 05:55:24.000000000","message":"Done","commit_id":"7a0774791d0a647a6594432949469aa11971cd95"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"d723e2277c5de5b941b30e5cfce78e981a751ed0","unresolved":false,"context_lines":[{"line_number":48,"context_line":"For ml2 plugin, the list of supported QoS rule types is defined as a common"},{"line_number":49,"context_line":"subset of rules supported by all active mechanism drivers."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. note:: The list of supported rule types reported by core plugin is not"},{"line_number":52,"context_line":"          enforced when accessing QoS rule resources. This is mostly because"},{"line_number":53,"context_line":"          then we would not be able to create any rules while at least one ml2"},{"line_number":54,"context_line":"          driver lacks support for QoS (at the moment of writing, linuxbridge"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba15a1d1_5be96c19","line":51,"updated":"2015-09-22 03:04:33.000000000","message":"Same here :)","commit_id":"7a0774791d0a647a6594432949469aa11971cd95"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ac80622cd399430dcbf9633dc65784bb2142d610","unresolved":false,"context_lines":[{"line_number":48,"context_line":"For ml2 plugin, the list of supported QoS rule types is defined as a common"},{"line_number":49,"context_line":"subset of rules supported by all active mechanism drivers."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. note:: The list of supported rule types reported by core plugin is not"},{"line_number":52,"context_line":"          enforced when accessing QoS rule resources. This is mostly because"},{"line_number":53,"context_line":"          then we would not be able to create any rules while at least one ml2"},{"line_number":54,"context_line":"          driver lacks support for QoS (at the moment of writing, linuxbridge"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba15a1d1_4c2c544a","line":51,"in_reply_to":"ba15a1d1_5be96c19","updated":"2015-09-22 05:55:24.000000000","message":"Done","commit_id":"7a0774791d0a647a6594432949469aa11971cd95"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"d723e2277c5de5b941b30e5cfce78e981a751ed0","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"On agent side (OVS):"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* add \u0027qos\u0027 to extensions in [agent] section."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":".. note:: QoS currently works with ml2 only (sr-iov with ovs are the only"},{"line_number":75,"context_line":"          drivers that are enabled for QoS in Liberty release)."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba15a1d1_7bec7029","line":72,"updated":"2015-09-22 03:04:33.000000000","message":"Capital A here","commit_id":"7a0774791d0a647a6594432949469aa11971cd95"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ac80622cd399430dcbf9633dc65784bb2142d610","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"On agent side (OVS):"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"* add \u0027qos\u0027 to extensions in [agent] section."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":".. note:: QoS currently works with ml2 only (sr-iov with ovs are the only"},{"line_number":75,"context_line":"          drivers that are enabled for QoS in Liberty release)."}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba15a1d1_acfe50ac","line":72,"in_reply_to":"ba15a1d1_7bec7029","updated":"2015-09-22 05:55:24.000000000","message":"Done","commit_id":"7a0774791d0a647a6594432949469aa11971cd95"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"d723e2277c5de5b941b30e5cfce78e981a751ed0","unresolved":false,"context_lines":[{"line_number":80,"context_line":"If tenants are trusted to administrate their own QoS policies in"},{"line_number":81,"context_line":"your cloud, neutron\u0027s file :file:`policy.json` can be modified to allow this."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Modify \"/etc/neutron/policy.json\" policy entries as follows::"},{"line_number":84,"context_line":"     \"get_policy\": \"rule:regular_user\","},{"line_number":85,"context_line":"     \"create_policy\": \"rule:regular_user\","},{"line_number":86,"context_line":"     \"update_policy\": \"rule:regular_user\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba15a1d1_3bf6f8f9","line":83,"updated":"2015-09-22 03:04:33.000000000","message":"``/etc/neutron/policy.json`` - backslashes here","commit_id":"7a0774791d0a647a6594432949469aa11971cd95"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ac80622cd399430dcbf9633dc65784bb2142d610","unresolved":false,"context_lines":[{"line_number":80,"context_line":"If tenants are trusted to administrate their own QoS policies in"},{"line_number":81,"context_line":"your cloud, neutron\u0027s file :file:`policy.json` can be modified to allow this."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"Modify \"/etc/neutron/policy.json\" policy entries as follows::"},{"line_number":84,"context_line":"     \"get_policy\": \"rule:regular_user\","},{"line_number":85,"context_line":"     \"create_policy\": \"rule:regular_user\","},{"line_number":86,"context_line":"     \"update_policy\": \"rule:regular_user\","}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba15a1d1_8c034cb8","line":83,"in_reply_to":"ba15a1d1_3bf6f8f9","updated":"2015-09-22 05:55:24.000000000","message":"Done","commit_id":"7a0774791d0a647a6594432949469aa11971cd95"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"d723e2277c5de5b941b30e5cfce78e981a751ed0","unresolved":false,"context_lines":[{"line_number":95,"context_line":"User workflow"},{"line_number":96,"context_line":"-------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"QoS policies are only created by admins with the default \"policy.json\"."},{"line_number":99,"context_line":"Therefore, you should have the Cloud Operator to set up them on"},{"line_number":100,"context_line":"behalf of the Cloud tenants."},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba15a1d1_fbd88081","line":98,"updated":"2015-09-22 03:04:33.000000000","message":"Same here: ``policy.json``","commit_id":"7a0774791d0a647a6594432949469aa11971cd95"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ac80622cd399430dcbf9633dc65784bb2142d610","unresolved":false,"context_lines":[{"line_number":95,"context_line":"User workflow"},{"line_number":96,"context_line":"-------------"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"QoS policies are only created by admins with the default \"policy.json\"."},{"line_number":99,"context_line":"Therefore, you should have the Cloud Operator to set up them on"},{"line_number":100,"context_line":"behalf of the Cloud tenants."},{"line_number":101,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba15a1d1_ecf448d0","line":98,"in_reply_to":"ba15a1d1_fbd88081","updated":"2015-09-22 05:55:24.000000000","message":"Done","commit_id":"7a0774791d0a647a6594432949469aa11971cd95"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"d723e2277c5de5b941b30e5cfce78e981a751ed0","unresolved":false,"context_lines":[{"line_number":100,"context_line":"behalf of the Cloud tenants."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"If tenants are trusted to create their own policies, check the trusted tenants"},{"line_number":103,"context_line":"\"policy.json\" configuration section."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"First, create a QoS policy and its bandwidth rules:"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba15a1d1_9be70440","line":103,"updated":"2015-09-22 03:04:33.000000000","message":"ditto","commit_id":"7a0774791d0a647a6594432949469aa11971cd95"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ac80622cd399430dcbf9633dc65784bb2142d610","unresolved":false,"context_lines":[{"line_number":100,"context_line":"behalf of the Cloud tenants."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"If tenants are trusted to create their own policies, check the trusted tenants"},{"line_number":103,"context_line":"\"policy.json\" configuration section."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"First, create a QoS policy and its bandwidth rules:"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba15a1d1_0c0f3ce2","line":103,"in_reply_to":"ba15a1d1_9be70440","updated":"2015-09-22 05:55:24.000000000","message":"Done","commit_id":"7a0774791d0a647a6594432949469aa11971cd95"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"d723e2277c5de5b941b30e5cfce78e981a751ed0","unresolved":false,"context_lines":[{"line_number":209,"context_line":"-------------------------"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Administrators are able to enforce policies on tenant ports or networks,"},{"line_number":212,"context_line":"as long as the policy is not shared, the tenant won\u0027t be able to detach"},{"line_number":213,"context_line":"any policy attached to a network or port."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"If the policy is shared, the tenant will be able to attach or detach such"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba15a1d1_7bd31060","line":212,"updated":"2015-09-22 03:04:33.000000000","message":"will not*","commit_id":"7a0774791d0a647a6594432949469aa11971cd95"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ac80622cd399430dcbf9633dc65784bb2142d610","unresolved":false,"context_lines":[{"line_number":209,"context_line":"-------------------------"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Administrators are able to enforce policies on tenant ports or networks,"},{"line_number":212,"context_line":"as long as the policy is not shared, the tenant won\u0027t be able to detach"},{"line_number":213,"context_line":"any policy attached to a network or port."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"If the policy is shared, the tenant will be able to attach or detach such"}],"source_content_type":"text/x-rst","patch_set":6,"id":"ba15a1d1_ac6730b6","line":212,"in_reply_to":"ba15a1d1_7bd31060","updated":"2015-09-22 05:55:24.000000000","message":"Done","commit_id":"7a0774791d0a647a6594432949469aa11971cd95"},{"author":{"_account_id":14396,"name":"Alexander Adamov","email":"aadamov@mirantis.com","username":"Alexander"},"change_message_id":"8b1fef6a23ecdc2af29950d95c67c907db08bf7f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Using OpenStack Networking with QoS"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_07294e89","line":1,"updated":"2015-09-22 10:04:51.000000000","message":"It looks like we can remove one \"\u003d\" at the end","commit_id":"72957275047a87ad82831cc37e16e937a18a03e5"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"93811b7d900cdfdaa163b7de1cf56f266714d3b4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Using OpenStack Networking with QoS"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_7078f42b","line":1,"in_reply_to":"ba15a1d1_07294e89","updated":"2015-09-22 14:17:52.000000000","message":"Done","commit_id":"72957275047a87ad82831cc37e16e937a18a03e5"},{"author":{"_account_id":14396,"name":"Alexander Adamov","email":"aadamov@mirantis.com","username":"Alexander"},"change_message_id":"8b1fef6a23ecdc2af29950d95c67c907db08bf7f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This page serves as a guide for how to use the \"Quality of Service\" (QoS)"},{"line_number":6,"context_line":"functionality of OpenStack Neutron Networking"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"QoS is defined as the ability to guarantee certain network requirements"},{"line_number":9,"context_line":"like bandwidth, latency, jitter and reliability in order to satisfy a"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_a7566204","line":6,"updated":"2015-09-22 10:04:51.000000000","message":"OpenStack Networking","commit_id":"72957275047a87ad82831cc37e16e937a18a03e5"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"93811b7d900cdfdaa163b7de1cf56f266714d3b4","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This page serves as a guide for how to use the \"Quality of Service\" (QoS)"},{"line_number":6,"context_line":"functionality of OpenStack Neutron Networking"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"QoS is defined as the ability to guarantee certain network requirements"},{"line_number":9,"context_line":"like bandwidth, latency, jitter and reliability in order to satisfy a"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_104f38be","line":6,"in_reply_to":"ba15a1d1_a7566204","updated":"2015-09-22 14:17:52.000000000","message":"Done","commit_id":"72957275047a87ad82831cc37e16e937a18a03e5"},{"author":{"_account_id":14396,"name":"Alexander Adamov","email":"aadamov@mirantis.com","username":"Alexander"},"change_message_id":"8b1fef6a23ecdc2af29950d95c67c907db08bf7f","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Network devices such as switches and routers can mark traffic in order to be"},{"line_number":14,"context_line":"handled with a higher priority to fulfill the QoS conditions agreed under"},{"line_number":15,"context_line":"the service SLA. In other cases, certain network traffic such as Voice over"},{"line_number":16,"context_line":"IP (VoIP) and video streaming requires to be transmitted with minimal bandwidth"},{"line_number":17,"context_line":"constraints. On a system without network QoS management, all traffic will be"},{"line_number":18,"context_line":"transmitted in a \"best-effort\" manner making impossible to guarantee service"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_67afeae3","line":15,"updated":"2015-09-22 10:04:51.000000000","message":"under the SLA","commit_id":"72957275047a87ad82831cc37e16e937a18a03e5"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"93811b7d900cdfdaa163b7de1cf56f266714d3b4","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Network devices such as switches and routers can mark traffic in order to be"},{"line_number":14,"context_line":"handled with a higher priority to fulfill the QoS conditions agreed under"},{"line_number":15,"context_line":"the service SLA. In other cases, certain network traffic such as Voice over"},{"line_number":16,"context_line":"IP (VoIP) and video streaming requires to be transmitted with minimal bandwidth"},{"line_number":17,"context_line":"constraints. On a system without network QoS management, all traffic will be"},{"line_number":18,"context_line":"transmitted in a \"best-effort\" manner making impossible to guarantee service"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_90b6e888","line":15,"in_reply_to":"ba15a1d1_67afeae3","updated":"2015-09-22 14:17:52.000000000","message":"Done","commit_id":"72957275047a87ad82831cc37e16e937a18a03e5"},{"author":{"_account_id":14396,"name":"Alexander Adamov","email":"aadamov@mirantis.com","username":"Alexander"},"change_message_id":"8b1fef6a23ecdc2af29950d95c67c907db08bf7f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"The basics"},{"line_number":23,"context_line":"----------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Quality of Service (QoS) is an advanced service plugin. QoS is decoupled"},{"line_number":26,"context_line":"from the rest of the Neutron code on multiple levels."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"QoS extends core resources (ports, networks) without using mixins inherited"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_c7f596ed","line":25,"updated":"2015-09-22 10:04:51.000000000","message":"QoS is ... It is decoupled...","commit_id":"72957275047a87ad82831cc37e16e937a18a03e5"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"93811b7d900cdfdaa163b7de1cf56f266714d3b4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"The basics"},{"line_number":23,"context_line":"----------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Quality of Service (QoS) is an advanced service plugin. QoS is decoupled"},{"line_number":26,"context_line":"from the rest of the Neutron code on multiple levels."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"QoS extends core resources (ports, networks) without using mixins inherited"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_70ac7435","line":25,"in_reply_to":"ba15a1d1_c7f596ed","updated":"2015-09-22 14:17:52.000000000","message":"Done","commit_id":"72957275047a87ad82831cc37e16e937a18a03e5"},{"author":{"_account_id":14396,"name":"Alexander Adamov","email":"aadamov@mirantis.com","username":"Alexander"},"change_message_id":"8b1fef6a23ecdc2af29950d95c67c907db08bf7f","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":".. note::"},{"line_number":53,"context_line":"   The list of supported rule types reported by core plugin is not"},{"line_number":54,"context_line":"   enforced when accessing QoS rule resources. This is mostly because"},{"line_number":55,"context_line":"   then we would not be able to create any rules while at least one ml2"},{"line_number":56,"context_line":"   driver lacks support for QoS (at the moment of writing, linuxbridge"},{"line_number":57,"context_line":"   is such a driver)."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_67e7ea12","line":54,"updated":"2015-09-22 10:04:51.000000000","message":"This is mostly because... it looks like a part of the sentence is missing here","commit_id":"72957275047a87ad82831cc37e16e937a18a03e5"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"6f8ac2b1d3e2a110a1e8538001c8394bac7b3852","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":".. note::"},{"line_number":53,"context_line":"   The list of supported rule types reported by core plugin is not"},{"line_number":54,"context_line":"   enforced when accessing QoS rule resources. This is mostly because"},{"line_number":55,"context_line":"   then we would not be able to create any rules while at least one ml2"},{"line_number":56,"context_line":"   driver lacks support for QoS (at the moment of writing, linuxbridge"},{"line_number":57,"context_line":"   is such a driver)."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_392ef6fa","line":54,"in_reply_to":"ba15a1d1_67e7ea12","updated":"2015-09-22 10:27:56.000000000","message":"It\u0027s complete, but we could reduce it to \"This is because we would not be able to create...\"","commit_id":"72957275047a87ad82831cc37e16e937a18a03e5"},{"author":{"_account_id":14396,"name":"Alexander Adamov","email":"aadamov@mirantis.com","username":"Alexander"},"change_message_id":"8b1fef6a23ecdc2af29950d95c67c907db08bf7f","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"On server side:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* Enable qos service in service_plugins."},{"line_number":68,"context_line":"* Set the needed notification_drivers in [qos] section"},{"line_number":69,"context_line":"  (message_queue is the default)."},{"line_number":70,"context_line":"* For ml2, add \u0027qos\u0027 to extension_drivers in [ml2] section."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_07bdced6","line":67,"updated":"2015-09-22 10:04:51.000000000","message":"``qos`` service","commit_id":"72957275047a87ad82831cc37e16e937a18a03e5"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"93811b7d900cdfdaa163b7de1cf56f266714d3b4","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"On server side:"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"* Enable qos service in service_plugins."},{"line_number":68,"context_line":"* Set the needed notification_drivers in [qos] section"},{"line_number":69,"context_line":"  (message_queue is the default)."},{"line_number":70,"context_line":"* For ml2, add \u0027qos\u0027 to extension_drivers in [ml2] section."}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_d031c00c","line":67,"in_reply_to":"ba15a1d1_07bdced6","updated":"2015-09-22 14:17:52.000000000","message":"Done","commit_id":"72957275047a87ad82831cc37e16e937a18a03e5"},{"author":{"_account_id":14396,"name":"Alexander Adamov","email":"aadamov@mirantis.com","username":"Alexander"},"change_message_id":"8b1fef6a23ecdc2af29950d95c67c907db08bf7f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"If tenants are trusted to administrate their own QoS policies in"},{"line_number":84,"context_line":"your cloud, neutron\u0027s file :file:`policy.json` can be modified to allow this."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Modify ``/etc/neutron/policy.json`` policy entries as follows::"},{"line_number":87,"context_line":"     \"get_policy\": \"rule:regular_user\","},{"line_number":88,"context_line":"     \"create_policy\": \"rule:regular_user\","},{"line_number":89,"context_line":"     \"update_policy\": \"rule:regular_user\","}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_0792ae4b","line":86,"updated":"2015-09-22 10:04:51.000000000","message":".. code-block:: ini","commit_id":"72957275047a87ad82831cc37e16e937a18a03e5"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"6f8ac2b1d3e2a110a1e8538001c8394bac7b3852","unresolved":false,"context_lines":[{"line_number":83,"context_line":"If tenants are trusted to administrate their own QoS policies in"},{"line_number":84,"context_line":"your cloud, neutron\u0027s file :file:`policy.json` can be modified to allow this."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"Modify ``/etc/neutron/policy.json`` policy entries as follows::"},{"line_number":87,"context_line":"     \"get_policy\": \"rule:regular_user\","},{"line_number":88,"context_line":"     \"create_policy\": \"rule:regular_user\","},{"line_number":89,"context_line":"     \"update_policy\": \"rule:regular_user\","}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_3907d682","line":86,"in_reply_to":"ba15a1d1_0792ae4b","updated":"2015-09-22 10:27:56.000000000","message":"It\u0027s not in ini config format, this is json, but it\u0027s incomplete because we\u0027re showing only the relevant fragment.\n\nWould ini work?","commit_id":"72957275047a87ad82831cc37e16e937a18a03e5"},{"author":{"_account_id":14396,"name":"Alexander Adamov","email":"aadamov@mirantis.com","username":"Alexander"},"change_message_id":"8b1fef6a23ecdc2af29950d95c67c907db08bf7f","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Second, associate the created policy with an existing neutron port."},{"line_number":138,"context_line":"In order to do this, user should extract the port id to be associated to"},{"line_number":139,"context_line":"the already created policy. In the next example, we will assign the bw-limiter"},{"line_number":140,"context_line":"policy to the VM with IP address 10.0.0.3"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_07b94ecb","line":139,"updated":"2015-09-22 10:04:51.000000000","message":"``bw-limiter`` policy","commit_id":"72957275047a87ad82831cc37e16e937a18a03e5"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"93811b7d900cdfdaa163b7de1cf56f266714d3b4","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"Second, associate the created policy with an existing neutron port."},{"line_number":138,"context_line":"In order to do this, user should extract the port id to be associated to"},{"line_number":139,"context_line":"the already created policy. In the next example, we will assign the bw-limiter"},{"line_number":140,"context_line":"policy to the VM with IP address 10.0.0.3"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ba15a1d1_eb02d908","line":139,"in_reply_to":"ba15a1d1_07b94ecb","updated":"2015-09-22 14:17:52.000000000","message":"Done","commit_id":"72957275047a87ad82831cc37e16e937a18a03e5"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"8dfb13a1a9545ee42c2a5e63855d00c0ae8b6cf6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"`\u003chttps://github.com/openstack/neutron/blob/master/neutron/services/qos/qos_consts.py\u003e`"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":".. note::"},{"line_number":44,"context_line":"   For the Liberty release only bandwidth limit rules are supported."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"In the most simple case, the property can be represented by a simple Python"},{"line_number":47,"context_line":"list defined on the class."}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba15a1d1_b6ebe477","line":44,"updated":"2015-09-22 14:48:33.000000000","message":"can we point out it is just for egress bandwidth, and I don\u0027t think we have limited the service port, such like router\u0027s interface port and so on","commit_id":"d4da208b51510d7f7893fcfa369e190905a44f51"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"1e402d18b8bf7f35b5d468786254a10ec6c6b9cc","unresolved":false,"context_lines":[{"line_number":41,"context_line":"`\u003chttps://github.com/openstack/neutron/blob/master/neutron/services/qos/qos_consts.py\u003e`"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":".. note::"},{"line_number":44,"context_line":"   For the Liberty release only bandwidth limit rules are supported."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"In the most simple case, the property can be represented by a simple Python"},{"line_number":47,"context_line":"list defined on the class."}],"source_content_type":"text/x-rst","patch_set":8,"id":"ba15a1d1_f1bde6d7","line":44,"in_reply_to":"ba15a1d1_b6ebe477","updated":"2015-09-22 15:10:50.000000000","message":"Done","commit_id":"d4da208b51510d7f7893fcfa369e190905a44f51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"db4c04010a89f8c6f75b5e8b93b5858c53f10f84","unresolved":false,"context_lines":[{"line_number":25,"context_line":"QoS is an advanced service plugin. QoS is decoupled from the rest of the"},{"line_number":26,"context_line":"Neutron code on multiple levels."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"QoS extends core resources (ports, networks) without using mixins inherited"},{"line_number":29,"context_line":"by plugins but through an ml2 extension driver."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Details about the DB models, API extension, and use cases can be found"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba15a1d1_26b00343","line":28,"updated":"2015-09-22 15:28:33.000000000","message":"Again, why the mixin details in user facing docs. Just note it requires ml2 extension.","commit_id":"cf357e36ae339440c76f0c26d4a4a882fb23eda8"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"22ecf66f4b9d69b7d09ca457b415a9039b66eb39","unresolved":false,"context_lines":[{"line_number":25,"context_line":"QoS is an advanced service plugin. QoS is decoupled from the rest of the"},{"line_number":26,"context_line":"Neutron code on multiple levels."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"QoS extends core resources (ports, networks) without using mixins inherited"},{"line_number":29,"context_line":"by plugins but through an ml2 extension driver."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Details about the DB models, API extension, and use cases can be found"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba15a1d1_3936e4e7","line":28,"in_reply_to":"ba15a1d1_26b00343","updated":"2015-09-22 16:42:25.000000000","message":"You are right. This level of details can be confusing. Will be removed in the next patch.","commit_id":"cf357e36ae339440c76f0c26d4a4a882fb23eda8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"db4c04010a89f8c6f75b5e8b93b5858c53f10f84","unresolved":false,"context_lines":[{"line_number":43,"context_line":".. note::"},{"line_number":44,"context_line":"   For the Liberty release only egress bandwidth limit rules are supported"},{"line_number":45,"context_line":"   on virtual machines port but not for services like the routers or load"},{"line_number":46,"context_line":"   balancers ports."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"In the most simple case, the property can be represented by a simple Python"},{"line_number":49,"context_line":"list defined on the class."}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba15a1d1_a6e9731c","line":46,"updated":"2015-09-22 15:28:33.000000000","message":"I believe that\u0027s wrong since if you set limit for those ports, it\u0027s applied. It\u0027s just that network-level QoS policy is not applied to them.","commit_id":"cf357e36ae339440c76f0c26d4a4a882fb23eda8"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"22ecf66f4b9d69b7d09ca457b415a9039b66eb39","unresolved":false,"context_lines":[{"line_number":43,"context_line":".. note::"},{"line_number":44,"context_line":"   For the Liberty release only egress bandwidth limit rules are supported"},{"line_number":45,"context_line":"   on virtual machines port but not for services like the routers or load"},{"line_number":46,"context_line":"   balancers ports."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"In the most simple case, the property can be represented by a simple Python"},{"line_number":49,"context_line":"list defined on the class."}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba15a1d1_06ee1fb4","line":46,"in_reply_to":"ba15a1d1_a6e9731c","updated":"2015-09-22 16:42:25.000000000","message":"Ok, adjusting this one.","commit_id":"cf357e36ae339440c76f0c26d4a4a882fb23eda8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"db4c04010a89f8c6f75b5e8b93b5858c53f10f84","unresolved":false,"context_lines":[{"line_number":76,"context_line":"* Add \u0027qos\u0027 to extensions in [agent] section."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. note::"},{"line_number":79,"context_line":"   QoS currently works with ml2 only (sr-iov with ovs are the only"},{"line_number":80,"context_line":"   drivers that are enabled for QoS in Liberty release)."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Trusted tenants policy.json configuration"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba15a1d1_66411b0b","line":79,"updated":"2015-09-22 15:28:33.000000000","message":"I believe, user facing, the driver alias is openvswitch, not ovs; and it\u0027s sriovnicswitch, not sr-iov.","commit_id":"cf357e36ae339440c76f0c26d4a4a882fb23eda8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0f1f9cb68b64eb3d90d15efbbb23329186f12792","unresolved":false,"context_lines":[{"line_number":76,"context_line":"* Add \u0027qos\u0027 to extensions in [agent] section."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. note::"},{"line_number":79,"context_line":"   QoS currently works with ml2 only (sr-iov with ovs are the only"},{"line_number":80,"context_line":"   drivers that are enabled for QoS in Liberty release)."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Trusted tenants policy.json configuration"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba15a1d1_cd0842dc","line":79,"in_reply_to":"ba15a1d1_0645bfb1","updated":"2015-09-22 16:49:40.000000000","message":"Well, if you refer to drivers, then I think it should reflect what is put in config files. Or alternatively, have proper case/naming, like SR-IOV and Open vSwitch.","commit_id":"cf357e36ae339440c76f0c26d4a4a882fb23eda8"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"22ecf66f4b9d69b7d09ca457b415a9039b66eb39","unresolved":false,"context_lines":[{"line_number":76,"context_line":"* Add \u0027qos\u0027 to extensions in [agent] section."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. note::"},{"line_number":79,"context_line":"   QoS currently works with ml2 only (sr-iov with ovs are the only"},{"line_number":80,"context_line":"   drivers that are enabled for QoS in Liberty release)."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Trusted tenants policy.json configuration"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba15a1d1_0645bfb1","line":79,"in_reply_to":"ba15a1d1_66411b0b","updated":"2015-09-22 16:42:25.000000000","message":"users are familiar with ovs and sr-iov. I find hard to read the suggested ones.","commit_id":"cf357e36ae339440c76f0c26d4a4a882fb23eda8"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"34a5da1dd70c1f32b431d34cc4e8ff4fbd603294","unresolved":false,"context_lines":[{"line_number":76,"context_line":"* Add \u0027qos\u0027 to extensions in [agent] section."},{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. note::"},{"line_number":79,"context_line":"   QoS currently works with ml2 only (sr-iov with ovs are the only"},{"line_number":80,"context_line":"   drivers that are enabled for QoS in Liberty release)."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"Trusted tenants policy.json configuration"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba15a1d1_8db7aaf4","line":79,"in_reply_to":"ba15a1d1_cd0842dc","updated":"2015-09-22 16:52:43.000000000","message":"sounds good. Let me change it to the suggested: SR-IOV and Open vSwitch.","commit_id":"cf357e36ae339440c76f0c26d4a4a882fb23eda8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"db4c04010a89f8c6f75b5e8b93b5858c53f10f84","unresolved":false,"context_lines":[{"line_number":107,"context_line":"If tenants are trusted to create their own policies, check the trusted tenants"},{"line_number":108,"context_line":"``policy.json`` configuration section."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"First, create a QoS policy and its bandwidth rules:"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":".. code-block:: console"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba15a1d1_e66c4b9e","line":110,"updated":"2015-09-22 15:28:33.000000000","message":"the proper name of the rule type is bandwidth limit, not just bandwidth.","commit_id":"cf357e36ae339440c76f0c26d4a4a882fb23eda8"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"22ecf66f4b9d69b7d09ca457b415a9039b66eb39","unresolved":false,"context_lines":[{"line_number":107,"context_line":"If tenants are trusted to create their own policies, check the trusted tenants"},{"line_number":108,"context_line":"``policy.json`` configuration section."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"First, create a QoS policy and its bandwidth rules:"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":".. code-block:: console"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba15a1d1_2627a313","line":110,"in_reply_to":"ba15a1d1_e66c4b9e","updated":"2015-09-22 16:42:25.000000000","message":"Done","commit_id":"cf357e36ae339440c76f0c26d4a4a882fb23eda8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"db4c04010a89f8c6f75b5e8b93b5858c53f10f84","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Rule modification"},{"line_number":223,"context_line":"-----------------"},{"line_number":224,"context_line":"Rules can be modified in runtime, rule modifications will be immediately"},{"line_number":225,"context_line":"propagated to any attached port."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba15a1d1_2621e34d","line":224,"updated":"2015-09-22 15:28:33.000000000","message":"I believe some comments from PS5 are lost, like about that immediate thingy.","commit_id":"cf357e36ae339440c76f0c26d4a4a882fb23eda8"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"22ecf66f4b9d69b7d09ca457b415a9039b66eb39","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"Rule modification"},{"line_number":223,"context_line":"-----------------"},{"line_number":224,"context_line":"Rules can be modified in runtime, rule modifications will be immediately"},{"line_number":225,"context_line":"propagated to any attached port."},{"line_number":226,"context_line":""},{"line_number":227,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ba15a1d1_d96248d8","line":224,"in_reply_to":"ba15a1d1_2621e34d","updated":"2015-09-22 16:42:25.000000000","message":"looking into those ones.","commit_id":"cf357e36ae339440c76f0c26d4a4a882fb23eda8"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"ad6ae0a7282830907d514df350999544dc0c7ae2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This page serves as a guide for how to use the \"Quality of Service\" (QoS)"},{"line_number":6,"context_line":"functionality of OpenStack Networking"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"QoS is defined as the ability to guarantee certain network requirements"},{"line_number":9,"context_line":"like bandwidth, latency, jitter and reliability in order to satisfy a"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_987cbcec","line":6,"updated":"2015-09-22 21:37:31.000000000","message":"Add a period?","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"81e1c77dd9993fd4afd5a60932d090f1bd4c2004","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This page serves as a guide for how to use the \"Quality of Service\" (QoS)"},{"line_number":6,"context_line":"functionality of OpenStack Networking"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"QoS is defined as the ability to guarantee certain network requirements"},{"line_number":9,"context_line":"like bandwidth, latency, jitter and reliability in order to satisfy a"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_771d1561","line":6,"in_reply_to":"ba15a1d1_987cbcec","updated":"2015-09-23 14:03:51.000000000","message":"+1","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"4574f36de7babed120f264a5a7dcd4938d4f55a2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This page serves as a guide for how to use the \"Quality of Service\" (QoS)"},{"line_number":6,"context_line":"functionality of OpenStack Networking"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"QoS is defined as the ability to guarantee certain network requirements"},{"line_number":9,"context_line":"like bandwidth, latency, jitter and reliability in order to satisfy a"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_29ca04a2","line":6,"in_reply_to":"ba15a1d1_987cbcec","updated":"2015-09-23 15:56:10.000000000","message":"Done","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"ad6ae0a7282830907d514df350999544dc0c7ae2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"This page serves as a guide for how to use the \"Quality of Service\" (QoS)"},{"line_number":6,"context_line":"functionality of OpenStack Networking"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"QoS is defined as the ability to guarantee certain network requirements"},{"line_number":9,"context_line":"like bandwidth, latency, jitter and reliability in order to satisfy a"},{"line_number":10,"context_line":"Service Level Agreement (SLA) between an application provider and end"},{"line_number":11,"context_line":"users."}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_7863e81a","line":8,"updated":"2015-09-22 21:37:31.000000000","message":"Can it guarantee these things?  Maybe minimum bandwidth, but not latency for instance, I think.","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"4574f36de7babed120f264a5a7dcd4938d4f55a2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"This page serves as a guide for how to use the \"Quality of Service\" (QoS)"},{"line_number":6,"context_line":"functionality of OpenStack Networking"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"QoS is defined as the ability to guarantee certain network requirements"},{"line_number":9,"context_line":"like bandwidth, latency, jitter and reliability in order to satisfy a"},{"line_number":10,"context_line":"Service Level Agreement (SLA) between an application provider and end"},{"line_number":11,"context_line":"users."}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_4944181a","line":8,"in_reply_to":"ba15a1d1_7863e81a","updated":"2015-09-23 15:56:10.000000000","message":"This is just about the QoS definition not about the scope of this guide and neutron capabilities.","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"81e1c77dd9993fd4afd5a60932d090f1bd4c2004","unresolved":false,"context_lines":[{"line_number":5,"context_line":"This page serves as a guide for how to use the \"Quality of Service\" (QoS)"},{"line_number":6,"context_line":"functionality of OpenStack Networking"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"QoS is defined as the ability to guarantee certain network requirements"},{"line_number":9,"context_line":"like bandwidth, latency, jitter and reliability in order to satisfy a"},{"line_number":10,"context_line":"Service Level Agreement (SLA) between an application provider and end"},{"line_number":11,"context_line":"users."}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_b775ed98","line":8,"in_reply_to":"ba15a1d1_7863e81a","updated":"2015-09-23 14:03:51.000000000","message":"Well, latency will be hard, we can only guarantee it is reduced via packet prioritisation (DSCP marking, VLAN priority tags, or IPV6 tags), but we can\u0027t guarantee an specific latency I guess.\n\nAny suggestion on how to rewrite this?.","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"ad6ae0a7282830907d514df350999544dc0c7ae2","unresolved":false,"context_lines":[{"line_number":6,"context_line":"functionality of OpenStack Networking"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"QoS is defined as the ability to guarantee certain network requirements"},{"line_number":9,"context_line":"like bandwidth, latency, jitter and reliability in order to satisfy a"},{"line_number":10,"context_line":"Service Level Agreement (SLA) between an application provider and end"},{"line_number":11,"context_line":"users."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_0b47f81d","line":9,"updated":"2015-09-22 21:37:31.000000000","message":"Are we (always?) talking specifically about minimum bandwidth, maximum latency, maximum jitter, and minimum reliability?","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"4574f36de7babed120f264a5a7dcd4938d4f55a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":"functionality of OpenStack Networking"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"QoS is defined as the ability to guarantee certain network requirements"},{"line_number":9,"context_line":"like bandwidth, latency, jitter and reliability in order to satisfy a"},{"line_number":10,"context_line":"Service Level Agreement (SLA) between an application provider and end"},{"line_number":11,"context_line":"users."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_a96cd49c","line":9,"in_reply_to":"ba15a1d1_0b47f81d","updated":"2015-09-23 15:56:10.000000000","message":"I don\u0027t understand your comment here but later you will see that we clarify the scope of the work done so far.","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"81e1c77dd9993fd4afd5a60932d090f1bd4c2004","unresolved":false,"context_lines":[{"line_number":6,"context_line":"functionality of OpenStack Networking"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"QoS is defined as the ability to guarantee certain network requirements"},{"line_number":9,"context_line":"like bandwidth, latency, jitter and reliability in order to satisfy a"},{"line_number":10,"context_line":"Service Level Agreement (SLA) between an application provider and end"},{"line_number":11,"context_line":"users."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_57957184","line":9,"in_reply_to":"ba15a1d1_0b47f81d","updated":"2015-09-23 14:03:51.000000000","message":"It\u0027s a general definition for QoS, not what we exactly do. Since QoS is an acronym not familiar to everyone, it\u0027s good to at least explain what it is once.","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"ad6ae0a7282830907d514df350999544dc0c7ae2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Service Level Agreement (SLA) between an application provider and end"},{"line_number":11,"context_line":"users."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Network devices such as switches and routers can mark traffic in order to be"},{"line_number":14,"context_line":"handled with a higher priority to fulfill the QoS conditions agreed under"},{"line_number":15,"context_line":"the SLA. In other cases, certain network traffic such as Voice over IP (VoIP)"},{"line_number":16,"context_line":"and video streaming requires to be transmitted with minimal bandwidth"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_98bfdc5f","line":13,"updated":"2015-09-22 21:37:31.000000000","message":"Suggest (so as to make it clear, syntactically, that we\u0027re talking about the traffic): s/in order to be/so that it is","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"4574f36de7babed120f264a5a7dcd4938d4f55a2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Service Level Agreement (SLA) between an application provider and end"},{"line_number":11,"context_line":"users."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Network devices such as switches and routers can mark traffic in order to be"},{"line_number":14,"context_line":"handled with a higher priority to fulfill the QoS conditions agreed under"},{"line_number":15,"context_line":"the SLA. In other cases, certain network traffic such as Voice over IP (VoIP)"},{"line_number":16,"context_line":"and video streaming requires to be transmitted with minimal bandwidth"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_09f5c0c9","line":13,"in_reply_to":"ba15a1d1_98bfdc5f","updated":"2015-09-23 15:56:10.000000000","message":"Done","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"81e1c77dd9993fd4afd5a60932d090f1bd4c2004","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Service Level Agreement (SLA) between an application provider and end"},{"line_number":11,"context_line":"users."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Network devices such as switches and routers can mark traffic in order to be"},{"line_number":14,"context_line":"handled with a higher priority to fulfill the QoS conditions agreed under"},{"line_number":15,"context_line":"the SLA. In other cases, certain network traffic such as Voice over IP (VoIP)"},{"line_number":16,"context_line":"and video streaming requires to be transmitted with minimal bandwidth"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_57dc9172","line":13,"in_reply_to":"ba15a1d1_98bfdc5f","updated":"2015-09-23 14:03:51.000000000","message":"thanks :)","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"ad6ae0a7282830907d514df350999544dc0c7ae2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Network devices such as switches and routers can mark traffic in order to be"},{"line_number":14,"context_line":"handled with a higher priority to fulfill the QoS conditions agreed under"},{"line_number":15,"context_line":"the SLA. In other cases, certain network traffic such as Voice over IP (VoIP)"},{"line_number":16,"context_line":"and video streaming requires to be transmitted with minimal bandwidth"},{"line_number":17,"context_line":"constraints. On a system without network QoS management, all traffic will be"},{"line_number":18,"context_line":"transmitted in a \"best-effort\" manner making impossible to guarantee service"},{"line_number":19,"context_line":"delivery to customers."}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_0b64d8e2","line":16,"updated":"2015-09-22 21:37:31.000000000","message":"Suggest (in order to match construction of previous sentence): s/requires to /can\n\n(And if you don\u0027t think that\u0027s right, perhaps suggest: s/requires/needs)","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"4574f36de7babed120f264a5a7dcd4938d4f55a2","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Network devices such as switches and routers can mark traffic in order to be"},{"line_number":14,"context_line":"handled with a higher priority to fulfill the QoS conditions agreed under"},{"line_number":15,"context_line":"the SLA. In other cases, certain network traffic such as Voice over IP (VoIP)"},{"line_number":16,"context_line":"and video streaming requires to be transmitted with minimal bandwidth"},{"line_number":17,"context_line":"constraints. On a system without network QoS management, all traffic will be"},{"line_number":18,"context_line":"transmitted in a \"best-effort\" manner making impossible to guarantee service"},{"line_number":19,"context_line":"delivery to customers."}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_692c7c4a","line":16,"in_reply_to":"ba15a1d1_0b64d8e2","updated":"2015-09-23 15:56:10.000000000","message":"Done","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"81e1c77dd9993fd4afd5a60932d090f1bd4c2004","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Network devices such as switches and routers can mark traffic in order to be"},{"line_number":14,"context_line":"handled with a higher priority to fulfill the QoS conditions agreed under"},{"line_number":15,"context_line":"the SLA. In other cases, certain network traffic such as Voice over IP (VoIP)"},{"line_number":16,"context_line":"and video streaming requires to be transmitted with minimal bandwidth"},{"line_number":17,"context_line":"constraints. On a system without network QoS management, all traffic will be"},{"line_number":18,"context_line":"transmitted in a \"best-effort\" manner making impossible to guarantee service"},{"line_number":19,"context_line":"delivery to customers."}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_b75f2de4","line":16,"in_reply_to":"ba15a1d1_0b64d8e2","updated":"2015-09-23 14:03:51.000000000","message":"s/requires/needs sounds good.","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"ad6ae0a7282830907d514df350999544dc0c7ae2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"the SLA. In other cases, certain network traffic such as Voice over IP (VoIP)"},{"line_number":16,"context_line":"and video streaming requires to be transmitted with minimal bandwidth"},{"line_number":17,"context_line":"constraints. On a system without network QoS management, all traffic will be"},{"line_number":18,"context_line":"transmitted in a \"best-effort\" manner making impossible to guarantee service"},{"line_number":19,"context_line":"delivery to customers."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_4b12d00a","line":18,"updated":"2015-09-22 21:37:31.000000000","message":"s/making impossible/making it impossible","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"81e1c77dd9993fd4afd5a60932d090f1bd4c2004","unresolved":false,"context_lines":[{"line_number":15,"context_line":"the SLA. In other cases, certain network traffic such as Voice over IP (VoIP)"},{"line_number":16,"context_line":"and video streaming requires to be transmitted with minimal bandwidth"},{"line_number":17,"context_line":"constraints. On a system without network QoS management, all traffic will be"},{"line_number":18,"context_line":"transmitted in a \"best-effort\" manner making impossible to guarantee service"},{"line_number":19,"context_line":"delivery to customers."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_37747d66","line":18,"in_reply_to":"ba15a1d1_4b12d00a","updated":"2015-09-23 14:03:51.000000000","message":"+1","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"4574f36de7babed120f264a5a7dcd4938d4f55a2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"the SLA. In other cases, certain network traffic such as Voice over IP (VoIP)"},{"line_number":16,"context_line":"and video streaming requires to be transmitted with minimal bandwidth"},{"line_number":17,"context_line":"constraints. On a system without network QoS management, all traffic will be"},{"line_number":18,"context_line":"transmitted in a \"best-effort\" manner making impossible to guarantee service"},{"line_number":19,"context_line":"delivery to customers."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_a91a9415","line":18,"in_reply_to":"ba15a1d1_4b12d00a","updated":"2015-09-23 15:56:10.000000000","message":"Done","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"ad6ae0a7282830907d514df350999544dc0c7ae2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"In the most simple case, the property can be represented by a simple Python"},{"line_number":46,"context_line":"list defined on the class."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"For ml2 plugin, the list of supported QoS rule types is defined as a common"},{"line_number":49,"context_line":"subset of rules supported by all active mechanism drivers."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_6b04747d","line":48,"updated":"2015-09-22 21:37:31.000000000","message":"Suggest: s/For ml2/For an ml2 (?)","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"81e1c77dd9993fd4afd5a60932d090f1bd4c2004","unresolved":false,"context_lines":[{"line_number":45,"context_line":"In the most simple case, the property can be represented by a simple Python"},{"line_number":46,"context_line":"list defined on the class."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"For ml2 plugin, the list of supported QoS rule types is defined as a common"},{"line_number":49,"context_line":"subset of rules supported by all active mechanism drivers."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_d72c219b","line":48,"in_reply_to":"ba15a1d1_6b04747d","updated":"2015-09-23 14:03:51.000000000","message":"+1","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"4574f36de7babed120f264a5a7dcd4938d4f55a2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"In the most simple case, the property can be represented by a simple Python"},{"line_number":46,"context_line":"list defined on the class."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"For ml2 plugin, the list of supported QoS rule types is defined as a common"},{"line_number":49,"context_line":"subset of rules supported by all active mechanism drivers."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_89d6b025","line":48,"in_reply_to":"ba15a1d1_6b04747d","updated":"2015-09-23 15:56:10.000000000","message":"Done","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"ad6ae0a7282830907d514df350999544dc0c7ae2","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"On server side:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Enable ``qos`` service in service_plugins."},{"line_number":67,"context_line":"* Set the needed notification_drivers in [qos] section"},{"line_number":68,"context_line":"  (message_queue is the default)."},{"line_number":69,"context_line":"* For ml2, add \u0027qos\u0027 to extension_drivers in [ml2] section."}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_8ed6b625","line":66,"updated":"2015-09-22 21:37:31.000000000","message":"Would it make sense to say how this is done?","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"4574f36de7babed120f264a5a7dcd4938d4f55a2","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"On server side:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Enable ``qos`` service in service_plugins."},{"line_number":67,"context_line":"* Set the needed notification_drivers in [qos] section"},{"line_number":68,"context_line":"  (message_queue is the default)."},{"line_number":69,"context_line":"* For ml2, add \u0027qos\u0027 to extension_drivers in [ml2] section."}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_e9e72c10","line":66,"in_reply_to":"ba15a1d1_8ed6b625","updated":"2015-09-23 15:56:10.000000000","message":"It is out of the scope of this guide. Please, review previous reviews.","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"81e1c77dd9993fd4afd5a60932d090f1bd4c2004","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"On server side:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Enable ``qos`` service in service_plugins."},{"line_number":67,"context_line":"* Set the needed notification_drivers in [qos] section"},{"line_number":68,"context_line":"  (message_queue is the default)."},{"line_number":69,"context_line":"* For ml2, add \u0027qos\u0027 to extension_drivers in [ml2] section."}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_8438b9ef","line":66,"in_reply_to":"ba15a1d1_8ed6b625","updated":"2015-09-23 14:03:51.000000000","message":"read next comment please :)","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"ad6ae0a7282830907d514df350999544dc0c7ae2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"On server side:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Enable ``qos`` service in service_plugins."},{"line_number":67,"context_line":"* Set the needed notification_drivers in [qos] section"},{"line_number":68,"context_line":"  (message_queue is the default)."},{"line_number":69,"context_line":"* For ml2, add \u0027qos\u0027 to extension_drivers in [ml2] section."},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_0ee38606","line":67,"updated":"2015-09-22 21:37:31.000000000","message":"Would it make sense, in this and following bullets, to specify which file(s) are to be modified?","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"4574f36de7babed120f264a5a7dcd4938d4f55a2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"On server side:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Enable ``qos`` service in service_plugins."},{"line_number":67,"context_line":"* Set the needed notification_drivers in [qos] section"},{"line_number":68,"context_line":"  (message_queue is the default)."},{"line_number":69,"context_line":"* For ml2, add \u0027qos\u0027 to extension_drivers in [ml2] section."},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_e4d3ae36","line":67,"in_reply_to":"ba15a1d1_0456e929","updated":"2015-09-23 15:56:10.000000000","message":"I do agree with Miguel Angel.","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"81e1c77dd9993fd4afd5a60932d090f1bd4c2004","unresolved":false,"context_lines":[{"line_number":64,"context_line":"On server side:"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"* Enable ``qos`` service in service_plugins."},{"line_number":67,"context_line":"* Set the needed notification_drivers in [qos] section"},{"line_number":68,"context_line":"  (message_queue is the default)."},{"line_number":69,"context_line":"* For ml2, add \u0027qos\u0027 to extension_drivers in [ml2] section."},{"line_number":70,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_0456e929","line":67,"in_reply_to":"ba15a1d1_0ee38606","updated":"2015-09-23 14:03:51.000000000","message":"I think the specifics should be left to the install guide. Since, the real file paths/names will differ from distribution to distribution.\n\nI\u0027ll personally add a link here when that\u0027s ready.\n\nDoes it sound reasonable?","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"ad6ae0a7282830907d514df350999544dc0c7ae2","unresolved":false,"context_lines":[{"line_number":209,"context_line":"-------------------------"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Administrators are able to enforce policies on tenant ports or networks,"},{"line_number":212,"context_line":"as long as the policy is not shared, the tenant will not be able to detach"},{"line_number":213,"context_line":"any policy attached to a network or port."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"If the policy is shared, the tenant will be able to attach or detach such"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_ae34dadd","line":212,"updated":"2015-09-22 21:37:31.000000000","message":"Suggest: s/networks, as/networks. As","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"81e1c77dd9993fd4afd5a60932d090f1bd4c2004","unresolved":false,"context_lines":[{"line_number":209,"context_line":"-------------------------"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Administrators are able to enforce policies on tenant ports or networks,"},{"line_number":212,"context_line":"as long as the policy is not shared, the tenant will not be able to detach"},{"line_number":213,"context_line":"any policy attached to a network or port."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"If the policy is shared, the tenant will be able to attach or detach such"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_a414dd4c","line":212,"in_reply_to":"ba15a1d1_ae34dadd","updated":"2015-09-23 14:03:51.000000000","message":"+1","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"4574f36de7babed120f264a5a7dcd4938d4f55a2","unresolved":false,"context_lines":[{"line_number":209,"context_line":"-------------------------"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Administrators are able to enforce policies on tenant ports or networks,"},{"line_number":212,"context_line":"as long as the policy is not shared, the tenant will not be able to detach"},{"line_number":213,"context_line":"any policy attached to a network or port."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"If the policy is shared, the tenant will be able to attach or detach such"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_49b738f5","line":212,"in_reply_to":"ba15a1d1_ae34dadd","updated":"2015-09-23 15:56:10.000000000","message":"Done","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"ad6ae0a7282830907d514df350999544dc0c7ae2","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"Rule modification"},{"line_number":220,"context_line":"-----------------"},{"line_number":221,"context_line":"Rules can be modified in runtime, rule modifications will be propagated to any"},{"line_number":222,"context_line":"attached port."},{"line_number":223,"context_line":""},{"line_number":224,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_0e3dc6ba","line":221,"updated":"2015-09-22 21:37:31.000000000","message":"Suggest: s/in runtime, rule/at runtime. Rule","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"81e1c77dd9993fd4afd5a60932d090f1bd4c2004","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"Rule modification"},{"line_number":220,"context_line":"-----------------"},{"line_number":221,"context_line":"Rules can be modified in runtime, rule modifications will be propagated to any"},{"line_number":222,"context_line":"attached port."},{"line_number":223,"context_line":""},{"line_number":224,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_57125158","line":221,"in_reply_to":"ba15a1d1_0e3dc6ba","updated":"2015-09-23 14:03:51.000000000","message":"+1","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"4574f36de7babed120f264a5a7dcd4938d4f55a2","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"Rule modification"},{"line_number":220,"context_line":"-----------------"},{"line_number":221,"context_line":"Rules can be modified in runtime, rule modifications will be propagated to any"},{"line_number":222,"context_line":"attached port."},{"line_number":223,"context_line":""},{"line_number":224,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba15a1d1_e48f2e21","line":221,"in_reply_to":"ba15a1d1_0e3dc6ba","updated":"2015-09-23 15:56:10.000000000","message":"Done","commit_id":"40044503bf278cca5e67969b154ccf346bb84127"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29d73d2c5aa5775e48152cf31b754d86eb3b2228","unresolved":false,"context_lines":[{"line_number":6,"context_line":"functionality of OpenStack Networking."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"QoS is defined as the ability to guarantee certain network requirements"},{"line_number":9,"context_line":"like bandwidth, latency, jitter and reliability in order to satisfy a"},{"line_number":10,"context_line":"Service Level Agreement (SLA) between an application provider and end"},{"line_number":11,"context_line":"users."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_227f39e1","line":9,"updated":"2015-09-24 09:31:12.000000000","message":"jitter and -\u003e jitter, and (comma before \u0027and\u0027).","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"67b4d6d39c40a881fd7b26aa7db5f24f3c28485e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"functionality of OpenStack Networking."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"QoS is defined as the ability to guarantee certain network requirements"},{"line_number":9,"context_line":"like bandwidth, latency, jitter and reliability in order to satisfy a"},{"line_number":10,"context_line":"Service Level Agreement (SLA) between an application provider and end"},{"line_number":11,"context_line":"users."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_b1aa7084","line":9,"in_reply_to":"ba15a1d1_227f39e1","updated":"2015-09-24 16:31:02.000000000","message":"Done","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29d73d2c5aa5775e48152cf31b754d86eb3b2228","unresolved":false,"context_lines":[{"line_number":22,"context_line":"The basics"},{"line_number":23,"context_line":"----------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"QoS is an advanced service plugin. QoS is decoupled from the rest of the"},{"line_number":26,"context_line":"Neutron code on multiple levels and it is available through the ml2 extension"},{"line_number":27,"context_line":"driver."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_628d31d2","line":25,"updated":"2015-09-24 09:31:12.000000000","message":"plugin -\u003e plug-in (please check the whole patch)\n\nhttps://wiki.openstack.org/wiki/Documentation/Conventions#Miscellaneous_words","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"67b4d6d39c40a881fd7b26aa7db5f24f3c28485e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"The basics"},{"line_number":23,"context_line":"----------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"QoS is an advanced service plugin. QoS is decoupled from the rest of the"},{"line_number":26,"context_line":"Neutron code on multiple levels and it is available through the ml2 extension"},{"line_number":27,"context_line":"driver."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_f18ea826","line":25,"in_reply_to":"ba15a1d1_628d31d2","updated":"2015-09-24 16:31:02.000000000","message":"Done","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29d73d2c5aa5775e48152cf31b754d86eb3b2228","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Supported QoS rule types"},{"line_number":35,"context_line":"------------------------"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Any plugin or ml2 mechanism driver can claim support for some QoS rule types by"},{"line_number":38,"context_line":"providing a plugin/driver class property called \u0027supported_qos_rule_types\u0027 that"},{"line_number":39,"context_line":"returns a list of strings that correspond to QoS rule types:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_c2e43da9","line":36,"updated":"2015-09-24 09:31:12.000000000","message":"do we need to capitalize \u0027ml2\u0027 -\u003e ML2?","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"67b4d6d39c40a881fd7b26aa7db5f24f3c28485e","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Supported QoS rule types"},{"line_number":35,"context_line":"------------------------"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Any plugin or ml2 mechanism driver can claim support for some QoS rule types by"},{"line_number":38,"context_line":"providing a plugin/driver class property called \u0027supported_qos_rule_types\u0027 that"},{"line_number":39,"context_line":"returns a list of strings that correspond to QoS rule types:"}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_31dbc01d","line":36,"in_reply_to":"ba15a1d1_c2e43da9","updated":"2015-09-24 16:31:02.000000000","message":"No, we don\u0027t. Neutron always uses \u0027ml2\u0027","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d20db9d3b0a527abb2b23796a00afdad8f011b53","unresolved":false,"context_lines":[{"line_number":45,"context_line":"In the most simple case, the property can be represented by a simple Python"},{"line_number":46,"context_line":"list defined on the class."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"For an ml2 plugin, the list of supported QoS rule types is defined as a common"},{"line_number":49,"context_line":"subset of rules supported by all active mechanism drivers."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_c2319d5a","line":48,"updated":"2015-09-24 09:05:05.000000000","message":"there is only one ml2 plugin, so \u0027an\u0027 does not apply.","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"67b4d6d39c40a881fd7b26aa7db5f24f3c28485e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"In the most simple case, the property can be represented by a simple Python"},{"line_number":46,"context_line":"list defined on the class."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"For an ml2 plugin, the list of supported QoS rule types is defined as a common"},{"line_number":49,"context_line":"subset of rules supported by all active mechanism drivers."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_f1b548d0","line":48,"in_reply_to":"ba15a1d1_c2319d5a","updated":"2015-09-24 16:31:02.000000000","message":"Done","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29d73d2c5aa5775e48152cf31b754d86eb3b2228","unresolved":false,"context_lines":[{"line_number":59,"context_line":"Configuration"},{"line_number":60,"context_line":"-------------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"To enable the service, the following steps should be followed:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"On server side:"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_6229b19a","line":62,"updated":"2015-09-24 09:31:12.000000000","message":"the following steps should be followed -\u003e follow the steps below (to avoid passive voice)","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"67b4d6d39c40a881fd7b26aa7db5f24f3c28485e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"Configuration"},{"line_number":60,"context_line":"-------------"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"To enable the service, the following steps should be followed:"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"On server side:"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_314980d1","line":62,"in_reply_to":"ba15a1d1_6229b19a","updated":"2015-09-24 16:31:02.000000000","message":"Done","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"0fcfb2e27696bd2b348c1245f43b3f3b82210dfb","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. note::"},{"line_number":76,"context_line":"   QoS currently works with ml2 only (SR-IOV and Open vSwitch are the only"},{"line_number":77,"context_line":"   drivers that are enabled for QoS in Liberty release)."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Trusted tenants policy.json configuration"},{"line_number":80,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_9142153d","line":77,"updated":"2015-09-24 07:08:32.000000000","message":"Is it possible to add example configurations for server and agent?","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"c090167f1c8eb603b1d3338542337223da6cb993","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. note::"},{"line_number":76,"context_line":"   QoS currently works with ml2 only (SR-IOV and Open vSwitch are the only"},{"line_number":77,"context_line":"   drivers that are enabled for QoS in Liberty release)."},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Trusted tenants policy.json configuration"},{"line_number":80,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_47eeffed","line":77,"in_reply_to":"ba15a1d1_9142153d","updated":"2015-09-24 08:27:03.000000000","message":"Hi Itzik,\nAs per previous patchset discussions that belongs to the deployment/install guide, we will add a link from here when that\u0027s ready.\n\nCheers :)","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29d73d2c5aa5775e48152cf31b754d86eb3b2228","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    | max_kbps       | 3000                                 |"},{"line_number":134,"context_line":"    +----------------+--------------------------------------+"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Second, associate the created policy with an existing neutron port."},{"line_number":137,"context_line":"In order to do this, user should extract the port id to be associated to"},{"line_number":138,"context_line":"the already created policy. In the next example, we will assign the"},{"line_number":139,"context_line":"``bw-limiter`` policy to the VM with IP address 10.0.0.3"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_70ff3866","line":136,"updated":"2015-09-24 09:31:12.000000000","message":"Could we change \u0027user should extract\u0027 to \u0027extract\u0027?","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"67b4d6d39c40a881fd7b26aa7db5f24f3c28485e","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    | max_kbps       | 3000                                 |"},{"line_number":134,"context_line":"    +----------------+--------------------------------------+"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"Second, associate the created policy with an existing neutron port."},{"line_number":137,"context_line":"In order to do this, user should extract the port id to be associated to"},{"line_number":138,"context_line":"the already created policy. In the next example, we will assign the"},{"line_number":139,"context_line":"``bw-limiter`` policy to the VM with IP address 10.0.0.3"}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_916acc19","line":136,"in_reply_to":"ba15a1d1_70ff3866","updated":"2015-09-24 16:31:02.000000000","message":"Done","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29d73d2c5aa5775e48152cf31b754d86eb3b2228","unresolved":false,"context_lines":[{"line_number":191,"context_line":"   | tenant_id             | 85b859134de2428d94f6ee910dc545d8                 |"},{"line_number":192,"context_line":"   +-----------------------+--------------------------------------------------+"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Networks can also be attached to a QoS policy. The meaning of this is that"},{"line_number":195,"context_line":"any compute port connected to the network will use the network policy by"},{"line_number":196,"context_line":"default unless the port has a specific policy attached to it. Network owned"},{"line_number":197,"context_line":"ports are excluded from network policy application."}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_9091ac49","line":194,"updated":"2015-09-24 09:31:12.000000000","message":"Networks can also be attached to a QoS policy. -\u003e You can attach networks to a QoS policy. (to avoid passive)","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"67b4d6d39c40a881fd7b26aa7db5f24f3c28485e","unresolved":false,"context_lines":[{"line_number":191,"context_line":"   | tenant_id             | 85b859134de2428d94f6ee910dc545d8                 |"},{"line_number":192,"context_line":"   +-----------------------+--------------------------------------------------+"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"Networks can also be attached to a QoS policy. The meaning of this is that"},{"line_number":195,"context_line":"any compute port connected to the network will use the network policy by"},{"line_number":196,"context_line":"default unless the port has a specific policy attached to it. Network owned"},{"line_number":197,"context_line":"ports are excluded from network policy application."}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_4306a921","line":194,"in_reply_to":"ba15a1d1_9091ac49","updated":"2015-09-24 16:31:02.000000000","message":"Done","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":4727,"name":"Itzik Brown","email":"itzikb@redhat.com","username":"itzikb1"},"change_message_id":"0fcfb2e27696bd2b348c1245f43b3f3b82210dfb","unresolved":false,"context_lines":[{"line_number":194,"context_line":"Networks can also be attached to a QoS policy. The meaning of this is that"},{"line_number":195,"context_line":"any compute port connected to the network will use the network policy by"},{"line_number":196,"context_line":"default unless the port has a specific policy attached to it. Network owned"},{"line_number":197,"context_line":"ports are excluded from network policy application."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"In order to attach a QoS policy to a network we can update an existing"},{"line_number":200,"context_line":"network, or initially create the network attached to the policy."}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_361e9f70","line":197,"updated":"2015-09-24 07:08:32.000000000","message":"Are you referring to DHCP and Router ports?","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"c090167f1c8eb603b1d3338542337223da6cb993","unresolved":false,"context_lines":[{"line_number":194,"context_line":"Networks can also be attached to a QoS policy. The meaning of this is that"},{"line_number":195,"context_line":"any compute port connected to the network will use the network policy by"},{"line_number":196,"context_line":"default unless the port has a specific policy attached to it. Network owned"},{"line_number":197,"context_line":"ports are excluded from network policy application."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"In order to attach a QoS policy to a network we can update an existing"},{"line_number":200,"context_line":"network, or initially create the network attached to the policy."}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_e7b5d3ec","line":197,"in_reply_to":"ba15a1d1_361e9f70","updated":"2015-09-24 08:27:03.000000000","message":"Yes, those are DHCP and router ports, I will add a note and be more explicit. Those are also LBaaS ports, etc..","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"67b4d6d39c40a881fd7b26aa7db5f24f3c28485e","unresolved":false,"context_lines":[{"line_number":194,"context_line":"Networks can also be attached to a QoS policy. The meaning of this is that"},{"line_number":195,"context_line":"any compute port connected to the network will use the network policy by"},{"line_number":196,"context_line":"default unless the port has a specific policy attached to it. Network owned"},{"line_number":197,"context_line":"ports are excluded from network policy application."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"In order to attach a QoS policy to a network we can update an existing"},{"line_number":200,"context_line":"network, or initially create the network attached to the policy."}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_b608212a","line":197,"in_reply_to":"ba15a1d1_e7b5d3ec","updated":"2015-09-24 16:31:02.000000000","message":"Done","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29d73d2c5aa5775e48152cf31b754d86eb3b2228","unresolved":false,"context_lines":[{"line_number":196,"context_line":"default unless the port has a specific policy attached to it. Network owned"},{"line_number":197,"context_line":"ports are excluded from network policy application."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"In order to attach a QoS policy to a network we can update an existing"},{"line_number":200,"context_line":"network, or initially create the network attached to the policy."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_f0ea68d7","line":199,"updated":"2015-09-24 09:31:12.000000000","message":"to a network we can update -\u003e to a network, update","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"67b4d6d39c40a881fd7b26aa7db5f24f3c28485e","unresolved":false,"context_lines":[{"line_number":196,"context_line":"default unless the port has a specific policy attached to it. Network owned"},{"line_number":197,"context_line":"ports are excluded from network policy application."},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"In order to attach a QoS policy to a network we can update an existing"},{"line_number":200,"context_line":"network, or initially create the network attached to the policy."},{"line_number":201,"context_line":""},{"line_number":202,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_96371de3","line":199,"in_reply_to":"ba15a1d1_f0ea68d7","updated":"2015-09-24 16:31:02.000000000","message":"Done","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29d73d2c5aa5775e48152cf31b754d86eb3b2228","unresolved":false,"context_lines":[{"line_number":209,"context_line":"-------------------------"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Administrators are able to enforce policies on tenant ports or networks."},{"line_number":212,"context_line":"As long as the policy is not shared, the tenant will not be able to detach"},{"line_number":213,"context_line":"any policy attached to a network or port."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"If the policy is shared, the tenant will be able to attach or detach such"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_d053a4e0","line":212,"updated":"2015-09-24 09:31:12.000000000","message":"Could we avoid future tense here?  will not be able -\u003e is not able","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"67b4d6d39c40a881fd7b26aa7db5f24f3c28485e","unresolved":false,"context_lines":[{"line_number":209,"context_line":"-------------------------"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"Administrators are able to enforce policies on tenant ports or networks."},{"line_number":212,"context_line":"As long as the policy is not shared, the tenant will not be able to detach"},{"line_number":213,"context_line":"any policy attached to a network or port."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"If the policy is shared, the tenant will be able to attach or detach such"}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_b66d81ce","line":212,"in_reply_to":"ba15a1d1_d053a4e0","updated":"2015-09-24 16:31:02.000000000","message":"Done","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29d73d2c5aa5775e48152cf31b754d86eb3b2228","unresolved":false,"context_lines":[{"line_number":212,"context_line":"As long as the policy is not shared, the tenant will not be able to detach"},{"line_number":213,"context_line":"any policy attached to a network or port."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"If the policy is shared, the tenant will be able to attach or detach such"},{"line_number":216,"context_line":"policy from its own ports and networks."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_f06588ae","line":215,"updated":"2015-09-24 09:31:12.000000000","message":"likewise","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"67b4d6d39c40a881fd7b26aa7db5f24f3c28485e","unresolved":false,"context_lines":[{"line_number":212,"context_line":"As long as the policy is not shared, the tenant will not be able to detach"},{"line_number":213,"context_line":"any policy attached to a network or port."},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"If the policy is shared, the tenant will be able to attach or detach such"},{"line_number":216,"context_line":"policy from its own ports and networks."},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_3662d1d9","line":215,"in_reply_to":"ba15a1d1_f06588ae","updated":"2015-09-24 16:31:02.000000000","message":"Done","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"29d73d2c5aa5775e48152cf31b754d86eb3b2228","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"Rule modification"},{"line_number":220,"context_line":"-----------------"},{"line_number":221,"context_line":"Rules can be modified at runtime. Rule modifications will be propagated to any"},{"line_number":222,"context_line":"attached port."},{"line_number":223,"context_line":""},{"line_number":224,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":12,"id":"ba15a1d1_f01348ff","line":221,"updated":"2015-09-24 09:31:12.000000000","message":"Could we change to active voice: Rules can be modified -\u003e You can modify rules","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"67b4d6d39c40a881fd7b26aa7db5f24f3c28485e","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"Rule modification"},{"line_number":220,"context_line":"-----------------"},{"line_number":221,"context_line":"Rules can be modified at runtime. Rule modifications will be propagated to any"},{"line_number":222,"context_line":"attached port."},{"line_number":223,"context_line":""},{"line_number":224,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":12,"id":"9a1a9d01_f69a19c5","line":221,"in_reply_to":"ba15a1d1_f01348ff","updated":"2015-09-24 16:31:02.000000000","message":"Done","commit_id":"e51ddd34745e4d39a61fdf264b4c6a3393ab506e"}]}