)]}'
{"id":"openstack%2Fopenstack-manuals~233451","triplet_id":"openstack%2Fopenstack-manuals~master~Ia778c3a7e18d053043643d376305f8f4519d5c96","project":"openstack/openstack-manuals","branch":"master","topic":"rst_remove_command","hashtags":[],"change_id":"Ia778c3a7e18d053043643d376305f8f4519d5c96","subject":"RST cleanup: remove the command directive","status":"ABANDONED","created":"2015-10-11 14:39:34.000000000","updated":"2015-10-12 09:55:08.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d7daebf17aa60a5ec6390326024dbb2f14736d56","_number":233451,"virtual_id_number":233451,"owner":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":9162,"name":"Lana Brindley","email":"openstack@lanabrindley.com","username":"loquacity"},{"date":"2015-10-11 16:34:20.000000000","_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},{"date":"2015-10-11 14:49:14.000000000","_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},{"date":"2015-10-11 17:16:53.000000000","_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":1,"date":"2015-10-11 15:01:21.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9162,"name":"Lana Brindley","email":"openstack@lanabrindley.com","username":"loquacity"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"all":[{"date":"2015-10-11 17:16:17.000000000","_account_id":9162,"name":"Lana Brindley","email":"openstack@lanabrindley.com","username":"loquacity"},{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},{"value":-1,"date":"2015-10-11 18:04:39.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":9162,"name":"Lana Brindley","email":"openstack@lanabrindley.com","username":"loquacity"},{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-11 15:01:21.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-10-11 16:34:20.000000000","updated_by":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"reviewer":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"state":"REVIEWER"},{"updated":"2015-10-11 17:16:17.000000000","updated_by":{"_account_id":9162,"name":"Lana Brindley","email":"openstack@lanabrindley.com","username":"loquacity"},"reviewer":{"_account_id":9162,"name":"Lana Brindley","email":"openstack@lanabrindley.com","username":"loquacity"},"state":"REVIEWER"},{"updated":"2015-10-11 17:16:53.000000000","updated_by":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"reviewer":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"state":"REVIEWER"}],"messages":[{"id":"930b5f128b805dd5b6b1ef95d57bbf33efe06a8a","author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"date":"2015-10-11 14:39:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dd3074314f8657c4f9a8e0fb4b2c39fe8324bda3","author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"date":"2015-10-11 14:41:15.000000000","message":"Patch Set 1:\n\nCan you delay non-content patches that impact the installation guide until after the Liberty release?","accounts_in_message":[],"_revision_number":1},{"id":"b3f0e17168843f5917dce69861f3723d0fab2b45","author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"date":"2015-10-11 14:42:15.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":1},{"id":"f34198f55e885c846f39a104410e716beae53bec","author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"date":"2015-10-11 14:49:14.000000000","message":"Patch Set 2:\n\nI can delay them, yes. I saw no bigger open review requests for the install guide and thought it is fine to include the changes there right now.","accounts_in_message":[],"_revision_number":2},{"id":"7d1a4d634880620042c1e22a63a93faaeedc7829","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-11 15:01:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-manuals-tox-checkniceness http://logs.openstack.org/51/233451/2/check/gate-openstack-manuals-tox-checkniceness/eff387b/ : SUCCESS in 2m 35s\n- gate-openstack-manuals-tox-checkdeletions http://logs.openstack.org/51/233451/2/check/gate-openstack-manuals-tox-checkdeletions/8f20d00/ : SUCCESS in 2m 04s\n- gate-openstack-manuals-tox-doc-publish-checkbuild http://docs-draft.openstack.org/51/233451/2/check/gate-openstack-manuals-tox-doc-publish-checkbuild/be13c95//publish-docs/ : SUCCESS in 14m 52s","accounts_in_message":[],"_revision_number":2},{"id":"0ffebec934be954961eda8f55836c7a81d217eef","author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"date":"2015-10-11 16:34:20.000000000","message":"Patch Set 2:\n\nDepending on the service complexity, updates for a release can take several days or more to fully validate, at least for me given other duties. For better or worse, I tend to work locally and make patches mostly complete before uploading them. If I realize a change to a service may impact other parts of the guide, I usually send a note to the e-mail list. If it helps, I could upload a very small patch when I begin working on a particular service, but it probably wouldn\u0027t indicate all of the files that a mostly complete or final patch would impact.","accounts_in_message":[],"_revision_number":2},{"id":"4b4eb7deb518e6cb2b2daba2abd8e04b564cc427","author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"date":"2015-10-11 16:38:18.000000000","message":"Patch Set 2:\n\nAlso, Git doesn\u0027t necessarily handle rebases of documentation structure/syntax very well, especially with a bunch of white space or line length changes. Hence, such changes that impact the installation guide and other release-critical documentation should probably wait until the Liberty testing matrix indicates successful testing for each of the distros we intend to publish.","accounts_in_message":[],"_revision_number":2},{"id":"3cf02f2d1abd11e9c4c22812ba4e922fd836a393","author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"date":"2015-10-11 16:40:28.000000000","message":"Patch Set 2:\n\nThanks for your explanations, Matt. I will remove the files changed in the install guide when I completed an other review. We can cleanup the install guide after completing the liberty spec.","accounts_in_message":[],"_revision_number":2},{"id":"c0c70c27d164ac0e5ef7c093c22caa863150b671","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2015-10-11 17:16:53.000000000","message":"Patch Set 2:\n\nChristian,\n\nI don\u0027t see a need for this cleanup. Based on the discussion both forms are fine and neither will get a -1.\n\nSo, this won\u0027t get a +2 from me, I consider it just a waste of all our time. I\u0027m not blocking it either, just commenting that  I won\u0027t review it...","accounts_in_message":[],"_revision_number":2},{"id":"d85845c84775a708d258d593082ff13c30a615a0","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2015-10-11 17:20:01.000000000","message":"Patch Set 2:\n\nBtw. this will break translations of the manuals and therefore I suggest to not do these cleanups at all.\n\nIf you change text for other reasons, go for it - but let\u0027s not break already translated content.","accounts_in_message":[],"_revision_number":2},{"id":"82ea62c1eddd842e07161fadc7973ec9becb7a65","author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"date":"2015-10-11 18:01:00.000000000","message":"Patch Set 2:\n\nI like to have a consistent syntax in all RST files. It is fine for me to not clean up the syntax if this is the viewpoint of the majority. Should I move this discussion to the mailing list?","accounts_in_message":[],"_revision_number":2},{"id":"44e188161ef5ddda53e2c063a1be8901b13ef121","author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"date":"2015-10-11 18:04:39.000000000","message":"Patch Set 2: Workflow-1","accounts_in_message":[],"_revision_number":2},{"id":"6551a6e51985d51bdeb83be0632012b36d4eee28","author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"date":"2015-10-12 09:55:08.000000000","message":"Abandoned\n\nwe decided to no clean up","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"cca1c0db85305573ea686f3745906f0c7445f8bc","revisions":{"34ca2fc0efaa328b1e3a4f6888c871ffc81a50a8":{"kind":"REWORK","_number":1,"created":"2015-10-11 14:39:34.000000000","uploader":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"ref":"refs/changes/51/233451/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-manuals","ref":"refs/changes/51/233451/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-manuals refs/changes/51/233451/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-manuals refs/changes/51/233451/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-manuals refs/changes/51/233451/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-manuals refs/changes/51/233451/1"}}},"commit":{"parents":[{"commit":"537123bd8a8c4c98b6acbea078a2a7e38a59240b","subject":"RST cleanup: remove line numbering from code listings","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-manuals/commit/537123bd8a8c4c98b6acbea078a2a7e38a59240b"}]}],"author":{"name":"Christian Berendt","email":"berendt@b1-systems.de","date":"2015-10-11 14:27:00.000000000","tz":120},"committer":{"name":"Christian Berendt","email":"berendt@b1-systems.de","date":"2015-10-11 14:39:48.000000000","tz":120},"subject":"RST cleanup: remove the command directive","message":"RST cleanup: remove the command directive\n\nChange-Id: Ia778c3a7e18d053043643d376305f8f4519d5c96\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-manuals/commit/34ca2fc0efaa328b1e3a4f6888c871ffc81a50a8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-manuals/commit/34ca2fc0efaa328b1e3a4f6888c871ffc81a50a8"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"537123bd8a8c4c98b6acbea078a2a7e38a59240b","is_merged_in_target_branch":false,"change_id":"If421d82e4c3522a008054c31a2003e81d591bbd3","change_number":233447,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"cca1c0db85305573ea686f3745906f0c7445f8bc":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2015-10-11 14:42:15.000000000","uploader":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"ref":"refs/changes/51/233451/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-manuals","ref":"refs/changes/51/233451/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-manuals refs/changes/51/233451/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-manuals refs/changes/51/233451/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-manuals refs/changes/51/233451/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-manuals refs/changes/51/233451/2"}}},"commit":{"parents":[{"commit":"f12cf266c6ce540662cdbf3645d7247ba12d493d","subject":"RST cleanup: remove line numbering from code listings","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-manuals/commit/f12cf266c6ce540662cdbf3645d7247ba12d493d"}]}],"author":{"name":"Christian Berendt","email":"berendt@b1-systems.de","date":"2015-10-11 14:27:00.000000000","tz":120},"committer":{"name":"Christian Berendt","email":"christian@berendt.io","date":"2015-10-11 14:42:15.000000000","tz":0},"subject":"RST cleanup: remove the command directive","message":"RST cleanup: remove the command directive\n\nChange-Id: Ia778c3a7e18d053043643d376305f8f4519d5c96\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-manuals/commit/cca1c0db85305573ea686f3745906f0c7445f8bc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-manuals/commit/cca1c0db85305573ea686f3745906f0c7445f8bc"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f12cf266c6ce540662cdbf3645d7247ba12d493d","is_merged_in_target_branch":false,"change_id":"If421d82e4c3522a008054c31a2003e81d591bbd3","change_number":233447,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}