)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},"change_message_id":"ba7008311c1bc3f988a58d93db3a4c0393a556d8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sawangpong muadphet \u003csawangpongm@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-27 14:23:18 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add document for neutron-linuxbridge-cleanup utility in"},{"line_number":8,"context_line":"neutron/cmd/linuxbridge_cleanup.py.  I add document in miscellaneous"},{"line_number":9,"context_line":"section of network-guide and explain basic feature of the function"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a29b11f_ff287335","line":7,"updated":"2015-10-27 05:48:23.000000000","message":"The title is too long\nhttp://docs.openstack.org/infra/manual/developers.html","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"75d11dd1c2be0cb6b4f7667aeb6e4c24b87dc62a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sawangpong muadphet \u003csawangpongm@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-27 14:23:18 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add document for neutron-linuxbridge-cleanup utility in"},{"line_number":8,"context_line":"neutron/cmd/linuxbridge_cleanup.py.  I add document in miscellaneous"},{"line_number":9,"context_line":"section of network-guide and explain basic feature of the function"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a26ad4f_62540854","line":7,"in_reply_to":"3a29b11f_ff287335","updated":"2015-10-27 11:54:57.000000000","message":"+1. Please check the section http://docs.openstack.org/infra/manual/developers.html#committing-a-change for more details. Also, please separate the title and the body of commit msg with a blank line.\n\nAlso, are we going to add details how to use this utility? If so, change Closes-Bug: to Partial-Bug:","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"57c3a4ea20729e3af5e336c3779a01f424d7703a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sawangpong muadphet \u003csawangpongm@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-27 22:24:42 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This commit I rewrite format and polish grammar also edit document base on"},{"line_number":8,"context_line":"Patch Set 5 Code-Review 1."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ib15d288cece25cb759f341ab5aed236778e57cb7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a26ad4f_4b09c92b","line":7,"updated":"2015-10-28 07:23:18.000000000","message":"Please have a look at https://wiki.openstack.org/wiki/GitCommitMessages how to write a commit message (rewrite the title).","commit_id":"308eb07d191b812a853b9ff4ca5652eb2582dba6"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"c68fbc5ee92efa93f361550ceae1fdaccc713ca9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sawangpong muadphet \u003csawangpongm@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-27 22:24:42 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This commit I rewrite format and polish grammar also edit document base on"},{"line_number":8,"context_line":"Patch Set 5 Code-Review 1."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ib15d288cece25cb759f341ab5aed236778e57cb7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a26ad4f_71aa74d6","line":7,"in_reply_to":"1a26ad4f_4b09c92b","updated":"2015-11-05 03:40:24.000000000","message":"Thank you very much.","commit_id":"308eb07d191b812a853b9ff4ca5652eb2582dba6"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"57c3a4ea20729e3af5e336c3779a01f424d7703a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-10-27 22:24:42 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This commit I rewrite format and polish grammar also edit document base on"},{"line_number":8,"context_line":"Patch Set 5 Code-Review 1."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ib15d288cece25cb759f341ab5aed236778e57cb7"},{"line_number":11,"context_line":"Closes-Bug: #1503244"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a26ad4f_6b0e0536","line":8,"updated":"2015-10-28 07:23:18.000000000","message":"This can be removed.","commit_id":"308eb07d191b812a853b9ff4ca5652eb2582dba6"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"c68fbc5ee92efa93f361550ceae1fdaccc713ca9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-10-27 22:24:42 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This commit I rewrite format and polish grammar also edit document base on"},{"line_number":8,"context_line":"Patch Set 5 Code-Review 1."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ib15d288cece25cb759f341ab5aed236778e57cb7"},{"line_number":11,"context_line":"Closes-Bug: #1503244"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a26ad4f_5183b8cc","line":8,"in_reply_to":"1a26ad4f_6b0e0536","updated":"2015-11-05 03:40:24.000000000","message":"Done","commit_id":"308eb07d191b812a853b9ff4ca5652eb2582dba6"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"3a16a6dbc8629d14dbc1bcd272342d4f0ecbcd06","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sawangpong muadphet \u003csawangpongm@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-28 21:28:13 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Networking service linux bridge Cleanup Utility to miscellaneous"},{"line_number":8,"context_line":"section of network-guide"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ib15d288cece25cb759f341ab5aed236778e57cb7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1a26ad4f_cc888525","line":7,"updated":"2015-10-28 15:09:16.000000000","message":"The first line should be limited to 50 characters and should not end with a period. Insert a single blank line after the first line. i.e. can not write commit message using two lines, use only one line.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"bc6df03d4435a5e90a25e7c62a3154399e947e4d"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"546473c6e8c1af2720bdfddc2b79b0c62e4154e1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     sawangpong muadphet \u003csawangpongm@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-28 21:28:13 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add Networking service linux bridge Cleanup Utility to miscellaneous"},{"line_number":8,"context_line":"section of network-guide"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ib15d288cece25cb759f341ab5aed236778e57cb7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1a26ad4f_d7f2419a","line":7,"in_reply_to":"1a26ad4f_cc888525","updated":"2015-10-30 02:24:21.000000000","message":"Thank you sir","commit_id":"bc6df03d4435a5e90a25e7c62a3154399e947e4d"}],"doc/networking-guide/source/misc_add_nentron_linuxbridge_clean.rst":[{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"75d11dd1c2be0cb6b4f7667aeb6e4c24b87dc62a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Add Neutron Linuxbridge Cleanup Utility"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_42e22ca1","line":2,"updated":"2015-10-27 11:54:57.000000000","message":"Please use sentence-case capitalization for headings in OpenStack docs.\n\nNeutron -\u003e Networking service (check and fix in all the doc + check other OpenStack services names. http://docs.openstack.org/contributor-guide/writing-style/openstack-components.html ).\n\nLinuxbridge -\u003e Linux bridge","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"08552d9b4e9f3d1946464c6cf94a7f0fc5b52252","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Add Neutron Linuxbridge Cleanup Utility"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_9f48962f","line":2,"in_reply_to":"1a26ad4f_42e22ca1","updated":"2015-10-30 02:24:13.000000000","message":"Done","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"75d11dd1c2be0cb6b4f7667aeb6e4c24b87dc62a","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"},{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"This tool deletes very empty linux bridge managed by linuxbridge agent except the"},{"line_number":8,"context_line":"ones defined by using bridge_mappings option in section  LINUX_BRIDGE"},{"line_number":9,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_28e7cf41","line":7,"updated":"2015-10-27 11:54:57.000000000","message":"very empty linux bridge -\u003e empty Linux bridges\n\nlinuxbridge agent -\u003e linuxbridge-agent","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"08552d9b4e9f3d1946464c6cf94a7f0fc5b52252","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"},{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"This tool deletes very empty linux bridge managed by linuxbridge agent except the"},{"line_number":8,"context_line":"ones defined by using bridge_mappings option in section  LINUX_BRIDGE"},{"line_number":9,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_ff5d0aed","line":7,"in_reply_to":"1a26ad4f_28e7cf41","updated":"2015-10-30 02:24:13.000000000","message":"Done","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"75d11dd1c2be0cb6b4f7667aeb6e4c24b87dc62a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Description"},{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"This tool deletes very empty linux bridge managed by linuxbridge agent except the"},{"line_number":8,"context_line":"ones defined by using bridge_mappings option in section  LINUX_BRIDGE"},{"line_number":9,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Removal of empty bridges have been disabled [1] to fix a race condition"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_c2ecfc91","line":8,"updated":"2015-10-27 11:54:57.000000000","message":"defined by using bridge_mappings -\u003e defined by the ``bridge_mappings``\n\nRemove an extra space after word \u0027section\u0027.\n\nWhat do you mean by LINUX_BRIDGE here? A linuxbridge_conf.ini file? If so, modify your sentence -\u003e ``bridge_mappings`` option in the appropriate section of the ``linuxbridge_conf.ini`` file.","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"75d11dd1c2be0cb6b4f7667aeb6e4c24b87dc62a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"This tool deletes very empty linux bridge managed by linuxbridge agent except the"},{"line_number":8,"context_line":"ones defined by using bridge_mappings option in section  LINUX_BRIDGE"},{"line_number":9,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Removal of empty bridges have been disabled [1] to fix a race condition"},{"line_number":12,"context_line":"between Nova and Neutron where a bridge would be removed if the only"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_e8879710","line":9,"updated":"2015-10-27 11:54:57.000000000","message":"Put a full stop after parenthesis.","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"08552d9b4e9f3d1946464c6cf94a7f0fc5b52252","unresolved":false,"context_lines":[{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"This tool deletes very empty linux bridge managed by linuxbridge agent except the"},{"line_number":8,"context_line":"ones defined by using bridge_mappings option in section  LINUX_BRIDGE"},{"line_number":9,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Removal of empty bridges have been disabled [1] to fix a race condition"},{"line_number":12,"context_line":"between Nova and Neutron where a bridge would be removed if the only"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_bf5792c9","line":9,"in_reply_to":"1a26ad4f_e8879710","updated":"2015-10-30 02:24:13.000000000","message":"Done","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"75d11dd1c2be0cb6b4f7667aeb6e4c24b87dc62a","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Removal of empty bridges have been disabled [1] to fix a race condition"},{"line_number":12,"context_line":"between Nova and Neutron where a bridge would be removed if the only"},{"line_number":13,"context_line":"instance using it is rebooted. This means empty bridges will pile up over time."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":".. note::"},{"line_number":16,"context_line":"    This tool should not be called during an instance created, migrate, etc. as"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_28fcaf3d","line":13,"updated":"2015-10-27 11:54:57.000000000","message":"Do we really need this paragraph? Also, there is no link to [1] here, also grammar should be polished if we need this description.","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"08552d9b4e9f3d1946464c6cf94a7f0fc5b52252","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Removal of empty bridges have been disabled [1] to fix a race condition"},{"line_number":12,"context_line":"between Nova and Neutron where a bridge would be removed if the only"},{"line_number":13,"context_line":"instance using it is rebooted. This means empty bridges will pile up over time."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":".. note::"},{"line_number":16,"context_line":"    This tool should not be called during an instance created, migrate, etc. as"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_df5cceef","line":13,"in_reply_to":"1a26ad4f_28fcaf3d","updated":"2015-10-30 02:24:13.000000000","message":"I remove the whole paragraph","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"75d11dd1c2be0cb6b4f7667aeb6e4c24b87dc62a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"between Nova and Neutron where a bridge would be removed if the only"},{"line_number":13,"context_line":"instance using it is rebooted. This means empty bridges will pile up over time."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":".. note::"},{"line_number":16,"context_line":"    This tool should not be called during an instance created, migrate, etc. as"},{"line_number":17,"context_line":"    it can delete a linux bridge about to be used by nova."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_885b8354","line":15,"updated":"2015-10-27 11:54:57.000000000","message":"I would not use notes for the description below (lines 16-26). Instead, you can create a bullet list with 4 items describing the usage specifics of the script.","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"08552d9b4e9f3d1946464c6cf94a7f0fc5b52252","unresolved":false,"context_lines":[{"line_number":12,"context_line":"between Nova and Neutron where a bridge would be removed if the only"},{"line_number":13,"context_line":"instance using it is rebooted. This means empty bridges will pile up over time."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":".. note::"},{"line_number":16,"context_line":"    This tool should not be called during an instance created, migrate, etc. as"},{"line_number":17,"context_line":"    it can delete a linux bridge about to be used by nova."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_1f0a46d3","line":15,"in_reply_to":"1a26ad4f_885b8354","updated":"2015-10-30 02:24:13.000000000","message":"i rewrite to 4 bullet lists","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"75d11dd1c2be0cb6b4f7667aeb6e4c24b87dc62a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"instance using it is rebooted. This means empty bridges will pile up over time."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":".. note::"},{"line_number":16,"context_line":"    This tool should not be called during an instance created, migrate, etc. as"},{"line_number":17,"context_line":"    it can delete a linux bridge about to be used by nova."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This script can be used to periodically remove empty bridges by running it on"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_c8ebbbaf","line":16,"updated":"2015-10-27 11:54:57.000000000","message":"Do not use this tool when you create or migrate an instance, as it can delete a Linux bridge that Compute service is going to use. ( I\u0027m not sure about the 2nd part of sentence though).","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"08552d9b4e9f3d1946464c6cf94a7f0fc5b52252","unresolved":false,"context_lines":[{"line_number":13,"context_line":"instance using it is rebooted. This means empty bridges will pile up over time."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":".. note::"},{"line_number":16,"context_line":"    This tool should not be called during an instance created, migrate, etc. as"},{"line_number":17,"context_line":"    it can delete a linux bridge about to be used by nova."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This script can be used to periodically remove empty bridges by running it on"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_ffa0aaa7","line":16,"in_reply_to":"1a26ad4f_c8ebbbaf","updated":"2015-10-30 02:24:13.000000000","message":"Done","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"75d11dd1c2be0cb6b4f7667aeb6e4c24b87dc62a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    This tool should not be called during an instance created, migrate, etc. as"},{"line_number":17,"context_line":"    it can delete a linux bridge about to be used by nova."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This script can be used to periodically remove empty bridges by running it on"},{"line_number":20,"context_line":"compute nodes."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_a8fd1f70","line":19,"updated":"2015-10-27 11:54:57.000000000","message":"This script can be used to periodically -\u003e Use this script to","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"08552d9b4e9f3d1946464c6cf94a7f0fc5b52252","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    This tool should not be called during an instance created, migrate, etc. as"},{"line_number":17,"context_line":"    it can delete a linux bridge about to be used by nova."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This script can be used to periodically remove empty bridges by running it on"},{"line_number":20,"context_line":"compute nodes."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_7f7c9a20","line":19,"in_reply_to":"1a26ad4f_a8fd1f70","updated":"2015-10-30 02:24:13.000000000","message":"Done","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"75d11dd1c2be0cb6b4f7667aeb6e4c24b87dc62a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"compute nodes."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":".. note::"},{"line_number":23,"context_line":"    Usage of this script can still trigger the original race condition."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"It should be used when you don\u0027t expect anyone do be doing operations"},{"line_number":26,"context_line":"on their instances."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_0830d355","line":23,"updated":"2015-10-27 11:54:57.000000000","message":"Usage of this script can still... -\u003e When you use this script, it can...","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"08552d9b4e9f3d1946464c6cf94a7f0fc5b52252","unresolved":false,"context_lines":[{"line_number":20,"context_line":"compute nodes."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":".. note::"},{"line_number":23,"context_line":"    Usage of this script can still trigger the original race condition."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"It should be used when you don\u0027t expect anyone do be doing operations"},{"line_number":26,"context_line":"on their instances."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_ff8e6a26","line":23,"in_reply_to":"1a26ad4f_0830d355","updated":"2015-10-30 02:24:13.000000000","message":"Done","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"75d11dd1c2be0cb6b4f7667aeb6e4c24b87dc62a","unresolved":false,"context_lines":[{"line_number":22,"context_line":".. note::"},{"line_number":23,"context_line":"    Usage of this script can still trigger the original race condition."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"It should be used when you don\u0027t expect anyone do be doing operations"},{"line_number":26,"context_line":"on their instances."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a26ad4f_a89e7f05","line":25,"updated":"2015-10-27 11:54:57.000000000","message":"Use the script only when you do not expect...","commit_id":"8bf3a13f23794ba1a13709811fbfd5a99ce01216"}],"doc/networking-guide/source/misc_add_neutron_linuxbridge_clean.rst":[{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"ccba599c12242a4abf44d8f8f3209fd8785a97c6","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"},{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"This tool deletes empty linux bridges managed by linuxbridge-agent except the"},{"line_number":8,"context_line":"ones defined by the ``bridge_mappings`` option in section LINUX_BRIDGE"},{"line_number":9,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a26ad4f_fd02db3d","line":7,"updated":"2015-10-28 06:43:21.000000000","message":"linuxbridge-agent, except those defined by the ... *","commit_id":"308eb07d191b812a853b9ff4ca5652eb2582dba6"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"c68fbc5ee92efa93f361550ceae1fdaccc713ca9","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"},{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"This tool deletes empty linux bridges managed by linuxbridge-agent except the"},{"line_number":8,"context_line":"ones defined by the ``bridge_mappings`` option in section LINUX_BRIDGE"},{"line_number":9,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a26ad4f_66eddc8a","line":7,"in_reply_to":"1a26ad4f_fd02db3d","updated":"2015-11-05 03:40:24.000000000","message":"Done","commit_id":"308eb07d191b812a853b9ff4ca5652eb2582dba6"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"ccba599c12242a4abf44d8f8f3209fd8785a97c6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Description"},{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"This tool deletes empty linux bridges managed by linuxbridge-agent except the"},{"line_number":8,"context_line":"ones defined by the ``bridge_mappings`` option in section LINUX_BRIDGE"},{"line_number":9,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* Do not use this tool when you create or migrate an instance, as it can delete "}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a26ad4f_bdfc633f","line":8,"updated":"2015-10-28 06:43:21.000000000","message":"``LINUX_BRIDGE``","commit_id":"308eb07d191b812a853b9ff4ca5652eb2582dba6"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"c68fbc5ee92efa93f361550ceae1fdaccc713ca9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Description"},{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"This tool deletes empty linux bridges managed by linuxbridge-agent except the"},{"line_number":8,"context_line":"ones defined by the ``bridge_mappings`` option in section LINUX_BRIDGE"},{"line_number":9,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* Do not use this tool when you create or migrate an instance, as it can delete "}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a26ad4f_0603c843","line":8,"in_reply_to":"1a26ad4f_bdfc633f","updated":"2015-11-05 03:40:24.000000000","message":"Done","commit_id":"308eb07d191b812a853b9ff4ca5652eb2582dba6"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"ccba599c12242a4abf44d8f8f3209fd8785a97c6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* Do not use this tool when you create or migrate an instance, as it can delete "},{"line_number":12,"context_line":"  a Linux bridge that Compute service is going to use. "},{"line_number":13,"context_line":"* Use this script to remove empty bridges by running it on compute nodes."},{"line_number":14,"context_line":"* When you use this script, it can trigger the original race condition."},{"line_number":15,"context_line":"* Use the script only when you do not expect anyone do be doing operations on "}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a26ad4f_3d9ff304","line":12,"updated":"2015-10-28 06:43:21.000000000","message":"\"Do not use this tool when creating or migrating an instance, as the instance can delete a Linux bridge.\"","commit_id":"308eb07d191b812a853b9ff4ca5652eb2582dba6"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"c68fbc5ee92efa93f361550ceae1fdaccc713ca9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* Do not use this tool when you create or migrate an instance, as it can delete "},{"line_number":12,"context_line":"  a Linux bridge that Compute service is going to use. "},{"line_number":13,"context_line":"* Use this script to remove empty bridges by running it on compute nodes."},{"line_number":14,"context_line":"* When you use this script, it can trigger the original race condition."},{"line_number":15,"context_line":"* Use the script only when you do not expect anyone do be doing operations on "}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a26ad4f_e6a7ac4d","line":12,"in_reply_to":"1a26ad4f_3d9ff304","updated":"2015-11-05 03:40:24.000000000","message":"Done","commit_id":"308eb07d191b812a853b9ff4ca5652eb2582dba6"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"ccba599c12242a4abf44d8f8f3209fd8785a97c6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  a Linux bridge that Compute service is going to use. "},{"line_number":13,"context_line":"* Use this script to remove empty bridges by running it on compute nodes."},{"line_number":14,"context_line":"* When you use this script, it can trigger the original race condition."},{"line_number":15,"context_line":"* Use the script only when you do not expect anyone do be doing operations on "},{"line_number":16,"context_line":"  their instances."}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a26ad4f_3de8537c","line":15,"updated":"2015-10-28 06:43:21.000000000","message":"The red boxes indicate whitespace, which need to be removed for jenkins to pass the patch successfully.","commit_id":"308eb07d191b812a853b9ff4ca5652eb2582dba6"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"c68fbc5ee92efa93f361550ceae1fdaccc713ca9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  a Linux bridge that Compute service is going to use. "},{"line_number":13,"context_line":"* Use this script to remove empty bridges by running it on compute nodes."},{"line_number":14,"context_line":"* When you use this script, it can trigger the original race condition."},{"line_number":15,"context_line":"* Use the script only when you do not expect anyone do be doing operations on "},{"line_number":16,"context_line":"  their instances."}],"source_content_type":"text/x-rst","patch_set":7,"id":"1a26ad4f_8663581a","line":15,"in_reply_to":"1a26ad4f_3de8537c","updated":"2015-11-05 03:40:24.000000000","message":"I remove with space already. one fail, two success. Could you please guild more why jenkin fail at  \n\"gate-openstack-manuals-tox-checkniceness\"\nthe first test.\nThank you for your help","commit_id":"308eb07d191b812a853b9ff4ca5652eb2582dba6"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"e8959fa23afec7057f6adaaf25a63c06822cd612","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Add Networking service Linux bridge Cleanup Utility"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a26ad4f_a7a66d51","line":2,"updated":"2015-10-29 09:08:30.000000000","message":"What is the correct official name/spelling of this utility?\n\nCan we change to:\n\nAdding neutron-linuxbridge-cleanup utility\n\n\nIf you prefer to leave the first variant, change capitalization and 1st word of the heading (for consistency with the guide\u0027s subsections):\n\nAdding Networking service Linux bridge cleanup utility","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"cbfe840477ad845ca61f1194eff6cef8272e048d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Add Networking service Linux bridge Cleanup Utility"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a26ad4f_b658d4fb","line":2,"in_reply_to":"1a26ad4f_a7a66d51","updated":"2015-10-29 14:22:23.000000000","message":"The source includes this utility, so \"add\" does not belong in the title.\n\nSuggestion: \"Linux bridge agent maintenance utility\"","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"6519891a8324487223892173945d22845089517f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Add Networking service Linux bridge Cleanup Utility"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"}],"source_content_type":"text/x-rst","patch_set":10,"id":"da85f559_8674b8cf","line":2,"in_reply_to":"1a26ad4f_a7a66d51","updated":"2015-11-07 03:21:19.000000000","message":"from code of this module,  there is only \u0027def remove_empty_bridges():\u0027 so I think \u0027Cleanup\u0027 is keyword","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"e8959fa23afec7057f6adaaf25a63c06822cd612","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"},{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"This tool deletes empty linux bridges managed by linuxbridge-agent,"},{"line_number":8,"context_line":"except those defined by the ``bridge_mappings`` option in section"},{"line_number":9,"context_line":"``LINUX_BRIDGE``"},{"line_number":10,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a26ad4f_e7e30504","line":7,"updated":"2015-10-29 09:08:30.000000000","message":"linux -\u003e Linux","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":9382,"name":"Shilla Saebi","email":"shilla.saebi@gmail.com","username":"shillasaebi"},"change_message_id":"63a5105542cf3d5f50ac86f340fb6c4c4d335ad9","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"},{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"This tool deletes empty linux bridges managed by linuxbridge-agent,"},{"line_number":8,"context_line":"except those defined by the ``bridge_mappings`` option in section"},{"line_number":9,"context_line":"``LINUX_BRIDGE``"},{"line_number":10,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)."}],"source_content_type":"text/x-rst","patch_set":10,"id":"fa80f949_851994d9","line":7,"updated":"2015-11-05 23:13:18.000000000","message":"managed by \"the linuxbridge-agent\" \n\ncan you add the here? thank you!","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"6519891a8324487223892173945d22845089517f","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"},{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"This tool deletes empty linux bridges managed by linuxbridge-agent,"},{"line_number":8,"context_line":"except those defined by the ``bridge_mappings`` option in section"},{"line_number":9,"context_line":"``LINUX_BRIDGE``"},{"line_number":10,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)."}],"source_content_type":"text/x-rst","patch_set":10,"id":"da85f559_da5b742d","line":7,"in_reply_to":"1a26ad4f_e7e30504","updated":"2015-11-07 03:21:19.000000000","message":"Done","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"6519891a8324487223892173945d22845089517f","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"},{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"This tool deletes empty linux bridges managed by linuxbridge-agent,"},{"line_number":8,"context_line":"except those defined by the ``bridge_mappings`` option in section"},{"line_number":9,"context_line":"``LINUX_BRIDGE``"},{"line_number":10,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)."}],"source_content_type":"text/x-rst","patch_set":10,"id":"da85f559_da7294ad","line":7,"in_reply_to":"fa80f949_851994d9","updated":"2015-11-07 03:21:19.000000000","message":"Done","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"e8959fa23afec7057f6adaaf25a63c06822cd612","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* Do not use this tool when creating or migrating an instance, as"},{"line_number":13,"context_line":"  the instance can delete a Linux bridge."},{"line_number":14,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":15,"context_line":"  nodes."},{"line_number":16,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":17,"context_line":"  condition."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a26ad4f_678cd535","line":14,"updated":"2015-10-29 09:08:30.000000000","message":"compute -\u003e Compute","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"6519891a8324487223892173945d22845089517f","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* Do not use this tool when creating or migrating an instance, as"},{"line_number":13,"context_line":"  the instance can delete a Linux bridge."},{"line_number":14,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":15,"context_line":"  nodes."},{"line_number":16,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":17,"context_line":"  condition."}],"source_content_type":"text/x-rst","patch_set":10,"id":"da85f559_baa47008","line":14,"in_reply_to":"1a26ad4f_131c3a76","updated":"2015-11-07 03:21:19.000000000","message":"Done","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"6372a3df2cfc0f22cd64937b45a82078ad9e1f83","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* Do not use this tool when creating or migrating an instance, as"},{"line_number":13,"context_line":"  the instance can delete a Linux bridge."},{"line_number":14,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":15,"context_line":"  nodes."},{"line_number":16,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":17,"context_line":"  condition."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a26ad4f_b3e1b400","line":14,"in_reply_to":"1a26ad4f_131c3a76","updated":"2015-11-05 03:39:17.000000000","message":"I do agree with Matthew, Thank you Olena. I looking forward your reviews.","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"6519891a8324487223892173945d22845089517f","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* Do not use this tool when creating or migrating an instance, as"},{"line_number":13,"context_line":"  the instance can delete a Linux bridge."},{"line_number":14,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":15,"context_line":"  nodes."},{"line_number":16,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":17,"context_line":"  condition."}],"source_content_type":"text/x-rst","patch_set":10,"id":"da85f559_5a5f840e","line":14,"in_reply_to":"1a26ad4f_678cd535","updated":"2015-11-07 03:21:19.000000000","message":"Thank you","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"cbfe840477ad845ca61f1194eff6cef8272e048d","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* Do not use this tool when creating or migrating an instance, as"},{"line_number":13,"context_line":"  the instance can delete a Linux bridge."},{"line_number":14,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":15,"context_line":"  nodes."},{"line_number":16,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":17,"context_line":"  condition."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a26ad4f_131c3a76","line":14,"in_reply_to":"1a26ad4f_678cd535","updated":"2015-10-29 14:22:23.000000000","message":"This can be lowercase because it is not referring to the compute service (nova).","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"f8ab7c08e543fe09c1358ed56461f30e3cbe868d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":15,"context_line":"  nodes."},{"line_number":16,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":17,"context_line":"  condition."},{"line_number":18,"context_line":"* Use the script only when you do not expect anyone do be doing"},{"line_number":19,"context_line":"  operations on their instances."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a26ad4f_f07fdddd","line":17,"updated":"2015-11-02 17:02:19.000000000","message":"You should actually explain the race condition.","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":9382,"name":"Shilla Saebi","email":"shilla.saebi@gmail.com","username":"shillasaebi"},"change_message_id":"bbc5c43d6acc09c6b436e9fd66c278838dbe60cd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":15,"context_line":"  nodes."},{"line_number":16,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":17,"context_line":"  condition."},{"line_number":18,"context_line":"* Use the script only when you do not expect anyone do be doing"},{"line_number":19,"context_line":"  operations on their instances."}],"source_content_type":"text/x-rst","patch_set":10,"id":"fa80f949_2b5c9224","line":17,"in_reply_to":"1a26ad4f_f07fdddd","updated":"2015-11-04 04:58:21.000000000","message":"+1 to explaining the race condition","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"e8959fa23afec7057f6adaaf25a63c06822cd612","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  nodes."},{"line_number":16,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":17,"context_line":"  condition."},{"line_number":18,"context_line":"* Use the script only when you do not expect anyone do be doing"},{"line_number":19,"context_line":"  operations on their instances."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a26ad4f_8777b139","line":18,"updated":"2015-10-29 09:08:30.000000000","message":"do -\u003e to","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"6519891a8324487223892173945d22845089517f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  nodes."},{"line_number":16,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":17,"context_line":"  condition."},{"line_number":18,"context_line":"* Use the script only when you do not expect anyone do be doing"},{"line_number":19,"context_line":"  operations on their instances."}],"source_content_type":"text/x-rst","patch_set":10,"id":"da85f559_ba7b107b","line":18,"in_reply_to":"1a26ad4f_8777b139","updated":"2015-11-07 03:21:19.000000000","message":"Done","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"f8ab7c08e543fe09c1358ed56461f30e3cbe868d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":17,"context_line":"  condition."},{"line_number":18,"context_line":"* Use the script only when you do not expect anyone do be doing"},{"line_number":19,"context_line":"  operations on their instances."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a26ad4f_9080e9c0","line":19,"updated":"2015-11-02 17:02:19.000000000","message":"This is poorly worded. Also the concept is bad. Is it reasonable for us to say \"oh, only run this script when _nobody_ in an openstack cluster is doing any operations on their instance\" - when does that happen? Is it reasonable to hope there is a period of time where this can occur?\n\nInstead we should probably say - run this script if you have evacuated all instances off a compute node and you want to clean up the bridges.","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"6519891a8324487223892173945d22845089517f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":17,"context_line":"  condition."},{"line_number":18,"context_line":"* Use the script only when you do not expect anyone do be doing"},{"line_number":19,"context_line":"  operations on their instances."}],"source_content_type":"text/x-rst","patch_set":10,"id":"da85f559_7ac4c891","line":19,"in_reply_to":"1a26ad4f_9080e9c0","updated":"2015-11-07 03:21:19.000000000","message":"I do agree with you, Sean. I make sense and precise instruction.\nThank you.","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"5b24c841bb69a6fbb2cd9e05c054a9c7edfa81fa","unresolved":false,"context_lines":[{"line_number":16,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":17,"context_line":"  condition."},{"line_number":18,"context_line":"* Use the script only when you do not expect anyone do be doing"},{"line_number":19,"context_line":"  operations on their instances."}],"source_content_type":"text/x-rst","patch_set":10,"id":"1a26ad4f_d34e6b6e","line":19,"in_reply_to":"1a26ad4f_9080e9c0","updated":"2015-11-02 17:08:46.000000000","message":"oh and in addition to evacuating all instances, you should be fencing off the compute node where you are going to run this script so new instances don\u0027t get scheduled on it.","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"6519891a8324487223892173945d22845089517f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":17,"context_line":"  condition."},{"line_number":18,"context_line":"* Use the script only when you do not expect anyone do be doing"},{"line_number":19,"context_line":"  operations on their instances."}],"source_content_type":"text/x-rst","patch_set":10,"id":"da85f559_badc7047","line":19,"in_reply_to":"1a26ad4f_d34e6b6e","updated":"2015-11-07 03:21:19.000000000","message":"Done","commit_id":"e0375e34ea00d96980b69c013234a2cb1bfc546b"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"7bc25e6a2767d9b52338d70c5ec50e6dcb223595","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Add Networking service Linux bridge Cleanup Utility"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"}],"source_content_type":"text/x-rst","patch_set":11,"id":"da85f559_d311165f","line":2,"updated":"2015-11-08 12:27:53.000000000","message":"This title needs work.","commit_id":"a8b1504504c4e80ae6551fd21f316a65976e85ba"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"b31a530968d8fdddc98ba8f2ecabed1d2bd85d2f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Add Networking service Linux bridge Cleanup Utility"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"}],"source_content_type":"text/x-rst","patch_set":11,"id":"da85f559_5d6e6cca","line":2,"in_reply_to":"da85f559_d311165f","updated":"2015-11-09 17:38:47.000000000","message":"Change to: Add neutron-linuxbridge-cleanup util","commit_id":"a8b1504504c4e80ae6551fd21f316a65976e85ba"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"5fbac099756baa0043a7053312ba2f276f9dbd65","unresolved":false,"context_lines":[{"line_number":7,"context_line":"This tool deletes empty linux bridges managed by linuxbridge-agent,"},{"line_number":8,"context_line":"except those defined by the ``bridge_mappings`` option in section"},{"line_number":9,"context_line":"``LINUX_BRIDGE``"},{"line_number":10,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* Do not use this tool when creating or migrating an instance, as"},{"line_number":13,"context_line":"  the instance can delete a Linux bridge."}],"source_content_type":"text/x-rst","patch_set":11,"id":"da85f559_349ac815","line":10,"updated":"2015-11-08 17:09:00.000000000","message":"Linking to a spec may not be a good idea.  It reflects a proposal at a point in time, but not necessarily the current state of things.","commit_id":"a8b1504504c4e80ae6551fd21f316a65976e85ba"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"b31a530968d8fdddc98ba8f2ecabed1d2bd85d2f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"This tool deletes empty linux bridges managed by linuxbridge-agent,"},{"line_number":8,"context_line":"except those defined by the ``bridge_mappings`` option in section"},{"line_number":9,"context_line":"``LINUX_BRIDGE``"},{"line_number":10,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* Do not use this tool when creating or migrating an instance, as"},{"line_number":13,"context_line":"  the instance can delete a Linux bridge."}],"source_content_type":"text/x-rst","patch_set":11,"id":"da85f559_3d112853","line":10,"in_reply_to":"da85f559_349ac815","updated":"2015-11-09 17:38:47.000000000","message":"We may still need it to reference to ``LINUX_BRIDE`` and this can give more understanding.","commit_id":"a8b1504504c4e80ae6551fd21f316a65976e85ba"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"f678794e50e7b7c740b809114fd35207978634b6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* Do not use this tool when creating or migrating an instance, as"},{"line_number":13,"context_line":"  the instance can delete a Linux bridge."},{"line_number":14,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":15,"context_line":"  nodes."},{"line_number":16,"context_line":"* When you use this script, it can trigger the original race"}],"source_content_type":"text/x-rst","patch_set":11,"id":"da85f559_ee80ed48","line":13,"updated":"2015-11-08 12:42:15.000000000","message":"This is not correct. The instance does not delete a bridge. The problem is that the script can run, and delete a bridge out from underneath the agent. The agent could need that bridge to attach a new instance or migrated instance - and when it tries to add the instance to the bridge, it throws an error because the bridge does not exist anymore, and the instance creation/migration will fail.","commit_id":"a8b1504504c4e80ae6551fd21f316a65976e85ba"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"b31a530968d8fdddc98ba8f2ecabed1d2bd85d2f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* Do not use this tool when creating or migrating an instance, as"},{"line_number":13,"context_line":"  the instance can delete a Linux bridge."},{"line_number":14,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":15,"context_line":"  nodes."},{"line_number":16,"context_line":"* When you use this script, it can trigger the original race"}],"source_content_type":"text/x-rst","patch_set":11,"id":"da85f559_b8bbe6c3","line":13,"in_reply_to":"da85f559_ee80ed48","updated":"2015-11-09 17:38:47.000000000","message":"Thank you to clarify me . It\u0027s help me to understand. I get more information from\nhttps://review.openstack.org/#/c/221508/\nhttps://review.openstack.org/#/c/197162/\n\nchange to:\n* Do not use this tool when creating or migrating an instance to bridge because it will throws error when bridge does not exist","commit_id":"a8b1504504c4e80ae6551fd21f316a65976e85ba"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"5fbac099756baa0043a7053312ba2f276f9dbd65","unresolved":false,"context_lines":[{"line_number":14,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":15,"context_line":"  nodes."},{"line_number":16,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":17,"context_line":"  condition."},{"line_number":18,"context_line":"* Use the script only when you do not expect anyone do be doing"},{"line_number":19,"context_line":"  operations on their instances."}],"source_content_type":"text/x-rst","patch_set":11,"id":"da85f559_948934cd","line":17,"updated":"2015-11-08 17:09:00.000000000","message":"What\u0027s the original race condition?","commit_id":"a8b1504504c4e80ae6551fd21f316a65976e85ba"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"b31a530968d8fdddc98ba8f2ecabed1d2bd85d2f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":15,"context_line":"  nodes."},{"line_number":16,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":17,"context_line":"  condition."},{"line_number":18,"context_line":"* Use the script only when you do not expect anyone do be doing"},{"line_number":19,"context_line":"  operations on their instances."}],"source_content_type":"text/x-rst","patch_set":11,"id":"da85f559_5a5af284","line":17,"in_reply_to":"da85f559_948934cd","updated":"2015-11-09 17:38:47.000000000","message":"The original race condition happen between Nova and Neutron. \nhttps://review.openstack.org/#/c/221508/","commit_id":"a8b1504504c4e80ae6551fd21f316a65976e85ba"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"c73c3c1c4d1e569af85344a6483da5d8a4c3ca3b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Add neutron-linuxbridge-cleanup util"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"},{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"Removal of empty bridges have been disabled to fix a race conditions"},{"line_number":8,"context_line":"between Nova and Neutron where a bridge are deleted. This tool"}],"source_content_type":"text/x-rst","patch_set":12,"id":"da85f559_522172fa","line":5,"updated":"2015-11-09 17:55:15.000000000","message":"An additional note that clarifies what setups this is relevant to would be helpful.  In this case, it\u0027s limited to environments using the linuxbridge agent.","commit_id":"233521133d9dc899c56b692b020cd107cffe03ca"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"c73c3c1c4d1e569af85344a6483da5d8a4c3ca3b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"deletes empty Linux bridges managed by the linuxbridge-agent,"},{"line_number":10,"context_line":"except those defined by the ``bridge_mappings`` option in section"},{"line_number":11,"context_line":"``LINUX_BRIDGE``"},{"line_number":12,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"* Do not use this tool when creating or migrating an instance to "},{"line_number":15,"context_line":"  bridge because it will throws error when bridge does not exist."}],"source_content_type":"text/x-rst","patch_set":12,"id":"da85f559_d28322cb","line":12,"updated":"2015-11-09 17:55:15.000000000","message":"I still don\u0027t think linking to a spec is a good idea.  The spec is dev focsed, and is a reflection of a proposal at a point in time, not necessarily long term documentation that will be kept up to date.","commit_id":"233521133d9dc899c56b692b020cd107cffe03ca"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"6759a88383f2051b34f646b60222de47f95a18bd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"deletes empty Linux bridges managed by the linuxbridge-agent,"},{"line_number":10,"context_line":"except those defined by the ``bridge_mappings`` option in section"},{"line_number":11,"context_line":"``LINUX_BRIDGE``"},{"line_number":12,"context_line":"(http://specs.openstack.org/openstack/neutron-specs/specs/liberty/phy-net-bridge-mapping.html)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"* Do not use this tool when creating or migrating an instance to "},{"line_number":15,"context_line":"  bridge because it will throws error when bridge does not exist."}],"source_content_type":"text/x-rst","patch_set":12,"id":"da85f559_5dbf43fb","line":12,"in_reply_to":"da85f559_d28322cb","updated":"2015-11-09 18:13:35.000000000","message":"Thank you very much. This link can be change in future and not necessarily to keep it . Let\u0027s make it right.","commit_id":"233521133d9dc899c56b692b020cd107cffe03ca"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"c73c3c1c4d1e569af85344a6483da5d8a4c3ca3b","unresolved":false,"context_lines":[{"line_number":16,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":17,"context_line":"  nodes."},{"line_number":18,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":19,"context_line":"  conditions."},{"line_number":20,"context_line":"* Run this script if you have evacuated all instances off a compute"},{"line_number":21,"context_line":"  node and you want to clean up the bridges. In addition to evacuating"},{"line_number":22,"context_line":"  all instances, you should be fencing off the compute node where you"}],"source_content_type":"text/x-rst","patch_set":12,"id":"da85f559_72d7d6ed","line":19,"updated":"2015-11-09 17:55:15.000000000","message":"When I commented on this, I was implying that it\u0027s not clear what this was talking about in the text","commit_id":"233521133d9dc899c56b692b020cd107cffe03ca"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"948a5872911ec75fbf916346ac9b3645e2907e72","unresolved":false,"context_lines":[{"line_number":16,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":17,"context_line":"  nodes."},{"line_number":18,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":19,"context_line":"  conditions."},{"line_number":20,"context_line":"* Run this script if you have evacuated all instances off a compute"},{"line_number":21,"context_line":"  node and you want to clean up the bridges. In addition to evacuating"},{"line_number":22,"context_line":"  all instances, you should be fencing off the compute node where you"}],"source_content_type":"text/x-rst","patch_set":12,"id":"da85f559_01ff0d68","line":19,"in_reply_to":"da85f559_72d7d6ed","updated":"2015-11-09 21:32:09.000000000","message":"Russell,\nFrom my understanding,\nthis script remove empty bridge only, but the race conditions still exists. It\u0027s not in scope of function to solve the race conditions. \noriginal:\nhttps://review.openstack.org/221508\n\nchangeto:\nUsage this script can still trigger the original race condition.\n\nplease review","commit_id":"233521133d9dc899c56b692b020cd107cffe03ca"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"881bc1d0571efd0fb1a5c7764a7d3c0e4aa53565","unresolved":false,"context_lines":[{"line_number":16,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":17,"context_line":"  nodes."},{"line_number":18,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":19,"context_line":"  conditions."},{"line_number":20,"context_line":"* Run this script if you have evacuated all instances off a compute"},{"line_number":21,"context_line":"  node and you want to clean up the bridges. In addition to evacuating"},{"line_number":22,"context_line":"  all instances, you should be fencing off the compute node where you"}],"source_content_type":"text/x-rst","patch_set":13,"id":"da85f559_dd0565c2","line":19,"updated":"2015-11-09 23:29:51.000000000","message":"Please explain what the \u0027origin race conditions\u0027 are.","commit_id":"774fdf151f8b88bf215a65494fe1a759a6ee9cc3"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"a2153ace9a1474a8cd86a922866b52c57b3fa99e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":17,"context_line":"  nodes."},{"line_number":18,"context_line":"* When you use this script, it can trigger the original race"},{"line_number":19,"context_line":"  conditions."},{"line_number":20,"context_line":"* Run this script if you have evacuated all instances off a compute"},{"line_number":21,"context_line":"  node and you want to clean up the bridges. In addition to evacuating"},{"line_number":22,"context_line":"  all instances, you should be fencing off the compute node where you"}],"source_content_type":"text/x-rst","patch_set":13,"id":"da85f559_6302930d","line":19,"in_reply_to":"da85f559_dd0565c2","updated":"2015-11-10 04:33:00.000000000","message":"I explain from my understanding please review it. Thank you","commit_id":"774fdf151f8b88bf215a65494fe1a759a6ee9cc3"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"881bc1d0571efd0fb1a5c7764a7d3c0e4aa53565","unresolved":false,"context_lines":[{"line_number":20,"context_line":"* Run this script if you have evacuated all instances off a compute"},{"line_number":21,"context_line":"  node and you want to clean up the bridges. In addition to evacuating"},{"line_number":22,"context_line":"  all instances, you should be fencing off the compute node where you"},{"line_number":23,"context_line":"  are going to run this script so new instances don\u0027t get scheduled on"},{"line_number":24,"context_line":"  it."}],"source_content_type":"text/x-rst","patch_set":13,"id":"da85f559_1d6d2d98","line":23,"updated":"2015-11-09 23:29:51.000000000","message":"Please use \"do not\" and not contractions.","commit_id":"774fdf151f8b88bf215a65494fe1a759a6ee9cc3"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"a2153ace9a1474a8cd86a922866b52c57b3fa99e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"* Run this script if you have evacuated all instances off a compute"},{"line_number":21,"context_line":"  node and you want to clean up the bridges. In addition to evacuating"},{"line_number":22,"context_line":"  all instances, you should be fencing off the compute node where you"},{"line_number":23,"context_line":"  are going to run this script so new instances don\u0027t get scheduled on"},{"line_number":24,"context_line":"  it."}],"source_content_type":"text/x-rst","patch_set":13,"id":"da85f559_a3087b2e","line":23,"in_reply_to":"da85f559_1d6d2d98","updated":"2015-11-10 04:33:00.000000000","message":"I am not sure where to put \u0027not contractions\u0027","commit_id":"774fdf151f8b88bf215a65494fe1a759a6ee9cc3"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"2a928d15a24879d24833d40eb58d4cefaef677ef","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Add neutron-linuxbridge-cleanup util"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"}],"source_content_type":"text/x-rst","patch_set":14,"id":"da85f559_56a62f54","line":2,"updated":"2015-11-10 05:17:01.000000000","message":"Is this meant to be \u0027utility\u0027 ?","commit_id":"cf7ab58092f46cf50823fcedd6d6264fab766b77"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"1355064296cfd0a29b675af65b0c8c81fb344083","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Add neutron-linuxbridge-cleanup util"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"}],"source_content_type":"text/x-rst","patch_set":14,"id":"da85f559_14a5ffb3","line":2,"in_reply_to":"da85f559_56a62f54","updated":"2015-11-10 10:14:55.000000000","message":"Yes. it mean \u0027utility\u0027.  I think I should reverse back to \u0027utility\u0027.","commit_id":"cf7ab58092f46cf50823fcedd6d6264fab766b77"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"2a928d15a24879d24833d40eb58d4cefaef677ef","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"},{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"Removal of empty bridges have been disabled to fix a race conditions"},{"line_number":8,"context_line":"between Nova and Neutron where a bridge are deleted in the"},{"line_number":9,"context_line":"environments using the linuxbridge-agent. Deleting empty"},{"line_number":10,"context_line":"Linux bridges managed by the linuxbridge-agent."}],"source_content_type":"text/x-rst","patch_set":14,"id":"da85f559_9608172f","line":7,"updated":"2015-11-10 05:17:01.000000000","message":"Rephrase to:\n\n\"Removal of empty bridges have been disabled to fix race conditions between Nova and Neutron.","commit_id":"cf7ab58092f46cf50823fcedd6d6264fab766b77"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"1355064296cfd0a29b675af65b0c8c81fb344083","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"},{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"Removal of empty bridges have been disabled to fix a race conditions"},{"line_number":8,"context_line":"between Nova and Neutron where a bridge are deleted in the"},{"line_number":9,"context_line":"environments using the linuxbridge-agent. Deleting empty"},{"line_number":10,"context_line":"Linux bridges managed by the linuxbridge-agent."}],"source_content_type":"text/x-rst","patch_set":14,"id":"da85f559_7496cb4d","line":7,"in_reply_to":"da85f559_9608172f","updated":"2015-11-10 10:14:55.000000000","message":"Done","commit_id":"cf7ab58092f46cf50823fcedd6d6264fab766b77"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"2a928d15a24879d24833d40eb58d4cefaef677ef","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Linux bridges managed by the linuxbridge-agent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* Do not use this tool when creating or migrating an instance to"},{"line_number":13,"context_line":"  bridge because it will throws error when bridge does not exist."},{"line_number":14,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":15,"context_line":"  nodes."},{"line_number":16,"context_line":"* Usage this script can still trigger the original race condition."}],"source_content_type":"text/x-rst","patch_set":14,"id":"da85f559_767813c5","line":13,"updated":"2015-11-10 05:17:01.000000000","message":"\"Do not use this tool when creating or migrating an instance as it throws an error when the bridge does not exist.\"","commit_id":"cf7ab58092f46cf50823fcedd6d6264fab766b77"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"1355064296cfd0a29b675af65b0c8c81fb344083","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Linux bridges managed by the linuxbridge-agent."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* Do not use this tool when creating or migrating an instance to"},{"line_number":13,"context_line":"  bridge because it will throws error when bridge does not exist."},{"line_number":14,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":15,"context_line":"  nodes."},{"line_number":16,"context_line":"* Usage this script can still trigger the original race condition."}],"source_content_type":"text/x-rst","patch_set":14,"id":"da85f559_1493bf50","line":13,"in_reply_to":"da85f559_767813c5","updated":"2015-11-10 10:14:55.000000000","message":"beautiful phrase.","commit_id":"cf7ab58092f46cf50823fcedd6d6264fab766b77"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"2a928d15a24879d24833d40eb58d4cefaef677ef","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  Neutron. Nova has delegated all of the network fuction to Neutron"},{"line_number":19,"context_line":"  and Nova only maintains a \u0027cache\u0027 of network information. When"},{"line_number":20,"context_line":"  the network cache info do not synchronize with Neutron network"},{"line_number":21,"context_line":"  info, this state run into race condition problems."},{"line_number":22,"context_line":"* Run this script if you have evacuated all instances off a compute"},{"line_number":23,"context_line":"  node and you want to clean up the bridges. In addition to evacuating"},{"line_number":24,"context_line":"  all instances, you should be fencing off the compute node where you"}],"source_content_type":"text/x-rst","patch_set":14,"id":"da85f559_f631630c","line":21,"updated":"2015-11-10 05:17:01.000000000","message":"\"Usage of this script can still trigger the original race condition.\"\n\n-- You have explained what happens with a race condition, but we need to understand WHAT a race condition is. If you could please update this to be clearer? :)","commit_id":"cf7ab58092f46cf50823fcedd6d6264fab766b77"},{"author":{"_account_id":9217,"name":"sawangpong muadphet","email":"sawangpongm@gmail.com","username":"sawangpongm"},"change_message_id":"1355064296cfd0a29b675af65b0c8c81fb344083","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  Neutron. Nova has delegated all of the network fuction to Neutron"},{"line_number":19,"context_line":"  and Nova only maintains a \u0027cache\u0027 of network information. When"},{"line_number":20,"context_line":"  the network cache info do not synchronize with Neutron network"},{"line_number":21,"context_line":"  info, this state run into race condition problems."},{"line_number":22,"context_line":"* Run this script if you have evacuated all instances off a compute"},{"line_number":23,"context_line":"  node and you want to clean up the bridges. In addition to evacuating"},{"line_number":24,"context_line":"  all instances, you should be fencing off the compute node where you"}],"source_content_type":"text/x-rst","patch_set":14,"id":"da85f559_34c6fa9a","line":21,"in_reply_to":"da85f559_f631630c","updated":"2015-11-10 10:14:55.000000000","message":"Done","commit_id":"cf7ab58092f46cf50823fcedd6d6264fab766b77"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e8b676ecb1719ae3f7a6c867de8612917d37d05c","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Description"},{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"Removal of empty bridges have been disabled to fix a race conditions"},{"line_number":8,"context_line":"between Nova and Neutron. Deleting empty Linux bridges managed by"},{"line_number":9,"context_line":"the linuxbridge-agent."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"da85f559_6d7a63f3","line":7,"updated":"2015-11-10 16:15:18.000000000","message":"\"Removal of empty bridges has been disabled to fix a race condition...\"","commit_id":"8a7e0d113aa95cced22f75b20eddc6305fc77d93"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e8b676ecb1719ae3f7a6c867de8612917d37d05c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"Description"},{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"Removal of empty bridges have been disabled to fix a race conditions"},{"line_number":8,"context_line":"between Nova and Neutron. Deleting empty Linux bridges managed by"},{"line_number":9,"context_line":"the linuxbridge-agent."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* Do not use this tool when creating or migrating an instance as it"}],"source_content_type":"text/x-rst","patch_set":15,"id":"da85f559_a8ab591c","line":8,"updated":"2015-11-10 16:15:18.000000000","message":"I believe we use lower-case for project names, so \"nova and neutron\".","commit_id":"8a7e0d113aa95cced22f75b20eddc6305fc77d93"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e8b676ecb1719ae3f7a6c867de8612917d37d05c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"~~~~~~~~~~~"},{"line_number":7,"context_line":"Removal of empty bridges have been disabled to fix a race conditions"},{"line_number":8,"context_line":"between Nova and Neutron. Deleting empty Linux bridges managed by"},{"line_number":9,"context_line":"the linuxbridge-agent."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* Do not use this tool when creating or migrating an instance as it"},{"line_number":12,"context_line":"  throws an error when the bridge does not exist."}],"source_content_type":"text/x-rst","patch_set":15,"id":"da85f559_083705e4","line":9,"updated":"2015-11-10 16:15:18.000000000","message":"I think it would be beneficial to describe the problem here. Something simple like: \"It used to be possible for a bridge to be deleted during the time when the only instance using it was rebooted.\" I\u0027m not sure that the second sentence in this paragraph is needed.","commit_id":"8a7e0d113aa95cced22f75b20eddc6305fc77d93"},{"author":{"_account_id":14643,"name":"Olga Gusarenko","email":"ogusarenko@mirantis.com","username":"Olga"},"change_message_id":"67e20fceb296516e07bbba2d28a13060828cdcb5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Removal of empty bridges have been disabled to fix a race conditions"},{"line_number":8,"context_line":"between Nova and Neutron. Deleting empty Linux bridges managed by"},{"line_number":9,"context_line":"the linuxbridge-agent."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* Do not use this tool when creating or migrating an instance as it"},{"line_number":12,"context_line":"  throws an error when the bridge does not exist."},{"line_number":13,"context_line":"* Use this script to remove empty bridges by running it on compute"}],"source_content_type":"text/x-rst","patch_set":15,"id":"da85f559_f0694726","line":10,"updated":"2015-11-10 16:51:53.000000000","message":"Could you please put some introductory sentence to the option list. It is not clear what it is about at the moment. As far as I understand, it mixes the \"Use\" and \"Do not use\" cases. Probably it makes sense to divided it in two to remove this ambiguity.","commit_id":"8a7e0d113aa95cced22f75b20eddc6305fc77d93"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e8b676ecb1719ae3f7a6c867de8612917d37d05c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  throws an error when the bridge does not exist."},{"line_number":13,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":14,"context_line":"  nodes."},{"line_number":15,"context_line":"* Usage this script can still trigger the original race condition."},{"line_number":16,"context_line":"  Race condition problem happen on interaction between Nova and"},{"line_number":17,"context_line":"  Neutron. Nova has delegated all of the network fuction to Neutron"},{"line_number":18,"context_line":"  and Nova only maintains a \u0027cache\u0027 of network information. When"}],"source_content_type":"text/x-rst","patch_set":15,"id":"da85f559_bf54f020","line":15,"updated":"2015-11-10 16:15:18.000000000","message":"\"Using this script...\" or \"Usage of this script...\"","commit_id":"8a7e0d113aa95cced22f75b20eddc6305fc77d93"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e8b676ecb1719ae3f7a6c867de8612917d37d05c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"* Use this script to remove empty bridges by running it on compute"},{"line_number":14,"context_line":"  nodes."},{"line_number":15,"context_line":"* Usage this script can still trigger the original race condition."},{"line_number":16,"context_line":"  Race condition problem happen on interaction between Nova and"},{"line_number":17,"context_line":"  Neutron. Nova has delegated all of the network fuction to Neutron"},{"line_number":18,"context_line":"  and Nova only maintains a \u0027cache\u0027 of network information. When"},{"line_number":19,"context_line":"  the network cache info do not synchronize with Neutron network"}],"source_content_type":"text/x-rst","patch_set":15,"id":"da85f559_5f9624f1","line":16,"updated":"2015-11-10 16:15:18.000000000","message":"I don\u0027t think lines 16 to 23 are needed with the suggested description on line 9.","commit_id":"8a7e0d113aa95cced22f75b20eddc6305fc77d93"},{"author":{"_account_id":9382,"name":"Shilla Saebi","email":"shilla.saebi@gmail.com","username":"shillasaebi"},"change_message_id":"93afe0c745ae3efe6ca53a37d272e9f3c91df215","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  nodes."},{"line_number":15,"context_line":"* Usage this script can still trigger the original race condition."},{"line_number":16,"context_line":"  Race condition problem happen on interaction between Nova and"},{"line_number":17,"context_line":"  Neutron. Nova has delegated all of the network fuction to Neutron"},{"line_number":18,"context_line":"  and Nova only maintains a \u0027cache\u0027 of network information. When"},{"line_number":19,"context_line":"  the network cache info do not synchronize with Neutron network"},{"line_number":20,"context_line":"  info, this state run into race condition problems. The race"}],"source_content_type":"text/x-rst","patch_set":15,"id":"da85f559_c27c2bee","line":17,"updated":"2015-11-12 00:49:32.000000000","message":"Nova has delegated all of the network functions to neutron and nova only maintains...\n\ncan you change to the above?","commit_id":"8a7e0d113aa95cced22f75b20eddc6305fc77d93"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e8b676ecb1719ae3f7a6c867de8612917d37d05c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  condition problems is happened when multiple processes have been"},{"line_number":22,"context_line":"  operated on single resource with in nearly same time. According to"},{"line_number":23,"context_line":"  this case, it happen in relation between Nova and Neutron."},{"line_number":24,"context_line":"* Run this script if you have evacuated all instances off a compute"},{"line_number":25,"context_line":"  node and you want to clean up the bridges. In addition to evacuating"},{"line_number":26,"context_line":"  all instances, you should be fencing off the compute node where you"},{"line_number":27,"context_line":"  are going to run this script so new instances do not get scheduled on"}],"source_content_type":"text/x-rst","patch_set":15,"id":"da85f559_d2144b45","line":24,"updated":"2015-11-10 16:15:18.000000000","message":"Based on Sean\u0027s review from patch set 10, this should be a continuation of the point above:\n\n\"Using this script can still trigger the original race condition. Only run this script if you have evacuated...\"","commit_id":"8a7e0d113aa95cced22f75b20eddc6305fc77d93"}]}