)]}'
{"doc/networking-guide/source/intro_os_networking_overview.rst":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"0aa4c433894bf8ecebe287d92fd2678fc7805c77","unresolved":false,"context_lines":[{"line_number":118,"context_line":"network configuration, such as the MAC and IP addresses to be used on that"},{"line_number":119,"context_line":"port. You can manually create a port with valid MAC address and associate to"},{"line_number":120,"context_line":"a virtual router. If the MAC address is invalid like \"00:00:00:00:00:00\", we"},{"line_number":121,"context_line":"see an exception in L3-agent logs."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Routers"},{"line_number":124,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a26ad4f_f0691dfa","line":121,"updated":"2015-11-02 17:05:37.000000000","message":"Is this factually accurate, that we see an exception in the L3 agent logs? The linked bug says that *prior* to the patch fixing the issue you\u0027d see it in the logs. The patch fixed it so it would return an error in the API to the user, rather than allowing it through.","commit_id":"6e2ef408202d0479915857583d459928a0112e3d"},{"author":{"_account_id":17832,"name":"Linette Williams","email":"stemke@us.ibm.com","username":"lwilliams"},"change_message_id":"50aaba1f66a061e5d214b863802eafdf60866411","unresolved":false,"context_lines":[{"line_number":118,"context_line":"network configuration, such as the MAC and IP addresses to be used on that"},{"line_number":119,"context_line":"port. You can manually create a port with valid MAC address and associate to"},{"line_number":120,"context_line":"a virtual router. If the MAC address is invalid like \"00:00:00:00:00:00\", we"},{"line_number":121,"context_line":"see an exception in L3-agent logs."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Routers"},{"line_number":124,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a26ad4f_23eafbdb","line":121,"updated":"2015-11-02 13:46:30.000000000","message":"suggestion: add articles and avoid first person. maybe something like, \"You can manually create a port with a valid MAC address and associate it to a virtual router. If the MAC address is invalid, such as  \"00:00:00:00:00:00\", you see an exception in the L3-agent logs.\"","commit_id":"6e2ef408202d0479915857583d459928a0112e3d"},{"author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"change_message_id":"ad742472920d342d48281b9249f296b681aca39e","unresolved":false,"context_lines":[{"line_number":118,"context_line":"network configuration, such as the MAC and IP addresses to be used on that"},{"line_number":119,"context_line":"port. You can manually create a port with valid MAC address and associate to"},{"line_number":120,"context_line":"a virtual router. If the MAC address is invalid like \"00:00:00:00:00:00\", we"},{"line_number":121,"context_line":"see an exception in L3-agent logs."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Routers"},{"line_number":124,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a26ad4f_2ebc09db","line":121,"in_reply_to":"1a26ad4f_f0691dfa","updated":"2015-11-03 02:47:33.000000000","message":"Good point!\nI just checked the patch. I think we can see both error msg in api and log.\n\nhttps://review.openstack.org/#/c/201141/5/neutron/api/v2/attributes.py\n\nif not valid_mac:\n   msg \u003d _(\"\u0027%s\u0027 is not a valid MAC address\") % data\n   LOG.debug(msg)\n   return msg","commit_id":"6e2ef408202d0479915857583d459928a0112e3d"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"1be0c429fb47e45d726d9c1dec78213f71e9edde","unresolved":false,"context_lines":[{"line_number":117,"context_line":"of a virtual server, to a virtual network. Also describes the associated"},{"line_number":118,"context_line":"network configuration, such as the MAC and IP addresses to be used on that"},{"line_number":119,"context_line":"port. You can manually create a port with valid MAC address and associate to"},{"line_number":120,"context_line":"a virtual router. If the MAC address is invalid like \"00:00:00:00:00:00\", you"},{"line_number":121,"context_line":"see an error message in API response and L3-agent logs."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Routers"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a26ad4f_58e58635","line":120,"updated":"2015-11-03 05:16:58.000000000","message":"\" ... invalid, for example \"00:00:00:00:00:00\", you will see an error message... \"","commit_id":"41b98fffa1e3d4e202f85cbb1f2dc38e64bec5d3"},{"author":{"_account_id":14396,"name":"Alexander Adamov","email":"aadamov@mirantis.com","username":"Alexander"},"change_message_id":"5ad6d6e5844cacc2d521b486d9f65bcb9c963efd","unresolved":false,"context_lines":[{"line_number":116,"context_line":"A port is a connection point for attaching a single device, such as the NIC"},{"line_number":117,"context_line":"of a virtual server, to a virtual network. Also describes the associated"},{"line_number":118,"context_line":"network configuration, such as the MAC and IP addresses to be used on that"},{"line_number":119,"context_line":"port. You can manually create a port with valid MAC address and associate to"},{"line_number":120,"context_line":"a virtual router. If the MAC address is invalid, for example"},{"line_number":121,"context_line":"\"00:00:00:00:00:00\", you will see an error message in API response and"},{"line_number":122,"context_line":"L3-agent logs."}],"source_content_type":"text/x-rst","patch_set":3,"id":"fa80f949_5295343e","line":119,"updated":"2015-11-03 09:45:50.000000000","message":"a valid MAC address","commit_id":"c97a3d0800ff016e5ee379b35d1fdb8cb04691cb"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"d5c8566d1d8794bba6d8db0f1cc239d97a8b39a6","unresolved":false,"context_lines":[{"line_number":119,"context_line":"port. You can manually create a port with a valid MAC address and associate"},{"line_number":120,"context_line":"to a virtual router. If the MAC address is invalid, for example"},{"line_number":121,"context_line":"\"00:00:00:00:00:00\", you will see an error message in API response and"},{"line_number":122,"context_line":"L3-agent logs."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Routers"},{"line_number":125,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa80f949_f5c0d2e2","line":122,"updated":"2015-11-03 10:29:17.000000000","message":"This is still not useful. You need to state that the API server will *return an error* and the creation will fail. Also, the code for the logging is if you have debug enabled. Debug logging level is not suggested for production use, since it is so verbose. Please remove the reference to things appearing in a log file.\n\nAlso, please state why \"00:00:00:00:00:00\" is invalid, casual readers may not know why. Either that, or remove this specific example and just state that if you enter an invalid mac address it\u0027ll return an error.","commit_id":"a4bd35c35d7cc9f8452b522427a025e88bfc6bc7"},{"author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"change_message_id":"ab25ff29ab4679cc77a2cb7da2fd9d5bb2b9ea20","unresolved":false,"context_lines":[{"line_number":119,"context_line":"port. You can manually create a port with a valid MAC address and associate"},{"line_number":120,"context_line":"to a virtual router. If the MAC address is invalid, for example"},{"line_number":121,"context_line":"\"00:00:00:00:00:00\", you will see an error message in API response and"},{"line_number":122,"context_line":"L3-agent logs."},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"Routers"},{"line_number":125,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fa80f949_f92a08e7","line":122,"in_reply_to":"fa80f949_f5c0d2e2","updated":"2015-11-03 13:27:29.000000000","message":"I go through the networking guide. There are no other places mentioning Port. Maybe this is the best place for now.\nHere would be some hands-up for the users about invalid mac address creation. I agree to remove the example and just keep the clear message for users.","commit_id":"a4bd35c35d7cc9f8452b522427a025e88bfc6bc7"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"e1db444dcc5d9208f2a2e55fe5320ec01491d96a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"of a virtual server, to a virtual network. Also describes the associated"},{"line_number":118,"context_line":"network configuration, such as the MAC and IP addresses to be used on that"},{"line_number":119,"context_line":"port. You can manually create a port with a valid MAC address and associate"},{"line_number":120,"context_line":"to a virtual router. If the MAC address is invalid, you will see an error"},{"line_number":121,"context_line":"message."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Routers"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa80f949_be81befd","line":120,"updated":"2015-11-03 15:34:25.000000000","message":"You don\u0027t associate a virtual port to a router. The workflow is, a router is associated with a network through the creation of a router port on the neutron Network. Frankly I think you should remove that sentence since it does not clarify and does not flow with the rest of this section. We\u0027re just introducing the different API objects, not their interactions with one another.","commit_id":"5b44ce37ce745c97483016bf36f5c790cef4b37c"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"e1db444dcc5d9208f2a2e55fe5320ec01491d96a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"network configuration, such as the MAC and IP addresses to be used on that"},{"line_number":119,"context_line":"port. You can manually create a port with a valid MAC address and associate"},{"line_number":120,"context_line":"to a virtual router. If the MAC address is invalid, you will see an error"},{"line_number":121,"context_line":"message."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"Routers"},{"line_number":124,"context_line":"-------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"fa80f949_befd3e70","line":121,"updated":"2015-11-03 15:34:25.000000000","message":"You don\u0027t see an error message. You attempt to create a port with an illegal MAC and the creation fails.","commit_id":"5b44ce37ce745c97483016bf36f5c790cef4b37c"},{"author":{"_account_id":9382,"name":"Shilla Saebi","email":"shilla.saebi@gmail.com","username":"shillasaebi"},"change_message_id":"833b573b90b2caf85529ac791bdb615a5b5512ff","unresolved":false,"context_lines":[{"line_number":114,"context_line":"-----"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"A port is a connection point for attaching a single device, such as the NIC"},{"line_number":117,"context_line":"of a virtual server, to a virtual network. Also describes the associated"},{"line_number":118,"context_line":"network configuration, such as the MAC and IP addresses to be used on that"},{"line_number":119,"context_line":"port. If the MAC address is invalid, the port creation will fail."},{"line_number":120,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"fa80f949_2b7332b3","line":117,"updated":"2015-11-04 04:59:50.000000000","message":"The port also describes the associated network configuration...","commit_id":"7ef8b4bc231726f86f63a7fd97f9c3bfb5412c40"},{"author":{"_account_id":9382,"name":"Shilla Saebi","email":"shilla.saebi@gmail.com","username":"shillasaebi"},"change_message_id":"c6621a220df1117f3015bf04ceb361135c515518","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Extensions"},{"line_number":148,"context_line":"----------"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"The OpenStack networking service is extensible. Extensions serve two"},{"line_number":151,"context_line":"purposes: they allow the introduction of new features in the API"},{"line_number":152,"context_line":"without requiring a version change and they allow the introduction of"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa80f949_0a5f33e6","line":149,"updated":"2015-11-04 15:50:52.000000000","message":"Networking service\n\nhttp://git.openstack.org/cgit/openstack/governance/tree/reference/projects.yaml\n\ncan you change it to capitalize Networking?","commit_id":"6fee8fe0f66af01a48290dd7b8bffbda5868fce9"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"e065a43a9c651ef0c5136f9203b2e6dfcbce9ef9","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Extensions"},{"line_number":148,"context_line":"----------"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"The OpenStack networking service is extensible. Extensions serve two"},{"line_number":151,"context_line":"purposes: they allow the introduction of new features in the API"},{"line_number":152,"context_line":"without requiring a version change and they allow the introduction of"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa80f949_4a4f7bbd","line":149,"in_reply_to":"fa80f949_0a5f33e6","updated":"2015-11-04 15:59:56.000000000","message":"That seems unrelated to this patch, though","commit_id":"6fee8fe0f66af01a48290dd7b8bffbda5868fce9"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"ec3b1ec64f449eb4e5e061699f05f0d0a6740acd","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"Extensions"},{"line_number":148,"context_line":"----------"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"The OpenStack networking service is extensible. Extensions serve two"},{"line_number":151,"context_line":"purposes: they allow the introduction of new features in the API"},{"line_number":152,"context_line":"without requiring a version change and they allow the introduction of"}],"source_content_type":"text/x-rst","patch_set":7,"id":"fa80f949_8c580dfc","line":149,"in_reply_to":"fa80f949_4a4f7bbd","updated":"2015-11-05 01:36:05.000000000","message":"It does, but if there is a cause for another patch, I think it\u0027s a viable option to do this too. The change is small.","commit_id":"6fee8fe0f66af01a48290dd7b8bffbda5868fce9"}]}