)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"406e9aa9dc5ac7eeb43be201275a4b8e3589e6d8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Indicate how a user can discover how many VFs a given PF can support."},{"line_number":10,"context_line":"- PF interface need to be \u0027up\u0027 else spawn will fail."},{"line_number":11,"context_line":"- Filter should be PciPassthroughFilter not PCIDeviceScheduler."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I840f24f57fef5a1d42cc5cbc1f708e5f13f35cb8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_953e9c27","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":63},"updated":"2016-05-03 16:53:39.000000000","message":"I hate to be _that_ guy, but this should probably be a different change","commit_id":"0538fe4788069ad52153f04a05b41dda39788de1"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"05a07de9f9b7c4a9a136669fbaa1cbaa011f78c1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Indicate how a user can discover how many VFs a given PF can support."},{"line_number":10,"context_line":"- PF interface need to be \u0027up\u0027 else spawn will fail."},{"line_number":11,"context_line":"- Filter should be PciPassthroughFilter not PCIDeviceScheduler."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I840f24f57fef5a1d42cc5cbc1f708e5f13f35cb8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_a4956b89","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":63},"in_reply_to":"1a122d0e_953e9c27","updated":"2016-05-03 17:52:10.000000000","message":"Done","commit_id":"0538fe4788069ad52153f04a05b41dda39788de1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"406e9aa9dc5ac7eeb43be201275a4b8e3589e6d8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- PF interface need to be \u0027up\u0027 else spawn will fail."},{"line_number":11,"context_line":"- Filter should be PciPassthroughFilter not PCIDeviceScheduler."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I840f24f57fef5a1d42cc5cbc1f708e5f13f35cb8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_d5f13497","line":13,"updated":"2016-05-03 16:53:39.000000000","message":"I wonder if we need a BP simply to track our work?","commit_id":"0538fe4788069ad52153f04a05b41dda39788de1"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"05a07de9f9b7c4a9a136669fbaa1cbaa011f78c1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- PF interface need to be \u0027up\u0027 else spawn will fail."},{"line_number":11,"context_line":"- Filter should be PciPassthroughFilter not PCIDeviceScheduler."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I840f24f57fef5a1d42cc5cbc1f708e5f13f35cb8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_e4e64343","line":13,"in_reply_to":"1a122d0e_d5f13497","updated":"2016-05-03 17:52:10.000000000","message":"Just asked mriedem, he doesn\u0027t think it\u0027s necessary","commit_id":"0538fe4788069ad52153f04a05b41dda39788de1"}],"doc/networking-guide/source/adv-config-sriov.rst":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"406e9aa9dc5ac7eeb43be201275a4b8e3589e6d8","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"      # echo \u00277\u0027 \u003e /sys/class/net/eth3/device/sriov_numvfs"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"   Alternatively VFs can be created by passing the ``max_vfs`` to the kernel"},{"line_number":142,"context_line":"   module of your network interface. The ``max_vfs`` parameter has been"},{"line_number":143,"context_line":"   deprecated so the PCI SYS interface is the preferred method."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"   Users can determine the maximum number of VFs a PF can support:"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_b5d598e6","line":143,"range":{"start_line":141,"start_character":0,"end_line":143,"end_character":63},"updated":"2016-05-03 16:53:39.000000000","message":"future work item: this should probably be \u0027warning\u0027 directive, and reworded as \"You _can_ do it this way, but don\u0027t because it\u0027s deprecated\"","commit_id":"0538fe4788069ad52153f04a05b41dda39788de1"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"05a07de9f9b7c4a9a136669fbaa1cbaa011f78c1","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"      # echo \u00277\u0027 \u003e /sys/class/net/eth3/device/sriov_numvfs"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"   Alternatively VFs can be created by passing the ``max_vfs`` to the kernel"},{"line_number":142,"context_line":"   module of your network interface. The ``max_vfs`` parameter has been"},{"line_number":143,"context_line":"   deprecated so the PCI SYS interface is the preferred method."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"   Users can determine the maximum number of VFs a PF can support:"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_84c4af41","line":143,"range":{"start_line":141,"start_character":0,"end_line":143,"end_character":63},"in_reply_to":"1a122d0e_b5d598e6","updated":"2016-05-03 17:52:10.000000000","message":"Done","commit_id":"0538fe4788069ad52153f04a05b41dda39788de1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"406e9aa9dc5ac7eeb43be201275a4b8e3589e6d8","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   .. code-block:: console"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      # cat /sys/class/net/eth3/device/sriov_totalvfs"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"   If the interface is down, make sure it\u0027s set to \u0027up\u0027 before launching a"},{"line_number":152,"context_line":"   guest (else the instance will fail to spawn):"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_55b3640a","line":149,"range":{"start_line":149,"start_character":6,"end_line":149,"end_character":53},"updated":"2016-05-03 16:53:39.000000000","message":"nit: I\u0027d like some sample output here (i.e. a number)","commit_id":"0538fe4788069ad52153f04a05b41dda39788de1"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"05a07de9f9b7c4a9a136669fbaa1cbaa011f78c1","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   .. code-block:: console"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      # cat /sys/class/net/eth3/device/sriov_totalvfs"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"   If the interface is down, make sure it\u0027s set to \u0027up\u0027 before launching a"},{"line_number":152,"context_line":"   guest (else the instance will fail to spawn):"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_84be6ffe","line":149,"range":{"start_line":149,"start_character":6,"end_line":149,"end_character":53},"in_reply_to":"1a122d0e_55b3640a","updated":"2016-05-03 17:52:10.000000000","message":"Done","commit_id":"0538fe4788069ad52153f04a05b41dda39788de1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"406e9aa9dc5ac7eeb43be201275a4b8e3589e6d8","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      # cat /sys/class/net/eth3/device/sriov_totalvfs"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"   If the interface is down, make sure it\u0027s set to \u0027up\u0027 before launching a"},{"line_number":152,"context_line":"   guest (else the instance will fail to spawn):"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"   .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_15a0cca4","line":151,"range":{"start_line":151,"start_character":51,"end_line":151,"end_character":55},"updated":"2016-05-03 16:53:39.000000000","message":"Should this be ``up``?","commit_id":"0538fe4788069ad52153f04a05b41dda39788de1"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"05a07de9f9b7c4a9a136669fbaa1cbaa011f78c1","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      # cat /sys/class/net/eth3/device/sriov_totalvfs"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"   If the interface is down, make sure it\u0027s set to \u0027up\u0027 before launching a"},{"line_number":152,"context_line":"   guest (else the instance will fail to spawn):"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"   .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_0439bfa3","line":151,"range":{"start_line":151,"start_character":51,"end_line":151,"end_character":55},"in_reply_to":"1a122d0e_15a0cca4","updated":"2016-05-03 17:52:10.000000000","message":"Done","commit_id":"0538fe4788069ad52153f04a05b41dda39788de1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"406e9aa9dc5ac7eeb43be201275a4b8e3589e6d8","unresolved":false,"context_lines":[{"line_number":149,"context_line":"      # cat /sys/class/net/eth3/device/sriov_totalvfs"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"   If the interface is down, make sure it\u0027s set to \u0027up\u0027 before launching a"},{"line_number":152,"context_line":"   guest (else the instance will fail to spawn):"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"   .. code-block:: console"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_35dfc83b","line":152,"range":{"start_line":152,"start_character":9,"end_line":152,"end_character":47},"updated":"2016-05-03 16:53:39.000000000","message":"nit: You don\u0027t need these bracket","commit_id":"0538fe4788069ad52153f04a05b41dda39788de1"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"05a07de9f9b7c4a9a136669fbaa1cbaa011f78c1","unresolved":false,"context_lines":[{"line_number":149,"context_line":"      # cat /sys/class/net/eth3/device/sriov_totalvfs"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"   If the interface is down, make sure it\u0027s set to \u0027up\u0027 before launching a"},{"line_number":152,"context_line":"   guest (else the instance will fail to spawn):"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"   .. code-block:: console"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"1a122d0e_a44a8b25","line":152,"range":{"start_line":152,"start_character":9,"end_line":152,"end_character":47},"in_reply_to":"1a122d0e_35dfc83b","updated":"2016-05-03 17:52:10.000000000","message":"Done","commit_id":"0538fe4788069ad52153f04a05b41dda39788de1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"18bc3406d650ce84a2b5b2594381cc234cf98728","unresolved":false,"context_lines":[{"line_number":145,"context_line":"      you first need to set ``sriov_numvfs`` to ``0`` then set it to your new"},{"line_number":146,"context_line":"      value."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"   DEPRECATED: Alternatively VFs can be created by passing the ``max_vfs`` to"},{"line_number":149,"context_line":"   the kernel module of your network interface. The ``max_vfs`` parameter has"},{"line_number":150,"context_line":"   been deprecated so the PCI SYS interface is the preferred method."},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_b73a92e5","line":148,"range":{"start_line":148,"start_character":3,"end_line":148,"end_character":14},"updated":"2016-05-04 15:09:35.000000000","message":"nit: Would a warning admonition be suitable here?\n\n    .. warning::\n\n    Alternatively...","commit_id":"ea1aa65b5c88da479ede20908aee2d43e2b6c128"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"75014e79639c0957429ecf6cb03c913edf655830","unresolved":false,"context_lines":[{"line_number":145,"context_line":"      you first need to set ``sriov_numvfs`` to ``0`` then set it to your new"},{"line_number":146,"context_line":"      value."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"   DEPRECATED: Alternatively VFs can be created by passing the ``max_vfs`` to"},{"line_number":149,"context_line":"   the kernel module of your network interface. The ``max_vfs`` parameter has"},{"line_number":150,"context_line":"   been deprecated so the PCI SYS interface is the preferred method."},{"line_number":151,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_055070d3","line":148,"range":{"start_line":148,"start_character":3,"end_line":148,"end_character":14},"in_reply_to":"1a122d0e_b73a92e5","updated":"2016-05-04 15:28:19.000000000","message":"Done","commit_id":"ea1aa65b5c88da479ede20908aee2d43e2b6c128"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"2ec3c3c0d033f16e384da64db16bc4dc5f713184","unresolved":false,"context_lines":[{"line_number":288,"context_line":"-------------------------------------"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"#. On every controller node running nova-scheduler add"},{"line_number":291,"context_line":"   PCIDeviceScheduler to the scheduler_default_filters parameter"},{"line_number":292,"context_line":"   and add a new line for scheduler_available_filters parameter"},{"line_number":293,"context_line":"   under the ``[default]`` section in"},{"line_number":294,"context_line":"   ``/etc/nova/nova.conf``:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_3dcccaba","line":291,"range":{"start_line":291,"start_character":3,"end_line":291,"end_character":21},"updated":"2016-05-03 19:02:35.000000000","message":"why did you change this filter name?\nit is still PciPassthroughFilter https://github.com/openstack/nova/blob/bc5035343d366a18cae587f92ecb4e871aba974a/nova/scheduler/filters/pci_passthrough_filter.py","commit_id":"ea1aa65b5c88da479ede20908aee2d43e2b6c128"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"76c0c019c7c0ff6ef54548cb120745331f3d4b17","unresolved":false,"context_lines":[{"line_number":288,"context_line":"-------------------------------------"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"#. On every controller node running nova-scheduler add"},{"line_number":291,"context_line":"   PCIDeviceScheduler to the scheduler_default_filters parameter"},{"line_number":292,"context_line":"   and add a new line for scheduler_available_filters parameter"},{"line_number":293,"context_line":"   under the ``[default]`` section in"},{"line_number":294,"context_line":"   ``/etc/nova/nova.conf``:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"1a122d0e_9d1fde08","line":291,"range":{"start_line":291,"start_character":3,"end_line":291,"end_character":21},"in_reply_to":"1a122d0e_3dcccaba","updated":"2016-05-03 19:05:19.000000000","message":"I haven\u0027t changed that.  This is a \"bug\" in the current version of the document.\n\nThe fix was in patch set 1, but Stephen prefers that this is handled in a different patch.","commit_id":"ea1aa65b5c88da479ede20908aee2d43e2b6c128"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"06362e38f613f6ad6441cbf30005a5af02b3f861","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"   .. note::"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"      On some PCI devices, it has been observed that when changing the amount"},{"line_number":144,"context_line":"      of VFs you can get an error ``Device or resource busy``.  In this case"},{"line_number":145,"context_line":"      you first need to set ``sriov_numvfs`` to ``0`` then set it to your new"},{"line_number":146,"context_line":"      value."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_e5c1dd4f","line":143,"range":{"start_line":143,"start_character":6,"end_line":143,"end_character":47},"updated":"2016-05-05 00:41:34.000000000","message":"\"On some PCI devices, observe that when changing the amount of VFs you receive the error...\"","commit_id":"8db025060f6c3d78b05bfd683e862a36063b8220"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"fcd94ce804957c22f5fdf89b78e659ff18db0efc","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"   .. note::"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"      On some PCI devices, it has been observed that when changing the amount"},{"line_number":144,"context_line":"      of VFs you can get an error ``Device or resource busy``.  In this case"},{"line_number":145,"context_line":"      you first need to set ``sriov_numvfs`` to ``0`` then set it to your new"},{"line_number":146,"context_line":"      value."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_3252e735","line":143,"range":{"start_line":143,"start_character":6,"end_line":143,"end_character":47},"in_reply_to":"1a122d0e_e5c1dd4f","updated":"2016-05-05 11:05:35.000000000","message":"Done","commit_id":"8db025060f6c3d78b05bfd683e862a36063b8220"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"06362e38f613f6ad6441cbf30005a5af02b3f861","unresolved":false,"context_lines":[{"line_number":141,"context_line":"   .. note::"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"      On some PCI devices, it has been observed that when changing the amount"},{"line_number":144,"context_line":"      of VFs you can get an error ``Device or resource busy``.  In this case"},{"line_number":145,"context_line":"      you first need to set ``sriov_numvfs`` to ``0`` then set it to your new"},{"line_number":146,"context_line":"      value."},{"line_number":147,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_25a635c1","line":144,"range":{"start_line":144,"start_character":64,"end_line":144,"end_character":76},"updated":"2016-05-05 00:41:34.000000000","message":"\"In this case, you first need...\"","commit_id":"8db025060f6c3d78b05bfd683e862a36063b8220"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"fcd94ce804957c22f5fdf89b78e659ff18db0efc","unresolved":false,"context_lines":[{"line_number":141,"context_line":"   .. note::"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"      On some PCI devices, it has been observed that when changing the amount"},{"line_number":144,"context_line":"      of VFs you can get an error ``Device or resource busy``.  In this case"},{"line_number":145,"context_line":"      you first need to set ``sriov_numvfs`` to ``0`` then set it to your new"},{"line_number":146,"context_line":"      value."},{"line_number":147,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_92313b0e","line":144,"range":{"start_line":144,"start_character":64,"end_line":144,"end_character":76},"in_reply_to":"1a122d0e_25a635c1","updated":"2016-05-05 11:05:35.000000000","message":"Done","commit_id":"8db025060f6c3d78b05bfd683e862a36063b8220"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"06362e38f613f6ad6441cbf30005a5af02b3f861","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"   .. warning::"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"      DEPRECATED: Alternatively VFs can be created by passing the ``max_vfs``"},{"line_number":151,"context_line":"      to the kernel module of your network interface. The ``max_vfs``"},{"line_number":152,"context_line":"      parameter has been deprecated so the PCI SYS interface is the preferred"},{"line_number":153,"context_line":"      method."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_65acad9f","line":150,"updated":"2016-05-05 00:41:34.000000000","message":"\"Alternatively, you can create VFs by passing ...\"","commit_id":"8db025060f6c3d78b05bfd683e862a36063b8220"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"fcd94ce804957c22f5fdf89b78e659ff18db0efc","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"   .. warning::"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"      DEPRECATED: Alternatively VFs can be created by passing the ``max_vfs``"},{"line_number":151,"context_line":"      to the kernel module of your network interface. The ``max_vfs``"},{"line_number":152,"context_line":"      parameter has been deprecated so the PCI SYS interface is the preferred"},{"line_number":153,"context_line":"      method."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_3229479c","line":150,"in_reply_to":"1a122d0e_65acad9f","updated":"2016-05-05 11:05:35.000000000","message":"Done","commit_id":"8db025060f6c3d78b05bfd683e862a36063b8220"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"06362e38f613f6ad6441cbf30005a5af02b3f861","unresolved":false,"context_lines":[{"line_number":159,"context_line":"      # cat /sys/class/net/eth3/device/sriov_totalvfs"},{"line_number":160,"context_line":"      63"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"   If the interface is down, make sure it\u0027s set to ``up`` before launching a"},{"line_number":163,"context_line":"   guest else the instance will fail to spawn:"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"   .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_857e2919","line":162,"range":{"start_line":162,"start_character":29,"end_line":162,"end_character":43},"updated":"2016-05-05 00:41:34.000000000","message":"ensure it is*","commit_id":"8db025060f6c3d78b05bfd683e862a36063b8220"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"fcd94ce804957c22f5fdf89b78e659ff18db0efc","unresolved":false,"context_lines":[{"line_number":159,"context_line":"      # cat /sys/class/net/eth3/device/sriov_totalvfs"},{"line_number":160,"context_line":"      63"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"   If the interface is down, make sure it\u0027s set to ``up`` before launching a"},{"line_number":163,"context_line":"   guest else the instance will fail to spawn:"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"   .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1a122d0e_120d2b3e","line":162,"range":{"start_line":162,"start_character":29,"end_line":162,"end_character":43},"in_reply_to":"1a122d0e_857e2919","updated":"2016-05-05 11:05:35.000000000","message":"Done","commit_id":"8db025060f6c3d78b05bfd683e862a36063b8220"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"138385f75f14a922db8546392210528c2f77d0ce","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"      On some PCI devices, observe that when changing the amount of VFs you"},{"line_number":144,"context_line":"      receive the error ``Device or resource busy``.  In this case, you first"},{"line_number":145,"context_line":"      need to set ``sriov_numvfs`` to ``0`` then set it to your new value."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   .. warning::"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_bcc081e1","line":145,"range":{"start_line":145,"start_character":43,"end_line":145,"end_character":44},"updated":"2016-05-05 14:45:02.000000000","message":"comma before \u0027then\u0027","commit_id":"4022d9199a6ecfa235f5db336a43361f3baca6d1"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"4b11b57196c604a13c87397240ebed6fb8bd27da","unresolved":false,"context_lines":[{"line_number":142,"context_line":""},{"line_number":143,"context_line":"      On some PCI devices, observe that when changing the amount of VFs you"},{"line_number":144,"context_line":"      receive the error ``Device or resource busy``.  In this case, you first"},{"line_number":145,"context_line":"      need to set ``sriov_numvfs`` to ``0`` then set it to your new value."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   .. warning::"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_464ebb38","line":145,"range":{"start_line":145,"start_character":43,"end_line":145,"end_character":44},"in_reply_to":"1a122d0e_bcc081e1","updated":"2016-05-05 15:13:57.000000000","message":"Done","commit_id":"4022d9199a6ecfa235f5db336a43361f3baca6d1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9b1c7c6c681440754c21065f8b95e7287713e5ca","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   .. warning::"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      DEPRECATED: Alternatively, you can create VFs by passing the ``max_vfs``"},{"line_number":150,"context_line":"      to the kernel module of your network interface. The ``max_vfs``"},{"line_number":151,"context_line":"      parameter has been deprecated so the PCI SYS interface is the preferred"},{"line_number":152,"context_line":"      method."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_9002ce0a","line":149,"range":{"start_line":149,"start_character":6,"end_line":149,"end_character":18},"updated":"2016-05-05 13:40:25.000000000","message":"nit: You could probably drop this too, as it\u0027s already marked as a warning and you explain that it\u0027s deprecated in the text.","commit_id":"4022d9199a6ecfa235f5db336a43361f3baca6d1"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"4b11b57196c604a13c87397240ebed6fb8bd27da","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   .. warning::"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      DEPRECATED: Alternatively, you can create VFs by passing the ``max_vfs``"},{"line_number":150,"context_line":"      to the kernel module of your network interface. The ``max_vfs``"},{"line_number":151,"context_line":"      parameter has been deprecated so the PCI SYS interface is the preferred"},{"line_number":152,"context_line":"      method."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_c6412b0c","line":149,"range":{"start_line":149,"start_character":6,"end_line":149,"end_character":18},"in_reply_to":"1a122d0e_5065d1ac","updated":"2016-05-05 15:13:57.000000000","message":"I think we want a warning there.  It works but I\u0027ve seen it causing problem.  We just want to warn the user (who may have read about it on some blogs).","commit_id":"4022d9199a6ecfa235f5db336a43361f3baca6d1"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"4b11b57196c604a13c87397240ebed6fb8bd27da","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   .. warning::"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      DEPRECATED: Alternatively, you can create VFs by passing the ``max_vfs``"},{"line_number":150,"context_line":"      to the kernel module of your network interface. The ``max_vfs``"},{"line_number":151,"context_line":"      parameter has been deprecated so the PCI SYS interface is the preferred"},{"line_number":152,"context_line":"      method."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_a65d0fee","line":149,"range":{"start_line":149,"start_character":6,"end_line":149,"end_character":18},"in_reply_to":"1a122d0e_9002ce0a","updated":"2016-05-05 15:13:57.000000000","message":"Done","commit_id":"4022d9199a6ecfa235f5db336a43361f3baca6d1"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"138385f75f14a922db8546392210528c2f77d0ce","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   .. warning::"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      DEPRECATED: Alternatively, you can create VFs by passing the ``max_vfs``"},{"line_number":150,"context_line":"      to the kernel module of your network interface. The ``max_vfs``"},{"line_number":151,"context_line":"      parameter has been deprecated so the PCI SYS interface is the preferred"},{"line_number":152,"context_line":"      method."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_5065d1ac","line":149,"range":{"start_line":149,"start_character":6,"end_line":149,"end_character":18},"in_reply_to":"1a122d0e_9002ce0a","updated":"2016-05-05 14:45:02.000000000","message":"I would leave this word at the beginning (to inform the user at once) and remove the last sentence instead. And btw, is it really a warning? Or a simple note?","commit_id":"4022d9199a6ecfa235f5db336a43361f3baca6d1"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"e8dd9253572b65adb903e1389b68c2d3a92867c5","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   .. warning::"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      DEPRECATED: Alternatively, you can create VFs by passing the ``max_vfs``"},{"line_number":150,"context_line":"      to the kernel module of your network interface. The ``max_vfs``"},{"line_number":151,"context_line":"      parameter has been deprecated so the PCI SYS interface is the preferred"},{"line_number":152,"context_line":"      method."}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_c9265c66","line":149,"range":{"start_line":149,"start_character":6,"end_line":149,"end_character":18},"in_reply_to":"1a122d0e_c6412b0c","updated":"2016-05-05 15:33:36.000000000","message":"Understood, thanks! Then, I agree with Stephen. Sorry for a mix-up. Please see my comment in the next patch.","commit_id":"4022d9199a6ecfa235f5db336a43361f3baca6d1"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"138385f75f14a922db8546392210528c2f77d0ce","unresolved":false,"context_lines":[{"line_number":151,"context_line":"      parameter has been deprecated so the PCI SYS interface is the preferred"},{"line_number":152,"context_line":"      method."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"   Users can determine the maximum number of VFs a PF can support:"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"   .. code-block:: console"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_70ff2dab","line":154,"range":{"start_line":154,"start_character":3,"end_line":154,"end_character":8},"updated":"2016-05-05 14:45:02.000000000","message":"You","commit_id":"4022d9199a6ecfa235f5db336a43361f3baca6d1"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"4b11b57196c604a13c87397240ebed6fb8bd27da","unresolved":false,"context_lines":[{"line_number":151,"context_line":"      parameter has been deprecated so the PCI SYS interface is the preferred"},{"line_number":152,"context_line":"      method."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"   Users can determine the maximum number of VFs a PF can support:"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"   .. code-block:: console"},{"line_number":157,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_e65387dc","line":154,"range":{"start_line":154,"start_character":3,"end_line":154,"end_character":8},"in_reply_to":"1a122d0e_70ff2dab","updated":"2016-05-05 15:13:57.000000000","message":"Done","commit_id":"4022d9199a6ecfa235f5db336a43361f3baca6d1"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"138385f75f14a922db8546392210528c2f77d0ce","unresolved":false,"context_lines":[{"line_number":159,"context_line":"      63"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"   If the interface is down, make sure it is set to ``up`` before launching a"},{"line_number":162,"context_line":"   guest else the instance will fail to spawn:"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"   .. code-block:: console"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_101d190f","line":162,"range":{"start_line":162,"start_character":8,"end_line":162,"end_character":9},"updated":"2016-05-05 14:45:02.000000000","message":"comma","commit_id":"4022d9199a6ecfa235f5db336a43361f3baca6d1"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"4b11b57196c604a13c87397240ebed6fb8bd27da","unresolved":false,"context_lines":[{"line_number":159,"context_line":"      63"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"   If the interface is down, make sure it is set to ``up`` before launching a"},{"line_number":162,"context_line":"   guest else the instance will fail to spawn:"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"   .. code-block:: console"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a122d0e_66681789","line":162,"range":{"start_line":162,"start_character":8,"end_line":162,"end_character":9},"in_reply_to":"1a122d0e_101d190f","updated":"2016-05-05 15:13:57.000000000","message":"Done","commit_id":"4022d9199a6ecfa235f5db336a43361f3baca6d1"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"c0da31f1ef926728000fe5f4298079ac4338d662","unresolved":false,"context_lines":[{"line_number":141,"context_line":"   .. note::"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"      On some PCI devices, observe that when changing the amount of VFs you"},{"line_number":144,"context_line":"      receive the error ``Device or resource busy``.  In this case, you first"},{"line_number":145,"context_line":"      need to set ``sriov_numvfs`` to ``0``, then set it to your new value."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   .. warning::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_9a49ccd3","line":144,"range":{"start_line":144,"start_character":53,"end_line":144,"end_character":54},"updated":"2016-05-06 01:07:23.000000000","message":"Remove the extra space here","commit_id":"1584e939db6175e5ed6898fcfe248d6cb593cf47"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"6bd3834f98f9bdbadbbe89a92e4be1a7cda520f6","unresolved":false,"context_lines":[{"line_number":141,"context_line":"   .. note::"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"      On some PCI devices, observe that when changing the amount of VFs you"},{"line_number":144,"context_line":"      receive the error ``Device or resource busy``.  In this case, you first"},{"line_number":145,"context_line":"      need to set ``sriov_numvfs`` to ``0``, then set it to your new value."},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   .. warning::"}],"source_content_type":"text/x-rst","patch_set":5,"id":"dab17558_d7903998","line":144,"range":{"start_line":144,"start_character":53,"end_line":144,"end_character":54},"in_reply_to":"dab17558_9a49ccd3","updated":"2016-05-06 12:27:46.000000000","message":"Done.\n\nThanks for the review Alexandra.","commit_id":"1584e939db6175e5ed6898fcfe248d6cb593cf47"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"dee968d0100880f7695d02724460571ead719b0b","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   .. warning::"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      DEPRECATED: Alternatively, you can create VFs by passing the ``max_vfs``"},{"line_number":150,"context_line":"      to the kernel module of your network interface."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"   You can determine the maximum number of VFs a PF can support:"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_0979742f","line":150,"range":{"start_line":149,"start_character":6,"end_line":150,"end_character":53},"updated":"2016-05-05 15:34:04.000000000","message":"Alternatively, you can create VFs by passing the ``max_vfs`` to the kernel module of your network interface. However, the ``max_vfs`` parameter has been deprecated, so the PCI SYS interface is the preferred method.","commit_id":"1584e939db6175e5ed6898fcfe248d6cb593cf47"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"506c782b65e32ae97827e7fa29d62157b73a080a","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   .. warning::"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      DEPRECATED: Alternatively, you can create VFs by passing the ``max_vfs``"},{"line_number":150,"context_line":"      to the kernel module of your network interface."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"   You can determine the maximum number of VFs a PF can support:"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"1a122d0e_498c0cd7","line":150,"range":{"start_line":149,"start_character":6,"end_line":150,"end_character":53},"in_reply_to":"1a122d0e_0979742f","updated":"2016-05-05 15:41:02.000000000","message":"Thanks Olena for the review !","commit_id":"1584e939db6175e5ed6898fcfe248d6cb593cf47"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"776d36c33c1c19529bbbfac3d8871a045ce84519","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   .. warning::"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      DEPRECATED: Alternatively, you can create VFs by passing the ``max_vfs``"},{"line_number":150,"context_line":"      to the kernel module of your network interface."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"   You can determine the maximum number of VFs a PF can support:"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_db0f4886","line":150,"range":{"start_line":149,"start_character":0,"end_line":150,"end_character":53},"updated":"2016-05-10 12:43:54.000000000","message":"I think you\u0027ve misunderstood Olena\u0027s comments here. The second sentence should remain, and the \u0027DEPRECATED\u0027 prefix should be removed (unnecessary)","commit_id":"c4c104a7b914264c042d5b86531ea0941d08082b"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"94ebe2de21d046caa8e2c001dbb217416d2ea40e","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   .. warning::"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      DEPRECATED: Alternatively, you can create VFs by passing the ``max_vfs``"},{"line_number":150,"context_line":"      to the kernel module of your network interface."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"   You can determine the maximum number of VFs a PF can support:"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_3d19247a","line":150,"range":{"start_line":149,"start_character":0,"end_line":150,"end_character":53},"in_reply_to":"dab17558_4e30b4e8","updated":"2016-05-10 14:09:54.000000000","message":"Done","commit_id":"c4c104a7b914264c042d5b86531ea0941d08082b"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"94ebe2de21d046caa8e2c001dbb217416d2ea40e","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   .. warning::"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      DEPRECATED: Alternatively, you can create VFs by passing the ``max_vfs``"},{"line_number":150,"context_line":"      to the kernel module of your network interface."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"   You can determine the maximum number of VFs a PF can support:"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_5d1ce869","line":150,"range":{"start_line":149,"start_character":0,"end_line":150,"end_character":53},"in_reply_to":"dab17558_db0f4886","updated":"2016-05-10 14:09:54.000000000","message":"Done","commit_id":"c4c104a7b914264c042d5b86531ea0941d08082b"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"2d93d18ec450c8ce2cd7a2af3f78776618cb416f","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"   .. warning::"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"      DEPRECATED: Alternatively, you can create VFs by passing the ``max_vfs``"},{"line_number":150,"context_line":"      to the kernel module of your network interface."},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"   You can determine the maximum number of VFs a PF can support:"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"dab17558_4e30b4e8","line":150,"range":{"start_line":149,"start_character":0,"end_line":150,"end_character":53},"in_reply_to":"dab17558_db0f4886","updated":"2016-05-10 12:50:03.000000000","message":"Yup, thanks Stephen! Sorry for misunderstanding. Here is the comment I left in the 5th patch (these 2 sentences are enough for the warning):\n\nAlternatively, you can create VFs by passing the ``max_vfs`` to the kernel module of your network interface. However, the ``max_vfs`` parameter has been deprecated, so the PCI SYS interface is the preferred method.","commit_id":"c4c104a7b914264c042d5b86531ea0941d08082b"}]}