)]}'
{"doc/admin-guide/source/blockstorage-driver-filter-weighing.rst":[{"author":{"_account_id":21774,"name":"shalakha naresh sidmul","email":"shalakhansidmul@gmail.com","username":"shalakhansidmul"},"change_message_id":"d009da52ad07e5a12700a8769c3218d67b0a983d","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":".. important::"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"   Default values for the filter and goodness functions will be used"},{"line_number":90,"context_line":"   for each back-end if you do not define them yourself. If complete"},{"line_number":91,"context_line":"   control is desired then a filter and goodness function should be"},{"line_number":92,"context_line":"   defined for each of the back ends in the ``cinder.conf`` file."}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_7d611e39","line":89,"updated":"2016-05-09 18:54:06.000000000","message":"I think it should be: \"If you do not define values for filter and goodness functions, default values will be used.\"","commit_id":"b92ff99301b42b463a5ea60821bfc8c5d859fe38"},{"author":{"_account_id":10897,"name":"Joseph Robinson","email":"josephremail@gmail.com","username":"RobiJoe"},"change_message_id":"b7704ef4ad6c07772281a48770177cc5294f9f2a","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":".. important::"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"   Default values for the filter and goodness functions will be used"},{"line_number":90,"context_line":"   for each back-end if you do not define them yourself. If complete"},{"line_number":91,"context_line":"   control is desired then a filter and goodness function should be"},{"line_number":92,"context_line":"   defined for each of the back ends in the ``cinder.conf`` file."}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_d0c46360","line":89,"in_reply_to":"dab17558_7d611e39","updated":"2016-05-10 02:48:47.000000000","message":"So my thoughts on the passive voice with this bug - change the sentence on line 89 to \"The drive filter and weigher will use default values for filter and goodness functions for each back-end if you do not define them yourself.\"","commit_id":"b92ff99301b42b463a5ea60821bfc8c5d859fe38"},{"author":{"_account_id":10897,"name":"Joseph Robinson","email":"josephremail@gmail.com","username":"RobiJoe"},"change_message_id":"ac7794ccad6acddb96bbb95f8cbc0d130aab1dd8","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":".. important::"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"   Default values for the filter and goodness functions will be used"},{"line_number":90,"context_line":"   for each back-end if you do not define them yourself. If complete"},{"line_number":91,"context_line":"   control is desired then a filter and goodness function should be"},{"line_number":92,"context_line":"   defined for each of the back ends in the ``cinder.conf`` file."}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_623764ff","line":89,"in_reply_to":"dab17558_d0c46360","updated":"2016-05-11 06:31:25.000000000","message":"Disregard the change here. \"back end\" is correct.","commit_id":"b92ff99301b42b463a5ea60821bfc8c5d859fe38"},{"author":{"_account_id":21774,"name":"shalakha naresh sidmul","email":"shalakhansidmul@gmail.com","username":"shalakhansidmul"},"change_message_id":"d009da52ad07e5a12700a8769c3218d67b0a983d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"   Default values for the filter and goodness functions will be used"},{"line_number":90,"context_line":"   for each back-end if you do not define them yourself. If complete"},{"line_number":91,"context_line":"   control is desired then a filter and goodness function should be"},{"line_number":92,"context_line":"   defined for each of the back ends in the ``cinder.conf`` file."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Supported operations in filter and goodness functions"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_bdb1c6e3","line":92,"updated":"2016-05-09 18:54:06.000000000","message":"I think it should be \"defined for each of the back-ends (or backends) in the ``cinder.conf`` file.\"","commit_id":"b92ff99301b42b463a5ea60821bfc8c5d859fe38"},{"author":{"_account_id":10897,"name":"Joseph Robinson","email":"josephremail@gmail.com","username":"RobiJoe"},"change_message_id":"ac7794ccad6acddb96bbb95f8cbc0d130aab1dd8","unresolved":false,"context_lines":[{"line_number":89,"context_line":"   Default values for the filter and goodness functions will be used"},{"line_number":90,"context_line":"   for each back-end if you do not define them yourself. If complete"},{"line_number":91,"context_line":"   control is desired then a filter and goodness function should be"},{"line_number":92,"context_line":"   defined for each of the back ends in the ``cinder.conf`` file."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Supported operations in filter and goodness functions"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_a23dccde","line":92,"in_reply_to":"dab17558_b0cb9f52","updated":"2016-05-11 06:31:25.000000000","message":"Disregard this, I\u0027m wrong here.","commit_id":"b92ff99301b42b463a5ea60821bfc8c5d859fe38"},{"author":{"_account_id":10897,"name":"Joseph Robinson","email":"josephremail@gmail.com","username":"RobiJoe"},"change_message_id":"b7704ef4ad6c07772281a48770177cc5294f9f2a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"   Default values for the filter and goodness functions will be used"},{"line_number":90,"context_line":"   for each back-end if you do not define them yourself. If complete"},{"line_number":91,"context_line":"   control is desired then a filter and goodness function should be"},{"line_number":92,"context_line":"   defined for each of the back ends in the ``cinder.conf`` file."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Supported operations in filter and goodness functions"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_b0cb9f52","line":92,"in_reply_to":"dab17558_bdb1c6e3","updated":"2016-05-10 02:48:47.000000000","message":"Just \"backends\" without a space works in this case following the OpenStack Contributor Guide http://docs.openstack.org/contributor-guide/writing-style/word-choice.html","commit_id":"b92ff99301b42b463a5ea60821bfc8c5d859fe38"},{"author":{"_account_id":21774,"name":"shalakha naresh sidmul","email":"shalakhansidmul@gmail.com","username":"shalakhansidmul"},"change_message_id":"d009da52ad07e5a12700a8769c3218d67b0a983d","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":".. caution::"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"   Syntax errors in filter or goodness strings defined by you will"},{"line_number":120,"context_line":"   cause errors to be thrown at a volume request time."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Available properties when creating custom functions"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_9decc290","line":119,"updated":"2016-05-09 18:54:06.000000000","message":"I think this should be: \"At volume request time, the syntax errors you define in filter or goodness functions, will be thrown.\"","commit_id":"b92ff99301b42b463a5ea60821bfc8c5d859fe38"},{"author":{"_account_id":10897,"name":"Joseph Robinson","email":"josephremail@gmail.com","username":"RobiJoe"},"change_message_id":"b7704ef4ad6c07772281a48770177cc5294f9f2a","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":".. caution::"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"   Syntax errors in filter or goodness strings defined by you will"},{"line_number":120,"context_line":"   cause errors to be thrown at a volume request time."},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"Available properties when creating custom functions"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_10d70b24","line":119,"in_reply_to":"dab17558_9decc290","updated":"2016-05-10 02:48:47.000000000","message":"More thoughts - change the caution admonition on line 117 to \"Syntax errors you defined in filter or goodness strings are thrown at volume request time.\"","commit_id":"b92ff99301b42b463a5ea60821bfc8c5d859fe38"},{"author":{"_account_id":21774,"name":"shalakha naresh sidmul","email":"shalakhansidmul@gmail.com","username":"shalakhansidmul"},"change_message_id":"d009da52ad07e5a12700a8769c3218d67b0a983d","unresolved":false,"context_lines":[{"line_number":361,"context_line":"   volume_backend_name \u003d lvmdriver-3"},{"line_number":362,"context_line":"   goodness_function \u003d \"55\""},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"The above is an example of how back end specific properties can be used"},{"line_number":365,"context_line":"in the filter and goodness functions. In this example the LVM driver\u0027s"},{"line_number":366,"context_line":"``total_volumes`` capability is being used to determine which host gets"},{"line_number":367,"context_line":"used during a volume request. In the above example, lvm-1 and lvm-2 will"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_980df039","line":364,"updated":"2016-05-09 18:54:06.000000000","message":"I think we should follow one consistent approach. According to this link : http://english.stackexchange.com/questions/34447/is-it-front-end-frontend-or-front-end, \"backend\" and \"back end\", both can be used. I suggest we can eliminate unnecessary hyphenation.","commit_id":"b92ff99301b42b463a5ea60821bfc8c5d859fe38"},{"author":{"_account_id":10897,"name":"Joseph Robinson","email":"josephremail@gmail.com","username":"RobiJoe"},"change_message_id":"ac7794ccad6acddb96bbb95f8cbc0d130aab1dd8","unresolved":false,"context_lines":[{"line_number":361,"context_line":"   volume_backend_name \u003d lvmdriver-3"},{"line_number":362,"context_line":"   goodness_function \u003d \"55\""},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"The above is an example of how back end specific properties can be used"},{"line_number":365,"context_line":"in the filter and goodness functions. In this example the LVM driver\u0027s"},{"line_number":366,"context_line":"``total_volumes`` capability is being used to determine which host gets"},{"line_number":367,"context_line":"used during a volume request. In the above example, lvm-1 and lvm-2 will"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_6d05950f","line":364,"in_reply_to":"dab17558_50023370","updated":"2016-05-11 06:31:25.000000000","message":"This one does need the hyphenation since it is the adjective form.","commit_id":"b92ff99301b42b463a5ea60821bfc8c5d859fe38"},{"author":{"_account_id":10897,"name":"Joseph Robinson","email":"josephremail@gmail.com","username":"RobiJoe"},"change_message_id":"b7704ef4ad6c07772281a48770177cc5294f9f2a","unresolved":false,"context_lines":[{"line_number":361,"context_line":"   volume_backend_name \u003d lvmdriver-3"},{"line_number":362,"context_line":"   goodness_function \u003d \"55\""},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"The above is an example of how back end specific properties can be used"},{"line_number":365,"context_line":"in the filter and goodness functions. In this example the LVM driver\u0027s"},{"line_number":366,"context_line":"``total_volumes`` capability is being used to determine which host gets"},{"line_number":367,"context_line":"used during a volume request. In the above example, lvm-1 and lvm-2 will"}],"source_content_type":"text/x-rst","patch_set":1,"id":"dab17558_50023370","line":364,"in_reply_to":"dab17558_980df039","updated":"2016-05-10 02:48:47.000000000","message":"So the Contributor Guide - http://docs.openstack.org/contributor-guide/writing-style/word-choice.html recommends using the hyphen, or a more specific term. I\u0027ll add contacting an SME to find a more specific term for this section, and discuss this at the next user guide meeting. Shalakha, this is a good point - I think a adopting a specific term for the Filter and Weigher content will help here.","commit_id":"b92ff99301b42b463a5ea60821bfc8c5d859fe38"}]}