)]}'
{"doc/contributor-guide/source/docs-review-guidelines.rst":[{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Critique categories"},{"line_number":9,"context_line":"~~~~~~~~~~~~~~~~~~~"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Objective"},{"line_number":12,"context_line":"---------"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_9d40d408","line":10,"updated":"2016-07-07 11:30:02.000000000","message":"This may require at least a short intro.","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14643,"name":"Olga Gusarenko","email":"ogusarenko@mirantis.com","username":"Olga"},"change_message_id":"decc323f6e94ffa0e174e2ba6c0f203b92f764cd","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Critique categories"},{"line_number":9,"context_line":"~~~~~~~~~~~~~~~~~~~"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Objective"},{"line_number":12,"context_line":"---------"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_a0d59fe5","line":10,"in_reply_to":"1aa78d24_9d40d408","updated":"2016-07-07 14:44:39.000000000","message":"+1 (a couple of short sentences explaining what the whole subsection is about)","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9455b2ffaa13848100d559492b95afa44a439e90","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Critique categories"},{"line_number":9,"context_line":"~~~~~~~~~~~~~~~~~~~"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Objective"},{"line_number":12,"context_line":"---------"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_1482d5c8","line":10,"in_reply_to":"1aa78d24_a0d59fe5","updated":"2016-07-08 02:06:47.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  provide appropriate comments, score the patch with a -1, and consider"},{"line_number":81,"context_line":"  mentioning your issue on the mailing list or in a meeting."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  * Example: A new service uses \"key \u003d value\" in the configuration file"},{"line_number":84,"context_line":"    and all other services use \"key\u003dvalue\" in their configuration files."},{"line_number":85,"context_line":"    Both methods work, but the book should maintain consistency."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_64a479b9","line":83,"range":{"start_line":83,"start_character":2,"end_line":83,"end_character":4},"updated":"2016-07-07 11:30:02.000000000","message":"I believe the bullet is not required for the example.","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9455b2ffaa13848100d559492b95afa44a439e90","unresolved":false,"context_lines":[{"line_number":80,"context_line":"  provide appropriate comments, score the patch with a -1, and consider"},{"line_number":81,"context_line":"  mentioning your issue on the mailing list or in a meeting."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  * Example: A new service uses \"key \u003d value\" in the configuration file"},{"line_number":84,"context_line":"    and all other services use \"key\u003dvalue\" in their configuration files."},{"line_number":85,"context_line":"    Both methods work, but the book should maintain consistency."},{"line_number":86,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_3469d126","line":83,"range":{"start_line":83,"start_character":2,"end_line":83,"end_character":4},"in_reply_to":"1aa78d24_64a479b9","updated":"2016-07-08 02:06:47.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    and all other services use \"key\u003dvalue\" in their configuration files."},{"line_number":85,"context_line":"    Both methods work, but the book should maintain consistency."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* If a patch has already recieved a -1, do not be discouraged to check"},{"line_number":88,"context_line":"  on it, and add additional comments. This way, there will be fewer patch"},{"line_number":89,"context_line":"  sets and comments building up under one review."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_c7c28f84","line":87,"range":{"start_line":87,"start_character":62,"end_line":87,"end_character":70},"updated":"2016-07-07 11:30:02.000000000","message":"from checking","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    and all other services use \"key\u003dvalue\" in their configuration files."},{"line_number":85,"context_line":"    Both methods work, but the book should maintain consistency."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* If a patch has already recieved a -1, do not be discouraged to check"},{"line_number":88,"context_line":"  on it, and add additional comments. This way, there will be fewer patch"},{"line_number":89,"context_line":"  sets and comments building up under one review."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_c7dbaf7a","line":87,"range":{"start_line":87,"start_character":25,"end_line":87,"end_character":33},"updated":"2016-07-07 11:30:02.000000000","message":"received","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9455b2ffaa13848100d559492b95afa44a439e90","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    and all other services use \"key\u003dvalue\" in their configuration files."},{"line_number":85,"context_line":"    Both methods work, but the book should maintain consistency."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* If a patch has already recieved a -1, do not be discouraged to check"},{"line_number":88,"context_line":"  on it, and add additional comments. This way, there will be fewer patch"},{"line_number":89,"context_line":"  sets and comments building up under one review."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_5453bd6c","line":87,"range":{"start_line":87,"start_character":62,"end_line":87,"end_character":70},"in_reply_to":"1aa78d24_c7c28f84","updated":"2016-07-08 02:06:47.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9455b2ffaa13848100d559492b95afa44a439e90","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    and all other services use \"key\u003dvalue\" in their configuration files."},{"line_number":85,"context_line":"    Both methods work, but the book should maintain consistency."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"* If a patch has already recieved a -1, do not be discouraged to check"},{"line_number":88,"context_line":"  on it, and add additional comments. This way, there will be fewer patch"},{"line_number":89,"context_line":"  sets and comments building up under one review."},{"line_number":90,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_1459358f","line":87,"range":{"start_line":87,"start_character":25,"end_line":87,"end_character":33},"in_reply_to":"1aa78d24_c7dbaf7a","updated":"2016-07-08 02:06:47.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":106,"context_line":"The waiting game"},{"line_number":107,"context_line":"~~~~~~~~~~~~~~~~"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"After the first review with a -1 or 0 score, an author should update"},{"line_number":110,"context_line":"the patch. Authors do not need to wait for a lengthy period of time."},{"line_number":111,"context_line":"Expect to leave some time for reviewers to check on a patch, however."},{"line_number":112,"context_line":"Consider that some reviewers are located in different timezones."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_64b919cc","line":109,"range":{"start_line":109,"start_character":45,"end_line":109,"end_character":47},"updated":"2016-07-07 11:30:02.000000000","message":"the","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9455b2ffaa13848100d559492b95afa44a439e90","unresolved":false,"context_lines":[{"line_number":106,"context_line":"The waiting game"},{"line_number":107,"context_line":"~~~~~~~~~~~~~~~~"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"After the first review with a -1 or 0 score, an author should update"},{"line_number":110,"context_line":"the patch. Authors do not need to wait for a lengthy period of time."},{"line_number":111,"context_line":"Expect to leave some time for reviewers to check on a patch, however."},{"line_number":112,"context_line":"Consider that some reviewers are located in different timezones."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_3450b15e","line":109,"range":{"start_line":109,"start_character":45,"end_line":109,"end_character":47},"in_reply_to":"1aa78d24_64b919cc","updated":"2016-07-08 02:06:47.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14643,"name":"Olga Gusarenko","email":"ogusarenko@mirantis.com","username":"Olga"},"change_message_id":"decc323f6e94ffa0e174e2ba6c0f203b92f764cd","unresolved":false,"context_lines":[{"line_number":121,"context_line":"* Scores available to core reviewers: -2, -1, 0, +1, +2"},{"line_number":122,"context_line":"* Approvals"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"  * A core reviewer can approve a patch with +4 points, typically after"},{"line_number":125,"context_line":"    it obtains two +2 scores from other core reviewers."},{"line_number":126,"context_line":"  * A core reviewer can +2 score a patch with a +2 score from another"},{"line_number":127,"context_line":"    core reviewer and approve it."},{"line_number":128,"context_line":"  * A core reviewer can +2 score a patch with two +1 from other reviewers"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_d63191a3","line":125,"range":{"start_line":124,"start_character":0,"end_line":125,"end_character":55},"updated":"2016-07-07 14:44:39.000000000","message":"As Andreas suggested in Austin, could you please add here that it is advised that if the change contains important/critical information the core reviewer should not approve it immediately but provide some time (~ 7-10 days) for wider community audience to express their opinion.","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9455b2ffaa13848100d559492b95afa44a439e90","unresolved":false,"context_lines":[{"line_number":121,"context_line":"* Scores available to core reviewers: -2, -1, 0, +1, +2"},{"line_number":122,"context_line":"* Approvals"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"  * A core reviewer can approve a patch with +4 points, typically after"},{"line_number":125,"context_line":"    it obtains two +2 scores from other core reviewers."},{"line_number":126,"context_line":"  * A core reviewer can +2 score a patch with a +2 score from another"},{"line_number":127,"context_line":"    core reviewer and approve it."},{"line_number":128,"context_line":"  * A core reviewer can +2 score a patch with two +1 from other reviewers"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_173ad7e7","line":125,"range":{"start_line":124,"start_character":0,"end_line":125,"end_character":55},"in_reply_to":"1aa78d24_d63191a3","updated":"2016-07-08 02:06:47.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":128,"context_line":"  * A core reviewer can +2 score a patch with two +1 from other reviewers"},{"line_number":129,"context_line":"    and approve it."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Note: If you find an issue with a patch that already has a +2 score from"},{"line_number":132,"context_line":"another core reviewer, consider commenting on the issue and scoring the"},{"line_number":133,"context_line":"patch with a 0 rather than scoring it with a -1."},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_c4244d0e","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":5},"updated":"2016-07-07 11:30:02.000000000","message":".. note::","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9455b2ffaa13848100d559492b95afa44a439e90","unresolved":false,"context_lines":[{"line_number":128,"context_line":"  * A core reviewer can +2 score a patch with two +1 from other reviewers"},{"line_number":129,"context_line":"    and approve it."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Note: If you find an issue with a patch that already has a +2 score from"},{"line_number":132,"context_line":"another core reviewer, consider commenting on the issue and scoring the"},{"line_number":133,"context_line":"patch with a 0 rather than scoring it with a -1."},{"line_number":134,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_94e405ad","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":5},"in_reply_to":"1aa78d24_c4244d0e","updated":"2016-07-08 02:06:47.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":132,"context_line":"another core reviewer, consider commenting on the issue and scoring the"},{"line_number":133,"context_line":"patch with a 0 rather than scoring it with a -1."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Set WorkInProgress (WIP) during review"},{"line_number":136,"context_line":"--------------------------------------"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"The WIP tag tells anyone looking at a change that more updates are still"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_e757cb55","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":3},"updated":"2016-07-07 11:30:02.000000000","message":"Setting","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9455b2ffaa13848100d559492b95afa44a439e90","unresolved":false,"context_lines":[{"line_number":132,"context_line":"another core reviewer, consider commenting on the issue and scoring the"},{"line_number":133,"context_line":"patch with a 0 rather than scoring it with a -1."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"Set WorkInProgress (WIP) during review"},{"line_number":136,"context_line":"--------------------------------------"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"The WIP tag tells anyone looking at a change that more updates are still"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_54da9dea","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":3},"in_reply_to":"1aa78d24_e757cb55","updated":"2016-07-08 02:06:47.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"To add the WIP tag:"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Click a patch set."},{"line_number":156,"context_line":"* Click the Review button."},{"line_number":157,"context_line":"* Choose the \u0027-1 Work In Progress\u0027 from the Workflow options,"},{"line_number":158,"context_line":"  enter comments (optional)."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_24e551a7","line":155,"range":{"start_line":155,"start_character":0,"end_line":155,"end_character":1},"updated":"2016-07-07 11:30:02.000000000","message":"This can be a numbered list instead.","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9455b2ffaa13848100d559492b95afa44a439e90","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"To add the WIP tag:"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Click a patch set."},{"line_number":156,"context_line":"* Click the Review button."},{"line_number":157,"context_line":"* Choose the \u0027-1 Work In Progress\u0027 from the Workflow options,"},{"line_number":158,"context_line":"  enter comments (optional)."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_3721d3b5","line":155,"range":{"start_line":155,"start_character":0,"end_line":155,"end_character":1},"in_reply_to":"1aa78d24_24e551a7","updated":"2016-07-08 02:06:47.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":153,"context_line":"To add the WIP tag:"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Click a patch set."},{"line_number":156,"context_line":"* Click the Review button."},{"line_number":157,"context_line":"* Choose the \u0027-1 Work In Progress\u0027 from the Workflow options,"},{"line_number":158,"context_line":"  enter comments (optional)."},{"line_number":159,"context_line":"* Click Publish Comments."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_e48ce9db","line":156,"range":{"start_line":156,"start_character":12,"end_line":156,"end_character":18},"updated":"2016-07-07 11:30:02.000000000","message":"Isn\u0027t it not \"Reply...\"?\n\n#. Click :guilabel:`Reply...`.","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9455b2ffaa13848100d559492b95afa44a439e90","unresolved":false,"context_lines":[{"line_number":153,"context_line":"To add the WIP tag:"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Click a patch set."},{"line_number":156,"context_line":"* Click the Review button."},{"line_number":157,"context_line":"* Choose the \u0027-1 Work In Progress\u0027 from the Workflow options,"},{"line_number":158,"context_line":"  enter comments (optional)."},{"line_number":159,"context_line":"* Click Publish Comments."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_ca2426b4","line":156,"range":{"start_line":156,"start_character":12,"end_line":156,"end_character":18},"in_reply_to":"1aa78d24_e48ce9db","updated":"2016-07-08 02:06:47.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Click a patch set."},{"line_number":156,"context_line":"* Click the Review button."},{"line_number":157,"context_line":"* Choose the \u0027-1 Work In Progress\u0027 from the Workflow options,"},{"line_number":158,"context_line":"  enter comments (optional)."},{"line_number":159,"context_line":"* Click Publish Comments."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"This sets a -1 and informs everyone that the patch is WorkInProgress."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_e40fc934","line":158,"range":{"start_line":157,"start_character":0,"end_line":158,"end_character":28},"updated":"2016-07-07 11:30:02.000000000","message":"#. Choose :guilabel:`-1 Work in progress` from the :guilabel:`Workflow` options.\n\n#. Optional. Enter comments.","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9455b2ffaa13848100d559492b95afa44a439e90","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"* Click a patch set."},{"line_number":156,"context_line":"* Click the Review button."},{"line_number":157,"context_line":"* Choose the \u0027-1 Work In Progress\u0027 from the Workflow options,"},{"line_number":158,"context_line":"  enter comments (optional)."},{"line_number":159,"context_line":"* Click Publish Comments."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"This sets a -1 and informs everyone that the patch is WorkInProgress."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_4a6796ea","line":158,"range":{"start_line":157,"start_character":0,"end_line":158,"end_character":28},"in_reply_to":"1aa78d24_e40fc934","updated":"2016-07-08 02:06:47.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":156,"context_line":"* Click the Review button."},{"line_number":157,"context_line":"* Choose the \u0027-1 Work In Progress\u0027 from the Workflow options,"},{"line_number":158,"context_line":"  enter comments (optional)."},{"line_number":159,"context_line":"* Click Publish Comments."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"This sets a -1 and informs everyone that the patch is WorkInProgress."},{"line_number":162,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_072f7788","line":159,"range":{"start_line":159,"start_character":0,"end_line":159,"end_character":25},"updated":"2016-07-07 11:30:02.000000000","message":"#. Click :guilabel:`Post`.","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9455b2ffaa13848100d559492b95afa44a439e90","unresolved":false,"context_lines":[{"line_number":156,"context_line":"* Click the Review button."},{"line_number":157,"context_line":"* Choose the \u0027-1 Work In Progress\u0027 from the Workflow options,"},{"line_number":158,"context_line":"  enter comments (optional)."},{"line_number":159,"context_line":"* Click Publish Comments."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"This sets a -1 and informs everyone that the patch is WorkInProgress."},{"line_number":162,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_6a47f24b","line":159,"range":{"start_line":159,"start_character":0,"end_line":159,"end_character":25},"in_reply_to":"1aa78d24_072f7788","updated":"2016-07-08 02:06:47.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":163,"context_line":"Abandoning patches"},{"line_number":164,"context_line":"------------------"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Patches that will not go in, should be abandoned to clean the review list."},{"line_number":167,"context_line":"Both the patch owner and cores can abandon a patch - and"},{"line_number":168,"context_line":"also resurrect it again."},{"line_number":169,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_e7234b54","line":166,"range":{"start_line":166,"start_character":27,"end_line":166,"end_character":28},"updated":"2016-07-07 11:30:02.000000000","message":"no comma","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9455b2ffaa13848100d559492b95afa44a439e90","unresolved":false,"context_lines":[{"line_number":163,"context_line":"Abandoning patches"},{"line_number":164,"context_line":"------------------"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Patches that will not go in, should be abandoned to clean the review list."},{"line_number":167,"context_line":"Both the patch owner and cores can abandon a patch - and"},{"line_number":168,"context_line":"also resurrect it again."},{"line_number":169,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_6a5ed213","line":166,"range":{"start_line":166,"start_character":27,"end_line":166,"end_character":28},"in_reply_to":"1aa78d24_e7234b54","updated":"2016-07-08 02:06:47.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":164,"context_line":"------------------"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Patches that will not go in, should be abandoned to clean the review list."},{"line_number":167,"context_line":"Both the patch owner and cores can abandon a patch - and"},{"line_number":168,"context_line":"also resurrect it again."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Translation and sync patches by the OpenStack Proposal Bot"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_67bd9bd7","line":167,"range":{"start_line":167,"start_character":51,"end_line":167,"end_character":52},"updated":"2016-07-07 11:30:02.000000000","message":"please remove","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9455b2ffaa13848100d559492b95afa44a439e90","unresolved":false,"context_lines":[{"line_number":164,"context_line":"------------------"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"Patches that will not go in, should be abandoned to clean the review list."},{"line_number":167,"context_line":"Both the patch owner and cores can abandon a patch - and"},{"line_number":168,"context_line":"also resurrect it again."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Translation and sync patches by the OpenStack Proposal Bot"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_aa855a5a","line":167,"range":{"start_line":167,"start_character":51,"end_line":167,"end_character":52},"in_reply_to":"1aa78d24_67bd9bd7","updated":"2016-07-08 02:06:47.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"Both the patch owner and cores can abandon a patch - and"},{"line_number":168,"context_line":"also resurrect it again."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Translation and sync patches by the OpenStack Proposal Bot"},{"line_number":171,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"There are a few proposal jobs setup that are run regularly:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_47669f51","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":58},"updated":"2016-07-07 11:30:02.000000000","message":"Can be something like: \nOpenStack Proposal Bot patches\nor: \nPatches by the OpenStack Proposal Bot","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9455b2ffaa13848100d559492b95afa44a439e90","unresolved":false,"context_lines":[{"line_number":167,"context_line":"Both the patch owner and cores can abandon a patch - and"},{"line_number":168,"context_line":"also resurrect it again."},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Translation and sync patches by the OpenStack Proposal Bot"},{"line_number":171,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"There are a few proposal jobs setup that are run regularly:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_0af2ae06","line":170,"range":{"start_line":170,"start_character":0,"end_line":170,"end_character":58},"in_reply_to":"1aa78d24_47669f51","updated":"2016-07-08 02:06:47.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"Translation and sync patches by the OpenStack Proposal Bot"},{"line_number":171,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"There are a few proposal jobs setup that are run regularly:"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"* ``Imported Translations from Zanata``: Import of translated files from"},{"line_number":176,"context_line":"  the translation infrastructure."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_e7ea2bda","line":173,"range":{"start_line":173,"start_character":30,"end_line":173,"end_character":35},"updated":"2016-07-07 11:30:02.000000000","message":"set up","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9455b2ffaa13848100d559492b95afa44a439e90","unresolved":false,"context_lines":[{"line_number":170,"context_line":"Translation and sync patches by the OpenStack Proposal Bot"},{"line_number":171,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"There are a few proposal jobs setup that are run regularly:"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"* ``Imported Translations from Zanata``: Import of translated files from"},{"line_number":176,"context_line":"  the translation infrastructure."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_4adcb674","line":173,"range":{"start_line":173,"start_character":30,"end_line":173,"end_character":35},"in_reply_to":"1aa78d24_e7ea2bda","updated":"2016-07-08 02:06:47.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  test-requirements.txt from the global requirements repository."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"For all types of patches, any core just approves it if all the tests pass."},{"line_number":185,"context_line":"If the tests do not patch, vote -1 on the patch, fix the problem and wait for"},{"line_number":186,"context_line":"the next proposal run. The proposal job will update a patch with the next run."},{"line_number":187,"context_line":"If you cannot fix the problem, ask for help this up on the mailing lists:"},{"line_number":188,"context_line":"openstack-i18n for translation update failures, openstack-doc for others."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_6792bb4d","line":185,"range":{"start_line":185,"start_character":20,"end_line":185,"end_character":25},"updated":"2016-07-07 11:30:02.000000000","message":"pass","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9455b2ffaa13848100d559492b95afa44a439e90","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  test-requirements.txt from the global requirements repository."},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"For all types of patches, any core just approves it if all the tests pass."},{"line_number":185,"context_line":"If the tests do not patch, vote -1 on the patch, fix the problem and wait for"},{"line_number":186,"context_line":"the next proposal run. The proposal job will update a patch with the next run."},{"line_number":187,"context_line":"If you cannot fix the problem, ask for help this up on the mailing lists:"},{"line_number":188,"context_line":"openstack-i18n for translation update failures, openstack-doc for others."}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_aad39a5e","line":185,"range":{"start_line":185,"start_character":20,"end_line":185,"end_character":25},"in_reply_to":"1aa78d24_6792bb4d","updated":"2016-07-08 02:06:47.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"For all types of patches, any core just approves it if all the tests pass."},{"line_number":185,"context_line":"If the tests do not patch, vote -1 on the patch, fix the problem and wait for"},{"line_number":186,"context_line":"the next proposal run. The proposal job will update a patch with the next run."},{"line_number":187,"context_line":"If you cannot fix the problem, ask for help this up on the mailing lists:"},{"line_number":188,"context_line":"openstack-i18n for translation update failures, openstack-doc for others."},{"line_number":189,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_e7cd0b67","line":186,"range":{"start_line":186,"start_character":52,"end_line":186,"end_character":53},"updated":"2016-07-07 11:30:02.000000000","message":"the","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9455b2ffaa13848100d559492b95afa44a439e90","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"For all types of patches, any core just approves it if all the tests pass."},{"line_number":185,"context_line":"If the tests do not patch, vote -1 on the patch, fix the problem and wait for"},{"line_number":186,"context_line":"the next proposal run. The proposal job will update a patch with the next run."},{"line_number":187,"context_line":"If you cannot fix the problem, ask for help this up on the mailing lists:"},{"line_number":188,"context_line":"openstack-i18n for translation update failures, openstack-doc for others."},{"line_number":189,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_8a197e25","line":186,"range":{"start_line":186,"start_character":52,"end_line":186,"end_character":53},"in_reply_to":"1aa78d24_e7cd0b67","updated":"2016-07-08 02:06:47.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14643,"name":"Olga Gusarenko","email":"ogusarenko@mirantis.com","username":"Olga"},"change_message_id":"2686ecd7d5204a1bdb827e6bcb16848901a6528e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"* Commit message"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  * Content"},{"line_number":19,"context_line":"  * Conventions"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"* Patch"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_a31c60c2","line":19,"updated":"2016-07-08 08:15:20.000000000","message":"Please add about a bug number (approved!) or a blueprint + link to git messages best practices https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"e567f096778e5a89f44b8b1c820bd60b1d4c59c3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"* Commit message"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  * Content"},{"line_number":19,"context_line":"  * Conventions"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"* Patch"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_7f916052","line":19,"in_reply_to":"1aa78d24_a31c60c2","updated":"2016-07-08 10:34:51.000000000","message":"Done","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":14643,"name":"Olga Gusarenko","email":"ogusarenko@mirantis.com","username":"Olga"},"change_message_id":"2686ecd7d5204a1bdb827e6bcb16848901a6528e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  * Content"},{"line_number":19,"context_line":"  * Conventions"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"* Patch"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  * Content"},{"line_number":24,"context_line":"  * Conventions"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_03c61416","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":7},"updated":"2016-07-08 08:15:20.000000000","message":"I would also add here another option - the accuracy of the selected location of the information to live after it is merged and, of course, reviewing for the information duplication.","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"e567f096778e5a89f44b8b1c820bd60b1d4c59c3","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  * Content"},{"line_number":19,"context_line":"  * Conventions"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"* Patch"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  * Content"},{"line_number":24,"context_line":"  * Conventions"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_7f5a0052","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":7},"in_reply_to":"1aa78d24_03c61416","updated":"2016-07-08 10:34:51.000000000","message":"Done","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":14643,"name":"Olga Gusarenko","email":"ogusarenko@mirantis.com","username":"Olga"},"change_message_id":"2686ecd7d5204a1bdb827e6bcb16848901a6528e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"* Patch"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  * Content"},{"line_number":24,"context_line":"  * Conventions"},{"line_number":25,"context_line":"  * Grammar"},{"line_number":26,"context_line":"  * :doc:`Style, phrasing, wording, and capitalization \u003cwriting-style\u003e`"},{"line_number":27,"context_line":"  * Spelling"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_439e5c08","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":15},"updated":"2016-07-08 08:15:20.000000000","message":"What is meant under conventions here? Could you please clarify because it is too general at the moment..","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"e567f096778e5a89f44b8b1c820bd60b1d4c59c3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"* Patch"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  * Content"},{"line_number":24,"context_line":"  * Conventions"},{"line_number":25,"context_line":"  * Grammar"},{"line_number":26,"context_line":"  * :doc:`Style, phrasing, wording, and capitalization \u003cwriting-style\u003e`"},{"line_number":27,"context_line":"  * Spelling"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_ff66f027","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":15},"in_reply_to":"1aa78d24_439e5c08","updated":"2016-07-08 10:34:51.000000000","message":"I removed this. This is duplicated: Style, phrasing, wording, and capitalization.","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"04f6859a1497667bb47c3089eab7484943a6ec1c","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  * Grammar"},{"line_number":42,"context_line":"  * Style, phrasing, and wording"},{"line_number":43,"context_line":"  * Other suggestions"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Scope"},{"line_number":46,"context_line":"~~~~~"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_a96c3a37","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":21},"updated":"2016-07-08 10:10:27.000000000","message":"Add \u0027technical accuracy\u0027 as that is equally, if not more, important","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"e567f096778e5a89f44b8b1c820bd60b1d4c59c3","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"  * Grammar"},{"line_number":42,"context_line":"  * Style, phrasing, and wording"},{"line_number":43,"context_line":"  * Other suggestions"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Scope"},{"line_number":46,"context_line":"~~~~~"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_ff7c30ed","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":21},"in_reply_to":"1aa78d24_a96c3a37","updated":"2016-07-08 10:34:51.000000000","message":"Done","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"04f6859a1497667bb47c3089eab7484943a6ec1c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"  and all other services use \"key\u003dvalue\" in their configuration files."},{"line_number":87,"context_line":"  Both methods work, but the book should maintain consistency."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"* If a patch has already received a -1, do not be discouraged from"},{"line_number":90,"context_line":"  checking on it, and add additional comments. This way, there will"},{"line_number":91,"context_line":"  be fewer patch sets and comments building up under one review."},{"line_number":92,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_c98f06cb","line":89,"range":{"start_line":89,"start_character":2,"end_line":89,"end_character":38},"updated":"2016-07-08 10:10:27.000000000","message":"Maybe also add a note note to double up a -1 if you agree with someone else\u0027s -1. Adding a second \u0027-1\u0027 does not add to the patch.","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"04f6859a1497667bb47c3089eab7484943a6ec1c","unresolved":false,"context_lines":[{"line_number":113,"context_line":"Expect to leave some time for reviewers to check on a patch, however."},{"line_number":114,"context_line":"Consider that some reviewers are located in different timezones."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Core reviewers will in general review a patch within a few days."},{"line_number":117,"context_line":"If no review happens, feel free to ask on the #openstack-docs IRC channel."},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Review scoring and approvals"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_29620a17","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":30},"updated":"2016-07-08 10:10:27.000000000","message":"In general, core reviewers will review a patch within a few days.*","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":14643,"name":"Olga Gusarenko","email":"ogusarenko@mirantis.com","username":"Olga"},"change_message_id":"2686ecd7d5204a1bdb827e6bcb16848901a6528e","unresolved":false,"context_lines":[{"line_number":133,"context_line":".. note::"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"   If you find an issue with a patch that already has a +2 score from"},{"line_number":136,"context_line":"   another core reviewer, consider commenting on the issue and scoring the"},{"line_number":137,"context_line":"   patch with a 0 rather than scoring it with a -1."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Setting WorkInProgress (WIP) during review"},{"line_number":140,"context_line":"------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_c3e6cc43","line":137,"range":{"start_line":136,"start_character":59,"end_line":137,"end_character":51},"updated":"2016-07-08 08:15:20.000000000","message":"Kato, I cannot agree here. -1 attracts more attention from reviewers and prevents other cores from merging showing that the issue matters (if it really does, of course).","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"04f6859a1497667bb47c3089eab7484943a6ec1c","unresolved":false,"context_lines":[{"line_number":133,"context_line":".. note::"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"   If you find an issue with a patch that already has a +2 score from"},{"line_number":136,"context_line":"   another core reviewer, consider commenting on the issue and scoring the"},{"line_number":137,"context_line":"   patch with a 0 rather than scoring it with a -1."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Setting WorkInProgress (WIP) during review"},{"line_number":140,"context_line":"------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_6943726d","line":137,"range":{"start_line":136,"start_character":59,"end_line":137,"end_character":51},"in_reply_to":"1aa78d24_c3e6cc43","updated":"2016-07-08 10:10:27.000000000","message":"+1 to this, tbh. Unless of course the issue is not a blocker. I think maybe include both instances in this note?","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"04f6859a1497667bb47c3089eab7484943a6ec1c","unresolved":false,"context_lines":[{"line_number":168,"context_line":"Abandoning patches"},{"line_number":169,"context_line":"------------------"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Patches that will not go in should be abandoned to clean the review list."},{"line_number":172,"context_line":"Both the patch owner and cores can abandon a patch and also resurrect it"},{"line_number":173,"context_line":"again."},{"line_number":174,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_5c08f228","line":171,"range":{"start_line":171,"start_character":0,"end_line":171,"end_character":73},"updated":"2016-07-08 10:10:27.000000000","message":"Abandon any patches that cannot be passed to clear the review list.*","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"04f6859a1497667bb47c3089eab7484943a6ec1c","unresolved":false,"context_lines":[{"line_number":169,"context_line":"------------------"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"Patches that will not go in should be abandoned to clean the review list."},{"line_number":172,"context_line":"Both the patch owner and cores can abandon a patch and also resurrect it"},{"line_number":173,"context_line":"again."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"Patches by OpenStack Proposal Bot"},{"line_number":176,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_bc19167c","line":173,"range":{"start_line":172,"start_character":35,"end_line":173,"end_character":6},"updated":"2016-07-08 10:10:27.000000000","message":"can abandon or resurrect a patch.*","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"04f6859a1497667bb47c3089eab7484943a6ec1c","unresolved":false,"context_lines":[{"line_number":196,"context_line":"Considerations for documentation aligned with release cycles"},{"line_number":197,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"Beginning with milestone releases, shift focus to objective issues,"},{"line_number":200,"context_line":"especially with new services and existing services with significant changes."},{"line_number":201,"context_line":"Only patches with significant subjective issues should receive a -1 score."},{"line_number":202,"context_line":"Otherwise, comment on subjective issues and score with a 0."}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_1c730ab6","line":199,"range":{"start_line":199,"start_character":0,"end_line":199,"end_character":34},"updated":"2016-07-08 10:10:27.000000000","message":"Do you mean, \"At the beginning of milestone releases, focused is shifted to objective issues, especially with new services and existing services with significant changes.\" ?","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":9382,"name":"Shilla Saebi","email":"shilla.saebi@gmail.com","username":"shillasaebi"},"change_message_id":"bc690fb35e113d248887b0a82f368ca04a333ed8","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Critique categories"},{"line_number":9,"context_line":"~~~~~~~~~~~~~~~~~~~"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The below list is critique categories from the viewpoint of review."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Objective"},{"line_number":14,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1aa78d24_447db0e6","line":11,"updated":"2016-07-08 14:12:12.000000000","message":"Can we rephrase the sentence? It doesn\u0027t seem right to me. Maybe something like: \n\nBelow is a list of the categories you will critique as the reviewer","commit_id":"9edad57d9ca89ad1228a18a0701bac1b4ac8e588"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"7b8aca517c87ef41d9a36a1e6ed10475baf48f83","unresolved":false,"context_lines":[{"line_number":8,"context_line":"Critique categories"},{"line_number":9,"context_line":"~~~~~~~~~~~~~~~~~~~"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The below list is critique categories from the viewpoint of review."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Objective"},{"line_number":14,"context_line":"---------"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1aa78d24_9e2fb2a0","line":11,"in_reply_to":"1aa78d24_447db0e6","updated":"2016-07-10 23:58:11.000000000","message":"Done","commit_id":"9edad57d9ca89ad1228a18a0701bac1b4ac8e588"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":104,"context_line":"wait two weeks at least. If you have difficulty getting a reviewer"},{"line_number":105,"context_line":"for a particular project, use the `Cross Project Documentation Liaisons"},{"line_number":106,"context_line":"\u003chttps://wiki.openstack.org/wiki/CrossProjectLiaisons#Documentation\u003e`_"},{"line_number":107,"context_line":"page to contact the doc liaison for the project to get a reviewer."},{"line_number":108,"context_line":"The Documentation PTL can also assist in getting reviewers attention."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"The waiting game"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_f95a9af1","line":107,"updated":"2016-07-13 22:49:16.000000000","message":"Change \"doc\" to \"documentation\" or remove the word.","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":104,"context_line":"wait two weeks at least. If you have difficulty getting a reviewer"},{"line_number":105,"context_line":"for a particular project, use the `Cross Project Documentation Liaisons"},{"line_number":106,"context_line":"\u003chttps://wiki.openstack.org/wiki/CrossProjectLiaisons#Documentation\u003e`_"},{"line_number":107,"context_line":"page to contact the doc liaison for the project to get a reviewer."},{"line_number":108,"context_line":"The Documentation PTL can also assist in getting reviewers attention."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"The waiting game"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_0c15a148","line":107,"in_reply_to":"1aa78d24_f95a9af1","updated":"2016-07-14 02:42:07.000000000","message":"Use \"documentation\"","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Consider that some reviewers are located in different timezones."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Core reviewers will in general review a patch within a few days."},{"line_number":119,"context_line":"If no review happens, feel free to ask on the #openstack-docs IRC channel."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Review scoring and approvals"},{"line_number":122,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_d9023eba","line":119,"updated":"2016-07-13 22:49:16.000000000","message":"#openstack-doc","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":116,"context_line":"Consider that some reviewers are located in different timezones."},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"Core reviewers will in general review a patch within a few days."},{"line_number":119,"context_line":"If no review happens, feel free to ask on the #openstack-docs IRC channel."},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Review scoring and approvals"},{"line_number":122,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_d7016206","line":119,"in_reply_to":"1aa78d24_d9023eba","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":130,"context_line":"If the change contains important or critical information,"},{"line_number":131,"context_line":"the core reviewer should not approve it immediately, but provide a few days"},{"line_number":132,"context_line":"for wider community audience to express their opinion, and advise to email"},{"line_number":133,"context_line":"to the docs mailing list."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":".. note::"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_9918b620","line":133,"updated":"2016-07-13 22:49:16.000000000","message":"\"... and advise to email to the docs\" doesn\u0027t make sense to me. Maybe \"and suggest posting to the documentation mailing list\" ?","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":130,"context_line":"If the change contains important or critical information,"},{"line_number":131,"context_line":"the core reviewer should not approve it immediately, but provide a few days"},{"line_number":132,"context_line":"for wider community audience to express their opinion, and advise to email"},{"line_number":133,"context_line":"to the docs mailing list."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":".. note::"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_371ee65f","line":133,"in_reply_to":"1aa78d24_9918b620","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":141,"context_line":"Setting WorkInProgress (WIP) during review"},{"line_number":142,"context_line":"------------------------------------------"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"The WIP tag tells anyone looking at a change that more updates are still"},{"line_number":145,"context_line":"needed. Both the change\u0027s owner and any core reviewer can set the WIP statusː"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"* A change owner can set this tag on their own review to mark that"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_f9ad7a9c","line":144,"updated":"2016-07-13 22:49:16.000000000","message":"... tells potential reviewers to expect additional updates to a patch before reviewing.","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":141,"context_line":"Setting WorkInProgress (WIP) during review"},{"line_number":142,"context_line":"------------------------------------------"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"The WIP tag tells anyone looking at a change that more updates are still"},{"line_number":145,"context_line":"needed. Both the change\u0027s owner and any core reviewer can set the WIP statusː"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"* A change owner can set this tag on their own review to mark that"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_77386ed5","line":144,"in_reply_to":"1aa78d24_f9ad7a9c","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":149,"context_line":"  reviews while that happens."},{"line_number":150,"context_line":"* A core reviewer can set the WIP tag to acknowledge that a contributor"},{"line_number":151,"context_line":"  will definitely need to do more work on a change rather than merely"},{"line_number":152,"context_line":"  expressing an opinion on its readiness."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"This can be a great convenience to fellow reviewers. It allows the core"},{"line_number":155,"context_line":"reviewer to politely send the message that the change needs additional"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_997556fc","line":152,"updated":"2016-07-13 22:49:16.000000000","message":"Hmm, does this ever come up? I only set WIPs on patches involving me or by suggestion from the author(s). I consider patches without a WIP as ready for review and will give a -1/-2 before setting WIP.","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":149,"context_line":"  reviews while that happens."},{"line_number":150,"context_line":"* A core reviewer can set the WIP tag to acknowledge that a contributor"},{"line_number":151,"context_line":"  will definitely need to do more work on a change rather than merely"},{"line_number":152,"context_line":"  expressing an opinion on its readiness."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"This can be a great convenience to fellow reviewers. It allows the core"},{"line_number":155,"context_line":"reviewer to politely send the message that the change needs additional"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_d762023d","line":152,"in_reply_to":"1aa78d24_997556fc","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"To add the WIP tag:"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"#. Click a patch set."},{"line_number":162,"context_line":"#. Click :guilabel:`Reply...` button."},{"line_number":163,"context_line":"#. Choose :guilabel:`-1 (Work In Progress)` from the :guilabel:`Workflow`"},{"line_number":164,"context_line":"   options."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_99e396a4","line":161,"updated":"2016-07-13 22:49:16.000000000","message":"Click -\u003e select","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"To add the WIP tag:"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"#. Click a patch set."},{"line_number":162,"context_line":"#. Click :guilabel:`Reply...` button."},{"line_number":163,"context_line":"#. Choose :guilabel:`-1 (Work In Progress)` from the :guilabel:`Workflow`"},{"line_number":164,"context_line":"   options."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_972fda87","line":161,"in_reply_to":"1aa78d24_99e396a4","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":170,"context_line":"Abandoning patches"},{"line_number":171,"context_line":"------------------"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Patches that will not go in should be abandoned to clean the review list."},{"line_number":174,"context_line":"Both the patch owner and cores can abandon a patch and also resurrect it"},{"line_number":175,"context_line":"again."},{"line_number":176,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_9d18a177","line":173,"updated":"2016-07-13 22:49:16.000000000","message":"Core reviewers may abandon patches that receive a -2 review or lack activity for at least four weeks to freshen the patch review queue. The owner of a patch can also abandon it.","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":170,"context_line":"Abandoning patches"},{"line_number":171,"context_line":"------------------"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"Patches that will not go in should be abandoned to clean the review list."},{"line_number":174,"context_line":"Both the patch owner and cores can abandon a patch and also resurrect it"},{"line_number":175,"context_line":"again."},{"line_number":176,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_177f6a67","line":173,"in_reply_to":"1aa78d24_9d18a177","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":188,"context_line":"* ``Updated from global requirements``: Import of requirements.txt and"},{"line_number":189,"context_line":"  test-requirements.txt from the global requirements repository."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"For all types of patches, any core just approves it if all the tests pass."},{"line_number":192,"context_line":"If the tests do not pass, vote ``-1`` on the patch, fix the problem and"},{"line_number":193,"context_line":"wait for the next proposal run. The proposal job will update the patch"},{"line_number":194,"context_line":"with the next run."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_5d3599d9","line":191,"updated":"2016-07-13 22:49:16.000000000","message":"... any core can approve a patch...","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":188,"context_line":"* ``Updated from global requirements``: Import of requirements.txt and"},{"line_number":189,"context_line":"  test-requirements.txt from the global requirements repository."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"For all types of patches, any core just approves it if all the tests pass."},{"line_number":192,"context_line":"If the tests do not pass, vote ``-1`` on the patch, fix the problem and"},{"line_number":193,"context_line":"wait for the next proposal run. The proposal job will update the patch"},{"line_number":194,"context_line":"with the next run."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_370a667a","line":191,"in_reply_to":"1aa78d24_5d3599d9","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":192,"context_line":"If the tests do not pass, vote ``-1`` on the patch, fix the problem and"},{"line_number":193,"context_line":"wait for the next proposal run. The proposal job will update the patch"},{"line_number":194,"context_line":"with the next run."},{"line_number":195,"context_line":"If you cannot fix the problem, ask for help this up on the openstack-i18n"},{"line_number":196,"context_line":"mailing lists for translation update failures, openstack-doc for others."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Considerations for documentation aligned with release cycles"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_7d6695ef","line":195,"updated":"2016-07-13 22:49:16.000000000","message":"... help this up?","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":192,"context_line":"If the tests do not pass, vote ``-1`` on the patch, fix the problem and"},{"line_number":193,"context_line":"wait for the next proposal run. The proposal job will update the patch"},{"line_number":194,"context_line":"with the next run."},{"line_number":195,"context_line":"If you cannot fix the problem, ask for help this up on the openstack-i18n"},{"line_number":196,"context_line":"mailing lists for translation update failures, openstack-doc for others."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Considerations for documentation aligned with release cycles"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_d7068284","line":195,"in_reply_to":"1aa78d24_7d6695ef","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":193,"context_line":"wait for the next proposal run. The proposal job will update the patch"},{"line_number":194,"context_line":"with the next run."},{"line_number":195,"context_line":"If you cannot fix the problem, ask for help this up on the openstack-i18n"},{"line_number":196,"context_line":"mailing lists for translation update failures, openstack-doc for others."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Considerations for documentation aligned with release cycles"},{"line_number":199,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_1da831db","line":196,"updated":"2016-07-13 22:49:16.000000000","message":"I suggest using some sort of list here, for example.\n\nopenstack-i18n: translation failures, blah, blah...\nopenstack-doc: requirements failures, blah, blah...","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":193,"context_line":"wait for the next proposal run. The proposal job will update the patch"},{"line_number":194,"context_line":"with the next run."},{"line_number":195,"context_line":"If you cannot fix the problem, ask for help this up on the openstack-i18n"},{"line_number":196,"context_line":"mailing lists for translation update failures, openstack-doc for others."},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Considerations for documentation aligned with release cycles"},{"line_number":199,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_f701fe6e","line":196,"in_reply_to":"1aa78d24_1da831db","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f5baf391dd64933557324b139caf2b71da0f0b75","unresolved":false,"context_lines":[{"line_number":157,"context_line":"To add the WIP tag:"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"#. Select a patch set."},{"line_number":160,"context_line":"#. Click :guilabel:`Reply...` button."},{"line_number":161,"context_line":"#. Choose :guilabel:`-1 (Work In Progress)` from the :guilabel:`Workflow`"},{"line_number":162,"context_line":"   options."},{"line_number":163,"context_line":"#. Optional. Enter comments."}],"source_content_type":"text/x-rst","patch_set":9,"id":"1aa78d24_73782ff9","line":160,"updated":"2016-07-15 13:48:43.000000000","message":"Changing click to select applies to all instances.","commit_id":"8baad05c364cf5f33d5b02402ccd8e4b459444d3"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"22651348868bc707562e8c4dce039878599dfe70","unresolved":false,"context_lines":[{"line_number":157,"context_line":"To add the WIP tag:"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"#. Select a patch set."},{"line_number":160,"context_line":"#. Click :guilabel:`Reply...` button."},{"line_number":161,"context_line":"#. Choose :guilabel:`-1 (Work In Progress)` from the :guilabel:`Workflow`"},{"line_number":162,"context_line":"   options."},{"line_number":163,"context_line":"#. Optional. Enter comments."}],"source_content_type":"text/x-rst","patch_set":9,"id":"fad55976_f07bd879","line":160,"in_reply_to":"1aa78d24_73782ff9","updated":"2016-07-15 14:50:12.000000000","message":"Done","commit_id":"8baad05c364cf5f33d5b02402ccd8e4b459444d3"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f5baf391dd64933557324b139caf2b71da0f0b75","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Core reviewers may abandon patches that receive a -2 review or"},{"line_number":172,"context_line":"lack activity for at least four weeks to freshen the patch review queue."},{"line_number":173,"context_line":"The owner of a patch can also abandon it."},{"line_number":174,"context_line":"The owner and core reviewers can resurrect it again."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Patches by OpenStack Proposal Bot"},{"line_number":177,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1aa78d24_5362533e","line":174,"updated":"2016-07-15 13:48:43.000000000","message":"resurrect -\u003e restore","commit_id":"8baad05c364cf5f33d5b02402ccd8e4b459444d3"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"22651348868bc707562e8c4dce039878599dfe70","unresolved":false,"context_lines":[{"line_number":171,"context_line":"Core reviewers may abandon patches that receive a -2 review or"},{"line_number":172,"context_line":"lack activity for at least four weeks to freshen the patch review queue."},{"line_number":173,"context_line":"The owner of a patch can also abandon it."},{"line_number":174,"context_line":"The owner and core reviewers can resurrect it again."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Patches by OpenStack Proposal Bot"},{"line_number":177,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":9,"id":"fad55976_10acacec","line":174,"in_reply_to":"1aa78d24_5362533e","updated":"2016-07-15 14:50:12.000000000","message":"Done","commit_id":"8baad05c364cf5f33d5b02402ccd8e4b459444d3"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"a52b025de12d7fe4104d56a839e966fbfb90e2da","unresolved":false,"context_lines":[{"line_number":157,"context_line":"To add the WIP tag:"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"#. Select a patch set."},{"line_number":160,"context_line":"#. Select :guilabel:`Reply...` button."},{"line_number":161,"context_line":"#. Choose :guilabel:`-1 (Work In Progress)` from the :guilabel:`Workflow`"},{"line_number":162,"context_line":"   options."},{"line_number":163,"context_line":"#. Optional. Enter comments."}],"source_content_type":"text/x-rst","patch_set":11,"id":"dada55a8_d3f3f79c","line":160,"range":{"start_line":160,"start_character":3,"end_line":160,"end_character":9},"updated":"2016-07-19 08:46:35.000000000","message":"This has to be Click, not Select, as we click a button and select a checkbox. And the same in line 164.","commit_id":"ed63991d3243acd87452ab12bd03b108734443c5"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"25413d9b64b2cfd21a6fbcdfabefd3ddce48913f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"To add the WIP tag:"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"#. Select a patch set."},{"line_number":160,"context_line":"#. Select :guilabel:`Reply...` button."},{"line_number":161,"context_line":"#. Choose :guilabel:`-1 (Work In Progress)` from the :guilabel:`Workflow`"},{"line_number":162,"context_line":"   options."},{"line_number":163,"context_line":"#. Optional. Enter comments."}],"source_content_type":"text/x-rst","patch_set":11,"id":"dada55a8_5e141e43","line":160,"range":{"start_line":160,"start_character":3,"end_line":160,"end_character":9},"in_reply_to":"dada55a8_089d4c59","updated":"2016-07-19 13:05:50.000000000","message":"Then we have to apply this change to all our docs to keep them consistent. I believe we should first discuss this on the mailing list.\n\nBy the way, the IBM terminology stands for click.\nPlease see: https://www-01.ibm.com/software/globalization/terminology/c.html","commit_id":"ed63991d3243acd87452ab12bd03b108734443c5"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"3127a624a12faad225c4240f6556ab17f9fab2cd","unresolved":false,"context_lines":[{"line_number":157,"context_line":"To add the WIP tag:"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"#. Select a patch set."},{"line_number":160,"context_line":"#. Select :guilabel:`Reply...` button."},{"line_number":161,"context_line":"#. Choose :guilabel:`-1 (Work In Progress)` from the :guilabel:`Workflow`"},{"line_number":162,"context_line":"   options."},{"line_number":163,"context_line":"#. Optional. Enter comments."}],"source_content_type":"text/x-rst","patch_set":11,"id":"dada55a8_089d4c59","line":160,"range":{"start_line":160,"start_character":3,"end_line":160,"end_character":9},"in_reply_to":"dada55a8_7f92caa0","updated":"2016-07-19 12:32:44.000000000","message":"Click is a colloquialism that refers to the sound a mouse makes, not a universal action independent of the pointing device.","commit_id":"ed63991d3243acd87452ab12bd03b108734443c5"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"85f970c99febfbec5708883e04da9932e48d36bc","unresolved":false,"context_lines":[{"line_number":157,"context_line":"To add the WIP tag:"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"#. Select a patch set."},{"line_number":160,"context_line":"#. Select :guilabel:`Reply...` button."},{"line_number":161,"context_line":"#. Choose :guilabel:`-1 (Work In Progress)` from the :guilabel:`Workflow`"},{"line_number":162,"context_line":"   options."},{"line_number":163,"context_line":"#. Optional. Enter comments."}],"source_content_type":"text/x-rst","patch_set":11,"id":"dada55a8_7f92caa0","line":160,"range":{"start_line":160,"start_character":3,"end_line":160,"end_character":9},"in_reply_to":"dada55a8_d3f3f79c","updated":"2016-07-19 09:36:48.000000000","message":"This is brought from the comment at patch set 9.","commit_id":"ed63991d3243acd87452ab12bd03b108734443c5"}],"doc/contributor-guide/source/docs-review.rst":[{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"d19b4a05734ab868f768324d327bf53aa4bc4d18","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#. Click a patch set."},{"line_number":54,"context_line":"#. Click a file that was uploaded to view the changes side by side."},{"line_number":55,"context_line":"#. If you see some inconsistencies or have questions to the patch owner,"},{"line_number":56,"context_line":"   double click the line in question for a ``Comment`` field to appear."},{"line_number":57,"context_line":"   Click ``Save`` button once you write a draft of your comment."},{"line_number":58,"context_line":"#. In the ``Jenkins check`` section, click the Jenkins ``checkbuild`` gate"},{"line_number":59,"context_line":"   link (for the openstack-manuals, it is called"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_6e7c58ec","line":56,"updated":"2016-07-07 10:10:48.000000000","message":"You can also highlight the line/word in question, and press \u0027c\u0027 - which will comment directly on that line/word \n^^ I think we should definitely include this too.","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"457f46c824fc3b6f1e473abb016fc08852fab7ad","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#. Click a patch set."},{"line_number":54,"context_line":"#. Click a file that was uploaded to view the changes side by side."},{"line_number":55,"context_line":"#. If you see some inconsistencies or have questions to the patch owner,"},{"line_number":56,"context_line":"   double click the line in question for a ``Comment`` field to appear."},{"line_number":57,"context_line":"   Click ``Save`` button once you write a draft of your comment."},{"line_number":58,"context_line":"#. In the ``Jenkins check`` section, click the Jenkins ``checkbuild`` gate"},{"line_number":59,"context_line":"   link (for the openstack-manuals, it is called"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_cab426d6","line":56,"in_reply_to":"1aa78d24_224b815a","updated":"2016-07-08 02:14:43.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#. Click a patch set."},{"line_number":54,"context_line":"#. Click a file that was uploaded to view the changes side by side."},{"line_number":55,"context_line":"#. If you see some inconsistencies or have questions to the patch owner,"},{"line_number":56,"context_line":"   double click the line in question for a ``Comment`` field to appear."},{"line_number":57,"context_line":"   Click ``Save`` button once you write a draft of your comment."},{"line_number":58,"context_line":"#. In the ``Jenkins check`` section, click the Jenkins ``checkbuild`` gate"},{"line_number":59,"context_line":"   link (for the openstack-manuals, it is called"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_224b815a","line":56,"in_reply_to":"1aa78d24_6e7c58ec","updated":"2016-07-07 11:30:02.000000000","message":"Double click doesn\u0027t work for me :(\nwe should definitely add the `c` option here.","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"#. Click a file that was uploaded to view the changes side by side."},{"line_number":55,"context_line":"#. If you see some inconsistencies or have questions to the patch owner,"},{"line_number":56,"context_line":"   double click the line in question for a ``Comment`` field to appear."},{"line_number":57,"context_line":"   Click ``Save`` button once you write a draft of your comment."},{"line_number":58,"context_line":"#. In the ``Jenkins check`` section, click the Jenkins ``checkbuild`` gate"},{"line_number":59,"context_line":"   link (for the openstack-manuals, it is called"},{"line_number":60,"context_line":"   ``gate-openstack-manuals-tox-doc-publish-checkbuild``) and review the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_c21efd0a","line":57,"range":{"start_line":57,"start_character":3,"end_line":57,"end_character":24},"updated":"2016-07-07 11:30:02.000000000","message":"Click :guilabel:`Save`","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"457f46c824fc3b6f1e473abb016fc08852fab7ad","unresolved":false,"context_lines":[{"line_number":54,"context_line":"#. Click a file that was uploaded to view the changes side by side."},{"line_number":55,"context_line":"#. If you see some inconsistencies or have questions to the patch owner,"},{"line_number":56,"context_line":"   double click the line in question for a ``Comment`` field to appear."},{"line_number":57,"context_line":"   Click ``Save`` button once you write a draft of your comment."},{"line_number":58,"context_line":"#. In the ``Jenkins check`` section, click the Jenkins ``checkbuild`` gate"},{"line_number":59,"context_line":"   link (for the openstack-manuals, it is called"},{"line_number":60,"context_line":"   ``gate-openstack-manuals-tox-doc-publish-checkbuild``) and review the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_8ac33e38","line":57,"range":{"start_line":57,"start_character":3,"end_line":57,"end_character":24},"in_reply_to":"1aa78d24_c21efd0a","updated":"2016-07-08 02:14:43.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"#. If you see some inconsistencies or have questions to the patch owner,"},{"line_number":56,"context_line":"   double click the line in question for a ``Comment`` field to appear."},{"line_number":57,"context_line":"   Click ``Save`` button once you write a draft of your comment."},{"line_number":58,"context_line":"#. In the ``Jenkins check`` section, click the Jenkins ``checkbuild`` gate"},{"line_number":59,"context_line":"   link (for the openstack-manuals, it is called"},{"line_number":60,"context_line":"   ``gate-openstack-manuals-tox-doc-publish-checkbuild``) and review the"},{"line_number":61,"context_line":"   built manuals to see how the change will look on the web page. For a new"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_9dc9f4ae","line":58,"range":{"start_line":58,"start_character":10,"end_line":58,"end_character":27},"updated":"2016-07-07 11:30:02.000000000","message":":guilabel:`Jenkins check`","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"457f46c824fc3b6f1e473abb016fc08852fab7ad","unresolved":false,"context_lines":[{"line_number":55,"context_line":"#. If you see some inconsistencies or have questions to the patch owner,"},{"line_number":56,"context_line":"   double click the line in question for a ``Comment`` field to appear."},{"line_number":57,"context_line":"   Click ``Save`` button once you write a draft of your comment."},{"line_number":58,"context_line":"#. In the ``Jenkins check`` section, click the Jenkins ``checkbuild`` gate"},{"line_number":59,"context_line":"   link (for the openstack-manuals, it is called"},{"line_number":60,"context_line":"   ``gate-openstack-manuals-tox-doc-publish-checkbuild``) and review the"},{"line_number":61,"context_line":"   built manuals to see how the change will look on the web page. For a new"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_aae0bacd","line":58,"range":{"start_line":58,"start_character":10,"end_line":58,"end_character":27},"in_reply_to":"1aa78d24_9dc9f4ae","updated":"2016-07-08 02:14:43.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"   built manuals to see how the change will look on the web page. For a new"},{"line_number":62,"context_line":"   patch, it takes some time before Jenkins checks appear on the Gerrit"},{"line_number":63,"context_line":"   page. You can also `build the patch locally`_ if necessary."},{"line_number":64,"context_line":"#. Click ``Reply`` to vote and enter any comments about your review,"},{"line_number":65,"context_line":"   then click ``Post``."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_22f1c1cd","line":64,"range":{"start_line":64,"start_character":9,"end_line":64,"end_character":18},"updated":"2016-07-07 11:30:02.000000000","message":":guilabel:`Reply...`","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"457f46c824fc3b6f1e473abb016fc08852fab7ad","unresolved":false,"context_lines":[{"line_number":61,"context_line":"   built manuals to see how the change will look on the web page. For a new"},{"line_number":62,"context_line":"   patch, it takes some time before Jenkins checks appear on the Gerrit"},{"line_number":63,"context_line":"   page. You can also `build the patch locally`_ if necessary."},{"line_number":64,"context_line":"#. Click ``Reply`` to vote and enter any comments about your review,"},{"line_number":65,"context_line":"   then click ``Post``."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_4ad036f8","line":64,"range":{"start_line":64,"start_character":9,"end_line":64,"end_character":18},"in_reply_to":"1aa78d24_22f1c1cd","updated":"2016-07-08 02:14:43.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"   patch, it takes some time before Jenkins checks appear on the Gerrit"},{"line_number":63,"context_line":"   page. You can also `build the patch locally`_ if necessary."},{"line_number":64,"context_line":"#. Click ``Reply`` to vote and enter any comments about your review,"},{"line_number":65,"context_line":"   then click ``Post``."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. note::"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_a2aad182","line":65,"range":{"start_line":65,"start_character":14,"end_line":65,"end_character":22},"updated":"2016-07-07 11:30:02.000000000","message":"`guilabel:`Post`","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"457f46c824fc3b6f1e473abb016fc08852fab7ad","unresolved":false,"context_lines":[{"line_number":62,"context_line":"   patch, it takes some time before Jenkins checks appear on the Gerrit"},{"line_number":63,"context_line":"   page. You can also `build the patch locally`_ if necessary."},{"line_number":64,"context_line":"#. Click ``Reply`` to vote and enter any comments about your review,"},{"line_number":65,"context_line":"   then click ``Post``."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. note::"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_eaeac2ab","line":65,"range":{"start_line":65,"start_character":14,"end_line":65,"end_character":22},"in_reply_to":"1aa78d24_a2aad182","updated":"2016-07-08 02:14:43.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"To build a patch locally:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"#. In terminal, switch to a necessary directory. For example:"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"   .. code-block:: console"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_a27bf179","line":90,"range":{"start_line":90,"start_character":6,"end_line":90,"end_character":14},"updated":"2016-07-07 11:30:02.000000000","message":"the terminal","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"457f46c824fc3b6f1e473abb016fc08852fab7ad","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"To build a patch locally:"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"#. In terminal, switch to a necessary directory. For example:"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"   .. code-block:: console"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_2acdea5d","line":90,"range":{"start_line":90,"start_character":6,"end_line":90,"end_character":14},"in_reply_to":"1aa78d24_a27bf179","updated":"2016-07-08 02:14:43.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"      $ cd openstack-manuals"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"#. Run the below command to create a local branch with the patch in question:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"   .. code-block:: console"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_02a80576","line":96,"range":{"start_line":96,"start_character":7,"end_line":96,"end_character":24},"updated":"2016-07-07 11:30:02.000000000","message":"the command below","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"457f46c824fc3b6f1e473abb016fc08852fab7ad","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"      $ cd openstack-manuals"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"#. Run the below command to create a local branch with the patch in question:"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"   .. code-block:: console"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_6ad7f2ed","line":96,"range":{"start_line":96,"start_character":7,"end_line":96,"end_character":24},"in_reply_to":"1aa78d24_02a80576","updated":"2016-07-08 02:14:43.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"d19b4a05734ab868f768324d327bf53aa4bc4d18","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"      $ git review -d \u003cnnnnnn\u003e"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"   where the value of \u003cnnnnnn\u003e is a Gerrit commit number. For example, 226632"},{"line_number":103,"context_line":"   is the commit number of the patch https://review.openstack.org/#/c/226632."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"#. Build all the books that are affected by changes in the patch set:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_4e66bc51","line":102,"range":{"start_line":102,"start_character":3,"end_line":102,"end_character":8},"updated":"2016-07-07 10:10:48.000000000","message":"Where*","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"457f46c824fc3b6f1e473abb016fc08852fab7ad","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"      $ git review -d \u003cnnnnnn\u003e"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"   where the value of \u003cnnnnnn\u003e is a Gerrit commit number. For example, 226632"},{"line_number":103,"context_line":"   is the commit number of the patch https://review.openstack.org/#/c/226632."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"#. Build all the books that are affected by changes in the patch set:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_ca026672","line":102,"range":{"start_line":102,"start_character":3,"end_line":102,"end_character":8},"in_reply_to":"1aa78d24_4e66bc51","updated":"2016-07-08 02:14:43.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"d19b4a05734ab868f768324d327bf53aa4bc4d18","unresolved":false,"context_lines":[{"line_number":100,"context_line":"      $ git review -d \u003cnnnnnn\u003e"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"   where the value of \u003cnnnnnn\u003e is a Gerrit commit number. For example, 226632"},{"line_number":103,"context_line":"   is the commit number of the patch https://review.openstack.org/#/c/226632."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"#. Build all the books that are affected by changes in the patch set:"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_0ef79459","line":103,"range":{"start_line":103,"start_character":37,"end_line":103,"end_character":76},"updated":"2016-07-07 10:10:48.000000000","message":"I\u0027m not entirely sure we should reference someone\u0027s old patch, even though it has passed. Perhaps have something like:\n\n\"Where the value of \u003cNUMBER\u003e is a Gerrit commit number. You can find this number on the patch link, `https://review.openstack.org/#/c/\u003cNUMBER\u003e`","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"      $ git review -d \u003cnnnnnn\u003e"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"   where the value of \u003cnnnnnn\u003e is a Gerrit commit number. For example, 226632"},{"line_number":103,"context_line":"   is the commit number of the patch https://review.openstack.org/#/c/226632."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"#. Build all the books that are affected by changes in the patch set:"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_42bccdba","line":103,"range":{"start_line":103,"start_character":37,"end_line":103,"end_character":76},"in_reply_to":"1aa78d24_0ef79459","updated":"2016-07-07 11:30:02.000000000","message":"+1","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"457f46c824fc3b6f1e473abb016fc08852fab7ad","unresolved":false,"context_lines":[{"line_number":100,"context_line":"      $ git review -d \u003cnnnnnn\u003e"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"   where the value of \u003cnnnnnn\u003e is a Gerrit commit number. For example, 226632"},{"line_number":103,"context_line":"   is the commit number of the patch https://review.openstack.org/#/c/226632."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"#. Build all the books that are affected by changes in the patch set:"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_ea01226c","line":103,"range":{"start_line":103,"start_character":37,"end_line":103,"end_character":76},"in_reply_to":"1aa78d24_42bccdba","updated":"2016-07-08 02:14:43.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"      $ sudo tox -e checkbuild"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"#. Find the build result in :file:`openstack-manuals/publish-docs/index.html`."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"#. Review the source and the output. You are also welcomed to edit and update"},{"line_number":114,"context_line":"   the patch:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_02bf65aa","line":111,"range":{"start_line":111,"start_character":28,"end_line":111,"end_character":77},"updated":"2016-07-07 11:30:02.000000000","message":"``openstack-manuals/publish-docs/index.html``","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"d19b4a05734ab868f768324d327bf53aa4bc4d18","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"#. Find the build result in :file:`openstack-manuals/publish-docs/index.html`."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"#. Review the source and the output. You are also welcomed to edit and update"},{"line_number":114,"context_line":"   the patch:"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"   #. Ensure that your edits adhere to the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_aeb5a07e","line":113,"range":{"start_line":113,"start_character":37,"end_line":113,"end_character":58},"updated":"2016-07-07 10:10:48.000000000","message":"I would say you \u0027can\u0027 rather than are welcomed?","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"457f46c824fc3b6f1e473abb016fc08852fab7ad","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"#. Find the build result in :file:`openstack-manuals/publish-docs/index.html`."},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"#. Review the source and the output. You are also welcomed to edit and update"},{"line_number":114,"context_line":"   the patch:"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"   #. Ensure that your edits adhere to the"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_6aeed2b5","line":113,"range":{"start_line":113,"start_character":37,"end_line":113,"end_character":58},"in_reply_to":"1aa78d24_aeb5a07e","updated":"2016-07-08 02:14:43.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":14947,"name":"Maria Zlatkova","email":"mzlatkova@mirantis.com","username":"mzlatkova"},"change_message_id":"368518c82c74c7062d1d4da23341462c266d2f1d","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"   #. Ensure that your edits adhere to the"},{"line_number":117,"context_line":"      :ref:`Writing Style \u003cstg_writing_style\u003e` for OpenStack documentation"},{"line_number":118,"context_line":"      and uses standard US English."},{"line_number":119,"context_line":"   #. Once the build and new output are good to commit, run:"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"      .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_622e29fc","line":118,"range":{"start_line":118,"start_character":13,"end_line":118,"end_character":14},"updated":"2016-07-07 11:30:02.000000000","message":"use","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"457f46c824fc3b6f1e473abb016fc08852fab7ad","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"   #. Ensure that your edits adhere to the"},{"line_number":117,"context_line":"      :ref:`Writing Style \u003cstg_writing_style\u003e` for OpenStack documentation"},{"line_number":118,"context_line":"      and uses standard US English."},{"line_number":119,"context_line":"   #. Once the build and new output are good to commit, run:"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"      .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_aa2efaf7","line":118,"range":{"start_line":118,"start_character":13,"end_line":118,"end_character":14},"in_reply_to":"1aa78d24_622e29fc","updated":"2016-07-08 02:14:43.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"d19b4a05734ab868f768324d327bf53aa4bc4d18","unresolved":false,"context_lines":[{"line_number":125,"context_line":"   #. When the editor opens, update the commit message if necessary. But do"},{"line_number":126,"context_line":"      not add information on what your specific patch set changes. A reviewer"},{"line_number":127,"context_line":"      can use the Gerrit interface to see the difference between patches."},{"line_number":128,"context_line":"   #. Save the changes if any and exit the editor. If your editor is vi,"},{"line_number":129,"context_line":"      use the :command:`:wq` command to save the file and exit vi."},{"line_number":130,"context_line":"   #. Send your patch to the existing review:"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_0ea5d445","line":128,"range":{"start_line":128,"start_character":69,"end_line":128,"end_character":71},"updated":"2016-07-07 10:10:48.000000000","message":"`vi`","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"d19b4a05734ab868f768324d327bf53aa4bc4d18","unresolved":false,"context_lines":[{"line_number":125,"context_line":"   #. When the editor opens, update the commit message if necessary. But do"},{"line_number":126,"context_line":"      not add information on what your specific patch set changes. A reviewer"},{"line_number":127,"context_line":"      can use the Gerrit interface to see the difference between patches."},{"line_number":128,"context_line":"   #. Save the changes if any and exit the editor. If your editor is vi,"},{"line_number":129,"context_line":"      use the :command:`:wq` command to save the file and exit vi."},{"line_number":130,"context_line":"   #. Send your patch to the existing review:"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_2eaa5019","line":128,"range":{"start_line":128,"start_character":26,"end_line":128,"end_character":29},"updated":"2016-07-07 10:10:48.000000000","message":"any, *","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"457f46c824fc3b6f1e473abb016fc08852fab7ad","unresolved":false,"context_lines":[{"line_number":125,"context_line":"   #. When the editor opens, update the commit message if necessary. But do"},{"line_number":126,"context_line":"      not add information on what your specific patch set changes. A reviewer"},{"line_number":127,"context_line":"      can use the Gerrit interface to see the difference between patches."},{"line_number":128,"context_line":"   #. Save the changes if any and exit the editor. If your editor is vi,"},{"line_number":129,"context_line":"      use the :command:`:wq` command to save the file and exit vi."},{"line_number":130,"context_line":"   #. Send your patch to the existing review:"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"1aa78d24_6a4532b2","line":128,"range":{"start_line":128,"start_character":26,"end_line":128,"end_character":29},"in_reply_to":"1aa78d24_2eaa5019","updated":"2016-07-08 02:14:43.000000000","message":"Done","commit_id":"2f20cdc5c0a5ca3046b09306cd273b36ecfec6ac"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"04f6859a1497667bb47c3089eab7484943a6ec1c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#. Click a patch set."},{"line_number":54,"context_line":"#. Click a file that was uploaded to view the changes side by side."},{"line_number":55,"context_line":"#. If you see some inconsistencies or have questions to the patch owner,"},{"line_number":56,"context_line":"   you can also highlight the line or word in question, and press the \u0027c\u0027"},{"line_number":57,"context_line":"   key, which will comment directly on that line or word."},{"line_number":58,"context_line":"   Click :guilabel:`Save` button once you write a draft of your comment."},{"line_number":59,"context_line":"#. In the :guilabel:`Jenkins check` section, click the Jenkins ``checkbuild``"},{"line_number":60,"context_line":"   gate link (for the openstack-manuals, it is called"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_7cd96e83","line":57,"range":{"start_line":56,"start_character":60,"end_line":57,"end_character":6},"updated":"2016-07-08 10:10:27.000000000","message":"press \u0027c\u0027 on your keyboard* (to make it as clear as possible)","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"e567f096778e5a89f44b8b1c820bd60b1d4c59c3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"#. Click a patch set."},{"line_number":54,"context_line":"#. Click a file that was uploaded to view the changes side by side."},{"line_number":55,"context_line":"#. If you see some inconsistencies or have questions to the patch owner,"},{"line_number":56,"context_line":"   you can also highlight the line or word in question, and press the \u0027c\u0027"},{"line_number":57,"context_line":"   key, which will comment directly on that line or word."},{"line_number":58,"context_line":"   Click :guilabel:`Save` button once you write a draft of your comment."},{"line_number":59,"context_line":"#. In the :guilabel:`Jenkins check` section, click the Jenkins ``checkbuild``"},{"line_number":60,"context_line":"   gate link (for the openstack-manuals, it is called"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_9fc36c8a","line":57,"range":{"start_line":56,"start_character":60,"end_line":57,"end_character":6},"in_reply_to":"1aa78d24_7cd96e83","updated":"2016-07-08 10:34:51.000000000","message":"Done","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"04f6859a1497667bb47c3089eab7484943a6ec1c","unresolved":false,"context_lines":[{"line_number":68,"context_line":".. note::"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"   A patch with WorkInProgress (WIP) status needs additional work"},{"line_number":71,"context_line":"   before it gets merged. Therefore, you may skip such a patch and"},{"line_number":72,"context_line":"   review once it is ready. For more information, see `Work In Progress"},{"line_number":73,"context_line":"   \u003chttp://docs.openstack.org/infra/manual/core.html#work-in-progress\u003e`_."},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_5c5752ca","line":71,"range":{"start_line":71,"start_character":13,"end_line":71,"end_character":24},"updated":"2016-07-08 10:10:27.000000000","message":"it is merged.*","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"e567f096778e5a89f44b8b1c820bd60b1d4c59c3","unresolved":false,"context_lines":[{"line_number":68,"context_line":".. note::"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"   A patch with WorkInProgress (WIP) status needs additional work"},{"line_number":71,"context_line":"   before it gets merged. Therefore, you may skip such a patch and"},{"line_number":72,"context_line":"   review once it is ready. For more information, see `Work In Progress"},{"line_number":73,"context_line":"   \u003chttp://docs.openstack.org/infra/manual/core.html#work-in-progress\u003e`_."},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_ff3a7097","line":71,"range":{"start_line":71,"start_character":13,"end_line":71,"end_character":24},"in_reply_to":"1aa78d24_5c5752ca","updated":"2016-07-08 10:34:51.000000000","message":"Done","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"04f6859a1497667bb47c3089eab7484943a6ec1c","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"   .. code-block:: console"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"      $ git review -d \u003cnnnnnn\u003e"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"   Where the value of \u003cnnnnnn\u003e is a Gerrit commit number."},{"line_number":104,"context_line":"   You can find this number on the patch link,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_dc0222b4","line":101,"range":{"start_line":101,"start_character":22,"end_line":101,"end_character":30},"updated":"2016-07-08 10:10:27.000000000","message":"Change this to \u003cNUMBER\u003e too to be consistent with the example","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"e567f096778e5a89f44b8b1c820bd60b1d4c59c3","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"   .. code-block:: console"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"      $ git review -d \u003cnnnnnn\u003e"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"   Where the value of \u003cnnnnnn\u003e is a Gerrit commit number."},{"line_number":104,"context_line":"   You can find this number on the patch link,"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_3f5cf8ec","line":101,"range":{"start_line":101,"start_character":22,"end_line":101,"end_character":30},"in_reply_to":"1aa78d24_dc0222b4","updated":"2016-07-08 10:34:51.000000000","message":"Done","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"04f6859a1497667bb47c3089eab7484943a6ec1c","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"      $ git review -d \u003cnnnnnn\u003e"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"   Where the value of \u003cnnnnnn\u003e is a Gerrit commit number."},{"line_number":104,"context_line":"   You can find this number on the patch link,"},{"line_number":105,"context_line":"   ``https://review.openstack.org/#/c/\u003cNUMBER\u003e``."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_1c2b0a35","line":103,"range":{"start_line":103,"start_character":22,"end_line":103,"end_character":30},"updated":"2016-07-08 10:10:27.000000000","message":"ditto","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"e567f096778e5a89f44b8b1c820bd60b1d4c59c3","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"      $ git review -d \u003cnnnnnn\u003e"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"   Where the value of \u003cnnnnnn\u003e is a Gerrit commit number."},{"line_number":104,"context_line":"   You can find this number on the patch link,"},{"line_number":105,"context_line":"   ``https://review.openstack.org/#/c/\u003cNUMBER\u003e``."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1aa78d24_7f6e8097","line":103,"range":{"start_line":103,"start_character":22,"end_line":103,"end_character":30},"in_reply_to":"1aa78d24_1c2b0a35","updated":"2016-07-08 10:34:51.000000000","message":"Done","commit_id":"2df9e20f33a76e7b820166b9a3bf6707d29ff76b"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"d9055d1fb4bd2b6d4dfa95c170caec32df04c6e2","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":".. _`build the patch locally`:"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"How to build an existing patch locally"},{"line_number":83,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Before proceeding, make sure you have all the necessary"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1aa78d24_8caa1a84","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":38},"updated":"2016-07-08 15:39:08.000000000","message":"I discovered that we already have such a section http://docs.openstack.org/contributor-guide/build-locally.html. So I would rather restructure the existing section and keep it separately from \u0027Reviewing documentation\u0027, as building locally is necessary for uploading a new patch at first stage. But we should for sure leave a reference for this section in \u0027Review docs\u0027 section.","commit_id":"9edad57d9ca89ad1228a18a0701bac1b4ac8e588"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"7b8aca517c87ef41d9a36a1e6ed10475baf48f83","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":".. _`build the patch locally`:"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"How to build an existing patch locally"},{"line_number":83,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Before proceeding, make sure you have all the necessary"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1aa78d24_a11d3368","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":38},"in_reply_to":"1aa78d24_8caa1a84","updated":"2016-07-10 23:58:11.000000000","message":"I will reorganize how to build section at the following patch. I\u0027d like to aviod to become a patch big.","commit_id":"9edad57d9ca89ad1228a18a0701bac1b4ac8e588"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"f44731846831f2d1a4037b2873e2b4dcfb8290bb","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":".. _`build the patch locally`:"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"How to build an existing patch locally"},{"line_number":83,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"Before proceeding, make sure you have all the necessary"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1aa78d24_edf3a59d","line":82,"range":{"start_line":82,"start_character":0,"end_line":82,"end_character":38},"in_reply_to":"1aa78d24_a11d3368","updated":"2016-07-11 08:42:24.000000000","message":"Thanks for clarification. Sounds good then!","commit_id":"9edad57d9ca89ad1228a18a0701bac1b4ac8e588"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"d9055d1fb4bd2b6d4dfa95c170caec32df04c6e2","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"   #. Leave a comment in Gerrit explaining the reason for your patch set."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":".. TODO: make a seealso and add a links to the below pages once converted to"},{"line_number":140,"context_line":"   .RST:"},{"line_number":141,"context_line":"    - https://wiki.openstack.org/wiki/Documentation/HowTo#Building_Output_Locally"},{"line_number":142,"context_line":"    - https://wiki.openstack.org/wiki/Documentation/HowTo#Using_Tox_to_check_builds"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Achieving a core reviewer status"},{"line_number":145,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1aa78d24_27a501b5","line":142,"range":{"start_line":139,"start_character":0,"end_line":142,"end_character":83},"updated":"2016-07-08 15:39:08.000000000","message":"This can be removed, and corresponding refs should be added.","commit_id":"9edad57d9ca89ad1228a18a0701bac1b4ac8e588"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"7b8aca517c87ef41d9a36a1e6ed10475baf48f83","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"   #. Leave a comment in Gerrit explaining the reason for your patch set."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":".. TODO: make a seealso and add a links to the below pages once converted to"},{"line_number":140,"context_line":"   .RST:"},{"line_number":141,"context_line":"    - https://wiki.openstack.org/wiki/Documentation/HowTo#Building_Output_Locally"},{"line_number":142,"context_line":"    - https://wiki.openstack.org/wiki/Documentation/HowTo#Using_Tox_to_check_builds"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"Achieving a core reviewer status"},{"line_number":145,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":7,"id":"1aa78d24_de177a52","line":142,"range":{"start_line":139,"start_character":0,"end_line":142,"end_character":83},"in_reply_to":"1aa78d24_27a501b5","updated":"2016-07-10 23:58:11.000000000","message":"Done","commit_id":"9edad57d9ca89ad1228a18a0701bac1b4ac8e588"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":10,"context_line":"   docs-review-guidelines.rst"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"OpenStack documentation is treated like code."},{"line_number":13,"context_line":"We follow the standard code review porcess."},{"line_number":14,"context_line":"To see what documentation changes are ready for review, use the"},{"line_number":15,"context_line":"`Documentation Program Dashboard \u003chttp://is.gd/openstackdocsreview\u003e`_."},{"line_number":16,"context_line":"It is organized in groupings based on the audience for the documentation."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_998ef677","line":13,"updated":"2016-07-13 22:49:16.000000000","message":"process","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":10,"context_line":"   docs-review-guidelines.rst"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"OpenStack documentation is treated like code."},{"line_number":13,"context_line":"We follow the standard code review porcess."},{"line_number":14,"context_line":"To see what documentation changes are ready for review, use the"},{"line_number":15,"context_line":"`Documentation Program Dashboard \u003chttp://is.gd/openstackdocsreview\u003e`_."},{"line_number":16,"context_line":"It is organized in groupings based on the audience for the documentation."}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_ec76550b","line":13,"in_reply_to":"1aa78d24_998ef677","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":39,"context_line":"The current list of docs cores for openstack-manuals can be found at"},{"line_number":40,"context_line":"https://review.openstack.org/#/admin/groups/30,members."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"How to review a documentation patch"},{"line_number":43,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Before you proceed with reviewing patches, make sure to read carefully"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_1e0dcce8","line":42,"updated":"2016-07-13 22:49:16.000000000","message":"I\u0027m not a huge fan of beginning topics with \"How to\" ... perhaps use \"Reviewing a documentation patch\" instead? Same with the next topic.","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":39,"context_line":"The current list of docs cores for openstack-manuals can be found at"},{"line_number":40,"context_line":"https://review.openstack.org/#/admin/groups/30,members."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"How to review a documentation patch"},{"line_number":43,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"Before you proceed with reviewing patches, make sure to read carefully"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_6c6b8520","line":42,"in_reply_to":"1aa78d24_1e0dcce8","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"#. Go to the `Documentation Program Dashboard"},{"line_number":52,"context_line":"   \u003chttp://is.gd/openstackdocsreview\u003e`_."},{"line_number":53,"context_line":"#. Click a patch set."},{"line_number":54,"context_line":"#. Click a file that was uploaded to view the changes side by side."},{"line_number":55,"context_line":"#. If you see some inconsistencies or have questions to the patch owner,"},{"line_number":56,"context_line":"   you can also highlight the line or word in question, and press \u0027c\u0027"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_9ec25c33","line":53,"updated":"2016-07-13 22:49:16.000000000","message":"I prefer \"select\" over \"click\" because it refers to an action instead of a sound.","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"#. Go to the `Documentation Program Dashboard"},{"line_number":52,"context_line":"   \u003chttp://is.gd/openstackdocsreview\u003e`_."},{"line_number":53,"context_line":"#. Click a patch set."},{"line_number":54,"context_line":"#. Click a file that was uploaded to view the changes side by side."},{"line_number":55,"context_line":"#. If you see some inconsistencies or have questions to the patch owner,"},{"line_number":56,"context_line":"   you can also highlight the line or word in question, and press \u0027c\u0027"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_2c585d8a","line":53,"in_reply_to":"1aa78d24_9ec25c33","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":54,"context_line":"#. Click a file that was uploaded to view the changes side by side."},{"line_number":55,"context_line":"#. If you see some inconsistencies or have questions to the patch owner,"},{"line_number":56,"context_line":"   you can also highlight the line or word in question, and press \u0027c\u0027"},{"line_number":57,"context_line":"   on your keyboard, which will comment directly on that line or word."},{"line_number":58,"context_line":"   Click :guilabel:`Save` button once you write a draft of your comment."},{"line_number":59,"context_line":"#. In the :guilabel:`Jenkins check` section, click the Jenkins ``checkbuild``"},{"line_number":60,"context_line":"   gate link (for the openstack-manuals, it is called"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_1ee5ccdb","line":57,"updated":"2016-07-13 22:49:16.000000000","message":"Avoid future tense.\n\n... which enables commenting directly...","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":54,"context_line":"#. Click a file that was uploaded to view the changes side by side."},{"line_number":55,"context_line":"#. If you see some inconsistencies or have questions to the patch owner,"},{"line_number":56,"context_line":"   you can also highlight the line or word in question, and press \u0027c\u0027"},{"line_number":57,"context_line":"   on your keyboard, which will comment directly on that line or word."},{"line_number":58,"context_line":"   Click :guilabel:`Save` button once you write a draft of your comment."},{"line_number":59,"context_line":"#. In the :guilabel:`Jenkins check` section, click the Jenkins ``checkbuild``"},{"line_number":60,"context_line":"   gate link (for the openstack-manuals, it is called"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_6c52656a","line":57,"in_reply_to":"1aa78d24_1ee5ccdb","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":68,"context_line":".. note::"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"   A patch with WorkInProgress (WIP) status needs additional work"},{"line_number":71,"context_line":"   before it is merged. Therefore, you may skip such a patch and"},{"line_number":72,"context_line":"   review once it is ready. For more information, see `Work In Progress"},{"line_number":73,"context_line":"   \u003chttp://docs.openstack.org/infra/manual/core.html#work-in-progress\u003e`_."},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_7eedf0b6","line":71,"updated":"2016-07-13 22:49:16.000000000","message":"... before review and possible approval.","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":68,"context_line":".. note::"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"   A patch with WorkInProgress (WIP) status needs additional work"},{"line_number":71,"context_line":"   before it is merged. Therefore, you may skip such a patch and"},{"line_number":72,"context_line":"   review once it is ready. For more information, see `Work In Progress"},{"line_number":73,"context_line":"   \u003chttp://docs.openstack.org/infra/manual/core.html#work-in-progress\u003e`_."},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_ccc9d927","line":71,"in_reply_to":"1aa78d24_7eedf0b6","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"To build a patch locally:"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"#. In the terminal, switch to a necessary directory. For example:"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"   .. code-block:: console"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_1e0aec79","line":91,"updated":"2016-07-13 22:49:16.000000000","message":"Change to the directory containing the appropriate repository.","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"To build a patch locally:"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"#. In the terminal, switch to a necessary directory. For example:"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"   .. code-block:: console"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_8ce07198","line":91,"in_reply_to":"1aa78d24_1e0aec79","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"      $ cd openstack-manuals"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"#. Run the command below to create a local branch with the patch in question:"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"   .. code-block:: console"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_9e753cfc","line":97,"updated":"2016-07-13 22:49:16.000000000","message":"Create a local branch that contains the particular patch.","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"      $ cd openstack-manuals"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"#. Run the command below to create a local branch with the patch in question:"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"   .. code-block:: console"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_ccf0b969","line":97,"in_reply_to":"1aa78d24_9e753cfc","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"   .. code-block:: console"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"      $ git review -d NUMBER"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"   Where the value of NUMBER is a Gerrit commit number."},{"line_number":104,"context_line":"   You can find this number on the patch link,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_dec4e40f","line":101,"updated":"2016-07-13 22:49:16.000000000","message":"PATCH_ID","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"   .. code-block:: console"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"      $ git review -d NUMBER"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"   Where the value of NUMBER is a Gerrit commit number."},{"line_number":104,"context_line":"   You can find this number on the patch link,"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_acfa8d41","line":101,"in_reply_to":"1aa78d24_dec4e40f","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"      $ git review -d NUMBER"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"   Where the value of NUMBER is a Gerrit commit number."},{"line_number":104,"context_line":"   You can find this number on the patch link,"},{"line_number":105,"context_line":"   ``https://review.openstack.org/#/c/NUMBER``."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_5e52b469","line":103,"updated":"2016-07-13 22:49:16.000000000","message":"Replace PATCH_ID with...","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"      $ git review -d NUMBER"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"   Where the value of NUMBER is a Gerrit commit number."},{"line_number":104,"context_line":"   You can find this number on the patch link,"},{"line_number":105,"context_line":"   ``https://review.openstack.org/#/c/NUMBER``."},{"line_number":106,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_8cf7d158","line":103,"in_reply_to":"1aa78d24_5e52b469","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"   .. code-block:: console"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"      $ sudo tox -e checkbuild"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"#. Find the build result in ``openstack-manuals/publish-docs/index.html``."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_3ed8887f","line":111,"updated":"2016-07-13 22:49:16.000000000","message":"Running tox should not require sudo.","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"   .. code-block:: console"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"      $ sudo tox -e checkbuild"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"#. Find the build result in ``openstack-manuals/publish-docs/index.html``."},{"line_number":114,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_2c9dfd0a","line":111,"in_reply_to":"1aa78d24_3ed8887f","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"      $ sudo tox -e checkbuild"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"#. Find the build result in ``openstack-manuals/publish-docs/index.html``."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"#. Review the source and the output. You can edit and update the patch:"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_79186a76","line":113,"updated":"2016-07-13 22:49:16.000000000","message":"Do we assume the audience is always using the openstack-manuals repository?","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"      $ sudo tox -e checkbuild"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"#. Find the build result in ``openstack-manuals/publish-docs/index.html``."},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"#. Review the source and the output. You can edit and update the patch:"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_4c84c9b0","line":113,"in_reply_to":"1aa78d24_79186a76","updated":"2016-07-14 02:42:07.000000000","message":"No. The audience is already in the appropriate repository.","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":127,"context_line":"      not add information on what your specific patch set changes. A reviewer"},{"line_number":128,"context_line":"      can use the Gerrit interface to see the difference between patches."},{"line_number":129,"context_line":"   #. Save the changes if any, and exit the editor. If your editor is ``vi``,"},{"line_number":130,"context_line":"      use the :command:`:wq` command to save the file and exit ``vi``."},{"line_number":131,"context_line":"   #. Send your patch to the existing review:"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"      .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_5ec2b487","line":130,"updated":"2016-07-13 22:49:16.000000000","message":"I think we should expect people to know how to use their particular editor.","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":127,"context_line":"      not add information on what your specific patch set changes. A reviewer"},{"line_number":128,"context_line":"      can use the Gerrit interface to see the difference between patches."},{"line_number":129,"context_line":"   #. Save the changes if any, and exit the editor. If your editor is ``vi``,"},{"line_number":130,"context_line":"      use the :command:`:wq` command to save the file and exit ``vi``."},{"line_number":131,"context_line":"   #. Send your patch to the existing review:"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"      .. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_0cb9217a","line":130,"in_reply_to":"1aa78d24_5ec2b487","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"         $ git review"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"   #. Leave a comment in Gerrit explaining the reason for your patch set."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Achieving a core reviewer status"},{"line_number":140,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_f959fa36","line":137,"updated":"2016-07-13 22:49:16.000000000","message":"... reason for the additional changes.","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"         $ git review"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"   #. Leave a comment in Gerrit explaining the reason for your patch set."},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"Achieving a core reviewer status"},{"line_number":140,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_aca8cd21","line":137,"in_reply_to":"1aa78d24_f959fa36","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Core reviewers are able to +2 and merge content into the projects they have"},{"line_number":143,"context_line":"the core status in. Core status is granted to **those who have not only done"},{"line_number":144,"context_line":"a lot of reviews, but who also have shown care and wisdom in those reviews**."},{"line_number":145,"context_line":"Becoming a core reviewer also carries with it a responsibility: you are now"},{"line_number":146,"context_line":"the **guardian of the gate**, and it is up to the core team to ensure that"},{"line_number":147,"context_line":"nothing untoward gets through, without discouraging contributions. The core"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_396382df","line":144,"updated":"2016-07-13 22:49:16.000000000","message":"... a sufficient quantity of","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"Core reviewers are able to +2 and merge content into the projects they have"},{"line_number":143,"context_line":"the core status in. Core status is granted to **those who have not only done"},{"line_number":144,"context_line":"a lot of reviews, but who also have shown care and wisdom in those reviews**."},{"line_number":145,"context_line":"Becoming a core reviewer also carries with it a responsibility: you are now"},{"line_number":146,"context_line":"the **guardian of the gate**, and it is up to the core team to ensure that"},{"line_number":147,"context_line":"nothing untoward gets through, without discouraging contributions. The core"}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_0c476178","line":144,"in_reply_to":"1aa78d24_396382df","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"f066e8e20917945524a73e2544b21ea208ca7f71","unresolved":false,"context_lines":[{"line_number":144,"context_line":"a lot of reviews, but who also have shown care and wisdom in those reviews**."},{"line_number":145,"context_line":"Becoming a core reviewer also carries with it a responsibility: you are now"},{"line_number":146,"context_line":"the **guardian of the gate**, and it is up to the core team to ensure that"},{"line_number":147,"context_line":"nothing untoward gets through, without discouraging contributions. The core"},{"line_number":148,"context_line":"reviewer\u0027s role is complex, and having a great core team is crucial to the"},{"line_number":149,"context_line":"success of any OpenStack project."},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_d97fde67","line":147,"updated":"2016-07-13 22:49:16.000000000","message":"Untoward is an unusual word.","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"9c7807d94d061750eba58683afe2646023575f77","unresolved":false,"context_lines":[{"line_number":144,"context_line":"a lot of reviews, but who also have shown care and wisdom in those reviews**."},{"line_number":145,"context_line":"Becoming a core reviewer also carries with it a responsibility: you are now"},{"line_number":146,"context_line":"the **guardian of the gate**, and it is up to the core team to ensure that"},{"line_number":147,"context_line":"nothing untoward gets through, without discouraging contributions. The core"},{"line_number":148,"context_line":"reviewer\u0027s role is complex, and having a great core team is crucial to the"},{"line_number":149,"context_line":"success of any OpenStack project."},{"line_number":150,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"1aa78d24_6c2385bf","line":147,"in_reply_to":"1aa78d24_d97fde67","updated":"2016-07-14 02:42:07.000000000","message":"Done","commit_id":"3e511eab33cadedcfa443f4322c6afe5b9b9fd0f"}]}