)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"8b420c705547485bdb11051d76df3fc3240a804b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Document QoS support for egress minimum bandwidth"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I606cc9b8ba2a8bbb0e23de5fd49d19cbb9d093db"},{"line_number":10,"context_line":"Resolves-Bug: #1618769"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa31d9ce_f9fbd544","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":12},"updated":"2017-02-15 11:56:07.000000000","message":"\"Resvolves-Bug:\" -\u003e \"Closes-Bug:\"\n\nThis will also close bug 1618762.","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"}],"doc/networking-guide/source/config-qos.rst":[{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"653518f99928499317e945566fd544c5a8b44440","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":".. note::"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"   Bandwidth limit is supported on OVS, Linux Bridge, and SR-IOV mechanism"},{"line_number":41,"context_line":"   drivers. For the Newton release onward DSCP marking will be supported on the"},{"line_number":42,"context_line":"   OVS mechanism driver, and the minimum bandwidth rules on the SR-IOV NIC"},{"line_number":43,"context_line":"   mechanism driver."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_731547e3","line":40,"range":{"start_line":40,"start_character":46,"end_line":40,"end_character":52},"updated":"2017-02-15 09:40:02.000000000","message":"bridge (lower case)","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"341ddffaa864d50a4818adf9d1c161c0dea7b671","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":".. note::"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"   Bandwidth limit is supported on OVS, Linux Bridge, and SR-IOV mechanism"},{"line_number":41,"context_line":"   drivers. For the Newton release onward DSCP marking will be supported on the"},{"line_number":42,"context_line":"   OVS mechanism driver, and the minimum bandwidth rules on the SR-IOV NIC"},{"line_number":43,"context_line":"   mechanism driver."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_00f27d9a","line":40,"range":{"start_line":40,"start_character":46,"end_line":40,"end_character":52},"in_reply_to":"fa31d9ce_731547e3","updated":"2017-02-17 14:43:35.000000000","message":"Done","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"653518f99928499317e945566fd544c5a8b44440","unresolved":false,"context_lines":[{"line_number":38,"context_line":".. note::"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"   Bandwidth limit is supported on OVS, Linux Bridge, and SR-IOV mechanism"},{"line_number":41,"context_line":"   drivers. For the Newton release onward DSCP marking will be supported on the"},{"line_number":42,"context_line":"   OVS mechanism driver, and the minimum bandwidth rules on the SR-IOV NIC"},{"line_number":43,"context_line":"   mechanism driver."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_13a7abaa","line":41,"range":{"start_line":41,"start_character":55,"end_line":41,"end_character":62},"updated":"2017-02-15 09:40:02.000000000","message":"is","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"341ddffaa864d50a4818adf9d1c161c0dea7b671","unresolved":false,"context_lines":[{"line_number":38,"context_line":".. note::"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"   Bandwidth limit is supported on OVS, Linux Bridge, and SR-IOV mechanism"},{"line_number":41,"context_line":"   drivers. For the Newton release onward DSCP marking will be supported on the"},{"line_number":42,"context_line":"   OVS mechanism driver, and the minimum bandwidth rules on the SR-IOV NIC"},{"line_number":43,"context_line":"   mechanism driver."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_e0f48988","line":41,"range":{"start_line":41,"start_character":55,"end_line":41,"end_character":62},"in_reply_to":"fa31d9ce_13a7abaa","updated":"2017-02-17 14:43:35.000000000","message":"Done","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f1528c51518e232c6d74896da94bf80c6d52ab9e","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"   Bandwidth limit is supported on OVS, Linux Bridge, and SR-IOV mechanism"},{"line_number":41,"context_line":"   drivers. For the Newton release onward DSCP marking will be supported on the"},{"line_number":42,"context_line":"   OVS mechanism driver, and the minimum bandwidth rules on the SR-IOV NIC"},{"line_number":43,"context_line":"   mechanism driver."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"In the most simple case, the property can be represented by a simple Python"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_bdc07051","line":42,"range":{"start_line":42,"start_character":3,"end_line":42,"end_character":23},"updated":"2017-02-15 09:00:50.000000000","message":"And LB too","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"341ddffaa864d50a4818adf9d1c161c0dea7b671","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"   Bandwidth limit is supported on OVS, Linux Bridge, and SR-IOV mechanism"},{"line_number":41,"context_line":"   drivers. For the Newton release onward DSCP marking will be supported on the"},{"line_number":42,"context_line":"   OVS mechanism driver, and the minimum bandwidth rules on the SR-IOV NIC"},{"line_number":43,"context_line":"   mechanism driver."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"In the most simple case, the property can be represented by a simple Python"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_c0f7858a","line":42,"range":{"start_line":42,"start_character":3,"end_line":42,"end_character":23},"in_reply_to":"fa31d9ce_bdc07051","updated":"2017-02-17 14:43:35.000000000","message":"Done","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"8b420c705547485bdb11051d76df3fc3240a804b","unresolved":false,"context_lines":[{"line_number":125,"context_line":"   \"update_policy\": \"rule:regular_user\","},{"line_number":126,"context_line":"   \"delete_policy\": \"rule:regular_user\","},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"To enable bandwidth limit rule:"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. code-block:: none"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"   \"get_policy_bandwidth_limit_rule\": \"rule:regular_user\","},{"line_number":133,"context_line":"   \"create_policy_bandwidth_limit_rule\": \"rule:admin_only\","},{"line_number":134,"context_line":"   \"delete_policy_bandwidth_limit_rule\": \"rule:admin_only\","},{"line_number":135,"context_line":"   \"update_policy_bandwidth_limit_rule\": \"rule:admin_only\","},{"line_number":136,"context_line":"   \"get_rule_type\": \"rule:regular_user\","},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"To enable DSCP marking rule:"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":".. code-block:: none"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"   \"get_policy_dscp_marking_rule\": \"rule:regular_user\","},{"line_number":143,"context_line":"   \"create_dscp_marking_rule\": \"rule:admin_only\","},{"line_number":144,"context_line":"   \"delete_dscp_marking_rule\": \"rule:admin_only\","},{"line_number":145,"context_line":"   \"update_dscp_marking_rule\": \"rule:admin_only\","},{"line_number":146,"context_line":"   \"get_rule_type\": \"rule:regular_user\","},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"User workflow"},{"line_number":149,"context_line":"~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_e457a823","line":146,"range":{"start_line":128,"start_character":0,"end_line":146,"end_character":40},"updated":"2017-02-15 11:56:07.000000000","message":"Do we need a similar section here for the minimum bandwidth rule?","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"341ddffaa864d50a4818adf9d1c161c0dea7b671","unresolved":false,"context_lines":[{"line_number":125,"context_line":"   \"update_policy\": \"rule:regular_user\","},{"line_number":126,"context_line":"   \"delete_policy\": \"rule:regular_user\","},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"To enable bandwidth limit rule:"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. code-block:: none"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"   \"get_policy_bandwidth_limit_rule\": \"rule:regular_user\","},{"line_number":133,"context_line":"   \"create_policy_bandwidth_limit_rule\": \"rule:admin_only\","},{"line_number":134,"context_line":"   \"delete_policy_bandwidth_limit_rule\": \"rule:admin_only\","},{"line_number":135,"context_line":"   \"update_policy_bandwidth_limit_rule\": \"rule:admin_only\","},{"line_number":136,"context_line":"   \"get_rule_type\": \"rule:regular_user\","},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"To enable DSCP marking rule:"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":".. code-block:: none"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"   \"get_policy_dscp_marking_rule\": \"rule:regular_user\","},{"line_number":143,"context_line":"   \"create_dscp_marking_rule\": \"rule:admin_only\","},{"line_number":144,"context_line":"   \"delete_dscp_marking_rule\": \"rule:admin_only\","},{"line_number":145,"context_line":"   \"update_dscp_marking_rule\": \"rule:admin_only\","},{"line_number":146,"context_line":"   \"get_rule_type\": \"rule:regular_user\","},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"User workflow"},{"line_number":149,"context_line":"~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_a002916d","line":146,"range":{"start_line":128,"start_character":0,"end_line":146,"end_character":40},"in_reply_to":"fa31d9ce_e457a823","updated":"2017-02-17 14:43:35.000000000","message":"Done.\nI\u0027ve also fixed a few mistakes.","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"8b420c705547485bdb11051d76df3fc3240a804b","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        115e4f70-8034-4176-8fe9-2c47f8878a7d dscp-marking"},{"line_number":381,"context_line":"      Deleted dscp_rule: 115e4f70-8034-4176-8fe9-2c47f8878a7d"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"You can incorporate minimum bandwidth rules to your policy:"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":".. code-block:: console"},{"line_number":386,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_04503cd3","line":383,"range":{"start_line":383,"start_character":0,"end_line":383,"end_character":59},"updated":"2017-02-15 11:56:07.000000000","message":"You can also include minimum bandwidth rules in your policy:","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"341ddffaa864d50a4818adf9d1c161c0dea7b671","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        115e4f70-8034-4176-8fe9-2c47f8878a7d dscp-marking"},{"line_number":381,"context_line":"      Deleted dscp_rule: 115e4f70-8034-4176-8fe9-2c47f8878a7d"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"You can incorporate minimum bandwidth rules to your policy:"},{"line_number":384,"context_line":""},{"line_number":385,"context_line":".. code-block:: console"},{"line_number":386,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_127c9471","line":383,"range":{"start_line":383,"start_character":0,"end_line":383,"end_character":59},"in_reply_to":"fa31d9ce_04503cd3","updated":"2017-02-17 14:43:35.000000000","message":"Done","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f1528c51518e232c6d74896da94bf80c6d52ab9e","unresolved":false,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":".. code-block:: console"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    $ neutron qos-policy-create bandwidth-control"},{"line_number":388,"context_line":"    $ neutron qos-minimum-bandwidth-rule-create bandwidth-control \\"},{"line_number":389,"context_line":"              --min-kbps 10000 --direction egress"},{"line_number":390,"context_line":"    Created a new minimum_bandwidth_rule:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_fdb2e8e3","line":387,"updated":"2017-02-15 09:00:50.000000000","message":"I know the whole document uses neutron client. Should we move to openstackclient?","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"341ddffaa864d50a4818adf9d1c161c0dea7b671","unresolved":false,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":".. code-block:: console"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    $ neutron qos-policy-create bandwidth-control"},{"line_number":388,"context_line":"    $ neutron qos-minimum-bandwidth-rule-create bandwidth-control \\"},{"line_number":389,"context_line":"              --min-kbps 10000 --direction egress"},{"line_number":390,"context_line":"    Created a new minimum_bandwidth_rule:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_72687022","line":387,"in_reply_to":"fa31d9ce_a4ea10d9","updated":"2017-02-17 14:43:35.000000000","message":"Done","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"8b420c705547485bdb11051d76df3fc3240a804b","unresolved":false,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":".. code-block:: console"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    $ neutron qos-policy-create bandwidth-control"},{"line_number":388,"context_line":"    $ neutron qos-minimum-bandwidth-rule-create bandwidth-control \\"},{"line_number":389,"context_line":"              --min-kbps 10000 --direction egress"},{"line_number":390,"context_line":"    Created a new minimum_bandwidth_rule:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_a4ea10d9","line":387,"in_reply_to":"fa31d9ce_fdb2e8e3","updated":"2017-02-15 11:56:07.000000000","message":"This new section should definitely use the openstackclient. Conversion of the existing commands can be covered by a separate patch.","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"8b420c705547485bdb11051d76df3fc3240a804b","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    | min_kbps  | 10000                                |"},{"line_number":397,"context_line":"    +-----------+--------------------------------------+"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    $ neutron qos-bandwidth-limit-rule-create bandwidth-control --max-kbps 50000"},{"line_number":400,"context_line":"    Created a new bandwidth_limit_rule:"},{"line_number":401,"context_line":"    +----------------+--------------------------------------+"},{"line_number":402,"context_line":"    | Field          | Value                                |"},{"line_number":403,"context_line":"    +----------------+--------------------------------------+"},{"line_number":404,"context_line":"    | id             | 76695f30-bdaf-4a3c-88b1-dfa4072ecd7e |"},{"line_number":405,"context_line":"    | max_burst_kbps | 0                                    |"},{"line_number":406,"context_line":"    | max_kbps       | 50000                                |"},{"line_number":407,"context_line":"    +----------------+--------------------------------------+"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    $ neutron qos-policy-show bandwidth-control"},{"line_number":410,"context_line":"    +-----------------+----------------------------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_a47f7013","line":407,"range":{"start_line":399,"start_character":4,"end_line":407,"end_character":61},"updated":"2017-02-15 11:56:07.000000000","message":"What\u0027s the reason for adding this rule? max_kbps is already covered above.","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"341ddffaa864d50a4818adf9d1c161c0dea7b671","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    | min_kbps  | 10000                                |"},{"line_number":397,"context_line":"    +-----------+--------------------------------------+"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    $ neutron qos-bandwidth-limit-rule-create bandwidth-control --max-kbps 50000"},{"line_number":400,"context_line":"    Created a new bandwidth_limit_rule:"},{"line_number":401,"context_line":"    +----------------+--------------------------------------+"},{"line_number":402,"context_line":"    | Field          | Value                                |"},{"line_number":403,"context_line":"    +----------------+--------------------------------------+"},{"line_number":404,"context_line":"    | id             | 76695f30-bdaf-4a3c-88b1-dfa4072ecd7e |"},{"line_number":405,"context_line":"    | max_burst_kbps | 0                                    |"},{"line_number":406,"context_line":"    | max_kbps       | 50000                                |"},{"line_number":407,"context_line":"    +----------------+--------------------------------------+"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    $ neutron qos-policy-show bandwidth-control"},{"line_number":410,"context_line":"    +-----------------+----------------------------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_d2bbdc73","line":407,"range":{"start_line":399,"start_character":4,"end_line":407,"end_character":61},"in_reply_to":"fa31d9ce_a47f7013","updated":"2017-02-17 14:43:35.000000000","message":"I wanted to explain that the combination of rules is possible.","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"8b420c705547485bdb11051d76df3fc3240a804b","unresolved":false,"context_lines":[{"line_number":423,"context_line":"    | updated_at      | 2017-02-14T14:51:02Z                                           |"},{"line_number":424,"context_line":"    +-----------------+----------------------------------------------------------------+"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"A policy with a minimum bandwidth limit rule guarantees bandwidth to the port"},{"line_number":428,"context_line":"as long as the hypervisor has enough bandwidth to met all the guarantees."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_84b8ac76","line":426,"updated":"2017-02-15 11:56:07.000000000","message":"extra whitespace","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"341ddffaa864d50a4818adf9d1c161c0dea7b671","unresolved":false,"context_lines":[{"line_number":423,"context_line":"    | updated_at      | 2017-02-14T14:51:02Z                                           |"},{"line_number":424,"context_line":"    +-----------------+----------------------------------------------------------------+"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"A policy with a minimum bandwidth limit rule guarantees bandwidth to the port"},{"line_number":428,"context_line":"as long as the hypervisor has enough bandwidth to met all the guarantees."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_f262a03c","line":426,"in_reply_to":"fa31d9ce_84b8ac76","updated":"2017-02-17 14:43:35.000000000","message":"Done","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"d913bee5c81c77750a479e290578e65463d32822","unresolved":false,"context_lines":[{"line_number":424,"context_line":"    +-----------------+----------------------------------------------------------------+"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"A policy with a minimum bandwidth limit rule guarantees bandwidth to the port"},{"line_number":428,"context_line":"as long as the hypervisor has enough bandwidth to met all the guarantees."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_132a4bdb","line":427,"range":{"start_line":427,"start_character":34,"end_line":427,"end_character":39},"updated":"2017-02-15 09:45:05.000000000","message":"would \"assurance\" be a better word here than \"limit\"?","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"8b420c705547485bdb11051d76df3fc3240a804b","unresolved":false,"context_lines":[{"line_number":424,"context_line":"    +-----------------+----------------------------------------------------------------+"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"A policy with a minimum bandwidth limit rule guarantees bandwidth to the port"},{"line_number":428,"context_line":"as long as the hypervisor has enough bandwidth to met all the guarantees."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_64349849","line":427,"range":{"start_line":427,"start_character":34,"end_line":427,"end_character":39},"in_reply_to":"fa31d9ce_132a4bdb","updated":"2017-02-15 11:56:07.000000000","message":"I would just remove this word altogether. \"minimum bandwidth rule\" is sufficient.","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"341ddffaa864d50a4818adf9d1c161c0dea7b671","unresolved":false,"context_lines":[{"line_number":424,"context_line":"    +-----------------+----------------------------------------------------------------+"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"A policy with a minimum bandwidth limit rule guarantees bandwidth to the port"},{"line_number":428,"context_line":"as long as the hypervisor has enough bandwidth to met all the guarantees."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_b28e68ce","line":427,"range":{"start_line":427,"start_character":34,"end_line":427,"end_character":39},"in_reply_to":"fa31d9ce_64349849","updated":"2017-02-17 14:43:35.000000000","message":"ack.","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"8b420c705547485bdb11051d76df3fc3240a804b","unresolved":false,"context_lines":[{"line_number":424,"context_line":"    +-----------------+----------------------------------------------------------------+"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"A policy with a minimum bandwidth limit rule guarantees bandwidth to the port"},{"line_number":428,"context_line":"as long as the hypervisor has enough bandwidth to met all the guarantees."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_048e7ccf","line":428,"range":{"start_line":427,"start_character":45,"end_line":428,"end_character":73},"updated":"2017-02-15 11:56:07.000000000","message":"Based on the release note attached to [1], suggest rewording this to:\n\n  ...ensures best efforts are made to provide no less than the specified\n  bandwidth to each port on which the rule is applied. However, as this\n  feature is not yet integrated with the Compute scheduler, minimum\n  bandwidth cannot be guaranteed.\n\n[1] https://review.openstack.org/#/c/344145/29/releasenotes/notes/qos-min-egress-bw-rule-b1c80f5675a4c1c3.yaml","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":14962,"name":"ologvinova","email":"ologvinova@mirantis.com","username":"ologvinova"},"change_message_id":"653518f99928499317e945566fd544c5a8b44440","unresolved":false,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"A policy with a minimum bandwidth limit rule guarantees bandwidth to the port"},{"line_number":428,"context_line":"as long as the hypervisor has enough bandwidth to met all the guarantees."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_d30ef3e3","line":428,"range":{"start_line":428,"start_character":50,"end_line":428,"end_character":53},"updated":"2017-02-15 09:40:02.000000000","message":"meet?","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"341ddffaa864d50a4818adf9d1c161c0dea7b671","unresolved":false,"context_lines":[{"line_number":424,"context_line":"    +-----------------+----------------------------------------------------------------+"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"A policy with a minimum bandwidth limit rule guarantees bandwidth to the port"},{"line_number":428,"context_line":"as long as the hypervisor has enough bandwidth to met all the guarantees."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_d2ed9c8f","line":428,"range":{"start_line":427,"start_character":45,"end_line":428,"end_character":73},"in_reply_to":"fa31d9ce_048e7ccf","updated":"2017-02-17 14:43:35.000000000","message":"Thanks, sounds great.","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"341ddffaa864d50a4818adf9d1c161c0dea7b671","unresolved":false,"context_lines":[{"line_number":425,"context_line":""},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"A policy with a minimum bandwidth limit rule guarantees bandwidth to the port"},{"line_number":428,"context_line":"as long as the hypervisor has enough bandwidth to met all the guarantees."}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa31d9ce_924ec4bf","line":428,"range":{"start_line":428,"start_character":50,"end_line":428,"end_character":53},"in_reply_to":"fa31d9ce_d30ef3e3","updated":"2017-02-17 14:43:35.000000000","message":"oops right.","commit_id":"059c5dd1cd49d3afa9cc91983247f7ce1aed8aef"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e5c5773f46dde57ef299bf25272cde28d0e4af8e","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"   Bandwidth limit is supported on OVS, Linux bridge, and SR-IOV mechanism"},{"line_number":41,"context_line":"   drivers. For the Newton release onward DSCP marking is supported on the"},{"line_number":42,"context_line":"   OVS and LB mechanism drivers, and the minimum bandwidth rules on the"},{"line_number":43,"context_line":"   SR-IOV NIC mechanism driver."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"In the most simple case, the property can be represented by a simple Python"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_a9392bd9","line":42,"range":{"start_line":42,"start_character":11,"end_line":42,"end_character":13},"updated":"2017-02-23 20:43:16.000000000","message":"nit: Linux bridge, as above.","commit_id":"abb2ea5a7b238819b30e72bed4bfc9ece1167b4e"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e5c5773f46dde57ef299bf25272cde28d0e4af8e","unresolved":false,"context_lines":[{"line_number":131,"context_line":".. code-block:: none"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"   \"get_policy_bandwidth_limit_rule\": \"rule:regular_user\","},{"line_number":134,"context_line":"   \"create_policy_bandwidth_limit_rule\": \"rule:regular_user\","},{"line_number":135,"context_line":"   \"delete_policy_bandwidth_limit_rule\": \"rule:regular_user\","},{"line_number":136,"context_line":"   \"update_policy_bandwidth_limit_rule\": \"rule:regular_user\","},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"To enable DSCP marking rule:"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":".. code-block:: none"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"   \"get_policy_dscp_marking_rule\": \"rule:regular_user\","},{"line_number":143,"context_line":"   \"create_dscp_marking_rule\": \"rule:regular_user\","},{"line_number":144,"context_line":"   \"delete_dscp_marking_rule\": \"rule:regular_user\","},{"line_number":145,"context_line":"   \"update_dscp_marking_rule\": \"rule:regular_user\","},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"To enable minimum bandwidth rule:"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_e9b96316","line":145,"range":{"start_line":134,"start_character":2,"end_line":145,"end_character":51},"updated":"2017-02-23 20:43:16.000000000","message":"These changes are outside of the scope of the bug, but they seem to be correct and are minor enough, so I think it\u0027s ok to include them.","commit_id":"abb2ea5a7b238819b30e72bed4bfc9ece1167b4e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f2374f79094cd58c3f798ce3a01c12128af63c5f","unresolved":false,"context_lines":[{"line_number":131,"context_line":".. code-block:: none"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"   \"get_policy_bandwidth_limit_rule\": \"rule:regular_user\","},{"line_number":134,"context_line":"   \"create_policy_bandwidth_limit_rule\": \"rule:regular_user\","},{"line_number":135,"context_line":"   \"delete_policy_bandwidth_limit_rule\": \"rule:regular_user\","},{"line_number":136,"context_line":"   \"update_policy_bandwidth_limit_rule\": \"rule:regular_user\","},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"To enable DSCP marking rule:"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":".. code-block:: none"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"   \"get_policy_dscp_marking_rule\": \"rule:regular_user\","},{"line_number":143,"context_line":"   \"create_dscp_marking_rule\": \"rule:regular_user\","},{"line_number":144,"context_line":"   \"delete_dscp_marking_rule\": \"rule:regular_user\","},{"line_number":145,"context_line":"   \"update_dscp_marking_rule\": \"rule:regular_user\","},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"To enable minimum bandwidth rule:"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_702f063f","line":145,"range":{"start_line":134,"start_character":2,"end_line":145,"end_character":51},"in_reply_to":"da36d5c6_e9b96316","updated":"2017-02-24 11:12:56.000000000","message":"You\u0027re right, thank you.","commit_id":"abb2ea5a7b238819b30e72bed4bfc9ece1167b4e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"959a2d3f18b1631547de4f72368b30ad78e5ab92","unresolved":false,"context_lines":[{"line_number":145,"context_line":"   \"update_dscp_marking_rule\": \"rule:regular_user\","},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"To enable minimum bandwidth rule:"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    \"get_policy_minimum_bandwidth_rule\": \"rule:regular_user\","},{"line_number":150,"context_line":"    \"create_policy_minimum_bandwidth_rule\": \"rule:regular_user\","},{"line_number":151,"context_line":"    \"delete_policy_minimum_bandwidth_rule\": \"rule:regular_user\","}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_9b5bf6f5","line":148,"updated":"2017-02-22 22:01:31.000000000","message":"IMHO here should be also something like \".. code-block:: none\" as is in L 140 and L131","commit_id":"abb2ea5a7b238819b30e72bed4bfc9ece1167b4e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f2374f79094cd58c3f798ce3a01c12128af63c5f","unresolved":false,"context_lines":[{"line_number":145,"context_line":"   \"update_dscp_marking_rule\": \"rule:regular_user\","},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"To enable minimum bandwidth rule:"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    \"get_policy_minimum_bandwidth_rule\": \"rule:regular_user\","},{"line_number":150,"context_line":"    \"create_policy_minimum_bandwidth_rule\": \"rule:regular_user\","},{"line_number":151,"context_line":"    \"delete_policy_minimum_bandwidth_rule\": \"rule:regular_user\","}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_30f10ece","line":148,"in_reply_to":"da36d5c6_2989bb75","updated":"2017-02-24 11:12:56.000000000","message":"Done","commit_id":"abb2ea5a7b238819b30e72bed4bfc9ece1167b4e"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e5c5773f46dde57ef299bf25272cde28d0e4af8e","unresolved":false,"context_lines":[{"line_number":145,"context_line":"   \"update_dscp_marking_rule\": \"rule:regular_user\","},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"To enable minimum bandwidth rule:"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    \"get_policy_minimum_bandwidth_rule\": \"rule:regular_user\","},{"line_number":150,"context_line":"    \"create_policy_minimum_bandwidth_rule\": \"rule:regular_user\","},{"line_number":151,"context_line":"    \"delete_policy_minimum_bandwidth_rule\": \"rule:regular_user\","}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_2989bb75","line":148,"in_reply_to":"da36d5c6_9b5bf6f5","updated":"2017-02-23 20:43:16.000000000","message":"+1","commit_id":"abb2ea5a7b238819b30e72bed4bfc9ece1167b4e"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e5c5773f46dde57ef299bf25272cde28d0e4af8e","unresolved":false,"context_lines":[{"line_number":390,"context_line":""},{"line_number":391,"context_line":".. code-block:: console"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    $ openstack network qos policy create bandwidth-control"},{"line_number":394,"context_line":"    $ openstack network qos rule create bandwidth-control \\"},{"line_number":395,"context_line":"                --type minimum-bandwidth --min-kbps 1000 --egress"},{"line_number":396,"context_line":"    +------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_a93e8b25","line":393,"updated":"2017-02-23 20:43:16.000000000","message":"Does this command not have a return?","commit_id":"abb2ea5a7b238819b30e72bed4bfc9ece1167b4e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f2374f79094cd58c3f798ce3a01c12128af63c5f","unresolved":false,"context_lines":[{"line_number":390,"context_line":""},{"line_number":391,"context_line":".. code-block:: console"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    $ openstack network qos policy create bandwidth-control"},{"line_number":394,"context_line":"    $ openstack network qos rule create bandwidth-control \\"},{"line_number":395,"context_line":"                --type minimum-bandwidth --min-kbps 1000 --egress"},{"line_number":396,"context_line":"    +------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_d046f279","line":393,"in_reply_to":"da36d5c6_a93e8b25","updated":"2017-02-24 11:12:56.000000000","message":"Done","commit_id":"abb2ea5a7b238819b30e72bed4bfc9ece1167b4e"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e5c5773f46dde57ef299bf25272cde28d0e4af8e","unresolved":false,"context_lines":[{"line_number":391,"context_line":".. code-block:: console"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    $ openstack network qos policy create bandwidth-control"},{"line_number":394,"context_line":"    $ openstack network qos rule create bandwidth-control \\"},{"line_number":395,"context_line":"                --type minimum-bandwidth --min-kbps 1000 --egress"},{"line_number":396,"context_line":"    +------------+--------------------------------------+"},{"line_number":397,"context_line":"    | Field      | Value                                |"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_89a547a3","line":394,"updated":"2017-02-23 20:43:16.000000000","message":"Please add a blank line before this one.","commit_id":"abb2ea5a7b238819b30e72bed4bfc9ece1167b4e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f2374f79094cd58c3f798ce3a01c12128af63c5f","unresolved":false,"context_lines":[{"line_number":391,"context_line":".. code-block:: console"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    $ openstack network qos policy create bandwidth-control"},{"line_number":394,"context_line":"    $ openstack network qos rule create bandwidth-control \\"},{"line_number":395,"context_line":"                --type minimum-bandwidth --min-kbps 1000 --egress"},{"line_number":396,"context_line":"    +------------+--------------------------------------+"},{"line_number":397,"context_line":"    | Field      | Value                                |"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_f0613606","line":394,"in_reply_to":"da36d5c6_89a547a3","updated":"2017-02-24 11:12:56.000000000","message":"Done","commit_id":"abb2ea5a7b238819b30e72bed4bfc9ece1167b4e"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e5c5773f46dde57ef299bf25272cde28d0e4af8e","unresolved":false,"context_lines":[{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    $ openstack network qos policy create bandwidth-control"},{"line_number":394,"context_line":"    $ openstack network qos rule create bandwidth-control \\"},{"line_number":395,"context_line":"                --type minimum-bandwidth --min-kbps 1000 --egress"},{"line_number":396,"context_line":"    +------------+--------------------------------------+"},{"line_number":397,"context_line":"    | Field      | Value                                |"},{"line_number":398,"context_line":"    +------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_894d4740","line":395,"range":{"start_line":395,"start_character":16,"end_line":395,"end_character":65},"updated":"2017-02-23 20:43:16.000000000","message":"Indentation should line up with \u0027openstack\u0027 on the line above.","commit_id":"abb2ea5a7b238819b30e72bed4bfc9ece1167b4e"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"94f9109a70ae4ab492184456007026d62d62806d","unresolved":false,"context_lines":[{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    $ openstack network qos policy create bandwidth-control"},{"line_number":394,"context_line":"    $ openstack network qos rule create bandwidth-control \\"},{"line_number":395,"context_line":"                --type minimum-bandwidth --min-kbps 1000 --egress"},{"line_number":396,"context_line":"    +------------+--------------------------------------+"},{"line_number":397,"context_line":"    | Field      | Value                                |"},{"line_number":398,"context_line":"    +------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_2fafe02a","line":395,"range":{"start_line":395,"start_character":16,"end_line":395,"end_character":65},"in_reply_to":"da36d5c6_50c3e256","updated":"2017-02-24 16:28:31.000000000","message":"L386 is wrong too, but this patch isn\u0027t touching it so I didn\u0027t think it was reasonable to ask you to fix it :)","commit_id":"abb2ea5a7b238819b30e72bed4bfc9ece1167b4e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f2374f79094cd58c3f798ce3a01c12128af63c5f","unresolved":false,"context_lines":[{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    $ openstack network qos policy create bandwidth-control"},{"line_number":394,"context_line":"    $ openstack network qos rule create bandwidth-control \\"},{"line_number":395,"context_line":"                --type minimum-bandwidth --min-kbps 1000 --egress"},{"line_number":396,"context_line":"    +------------+--------------------------------------+"},{"line_number":397,"context_line":"    | Field      | Value                                |"},{"line_number":398,"context_line":"    +------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_50c3e256","line":395,"range":{"start_line":395,"start_character":16,"end_line":395,"end_character":65},"in_reply_to":"da36d5c6_894d4740","updated":"2017-02-24 11:12:56.000000000","message":"IMHO a little of indentation helps readability on multi-line command lines, I\u0027ll keep a bit like in L386 and others.","commit_id":"abb2ea5a7b238819b30e72bed4bfc9ece1167b4e"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e5c5773f46dde57ef299bf25272cde28d0e4af8e","unresolved":false,"context_lines":[{"line_number":413,"context_line":".. code-block:: console"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    $ openstack network qos rule create bandwidth-control \\"},{"line_number":416,"context_line":"    --type bandwidth-limit --max-kbps 50000 --max-burst-kbits 50000"},{"line_number":417,"context_line":"    +----------------+--------------------------------------+"},{"line_number":418,"context_line":"    | Field          | Value                                |"},{"line_number":419,"context_line":"    +----------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_29653bb4","line":416,"range":{"start_line":416,"start_character":4,"end_line":416,"end_character":67},"updated":"2017-02-23 20:43:16.000000000","message":"Ditto L395","commit_id":"abb2ea5a7b238819b30e72bed4bfc9ece1167b4e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f2374f79094cd58c3f798ce3a01c12128af63c5f","unresolved":false,"context_lines":[{"line_number":413,"context_line":".. code-block:: console"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    $ openstack network qos rule create bandwidth-control \\"},{"line_number":416,"context_line":"    --type bandwidth-limit --max-kbps 50000 --max-burst-kbits 50000"},{"line_number":417,"context_line":"    +----------------+--------------------------------------+"},{"line_number":418,"context_line":"    | Field          | Value                                |"},{"line_number":419,"context_line":"    +----------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_30582e56","line":416,"range":{"start_line":416,"start_character":4,"end_line":416,"end_character":67},"in_reply_to":"da36d5c6_29653bb4","updated":"2017-02-24 11:12:56.000000000","message":"Done","commit_id":"abb2ea5a7b238819b30e72bed4bfc9ece1167b4e"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e5c5773f46dde57ef299bf25272cde28d0e4af8e","unresolved":false,"context_lines":[{"line_number":424,"context_line":"    | project_id     |                                      |"},{"line_number":425,"context_line":"    +----------------+--------------------------------------+"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    $ openstack network qos policy show bandwidth-control"},{"line_number":428,"context_line":"    +-------------+-------------------------------------------------------------------------------------------------------+"},{"line_number":429,"context_line":"    | Field       | Value                                                                                                 |"},{"line_number":430,"context_line":"    +-------------+-------------------------------------------------------------------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_e915e3e4","line":427,"updated":"2017-02-23 20:43:16.000000000","message":"Please add a blank line between this and the table above","commit_id":"abb2ea5a7b238819b30e72bed4bfc9ece1167b4e"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e5c5773f46dde57ef299bf25272cde28d0e4af8e","unresolved":false,"context_lines":[{"line_number":432,"context_line":"    | id          | 8491547e-add1-4c6c-a50e-42121237256c                                                                  |"},{"line_number":433,"context_line":"    | name        | bandwidth-control                                                                                     |"},{"line_number":434,"context_line":"    | project_id  | 7cc5a84e415d48e69d2b06aa67b317d8                                                                      |"},{"line_number":435,"context_line":"    | rules       | [{u\u0027max_kbps\u0027: 50000, u\u0027type\u0027: u\u0027bandwidth_limit\u0027, u\u0027id\u0027: u\u00270db48906-a762-4d32-8694-3f65214c34a6\u0027,    |"},{"line_number":436,"context_line":"    |             | u\u0027max_burst_kbps\u0027: 50000, u\u0027qos_policy_id\u0027: u\u00278491547e-add1-4c6c-a50e-42121237256c\u0027}, {u\u0027direction\u0027:  |"},{"line_number":437,"context_line":"    |             | u\u0027egress\u0027, u\u0027min_kbps\u0027: 1000, u\u0027type\u0027: u\u0027minimum_bandwidth\u0027, u\u0027id\u0027: u\u0027da858b32-44bc-43c9-b92b-        |"},{"line_number":438,"context_line":"    |             | cf6e2fa836ab\u0027, u\u0027qos_policy_id\u0027: u\u00278491547e-add1-4c6c-a50e-42121237256c\u0027}]                            |"},{"line_number":439,"context_line":"    | shared      | False                                                                                                 |"},{"line_number":440,"context_line":"    +-------------+-------------------------------------------------------------------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_29337bac","line":438,"range":{"start_line":435,"start_character":20,"end_line":438,"end_character":95},"updated":"2017-02-23 20:43:16.000000000","message":"Wow, is this really what the return from OSC looks like? Ouch. Would be nice to clean this up a bit so it fits in the 79 char limit.","commit_id":"abb2ea5a7b238819b30e72bed4bfc9ece1167b4e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f2374f79094cd58c3f798ce3a01c12128af63c5f","unresolved":false,"context_lines":[{"line_number":432,"context_line":"    | id          | 8491547e-add1-4c6c-a50e-42121237256c                                                                  |"},{"line_number":433,"context_line":"    | name        | bandwidth-control                                                                                     |"},{"line_number":434,"context_line":"    | project_id  | 7cc5a84e415d48e69d2b06aa67b317d8                                                                      |"},{"line_number":435,"context_line":"    | rules       | [{u\u0027max_kbps\u0027: 50000, u\u0027type\u0027: u\u0027bandwidth_limit\u0027, u\u0027id\u0027: u\u00270db48906-a762-4d32-8694-3f65214c34a6\u0027,    |"},{"line_number":436,"context_line":"    |             | u\u0027max_burst_kbps\u0027: 50000, u\u0027qos_policy_id\u0027: u\u00278491547e-add1-4c6c-a50e-42121237256c\u0027}, {u\u0027direction\u0027:  |"},{"line_number":437,"context_line":"    |             | u\u0027egress\u0027, u\u0027min_kbps\u0027: 1000, u\u0027type\u0027: u\u0027minimum_bandwidth\u0027, u\u0027id\u0027: u\u0027da858b32-44bc-43c9-b92b-        |"},{"line_number":438,"context_line":"    |             | cf6e2fa836ab\u0027, u\u0027qos_policy_id\u0027: u\u00278491547e-add1-4c6c-a50e-42121237256c\u0027}]                            |"},{"line_number":439,"context_line":"    | shared      | False                                                                                                 |"},{"line_number":440,"context_line":"    +-------------+-------------------------------------------------------------------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":4,"id":"da36d5c6_b03a5ee5","line":438,"range":{"start_line":435,"start_character":20,"end_line":438,"end_character":95},"in_reply_to":"da36d5c6_29337bac","updated":"2017-02-24 11:12:56.000000000","message":"I fixed it a bit, true artisan work ;)\n\nIt would be great to get that output a bit nicer.","commit_id":"abb2ea5a7b238819b30e72bed4bfc9ece1167b4e"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"1efa363840df546a2b4a322793ab776bf815b500","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"   Bandwidth limit is supported on OVS, Linux bridge, and SR-IOV mechanism"},{"line_number":41,"context_line":"   drivers. For the Newton release onward DSCP marking is supported on the"},{"line_number":42,"context_line":"   OVS and Linux Bridge mechanism drivers, and the minimum bandwidth rules"},{"line_number":43,"context_line":"   on the SR-IOV NIC mechanism driver."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"In the most simple case, the property can be represented by a simple Python"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_cfb3a408","line":42,"range":{"start_line":42,"start_character":17,"end_line":42,"end_character":23},"updated":"2017-02-24 16:30:40.000000000","message":"This is the teeniest of tiniest of nits: bridge should be lowercase.","commit_id":"886b2edffcecd964a2552844083df57a4b973b1f"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"1efa363840df546a2b4a322793ab776bf815b500","unresolved":false,"context_lines":[{"line_number":445,"context_line":"    | id          | 8491547e-add1-4c6c-a50e-42121237256c                              |"},{"line_number":446,"context_line":"    | name        | bandwidth-control                                                 |"},{"line_number":447,"context_line":"    | project_id  | 7cc5a84e415d48e69d2b06aa67b317d8                                  |"},{"line_number":448,"context_line":"    | rules       | [{u\u0027max_kbps\u0027: 50000, u\u0027type\u0027: u\u0027bandwidth_limit\u0027,                |"},{"line_number":449,"context_line":"    |             |   u\u0027id\u0027: u\u00270db48906-a762-4d32-8694-3f65214c34a6\u0027,                 |"},{"line_number":450,"context_line":"    |             |   u\u0027max_burst_kbps\u0027: 50000,                                       |"},{"line_number":451,"context_line":"    |             |   u\u0027qos_policy_id\u0027: u\u00278491547e-add1-4c6c-a50e-42121237256c\u0027},     |"},{"line_number":452,"context_line":"    |             |  {u\u0027direction\u0027:                                                   |"},{"line_number":453,"context_line":"    |             |   u\u0027egress\u0027, u\u0027min_kbps\u0027: 1000, u\u0027type\u0027: u\u0027minimum_bandwidth\u0027,    |"},{"line_number":454,"context_line":"    |             |   u\u0027id\u0027: u\u0027da858b32-44bc-43c9-b92b-cf6e2fa836ab\u0027,                 |"},{"line_number":455,"context_line":"    |             |   u\u0027qos_policy_id\u0027: u\u00278491547e-add1-4c6c-a50e-42121237256c\u0027}]     |"},{"line_number":456,"context_line":"    | shared      | False                                                             |"},{"line_number":457,"context_line":"    +-------------+-------------------------------------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":5,"id":"da36d5c6_afe3d0d7","line":455,"range":{"start_line":448,"start_character":20,"end_line":455,"end_character":81},"updated":"2017-02-24 16:30:40.000000000","message":"This is much better, thank you!","commit_id":"886b2edffcecd964a2552844083df57a4b973b1f"},{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"530f916a9ec5367ea2e9bf2509ae029fda031d09","unresolved":false,"context_lines":[{"line_number":38,"context_line":".. note::"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"   Bandwidth limit is supported on OVS, Linux bridge, and SR-IOV mechanism"},{"line_number":41,"context_line":"   drivers. For the Newton release onward DSCP marking is supported on the"},{"line_number":42,"context_line":"   OVS and Linux bridge mechanism drivers, and the minimum bandwidth rules"},{"line_number":43,"context_line":"   on the SR-IOV NIC mechanism driver."},{"line_number":44,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"da36d5c6_3863a743","line":41,"range":{"start_line":41,"start_character":35,"end_line":41,"end_character":41},"updated":"2017-02-24 18:03:16.000000000","message":"onward, *","commit_id":"f469c7f19bfb358d292af34c8d1a1b65971d5018"}]}