)]}'
{"doc/doc-contrib-guide/source/doc-tools/template-generator.rst":[{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"26285c70eb89b46cecd740d85ce926fcf722f36d","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  * README.rst"},{"line_number":104,"context_line":"  * schema.yaml"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"* redirect-tests.txt *input file for whereto to test .htaccess:"},{"line_number":107,"context_line":"  http://files.openstack.org/docs-404s/*"},{"line_number":108,"context_line":"* static *contains files that are not templates (CSS, JS, sitemap,"},{"line_number":109,"context_line":"  etc.)*"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_c347821d","line":106,"range":{"start_line":106,"start_character":37,"end_line":106,"end_character":44},"updated":"2017-10-19 17:16:37.000000000","message":"a link to http://git.openstack.org/cgit/openstack/whereto or other documentation would be helpful.","commit_id":"3c838e51937e25163dbc1ab8f274dfabcb63e1a8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"47228663e67d178a390f6d5417a113aa33537e60","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  * README.rst"},{"line_number":104,"context_line":"  * schema.yaml"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"* redirect-tests.txt *input file for whereto to test .htaccess:"},{"line_number":107,"context_line":"  http://files.openstack.org/docs-404s/*"},{"line_number":108,"context_line":"* static *contains files that are not templates (CSS, JS, sitemap,"},{"line_number":109,"context_line":"  etc.)*"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_efeedf86","line":106,"range":{"start_line":106,"start_character":37,"end_line":106,"end_character":44},"in_reply_to":"3f4b6375_c347821d","updated":"2017-10-19 20:13:15.000000000","message":"Done","commit_id":"3c838e51937e25163dbc1ab8f274dfabcb63e1a8"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"26285c70eb89b46cecd740d85ce926fcf722f36d","unresolved":false,"context_lines":[{"line_number":411,"context_line":"1. Update the schema to allow the flag by changing"},{"line_number":412,"context_line":"   ``www/project-data/schema.yaml``."},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"2. Update the contrib guide to explain the flag\u0027s use by modifying"},{"line_number":415,"context_line":"   ``doc/doc-contribu-guide/source/doc-tools/template-generator.rst``."},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"3. Update ``www/project-data/latest.yaml`` to set the flag for some project(s)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_63844e5f","line":414,"range":{"start_line":414,"start_character":10,"end_line":414,"end_character":27},"updated":"2017-10-19 17:16:37.000000000","message":"\"the doc contrib guide\" - this should us tell apart from the new contributor guide.","commit_id":"3c838e51937e25163dbc1ab8f274dfabcb63e1a8"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"47228663e67d178a390f6d5417a113aa33537e60","unresolved":false,"context_lines":[{"line_number":411,"context_line":"1. Update the schema to allow the flag by changing"},{"line_number":412,"context_line":"   ``www/project-data/schema.yaml``."},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"2. Update the contrib guide to explain the flag\u0027s use by modifying"},{"line_number":415,"context_line":"   ``doc/doc-contribu-guide/source/doc-tools/template-generator.rst``."},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"3. Update ``www/project-data/latest.yaml`` to set the flag for some project(s)."}],"source_content_type":"text/x-rst","patch_set":2,"id":"3f4b6375_2ff51758","line":414,"range":{"start_line":414,"start_character":10,"end_line":414,"end_character":27},"in_reply_to":"3f4b6375_63844e5f","updated":"2017-10-19 20:13:15.000000000","message":"Done","commit_id":"3c838e51937e25163dbc1ab8f274dfabcb63e1a8"},{"author":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"change_message_id":"f6d95c115e0a7228014b2b816beb235314fbe8e1","unresolved":false,"context_lines":[{"line_number":385,"context_line":"~~~~~~~~~~~~"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"How would I change a page?"},{"line_number":388,"context_line":"++++++++++++++++++++++++++"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"1. Look for the TEMPLATE_FILE value in the page source to find which"},{"line_number":391,"context_line":"   file produces the page"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_ebb5acef","line":388,"range":{"start_line":388,"start_character":0,"end_line":388,"end_character":26},"updated":"2017-10-20 03:00:56.000000000","message":"We use \"-\" to mark heading 3.Please check  https://docs.openstack.org/doc-contrib-guide/rst-conv/titles.html","commit_id":"11492de70fd5cb6b73bb90133b679f8ba43a1180"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"f287a778295d8c6b0fe839bc198613abf26b42e2","unresolved":false,"context_lines":[{"line_number":385,"context_line":"~~~~~~~~~~~~"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"How would I change a page?"},{"line_number":388,"context_line":"++++++++++++++++++++++++++"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"1. Look for the TEMPLATE_FILE value in the page source to find which"},{"line_number":391,"context_line":"   file produces the page"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_a2dd8743","line":388,"range":{"start_line":388,"start_character":0,"end_line":388,"end_character":26},"in_reply_to":"3f4b6375_ebb5acef","updated":"2017-10-20 15:14:29.000000000","message":"I\u0027m going to push back on this sort of review comment. Please don\u0027t take this personally, because you\u0027re not the only reviewer I\u0027ve seen doing this in this repo.\n\nI\u0027m giving you lots of new content here, and you\u0027re giving me a -1 because of formatting that isn\u0027t being checked via an automated linter, while not giving me any comments at all about the actual content. If I was a new contributor, I might very well walk away at this point. I have no way to tell what other \"nits\" someone might find with my next patch, and the response so far hasn\u0027t been that warm. I also might not have time to deal with fixing it. I think that is not a good way to build up contributions to documentation.\n\nSo, I propose that you either write the linter check for this rule, or propose a separate patch on top of this one to fix the problem. And let me know if the text makes sense and adds value.","commit_id":"11492de70fd5cb6b73bb90133b679f8ba43a1180"},{"author":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"change_message_id":"f6d95c115e0a7228014b2b816beb235314fbe8e1","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"The test script supports a few options to make it more effective."},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"--skip-links          Skip link checks"},{"line_number":459,"context_line":"--series SERIES       series to update/test"},{"line_number":460,"context_line":"--check-all-links     Check for links with flags set false."},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"To test template rendering without waiting for link checks::"},{"line_number":463,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_86abcdd4","line":460,"range":{"start_line":458,"start_character":0,"end_line":460,"end_character":59},"updated":"2017-10-20 03:00:56.000000000","message":"It would be better if following https://docs.openstack.org/doc-contrib-guide/rst-conv/lists.html","commit_id":"11492de70fd5cb6b73bb90133b679f8ba43a1180"},{"author":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"change_message_id":"f6d95c115e0a7228014b2b816beb235314fbe8e1","unresolved":false,"context_lines":[{"line_number":461,"context_line":""},{"line_number":462,"context_line":"To test template rendering without waiting for link checks::"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"  $ ./tools/test.sh --skip-links"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"To test project links only for items listed in latest.yaml::"},{"line_number":467,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_8b1e380a","line":464,"range":{"start_line":464,"start_character":0,"end_line":464,"end_character":32},"updated":"2017-10-20 03:00:56.000000000","message":".. code-block:: console","commit_id":"11492de70fd5cb6b73bb90133b679f8ba43a1180"},{"author":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"change_message_id":"f6d95c115e0a7228014b2b816beb235314fbe8e1","unresolved":false,"context_lines":[{"line_number":465,"context_line":""},{"line_number":466,"context_line":"To test project links only for items listed in latest.yaml::"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"  $ ./tools/test.sh --series latest"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"To produce a list of the unset flags for latest.yaml that *could* be"},{"line_number":471,"context_line":"set (the pages linked do exist)::"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_6b1bfc1a","line":468,"range":{"start_line":468,"start_character":0,"end_line":468,"end_character":35},"updated":"2017-10-20 03:00:56.000000000","message":"ditto","commit_id":"11492de70fd5cb6b73bb90133b679f8ba43a1180"},{"author":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"change_message_id":"f6d95c115e0a7228014b2b816beb235314fbe8e1","unresolved":false,"context_lines":[{"line_number":470,"context_line":"To produce a list of the unset flags for latest.yaml that *could* be"},{"line_number":471,"context_line":"set (the pages linked do exist)::"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"  $ ./tools/test.sh --check-all-links --series latest"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3f4b6375_4b18401c","line":473,"range":{"start_line":473,"start_character":0,"end_line":473,"end_character":53},"updated":"2017-10-20 03:00:56.000000000","message":"ditto","commit_id":"11492de70fd5cb6b73bb90133b679f8ba43a1180"}]}