)]}'
{"www/.htaccess":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"376e6d2861ba27f05cd911d2facfe93ad48905a4","unresolved":false,"context_lines":[{"line_number":140,"context_line":"redirect 301 /doc-contrib-guide/ui-text-guidelines /doc-contrib-guide/ux-ui-guidelines"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# Redirect any deploy guide project directory back to the current stable index"},{"line_number":143,"context_line":"{{ dir_to_page(\u0027/project-deploy-guide/(newton|ocata)\u0027, \u0027/$1/deploy/\u0027) }}"},{"line_number":144,"context_line":"{{ path_to_released_series(\u0027/project-deploy-guide$\u0027, \u0027/deploy/\u0027) }}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# Redirect old install guide list pages to their new home"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3f4b6375_0fb98d13","line":143,"updated":"2017-10-26 17:21:31.000000000","message":"shouldn\u0027t we add | pike here?","commit_id":"ae552c9f3335fafe94c02103ff4c4ce6e335829d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"fc56355b4f274d2a7c3165f8dd879f1cebf4ce3e","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# Redirect any deploy guide project directory back to the current stable index"},{"line_number":143,"context_line":"{{ dir_to_page(\u0027/project-deploy-guide/(newton|ocata)\u0027, \u0027/$1/deploy/\u0027) }}"},{"line_number":144,"context_line":"{{ path_to_released_series(\u0027/project-deploy-guide/?$\u0027, \u0027/deploy/\u0027) }}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# Redirect old install guide list pages to their new home"},{"line_number":147,"context_line":"{{ path_to_page(\u0027/(havana|icehouse|juno|kilo|mitaka)/install-guide\u0027, \u0027/$1/\u0027) }}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3f4b6375_20257309","line":144,"updated":"2017-10-26 22:10:08.000000000","message":"The macro path_to_released_series is going to append \"/pike/\" to the end of the first argument, giving /project-deploy-guide/?$/deploy/ as the result, which isn\u0027t what we want. I think we either need to use a different macro, or we need to write a new one for this case.","commit_id":"130db357614e984d5010adbe1dd8d29fe81ab923"},{"author":{"_account_id":24132,"name":"Maxime Guyot","email":"maxime@root314.com","username":"miouge"},"change_message_id":"da17c6575a88623b3ccac32dde69c9202e3189bb","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# Redirect any deploy guide project directory back to the current stable index"},{"line_number":143,"context_line":"{{ dir_to_page(\u0027/project-deploy-guide/(newton|ocata)\u0027, \u0027/$1/deploy/\u0027) }}"},{"line_number":144,"context_line":"{{ path_to_released_series(\u0027/project-deploy-guide/?$\u0027, \u0027/deploy/\u0027) }}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# Redirect old install guide list pages to their new home"},{"line_number":147,"context_line":"{{ path_to_page(\u0027/(havana|icehouse|juno|kilo|mitaka)/install-guide\u0027, \u0027/$1/\u0027) }}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3f4b6375_bb64ed4a","line":144,"in_reply_to":"3f4b6375_2001f338","updated":"2017-10-27 06:39:14.000000000","message":"From what I have tested locally, this produces:\nredirectmatch 301 ^/project-deploy-guide/?$($|/.*$) /pike/deploy/\n\nwhich is a valid regex and redirects both /project-deploy-guide/ and /project-deploy-guide but not /project-deploy-guide/foo\n\nI think that is the intended bevavior.","commit_id":"130db357614e984d5010adbe1dd8d29fe81ab923"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"e06506fe225033f931ba9a0969833dcac8bed4d8","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# Redirect any deploy guide project directory back to the current stable index"},{"line_number":143,"context_line":"{{ dir_to_page(\u0027/project-deploy-guide/(newton|ocata)\u0027, \u0027/$1/deploy/\u0027) }}"},{"line_number":144,"context_line":"{{ path_to_released_series(\u0027/project-deploy-guide/?$\u0027, \u0027/deploy/\u0027) }}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# Redirect old install guide list pages to their new home"},{"line_number":147,"context_line":"{{ path_to_page(\u0027/(havana|icehouse|juno|kilo|mitaka)/install-guide\u0027, \u0027/$1/\u0027) }}"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3f4b6375_2001f338","line":144,"in_reply_to":"3f4b6375_20257309","updated":"2017-10-26 22:15:53.000000000","message":"Actually, re-reading that, I\u0027m wrong. This should be the correct solution. You should update the redirect-tests.txt file too so that the tests match the rule change.","commit_id":"130db357614e984d5010adbe1dd8d29fe81ab923"},{"author":{"_account_id":24132,"name":"Maxime Guyot","email":"maxime@root314.com","username":"miouge"},"change_message_id":"c2a852f5cacfa3286ea2a27040f95b14c8b1f4dd","unresolved":false,"context_lines":[{"line_number":140,"context_line":"redirect 301 /doc-contrib-guide/ui-text-guidelines /doc-contrib-guide/ux-ui-guidelines"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# Redirect any deploy guide project directory back to the current stable index"},{"line_number":143,"context_line":"{{ dir_to_page(\u0027/project-deploy-guide/(newton|ocata)\u0027, \u0027/$1/deploy/\u0027) }}"},{"line_number":144,"context_line":"{{ path_to_released_series(\u0027/project-deploy-guide/?$\u0027, \u0027/deploy/\u0027) }}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# Redirect old install guide list pages to their new home"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3f4b6375_ac4ef593","line":143,"updated":"2017-10-27 08:34:20.000000000","message":"How about this, should Pike be in there as well?","commit_id":"4103ac9a221d06451e3ba9fb5f148e88ba5b1457"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"cb608f8ffd8fcfb8baeeade07b97f5b11a79fa16","unresolved":false,"context_lines":[{"line_number":140,"context_line":"redirect 301 /doc-contrib-guide/ui-text-guidelines /doc-contrib-guide/ux-ui-guidelines"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# Redirect any deploy guide project directory back to the current stable index"},{"line_number":143,"context_line":"{{ dir_to_page(\u0027/project-deploy-guide/(newton|ocata)\u0027, \u0027/$1/deploy/\u0027) }}"},{"line_number":144,"context_line":"{{ path_to_released_series(\u0027/project-deploy-guide/?$\u0027, \u0027/deploy/\u0027) }}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# Redirect old install guide list pages to their new home"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3f4b6375_e77e46ad","line":143,"in_reply_to":"3f4b6375_ac4ef593","updated":"2017-10-27 09:10:03.000000000","message":"I had this in my previous patch :)","commit_id":"4103ac9a221d06451e3ba9fb5f148e88ba5b1457"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"0134a165ebf9db486c8c5e29602662604ea28b81","unresolved":false,"context_lines":[{"line_number":140,"context_line":"redirect 301 /doc-contrib-guide/ui-text-guidelines /doc-contrib-guide/ux-ui-guidelines"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# Redirect any deploy guide project directory back to the current stable index"},{"line_number":143,"context_line":"{{ dir_to_page(\u0027/project-deploy-guide/(newton|ocata)\u0027, \u0027/$1/deploy/\u0027) }}"},{"line_number":144,"context_line":"{{ path_to_released_series(\u0027/project-deploy-guide/?$\u0027, \u0027/deploy/\u0027) }}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# Redirect old install guide list pages to their new home"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3f4b6375_67b496f2","line":143,"in_reply_to":"3f4b6375_ac4ef593","updated":"2017-10-27 08:49:41.000000000","message":"Yes, should be","commit_id":"4103ac9a221d06451e3ba9fb5f148e88ba5b1457"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"68c7142e2c41458a689ec6a5dc0c9839c8251190","unresolved":false,"context_lines":[{"line_number":140,"context_line":"redirect 301 /doc-contrib-guide/ui-text-guidelines /doc-contrib-guide/ux-ui-guidelines"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"# Redirect any deploy guide project directory back to the current stable index"},{"line_number":143,"context_line":"{{ dir_to_page(\u0027/project-deploy-guide/(newton|ocata)\u0027, \u0027/$1/deploy/\u0027) }}"},{"line_number":144,"context_line":"{{ path_to_released_series(\u0027/project-deploy-guide/?$\u0027, \u0027/deploy/\u0027) }}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# Redirect old install guide list pages to their new home"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3f4b6375_7952fa14","line":143,"in_reply_to":"3f4b6375_e77e46ad","updated":"2017-10-27 09:12:28.000000000","message":"updated","commit_id":"4103ac9a221d06451e3ba9fb5f148e88ba5b1457"}],"www/project-data/pike.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bda93a0eaf4084d76b7eb7b04fd630b7df89c81f","unresolved":false,"context_lines":[{"line_number":739,"context_line":"- name: openstack-ansible"},{"line_number":740,"context_line":"  service: OpenStack-Ansible Deployment"},{"line_number":741,"context_line":"  type: deployment"},{"line_number":742,"context_line":"  #has_deployment_guide: true"},{"line_number":743,"context_line":""},{"line_number":744,"context_line":"- name: kolla-ansible"},{"line_number":745,"context_line":"  service: Kolla Deployment"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4b6375_79e2fad6","line":742,"range":{"start_line":742,"start_character":0,"end_line":742,"end_character":29},"updated":"2017-10-27 09:25:24.000000000","message":"I\u0027m not going to block because this is breaking the gate, but can you just remove these instead of commenting them out? (they\u0027re in source control)","commit_id":"1dfa1a3dc4d43a3e3de732b9b683fb2e7bec0491"}]}