)]}'
{"www/redirect-tests.txt":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"0720ade9a1b63d5db91f2cf1295cc5e6e8b9af4e","unresolved":false,"context_lines":[{"line_number":186,"context_line":"{%- if project.has_in_tree_htaccess %}"},{"line_number":187,"context_line":"{{ deep_links(\u0027/developer/\u0027 + project.name, \u0027/\u0027 + project.name + \u0027/latest\u0027) }}"},{"line_number":188,"context_line":"# Do *not* redirect if only a prefix matches"},{"line_number":189,"context_line":"{{ deep_links(\u0027/developer/\u0027 + project.name + \u0027-bogus\u0027, \u0027\u0027, 200) }}"},{"line_number":190,"context_line":"{% else %}"},{"line_number":191,"context_line":"{{ path_to_page(\u0027/developer/\u0027 + project.name, \u0027/\u0027 + project.name + \u0027/latest/\u0027) }}"},{"line_number":192,"context_line":"{% endif -%}"}],"source_content_type":"text/plain","patch_set":1,"id":"1f485f77_89609434","line":189,"updated":"2017-11-12 16:38:13.000000000","message":"The macro isn\u0027t really set up to generate correct rules for 200 redirects because it still includes a result path in all of the tests, even though a rule for a 200 response shouldn\u0027t have a result path.\n\nI think we either need a new macro, or we need to add the 200 cases to the existing macro directly. Doing the latter would be consistent with the existing approach of having the macro emit multiple tests.","commit_id":"de5aaabcc6829e3057f61b06848f12c3dea465b0"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"c3c56384dba565b95ececbf8806edf93730135c5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"     result_prefix -- the start of the new path (should not include /)"},{"line_number":54,"context_line":"     code -- the response code (defaults to 301)"},{"line_number":55,"context_line":"#}"},{"line_number":56,"context_line":"{% macro deep_links(path, result_prefix, code\u003d301, nosuffix\u003dTrue) -%}"},{"line_number":57,"context_line":"{{ path }} {{ code }} {{ result_prefix }}/"},{"line_number":58,"context_line":"{{ path }}/ {{ code }} {{ result_prefix }}/"},{"line_number":59,"context_line":"{{ path }}/any-page {{ code }} {{ result_prefix }}/any-page"}],"source_content_type":"text/plain","patch_set":3,"id":"1f485f77_34d1defc","line":56,"updated":"2017-11-13 16:35:29.000000000","message":"Do we need the flag? Don\u0027t we always want the behavior we have here with nosuffix\u003dFalse?","commit_id":"a16b24ea3bf7b75f3b8e77a094227c07314fcf37"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"ab7ba98c985b773e075cf52fbba5bf8cdcb4835f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"     result_prefix -- the start of the new path (should not include /)"},{"line_number":54,"context_line":"     code -- the response code (defaults to 301)"},{"line_number":55,"context_line":"#}"},{"line_number":56,"context_line":"{% macro deep_links(path, result_prefix, code\u003d301, nosuffix\u003dTrue) -%}"},{"line_number":57,"context_line":"{{ path }} {{ code }} {{ result_prefix }}/"},{"line_number":58,"context_line":"{{ path }}/ {{ code }} {{ result_prefix }}/"},{"line_number":59,"context_line":"{{ path }}/any-page {{ code }} {{ result_prefix }}/any-page"}],"source_content_type":"text/plain","patch_set":3,"id":"1f485f77_853bbee9","line":56,"in_reply_to":"1f485f77_34d1defc","updated":"2017-11-13 18:54:59.000000000","message":"Yes. If we don\u0027t have nosuffix\u003dTrue then we won\u0027t be testing the bug that\u0027s being fixed here, and if we don\u0027t allow nosuffix\u003dFalse then it fails for the ansible tests (which are explicitly allowed to redirect \u0027/developer/openstack-ansible-[^/]+\u0027).","commit_id":"a16b24ea3bf7b75f3b8e77a094227c07314fcf37"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"5bcf33a482eeb205bdfb2c4354cd110c703c2729","unresolved":false,"context_lines":[{"line_number":53,"context_line":"     result_prefix -- the start of the new path (should not include /)"},{"line_number":54,"context_line":"     code -- the response code (defaults to 301)"},{"line_number":55,"context_line":"#}"},{"line_number":56,"context_line":"{% macro deep_links(path, result_prefix, code\u003d301, nosuffix\u003dTrue) -%}"},{"line_number":57,"context_line":"{{ path }} {{ code }} {{ result_prefix }}/"},{"line_number":58,"context_line":"{{ path }}/ {{ code }} {{ result_prefix }}/"},{"line_number":59,"context_line":"{{ path }}/any-page {{ code }} {{ result_prefix }}/any-page"}],"source_content_type":"text/plain","patch_set":3,"id":"ff82abbf_15ce7f2c","line":56,"in_reply_to":"1f485f77_853bbee9","updated":"2017-11-27 14:58:01.000000000","message":"To avoid ambiguity: Yes, we need the flag. No, we don\u0027t always want the nosuffix\u003dFalse behaviour, because this fix would be untested if we did that.","commit_id":"a16b24ea3bf7b75f3b8e77a094227c07314fcf37"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"8df8fb3ef6de81014adc6363cc42daae66752910","unresolved":false,"context_lines":[{"line_number":53,"context_line":"     result_prefix -- the start of the new path (should not include /)"},{"line_number":54,"context_line":"     code -- the response code (defaults to 301)"},{"line_number":55,"context_line":"#}"},{"line_number":56,"context_line":"{% macro deep_links(path, result_prefix, code\u003d301, nosuffix\u003dTrue) -%}"},{"line_number":57,"context_line":"{{ path }} {{ code }} {{ result_prefix }}/"},{"line_number":58,"context_line":"{{ path }}/ {{ code }} {{ result_prefix }}/"},{"line_number":59,"context_line":"{{ path }}/any-page {{ code }} {{ result_prefix }}/any-page"}],"source_content_type":"text/plain","patch_set":3,"id":"ff82abbf_1ab3060c","line":56,"in_reply_to":"ff82abbf_15ce7f2c","updated":"2017-11-27 18:52:46.000000000","message":"OK. I wonder if it\u0027s worth reviewing how those ansible links are generated and tested. I have been trying to keep the macros very simple to avoid having to reason too much about what arguments to pass to them. This is OK for now.","commit_id":"a16b24ea3bf7b75f3b8e77a094227c07314fcf37"}]}