)]}'
{"id":"openstack%2Fopenstack-specs~460110","triplet_id":"openstack%2Fopenstack-specs~master~If80b91ef0e853690587536abe975e7d6f3e9b891","project":"openstack/openstack-specs","branch":"master","topic":"logging-message-ids","hashtags":[],"change_id":"If80b91ef0e853690587536abe975e7d6f3e9b891","subject":"logging message identifiers","status":"ABANDONED","created":"2017-04-26 13:48:03.000000000","updated":"2017-05-15 14:49:38.000000000","total_comment_count":19,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"09001d593d3f832d968a010826aa4d397da3f6a3","_number":460110,"virtual_id_number":460110,"owner":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2017-04-26 13:57:37.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2017-04-27 14:01:03.000000000","_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},{"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":-1,"date":"2017-04-27 15:51:47.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"all":[{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},{"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},{"value":-1,"date":"2017-04-26 14:14:41.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-04-26 13:57:37.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-04-26 14:13:29.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2017-04-27 11:07:08.000000000","updated_by":{"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},"reviewer":{"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},"state":"REVIEWER"},{"updated":"2017-04-27 14:01:03.000000000","updated_by":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"reviewer":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"state":"REVIEWER"},{"updated":"2017-04-27 15:51:47.000000000","updated_by":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"reviewer":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"state":"REVIEWER"}],"messages":[{"id":"3dd0d64eddaa2a8fb86fa48704d40da70e3cb30b","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2017-04-26 13:48:03.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2a3c657b2f4f93c70d88746b936278454c230fcf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-26 13:49:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-specs-docs-ubuntu-xenial http://docs-draft.openstack.org/10/460110/1/check/gate-openstack-specs-docs-ubuntu-xenial/6d4f2df//doc/build/html/ : SUCCESS in 1m 44s","accounts_in_message":[],"_revision_number":1},{"id":"ec789079af877408e2568d9d802bdacb13e1a3f9","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2017-04-26 13:53:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"62d213d8693cd9fab0969896dd1f69cde410ae4d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-04-26 13:57:37.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstack-specs-docs-ubuntu-xenial http://docs-draft.openstack.org/10/460110/2/check/gate-openstack-specs-docs-ubuntu-xenial/df1418c//doc/build/html/ : SUCCESS in 2m 33s","accounts_in_message":[],"_revision_number":2},{"id":"7d92df424b41db2644fbe0322cf68b7b98419125","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-04-26 14:13:29.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nI like the idea of a situation ID rather than a per-message ID. I think that would help make troubleshooting easier.\n\nIt may be useful to have this information published to a site that can allow comments or another way for operators to add details that helped them resolve issues. But that\u0027s something better left for a later stage.","accounts_in_message":[],"_revision_number":1},{"id":"967e6f5328fcd6f9699429ded8eb5b72dec0d704","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2017-04-26 14:14:41.000000000","message":"Patch Set 2: Workflow-1\n\nThis will be discussed at the forum.","accounts_in_message":[],"_revision_number":2},{"id":"e041644bb1d24d4446fc53f62a21b17f59ac9e3d","author":{"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},"date":"2017-04-27 11:08:55.000000000","message":"Patch Set 2:\n\nAny thoughts on a severity field (F for Fatal etc.) as in other approaches e.g. IBM\u0027s ? This is useful for automatic alarming whenever a fatal situation occurs.","accounts_in_message":[],"_revision_number":2},{"id":"f640f2870d23698b8bd74dfc558b201dc86b8333","author":{"_account_id":136,"name":"Tim Bell","email":"tim.bell@cern.ch","username":"tim-bell"},"date":"2017-04-27 11:18:30.000000000","message":"Patch Set 2:\n\n\u003e Any thoughts on a severity field (F for Fatal etc.) as in other\n \u003e approaches e.g. IBM\u0027s ? This is useful for automatic alarming\n \u003e whenever a fatal situation occurs.\nJust checked and this is covered already through oslo.log so not needed.\n\nLooks good to me.","accounts_in_message":[],"_revision_number":2},{"id":"af93edc4a2e68d4824d03c4ae9d5d0d42db88e1c","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2017-04-27 12:55:11.000000000","message":"Patch Set 2:\n\nReviewers, there is a related alternative spec in https://review.openstack.org/460112","accounts_in_message":[],"_revision_number":2},{"id":"1cd63a12717ca2f243f51ed4fa93b080618cf40d","author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"date":"2017-04-27 14:01:03.000000000","message":"Patch Set 2:\n\n(7 comments)\n\nI think OpenStack should have message IDs. A little input from my side (I won\u0027t make it to the Forum).","accounts_in_message":[],"_revision_number":2},{"id":"b8f734a50e47276a0171d4c4801ae176ccc5db75","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2017-04-27 14:11:23.000000000","message":"Patch Set 2:\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"a29dcecb14968d2b4406d734da96d1b5e466ec84","author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"date":"2017-04-27 14:29:34.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"1e57cac10918aebb5d103473bea305244259ce99","author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"date":"2017-04-27 15:51:47.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)\n\nI find the concept of a \"situation id\" a bit confusing. Is the idea that there are a variety of different interactions that could lead to a log message with the same situation id?\n\nIf so, I\u0027m not sure, as a debugger, if that is something I would want. I might want the identifier to be specific to the exact instance of a class situations so I can inspect it directly.\n\nThose thoughts point out something that might be missing from this document: A very cogent explanation of the use case here. Who is going to use these identifiers for what?\n\nFinally, but this may be because I don\u0027t understand what a \"situation\" is, as a developer I\u0027m confused about when I would use an existing situation ID and when I would create a new one (when adding features, or fixing existing ones).\n\nSo the -1 is for something akin to \"I don\u0027t get it\".","accounts_in_message":[],"_revision_number":2},{"id":"14dee68709eae387b1ccff9ce9e65bcd099749bb","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2017-04-27 19:34:26.000000000","message":"Patch Set 2:\n\n(1 comment)\n\n\u003e (1 comment)\n \u003e \n \u003e I find the concept of a \"situation id\" a bit confusing. Is the idea\n \u003e that there are a variety of different interactions that could lead\n \u003e to a log message with the same situation id?\n\nTesting uniqueness seemed like an extra hassle. When I considered dropping that requirement, I realized that we may be able to get a new benefit if we use IDs to tie together several related messages. I\u0027ve seen several mentions from operators who say that they watch for a series of messages to detect a class of issues, rather than just looking for those final messages. For example, a path through the code that leads to a failure case may first log something at INFO, before the app eventually realizes that it\u0027s a full failure and logs a WARNING or ERROR.  If the IDs don\u0027t have to be unique, we could tag multiple messages to make those series more obvious/explicit.\n\nThat may all be a complication based on hope, though. It\u0027s not necessary, and it may make reviewing more complicated in a different way because reviewers would have to consider if log messages are truly related. \n\n \u003e If so, I\u0027m not sure, as a debugger, if that is something I would\n \u003e want. I might want the identifier to be specific to the exact\n \u003e instance of a class situations so I can inspect it directly.\n \u003e\n \u003e Those thoughts point out something that might be missing from this\n \u003e document: A very cogent explanation of the use case here. Who is\n \u003e going to use these identifiers for what?\n\nYes, I would also be happy to have that. So far, we\u0027ve had proposals for implementation without much detail into the \"why\". The other review includes a bit more detail in what I think are the requirements, including being able to find where a log message is produced in the code (searching for a string that may include %s and be split across several lines in the source can be a challenge) and having some sort of mnemonic for remembering and discussing an error. Frankly, I think the other proposal that adds exception names to the log automatically is easier to implement and solves those problems. I hope to get more information about what problems are solved by IDs that are not solved by the other proposal when we discuss this at the forum.\n\n \u003e Finally, but this may be because I don\u0027t understand what a\n \u003e \"situation\" is, as a developer I\u0027m confused about when I would use\n \u003e an existing situation ID and when I would create a new one (when\n \u003e adding features, or fixing existing ones).\n \u003e \n \u003e So the -1 is for something akin to \"I don\u0027t get it\".\n\nI didn\u0027t spell it out, because I was trying to avoid going into too much detail about exactly how to allocate IDs, but I had originally thought they would be scoped either to a single function or at least methods of a given class that are known to be invoked in sequence. Keeping track of that during a review may be asking too much, so I would be OK with dropping it if we think there\u0027s not much benefit.","accounts_in_message":[],"_revision_number":2},{"id":"f190e0f2e5234f5c871111689eb426278ecc8f5c","author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"date":"2017-04-28 10:01:39.000000000","message":"Patch Set 2:\n\n(2 comments)\n\nA few more thoughts on having \"project-name\" as part of the ID.","accounts_in_message":[],"_revision_number":2},{"id":"05a466b26642d9e634f7286efc1ca4641524335d","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2017-04-28 12:44:50.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"bfdd48036778454ba43e5d49913ee113d3f48da9","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2017-05-15 14:49:38.000000000","message":"Abandoned\n\nIn the forum session, we agreed to move ahead with https://review.openstack.org/460112 instead of this proposal.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"53a2d8076dd2b6650fa27bacca7d9422f5e2622a","revisions":{"d9ed138f8286a9e74d3d45118549711b5e157420":{"kind":"REWORK","_number":1,"created":"2017-04-26 13:48:03.000000000","uploader":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"ref":"refs/changes/10/460110/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-specs","ref":"refs/changes/10/460110/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-specs refs/changes/10/460110/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-specs refs/changes/10/460110/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-specs refs/changes/10/460110/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-specs refs/changes/10/460110/1"}}},"commit":{"parents":[{"commit":"47bc2257341fd2e37c8c100f0303eaeb1b65e985","subject":"Merge \"Add clouds.yaml support specification\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-specs/commit/47bc2257341fd2e37c8c100f0303eaeb1b65e985"}]}],"author":{"name":"Doug Hellmann","email":"doug@doughellmann.com","date":"2017-04-26 13:44:43.000000000","tz":-240},"committer":{"name":"Doug Hellmann","email":"doug@doughellmann.com","date":"2017-04-26 13:44:43.000000000","tz":-240},"subject":"logging message identifiers","message":"logging message identifiers\n\nOperators have been asking for mnemonic identifiers for log messages\ntied to errors since the start of the Folsom cycle in 2012. Let\u0027s see\nif we can finally deliver them.\n\nChange-Id: If80b91ef0e853690587536abe975e7d6f3e9b891\nSigned-off-by: Doug Hellmann \u003cdoug@doughellmann.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-specs/commit/d9ed138f8286a9e74d3d45118549711b5e157420"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-specs/commit/d9ed138f8286a9e74d3d45118549711b5e157420"}]},"branch":"refs/heads/master"},"53a2d8076dd2b6650fa27bacca7d9422f5e2622a":{"kind":"REWORK","_number":2,"created":"2017-04-26 13:53:34.000000000","uploader":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"ref":"refs/changes/10/460110/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstack-specs","ref":"refs/changes/10/460110/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstack-specs refs/changes/10/460110/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstack-specs refs/changes/10/460110/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstack-specs refs/changes/10/460110/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstack-specs refs/changes/10/460110/2"}}},"commit":{"parents":[{"commit":"47bc2257341fd2e37c8c100f0303eaeb1b65e985","subject":"Merge \"Add clouds.yaml support specification\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-specs/commit/47bc2257341fd2e37c8c100f0303eaeb1b65e985"}]}],"author":{"name":"Doug Hellmann","email":"doug@doughellmann.com","date":"2017-04-26 13:44:43.000000000","tz":-240},"committer":{"name":"Doug Hellmann","email":"doug@doughellmann.com","date":"2017-04-26 13:53:28.000000000","tz":-240},"subject":"logging message identifiers","message":"logging message identifiers\n\nOperators have been asking for mnemonic identifiers for log messages\ntied to errors since the start of the Folsom cycle in 2012. Let\u0027s see\nif we can finally deliver them.\n\nChange-Id: If80b91ef0e853690587536abe975e7d6f3e9b891\nSigned-off-by: Doug Hellmann \u003cdoug@doughellmann.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-specs/commit/53a2d8076dd2b6650fa27bacca7d9422f5e2622a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstack-specs/commit/53a2d8076dd2b6650fa27bacca7d9422f5e2622a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}