)]}'
{"ipxe/Makefile":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"6f197c5cac449635e00d75a25cd0df370040bb28","unresolved":false,"context_lines":[{"line_number":6,"context_line":"ipxe-boot.qcow2:"},{"line_number":7,"context_line":"\tELEMENTS_PATH\u003d./elements IPXE_GIT_REF\u003d$(IPXE_GIT_REF) disk-image-create -x -o ipxe-boot ipxe-boot-image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ipxe-boot-ipv6.qcow2:"},{"line_number":10,"context_line":"\tELEMENTS_PATH\u003d./elements IPXE_NET_PROTO_IPV6\u003dTrue IPXE_GIT_REF\u003d$(IPXE_GIT_REF) disk-image-create -x -o ipxe-boot-ipv6 ipxe-boot-image"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"all:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fa7e38b_ede3efd7","line":9,"updated":"2019-09-25 21:54:27.000000000","message":"Is there any reason to build a separate image rather than just enable it unconditionally? It makes the ipxe image 4k larger, which is inconsequential. Does it have any negative impacts?","commit_id":"448c6c404cccde61e102c94c949f7174f8efe409"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"42541dd3a4df8d19f3b4f65b6898babd5d05c76a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"ipxe-boot.qcow2:"},{"line_number":7,"context_line":"\tELEMENTS_PATH\u003d./elements IPXE_GIT_REF\u003d$(IPXE_GIT_REF) disk-image-create -x -o ipxe-boot ipxe-boot-image"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ipxe-boot-ipv6.qcow2:"},{"line_number":10,"context_line":"\tELEMENTS_PATH\u003d./elements IPXE_NET_PROTO_IPV6\u003dTrue IPXE_GIT_REF\u003d$(IPXE_GIT_REF) disk-image-create -x -o ipxe-boot-ipv6 ipxe-boot-image"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"all:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fa7e38b_91a7ed0b","line":9,"in_reply_to":"3fa7e38b_ede3efd7","updated":"2019-09-26 08:08:42.000000000","message":"It should\u0027nt have any negative impacts that I\u0027m aware of. I guess I\u0027m just being careful. To be honest maby the upstream default should be changed to enable IPV6 by default.\n\nI don\u0027t mind if we just make this the default in OVB.","commit_id":"448c6c404cccde61e102c94c949f7174f8efe409"}],"ipxe/elements/ipxe-boot-image/install.d/50-grub2-boot-ipxe":[{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"6f197c5cac449635e00d75a25cd0df370040bb28","unresolved":false,"context_lines":[{"line_number":30,"context_line":"IPXE_GIT_REF_CURRENT\u003d$(git rev-parse --short HEAD)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"if [[ \"${IPXE_NET_PROTO_IPV6:-False}\" \u003d\u003d \"True\" ]]; then"},{"line_number":33,"context_line":"  sed -i \u0027s/#undef\\tNET_PROTO_IPV6/\\#define\\tNET_PROTO_IPV6/g\u0027 config/general.h"},{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"cat \u003c\u003c EOF \u003e\u003escript.ipxe"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_0daa0b70","line":33,"updated":"2019-09-25 21:54:27.000000000","message":"Eww! But AFAICT this is really how you\u0027re supposed to do this.","commit_id":"448c6c404cccde61e102c94c949f7174f8efe409"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"42541dd3a4df8d19f3b4f65b6898babd5d05c76a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"IPXE_GIT_REF_CURRENT\u003d$(git rev-parse --short HEAD)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"if [[ \"${IPXE_NET_PROTO_IPV6:-False}\" \u003d\u003d \"True\" ]]; then"},{"line_number":33,"context_line":"  sed -i \u0027s/#undef\\tNET_PROTO_IPV6/\\#define\\tNET_PROTO_IPV6/g\u0027 config/general.h"},{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"cat \u003c\u003c EOF \u003e\u003escript.ipxe"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_f1b50133","line":33,"in_reply_to":"3fa7e38b_0daa0b70","updated":"2019-09-26 08:08:42.000000000","message":"Eww, indeed. :)","commit_id":"448c6c404cccde61e102c94c949f7174f8efe409"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"4d736f19c046c8226bf117fb55a34b0f616a96a0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"IPXE_GIT_REF_CURRENT\u003d$(git rev-parse --short HEAD)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"if [[ \"${IPXE_NET_PROTO_IPV6:-False}\" \u003d\u003d \"True\" ]]; then"},{"line_number":33,"context_line":"  sed -i \u0027s/#undef\\tNET_PROTO_IPV6/\\#define\\tNET_PROTO_IPV6/g\u0027 config/general.h"},{"line_number":34,"context_line":"fi"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"cat \u003c\u003c EOF \u003e\u003escript.ipxe"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_3c2049ac","line":33,"in_reply_to":"3fa7e38b_f1b50133","updated":"2019-09-26 14:23:59.000000000","message":"I was debugging a build failure in ipxe and accidentally stumbled across they way they actually intend us to do this. iPXE isn\u0027t strong on documentation! I knocked up:\n\nhttps://review.opendev.org/#/c/685096/","commit_id":"448c6c404cccde61e102c94c949f7174f8efe409"}]}