)]}'
{"environments/base-extra-node.yaml":[{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"96185e915d0354d09f839952a14440f28613223b","unresolved":true,"context_lines":[{"line_number":41,"context_line":"  role: extra"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"resource_registry:"},{"line_number":44,"context_line":"  OS::OVB::BMC: OS::Heat::None"},{"line_number":45,"context_line":"  OS::OVB::BaremetalPorts: ../templates/baremetal-ports-extra-node.yaml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5020dca0_754a1f16","line":44,"range":{"start_line":44,"start_character":2,"end_line":44,"end_character":30},"updated":"2021-05-28 08:26:31.000000000","message":"So this seem have resulted in the next failure, where the validation fails.\n\nRuntimeError: Found different numbers of baremetal and bmc ports\n\nhttps://logserver.rdoproject.org/48/793448/1/openstack-check/tripleo-ci-centos-8-ovb-3ctlr_1comp_1supp-featureset039/685ff28/job-output.txt","commit_id":"d6452234c0892ab9ecb3c9991f4b51734331e7e3"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"bfb6c7e3913d860fc9b10127a10feff88b480cf9","unresolved":true,"context_lines":[{"line_number":41,"context_line":"  role: extra"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"resource_registry:"},{"line_number":44,"context_line":"  OS::OVB::BMC: OS::Heat::None"},{"line_number":45,"context_line":"  OS::OVB::BaremetalPorts: ../templates/baremetal-ports-extra-node.yaml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f99eb229_2814384a","line":44,"range":{"start_line":44,"start_character":2,"end_line":44,"end_character":30},"in_reply_to":"3cfa5898_7d002c6d","updated":"2021-05-28 12:13:17.000000000","message":"I tried the \u0027baremetal_prefix\u0027 approach. It does not work.\nLet\u0027s revert the \u0027OS::OVB::BMC: OS::Heat::None\u0027 part, and we can make this change in a follow up?","commit_id":"d6452234c0892ab9ecb3c9991f4b51734331e7e3"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4fd3b77462c12cace379a45fa7678db65487a443","unresolved":true,"context_lines":[{"line_number":41,"context_line":"  role: extra"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"resource_registry:"},{"line_number":44,"context_line":"  OS::OVB::BMC: OS::Heat::None"},{"line_number":45,"context_line":"  OS::OVB::BaremetalPorts: ../templates/baremetal-ports-extra-node.yaml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf10f1ef_a9c5d083","line":44,"range":{"start_line":44,"start_character":2,"end_line":44,"end_character":30},"in_reply_to":"5020dca0_754a1f16","updated":"2021-05-28 09:04:32.000000000","message":"So, I\u0027ve been disabling BMC by doing as below without issues:\n OS::OVB::BMC: ../templates/bmc-none.yaml\n\nI don\u0027t see how that is different from just using OS::Heat::None","commit_id":"d6452234c0892ab9ecb3c9991f4b51734331e7e3"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"31293840e4b14ae79b9af6092fc703018f3a11d3","unresolved":true,"context_lines":[{"line_number":41,"context_line":"  role: extra"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"resource_registry:"},{"line_number":44,"context_line":"  OS::OVB::BMC: OS::Heat::None"},{"line_number":45,"context_line":"  OS::OVB::BaremetalPorts: ../templates/baremetal-ports-extra-node.yaml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3cfa5898_7d002c6d","line":44,"range":{"start_line":44,"start_character":2,"end_line":44,"end_character":30},"in_reply_to":"bf10f1ef_a9c5d083","updated":"2021-05-28 09:33:31.000000000","message":"I think if we set the \u0027baremetal_prefix\u0027 in environments/base-extra-node.yaml to something like \u0027baremetal_prefix: extra_baremetal\u0027 it would work? The extra node\u0027s ports will then not be included in bm_ports?\n\n[1] https://opendev.org/openstack/openstack-virtual-baremetal/src/branch/master/openstack_virtual_baremetal/build_nodes_json.py#L109-L110","commit_id":"d6452234c0892ab9ecb3c9991f4b51734331e7e3"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"031a97b6a4ed634ef6893e74ddf8d423f4ffe91e","unresolved":true,"context_lines":[{"line_number":41,"context_line":"  role: extra"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"resource_registry:"},{"line_number":44,"context_line":"  OS::OVB::BMC: OS::Heat::None"},{"line_number":45,"context_line":"  OS::OVB::BaremetalPorts: ../templates/baremetal-ports-extra-node.yaml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"eda463dc_80031f6b","line":44,"range":{"start_line":44,"start_character":2,"end_line":44,"end_character":30},"in_reply_to":"f99eb229_2814384a","updated":"2021-05-28 13:21:59.000000000","message":"https://review.opendev.org/c/openstack/openstack-virtual-baremetal/+/793600 worked for me locally.","commit_id":"d6452234c0892ab9ecb3c9991f4b51734331e7e3"}],"templates/virtual-baremetal-servers.yaml":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2bfd487fe1590ec6c18288163a3d295715666afa","unresolved":true,"context_lines":[{"line_number":23,"context_line":"  suffix:"},{"line_number":24,"context_line":"    type: string"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  config_drive:"},{"line_number":27,"context_line":"    type: boolean"},{"line_number":28,"context_line":"    default: false"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ec1b3daf_07234039","line":26,"range":{"start_line":26,"start_character":2,"end_line":26,"end_character":14},"updated":"2021-05-27 06:54:17.000000000","message":"We have to use a different parameter name here.\n\nWhen you set \"config_drive: true\" in the environment to use it for BMC and undercloud nodes, this would also enable it here. If I am not mistaken, this will cause the instances to have 2 disks, a very small vda with the config-drive and the bigger disk based on the flavor as vdb.\n\nWhen later using ironic to deploy to the virtual baremetal nodes ironic can end up trying to write the image to the wrong disk, and fail due to size.\n\nIf you use root_device hints to control wich disk ironic uses, there is also the issue that cloud-init on the ironic provisioned node will see the host clouds metadata, and not the cloud init data ironic put\u0027s on a partition.\n\nI\u0027m sure TripleO CI will break ...\n\n\nI think a different name such as \u0027virtual_baremetal_config_drive\u0027 should be used here, preferably with a description highlighting the potential pit-fall with ironic. For \"extra\" node where a generic cloud image is used we can then set \u0027virtual_baremetal_config_drive: true\u0027 in addition to \u0027config_drive: true\u0027","commit_id":"09cfce0d3eec3febdbbf29ee544beba0c264ed45"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"28e7301cd99818ad9f8df8a2b43ad2ac8d5c0fe1","unresolved":true,"context_lines":[{"line_number":23,"context_line":"  suffix:"},{"line_number":24,"context_line":"    type: string"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  config_drive:"},{"line_number":27,"context_line":"    type: boolean"},{"line_number":28,"context_line":"    default: false"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"973304f3_5b7066d9","line":26,"range":{"start_line":26,"start_character":2,"end_line":26,"end_character":14},"in_reply_to":"ec1b3daf_07234039","updated":"2021-05-27 07:14:24.000000000","message":"Not sure you got my question. What I\u0027m saying is with this patch, it\u0027s not enabling config_drive for the extra node.So it\u0027s probably not using this template either, unless depends-on does not work.\n\nhttps://logserver.rdoproject.org/54/32054/13/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp_1supp-featureset039-master/c144269/logs/baremetal_13_55179extra_0-console.log\n\nAbove log is form the test patch with this patch added as depends-on.","commit_id":"09cfce0d3eec3febdbbf29ee544beba0c264ed45"}]}