)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"60397d628cd3ec0a5af0f113d4ce193260ba2968","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ea792028_efba931f","updated":"2022-03-24 16:04:44.000000000","message":"Confirmed it working, on vexxhost.","commit_id":"3819a5d2119292e405074f5fedb49c70b0798976"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"3f123bd39ba1711e94947c12fdaa9936a7233178","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c4a34403_7c095eb3","updated":"2022-03-24 16:06:52.000000000","message":"Test project: https://review.rdoproject.org/r/c/testproject/+/40332","commit_id":"3819a5d2119292e405074f5fedb49c70b0798976"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"cd5ad16fa7765e116417050c2bf3191b087da958","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e23321ea_2a6ca216","updated":"2022-03-28 12:38:23.000000000","message":"A couple of inline comments. This looks good, but I think we should give the docs some TLC as well.\n\nDid we look at using the .usb target?\nafict, it would build a disk image with both pcbios and efi support?\nSee: https://ipxe.org/appnote/buildtargets\n\n\nAdding Ben to review as well.","commit_id":"1475a736a2d744f2e6eb37e5a926ddf0cbfcd606"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2fd928a12d7e669eee892ce4542350a1e44b1564","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"57f1d131_4b6151fa","in_reply_to":"0254f202_3455bce7","updated":"2022-03-30 08:13:57.000000000","message":"roger that. Let\u0027s go with the ISO format.","commit_id":"1475a736a2d744f2e6eb37e5a926ddf0cbfcd606"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"1ec8f1f6c96eb5cae4fbcbe06355604142ce736f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0254f202_3455bce7","in_reply_to":"e23321ea_2a6ca216","updated":"2022-03-30 00:40:34.000000000","message":"I vaguely remember trying the .usb target and the OVMF firmware didn\u0027t support the floppy format. I could try again, but hey the ISO works and it is a format slightly less legacy than floppy.","commit_id":"1475a736a2d744f2e6eb37e5a926ddf0cbfcd606"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"b5a1ae60d67b7b9c1a44ea2ab3f9c8de119e88b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2088747a_d1eb91a8","updated":"2022-04-01 16:30:36.000000000","message":"RDO job is still failing.\nBut, this image is not used in tests, and introspection passed. A good indication that everything OVB is OK. Based on this I will merge this change.\n\nhttps://logserver.rdoproject.org/13/834813/5/openstack-check/tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001-ovb-master/14e9090/logs/undercloud/home/zuul/overcloud_introspect.log.txt.gz","commit_id":"ce863ae11c6338d9269df3020db7e82f7608a30e"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"146a941dff92dc20733e093078db9007fd40c9ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c69373da_2e0f4e65","updated":"2022-03-30 02:17:27.000000000","message":"Thanks!","commit_id":"ce863ae11c6338d9269df3020db7e82f7608a30e"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"a3bb83e3260e53281715676f47941c3e3764bf63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"22a577a0_6252e993","updated":"2022-04-01 13:40:39.000000000","message":"Yes, that was an issue we noticed yesterday: https://bugs.launchpad.net/tripleo/+bug/1967430\nIt should be solved by now.","commit_id":"ce863ae11c6338d9269df3020db7e82f7608a30e"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2c62a4243ee9925806ab367fdc75e738687da5d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f279071b_f735e3eb","updated":"2022-03-31 19:57:10.000000000","message":"check-rdo","commit_id":"ce863ae11c6338d9269df3020db7e82f7608a30e"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a69e87d4ee4ab0ab0a3261077127b3abdcf949a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a2caaac1_e5aa0e0d","updated":"2022-04-01 09:43:19.000000000","message":"check-rdo\n\n2022-03-31 17:33:06.981013 | primary | ERROR: openstack-ansible-os_tempest from file:///home/zuul/src/opendev.org//openstack/openstack-ansible-os_tempest/#egg\u003dopenstack-ansible-os_tempest (from -r quickstart-extras-requirements.txt (line 5)) does not appear to be a Python project: neither \u0027setup.py\u0027 nor \u0027pyproject.toml\u0027 found.","commit_id":"ce863ae11c6338d9269df3020db7e82f7608a30e"}],"doc/source/host-cloud/prepare.rst":[{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"b5a51352a777c489d0ae576f39348a7281ae2a36","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"   #. To download a pre-built image::"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"       wget https://repos.fedorapeople.org/repos/openstack-m/ovb/ipxe-boot.qcow2"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"   #. To build the image, run the following from the root of the OVB repo::"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"45dae496_711a59ae","side":"PARENT","line":8,"updated":"2022-03-30 20:54:11.000000000","message":"https://repos.fedorapeople.org/repos/openstack-m/ovb/ is all very old images, I\u0027ll check if I have access and remove them","commit_id":"ad0b75e870f43af906580187c13886caccef2a8f"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"5e3cbb03c7c7242083b77be74512c0c0f97a6190","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"   #. To download a pre-built image::"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"       wget https://repos.fedorapeople.org/repos/openstack-m/ovb/ipxe-boot.qcow2"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"   #. To build the image, run the following from the root of the OVB repo::"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"c618dd37_296253d1","side":"PARENT","line":8,"in_reply_to":"45dae496_711a59ae","updated":"2022-03-30 21:09:00.000000000","message":"cleanup tracking in https://issues.redhat.com/browse/RDO-33","commit_id":"ad0b75e870f43af906580187c13886caccef2a8f"}],"ipxe/Makefile":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"cd5ad16fa7765e116417050c2bf3191b087da958","unresolved":true,"context_lines":[{"line_number":18,"context_line":"\tcp efi.img $$tmp_dir/efi.img \u0026\u0026 \\"},{"line_number":19,"context_line":"\tmkdir -p $$tmp_dir/boot/efi \u0026\u0026 \\"},{"line_number":20,"context_line":"\txorriso -osirrox on -indev $(ipxe_img_path) -extract / $$tmp_dir \u0026\u0026 \\"},{"line_number":21,"context_line":"\txorriso -as mkisofs \\"},{"line_number":22,"context_line":"\t\t-isohybrid-mbr /usr/share/syslinux/isohdpfx.bin \\"},{"line_number":23,"context_line":"\t\t-c boot.catalog \\"},{"line_number":24,"context_line":"\t\t-b isolinux.bin \\"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"745d99f7_002aef05","line":21,"range":{"start_line":21,"start_character":1,"end_line":21,"end_character":8},"updated":"2022-03-28 12:38:23.000000000","message":"doc need update - doc/source/host-cloud/prepare.rst\n\nIt mentions genisoimage as requirement.","commit_id":"1475a736a2d744f2e6eb37e5a926ddf0cbfcd606"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"1ec8f1f6c96eb5cae4fbcbe06355604142ce736f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\tcp efi.img $$tmp_dir/efi.img \u0026\u0026 \\"},{"line_number":19,"context_line":"\tmkdir -p $$tmp_dir/boot/efi \u0026\u0026 \\"},{"line_number":20,"context_line":"\txorriso -osirrox on -indev $(ipxe_img_path) -extract / $$tmp_dir \u0026\u0026 \\"},{"line_number":21,"context_line":"\txorriso -as mkisofs \\"},{"line_number":22,"context_line":"\t\t-isohybrid-mbr /usr/share/syslinux/isohdpfx.bin \\"},{"line_number":23,"context_line":"\t\t-c boot.catalog \\"},{"line_number":24,"context_line":"\t\t-b isolinux.bin \\"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ee7f619_1b7f3d88","line":21,"range":{"start_line":21,"start_character":1,"end_line":21,"end_character":8},"in_reply_to":"745d99f7_002aef05","updated":"2022-03-30 00:40:34.000000000","message":"Done","commit_id":"1475a736a2d744f2e6eb37e5a926ddf0cbfcd606"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"cd5ad16fa7765e116417050c2bf3191b087da958","unresolved":true,"context_lines":[{"line_number":81,"context_line":"clean:"},{"line_number":82,"context_line":"\trm -rf ipxe"},{"line_number":83,"context_line":"\tmkdir ipxe"},{"line_number":84,"context_line":"\trm -f ipxe-boot.img ipxe-boot.qcow2"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".PHONY: $(ipxe_img_path) clean"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"2b7f2803_d6320276","line":84,"range":{"start_line":84,"start_character":1,"end_line":84,"end_character":36},"updated":"2022-03-28 12:38:23.000000000","message":"Is this needed? With the convert removed?","commit_id":"1475a736a2d744f2e6eb37e5a926ddf0cbfcd606"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"1ec8f1f6c96eb5cae4fbcbe06355604142ce736f","unresolved":true,"context_lines":[{"line_number":81,"context_line":"clean:"},{"line_number":82,"context_line":"\trm -rf ipxe"},{"line_number":83,"context_line":"\tmkdir ipxe"},{"line_number":84,"context_line":"\trm -f ipxe-boot.img ipxe-boot.qcow2"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".PHONY: $(ipxe_img_path) clean"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"4968509b_ca95f929","line":84,"range":{"start_line":84,"start_character":1,"end_line":84,"end_character":36},"in_reply_to":"2b7f2803_d6320276","updated":"2022-03-30 00:40:34.000000000","message":"I did this so there wasn\u0027t a stale ipxe-boot.qcow2 from a previous build, that could be confusing","commit_id":"1475a736a2d744f2e6eb37e5a926ddf0cbfcd606"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2fd928a12d7e669eee892ce4542350a1e44b1564","unresolved":false,"context_lines":[{"line_number":81,"context_line":"clean:"},{"line_number":82,"context_line":"\trm -rf ipxe"},{"line_number":83,"context_line":"\tmkdir ipxe"},{"line_number":84,"context_line":"\trm -f ipxe-boot.img ipxe-boot.qcow2"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".PHONY: $(ipxe_img_path) clean"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"10e20572_1a0a48d4","line":84,"range":{"start_line":84,"start_character":1,"end_line":84,"end_character":36},"in_reply_to":"4968509b_ca95f929","updated":"2022-03-30 08:13:57.000000000","message":"Ok, makes sense.","commit_id":"1475a736a2d744f2e6eb37e5a926ddf0cbfcd606"}],"ipxe/README":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"cd5ad16fa7765e116417050c2bf3191b087da958","unresolved":true,"context_lines":[{"line_number":13,"context_line":"* syslinux-nonlinux"},{"line_number":14,"context_line":"* xz-devel"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Please ping Ben Nemec \u003copenstack@nemebean.com\u003e when making a change which"},{"line_number":17,"context_line":"affects the ipxe image to update the public repo of pre-built images."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"2d0438c9_f9becbc3","side":"PARENT","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":69},"updated":"2022-03-28 12:38:23.000000000","message":"Should we remove this? doc/source/host-cloud/prepare.rst still mention the repository with pre-build images. If we remove this, we may want to update doc as well.","commit_id":"ad0b75e870f43af906580187c13886caccef2a8f"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"2fd928a12d7e669eee892ce4542350a1e44b1564","unresolved":false,"context_lines":[{"line_number":13,"context_line":"* syslinux-nonlinux"},{"line_number":14,"context_line":"* xz-devel"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Please ping Ben Nemec \u003copenstack@nemebean.com\u003e when making a change which"},{"line_number":17,"context_line":"affects the ipxe image to update the public repo of pre-built images."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ab4feda5_c82fb7c2","side":"PARENT","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":69},"in_reply_to":"1206e94a_c69a1e89","updated":"2022-03-30 08:13:57.000000000","message":"Ack","commit_id":"ad0b75e870f43af906580187c13886caccef2a8f"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"1ec8f1f6c96eb5cae4fbcbe06355604142ce736f","unresolved":true,"context_lines":[{"line_number":13,"context_line":"* syslinux-nonlinux"},{"line_number":14,"context_line":"* xz-devel"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Please ping Ben Nemec \u003copenstack@nemebean.com\u003e when making a change which"},{"line_number":17,"context_line":"affects the ipxe image to update the public repo of pre-built images."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1206e94a_c69a1e89","side":"PARENT","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":69},"in_reply_to":"2d0438c9_f9becbc3","updated":"2022-03-30 00:40:34.000000000","message":"The documented link is a 404, so I\u0027ve removed the link from prepare.rst. I don\u0027t think we should be in the business of distributing these images unless it is fully automated.","commit_id":"ad0b75e870f43af906580187c13886caccef2a8f"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"a2acab4619d19e79b8a53d04343450860fafbe33","unresolved":true,"context_lines":[{"line_number":5,"context_line":"build the image. It is provided as a raw image which is capable of both UEFI"},{"line_number":6,"context_line":"and legacy BIOS boot."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"The iPXE image has minimal build dependencies. On a Fedora system, these are:"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"* gcc"},{"line_number":11,"context_line":"* xorriso"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"e8ba0658_66cce35f","line":8,"range":{"start_line":8,"start_character":33,"end_line":8,"end_character":45},"updated":"2022-03-29 03:53:12.000000000","message":"I tested this on a minimal fedora install, and it failed:\n\n  [root@fedora openstack-virtual-baremetal]# make -C ipxe/\n  \u003c ... snip ... \u003e\n  make[1]: Leaving directory \u0027/root/openstack-virtual-baremetal/ipxe/ipxe/src\u0027\n  tmp_dir\u003d$(mktemp -d) \u0026\u0026 \\\n  mkdir -p $tmp_dir/EFI/BOOT \u0026\u0026 \\\n  cp ipxe/src/bin-x86_64-efi/ipxe.efi $tmp_dir/EFI/BOOT/BOOTX64.EFI \u0026\u0026 \\\n  virt-make-fs --format\u003draw --type\u003dfat $tmp_dir efi.img\n  /bin/sh: line 4: virt-make-fs: command not found\n  make: *** [Makefile:36: efi.img] Error 127\n  make: Leaving directory \u0027/root/openstack-virtual-baremetal/ipxe\u0027\n\n\nI believe we need to add `guestfs-tools` and `libvirt` to the build dependencies.\n\nI also had to set LIBGUESTFS_BACKEND\u003ddirect with:\n  export LIBGUESTFS_BACKEND\u003ddirect","commit_id":"1475a736a2d744f2e6eb37e5a926ddf0cbfcd606"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"1ec8f1f6c96eb5cae4fbcbe06355604142ce736f","unresolved":false,"context_lines":[{"line_number":5,"context_line":"build the image. It is provided as a raw image which is capable of both UEFI"},{"line_number":6,"context_line":"and legacy BIOS boot."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"The iPXE image has minimal build dependencies. On a Fedora system, these are:"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"* gcc"},{"line_number":11,"context_line":"* xorriso"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"fc91da61_fee2ae3c","line":8,"range":{"start_line":8,"start_character":33,"end_line":8,"end_character":45},"in_reply_to":"e8ba0658_66cce35f","updated":"2022-03-30 00:40:34.000000000","message":"Done, this is a bit of double documentation with prepare.rst, I think I\u0027ll rework prepare.rst a bit and replace most of README with an online link.","commit_id":"1475a736a2d744f2e6eb37e5a926ddf0cbfcd606"}],"ipxe/ipxe":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"f1bb7ccd69800f72462ed4fb1c0258aba1f493e1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Subproject commit dd3547543811dd2e996b910bdadb609414904352"}],"source_content_type":"x-git/gitlink","patch_set":4,"id":"6a20dd19_11c18114","line":1,"updated":"2022-03-30 02:08:46.000000000","message":"If you\u0027re gonna respin, we might again update commit: f58b5109f46088bdbb5345a9d94b636c54345bdf\n\nhowever it\u0027s not required.","commit_id":"e06dc9114d6187705e2713404ed8a354c747c130"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"614c867b9ca2de9c8644fc430df837437d2619a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Subproject commit dd3547543811dd2e996b910bdadb609414904352"}],"source_content_type":"x-git/gitlink","patch_set":4,"id":"540d3b05_e4efd486","line":1,"in_reply_to":"6a20dd19_11c18114","updated":"2022-03-30 02:16:23.000000000","message":"Done","commit_id":"e06dc9114d6187705e2713404ed8a354c747c130"}]}