)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ad172e0f19e34ed8292e8d46f8a565ad7da93466","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a93adeab_f44d1517","updated":"2022-05-20 08:04:37.000000000","message":"py36 is hitting https://bugs.launchpad.net/tripleo/+bug/1974244\n\nyou can rebase onto https://review.opendev.org/c/openstack/openstack-virtual-baremetal/+/842405","commit_id":"c9b65bd0c2b6f403930b57d932907f353a0e6e61"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6d60324d18ccc16c27ef038b7e6be89c0db73e3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1c2ee8e5_b23024ab","updated":"2022-05-23 10:46:36.000000000","message":"Do we really want to do this on stable/2.0 branch?\nShould we not instead change TripleO CI to use master for now, and then cut a new stable release of OVB once we have C9-Stream support?","commit_id":"bb67a8575684d532a10c3d00ab58ae0c99286782"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"df6a9bc1e1038c27cef864d19f4984ac56cdaa35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7b496bf3_bf971122","updated":"2022-05-25 22:02:21.000000000","message":"I won\u0027t abandon this change just yet, just to keep this useful discussion visible","commit_id":"bb67a8575684d532a10c3d00ab58ae0c99286782"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"567e05b9db064547069519b68770591f55e8c71c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0ed8b2aa_4590e07a","updated":"2022-05-24 07:19:17.000000000","message":"so Harald I think you are saying that\n\n1. https://review.opendev.org/c/openstack/openstack-virtual-baremetal/+/842960 is sufficient and you don\u0027t want this forcing of centos-7 on stable/2.0 only for master? \n2. we also need to switch our jobs to use master instaed of 2.0\n\nit would mean blocking this until we discuss agree and implement the switch to use master. it *has* been discussed in the ci team and we have a task to explore it for next sprint fyi\n","commit_id":"bb67a8575684d532a10c3d00ab58ae0c99286782"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"ad71a993208c04c62cf2ec07a60facada69624de","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"704ec6ef_31d6c85c","in_reply_to":"0ed8b2aa_4590e07a","updated":"2022-05-24 07:57:34.000000000","message":"1. I think this change which \"removes the pre-built image support\" should not be backported to stable.\n2. I think https://review.opendev.org/c/openstack/openstack-virtual-baremetal/+/842960 is enough to fix our jobs and keep running on stable/2.0.\n3. In the not so distant future, when Steve\u0027s patches under \"topic:bmc-upgrade\" is complete we may want to either switch to use master or cut another stable branch and use that for TripleO master jobs. At this point probably also switch to use Redfish instead of IPMI.","commit_id":"bb67a8575684d532a10c3d00ab58ae0c99286782"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"4f90b24556be14b8ace22369675aeba1b83c8858","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fcee39df_1ba5452a","in_reply_to":"1c2ee8e5_b23024ab","updated":"2022-05-23 10:57:19.000000000","message":"I proposed a backport of only the change to install/upgrade the ca-certificates - https://review.opendev.org/c/openstack/openstack-virtual-baremetal/+/842960. I think that would fix stable/2.0 ?","commit_id":"bb67a8575684d532a10c3d00ab58ae0c99286782"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"7f1cfc4caf89ebc8b2b37c0a2347dc5dfadf5c18","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ce7f475b_0fa6ddf6","in_reply_to":"704ec6ef_31d6c85c","updated":"2022-05-26 04:11:32.000000000","message":"I\u0027ve proposed these 2 changes:\nhttps://review.rdoproject.org/r/c/config/+/43166\nhttps://review.opendev.org/c/openstack/tripleo-ci/+/843374\n\nLets carry on this discussion in those reviews","commit_id":"bb67a8575684d532a10c3d00ab58ae0c99286782"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"3d3701ceb962c26398f704ce30a3d231d916191a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bd9ff781_ecaee6dc","in_reply_to":"a1a1139b_473798fb","updated":"2022-05-23 11:56:49.000000000","message":"I think we use stable/2.0 for master TripleO jobs as well. I think the only time we use OVB master is when testing patches against openstack-virtual-baremetal itself.\n\nFor example this[1] master tripleo-heat-templates job have:\n\n        opendev.org/openstack/openstack-virtual-baremetal:\n            canonical_hostname: opendev.org\n            canonical_name: opendev.org/openstack/openstack-virtual-baremetal\n            checkout: stable/2.0\n            checkout_description: project override ref\n            commit: b99ed4692cb61f041125673e6de7b12ea4622ae3\n            name: openstack/openstack-virtual-baremetal\n            required: true\n            short_name: openstack-virtual-baremetal\n            src_dir: src/opendev.org/openstack/openstack-virtual-baremetal\n\n[1] https://logserver.rdoproject.org/74/842274/1/openstack-check/tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001/cfaa434/logs/zuul-variables.yaml","commit_id":"bb67a8575684d532a10c3d00ab58ae0c99286782"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"b7c3165449b093b652e4c16c1925e9f747a9a3c7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c225897f_272a94c6","in_reply_to":"bd9ff781_ecaee6dc","updated":"2022-05-23 21:36:49.000000000","message":"I think Harald is right, I\u0027m not aware of any CI which actually uses master OVB. This makes it hard to test OVB feature work, and requires backports just to get any change to run in CI.\n\nHaving master jobs run master OVB is something I am very much in favour of.\n\nI suspect stable/2.0 happened at a time when there was a lot of upstream development for personal-use ovb which kept breaking CI. But I think there is very little personal use OVB now.","commit_id":"bb67a8575684d532a10c3d00ab58ae0c99286782"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"567e05b9db064547069519b68770591f55e8c71c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c3d38694_834f5ecf","in_reply_to":"c225897f_272a94c6","updated":"2022-05-24 07:19:17.000000000","message":"looks like you\u0027re right - this came up in a ci call recently and someone said that we use master for master but i didn\u0027t check it at the time\n\nlooks like we use stable/2.0 everywhere e.g [1] [2] [3] sets that unconditionally upstream/midstream/downstream\n\n[1] https://opendev.org/openstack/tripleo-ci/src/commit/8f7363ec17f415ba57fe75cbae9c8b07a9ca5d71/zuul.d/base.yaml#L29\n\n[2] https://github.com/rdo-infra/review.rdoproject.org-config/blob/222b12b7cff82be0856e731870abc835adbc1939/roles/ovb-manage/defaults/main.yml#L6\n\n[3] https://code.engineering.redhat.com/gerrit/gitweb?p\u003dopenstack/tripleo-ci-internal-jobs.git;a\u003dblob;f\u003dzuul.d/required-projects-overrides.yaml#l19","commit_id":"bb67a8575684d532a10c3d00ab58ae0c99286782"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"68beca7d1930e7121bd68a72ea8cfbf3d801a8c7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"de9935a5_c1aa5a69","in_reply_to":"c3d38694_834f5ecf","updated":"2022-05-24 07:38:29.000000000","message":"RDO third party jobs running against ovb repo have jobs using stable/2.0[1] and master branch [2].\n\n[1]. https://github.com/rdo-infra/review.rdoproject.org-config/blob/master/zuul.d/tripleo.yaml#L110\n\n[2]. https://github.com/rdo-infra/review.rdoproject.org-config/blob/master/zuul.d/tripleo.yaml#L118\n\nif tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001-ovb-master and tripleo-ci-centos-9-ovb-3ctlr_1comp_1supp-featureset039-ovb-master are passing I think we can switch to master branch?\n\nhttps://review.rdoproject.org/zuul/builds?job_name\u003dtripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001-ovb-master\u0026skip\u003d0 does not looks good as it is check job.","commit_id":"bb67a8575684d532a10c3d00ab58ae0c99286782"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c59a4d21f086f72b35a782caa4d3547397ebeaa5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a1a1139b_473798fb","in_reply_to":"fcee39df_1ba5452a","updated":"2022-05-23 11:43:01.000000000","message":"we use master for master jobs but stable/2.0 for the stable/ branches.","commit_id":"bb67a8575684d532a10c3d00ab58ae0c99286782"}],"bin/install_openstackbmc.sh":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"ad172e0f19e34ed8292e8d46f8a565ad7da93466","unresolved":true,"context_lines":[{"line_number":4,"context_line":"centos_ver\u003d$(rpm --eval %{centos_ver})"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [ \"$centos_ver\" \u003d\u003d \"7\" ] ; then"},{"line_number":7,"context_line":"    yum install -y wget ca-certificates"},{"line_number":8,"context_line":"    wget -r --no-parent -nd -e robots\u003doff -l 1 -A \u0027python2-tripleo-repos-*\u0027 https://trunk.rdoproject.org/centos7/current/"},{"line_number":9,"context_line":"    yum install -y python2-tripleo-repos-*"},{"line_number":10,"context_line":"    tripleo-repos current-tripleo"}],"source_content_type":"text/x-sh","patch_set":2,"id":"17ebc264_badf081d","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":39},"updated":"2022-05-20 08:04:37.000000000","message":"this is absent in the original cherry-picked from","commit_id":"c9b65bd0c2b6f403930b57d932907f353a0e6e61"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"817a2b606c463f9c2ee86b018e70a60292faedec","unresolved":true,"context_lines":[{"line_number":4,"context_line":"centos_ver\u003d$(rpm --eval %{centos_ver})"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [ \"$centos_ver\" \u003d\u003d \"7\" ] ; then"},{"line_number":7,"context_line":"    yum install -y wget ca-certificates"},{"line_number":8,"context_line":"    wget -r --no-parent -nd -e robots\u003doff -l 1 -A \u0027python2-tripleo-repos-*\u0027 https://trunk.rdoproject.org/centos7/current/"},{"line_number":9,"context_line":"    yum install -y python2-tripleo-repos-*"},{"line_number":10,"context_line":"    tripleo-repos current-tripleo"}],"source_content_type":"text/x-sh","patch_set":2,"id":"4dac3f94_10d8eb0d","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":39},"in_reply_to":"17ebc264_badf081d","updated":"2022-05-23 06:09:16.000000000","message":"k, just came across https://review.opendev.org/c/openstack/openstack-virtual-baremetal/+/842727 - why not wait for it to merge then cherrypick it to add that here (seems cleaner)","commit_id":"c9b65bd0c2b6f403930b57d932907f353a0e6e61"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"567e05b9db064547069519b68770591f55e8c71c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"centos_ver\u003d$(rpm --eval %{centos_ver})"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"if [ \"$centos_ver\" \u003d\u003d \"7\" ] ; then"},{"line_number":7,"context_line":"    yum install -y wget ca-certificates"},{"line_number":8,"context_line":"    wget -r --no-parent -nd -e robots\u003doff -l 1 -A \u0027python2-tripleo-repos-*\u0027 https://trunk.rdoproject.org/centos7/current/"},{"line_number":9,"context_line":"    yum install -y python2-tripleo-repos-*"},{"line_number":10,"context_line":"    tripleo-repos current-tripleo"}],"source_content_type":"text/x-sh","patch_set":2,"id":"6c866d0f_f3a59655","line":7,"range":{"start_line":7,"start_character":24,"end_line":7,"end_character":39},"in_reply_to":"4dac3f94_10d8eb0d","updated":"2022-05-24 07:19:17.000000000","message":"cherrypick of ^^^ is proposed there https://review.opendev.org/c/openstack/openstack-virtual-baremetal/+/842960","commit_id":"c9b65bd0c2b6f403930b57d932907f353a0e6e61"}]}