)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"83cd65851b90eadb078abb875e08339201ca2839","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9ab49201_a67c2c0d","updated":"2022-08-02 06:39:11.000000000","message":" inline comments for consideration please ","commit_id":"6ba1d08c726cdaed5c6913c855eb8de76dde7f9d"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"c94c6967275f2c5cdd218b0ceb42a21ca2beb30e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"52ba83a3_cedd0cd7","updated":"2022-08-03 02:56:08.000000000","message":"As a suggestion which avoids needing to do this entirely, how about using a base image on IBM cloud which already has this CA cert installed? Once master jobs using  OVB branch master I think we should move towards a golden image approach so install_openstackbmc.sh can be shrunk into stack-specific configuration.","commit_id":"3ac0bb09c0597c269fd857df5f0b8dd688831afe"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"6dcd8125c16f56d5e85fc0dac25d6f5722c5c487","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fca9d2cf_73e5cf2b","in_reply_to":"52ba83a3_cedd0cd7","updated":"2022-08-03 06:59:14.000000000","message":"I used the above suggestion\n```\nvirt-customize -a bmc-template --upload ibm-bm2-nodepool.crt:/etc/pki/ca-trust/source/anchors/ibm-bm2-nodepool.crt --run-command update-ca-trust\n\nopenstack --os-cloud ibm-bm2-nodepool image create --disk-format qcow2 --container-format bare --shared --progress --file bmc-template  bmc-template-ibm\n```\nand\nin the latest run\n```\n- job:\n    name: periodic-tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001-master-ibm\n    parent: periodic-tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001-master\n    nodeset: tripleo-ovb-centos-9-primary-ibm\n    attempts: 1\n    vars:\n      ovb_manage_stack_mode: \u0027create\u0027\n      registry_login_enabled: false\n      quickstart_verbosity: -vv\n      create_private_network: true\n      key_name: chandankumar-ovb-test\n      cloud_name: ibm-bm2-nodepool\n      bmc_template_name: bmc-template-ibm\n      cloud_settings:\n          ibm-bm2-nodepool:\n            public_ip_net: hostonly\n            undercloud_flavor: nodepool\n            baremetal_flavor: m1.large\n            bmc_flavor: m1.small\n            extra_node_flavor: m1.small\n            enable_config_drive: true\n            radvd_flavor: m1.small\n            dhcp_relay_flavor: m1.small\n            enable_baremetal_config_drive: true\n            baremetal_image: CentOS-Stream-GenericCloud-9-20211216\n            baremetal_image_name: CentOS-Stream-GenericCloud-9-20211216\n- project:\n    check:\n      jobs:\n        - periodic-tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001-master-ibm\n```\nand\nperiodic-tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001-master-ibm https://review.rdoproject.org/zuul/build/48c42e98d96546b3970a335e2ee6f23e : SUCCESS in 1h 54m 33s it passed.","commit_id":"3ac0bb09c0597c269fd857df5f0b8dd688831afe"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"85d763f3263d311e27a21728ddc94117f86c2c8c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2efdbee5_a5e3f56f","updated":"2022-08-04 10:15:24.000000000","message":"Looks ok. I marked a few comments as resolved.\n\nBut, do we still want to do this? Reference to Steve\u0027s suggestion on using a modified cloud-image with the certificate pre-installed instead.","commit_id":"d1ca23f88c4890a61bd7ba418745320b7e5c4df0"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"72464cff5b2a95a13ed18ca520560a4d70b72ba1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"559777dc_93f71a20","updated":"2022-08-05 07:16:02.000000000","message":"looks OK but per harald comments may no longer be needed? if so please abandon","commit_id":"d1ca23f88c4890a61bd7ba418745320b7e5c4df0"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"bfa0d5097e91363d2cdf3c5579ce90d3393c3b80","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5318b72d_11c80039","in_reply_to":"2efdbee5_a5e3f56f","updated":"2022-08-05 10:09:04.000000000","message":"if we keep this feature, then we can use the same image in all cloud instead of modifying the image otherwise ibm cloud image will be have different due to certificate installed in it.\n\nI will wait for steve response.","commit_id":"d1ca23f88c4890a61bd7ba418745320b7e5c4df0"}],"bin/install_openstackbmc.sh":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6476ad534ef1abcd2a2be43775f72e6746f161b5","unresolved":true,"context_lines":[{"line_number":25,"context_line":"EOF"},{"line_number":26,"context_line":"chmod +x /usr/local/bin/openstackbmc"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Write cacert file"},{"line_number":29,"context_line":"cat \u003c\u003cEOF \u003e/tmp/cert"},{"line_number":30,"context_line":"$os_cacert"},{"line_number":31,"context_line":"EOF"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Configure clouds.yaml so we can authenticate to the host cloud"},{"line_number":34,"context_line":"mkdir -p ~/.config/openstack"}],"source_content_type":"text/x-sh","patch_set":2,"id":"8c35eab9_ba315bc7","line":31,"range":{"start_line":28,"start_character":0,"end_line":31,"end_character":3},"updated":"2022-08-02 14:14:15.000000000","message":"This should be conditioned, only if $os_cacert is not empty string.\nAnd there is no reason to use a tempfile? Just write it directly to `/etc/pki/ca-trust/source/anchors/bmc-cloud.crt` and run the command to update ca trust? No need for any of the below change?","commit_id":"3ac0bb09c0597c269fd857df5f0b8dd688831afe"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"db6469f67df9798f3004eaf9a6f8172d73f0adba","unresolved":false,"context_lines":[{"line_number":25,"context_line":"EOF"},{"line_number":26,"context_line":"chmod +x /usr/local/bin/openstackbmc"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Write cacert file"},{"line_number":29,"context_line":"cat \u003c\u003cEOF \u003e/tmp/cert"},{"line_number":30,"context_line":"$os_cacert"},{"line_number":31,"context_line":"EOF"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Configure clouds.yaml so we can authenticate to the host cloud"},{"line_number":34,"context_line":"mkdir -p ~/.config/openstack"}],"source_content_type":"text/x-sh","patch_set":2,"id":"4e225c1d_3cb05701","line":31,"range":{"start_line":28,"start_character":0,"end_line":31,"end_character":3},"in_reply_to":"73d388cd_c845c9d7","updated":"2022-08-04 09:42:40.000000000","message":"Done","commit_id":"3ac0bb09c0597c269fd857df5f0b8dd688831afe"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"554d433e8acacb81651773dc1c8f52601a32813e","unresolved":true,"context_lines":[{"line_number":25,"context_line":"EOF"},{"line_number":26,"context_line":"chmod +x /usr/local/bin/openstackbmc"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Write cacert file"},{"line_number":29,"context_line":"cat \u003c\u003cEOF \u003e/tmp/cert"},{"line_number":30,"context_line":"$os_cacert"},{"line_number":31,"context_line":"EOF"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Configure clouds.yaml so we can authenticate to the host cloud"},{"line_number":34,"context_line":"mkdir -p ~/.config/openstack"}],"source_content_type":"text/x-sh","patch_set":2,"id":"73d388cd_c845c9d7","line":31,"range":{"start_line":28,"start_character":0,"end_line":31,"end_character":3},"in_reply_to":"8c35eab9_ba315bc7","updated":"2022-08-02 15:35:12.000000000","message":"Ignore the part about tempfile, see updated comment below.","commit_id":"3ac0bb09c0597c269fd857df5f0b8dd688831afe"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6476ad534ef1abcd2a2be43775f72e6746f161b5","unresolved":true,"context_lines":[{"line_number":45,"context_line":"with open(\"/tmp/bmc-cloud-data\") as f:"},{"line_number":46,"context_line":"    data\u003djson.loads(f.read())"},{"line_number":47,"context_line":"if \"cacert\" in data.keys():"},{"line_number":48,"context_line":"    file_name \u003d str(data[\"cacert\"])"},{"line_number":49,"context_line":"    if os.path.exists(\"/tmp/cert\"):"},{"line_number":50,"context_line":"        shutil.copy(\"/tmp/cert\", file_name)"},{"line_number":51,"context_line":"    os.system(\"update-ca-trust\")"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bf360c99_a5348838","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":13},"updated":"2022-08-02 14:14:15.000000000","message":"I think we can just use a static filename in the appropidate directory here.\ni.e `/etc/pki/ca-trust/source/anchors/bmc-cloud.crt ? or something","commit_id":"3ac0bb09c0597c269fd857df5f0b8dd688831afe"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"554d433e8acacb81651773dc1c8f52601a32813e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"with open(\"/tmp/bmc-cloud-data\") as f:"},{"line_number":46,"context_line":"    data\u003djson.loads(f.read())"},{"line_number":47,"context_line":"if \"cacert\" in data.keys():"},{"line_number":48,"context_line":"    file_name \u003d str(data[\"cacert\"])"},{"line_number":49,"context_line":"    if os.path.exists(\"/tmp/cert\"):"},{"line_number":50,"context_line":"        shutil.copy(\"/tmp/cert\", file_name)"},{"line_number":51,"context_line":"    os.system(\"update-ca-trust\")"}],"source_content_type":"text/x-sh","patch_set":2,"id":"142ac870_fdf9944a","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":13},"in_reply_to":"bf360c99_a5348838","updated":"2022-08-02 15:35:12.000000000","message":"I take this comment back. I see how this is copying the cert to the location in cloud_data which is derived from auth._cloud_json()","commit_id":"3ac0bb09c0597c269fd857df5f0b8dd688831afe"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"554d433e8acacb81651773dc1c8f52601a32813e","unresolved":true,"context_lines":[{"line_number":54,"context_line":"rm -f /tmp/bmc-cloud-data"},{"line_number":55,"context_line":"export OS_CLOUD\u003dhost_cloud"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# If $os_cacert is defined then create the cacert file"},{"line_number":58,"context_line":"if [ -f \"$os_cacert\" ]; then"},{"line_number":59,"context_line":"    mkdir -p /etc/pki/ca-trust/source/anchors;"},{"line_number":60,"context_line":"    cat \u003c\u003cEOF /etc/pki/ca-trust/source/anchors/$CLOUD_CACERT.crt"},{"line_number":61,"context_line":"    $os_cacert"},{"line_number":62,"context_line":"    EOF;"},{"line_number":63,"context_line":"    update-ca-trust; fi"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# python script do query the cloud and write out the bmc services/configs"},{"line_number":66,"context_line":"$(command -v python3 || command -v python2) \u003c\u003cEOF"}],"source_content_type":"text/x-sh","patch_set":2,"id":"75ac0540_d9e1ccc0","line":63,"range":{"start_line":57,"start_character":0,"end_line":63,"end_character":23},"updated":"2022-08-02 15:35:12.000000000","message":"Is\u0027nt this just repeating what happened above in L49-51 ?","commit_id":"3ac0bb09c0597c269fd857df5f0b8dd688831afe"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"db6469f67df9798f3004eaf9a6f8172d73f0adba","unresolved":false,"context_lines":[{"line_number":54,"context_line":"rm -f /tmp/bmc-cloud-data"},{"line_number":55,"context_line":"export OS_CLOUD\u003dhost_cloud"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# If $os_cacert is defined then create the cacert file"},{"line_number":58,"context_line":"if [ -f \"$os_cacert\" ]; then"},{"line_number":59,"context_line":"    mkdir -p /etc/pki/ca-trust/source/anchors;"},{"line_number":60,"context_line":"    cat \u003c\u003cEOF /etc/pki/ca-trust/source/anchors/$CLOUD_CACERT.crt"},{"line_number":61,"context_line":"    $os_cacert"},{"line_number":62,"context_line":"    EOF;"},{"line_number":63,"context_line":"    update-ca-trust; fi"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# python script do query the cloud and write out the bmc services/configs"},{"line_number":66,"context_line":"$(command -v python3 || command -v python2) \u003c\u003cEOF"}],"source_content_type":"text/x-sh","patch_set":2,"id":"d7ed18cb_61416dab","line":63,"range":{"start_line":57,"start_character":0,"end_line":63,"end_character":23},"in_reply_to":"75ac0540_d9e1ccc0","updated":"2022-08-04 09:42:40.000000000","message":"removed that line.","commit_id":"3ac0bb09c0597c269fd857df5f0b8dd688831afe"}],"templates/bmc.yaml":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"83cd65851b90eadb078abb875e08339201ca2839","unresolved":true,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  os_cacert:"},{"line_number":84,"context_line":"    type: string"},{"line_number":85,"context_line":"    default: \u0027\u0027"},{"line_number":86,"context_line":"    description: |"},{"line_number":87,"context_line":"      The project domain for os_cacert."},{"line_number":88,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"13084a87_a8ed4d68","line":85,"range":{"start_line":85,"start_character":13,"end_line":85,"end_character":15},"updated":"2022-08-02 06:39:11.000000000","message":"perhaps you mean to default this to  /etc/pki/ca-trust/source/anchors/simpleca.crt","commit_id":"6ba1d08c726cdaed5c6913c855eb8de76dde7f9d"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"85d763f3263d311e27a21728ddc94117f86c2c8c","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  os_cacert:"},{"line_number":84,"context_line":"    type: string"},{"line_number":85,"context_line":"    default: \u0027\u0027"},{"line_number":86,"context_line":"    description: |"},{"line_number":87,"context_line":"      The project domain for os_cacert."},{"line_number":88,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"13649128_e6349564","line":85,"range":{"start_line":85,"start_character":13,"end_line":85,"end_character":15},"in_reply_to":"13084a87_a8ed4d68","updated":"2022-08-04 10:15:24.000000000","message":"Since \u0027get_param\u0027 is used below, this parameter now takes the content of the certificate file. Marking this comment resolved.","commit_id":"6ba1d08c726cdaed5c6913c855eb8de76dde7f9d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"83cd65851b90eadb078abb875e08339201ca2839","unresolved":true,"context_lines":[{"line_number":84,"context_line":"    type: string"},{"line_number":85,"context_line":"    default: \u0027\u0027"},{"line_number":86,"context_line":"    description: |"},{"line_number":87,"context_line":"      The project domain for os_cacert."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  cloud_data:"},{"line_number":90,"context_line":"    type: string"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e17aff69_c8486df0","line":87,"range":{"start_line":87,"start_character":10,"end_line":87,"end_character":24},"updated":"2022-08-02 06:39:11.000000000","message":"copy/paste nit doesnt make sense (from the previous one i guess)\n\nmore like \"The certificate authority certificate \" (assuming this is what cacert is? maybe it is something else so please update the description to explain ;))","commit_id":"6ba1d08c726cdaed5c6913c855eb8de76dde7f9d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"83cd65851b90eadb078abb875e08339201ca2839","unresolved":true,"context_lines":[{"line_number":155,"context_line":"            $os_project: {get_param: os_project}"},{"line_number":156,"context_line":"            $os__user_domain: {get_param: os_user_domain}"},{"line_number":157,"context_line":"            $os__project_domain: {get_param: os_project_domain}"},{"line_number":158,"context_line":"            $os_cacert: {get_file: /etc/pki/ca-trust/source/anchors/simpleca.crt}"},{"line_number":159,"context_line":"            $bm_node_count: {get_param: node_count}"},{"line_number":160,"context_line":"            $bmc_prefix: {get_param: bmc_prefix}"},{"line_number":161,"context_line":"            $bmc_utility: {get_attr: [bmc_port, ip_address]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"27fa6005_316a5feb","line":158,"range":{"start_line":158,"start_character":35,"end_line":158,"end_character":81},"updated":"2022-08-02 06:39:11.000000000","message":"but what about the parameter you added then\nmaybe should be get_param: os_cacert?","commit_id":"6ba1d08c726cdaed5c6913c855eb8de76dde7f9d"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6476ad534ef1abcd2a2be43775f72e6746f161b5","unresolved":true,"context_lines":[{"line_number":155,"context_line":"            $os_project: {get_param: os_project}"},{"line_number":156,"context_line":"            $os__user_domain: {get_param: os_user_domain}"},{"line_number":157,"context_line":"            $os__project_domain: {get_param: os_project_domain}"},{"line_number":158,"context_line":"            $os_cacert: {get_file: /etc/pki/ca-trust/source/anchors/simpleca.crt}"},{"line_number":159,"context_line":"            $bm_node_count: {get_param: node_count}"},{"line_number":160,"context_line":"            $bmc_prefix: {get_param: bmc_prefix}"},{"line_number":161,"context_line":"            $bmc_utility: {get_attr: [bmc_port, ip_address]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7ba52936_7127aa3a","line":158,"range":{"start_line":158,"start_character":35,"end_line":158,"end_character":81},"in_reply_to":"27fa6005_316a5feb","updated":"2022-08-02 14:14:15.000000000","message":"get_file does not support lookup from parameters see: https://docs.openstack.org/heat/latest/template_guide/hot_spec.html#get-file\n\nI.e the \u0027os_cacert\u0027 parameter is not used, and cannot be used with get_file.\n\nI think hard-coding the path to /etc/pki/ca-trust/source/anchors/ is not the best.\nI would rather we create a directory in the repo use \u0027../cacert/bmc-ca.crt` or somthing similar. The user will have copy the certificate to \u0027../cacert/bmc-ca.crt`\n\nEven better option would be to add the actual content (not the path to the file) of the certificate file as `os_cacert` parameter, and use {get_param: os_cacert}.","commit_id":"6ba1d08c726cdaed5c6913c855eb8de76dde7f9d"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"85d763f3263d311e27a21728ddc94117f86c2c8c","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            $os_project: {get_param: os_project}"},{"line_number":156,"context_line":"            $os__user_domain: {get_param: os_user_domain}"},{"line_number":157,"context_line":"            $os__project_domain: {get_param: os_project_domain}"},{"line_number":158,"context_line":"            $os_cacert: {get_file: /etc/pki/ca-trust/source/anchors/simpleca.crt}"},{"line_number":159,"context_line":"            $bm_node_count: {get_param: node_count}"},{"line_number":160,"context_line":"            $bmc_prefix: {get_param: bmc_prefix}"},{"line_number":161,"context_line":"            $bmc_utility: {get_attr: [bmc_port, ip_address]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dbe6f919_57850e10","line":158,"range":{"start_line":158,"start_character":35,"end_line":158,"end_character":81},"in_reply_to":"7ba52936_7127aa3a","updated":"2022-08-04 10:15:24.000000000","message":"Done","commit_id":"6ba1d08c726cdaed5c6913c855eb8de76dde7f9d"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"72464cff5b2a95a13ed18ca520560a4d70b72ba1","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            $os_project: {get_param: os_project}"},{"line_number":156,"context_line":"            $os__user_domain: {get_param: os_user_domain}"},{"line_number":157,"context_line":"            $os__project_domain: {get_param: os_project_domain}"},{"line_number":158,"context_line":"            $os_cacert: {get_file: /etc/pki/ca-trust/source/anchors/simpleca.crt}"},{"line_number":159,"context_line":"            $bm_node_count: {get_param: node_count}"},{"line_number":160,"context_line":"            $bmc_prefix: {get_param: bmc_prefix}"},{"line_number":161,"context_line":"            $bmc_utility: {get_attr: [bmc_port, ip_address]}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1ac7b1b1_6655d6c7","line":158,"range":{"start_line":158,"start_character":35,"end_line":158,"end_character":81},"in_reply_to":"dbe6f919_57850e10","updated":"2022-08-05 07:16:02.000000000","message":"thnks for writing here... makes reviewing the latest version easier ;)","commit_id":"6ba1d08c726cdaed5c6913c855eb8de76dde7f9d"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6476ad534ef1abcd2a2be43775f72e6746f161b5","unresolved":true,"context_lines":[{"line_number":165,"context_line":"            $openstackbmc_script: {get_file: ../bin/openstackbmc}"},{"line_number":166,"context_line":"            $cloud_data: {get_param: cloud_data}"},{"line_number":167,"context_line":"            $signal_command: {get_attr: [bmc_handle, curl_cli]}"},{"line_number":168,"context_line":"          template:"},{"line_number":169,"context_line":"            - {get_file: ../bin/install_openstackbmc.sh}"},{"line_number":170,"context_line":"            - {get_file: /etc/pki/ca-trust/source/anchors/simpleca.crt}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"603d7cbe_768f992d","line":170,"range":{"start_line":168,"start_character":0,"end_line":170,"end_character":71},"updated":"2022-08-02 14:14:15.000000000","message":"Template cannot be a list, this need to be:\n  template: {get_file: ../bin/install_openstackbmc.sh}","commit_id":"6ba1d08c726cdaed5c6913c855eb8de76dde7f9d"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"85d763f3263d311e27a21728ddc94117f86c2c8c","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            $openstackbmc_script: {get_file: ../bin/openstackbmc}"},{"line_number":166,"context_line":"            $cloud_data: {get_param: cloud_data}"},{"line_number":167,"context_line":"            $signal_command: {get_attr: [bmc_handle, curl_cli]}"},{"line_number":168,"context_line":"          template:"},{"line_number":169,"context_line":"            - {get_file: ../bin/install_openstackbmc.sh}"},{"line_number":170,"context_line":"            - {get_file: /etc/pki/ca-trust/source/anchors/simpleca.crt}"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dbd67fb4_11f039ef","line":170,"range":{"start_line":168,"start_character":0,"end_line":170,"end_character":71},"in_reply_to":"603d7cbe_768f992d","updated":"2022-08-04 10:15:24.000000000","message":"Done","commit_id":"6ba1d08c726cdaed5c6913c855eb8de76dde7f9d"}]}