)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22119,"name":"Dmitriy Stremkovskiy","display_name":"Dzmitry Stremkouski","email":"dstremkouski@mirantis.com","username":"dstremkouski"},"change_message_id":"9eb490ef41c857629f8695ec54ee361bd57c2035","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eef2e59d_413c5dde","updated":"2022-09-23 09:02:38.000000000","message":"Hello, team. Please review my patch, if possible.\n\nI don\u0027t think RDO test is valid. It fails because of atop absense and broken cache.","commit_id":"002b2d201be43dcb85cc828dc7b6823191e157b7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"d57e8316441a347319f28aad8a5a0989843799e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"11558930_e61fb888","updated":"2022-09-26 20:33:42.000000000","message":"The CI jobs failed, but much later and unrelated to the bmc behaviour, the bmc logs show it is working as expected:\n\nhttps://logserver.rdoproject.org/57/858357/2/openstack-check/tripleo-ci-centos-9-ovb-3ctlr_1comp-featureset001-ovb-master/ae34374/logs/bmc_2_21776-console.log","commit_id":"002b2d201be43dcb85cc828dc7b6823191e157b7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"53abb40d9f389cbf2ed843742ee38084c7549581","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1adbcfce_b06d012b","updated":"2022-09-26 07:28:59.000000000","message":"check-rdo","commit_id":"002b2d201be43dcb85cc828dc7b6823191e157b7"},{"author":{"_account_id":22119,"name":"Dmitriy Stremkovskiy","display_name":"Dzmitry Stremkouski","email":"dstremkouski@mirantis.com","username":"dstremkouski"},"change_message_id":"e113234fbb6f954934868f6af55aec5322aafac8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"61147af4_b62434c2","updated":"2022-09-22 12:30:28.000000000","message":"check-rdo","commit_id":"002b2d201be43dcb85cc828dc7b6823191e157b7"}],"openstack_virtual_baremetal/openstackbmc.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0ba2de2c740906d9fb19d7e424b5fa735983ca8f","unresolved":true,"context_lines":[{"line_number":206,"context_line":"                        help\u003d\u0027Port to listen on; defaults to 623\u0027)"},{"line_number":207,"context_line":"    parser.add_argument(\u0027--address\u0027,"},{"line_number":208,"context_line":"                        dest\u003d\u0027address\u0027,"},{"line_number":209,"context_line":"                        default\u003dos.environ.get(\u0027BMC_ADDRESS\u0027, \u0027::\u0027),"},{"line_number":210,"context_line":"                        help\u003d\u0027Address to bind to; defaults to ::\u0027)"},{"line_number":211,"context_line":"    parser.add_argument(\u0027--instance\u0027,"},{"line_number":212,"context_line":"                        dest\u003d\u0027instance\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"04d3118a_93b3b8b1","line":209,"range":{"start_line":209,"start_character":32,"end_line":209,"end_character":67},"updated":"2022-09-23 17:35:50.000000000","message":"How does this work when there are multiple virtual baremetal instances?\nIn this case the bmc instance created by OVB listen on a separate IP address per virtual baremetal node[1].\n\nIf you where to use the environment variables like this it can only work with one instance?\n\n\n[1] https://opendev.org/openstack/openstack-virtual-baremetal/src/branch/master/bin/install_openstackbmc.sh#L154","commit_id":"002b2d201be43dcb85cc828dc7b6823191e157b7"},{"author":{"_account_id":22119,"name":"Dmitriy Stremkovskiy","display_name":"Dzmitry Stremkouski","email":"dstremkouski@mirantis.com","username":"dstremkouski"},"change_message_id":"d7a0d18bac13bafb77ba9d056229dca2d10f07fe","unresolved":true,"context_lines":[{"line_number":206,"context_line":"                        help\u003d\u0027Port to listen on; defaults to 623\u0027)"},{"line_number":207,"context_line":"    parser.add_argument(\u0027--address\u0027,"},{"line_number":208,"context_line":"                        dest\u003d\u0027address\u0027,"},{"line_number":209,"context_line":"                        default\u003dos.environ.get(\u0027BMC_ADDRESS\u0027, \u0027::\u0027),"},{"line_number":210,"context_line":"                        help\u003d\u0027Address to bind to; defaults to ::\u0027)"},{"line_number":211,"context_line":"    parser.add_argument(\u0027--instance\u0027,"},{"line_number":212,"context_line":"                        dest\u003d\u0027instance\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"638c0ed1_256b975b","line":209,"range":{"start_line":209,"start_character":32,"end_line":209,"end_character":67},"in_reply_to":"04d3118a_93b3b8b1","updated":"2022-09-23 20:48:36.000000000","message":"This script is intended to control only one instance at once. It means if you want to control multiple instances you are to execute this script that amount of times. The only thing I change is an another way to set up same options script had before.","commit_id":"002b2d201be43dcb85cc828dc7b6823191e157b7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"d57e8316441a347319f28aad8a5a0989843799e1","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                        help\u003d\u0027Port to listen on; defaults to 623\u0027)"},{"line_number":207,"context_line":"    parser.add_argument(\u0027--address\u0027,"},{"line_number":208,"context_line":"                        dest\u003d\u0027address\u0027,"},{"line_number":209,"context_line":"                        default\u003dos.environ.get(\u0027BMC_ADDRESS\u0027, \u0027::\u0027),"},{"line_number":210,"context_line":"                        help\u003d\u0027Address to bind to; defaults to ::\u0027)"},{"line_number":211,"context_line":"    parser.add_argument(\u0027--instance\u0027,"},{"line_number":212,"context_line":"                        dest\u003d\u0027instance\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"673d8b11_bafaeafb","line":209,"range":{"start_line":209,"start_character":32,"end_line":209,"end_character":67},"in_reply_to":"1c1fe456_2898bfb6","updated":"2022-09-26 20:33:42.000000000","message":"install_openstackbmc.sh writes out systemd units per instance, so Environment or EnvironmentFile directives could be used in the unit to specify per-instance BMC_USER, BMC_PASSWORD","commit_id":"002b2d201be43dcb85cc828dc7b6823191e157b7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"18420b603afb2cbebf3f256f3990739b34034ec5","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                        help\u003d\u0027Port to listen on; defaults to 623\u0027)"},{"line_number":207,"context_line":"    parser.add_argument(\u0027--address\u0027,"},{"line_number":208,"context_line":"                        dest\u003d\u0027address\u0027,"},{"line_number":209,"context_line":"                        default\u003dos.environ.get(\u0027BMC_ADDRESS\u0027, \u0027::\u0027),"},{"line_number":210,"context_line":"                        help\u003d\u0027Address to bind to; defaults to ::\u0027)"},{"line_number":211,"context_line":"    parser.add_argument(\u0027--instance\u0027,"},{"line_number":212,"context_line":"                        dest\u003d\u0027instance\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1c1fe456_2898bfb6","line":209,"range":{"start_line":209,"start_character":32,"end_line":209,"end_character":67},"in_reply_to":"638c0ed1_256b975b","updated":"2022-09-26 07:28:33.000000000","message":"As a standalone script yes. I was thinking in the context of potential follow up changes to use environment vars in the install_openstackbmc.sh script as well. I understand you may be using this in a different context, where install_openstackbmc.sh is not involved.","commit_id":"002b2d201be43dcb85cc828dc7b6823191e157b7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0ba2de2c740906d9fb19d7e424b5fa735983ca8f","unresolved":true,"context_lines":[{"line_number":210,"context_line":"                        help\u003d\u0027Address to bind to; defaults to ::\u0027)"},{"line_number":211,"context_line":"    parser.add_argument(\u0027--instance\u0027,"},{"line_number":212,"context_line":"                        dest\u003d\u0027instance\u0027,"},{"line_number":213,"context_line":"                        default\u003dos.environ.get(\u0027INSTANCE_ID\u0027),"},{"line_number":214,"context_line":"                        help\u003d\u0027The uuid or name of the OpenStack instance \u0027"},{"line_number":215,"context_line":"                        \u0027to manage\u0027)"},{"line_number":216,"context_line":"    parser.add_argument(\u0027--cache-status\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"650d6321_6daf12e8","line":213,"range":{"start_line":213,"start_character":32,"end_line":213,"end_character":61},"updated":"2022-09-23 17:35:50.000000000","message":"Same as above, I don\u0027t understand how using the environment like this would work when the bmc node is hosting virtual BMC\u0027s for multiple instances.\n\n\n[1] https://opendev.org/openstack/openstack-virtual-baremetal/src/branch/master/bin/install_openstackbmc.sh#L149-L152","commit_id":"002b2d201be43dcb85cc828dc7b6823191e157b7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"18420b603afb2cbebf3f256f3990739b34034ec5","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                        help\u003d\u0027Address to bind to; defaults to ::\u0027)"},{"line_number":211,"context_line":"    parser.add_argument(\u0027--instance\u0027,"},{"line_number":212,"context_line":"                        dest\u003d\u0027instance\u0027,"},{"line_number":213,"context_line":"                        default\u003dos.environ.get(\u0027INSTANCE_ID\u0027),"},{"line_number":214,"context_line":"                        help\u003d\u0027The uuid or name of the OpenStack instance \u0027"},{"line_number":215,"context_line":"                        \u0027to manage\u0027)"},{"line_number":216,"context_line":"    parser.add_argument(\u0027--cache-status\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"0a77646e_a2e08431","line":213,"range":{"start_line":213,"start_character":32,"end_line":213,"end_character":61},"in_reply_to":"05166f9e_b1439180","updated":"2022-09-26 07:28:33.000000000","message":"Done","commit_id":"002b2d201be43dcb85cc828dc7b6823191e157b7"},{"author":{"_account_id":22119,"name":"Dmitriy Stremkovskiy","display_name":"Dzmitry Stremkouski","email":"dstremkouski@mirantis.com","username":"dstremkouski"},"change_message_id":"d7a0d18bac13bafb77ba9d056229dca2d10f07fe","unresolved":true,"context_lines":[{"line_number":210,"context_line":"                        help\u003d\u0027Address to bind to; defaults to ::\u0027)"},{"line_number":211,"context_line":"    parser.add_argument(\u0027--instance\u0027,"},{"line_number":212,"context_line":"                        dest\u003d\u0027instance\u0027,"},{"line_number":213,"context_line":"                        default\u003dos.environ.get(\u0027INSTANCE_ID\u0027),"},{"line_number":214,"context_line":"                        help\u003d\u0027The uuid or name of the OpenStack instance \u0027"},{"line_number":215,"context_line":"                        \u0027to manage\u0027)"},{"line_number":216,"context_line":"    parser.add_argument(\u0027--cache-status\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"05166f9e_b1439180","line":213,"range":{"start_line":213,"start_character":32,"end_line":213,"end_character":61},"in_reply_to":"650d6321_6daf12e8","updated":"2022-09-23 20:48:36.000000000","message":"Ditto ^","commit_id":"002b2d201be43dcb85cc828dc7b6823191e157b7"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"0ba2de2c740906d9fb19d7e424b5fa735983ca8f","unresolved":true,"context_lines":[{"line_number":232,"context_line":"    addr_format \u003d \u0027%s\u0027"},{"line_number":233,"context_line":"    if \u0027:\u0027 not in args.address:"},{"line_number":234,"context_line":"        addr_format \u003d \u0027::ffff:%s\u0027"},{"line_number":235,"context_line":"    mybmc \u003d OpenStackBmc({args.bmcuser: args.bmcpass}, port\u003dargs.port,"},{"line_number":236,"context_line":"                         address\u003daddr_format % args.address,"},{"line_number":237,"context_line":"                         instance\u003dargs.instance,"},{"line_number":238,"context_line":"                         cache_status\u003dargs.cache_status,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e138f86e_80506503","line":235,"range":{"start_line":235,"start_character":25,"end_line":235,"end_character":53},"updated":"2022-09-23 17:35:50.000000000","message":"This bit looks ok.\nYou may want to add unit tests.","commit_id":"002b2d201be43dcb85cc828dc7b6823191e157b7"}]}