)]}'
{"roles/prepare-docs-for-afs/tasks/branch.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"498487af08f8c7e46f93239ec8dc1943a43c483a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  # accessible under the developer docs root using the branch name."},{"line_number":7,"context_line":"  # EG: feature/foo or milestone-proposed"},{"line_number":8,"context_line":"  shell: |"},{"line_number":9,"context_line":"    mv doc/build/html doc/build/tmp"},{"line_number":10,"context_line":"    mkdir -p doc/build/html/{{ zuul.branch | dirname }}"},{"line_number":11,"context_line":"    mv doc/build/tmp doc/build/html/{{ zuul.branch }}"},{"line_number":12,"context_line":"  tags: skip_ansible_lint"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f287b81_10280832","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":35},"updated":"2017-09-05 20:00:39.000000000","message":"Can this step be avoided if we mkdir -p first then just move directly into the branch name destination?","commit_id":"0223973da23f7c4d218682b557bc526f5c1614e2"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"6654a6c46846627ef118da0f24c28eaf4caf2fc4","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  # accessible under the developer docs root using the branch name."},{"line_number":7,"context_line":"  # EG: feature/foo or milestone-proposed"},{"line_number":8,"context_line":"  shell: |"},{"line_number":9,"context_line":"    mv doc/build/html doc/build/tmp"},{"line_number":10,"context_line":"    mkdir -p doc/build/html/{{ zuul.branch | dirname }}"},{"line_number":11,"context_line":"    mv doc/build/tmp doc/build/html/{{ zuul.branch }}"},{"line_number":12,"context_line":"  tags: skip_ansible_lint"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f287b81_9059985b","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":35},"in_reply_to":"7f287b81_10280832","updated":"2017-09-05 20:09:19.000000000","message":"The new dir is a subdir of html, so you\u0027d have the whole \"can\u0027t move a file to a subdirectory of itself issue\"\n\nWe could break it up a little more though:\n\n  set_fact:\n    new_dir: \"doc/build/html/{{ zuul.branch | basename }}\"\n  command: mv doc/build/html doc/build/tmp\n  file:\n    dest: \"{{ new_dir }}\"\n    state: directory\n  command: \"mv doc/build/tmp doc/build/html/{{ new_dir }}\"","commit_id":"0223973da23f7c4d218682b557bc526f5c1614e2"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"9864ff930d44cb544079fc8e5ba362f94d361ea7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  # accessible under the developer docs root using the branch name."},{"line_number":7,"context_line":"  # EG: feature/foo or milestone-proposed"},{"line_number":8,"context_line":"  shell: |"},{"line_number":9,"context_line":"    mv doc/build/html doc/build/tmp"},{"line_number":10,"context_line":"    mkdir -p doc/build/html/{{ zuul.branch | dirname }}"},{"line_number":11,"context_line":"    mv doc/build/tmp doc/build/html/{{ zuul.branch }}"},{"line_number":12,"context_line":"  tags: skip_ansible_lint"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f287b81_9092b8f5","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":35},"in_reply_to":"7f287b81_10280832","updated":"2017-09-05 20:05:34.000000000","message":"Ya, likely. This is copypasta from how it works today. In fact, I\u0027d like to change this logic to use ansible tasks over shell","commit_id":"0223973da23f7c4d218682b557bc526f5c1614e2"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"d9637dbb7bec31a7bae81432ff1b8f447dafee0a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  # accessible under the developer docs root using the branch name."},{"line_number":7,"context_line":"  # EG: feature/foo or milestone-proposed"},{"line_number":8,"context_line":"  shell: |"},{"line_number":9,"context_line":"    mv doc/build/html doc/build/tmp"},{"line_number":10,"context_line":"    mkdir -p doc/build/html/{{ zuul.branch | dirname }}"},{"line_number":11,"context_line":"    mv doc/build/tmp doc/build/html/{{ zuul.branch }}"},{"line_number":12,"context_line":"  tags: skip_ansible_lint"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f287b81_59e91b18","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":35},"in_reply_to":"7f287b81_9059985b","updated":"2017-09-05 21:36:36.000000000","message":"I\u0027m going to do the ansiblify code in a follow up patch.","commit_id":"0223973da23f7c4d218682b557bc526f5c1614e2"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"6654a6c46846627ef118da0f24c28eaf4caf2fc4","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  shell: |"},{"line_number":9,"context_line":"    mv doc/build/html doc/build/tmp"},{"line_number":10,"context_line":"    mkdir -p doc/build/html/{{ zuul.branch | dirname }}"},{"line_number":11,"context_line":"    mv doc/build/tmp doc/build/html/{{ zuul.branch }}"},{"line_number":12,"context_line":"  tags: skip_ansible_lint"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f287b81_d024c0c8","line":11,"updated":"2017-09-05 20:09:19.000000000","message":"Whoops - this needs a | basename","commit_id":"0223973da23f7c4d218682b557bc526f5c1614e2"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"d9637dbb7bec31a7bae81432ff1b8f447dafee0a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  shell: |"},{"line_number":9,"context_line":"    mv doc/build/html doc/build/tmp"},{"line_number":10,"context_line":"    mkdir -p doc/build/html/{{ zuul.branch | dirname }}"},{"line_number":11,"context_line":"    mv doc/build/tmp doc/build/html/{{ zuul.branch }}"},{"line_number":12,"context_line":"  tags: skip_ansible_lint"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f287b81_f980c748","line":11,"in_reply_to":"7f287b81_d024c0c8","updated":"2017-09-05 21:36:36.000000000","message":"Fixed","commit_id":"0223973da23f7c4d218682b557bc526f5c1614e2"}],"roles/prepare-docs-for-afs/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"498487af08f8c7e46f93239ec8dc1943a43c483a","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Process tagged build"},{"line_number":7,"context_line":"  include: tagged.yaml"},{"line_number":8,"context_line":"  when: \"zuul.branch !\u003d \u0027master\u0027 and zuul.tag is defined\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Process stable branch build"},{"line_number":11,"context_line":"  include: stable.yaml"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f287b81_50bc50db","line":8,"range":{"start_line":8,"start_character":8,"end_line":8,"end_character":57},"updated":"2017-09-05 20:00:39.000000000","message":"What happens when the branch is master and the tag is defined?\n\nReading below we don\u0027t handle the case of master at all? Pretty sure that branch.yaml should handle \u0027master\u0027 as well? I seem to recall we published to / and /master.","commit_id":"0223973da23f7c4d218682b557bc526f5c1614e2"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"9864ff930d44cb544079fc8e5ba362f94d361ea7","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Process tagged build"},{"line_number":7,"context_line":"  include: tagged.yaml"},{"line_number":8,"context_line":"  when: \"zuul.branch !\u003d \u0027master\u0027 and zuul.tag is defined\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Process stable branch build"},{"line_number":11,"context_line":"  include: stable.yaml"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f287b81_f0ba1c6c","line":8,"range":{"start_line":8,"start_character":8,"end_line":8,"end_character":57},"in_reply_to":"7f287b81_50bc50db","updated":"2017-09-05 20:05:34.000000000","message":"So, if master, we don\u0027t rename anything we just take the docs from html folder and publish to executor\n\nI\u0027m not sure branch master and zuul.tag will ever happen, but need to look more","commit_id":"0223973da23f7c4d218682b557bc526f5c1614e2"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"498487af08f8c7e46f93239ec8dc1943a43c483a","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Process stable branch build"},{"line_number":11,"context_line":"  include: stable.yaml"},{"line_number":12,"context_line":"  when: \"\u0027stable\u0027 in zuul.branch and zuul.tag is not defined\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Process branch build"},{"line_number":15,"context_line":"  include: branch.yaml"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f287b81_100ec88c","line":12,"range":{"start_line":12,"start_character":37,"end_line":12,"end_character":60},"updated":"2017-09-05 20:00:39.000000000","message":"I think this check (and the one below) should be for zuul.tag is not defined and we are not tag only? Since if tag only we shouldn\u0027t execute this or the one below.","commit_id":"0223973da23f7c4d218682b557bc526f5c1614e2"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"9864ff930d44cb544079fc8e5ba362f94d361ea7","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Process stable branch build"},{"line_number":11,"context_line":"  include: stable.yaml"},{"line_number":12,"context_line":"  when: \"\u0027stable\u0027 in zuul.branch and zuul.tag is not defined\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Process branch build"},{"line_number":15,"context_line":"  include: branch.yaml"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f287b81_5063301b","line":12,"range":{"start_line":12,"start_character":37,"end_line":12,"end_character":60},"in_reply_to":"7f287b81_100ec88c","updated":"2017-09-05 20:05:34.000000000","message":"Ya, we likely can clean this up","commit_id":"0223973da23f7c4d218682b557bc526f5c1614e2"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"5f4cd114cd95f0f5f421c1ca56f3e3f55128efa3","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Process stable branch build"},{"line_number":11,"context_line":"  include: stable.yaml"},{"line_number":12,"context_line":"  when: \"\u0027stable\u0027 in zuul.branch and zuul.tag is not defined\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- name: Process branch build"},{"line_number":15,"context_line":"  include: branch.yaml"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f287b81_d3c5ea8f","line":12,"range":{"start_line":12,"start_character":37,"end_line":12,"end_character":60},"in_reply_to":"7f287b81_100ec88c","updated":"2017-09-05 20:17:55.000000000","message":"tag-only logic is handled in: roles/prepare-docs-for-afs/tasks/tagged.yaml which is how it\u0027s done in the existing shell. (was trying to keep as much logical symmetry as possible)","commit_id":"0223973da23f7c4d218682b557bc526f5c1614e2"}],"roles/prepare-docs-for-afs/tasks/tagged.yaml":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"3f030bbe461c0d2ec4f2777d12d96df114dc88b9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  register: latest"},{"line_number":12,"context_line":"  tags: skip_ansible_lint"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Put tagged releases in proper location. All tagged builds get copied to"},{"line_number":15,"context_line":"# BUILD_DIR/tagname. If this is the latest tagged release the copy of files"},{"line_number":16,"context_line":"# at BUILD_DIR remains. When Zuul copies this file the root developer"},{"line_number":17,"context_line":"# docs are always the latest release with older tags available under the"},{"line_number":18,"context_line":"# root in the tagname dir."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Process tags only builds when the tag is the latest tag"},{"line_number":21,"context_line":"  args:"},{"line_number":22,"context_line":"    chdir: \"{{ zuul_work_dir }}\""},{"line_number":23,"context_line":"  # Now publish to / and /$TAG if this is the latest version for projects"},{"line_number":24,"context_line":"  # and we are only publishing from the release pipeline,"},{"line_number":25,"context_line":"  # or just /$TAG otherwise."},{"line_number":26,"context_line":"  shell: |"},{"line_number":27,"context_line":"    # Copy the docs into a subdir if this is a tagged build"},{"line_number":28,"context_line":"    mkdir doc/build/{{ zuul.tag }}"},{"line_number":29,"context_line":"    cp -R doc/build/html/. doc/build/{{ zuul.tag }}"},{"line_number":30,"context_line":"    mv doc/build/{{ zuul.tag }} doc/build/html/{{ zuul.tag }}"},{"line_number":31,"context_line":"  when: \"doc_build_tags_only and zuul.tag \u003d\u003d latest.stdout|replace(\u0027\\n\u0027, \u0027\u0027)\""},{"line_number":32,"context_line":"  register: tags_only"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Process tags for non tags-only builds or non-latest tags"},{"line_number":35,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f287b81_e4dc9a75","line":32,"range":{"start_line":14,"start_character":0,"end_line":32,"end_character":21},"updated":"2017-09-05 22:17:55.000000000","message":"we can drop the branching logic here. This is the behavior we want for tags in infra.","commit_id":"5e87f85d1f2760f6b9f97b572ead52102ef2165c"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"3f030bbe461c0d2ec4f2777d12d96df114dc88b9","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  when: \"doc_build_tags_only and zuul.tag \u003d\u003d latest.stdout|replace(\u0027\\n\u0027, \u0027\u0027)\""},{"line_number":32,"context_line":"  register: tags_only"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Process tags for non tags-only builds or non-latest tags"},{"line_number":35,"context_line":"  args:"},{"line_number":36,"context_line":"    chdir: \"{{ zuul_work_dir }}\""},{"line_number":37,"context_line":"  shell: |"},{"line_number":38,"context_line":"      # Move the docs into a subdir if this is a tagged build"},{"line_number":39,"context_line":"      mv doc/build/html doc/build/tmp"},{"line_number":40,"context_line":"      mkdir doc/build/html"},{"line_number":41,"context_line":"      mv doc/build/tmp doc/build/html/{{ zuul.tag }}"},{"line_number":42,"context_line":"  when: not tags_only.skipped"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7f287b81_4487ee62","line":42,"range":{"start_line":34,"start_character":0,"end_line":42,"end_character":29},"updated":"2017-09-05 22:17:55.000000000","message":"I think we can get rid of this section.","commit_id":"5e87f85d1f2760f6b9f97b572ead52102ef2165c"}]}
