)]}'
{"playbooks/tox-docs/pre.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9b0e971834b17daf680ea5beb0db6190ed64e026","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  roles:"},{"line_number":3,"context_line":"    - role: prepare-build-pdf-docs"},{"line_number":4,"context_line":"      when: not tox_skip_pdf"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"7faddb67_60531518","line":4,"updated":"2019-08-23 15:31:35.000000000","message":"Do we need to check if tox_skip_pdf is defined too? I Guess if all jobs that use this playbook parent to openstack-tox-docs we should be fine.","commit_id":"bba1a617eefff6f7f2f34c1ea6154816233dc627"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"98121f56586c80f271b021a35cc5f6d584be7c9f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- hosts: all"},{"line_number":2,"context_line":"  roles:"},{"line_number":3,"context_line":"    - role: prepare-build-pdf-docs"},{"line_number":4,"context_line":"      when: not tox_skip_pdf"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"7faddb67_c077699f","line":4,"in_reply_to":"7faddb67_60531518","updated":"2019-08-23 15:33:17.000000000","message":"so far only openstack-tox-docs uses it.","commit_id":"bba1a617eefff6f7f2f34c1ea6154816233dc627"}],"playbooks/tox-docs/run.yaml":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"3a9cdba82cb24e666ed74ec62c9b5fc3031d71a4","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    - revoke-sudo"},{"line_number":4,"context_line":"    - role: tox"},{"line_number":5,"context_line":"      vars:"},{"line_number":6,"context_line":"        tox_envlist: docs"},{"line_number":7,"context_line":"    - build-pdf-docs"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7faddb67_1b2f3e89","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":25},"updated":"2019-08-23 08:33:26.000000000","message":"This doesn\u0027t seem dynamic or anything, thus the question in .zuul.yaml","commit_id":"63700707dfe43285478c18659de51ff0bc16f82d"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"8b0a47ef5a9ab5c12c9b98b89db8842998308b9b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    - revoke-sudo"},{"line_number":4,"context_line":"    - role: tox"},{"line_number":5,"context_line":"      vars:"},{"line_number":6,"context_line":"        tox_envlist: docs"},{"line_number":7,"context_line":"    - build-pdf-docs"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7faddb67_5be056f9","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":25},"in_reply_to":"7faddb67_1b2f3e89","updated":"2019-08-23 08:58:09.000000000","message":"I think we can move it back...","commit_id":"63700707dfe43285478c18659de51ff0bc16f82d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ae24cd70ab5d3b96ca43ea691fda7058c4ea04a4","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    - revoke-sudo"},{"line_number":4,"context_line":"    - role: tox"},{"line_number":5,"context_line":"      vars:"},{"line_number":6,"context_line":"        tox_envlist: docs"},{"line_number":7,"context_line":"    - build-pdf-docs"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7faddb67_7be3d2d9","line":6,"range":{"start_line":6,"start_character":8,"end_line":6,"end_character":25},"in_reply_to":"7faddb67_5be056f9","updated":"2019-08-23 09:08:02.000000000","message":"The reason I moved it from .zuul.yaml is as build-pdf-docs role imports \"tox\u0027 role internally and I am not sure what happens when we pass tox_envlist as the job level in .zuu.yaml.\n\nPerhaps it is just because I don\u0027t know the full order of value evaluation....","commit_id":"63700707dfe43285478c18659de51ff0bc16f82d"}],"roles/build-pdf-docs/README.rst":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"3a9cdba82cb24e666ed74ec62c9b5fc3031d71a4","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"**Role Variables**"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":".. zuul:rolevar:: pdf_tox_env"},{"line_number":9,"context_line":"   :default: pdfdocs"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"   tox environment used for PDF doc build."}],"source_content_type":"text/x-rst","patch_set":18,"id":"7faddb67_fb5fc20c","line":8,"range":{"start_line":8,"start_character":18,"end_line":8,"end_character":29},"updated":"2019-08-23 08:33:26.000000000","message":"Maybe this should be called tox_pdf_env instead to match the other tox-related vars?","commit_id":"63700707dfe43285478c18659de51ff0bc16f82d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ae24cd70ab5d3b96ca43ea691fda7058c4ea04a4","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"**Role Variables**"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":".. zuul:rolevar:: pdf_tox_env"},{"line_number":9,"context_line":"   :default: pdfdocs"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"   tox environment used for PDF doc build."}],"source_content_type":"text/x-rst","patch_set":18,"id":"7faddb67_9be80eb4","line":8,"range":{"start_line":8,"start_character":18,"end_line":8,"end_character":29},"in_reply_to":"7faddb67_fb5fc20c","updated":"2019-08-23 09:08:02.000000000","message":"sounds reasonable","commit_id":"63700707dfe43285478c18659de51ff0bc16f82d"}],"roles/build-pdf-docs/tasks/main.yaml":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"eacbbe2c6927b6098adfa63068e90fab29e19a0c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    name: \"{{ item }}\""},{"line_number":4,"context_line":"    state: present"},{"line_number":5,"context_line":"  become: yes"},{"line_number":6,"context_line":"  with_items:"},{"line_number":7,"context_line":"    - latexmk"},{"line_number":8,"context_line":"    - texlive-xelatex"},{"line_number":9,"context_line":"    - xindy"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Run sphinx-build"},{"line_number":12,"context_line":"  shell:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_b2a55d49","line":9,"range":{"start_line":6,"start_character":0,"end_line":9,"end_character":11},"updated":"2019-06-11 16:04:57.000000000","message":"I would move this into a variable, and you can pass `package` a list (which will make it a single transaction, instead of 3 seperate package installs)","commit_id":"d275e9bacb4f21fdc520c823e324fc9fe34bbf6e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"41a1dc3a2df2a56959e0c60b1efe65e657d8f92f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    name: \"{{ item }}\""},{"line_number":4,"context_line":"    state: present"},{"line_number":5,"context_line":"  become: yes"},{"line_number":6,"context_line":"  with_items:"},{"line_number":7,"context_line":"    - latexmk"},{"line_number":8,"context_line":"    - texlive-xelatex"},{"line_number":9,"context_line":"    - xindy"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Run sphinx-build"},{"line_number":12,"context_line":"  shell:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_7dea28d8","line":9,"range":{"start_line":6,"start_character":0,"end_line":9,"end_character":11},"in_reply_to":"9fb8cfa7_a700af02","updated":"2019-06-13 15:34:08.000000000","message":"Done","commit_id":"d275e9bacb4f21fdc520c823e324fc9fe34bbf6e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1e849dae4fc4f9284096f48fe9fd14d31d1041da","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    name: \"{{ item }}\""},{"line_number":4,"context_line":"    state: present"},{"line_number":5,"context_line":"  become: yes"},{"line_number":6,"context_line":"  with_items:"},{"line_number":7,"context_line":"    - latexmk"},{"line_number":8,"context_line":"    - texlive-xelatex"},{"line_number":9,"context_line":"    - xindy"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Run sphinx-build"},{"line_number":12,"context_line":"  shell:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_a700af02","line":9,"range":{"start_line":6,"start_character":0,"end_line":9,"end_character":11},"in_reply_to":"9fb8cfa7_b2a55d49","updated":"2019-06-12 08:48:42.000000000","message":"Yep, this task can transform to be:\n\n- name: Install PDF prereqs\n  package:\n    name:\n      - latexmk\n      - texlive-xelatex\n      - xindy\n    state: present\n  become: yes","commit_id":"d275e9bacb4f21fdc520c823e324fc9fe34bbf6e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1293acebcbafd03aaeba257a9ca442e3f30dd2f3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    - latexmk"},{"line_number":8,"context_line":"    - texlive-xelatex"},{"line_number":9,"context_line":"    - xindy"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Run sphinx-build"},{"line_number":12,"context_line":"  shell:"},{"line_number":13,"context_line":"    executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_c78ffaca","line":10,"updated":"2019-06-11 11:03:01.000000000","message":"Do I need to log anything?","commit_id":"d275e9bacb4f21fdc520c823e324fc9fe34bbf6e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"41a1dc3a2df2a56959e0c60b1efe65e657d8f92f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    - latexmk"},{"line_number":8,"context_line":"    - texlive-xelatex"},{"line_number":9,"context_line":"    - xindy"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Run sphinx-build"},{"line_number":12,"context_line":"  shell:"},{"line_number":13,"context_line":"    executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_fdb7f8f3","line":10,"in_reply_to":"9fb8cfa7_6754f7fe","updated":"2019-06-13 15:34:08.000000000","message":"Cool","commit_id":"d275e9bacb4f21fdc520c823e324fc9fe34bbf6e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1e849dae4fc4f9284096f48fe9fd14d31d1041da","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    - latexmk"},{"line_number":8,"context_line":"    - texlive-xelatex"},{"line_number":9,"context_line":"    - xindy"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Run sphinx-build"},{"line_number":12,"context_line":"  shell:"},{"line_number":13,"context_line":"    executable: /bin/bash"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_6754f7fe","line":10,"in_reply_to":"9fb8cfa7_c78ffaca","updated":"2019-06-12 08:48:42.000000000","message":"Both stdout and stderr will be captured and published by ARA, so I don\u0027t think you need to add any specific logging.","commit_id":"d275e9bacb4f21fdc520c823e324fc9fe34bbf6e"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"30298019fe755d3b667c78e1973607e93304244b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- name: Run sphinx-build"},{"line_number":12,"context_line":"  shell:"},{"line_number":13,"context_line":"    executable: /bin/bash"},{"line_number":14,"context_line":"    cmd: |"},{"line_number":15,"context_line":"      # Source the tox virtualenv activate file so that sphinx commands have"},{"line_number":16,"context_line":"      # the dependencies already installed."},{"line_number":17,"context_line":"      source .tox/docs/bin/activate"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_b21b1dc8","line":14,"updated":"2019-06-11 15:59:06.000000000","message":"A \"set -x\" here wouldn\u0027t hurt.","commit_id":"d275e9bacb4f21fdc520c823e324fc9fe34bbf6e"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"7bc94687f05535bab51f81ccd94c4f63a931bef3","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- name: Run sphinx-build"},{"line_number":12,"context_line":"  shell:"},{"line_number":13,"context_line":"    executable: /bin/bash"},{"line_number":14,"context_line":"    cmd: |"},{"line_number":15,"context_line":"      # Source the tox virtualenv activate file so that sphinx commands have"},{"line_number":16,"context_line":"      # the dependencies already installed."},{"line_number":17,"context_line":"      source .tox/docs/bin/activate"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_b853ea16","line":14,"in_reply_to":"9fb8cfa7_a74e6f6c","updated":"2019-06-12 12:08:22.000000000","message":"No, we definitely don’t want that. We don’t want all of the doc builds breaking on this new optional behavior.","commit_id":"d275e9bacb4f21fdc520c823e324fc9fe34bbf6e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1e849dae4fc4f9284096f48fe9fd14d31d1041da","unresolved":false,"context_lines":[{"line_number":11,"context_line":"- name: Run sphinx-build"},{"line_number":12,"context_line":"  shell:"},{"line_number":13,"context_line":"    executable: /bin/bash"},{"line_number":14,"context_line":"    cmd: |"},{"line_number":15,"context_line":"      # Source the tox virtualenv activate file so that sphinx commands have"},{"line_number":16,"context_line":"      # the dependencies already installed."},{"line_number":17,"context_line":"      source .tox/docs/bin/activate"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_a74e6f6c","line":14,"in_reply_to":"9fb8cfa7_b21b1dc8","updated":"2019-06-12 08:48:42.000000000","message":"Perhaps \u0027set -e\u0027 would be better here, to ensure that it bails out and reports the error if there\u0027s a failure in any one of the actions.","commit_id":"d275e9bacb4f21fdc520c823e324fc9fe34bbf6e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1293acebcbafd03aaeba257a9ca442e3f30dd2f3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      source .tox/docs/bin/activate"},{"line_number":18,"context_line":"      sphinx-build -W -b latex doc/source doc/build/pdf"},{"line_number":19,"context_line":"      timeout 180 make -C doc/build/pdf"},{"line_number":20,"context_line":"      cp doc/build/pdf/*.pdf doc/build/html"},{"line_number":21,"context_line":"    chdir: \"{{ zuul_work_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_2787f6b7","line":20,"updated":"2019-06-11 11:03:01.000000000","message":"Does any of this need to be parameterized? Works on my machine^H^H^H VM and maybe it\u0027s simple enough. Also, what happens in the make fails? We probably don\u0027t want to break builds for people so maybe we should wrap it but then people won\u0027t know why they\u0027re not getting PDFs","commit_id":"d275e9bacb4f21fdc520c823e324fc9fe34bbf6e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"1e849dae4fc4f9284096f48fe9fd14d31d1041da","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      # Source the tox virtualenv activate file so that sphinx commands have"},{"line_number":16,"context_line":"      # the dependencies already installed."},{"line_number":17,"context_line":"      source .tox/docs/bin/activate"},{"line_number":18,"context_line":"      sphinx-build -W -b latex doc/source doc/build/pdf"},{"line_number":19,"context_line":"      timeout 180 make -C doc/build/pdf"},{"line_number":20,"context_line":"      cp doc/build/pdf/*.pdf doc/build/html"},{"line_number":21,"context_line":"    chdir: \"{{ zuul_work_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_e73227f2","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":43},"updated":"2019-06-12 08:48:42.000000000","message":"Would it make sense to split these three script actions into a task each?\n\n1. Sphinx build\n2. Make PDFs\n3. Copy PDFs\n\nThat might make troubleshooting a little easier, although it\u0027s a fairly simple script.","commit_id":"d275e9bacb4f21fdc520c823e324fc9fe34bbf6e"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"30298019fe755d3b667c78e1973607e93304244b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"      source .tox/docs/bin/activate"},{"line_number":18,"context_line":"      sphinx-build -W -b latex doc/source doc/build/pdf"},{"line_number":19,"context_line":"      timeout 180 make -C doc/build/pdf"},{"line_number":20,"context_line":"      cp doc/build/pdf/*.pdf doc/build/html"},{"line_number":21,"context_line":"    chdir: \"{{ zuul_work_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_f26af517","line":20,"in_reply_to":"9fb8cfa7_2787f6b7","updated":"2019-06-11 15:59:06.000000000","message":"You definitely want to protect against failure in any steps in this script. Logging the output but always return success will still allow folks to look at the logs.","commit_id":"d275e9bacb4f21fdc520c823e324fc9fe34bbf6e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"41a1dc3a2df2a56959e0c60b1efe65e657d8f92f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      # Source the tox virtualenv activate file so that sphinx commands have"},{"line_number":16,"context_line":"      # the dependencies already installed."},{"line_number":17,"context_line":"      source .tox/docs/bin/activate"},{"line_number":18,"context_line":"      sphinx-build -W -b latex doc/source doc/build/pdf"},{"line_number":19,"context_line":"      timeout 180 make -C doc/build/pdf"},{"line_number":20,"context_line":"      cp doc/build/pdf/*.pdf doc/build/html"},{"line_number":21,"context_line":"    chdir: \"{{ zuul_work_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_fdacd89f","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":43},"in_reply_to":"9fb8cfa7_e73227f2","updated":"2019-06-13 15:34:08.000000000","message":"\u003e Would it make sense to split these three script actions into a task\n \u003e each?\n \u003e \n \u003e 1. Sphinx build\n \u003e 2. Make PDFs\n \u003e 3. Copy PDFs\n \u003e \n \u003e That might make troubleshooting a little easier, although it\u0027s a\n \u003e fairly simple script.\n\nPerhaps, but as Doug notes this script should eventually live elsewhere so it\u0027s probably easier keep this here for now","commit_id":"d275e9bacb4f21fdc520c823e324fc9fe34bbf6e"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"7bc94687f05535bab51f81ccd94c4f63a931bef3","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      # Source the tox virtualenv activate file so that sphinx commands have"},{"line_number":16,"context_line":"      # the dependencies already installed."},{"line_number":17,"context_line":"      source .tox/docs/bin/activate"},{"line_number":18,"context_line":"      sphinx-build -W -b latex doc/source doc/build/pdf"},{"line_number":19,"context_line":"      timeout 180 make -C doc/build/pdf"},{"line_number":20,"context_line":"      cp doc/build/pdf/*.pdf doc/build/html"},{"line_number":21,"context_line":"    chdir: \"{{ zuul_work_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_7859f232","line":20,"range":{"start_line":18,"start_character":0,"end_line":20,"end_character":43},"in_reply_to":"9fb8cfa7_e73227f2","updated":"2019-06-12 12:08:22.000000000","message":"Perhaps, although eventually we want a script on the docs theme repo so devs can run it locally.","commit_id":"d275e9bacb4f21fdc520c823e324fc9fe34bbf6e"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5ea87895832d30adb8f445994bf0b67905e89da1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Install PDF prereqs"},{"line_number":2,"context_line":"  package:"},{"line_number":3,"context_line":"    name:"},{"line_number":4,"context_line":"      - latexmk"},{"line_number":5,"context_line":"      - texlive-xelatex"},{"line_number":6,"context_line":"      - xindy"},{"line_number":7,"context_line":"      - inkscape"},{"line_number":8,"context_line":"    state: present"},{"line_number":9,"context_line":"  become: yes"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_3ca65255","line":7,"range":{"start_line":4,"start_character":0,"end_line":7,"end_character":16},"updated":"2019-06-24 11:29:38.000000000","message":"shouldn\u0027t we use here the outpuds given via ``bindep -f bindep.txt -b -l newline doc``?","commit_id":"d6ecb16c0b73345be730d17850ab4cc0fcee476b"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"43c7e650d725e3a9d109a6c9742da4ea728bf277","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      - xindy"},{"line_number":7,"context_line":"      - inkscape"},{"line_number":8,"context_line":"    state: present"},{"line_number":9,"context_line":"  become: yes"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Run sphinx-build"},{"line_number":12,"context_line":"  shell:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_bca1e248","line":9,"updated":"2019-06-24 11:29:29.000000000","message":"That\u0027s too late, sudo is not available at this point anymore.\n\nSee revoke-sudo which is removed in run.yaml: https://opendev.org/zuul/zuul-jobs/src/branch/master/playbooks/tox/run.yaml","commit_id":"d6ecb16c0b73345be730d17850ab4cc0fcee476b"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"371443244da30ed7d5852ceb90cb945a98979b3d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      - xindy"},{"line_number":7,"context_line":"      - inkscape"},{"line_number":8,"context_line":"    state: present"},{"line_number":9,"context_line":"  become: yes"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Run sphinx-build"},{"line_number":12,"context_line":"  shell:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_f0ebfb0e","line":9,"in_reply_to":"9fb8cfa7_bca1e248","updated":"2019-06-24 14:44:05.000000000","message":"We don\u0027t need this any more as there is bindep.txt in the repo root:\n\n16:42:45 - clarkb: bogdando: if the file is present in the root of the repo those packages are installed","commit_id":"d6ecb16c0b73345be730d17850ab4cc0fcee476b"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"a38f3ab086eb567adde173c039b04e04ef8fa8d1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      - xindy"},{"line_number":7,"context_line":"      - inkscape"},{"line_number":8,"context_line":"    state: present"},{"line_number":9,"context_line":"  become: yes"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Run sphinx-build"},{"line_number":12,"context_line":"  shell:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_ee477e1c","line":9,"in_reply_to":"9fb8cfa7_f0ebfb0e","updated":"2019-08-15 19:26:31.000000000","message":"This is causing my cinder WIP patch to fail, as sudo wants a password.\nhttps://review.opendev.org/#/c/676721/","commit_id":"d6ecb16c0b73345be730d17850ab4cc0fcee476b"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"43c7e650d725e3a9d109a6c9742da4ea728bf277","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    state: present"},{"line_number":9,"context_line":"  become: yes"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Run sphinx-build"},{"line_number":12,"context_line":"  shell:"},{"line_number":13,"context_line":"    executable: /bin/bash"},{"line_number":14,"context_line":"    cmd: |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_7cacca34","line":11,"updated":"2019-06-24 11:29:29.000000000","message":"Shouldn\u0027t this be only run on successful builds?","commit_id":"d6ecb16c0b73345be730d17850ab4cc0fcee476b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6bf5d015da0454c6c7503ea5a1b13a2b78c8b20a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"      sphinx-build -W -b latex doc/source doc/build/pdf"},{"line_number":20,"context_line":"      timeout 180 make -C doc/build/pdf || :"},{"line_number":21,"context_line":"      cp doc/build/pdf/*.pdf doc/build/html"},{"line_number":22,"context_line":"      set +x"},{"line_number":23,"context_line":"    chdir: \"{{ zuul_work_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_7193dfa4","line":22,"updated":"2019-06-19 04:12:41.000000000","message":"question: How we can notice a failure when PDF build fails?\nThis script always succeeds. The only way to check the result of PDF build is to check logs, but we usually check only the build status.","commit_id":"d6ecb16c0b73345be730d17850ab4cc0fcee476b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b83dcce6f69e04f67dca9df5a7293222d6ce0d63","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      cp doc/build/pdf/*.pdf doc/build/html"},{"line_number":12,"context_line":"      set +x"},{"line_number":13,"context_line":"    chdir: \"{{ zuul_work_dir }}\""},{"line_number":14,"context_line":"    ignore_errors: yes"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_8a8ec076","line":14,"updated":"2019-08-20 08:08:23.000000000","message":"I specified \u0027-e\u0027 option to bash so that the script exits with an error. It allows us to check PDF build succeeded or not easily by checking ARA report.\n\nignore_errors is used as not all repositories are not ready for PDF build. This can be improved later. For example, we can introduce a flag. The default value of the flag can start from False and then can be switched to True at some timing considering the progress of the community goal.","commit_id":"8feed6d211e98dd5b90b475a363f8ac53f7b61e5"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"8a827f19f7570e4c0ff7d48856682b01c02d6c9d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      cp doc/build/pdf/*.pdf doc/build/html"},{"line_number":12,"context_line":"      set +x"},{"line_number":13,"context_line":"    chdir: \"{{ zuul_work_dir }}\""},{"line_number":14,"context_line":"    ignore_errors: yes"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_6a3b449b","line":14,"updated":"2019-08-20 08:07:37.000000000","message":"Why do you want to ignore errors here?","commit_id":"8feed6d211e98dd5b90b475a363f8ac53f7b61e5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8f91222e03377813ffad095ec3a45c8c25520b6c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      cp doc/build/pdf/*.pdf doc/build/html"},{"line_number":12,"context_line":"      set +x"},{"line_number":13,"context_line":"    chdir: \"{{ zuul_work_dir }}\""},{"line_number":14,"context_line":"    ignore_errors: yes"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_aac13c50","line":14,"in_reply_to":"7faddb67_8a8ec076","updated":"2019-08-20 08:19:37.000000000","message":"Oops.... ignore_errors is not a module parameter but a task parameter....","commit_id":"8feed6d211e98dd5b90b475a363f8ac53f7b61e5"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"f83ee51abb71ab72abfcd92115d31073d0c26716","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      cp doc/build/pdf/*.pdf doc/build/html"},{"line_number":12,"context_line":"      set +x"},{"line_number":13,"context_line":"    chdir: \"{{ zuul_work_dir }}\""},{"line_number":14,"context_line":"    ignore_errors: yes"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_4ac8c820","line":14,"in_reply_to":"7faddb67_aac13c50","updated":"2019-08-20 08:33:11.000000000","message":"Let\u0027s make the errors configurable as you suggested.","commit_id":"8feed6d211e98dd5b90b475a363f8ac53f7b61e5"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"1152245507f1ec6196868e57a873b3359d333c48","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Run sphinx-build"},{"line_number":2,"context_line":"  shell:"},{"line_number":3,"context_line":"    executable: /bin/bash"},{"line_number":4,"context_line":"    cmd: |"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_4a4d2898","line":1,"updated":"2019-08-20 08:44:41.000000000","message":"Let\u0027s change name: \"Build PDF using sphinx-build\"","commit_id":"9de1e14fc7dd9a8e01c6ed9f6e6399cea17731dd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"04adbc88defe6157dca30ed017f7c791ac5beb3f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"      # the dependencies already installed."},{"line_number":8,"context_line":"      source .tox/docs/bin/activate"},{"line_number":9,"context_line":"      sphinx-build -W -b latex doc/source doc/build/pdf"},{"line_number":10,"context_line":"      timeout 180 make -C doc/build/pdf"},{"line_number":11,"context_line":"      cp doc/build/pdf/*.pdf doc/build/html"},{"line_number":12,"context_line":"      set +x"},{"line_number":13,"context_line":"    chdir: \"{{ zuul_work_dir }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_cc5935fd","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":17},"updated":"2019-08-20 11:48:31.000000000","message":"In case of neutron doc, the usual build takes 80~90 secs. The better timeout might be 300 sec which is three times of the usual build.","commit_id":"9de1e14fc7dd9a8e01c6ed9f6e6399cea17731dd"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9b0e971834b17daf680ea5beb0db6190ed64e026","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Check tox env for PDF build in tox.ini"},{"line_number":2,"context_line":"  shell: |"},{"line_number":3,"context_line":"    grep \u0027^\\[testenv:{{ tox_pdf_envlist }}\\]\u0027 {{ zuul_work_dir }}/tox.ini"},{"line_number":4,"context_line":"  register: pdfdocs_env"},{"line_number":5,"context_line":"  ignore_errors: yes"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"7faddb67_e03145ef","line":3,"range":{"start_line":3,"start_character":35,"end_line":3,"end_character":39},"updated":"2019-08-23 15:31:35.000000000","message":"Nit: The way this grep works we want a single env not a list of envs.","commit_id":"bba1a617eefff6f7f2f34c1ea6154816233dc627"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"98121f56586c80f271b021a35cc5f6d584be7c9f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Check tox env for PDF build in tox.ini"},{"line_number":2,"context_line":"  shell: |"},{"line_number":3,"context_line":"    grep \u0027^\\[testenv:{{ tox_pdf_envlist }}\\]\u0027 {{ zuul_work_dir }}/tox.ini"},{"line_number":4,"context_line":"  register: pdfdocs_env"},{"line_number":5,"context_line":"  ignore_errors: yes"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"7faddb67_807171ab","line":3,"range":{"start_line":3,"start_character":35,"end_line":3,"end_character":39},"in_reply_to":"7faddb67_e03145ef","updated":"2019-08-23 15:33:17.000000000","message":"Ah, yes. Should I rename or clarify anywhere?","commit_id":"bba1a617eefff6f7f2f34c1ea6154816233dc627"}],"roles/prepare-build-pdf-docs/README.rst":[{"author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"change_message_id":"0f6d5a0d6938491f1959bc7fa4caf36c72e42087","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Install binary packages for :zuul:role:`build-pdf-docs`."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This role currently only supports Ubuntu Bionic."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"If the tox environment specified in :zuul:rolevar:`tox_pdf_envlist`"},{"line_number":8,"context_line":"does not exist, package installation will be skipped."}],"source_content_type":"text/x-rst","patch_set":21,"id":"7faddb67_6f10e85a","line":5,"updated":"2019-08-23 14:00:53.000000000","message":"I thought Stephen said he got this working on Fedora too?","commit_id":"59b2b1ee6f664f6918f96aad91a7de5a932143f8"}],"roles/prepare-build-pdf-docs/tasks/main.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"89feeb306ee588f7c159bf36c1cadff70452945f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  package:"},{"line_number":3,"context_line":"    name:"},{"line_number":4,"context_line":"      - latexmk"},{"line_number":5,"context_line":"      - texlive-xelatex"},{"line_number":6,"context_line":"      - xindy"},{"line_number":7,"context_line":"      - inkscape"},{"line_number":8,"context_line":"    state: present"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_3914d04c","line":5,"range":{"start_line":5,"start_character":8,"end_line":5,"end_character":23},"updated":"2019-08-20 05:59:27.000000000","message":"This package is not found. It needs to be \"texlive-xetex\".","commit_id":"bcdce9d770cb1a425321a72b2472a196c411977c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7722359b78fa5fd6fe713ecdc2e327aad4161b7c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"      - latexmk"},{"line_number":5,"context_line":"      - texlive-xelatex"},{"line_number":6,"context_line":"      - xindy"},{"line_number":7,"context_line":"      - inkscape"},{"line_number":8,"context_line":"    state: present"},{"line_number":9,"context_line":"  become: yes"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_e5c1ad81","line":7,"updated":"2019-08-19 21:57:16.000000000","message":"can we add librsvg2-bin which is required for sphinxcontrib-svg2pdfconverter? It is not surprising that SVG images are used, so I think it is worth having it.","commit_id":"bcdce9d770cb1a425321a72b2472a196c411977c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b83dcce6f69e04f67dca9df5a7293222d6ce0d63","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    name:"},{"line_number":4,"context_line":"      - latexmk"},{"line_number":5,"context_line":"      - texlive-xetex"},{"line_number":6,"context_line":"      - texlive-fonts-recommended"},{"line_number":7,"context_line":"      - fonts-liberation"},{"line_number":8,"context_line":"      - xindy"},{"line_number":9,"context_line":"      - inkscape"},{"line_number":10,"context_line":"      # Required by sphinxcontrib-svg2pdfconverter to handle SVG images"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_0ac970aa","line":7,"range":{"start_line":6,"start_character":6,"end_line":7,"end_character":24},"updated":"2019-08-20 08:08:23.000000000","message":"Fonts needs to be installed explicitly. It seems \"package\" ansible module does not install recommended packages.","commit_id":"8feed6d211e98dd5b90b475a363f8ac53f7b61e5"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"3a9cdba82cb24e666ed74ec62c9b5fc3031d71a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Check tox env for PDF build in tox.ini"},{"line_number":2,"context_line":"  shell: |"},{"line_number":3,"context_line":"    grep \u0027^\\[testenv:{{ pdf_tox_env }}\\]\u0027 {{ zuul_work_dir }}/tox.ini"},{"line_number":4,"context_line":"  register: pdfdocs_env"},{"line_number":5,"context_line":"  ignore_errors: yes"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7faddb67_c9031f10","line":3,"updated":"2019-08-23 08:33:26.000000000","message":"fwiw - \u0027tox -l\u0027 lists the envs - but then I guess you\u0027d have to know tox was installed at this point - and you\u0027d still need a grep - so this is maybe better.","commit_id":"63700707dfe43285478c18659de51ff0bc16f82d"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"3a9cdba82cb24e666ed74ec62c9b5fc3031d71a4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"      - texlive-xetex"},{"line_number":12,"context_line":"      - texlive-fonts-recommended"},{"line_number":13,"context_line":"      - fonts-liberation"},{"line_number":14,"context_line":"      - inkscape"},{"line_number":15,"context_line":"      # Required by sphinxcontrib-svg2pdfconverter to handle SVG images"},{"line_number":16,"context_line":"      - librsvg2-bin"},{"line_number":17,"context_line":"    state: present"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7faddb67_5b0cd638","line":14,"range":{"start_line":14,"start_character":8,"end_line":14,"end_character":16},"updated":"2019-08-23 08:33:26.000000000","message":"Wow.","commit_id":"63700707dfe43285478c18659de51ff0bc16f82d"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":17068,"name":"Jean-Philippe Evrard","email":"openstack@a.spamming.party","username":"evrardjp"},"change_message_id":"71e3cbdf5b6b35748502c0ec643cf803575a7415","unresolved":false,"context_lines":[{"line_number":655,"context_line":"      tox_constraints_file: \u0027{{ ansible_user_dir }}/src/opendev.org/openstack/requirements/upper-constraints.txt\u0027"},{"line_number":656,"context_line":"      tox_envlist: docs"},{"line_number":657,"context_line":"      bindep_profile: compile doc"},{"line_number":658,"context_line":"    post-run: playbooks/tox-docs/post.yaml"},{"line_number":659,"context_line":"    success-url: html/"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_676f2efc","line":658,"range":{"start_line":658,"start_character":4,"end_line":658,"end_character":42},"updated":"2019-06-11 11:05:27.000000000","message":"1) wouldn\u0027t it make sense to run that in the same play, if we consider it\u0027s a thing we should do?\n\n2) Wouldn\u0027t it make sense to have a different job for pdf generation, within the same job template? \n\n3) Don\u0027t we need some kind of extra conditional too, in order to not target stein?","commit_id":"d275e9bacb4f21fdc520c823e324fc9fe34bbf6e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1293acebcbafd03aaeba257a9ca442e3f30dd2f3","unresolved":false,"context_lines":[{"line_number":655,"context_line":"      tox_constraints_file: \u0027{{ ansible_user_dir }}/src/opendev.org/openstack/requirements/upper-constraints.txt\u0027"},{"line_number":656,"context_line":"      tox_envlist: docs"},{"line_number":657,"context_line":"      bindep_profile: compile doc"},{"line_number":658,"context_line":"    post-run: playbooks/tox-docs/post.yaml"},{"line_number":659,"context_line":"    success-url: html/"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_8796e2ef","line":658,"updated":"2019-06-11 11:03:01.000000000","message":"I don\u0027t know if running this in a post-run step is the correct thing to do. Need input here","commit_id":"d275e9bacb4f21fdc520c823e324fc9fe34bbf6e"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"30298019fe755d3b667c78e1973607e93304244b","unresolved":false,"context_lines":[{"line_number":655,"context_line":"      tox_constraints_file: \u0027{{ ansible_user_dir }}/src/opendev.org/openstack/requirements/upper-constraints.txt\u0027"},{"line_number":656,"context_line":"      tox_envlist: docs"},{"line_number":657,"context_line":"      bindep_profile: compile doc"},{"line_number":658,"context_line":"    post-run: playbooks/tox-docs/post.yaml"},{"line_number":659,"context_line":"    success-url: html/"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_f2d8b5ef","line":658,"range":{"start_line":658,"start_character":4,"end_line":658,"end_character":42},"in_reply_to":"9fb8cfa7_676f2efc","updated":"2019-06-11 15:59:06.000000000","message":"It won\u0027t be easy to use a separate job because we don\u0027t want the PDF publishing to overwrite the rest of the HTML content being published. Combining the two formats into 1 job means we don\u0027t have to \"merge\" the published files.\n\nWe want PDFs built on all branches. The job should not fail if PDFs do not build, so it should be safe to do it on all of the old branches. Sometimes it will work, other times it won\u0027t. It isn\u0027t a requirement that anyone fix the old branches, but we don\u0027t want to preclude it either if the fix is easy.","commit_id":"d275e9bacb4f21fdc520c823e324fc9fe34bbf6e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"41a1dc3a2df2a56959e0c60b1efe65e657d8f92f","unresolved":false,"context_lines":[{"line_number":655,"context_line":"      tox_constraints_file: \u0027{{ ansible_user_dir }}/src/opendev.org/openstack/requirements/upper-constraints.txt\u0027"},{"line_number":656,"context_line":"      tox_envlist: docs"},{"line_number":657,"context_line":"      bindep_profile: compile doc"},{"line_number":658,"context_line":"    post-run: playbooks/tox-docs/post.yaml"},{"line_number":659,"context_line":"    success-url: html/"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_bd7bc025","line":658,"range":{"start_line":658,"start_character":4,"end_line":658,"end_character":42},"in_reply_to":"9fb8cfa7_f2d8b5ef","updated":"2019-06-13 15:34:08.000000000","message":"Soooo...this is okay as is? That\u0027s what I\u0027m getting out of this","commit_id":"d275e9bacb4f21fdc520c823e324fc9fe34bbf6e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"04adbc88defe6157dca30ed017f7c791ac5beb3f","unresolved":false,"context_lines":[{"line_number":655,"context_line":"      tox_constraints_file: \u0027{{ ansible_user_dir }}/src/opendev.org/openstack/requirements/upper-constraints.txt\u0027"},{"line_number":656,"context_line":"      tox_envlist: docs"},{"line_number":657,"context_line":"      bindep_profile: compile doc"},{"line_number":658,"context_line":"      build_pdf: false"},{"line_number":659,"context_line":"    pre-run: playbooks/tox-docs/pre.yaml"},{"line_number":660,"context_line":"    run: playbooks/tox-docs/run.yaml"},{"line_number":661,"context_line":"    success-url: html/"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_32e1429c","line":658,"range":{"start_line":658,"start_character":6,"end_line":658,"end_character":22},"updated":"2019-08-20 11:48:31.000000000","message":"Hmm..... \nIIUC when individual projects specify \u0027publish-openstack-docs-pti\u0027 in their .zuul.yaml, a variable cannot be passed.\nIt means projects need to specify the jobs with vars (instead of the project template).\nOr, do we want to define another template like publish/build-openstack-docs-pti-with-pdf?\n\nAnother approach is to use ignore_errors in build-pdf-docs role. This approach allows us to avoid redefinition of jobs. The downside is it potentially hides PDF build failure (as the job will succeed even when PDF build fails).","commit_id":"e605b594d8817abe68fdc1fea64abcb800b7ca2d"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"c46abcddd19896a24bd21829ffcf701b3730b5a0","unresolved":false,"context_lines":[{"line_number":655,"context_line":"      tox_constraints_file: \u0027{{ ansible_user_dir }}/src/opendev.org/openstack/requirements/upper-constraints.txt\u0027"},{"line_number":656,"context_line":"      tox_envlist: docs"},{"line_number":657,"context_line":"      bindep_profile: compile doc"},{"line_number":658,"context_line":"      build_pdf: false"},{"line_number":659,"context_line":"    pre-run: playbooks/tox-docs/pre.yaml"},{"line_number":660,"context_line":"    run: playbooks/tox-docs/run.yaml"},{"line_number":661,"context_line":"    success-url: html/"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_754b242a","line":658,"range":{"start_line":658,"start_character":6,"end_line":658,"end_character":22},"in_reply_to":"7faddb67_32e1429c","updated":"2019-08-20 12:20:59.000000000","message":"build_pdf variable needs to be documented in the job.","commit_id":"e605b594d8817abe68fdc1fea64abcb800b7ca2d"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"3a9cdba82cb24e666ed74ec62c9b5fc3031d71a4","unresolved":false,"context_lines":[{"line_number":653,"context_line":"      - name: openstack/requirements"},{"line_number":654,"context_line":"    vars:"},{"line_number":655,"context_line":"      tox_constraints_file: \u0027{{ ansible_user_dir }}/src/opendev.org/openstack/requirements/upper-constraints.txt\u0027"},{"line_number":656,"context_line":"      tox_envlist: docs"},{"line_number":657,"context_line":"      bindep_profile: compile doc"},{"line_number":658,"context_line":"    success-url: html/"},{"line_number":659,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7faddb67_5b35b6da","side":"PARENT","line":656,"range":{"start_line":656,"start_character":6,"end_line":656,"end_character":23},"updated":"2019-08-23 08:33:26.000000000","message":"Why move the tox_envlist definition from the job to the playbook? That removes the ability for the env to be overridden. Maybe that\u0027s not an issue - but I\u0027m curious why the change.","commit_id":"a7c46bcf8db89f3f42f9373756cb6a145c996a43"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f5e4778f12605c36486dd43bb6650892cf2985c9","unresolved":false,"context_lines":[{"line_number":417,"context_line":""},{"line_number":418,"context_line":"         Whether to skip building of PDF documents. By default a PDF"},{"line_number":419,"context_line":"         file is build if the tox environment specified by"},{"line_number":420,"context_line":"         :zuul:jobvar:`tox_pdf_envlist`exists."},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"    branches: ^(?!stable/(ocata|pike|queens|rocky)).*$"},{"line_number":423,"context_line":"    required-projects:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7faddb67_8a0af21d","line":420,"updated":"2019-08-23 14:02:30.000000000","message":"A space is need before´\"exists\".","commit_id":"59b2b1ee6f664f6918f96aad91a7de5a932143f8"}]}