)]}'
{"roles/prepare-zanata-client/files/propose_translation_update.sh":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"7a2a415d8bd3ee62971a7726f91d0cc048794a11","unresolved":true,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"# Rename existing Chinese locales in the project repository"},{"line_number":195,"context_line":"# (zh_CN -\u003e zh_Hans, zh_TW -\u003e zh_Hant)"},{"line_number":196,"context_line":"# NOTE: This is expected to call before pulling translations from zanata."},{"line_number":197,"context_line":"function rename_django_chinese_locales {"},{"line_number":198,"context_line":"    local project\u003d$1"},{"line_number":199,"context_line":"    local branch\u003d$2"}],"source_content_type":"text/x-sh","patch_set":2,"id":"e741246f_7401139d","line":196,"range":{"start_line":196,"start_character":8,"end_line":196,"end_character":73},"updated":"2021-02-02 14:47:54.000000000","message":"Your note contradicts your change in line 172, here you say that this function needs to be called *before* pulling translations. Above you call it *after*.\n\nI think calling after is correct and the note should be updated to say something like \"to be called *after*...\"","commit_id":"417d2ef92f93c27006fad7ba1e0cc5f015866282"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fd6d8bba4d4e6a8ea7240b1588944a22b7ee7ab7","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"# Rename existing Chinese locales in the project repository"},{"line_number":195,"context_line":"# (zh_CN -\u003e zh_Hans, zh_TW -\u003e zh_Hant)"},{"line_number":196,"context_line":"# NOTE: This is expected to call before pulling translations from zanata."},{"line_number":197,"context_line":"function rename_django_chinese_locales {"},{"line_number":198,"context_line":"    local project\u003d$1"},{"line_number":199,"context_line":"    local branch\u003d$2"}],"source_content_type":"text/x-sh","patch_set":2,"id":"4379f927_4fdb297f","line":196,"range":{"start_line":196,"start_character":8,"end_line":196,"end_character":73},"in_reply_to":"e741246f_7401139d","updated":"2021-02-02 23:52:21.000000000","message":"Sorry for confusion. I forgot to drop it when I refactored the proposed code.","commit_id":"417d2ef92f93c27006fad7ba1e0cc5f015866282"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"7a2a415d8bd3ee62971a7726f91d0cc048794a11","unresolved":true,"context_lines":[{"line_number":206,"context_line":"    # in horizon and its plugins, this branch check can be dropped."},{"line_number":207,"context_line":"    case \"$branch\" in"},{"line_number":208,"context_line":"        master|stable/wallaby) ;;"},{"line_number":209,"context_line":"        *) return ;;"},{"line_number":210,"context_line":"    esac"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    declare -A locale_rename_map\u003d("}],"source_content_type":"text/x-sh","patch_set":2,"id":"f64f55ec_5d44d836","line":209,"updated":"2021-02-02 14:47:54.000000000","message":"Why not check for old stable branches, so that we do no need to handle Xena etc.\n\nSo, a return on all supported stable branches (stable/victoria, etc) and the blank for the rest?","commit_id":"417d2ef92f93c27006fad7ba1e0cc5f015866282"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fd6d8bba4d4e6a8ea7240b1588944a22b7ee7ab7","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    # in horizon and its plugins, this branch check can be dropped."},{"line_number":207,"context_line":"    case \"$branch\" in"},{"line_number":208,"context_line":"        master|stable/wallaby) ;;"},{"line_number":209,"context_line":"        *) return ;;"},{"line_number":210,"context_line":"    esac"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    declare -A locale_rename_map\u003d("}],"source_content_type":"text/x-sh","patch_set":2,"id":"392d44a9_36d6a9af","line":209,"in_reply_to":"f64f55ec_5d44d836","updated":"2021-02-02 23:52:21.000000000","message":"Good point. I changed the logic as suggested.\nWhat we need to check are stable/ussuri and stable/victoria only [1].\n\n[1] https://opendev.org/openstack/openstack-zuul-jobs/src/commit/8a6fe25654790371a36601d9e0e14fc207931005/zuul.d/project-templates.yaml","commit_id":"417d2ef92f93c27006fad7ba1e0cc5f015866282"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"7a2a415d8bd3ee62971a7726f91d0cc048794a11","unresolved":true,"context_lines":[{"line_number":221,"context_line":"            rm -rf $module_name/locale/$new_locale"},{"line_number":222,"context_line":"            if [ -d $module_name/locale/$old_locale ]; then"},{"line_number":223,"context_line":"                mv $module_name/locale/$old_locale $module_name/locale/$new_locale"},{"line_number":224,"context_line":"            fi"},{"line_number":225,"context_line":"            if git ls-files | grep -q $module_name/locale/$old_locale; then"},{"line_number":226,"context_line":"                git rm -r $module_name/locale/$old_locale"},{"line_number":227,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"8c733b77_69591608","line":224,"updated":"2021-02-02 14:47:54.000000000","message":"Do we need to change the Language in the po file as well?\nhttps://opendev.org/openstack/horizon/src/branch/master/horizon/locale/zh_TW/LC_MESSAGES/django.po#L17","commit_id":"417d2ef92f93c27006fad7ba1e0cc5f015866282"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fd6d8bba4d4e6a8ea7240b1588944a22b7ee7ab7","unresolved":true,"context_lines":[{"line_number":221,"context_line":"            rm -rf $module_name/locale/$new_locale"},{"line_number":222,"context_line":"            if [ -d $module_name/locale/$old_locale ]; then"},{"line_number":223,"context_line":"                mv $module_name/locale/$old_locale $module_name/locale/$new_locale"},{"line_number":224,"context_line":"            fi"},{"line_number":225,"context_line":"            if git ls-files | grep -q $module_name/locale/$old_locale; then"},{"line_number":226,"context_line":"                git rm -r $module_name/locale/$old_locale"},{"line_number":227,"context_line":"            fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"48d373d2_a1594c5b","line":224,"in_reply_to":"8c733b77_69591608","updated":"2021-02-02 23:52:21.000000000","message":"I thought it once, but I did not do it this time.\nOne reason is I would like not to touch the contents of the file as long as it works. We can avoid unnecessary breakage.\nAnother reason is if we touch \"Language:\" field it seems we also need to change \"Language-Team\" field for consistency. AFAIK this entry is just information and it is not referred.\nThought?","commit_id":"417d2ef92f93c27006fad7ba1e0cc5f015866282"}]}