)]}'
{"roles/build-wheel-cache/files/wheel-build.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d7c759c0f1d4b9a51fb2332b915d59f22b369c23","unresolved":true,"context_lines":[{"line_number":14,"context_line":"if [[ ${PYTHON_VERSION} \u003d~ python2 ]]; then"},{"line_number":15,"context_line":"    VIRTUALENV_CMD\u003d\"virtualenv -p $PYTHON_VERSION\""},{"line_number":16,"context_line":"else"},{"line_number":17,"context_line":"    VIRTUALENV_CMD\u003d\"python3 -m venv\""},{"line_number":18,"context_line":"fi"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# preclean logs"}],"source_content_type":"text/x-sh","patch_set":2,"id":"a1fab7b4_3a2413fe","line":17,"updated":"2022-02-16 00:08:59.000000000","message":"This should probably be `$PYTHON_VERSION -m venv` so that we can support multiple python3 versions? I think the old code may have supported that though I\u0027m not sure it made use of it.","commit_id":"10e71361c46e521d46346516cd2c53c8e0b40ebf"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2e58e36410c3530b5518f804a71eb88ad1328207","unresolved":false,"context_lines":[{"line_number":14,"context_line":"if [[ ${PYTHON_VERSION} \u003d~ python2 ]]; then"},{"line_number":15,"context_line":"    VIRTUALENV_CMD\u003d\"virtualenv -p $PYTHON_VERSION\""},{"line_number":16,"context_line":"else"},{"line_number":17,"context_line":"    VIRTUALENV_CMD\u003d\"python3 -m venv\""},{"line_number":18,"context_line":"fi"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# preclean logs"}],"source_content_type":"text/x-sh","patch_set":2,"id":"686dff84_43a8cbbe","line":17,"in_reply_to":"a1fab7b4_3a2413fe","updated":"2022-02-16 00:19:18.000000000","message":"hrm, yes fair point","commit_id":"10e71361c46e521d46346516cd2c53c8e0b40ebf"}],"roles/build-wheel-cache/tasks/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d7c759c0f1d4b9a51fb2332b915d59f22b369c23","unresolved":true,"context_lines":[{"line_number":3,"context_line":"    name: ensure-virtualenv"},{"line_number":4,"context_line":"  when: wheel_python \u003d\u003d \"python2\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# NOTE(ianw) : 2022-02-08 - on python3 we use -m venv; which"},{"line_number":7,"context_line":"# ensure-pip.  Remove above and the conditional here when we drop"},{"line_number":8,"context_line":"# python2 platforms."},{"line_number":9,"context_line":"- name: Ensure pip"},{"line_number":10,"context_line":"  include_role:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"36ccc82c_adff5987","line":7,"range":{"start_line":6,"start_character":55,"end_line":7,"end_character":12},"updated":"2022-02-16 00:08:59.000000000","message":"I\u0027m not sure I understand what this is trying to convey. Does ensure-pip install the venv package?","commit_id":"10e71361c46e521d46346516cd2c53c8e0b40ebf"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2e58e36410c3530b5518f804a71eb88ad1328207","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    name: ensure-virtualenv"},{"line_number":4,"context_line":"  when: wheel_python \u003d\u003d \"python2\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# NOTE(ianw) : 2022-02-08 - on python3 we use -m venv; which"},{"line_number":7,"context_line":"# ensure-pip.  Remove above and the conditional here when we drop"},{"line_number":8,"context_line":"# python2 platforms."},{"line_number":9,"context_line":"- name: Ensure pip"},{"line_number":10,"context_line":"  include_role:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"32b450fa_2a002561","line":7,"range":{"start_line":6,"start_character":55,"end_line":7,"end_character":12},"in_reply_to":"36ccc82c_adff5987","updated":"2022-02-16 00:19:18.000000000","message":"sorry that sentence is incomplete.  indeed ensure-pip does also ensure venv and that was what i was trying to say","commit_id":"10e71361c46e521d46346516cd2c53c8e0b40ebf"}]}