)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b0073eba7ca86e69038a2c2f27328778bdbd00b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"8e5f2c54_80300e10","updated":"2022-05-04 21:24:03.000000000","message":"\u003eI\u0027m unconvinced it\u0027s worth it when we could just fetch the tarball of it and unpack that, or pull it all from Git as described in the debian/README.source file, and then overwrite it with whatever files we need to change.\n\nI guess the idea was to make it a bit clearer in review what\u0027s changing.  initially yes this is bigger, but from now on we either import our specific change, or can manually pull the upstream and just propose a diff update to what\u0027s in here, and we can see specifically the updates pretty clearly.  as opposed to having either diffs against files checked in, or munging scripts, or copies of random-looking files\n\nlike when we add a patch, we have to add the diff and update the series in the right place.  if we wanted to replace an upstream patch, we\u0027d have to delete the upstream diff, fiddle the series file, add ours, fiddle the series file, etc.  as opposed to just committing it in a clear change.\n\non your side -- this is moot right now, when there\u0027s no diffs for us, and few upstream patches anyway.  i would generally say that maintenance upstream seems to be much more active with things than a few years ago (meaning we are less likely to *have* to do major surgery here anyway).  but I can\u0027t shake the feeling that this situation has happened before.\n\n \u003e As for the job repository, would this make more sense in opendev/system-config? I know the idea was to not put it in a trusted config repo, which rules out openstack/project-config, but openstack//openstack-zuul-jobs is mostly OpenStack-specific versions of things while this is meant to be a general OpenDev process. I\u0027m not strongly opposed though.\n \n\u003e For that matter, is there a good reason to be adding this to the openstack tenant rather than the opendev tenant?\n\nFor both of these, it was just to be alongside the rpm generation path.\n\nrpm uses the standard afs publishing jobs, and the system-config roles are looking for the output files in tarballs.opendev.org/openstack/openstack-zuul-jobs; so moving it does take some coordination work.\n\nmy preference is to keep the jobs together, which is why i started here\n\ni\u0027m not opposed to system-config if we agree.  or a new opendev/openafs-deb-ppa repo if we\u0027d prefer to keep it separate?","commit_id":"8e4d34280738147619e0c7f9a46542d3deb97a1c"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"41611c4a97e4d70f17ced3596c6eb932415af9e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"aeb0982d_912e2ffc","updated":"2022-05-04 22:05:23.000000000","message":"One inline thing to help me out (and possibly others). But also I wonder if openstack-zuul-jobs is the best location for this job? OpenDev is using these openafs packages in its control plane. Maybe it should go in opendev/system-config or opendev/project-config? I\u0027m not too picky about it if we want to keep it here close to the wheel builds.","commit_id":"8e4d34280738147619e0c7f9a46542d3deb97a1c"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8552d44b6562e960fccfc0ea21dae52f849f9b98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"3b93f884_7ed25b2c","updated":"2022-05-04 23:18:31.000000000","message":"Sounds like this repo location is intentional. The followup change addresses my concerns with knowing what the upstream is and where to check deltas.","commit_id":"8e4d34280738147619e0c7f9a46542d3deb97a1c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0f3e9be0be40186e7058c5ea84d0065e9e52218e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"9c7cb3ca_68cf46e5","updated":"2022-05-04 23:29:08.000000000","message":"i\u0027m definitely willing to reorganize this, but it\u0027s a bit moot until it actually does something; which it doesn\u0027t at the moment because we need to promote it in the post pipeline to actually build anything; which i can\u0027t do speculatively.  i\u0027m going to go with this so i can work on that (pushing to a non-active ppa) and then, once it works, before we switch production i\u0027ll loop back and see how we feel","commit_id":"8e4d34280738147619e0c7f9a46542d3deb97a1c"}],"roles/openafs-deb-package-build/README.rst":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"41611c4a97e4d70f17ced3596c6eb932415af9e3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Build OpenAFS Ubuntu Packages"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"This pushes builds to launchpad"}],"source_content_type":"text/x-rst","patch_set":18,"id":"91796c4a_37764a99","line":3,"updated":"2022-05-04 22:05:23.000000000","message":"The commit message indicates we pull the upstream debian/* into this role, but it isn\u0027t clear if this is the ubuntu package or the debian package and for what version of AFS and debubuntu. Might be good to indicate that here so that we can easily cross hceck against the upstream to find deltas/updates.","commit_id":"8e4d34280738147619e0c7f9a46542d3deb97a1c"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d298688d1a568370a377e8ba0eafc8c58e297113","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Build OpenAFS Ubuntu Packages"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"This pushes builds to launchpad"}],"source_content_type":"text/x-rst","patch_set":18,"id":"7442b85b_e5739e97","line":3,"in_reply_to":"91796c4a_37764a99","updated":"2022-05-04 22:20:28.000000000","message":"yeah actually this is neither -- it\u0027s from https://launchpad.net/~openafs/+archive/ubuntu/stable\n\nthis repo has gone through periods of being very active and not active.  also, for whatever reason, it doesn\u0027t build arm64 packages.  that\u0027s why i don\u0027t think we can rely on it.  I can expand on this in the readme.","commit_id":"8e4d34280738147619e0c7f9a46542d3deb97a1c"}]}