)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"9f2d5b65fb25dc35359bff0720cc96b0a45eceff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":34,"id":"95dc7296_fcce605b","updated":"2022-06-24 22:14:46.000000000","message":"\u003e Is there a particular reason to put this in openstack/openstack-zuul-jobs instead of opendev/system-config? It seems like its intended for testing OpenDev\u0027s Grafana deployment, not anything OpenStack-related.\n\nI put it here to keep it next to project-config-grafyaml [1], which syntax checks the yaml input.\n\nI agree that this isn\u0027t specifically an openstack-* thing.  I think this whole repo needs a bit of a look at to split it up.  But I don\u0027t want to take that on now :)  And I do think keeping them together as they\u0027re related is the best approach.\n\n[1] https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/zuul.d/jobs.yaml#L1271","commit_id":"59e8221e7caa2eff88426efdb507a612d0390ead"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"733fc0fbf8974176b4eb558aa7707f97b036802a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"b765a092_ef48921e","updated":"2022-06-27 22:08:56.000000000","message":"Going to go with this, because it will allow us to see the results of .json dashboards in CI, which I think is a useful data-point for a discussion on using them more widely.","commit_id":"59e8221e7caa2eff88426efdb507a612d0390ead"}],"playbooks/grafana/main.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8fe8f817f2ee784e93cc7df60f401e123b583eb1","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    - name: Install dependencies"},{"line_number":19,"context_line":"      package:"},{"line_number":20,"context_line":"        name:"},{"line_number":21,"context_line":"          - python3-docker"},{"line_number":22,"context_line":"        state: present"},{"line_number":23,"context_line":"      become: yes"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":34,"id":"3d37420d_ab7f3da5","line":21,"updated":"2022-06-24 20:31:27.000000000","message":"This is a dependency of the running ansible right?","commit_id":"59e8221e7caa2eff88426efdb507a612d0390ead"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e7e1a6de32fba78fcd8e2d679b9167017a99f70f","unresolved":true,"context_lines":[{"line_number":18,"context_line":"    - name: Install dependencies"},{"line_number":19,"context_line":"      package:"},{"line_number":20,"context_line":"        name:"},{"line_number":21,"context_line":"          - python3-docker"},{"line_number":22,"context_line":"        state: present"},{"line_number":23,"context_line":"      become: yes"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":34,"id":"dc628c5a_759d9f5c","line":21,"in_reply_to":"3d37420d_ab7f3da5","updated":"2022-06-24 22:19:15.000000000","message":"A dependency of the docker_service: task, yep.  Seems a bit better than explicit shell calls to docker inline.","commit_id":"59e8221e7caa2eff88426efdb507a612d0390ead"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8fe8f817f2ee784e93cc7df60f401e123b583eb1","unresolved":true,"context_lines":[{"line_number":1283,"context_line":"      - tox.ini"},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"- job:"},{"line_number":1286,"context_line":"    name: project-config-grafana"},{"line_number":1287,"context_line":"    description: |"},{"line_number":1288,"context_line":"      Validates import and creates screenshots of project-config"},{"line_number":1289,"context_line":"      defined graphs."}],"source_content_type":"text/x-yaml","patch_set":34,"id":"7981fda5_0bb36953","line":1286,"updated":"2022-06-24 20:31:27.000000000","message":"Talking out loud here it feels odd to put this job in ozj. I think that choice may have been made so that it can be speculatively run?\n\nMy initial impression was that this sort of checking would be great in system-config-run-grafana. THen we can have openstack/project-config run that job too. Can you help me understand if there are other reasons to have it run out of this repo?","commit_id":"59e8221e7caa2eff88426efdb507a612d0390ead"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"e7e1a6de32fba78fcd8e2d679b9167017a99f70f","unresolved":true,"context_lines":[{"line_number":1283,"context_line":"      - tox.ini"},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"- job:"},{"line_number":1286,"context_line":"    name: project-config-grafana"},{"line_number":1287,"context_line":"    description: |"},{"line_number":1288,"context_line":"      Validates import and creates screenshots of project-config"},{"line_number":1289,"context_line":"      defined graphs."}],"source_content_type":"text/x-yaml","patch_set":34,"id":"d7b0a351_86f633f7","line":1286,"in_reply_to":"7981fda5_0bb36953","updated":"2022-06-24 22:19:15.000000000","message":"See my other response to fungi, but keeping it with the syntax checker was the initial goal.  And yes, I imagine that job ended up in there because of speculative testing too.\n\nIt\u0027s probably questionable if we need the grafana configs in a protected repo like project-config.  As mentioned, the whole of o-z-j could probably do with pulling apart in the opendev era (wheel jobs are similarly not exactly openstack specific).\n\nI did think about putting it in system-config job.  But that job does a lot more than just make screenshots of the graphs, which is quite confusing for somebody who just wants to add/modify a graph we display.  So I think a stand-alone job is useful.\n\nNow I\u0027ve done this, we can expand the system-config job to also take screenshots like this if we like, to validate each graph looks correct if we upgrade other parts of the system.","commit_id":"59e8221e7caa2eff88426efdb507a612d0390ead"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"aad2ea0f6ed940227763a199afcfe4ea48ad3354","unresolved":true,"context_lines":[{"line_number":1283,"context_line":"      - tox.ini"},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"- job:"},{"line_number":1286,"context_line":"    name: project-config-grafana"},{"line_number":1287,"context_line":"    description: |"},{"line_number":1288,"context_line":"      Validates import and creates screenshots of project-config"},{"line_number":1289,"context_line":"      defined graphs."}],"source_content_type":"text/x-yaml","patch_set":34,"id":"f42f9a37_441f3278","line":1286,"in_reply_to":"d7b0a351_86f633f7","updated":"2022-06-27 19:38:44.000000000","message":"The system-config job does do more, but in my mind we\u0027re testing the whole end result which includes our dashboards? Maybe updating that job too is the way to go for the best of both worlds.","commit_id":"59e8221e7caa2eff88426efdb507a612d0390ead"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"733fc0fbf8974176b4eb558aa7707f97b036802a","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"      - tox.ini"},{"line_number":1284,"context_line":""},{"line_number":1285,"context_line":"- job:"},{"line_number":1286,"context_line":"    name: project-config-grafana"},{"line_number":1287,"context_line":"    description: |"},{"line_number":1288,"context_line":"      Validates import and creates screenshots of project-config"},{"line_number":1289,"context_line":"      defined graphs."}],"source_content_type":"text/x-yaml","patch_set":34,"id":"c82f75d1_20cab8f2","line":1286,"in_reply_to":"f42f9a37_441f3278","updated":"2022-06-27 22:08:56.000000000","message":"Yep, now I know how to query the api for the dashboards, I\u0027ll add that to the system-config job.","commit_id":"59e8221e7caa2eff88426efdb507a612d0390ead"}]}