)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b5438c57e01b37929d914bf1cf4a2411db61b821","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9df3cd96_932deaa1","updated":"2022-07-01 04:38:46.000000000","message":"This definitely needs test cases added, see under zuul-tests.d and likely a playbook under test-playbooks","commit_id":"1c4165b88e758899a6979adf2006956b4b4edc17"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"eec1b05710fe3d00e3ed913f4640bc5e4c4eaea5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a11de996_ef3ab48e","in_reply_to":"8446de6e_941c0113","updated":"2022-07-01 20:41:31.000000000","message":"Will find some time to do, thanks for the suggestion.","commit_id":"1c4165b88e758899a6979adf2006956b4b4edc17"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d9b02c7fffaa020f7309259e46fc8d426152d487","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8446de6e_941c0113","in_reply_to":"9df3cd96_932deaa1","updated":"2022-07-01 04:42:57.000000000","message":"Oh, sorry, I thought this was in zuul-jobs, not openstack-zuul-jobs.  But still, perhaps something in the openstack-infra-extra-integration job?  or something else to exercise it","commit_id":"1c4165b88e758899a6979adf2006956b4b4edc17"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b445ed69671d9084aefe98267a690b0837867f64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"81e79359_4b1eb871","updated":"2022-07-01 16:24:56.000000000","message":"Please note the comments in https://review.opendev.org/c/zuul/zuul-jobs/+/848339 which has since been abandoned.\n\nLong story short I think a role that enforces openstack\u0027s commit formatting guidelines belong in an openstack role and not the generic stdlib found in zuul/zuul-jobs. Additionally, history has shown that enforcing rules like this in CI can be annoying for developers and instead reviewers might consider exercising judgement over whether a period exists at the end of a line (and by exercising judgement I mean just ignore it it isn\u0027t that big of a deal).\n\nThat said if a project really wants to enforce these rules this is probably the place to keep the role.","commit_id":"b418ca683464e2a7b23a313e8f66e5d4d21e7f15"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"eec1b05710fe3d00e3ed913f4640bc5e4c4eaea5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"36083803_4a05a7e4","in_reply_to":"81e79359_4b1eb871","updated":"2022-07-01 20:41:31.000000000","message":"I agree. This ends up being a choice of using this check to spare reviewers of checking structure every time on projects that enforce it vs. not using it and be more permissive.","commit_id":"b418ca683464e2a7b23a313e8f66e5d4d21e7f15"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"775d469a76a4ad2a128fa6dc855d1d2fb4f2da31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5544428d_c1f2cb7a","updated":"2022-07-01 20:24:26.000000000","message":"I agree with Clark\u0027s comments on the other patch with the same change as in this one. I remember when these formatting preferences were enforced in OpenStack, on occasions they rather made the contributor experience bad than fixing an actual issue.\n\nI hope this change will not replace to educate contributors about the information that they should include in their commit message, as well as to pass down good practices from established contributors to newcomers!\n\n","commit_id":"1b2a211d3f0dae44586e572a62860836031deab1"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"eec1b05710fe3d00e3ed913f4640bc5e4c4eaea5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"90f6b30a_87941c24","in_reply_to":"5544428d_c1f2cb7a","updated":"2022-07-01 20:41:31.000000000","message":"I\u0027m not really following the line of thought here. The aim of this check is to reduce churn on the reviews and spending reviewer time on structural issues that can be automated. \n\nThis has nothing to do with the syntax and, specially, the semantics of what is being written on the commit message. This will still be up to the reviewers to check out and guide contributors about.","commit_id":"1b2a211d3f0dae44586e572a62860836031deab1"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"968a27a0c3dc7f5b7a4f5469b00113aa35f48c9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1e0d4f73_d673175d","in_reply_to":"90f6b30a_87941c24","updated":"2022-07-15 22:14:26.000000000","message":"The point I was trying to make is that checks like this are incredibly frustrating to contributors because they are often trivial (like whether or not a \u0027.\u0027 is present) and not typically checked locally before pushing due to order of operations. It isn\u0027t that reviewers need to do more work it is that they should do less and just let small things like that go by.\n\nOpenStack does not enforce any of these rules in this way itself for these reasons. It tried to in the past using the hacking tool and it only led to problems.\n\nI\u0027m not a contributor to the projects that this will be applied to so I\u0027m not really going to argue this one way or another. I just wanted you to know the history here and why something like this doesn\u0027t already exist.","commit_id":"1b2a211d3f0dae44586e572a62860836031deab1"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"0cf5d2a06d9ab63e103a8a35dff5c5e287e67368","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"aee5d7e3_3608f11a","updated":"2022-07-06 12:52:05.000000000","message":"A couple of nits inline.\n\nI\u0027m curious where you plan to use this?\nI fear that few projects will use it based on previous experience, so really like to see which projects are signing up.\n\n\n\nLooking at the error messages,I wonder also whether instead of saying (I\u0027m paraphrasing, don\u0027t copy \u0026 paste me here) \"Summary is longer than 50 chars\", it\u0027s better to say \"Summary must be not longer than 50 characters\", so instead of stating what we found, state the role.\n\n","commit_id":"10c5b901832eb831778ba5944fe63fd844c656a7"}],"roles/validate-commit-message-guidelines/README.rst":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"0cf5d2a06d9ab63e103a8a35dff5c5e287e67368","unresolved":true,"context_lines":[{"line_number":1,"context_line":"Validate all commits complies with the commit message guidelines at [1]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[1] https://wiki.openstack.org/wiki/GitCommitMessages"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"34061521_1f852737","line":1,"range":{"start_line":1,"start_character":21,"end_line":1,"end_character":29},"updated":"2022-07-06 12:52:05.000000000","message":"comply","commit_id":"10c5b901832eb831778ba5944fe63fd844c656a7"}],"roles/validate-commit-message-guidelines/tasks/main.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b5438c57e01b37929d914bf1cf4a2411db61b821","unresolved":true,"context_lines":[{"line_number":11,"context_line":"          echo \"---\""},{"line_number":12,"context_line":"          git show -s $commit"},{"line_number":13,"context_line":"          echo \"---\""},{"line_number":14,"context_line":"          echo \"Summary is larger than 50 characters\""},{"line_number":15,"context_line":"          result\u003d1"},{"line_number":16,"context_line":"        fi"},{"line_number":17,"context_line":"        if [ ${summary: -1} \u003d\u003d \".\" ]; then"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b752275b_1ff1d9a4","line":14,"range":{"start_line":14,"start_character":27,"end_line":14,"end_character":33},"updated":"2022-07-01 04:38:46.000000000","message":"I think \"longer\" is a little clearer","commit_id":"1c4165b88e758899a6979adf2006956b4b4edc17"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"eec1b05710fe3d00e3ed913f4640bc5e4c4eaea5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"          echo \"---\""},{"line_number":12,"context_line":"          git show -s $commit"},{"line_number":13,"context_line":"          echo \"---\""},{"line_number":14,"context_line":"          echo \"Summary is larger than 50 characters\""},{"line_number":15,"context_line":"          result\u003d1"},{"line_number":16,"context_line":"        fi"},{"line_number":17,"context_line":"        if [ ${summary: -1} \u003d\u003d \".\" ]; then"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"76bd5159_44b4b8da","line":14,"range":{"start_line":14,"start_character":27,"end_line":14,"end_character":33},"in_reply_to":"b752275b_1ff1d9a4","updated":"2022-07-01 20:41:31.000000000","message":"Done","commit_id":"1c4165b88e758899a6979adf2006956b4b4edc17"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b5438c57e01b37929d914bf1cf4a2411db61b821","unresolved":true,"context_lines":[{"line_number":45,"context_line":"            echo \"---\""},{"line_number":46,"context_line":"            git show -s $commit"},{"line_number":47,"context_line":"            echo \"---\""},{"line_number":48,"context_line":"            echo \"Commit message body is greater than 72 characters\""},{"line_number":49,"context_line":"            result\u003d1"},{"line_number":50,"context_line":"            break"},{"line_number":51,"context_line":"          fi"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"489193b3_e1e350bb","line":48,"range":{"start_line":48,"start_character":53,"end_line":48,"end_character":68},"updated":"2022-07-01 04:38:46.000000000","message":"\"72 characters wide\" is maybe clearer","commit_id":"1c4165b88e758899a6979adf2006956b4b4edc17"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"eec1b05710fe3d00e3ed913f4640bc5e4c4eaea5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            echo \"---\""},{"line_number":46,"context_line":"            git show -s $commit"},{"line_number":47,"context_line":"            echo \"---\""},{"line_number":48,"context_line":"            echo \"Commit message body is greater than 72 characters\""},{"line_number":49,"context_line":"            result\u003d1"},{"line_number":50,"context_line":"            break"},{"line_number":51,"context_line":"          fi"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5ac67325_4aaf7710","line":48,"range":{"start_line":48,"start_character":53,"end_line":48,"end_character":68},"in_reply_to":"489193b3_e1e350bb","updated":"2022-07-01 20:41:31.000000000","message":"using \"longer\" now as in the previous instance","commit_id":"1c4165b88e758899a6979adf2006956b4b4edc17"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b5438c57e01b37929d914bf1cf4a2411db61b821","unresolved":true,"context_lines":[{"line_number":54,"context_line":"      exit $result"},{"line_number":55,"context_line":"    chdir: \"{{ zuul_work_dir }}\""},{"line_number":56,"context_line":"    executable: /bin/bash"},{"line_number":57,"context_line":"  register: _commit_message_check"},{"line_number":58,"context_line":"  failed_when: _commit_message_check.rc \u003e 1"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- name: Message body check failed"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"b6b64340_1f1c995a","line":57,"range":{"start_line":57,"start_character":1,"end_line":57,"end_character":33},"updated":"2022-07-01 04:38:46.000000000","message":"You can get the stdout of this; perhaps it would be a good idea to mix it into the fail: message so that you know exactly what went wrong?","commit_id":"1c4165b88e758899a6979adf2006956b4b4edc17"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"ac6cef45a6ff1a4aea38c22515b083611eb03c43","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      exit $result"},{"line_number":55,"context_line":"    chdir: \"{{ zuul_work_dir }}\""},{"line_number":56,"context_line":"    executable: /bin/bash"},{"line_number":57,"context_line":"  register: _commit_message_check"},{"line_number":58,"context_line":"  failed_when: _commit_message_check.rc \u003e 1"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- name: Message body check failed"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba13c703_b23b2cbc","line":57,"range":{"start_line":57,"start_character":1,"end_line":57,"end_character":33},"in_reply_to":"780fe7f5_ebc42533","updated":"2022-07-01 20:48:32.000000000","message":"Done","commit_id":"1c4165b88e758899a6979adf2006956b4b4edc17"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"eec1b05710fe3d00e3ed913f4640bc5e4c4eaea5","unresolved":true,"context_lines":[{"line_number":54,"context_line":"      exit $result"},{"line_number":55,"context_line":"    chdir: \"{{ zuul_work_dir }}\""},{"line_number":56,"context_line":"    executable: /bin/bash"},{"line_number":57,"context_line":"  register: _commit_message_check"},{"line_number":58,"context_line":"  failed_when: _commit_message_check.rc \u003e 1"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- name: Message body check failed"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"780fe7f5_ebc42533","line":57,"range":{"start_line":57,"start_character":1,"end_line":57,"end_character":33},"in_reply_to":"b6b64340_1f1c995a","updated":"2022-07-01 20:41:31.000000000","message":"Good suggestion, tks","commit_id":"1c4165b88e758899a6979adf2006956b4b4edc17"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"0cf5d2a06d9ab63e103a8a35dff5c5e287e67368","unresolved":true,"context_lines":[{"line_number":49,"context_line":"      )"},{"line_number":50,"context_line":"      for commit in $(git cherry -v origin/{{ zuul.branch }} HEAD | cut -d \" \" -f2); do"},{"line_number":51,"context_line":"        git show -s $commit --format\u003d%b| while read line; do"},{"line_number":52,"context_line":"          "},{"line_number":53,"context_line":"          # Skips lines that could possibly go over 72 due to reasons"},{"line_number":54,"context_line":"          skip_line\u003d0"},{"line_number":55,"context_line":"          for escape in \"${escapes[@]}\"; do"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"8ff13c2e_44aeda1b","line":52,"updated":"2022-07-06 12:52:05.000000000","message":"You have a couple of lines here with extra whitespace, check them on gerrit and remove. Quickly: lines 52,61,65","commit_id":"10c5b901832eb831778ba5944fe63fd844c656a7"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"0cf5d2a06d9ab63e103a8a35dff5c5e287e67368","unresolved":true,"context_lines":[{"line_number":68,"context_line":"            echo \"---\""},{"line_number":69,"context_line":"            git show -s $commit"},{"line_number":70,"context_line":"            echo \"---\""},{"line_number":71,"context_line":"            echo \"Any of the commit message body lines is longer than 72 characters\""},{"line_number":72,"context_line":"            result\u003d1"},{"line_number":73,"context_line":"            break"},{"line_number":74,"context_line":"          fi"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"5e0eba54_504b0c9a","line":71,"range":{"start_line":71,"start_character":18,"end_line":71,"end_character":22},"updated":"2022-07-06 12:52:05.000000000","message":"at least one","commit_id":"10c5b901832eb831778ba5944fe63fd844c656a7"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b5438c57e01b37929d914bf1cf4a2411db61b821","unresolved":true,"context_lines":[{"line_number":1831,"context_line":"- job:"},{"line_number":1832,"context_line":"    name: commit-message-guidelines"},{"line_number":1833,"context_line":"    description: |"},{"line_number":1834,"context_line":"      A job to validate all new commits respect the commit message guidelines "},{"line_number":1835,"context_line":"      wrt summary and body line length."},{"line_number":1836,"context_line":"    run: playbooks/commit-message-guidelines/run.yaml"},{"line_number":1837,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"40db5c1e_70684c6b","line":1834,"updated":"2022-07-01 04:38:46.000000000","message":"extra whitespace","commit_id":"1c4165b88e758899a6979adf2006956b4b4edc17"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"eec1b05710fe3d00e3ed913f4640bc5e4c4eaea5","unresolved":false,"context_lines":[{"line_number":1831,"context_line":"- job:"},{"line_number":1832,"context_line":"    name: commit-message-guidelines"},{"line_number":1833,"context_line":"    description: |"},{"line_number":1834,"context_line":"      A job to validate all new commits respect the commit message guidelines "},{"line_number":1835,"context_line":"      wrt summary and body line length."},{"line_number":1836,"context_line":"    run: playbooks/commit-message-guidelines/run.yaml"},{"line_number":1837,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"6a906e9a_84a1925a","line":1834,"in_reply_to":"40db5c1e_70684c6b","updated":"2022-07-01 20:41:31.000000000","message":"Done","commit_id":"1c4165b88e758899a6979adf2006956b4b4edc17"}]}