)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"fefbc46f34679b31a06ee7a8e523ad0220c8d066","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cb5080ae_47793fde","updated":"2022-12-15 20:35:11.000000000","message":"This is working for pin on stable branch but we should have a easy way to unpin it in projects zuul.yaml which does not seems the case. I tested to unpin it in project side at \u0027projects\u0027 level but it did not work due to order of setting of \u0027vars\u0027 \n\n- https://review.opendev.org/c/openstack/glance/+/867880/5/.zuul.yaml#295\n\ninstead of doing a complex way to unpin on project side I think backport the fixes to stable branches will be less time consuming as we anyways have to fix the things on master.","commit_id":"6b836a005f725b06074710ed794d3487997ca6ee"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9b8fbcf6f1114ce38d6b4619b3d59866a42027dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cc17379c_4b1b1a8b","updated":"2023-01-05 19:04:13.000000000","message":"I wouldn\u0027t care too much about the not needed stanzas, they should get cleaned up soon anyway when those old branches are completely retired.","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5ccc8987b8703d2f908df150b114a8752b94524d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fd0a75da_e4a63e47","updated":"2023-01-05 19:05:14.000000000","message":"Oh but that template issue seems relevant","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5f453421e8b039fd2449ca3f4850c064c8540d1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c3db8bc6_151f7e09","updated":"2023-01-05 14:38:18.000000000","message":"This is the way, IMHO.","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"7ca12872db2c55642117fd1c3399ece9999e0bea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1aa5d761_9ee89d39","updated":"2023-01-05 05:12:39.000000000","message":"We\u0027ve already backported tox4 changes to stable branches. Hope this pinning won\u0027t break those again. ","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"14320513f1f3a626a839099e74175a5d8eefb96a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3c08a529_9727a031","updated":"2023-01-05 04:13:57.000000000","message":"huge +1. This definitely saves us !","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c91753d0fbd9c8143e6fda3adf05f379b224d371","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fdb563d8_4399ce79","updated":"2023-01-05 04:09:25.000000000","message":"tested with cinder and nova stable branches and it is working fine\n- https://review.opendev.org/q/I0ca55abf9975c5a3f9713ac5dd5be39083e04554\n- https://review.opendev.org/q/I300e7804a27d08ecd239d1a7faaf2aaf3e07b9ee","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b2f12c4bbb2ae80167d2bd7f282d2f0b0e3f7b07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"25ed8ffb_844f9aa1","in_reply_to":"1aa5d761_9ee89d39","updated":"2023-01-05 18:17:00.000000000","message":"it should not. most of the changes done for tox4 are compatible with tox\u003c4.","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"1ebd174b9389c583ce4808c6d90a52d6cf29fcf2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"39f2d6e3_169590ba","updated":"2023-01-06 06:11:41.000000000","message":"This change is all good. I think we are hitting another issue from tox4 https://github.com/tox-dev/tox/pull/2824/\n\nseeing it consistently on master san\n - https://zuul.opendev.org/t/openstack/build/221af3c2b95e4c00a183fa5bfc4e2e99\n","commit_id":"4888ad13e9fb82e4ecbe9c00094cb8b4672e0444"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c21cd342ffe3e4a07592d856406d0f0764359d65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"68bc6d92_8e4c84dd","updated":"2023-01-05 20:30:02.000000000","message":"WIP until I run some DNM testing patch on stable and master gate to make sure branches variant working fine","commit_id":"4888ad13e9fb82e4ecbe9c00094cb8b4672e0444"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"182a26d011b3e854ba206c26e0167a2f30d6b9d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b3db5530_3a3e75fc","updated":"2023-01-06 03:47:50.000000000","message":"testing this change for stable and master gate.\n- https://review.opendev.org/q/topic:tox4-pin-testing\n\nStable branch: it is working fine in all stable branches\nMaster: Failing with strange errors. \n- https://zuul.opendev.org/t/openstack/build/f9385f3142af44699c13066d14eddf73\n- https://zuul.opendev.org/t/openstack/build/9e1bf669244e46fe8380d8741234051a\n- https://zuul.opendev.org/t/openstack/build/7b2da19738d44b1e9e69f40f5a45264f","commit_id":"4888ad13e9fb82e4ecbe9c00094cb8b4672e0444"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9bbd7f2425eb238cfe0f835253faaa7fd672e630","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"572f7137_ec08028c","in_reply_to":"b3db5530_3a3e75fc","updated":"2023-01-06 05:12:23.000000000","message":"I am seeing the master jobs error in other patches also which means it is not related to this change - https://zuul.openstack.org/build/269d2a0d50cb4c55a3fadfc6a58969eb","commit_id":"4888ad13e9fb82e4ecbe9c00094cb8b4672e0444"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"2845298bc4b7d0588c8718fa31155bbd0a510585","unresolved":false,"context_lines":[{"line_number":138,"context_line":"      # NOTE(gmann): This is stable branch (\u003c\u003dstable/rocky) job and new"},{"line_number":139,"context_line":"      # tox 4 require some changes in tox.ini to be compatible with it. Let\u0027s"},{"line_number":140,"context_line":"      # pin tox \u003c4 for stable branches testing (\u003c\u003dstable/zed)."},{"line_number":141,"context_line":"      ensure_tox_version: \u0027\u003c4\u0027"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"- job:"},{"line_number":144,"context_line":"    name: openstack-tox-with-sudo"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"434cf767_176de2f2","line":141,"updated":"2023-01-05 19:01:16.000000000","message":"Nit: This one isn\u0027t necessary. Tox 4.0.0 and later requires at least Python 3.7, which is not available on our ubuntu-xenial images. Pip only installs 3.x for these jobs.","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"66736c2fe383415673ea1db44ef6dc49ae440378","unresolved":false,"context_lines":[{"line_number":138,"context_line":"      # NOTE(gmann): This is stable branch (\u003c\u003dstable/rocky) job and new"},{"line_number":139,"context_line":"      # tox 4 require some changes in tox.ini to be compatible with it. Let\u0027s"},{"line_number":140,"context_line":"      # pin tox \u003c4 for stable branches testing (\u003c\u003dstable/zed)."},{"line_number":141,"context_line":"      ensure_tox_version: \u0027\u003c4\u0027"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"- job:"},{"line_number":144,"context_line":"    name: openstack-tox-with-sudo"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b7d81179_be320fd3","line":141,"in_reply_to":"434cf767_176de2f2","updated":"2023-01-05 19:36:31.000000000","message":"ok, just for safer side I thought we can keep it.","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a64818641d3ae2f64da79abbaa7b6067319cf245","unresolved":true,"context_lines":[{"line_number":157,"context_line":"      Run unit tests for an OpenStack Python project under cPython version 2.7."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"      Uses tox with the ``py27`` environment."},{"line_number":160,"context_line":"    branches: ^(?!stable/(queens|rocky)).*$"},{"line_number":161,"context_line":"    irrelevant-files: \u0026common-irrelevant-files"},{"line_number":162,"context_line":"      - ^.*\\.rst$"},{"line_number":163,"context_line":"      - ^api-ref/.*$"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5aa48307_69a67507","line":160,"updated":"2023-01-05 19:01:33.000000000","message":"Technically this one can run against master. But I guess we don\u0027t apply it to master since nothing supports 2.7 on master?","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d80f762f3245a7f524ee02e13190f26acda60718","unresolved":false,"context_lines":[{"line_number":157,"context_line":"      Run unit tests for an OpenStack Python project under cPython version 2.7."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"      Uses tox with the ``py27`` environment."},{"line_number":160,"context_line":"    branches: ^(?!stable/(queens|rocky)).*$"},{"line_number":161,"context_line":"    irrelevant-files: \u0026common-irrelevant-files"},{"line_number":162,"context_line":"      - ^.*\\.rst$"},{"line_number":163,"context_line":"      - ^api-ref/.*$"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ff9ab052_024f01f4","line":160,"in_reply_to":"14eceb4f_c2f7aa73","updated":"2023-01-06 09:43:42.000000000","message":"Done","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"66736c2fe383415673ea1db44ef6dc49ae440378","unresolved":true,"context_lines":[{"line_number":157,"context_line":"      Run unit tests for an OpenStack Python project under cPython version 2.7."},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"      Uses tox with the ``py27`` environment."},{"line_number":160,"context_line":"    branches: ^(?!stable/(queens|rocky)).*$"},{"line_number":161,"context_line":"    irrelevant-files: \u0026common-irrelevant-files"},{"line_number":162,"context_line":"      - ^.*\\.rst$"},{"line_number":163,"context_line":"      - ^api-ref/.*$"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"14eceb4f_c2f7aa73","line":160,"in_reply_to":"5aa48307_69a67507","updated":"2023-01-05 19:36:31.000000000","message":"yes, there is no py27 job on master.","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"2845298bc4b7d0588c8718fa31155bbd0a510585","unresolved":false,"context_lines":[{"line_number":195,"context_line":"      # NOTE(gmann): This is stable branch (\u003c\u003dstable/rocky) job and new"},{"line_number":196,"context_line":"      # tox 4 require some changes in tox.ini to be compatible with it. Let\u0027s"},{"line_number":197,"context_line":"      # pin tox \u003c4 for stable branches testing (\u003c\u003dstable/zed)."},{"line_number":198,"context_line":"      ensure_tox_version: \u0027\u003c4\u0027"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"- job:"},{"line_number":201,"context_line":"    name: openstack-tox-py35"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fd226bc1_d3171e51","line":198,"updated":"2023-01-05 19:01:16.000000000","message":"Nit: Also not needed.","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"2845298bc4b7d0588c8718fa31155bbd0a510585","unresolved":false,"context_lines":[{"line_number":214,"context_line":"      # NOTE(gmann): This is stable branch job and new tox 4 require"},{"line_number":215,"context_line":"      # some changes in tox.ini to be compatible with it. Let\u0027s"},{"line_number":216,"context_line":"      # pin tox \u003c4 for stable branches testing (\u003c\u003dstable/zed)."},{"line_number":217,"context_line":"      ensure_tox_version: \u0027\u003c4\u0027"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"- job:"},{"line_number":220,"context_line":"    name: openstack-tox-py36"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"83f5a1c0_85426361","line":217,"updated":"2023-01-05 19:01:16.000000000","message":"Nit: Also not needed.","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"2845298bc4b7d0588c8718fa31155bbd0a510585","unresolved":false,"context_lines":[{"line_number":509,"context_line":"      # NOTE(gmann): This is stable branch (\u003c\u003dstable/rocky) job and new"},{"line_number":510,"context_line":"      # tox 4 require some changes in tox.ini to be compatible with it. Let\u0027s"},{"line_number":511,"context_line":"      # pin tox \u003c4 for stable branches testing (\u003c\u003dstable/zed)."},{"line_number":512,"context_line":"      ensure_tox_version: \u0027\u003c4\u0027"},{"line_number":513,"context_line":"    timeout: 3000"},{"line_number":514,"context_line":"    branches:"},{"line_number":515,"context_line":"      - stable/queens"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"845dae7f_776f4449","line":512,"updated":"2023-01-05 19:01:16.000000000","message":"Nit: Also not needed.","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"2845298bc4b7d0588c8718fa31155bbd0a510585","unresolved":false,"context_lines":[{"line_number":1000,"context_line":"      # NOTE(gmann): This is stable branch (\u003c\u003dstable/rocky) job and new"},{"line_number":1001,"context_line":"      # tox 4 require some changes in tox.ini to be compatible with it. Let\u0027s"},{"line_number":1002,"context_line":"      # pin tox \u003c4 for stable branches testing (\u003c\u003dstable/zed)."},{"line_number":1003,"context_line":"      ensure_tox_version: \u0027\u003c4\u0027"},{"line_number":1004,"context_line":"    nodeset: ubuntu-xenial"},{"line_number":1005,"context_line":"    branches:"},{"line_number":1006,"context_line":"      - stable/queens"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6dc3aa36_8799b187","line":1003,"updated":"2023-01-05 19:01:16.000000000","message":"Nit: Also not needed.","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"}],"zuul.d/project-templates.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a64818641d3ae2f64da79abbaa7b6067319cf245","unresolved":true,"context_lines":[{"line_number":203,"context_line":"    # some changes in tox.ini to be compatible with it. Let\u0027s pin tox \u003c4"},{"line_number":204,"context_line":"    # for stable branches testing (\u003c\u003dstable/zed)."},{"line_number":205,"context_line":"    vars:"},{"line_number":206,"context_line":"      ensure_tox_version: \u0027\u003c4\u0027"},{"line_number":207,"context_line":"    check:"},{"line_number":208,"context_line":"      jobs:"},{"line_number":209,"context_line":"        - test-release-openstack:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"626b1d9f_f22ed0bb","line":206,"updated":"2023-01-05 19:01:33.000000000","message":"I\u0027m not sure the use of vars in a project-template like this will do what you intend it to do. The intention is that the jobs within this template will have tox pinned to \u0027\u003c4\u0027, but a project-template applies to the entire project instead. This means that every project that has one or more of these templates applied to it will get tox pinned to \u003c4 for every job they run regardless of branch.","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"66736c2fe383415673ea1db44ef6dc49ae440378","unresolved":true,"context_lines":[{"line_number":203,"context_line":"    # some changes in tox.ini to be compatible with it. Let\u0027s pin tox \u003c4"},{"line_number":204,"context_line":"    # for stable branches testing (\u003c\u003dstable/zed)."},{"line_number":205,"context_line":"    vars:"},{"line_number":206,"context_line":"      ensure_tox_version: \u0027\u003c4\u0027"},{"line_number":207,"context_line":"    check:"},{"line_number":208,"context_line":"      jobs:"},{"line_number":209,"context_line":"        - test-release-openstack:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a4428f9a_784e9137","line":206,"in_reply_to":"626b1d9f_f22ed0bb","updated":"2023-01-05 19:36:31.000000000","message":"I see. thanks for checking. let me update it at job level.","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d80f762f3245a7f524ee02e13190f26acda60718","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    # some changes in tox.ini to be compatible with it. Let\u0027s pin tox \u003c4"},{"line_number":204,"context_line":"    # for stable branches testing (\u003c\u003dstable/zed)."},{"line_number":205,"context_line":"    vars:"},{"line_number":206,"context_line":"      ensure_tox_version: \u0027\u003c4\u0027"},{"line_number":207,"context_line":"    check:"},{"line_number":208,"context_line":"      jobs:"},{"line_number":209,"context_line":"        - test-release-openstack:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"2c9919a0_15fb6e0c","line":206,"in_reply_to":"a4428f9a_784e9137","updated":"2023-01-06 09:43:42.000000000","message":"Done","commit_id":"95231e19595c2be98f12bd5803962069c25c55a7"}]}