)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f0a1a80f3baa7ba34139d2d754caad261934309c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9478c087_e29dcab8","updated":"2024-12-05 17:21:08.000000000","message":"Testing being done here:\n\nhttps://review.opendev.org/c/openstack/charm-mysql-innodb-cluster/+/937195","commit_id":"18b811ef611f3de8e1ade182fac2a36fc80e04bc"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"b7170d4406fc3a03887cc1a568d5d96194532bd9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4a3f97cd_4f0111ce","updated":"2024-12-05 19:39:58.000000000","message":"Dependedt job is passing.\nhttps://review.opendev.org/c/openstack/charm-mysql-innodb-cluster/+/935979","commit_id":"226cc9d0372249ae52f0f4b6d69db86e21550164"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7f6c293714a7fc0783ccee0936f9d23b82d092ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"306e9a7b_1e48dbe2","updated":"2024-12-10 19:58:27.000000000","message":"I\u0027m going to try and define this over in charm-zuul-jobs (which I didn\u0027t know existed) to keep them contained. If I can\u0027t get that to work I\u0027ll update this change accordingly.","commit_id":"226cc9d0372249ae52f0f4b6d69db86e21550164"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3c9c6ddbf5e8a9542888d15f9acfcda20fa4b4b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2690f967_e6da6bc1","updated":"2024-12-10 07:56:11.000000000","message":"I\u0027m wondering whether it might be easier for you to move this whole stack of job definitions into some charms repo and thus avoid the dependency on external reviewers","commit_id":"226cc9d0372249ae52f0f4b6d69db86e21550164"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9352d6d868b90bfc1108712bbe27fcc56810dbe8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4e4ee772_a403df63","in_reply_to":"2690f967_e6da6bc1","updated":"2024-12-10 15:33:22.000000000","message":"I see what you mean, I\u0027m just reluctant to move things as there are other \"charm\" jobs here too. Let me ping one of other charm maintainers for advice.","commit_id":"226cc9d0372249ae52f0f4b6d69db86e21550164"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"11eeb79b39be9976467e1f73f84b07f786de50b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"792d11c5_41ee9df2","updated":"2024-12-12 21:12:33.000000000","message":"I think we\u0027re going to go with https://review.opendev.org/c/openstack/charm-zuul-jobs/+/937479 to keep the definitions out of this repo, so this shouldn\u0027t be required.","commit_id":"79b6e257edb55869633cd986c8bff7bff12a9316"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"176c89489a5ea3d2d91efdc3a4a26382f7b7e5b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7ee046f7_d26ab511","updated":"2024-12-10 21:22:58.000000000","message":"So this does work as well, based on my test change\n\nhttps://review.opendev.org/c/openstack/charm-mysql-innodb-cluster/+/937195","commit_id":"79b6e257edb55869633cd986c8bff7bff12a9316"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"876327733fb24700191355e27794dd51a21086e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3a7d5d4a_cbd39748","updated":"2024-12-11 20:07:06.000000000","message":"commented in another approach also about using different name for those distro specific branches https://review.opendev.org/c/openstack/charm-zuul-jobs/+/937479","commit_id":"79b6e257edb55869633cd986c8bff7bff12a9316"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5a0b1c4f3475a0910bd6be023ae1fa99c6a2c00f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"075e1f02_99594a63","updated":"2024-12-11 19:55:20.000000000","message":"lgtm but one question is stable/\u003cdistro version\u003e branches common way in charms? I am wondering if it is and it can grow more in future then it make sense for charm not to use the generic template in those charm specific branches and you can define and use job from charms repo itself.","commit_id":"79b6e257edb55869633cd986c8bff7bff12a9316"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7e3c30078bddf62133dc4af4c11de2c56bb5b473","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fff51192_b4ac49b9","in_reply_to":"3a7d5d4a_cbd39748","updated":"2024-12-11 20:33:01.000000000","message":"NOTE: I chatted with haleyb on IRC to handle the charms specific stable branches (charms has stable branches nameing with openstack-release-way, distro-versions, just-version) in charm repo. \n\nWe can merge this to unblock the gate but it will be helpful if charm team can fix it in charm-zuul-jobs","commit_id":"79b6e257edb55869633cd986c8bff7bff12a9316"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5481c1f822d89401fc9063f5c5a9572b2a316834","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b24387d9_a3353aad","in_reply_to":"792d11c5_41ee9df2","updated":"2024-12-12 21:58:16.000000000","message":"thanks. agree/","commit_id":"79b6e257edb55869633cd986c8bff7bff12a9316"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2037666922a18c9e3caa616c6e443123431ce656","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa5f3a5a_b10b58c0","in_reply_to":"fff51192_b4ac49b9","updated":"2024-12-11 20:35:24.000000000","message":"\" fix it in charm-zuul-jobs\" I mean something like below:\n\nhttps://review.opendev.org/c/openstack/charm-zuul-jobs/+/937479","commit_id":"79b6e257edb55869633cd986c8bff7bff12a9316"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"750b3adb2be1b9ad6cf3a04bc75688051a07ec1d","unresolved":true,"context_lines":[{"line_number":475,"context_line":"      bindep_profile: test pep8"},{"line_number":476,"context_line":"      test_setup_skip: true"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"- job:"},{"line_number":479,"context_line":"    name: openstack-tox-pep8-charm-yoga"},{"line_number":480,"context_line":"    parent: openstack-tox"},{"line_number":481,"context_line":"    nodeset: ubuntu-jammy"},{"line_number":482,"context_line":"    # NOTE(haleyb): Must use jammy nodeset when running jobs on yoga releases"},{"line_number":483,"context_line":"    description: |"},{"line_number":484,"context_line":"      Runs code pep8 tests."},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"      Uses tox with the ``pep8`` environment."},{"line_number":487,"context_line":"    vars:"},{"line_number":488,"context_line":"      tox_envlist: pep8"},{"line_number":489,"context_line":"      bindep_profile: test pep8"},{"line_number":490,"context_line":"      test_setup_skip: true"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"- job:"},{"line_number":493,"context_line":"    name: openstack-tox-cover"},{"line_number":494,"context_line":"    parent: tox-cover"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4aa5eb92_bc48ac2f","line":491,"range":{"start_line":478,"start_character":0,"end_line":491,"end_character":0},"updated":"2024-12-10 17:57:22.000000000","message":"this should be handled by the branch variant in openstack-tox job. for yoga job definition which use nodeset focal should be used\n\n- https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/937194/2/zuul.d/jobs.yaml#44\n\ncan you please point it out where openstack-tox-pep8 on yoga using nobel nodeset? and we can find if something missing in openstack-tox branch handling","commit_id":"226cc9d0372249ae52f0f4b6d69db86e21550164"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"538bd585b8e59c4e0939657920f4379d06bcebe6","unresolved":false,"context_lines":[{"line_number":475,"context_line":"      bindep_profile: test pep8"},{"line_number":476,"context_line":"      test_setup_skip: true"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"- job:"},{"line_number":479,"context_line":"    name: openstack-tox-pep8-charm-yoga"},{"line_number":480,"context_line":"    parent: openstack-tox"},{"line_number":481,"context_line":"    nodeset: ubuntu-jammy"},{"line_number":482,"context_line":"    # NOTE(haleyb): Must use jammy nodeset when running jobs on yoga releases"},{"line_number":483,"context_line":"    description: |"},{"line_number":484,"context_line":"      Runs code pep8 tests."},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"      Uses tox with the ``pep8`` environment."},{"line_number":487,"context_line":"    vars:"},{"line_number":488,"context_line":"      tox_envlist: pep8"},{"line_number":489,"context_line":"      bindep_profile: test pep8"},{"line_number":490,"context_line":"      test_setup_skip: true"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"- job:"},{"line_number":493,"context_line":"    name: openstack-tox-cover"},{"line_number":494,"context_line":"    parent: tox-cover"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dabb45e5_9602999e","line":491,"range":{"start_line":478,"start_character":0,"end_line":491,"end_character":0},"in_reply_to":"45a06838_14b1d96b","updated":"2024-12-10 21:23:49.000000000","message":"Done","commit_id":"226cc9d0372249ae52f0f4b6d69db86e21550164"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7f6c293714a7fc0783ccee0936f9d23b82d092ff","unresolved":true,"context_lines":[{"line_number":475,"context_line":"      bindep_profile: test pep8"},{"line_number":476,"context_line":"      test_setup_skip: true"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"- job:"},{"line_number":479,"context_line":"    name: openstack-tox-pep8-charm-yoga"},{"line_number":480,"context_line":"    parent: openstack-tox"},{"line_number":481,"context_line":"    nodeset: ubuntu-jammy"},{"line_number":482,"context_line":"    # NOTE(haleyb): Must use jammy nodeset when running jobs on yoga releases"},{"line_number":483,"context_line":"    description: |"},{"line_number":484,"context_line":"      Runs code pep8 tests."},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"      Uses tox with the ``pep8`` environment."},{"line_number":487,"context_line":"    vars:"},{"line_number":488,"context_line":"      tox_envlist: pep8"},{"line_number":489,"context_line":"      bindep_profile: test pep8"},{"line_number":490,"context_line":"      test_setup_skip: true"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":"- job:"},{"line_number":493,"context_line":"    name: openstack-tox-cover"},{"line_number":494,"context_line":"    parent: tox-cover"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"45a06838_14b1d96b","line":491,"range":{"start_line":478,"start_character":0,"end_line":491,"end_character":0},"in_reply_to":"4aa5eb92_bc48ac2f","updated":"2024-12-10 19:58:27.000000000","message":"The problem is the branch name is stable/jammy, so it seems to use the job with the noble nodeset as it doesn\u0027t match the others. Having \u0027yoga\u0027 in the name is probably the wrong thing, I\u0027ll need to update.","commit_id":"226cc9d0372249ae52f0f4b6d69db86e21550164"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"750b3adb2be1b9ad6cf3a04bc75688051a07ec1d","unresolved":true,"context_lines":[{"line_number":554,"context_line":"      ensure_tox_version: \u0027\u003c4\u0027"},{"line_number":555,"context_line":"    timeout: 3000"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"- job:"},{"line_number":558,"context_line":"    name: openstack-tox-cover-charm-yoga"},{"line_number":559,"context_line":"    # NOTE(haleyb): Must use jammy nodeset when running jobs on yoga releases"},{"line_number":560,"context_line":"    parent: tox-cover"},{"line_number":561,"context_line":"    description: |"},{"line_number":562,"context_line":"      Run code coverage tests."},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"      Uses tox with the ``cover`` environment."},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"      This job runs on focal from stable/victoria until stable/zed."},{"line_number":567,"context_line":"    nodeset: ubuntu-jammy"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c17771e8_6af58849","line":564,"range":{"start_line":557,"start_character":0,"end_line":564,"end_character":46},"updated":"2024-12-10 17:57:22.000000000","message":"ditto","commit_id":"226cc9d0372249ae52f0f4b6d69db86e21550164"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"538bd585b8e59c4e0939657920f4379d06bcebe6","unresolved":false,"context_lines":[{"line_number":554,"context_line":"      ensure_tox_version: \u0027\u003c4\u0027"},{"line_number":555,"context_line":"    timeout: 3000"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"- job:"},{"line_number":558,"context_line":"    name: openstack-tox-cover-charm-yoga"},{"line_number":559,"context_line":"    # NOTE(haleyb): Must use jammy nodeset when running jobs on yoga releases"},{"line_number":560,"context_line":"    parent: tox-cover"},{"line_number":561,"context_line":"    description: |"},{"line_number":562,"context_line":"      Run code coverage tests."},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"      Uses tox with the ``cover`` environment."},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"      This job runs on focal from stable/victoria until stable/zed."},{"line_number":567,"context_line":"    nodeset: ubuntu-jammy"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"c046287e_8fc9880d","line":564,"range":{"start_line":557,"start_character":0,"end_line":564,"end_character":46},"in_reply_to":"c17771e8_6af58849","updated":"2024-12-10 21:23:49.000000000","message":"Done","commit_id":"226cc9d0372249ae52f0f4b6d69db86e21550164"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3c9c6ddbf5e8a9542888d15f9acfcda20fa4b4b1","unresolved":true,"context_lines":[{"line_number":563,"context_line":""},{"line_number":564,"context_line":"      Uses tox with the ``cover`` environment."},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"      This job runs on focal from stable/victoria until stable/zed."},{"line_number":567,"context_line":"    nodeset: ubuntu-jammy"},{"line_number":568,"context_line":"    required-projects:"},{"line_number":569,"context_line":"      - name: openstack/requirements"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1836de56_3d8fa503","line":566,"range":{"start_line":566,"start_character":23,"end_line":566,"end_character":28},"updated":"2024-12-10 07:56:11.000000000","message":"jammy?\n\nalso the branch names seem to be different for charms?","commit_id":"226cc9d0372249ae52f0f4b6d69db86e21550164"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9352d6d868b90bfc1108712bbe27fcc56810dbe8","unresolved":true,"context_lines":[{"line_number":563,"context_line":""},{"line_number":564,"context_line":"      Uses tox with the ``cover`` environment."},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"      This job runs on focal from stable/victoria until stable/zed."},{"line_number":567,"context_line":"    nodeset: ubuntu-jammy"},{"line_number":568,"context_line":"    required-projects:"},{"line_number":569,"context_line":"      - name: openstack/requirements"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6a57e720_c8ccacaf","line":566,"range":{"start_line":566,"start_character":23,"end_line":566,"end_character":28},"in_reply_to":"1836de56_3d8fa503","updated":"2024-12-10 15:33:22.000000000","message":"Bad copy paste.\n\nRegarding the branch names, for some charms they follow openstack naming, stable/2024.1, etc. For others that are not specific to openstack they are typically LTS names, like stable/noble, stable/jammy, etc. And to further complicate it this basically targeting jammy/yoga code.","commit_id":"226cc9d0372249ae52f0f4b6d69db86e21550164"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"538bd585b8e59c4e0939657920f4379d06bcebe6","unresolved":false,"context_lines":[{"line_number":563,"context_line":""},{"line_number":564,"context_line":"      Uses tox with the ``cover`` environment."},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"      This job runs on focal from stable/victoria until stable/zed."},{"line_number":567,"context_line":"    nodeset: ubuntu-jammy"},{"line_number":568,"context_line":"    required-projects:"},{"line_number":569,"context_line":"      - name: openstack/requirements"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"43f25d92_0ae13d61","line":566,"range":{"start_line":566,"start_character":23,"end_line":566,"end_character":28},"in_reply_to":"6a57e720_c8ccacaf","updated":"2024-12-10 21:23:49.000000000","message":"Done","commit_id":"226cc9d0372249ae52f0f4b6d69db86e21550164"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3c9c6ddbf5e8a9542888d15f9acfcda20fa4b4b1","unresolved":true,"context_lines":[{"line_number":569,"context_line":"      - name: openstack/requirements"},{"line_number":570,"context_line":"    irrelevant-files: *common-irrelevant-files"},{"line_number":571,"context_line":"    vars:"},{"line_number":572,"context_line":"      tox_constraints_file: \u0027{{ ansible_user_dir }}/src/opendev.org/openstack/requirements/upper-constraints.txt\u0027"},{"line_number":573,"context_line":"      # NOTE(gmann): This is stable branch (\u003c\u003d(stable|unmaintained)/zed) job and new"},{"line_number":574,"context_line":"      # tox 4 require some changes in tox.ini to be compatible with it. Let\u0027s"},{"line_number":575,"context_line":"      # pin tox \u003c4 for stable branches testing (\u003c\u003d(stable|unmaintained)/zed)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"18c29875_2f2c4bbd","line":572,"updated":"2024-12-10 07:56:11.000000000","message":"are global requirements actually used by charms? I\u0027d rather expect them to be based on what is available in uca","commit_id":"226cc9d0372249ae52f0f4b6d69db86e21550164"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9352d6d868b90bfc1108712bbe27fcc56810dbe8","unresolved":true,"context_lines":[{"line_number":569,"context_line":"      - name: openstack/requirements"},{"line_number":570,"context_line":"    irrelevant-files: *common-irrelevant-files"},{"line_number":571,"context_line":"    vars:"},{"line_number":572,"context_line":"      tox_constraints_file: \u0027{{ ansible_user_dir }}/src/opendev.org/openstack/requirements/upper-constraints.txt\u0027"},{"line_number":573,"context_line":"      # NOTE(gmann): This is stable branch (\u003c\u003d(stable|unmaintained)/zed) job and new"},{"line_number":574,"context_line":"      # tox 4 require some changes in tox.ini to be compatible with it. Let\u0027s"},{"line_number":575,"context_line":"      # pin tox \u003c4 for stable branches testing (\u003c\u003d(stable|unmaintained)/zed)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"82ec5c61_69b477e1","line":572,"in_reply_to":"18c29875_2f2c4bbd","updated":"2024-12-10 15:33:22.000000000","message":"I think they do use g-r","commit_id":"226cc9d0372249ae52f0f4b6d69db86e21550164"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"538bd585b8e59c4e0939657920f4379d06bcebe6","unresolved":false,"context_lines":[{"line_number":569,"context_line":"      - name: openstack/requirements"},{"line_number":570,"context_line":"    irrelevant-files: *common-irrelevant-files"},{"line_number":571,"context_line":"    vars:"},{"line_number":572,"context_line":"      tox_constraints_file: \u0027{{ ansible_user_dir }}/src/opendev.org/openstack/requirements/upper-constraints.txt\u0027"},{"line_number":573,"context_line":"      # NOTE(gmann): This is stable branch (\u003c\u003d(stable|unmaintained)/zed) job and new"},{"line_number":574,"context_line":"      # tox 4 require some changes in tox.ini to be compatible with it. Let\u0027s"},{"line_number":575,"context_line":"      # pin tox \u003c4 for stable branches testing (\u003c\u003d(stable|unmaintained)/zed)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5219ccdb_301c686f","line":572,"in_reply_to":"82ec5c61_69b477e1","updated":"2024-12-10 21:23:49.000000000","message":"Done","commit_id":"226cc9d0372249ae52f0f4b6d69db86e21550164"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3c9c6ddbf5e8a9542888d15f9acfcda20fa4b4b1","unresolved":true,"context_lines":[{"line_number":573,"context_line":"      # NOTE(gmann): This is stable branch (\u003c\u003d(stable|unmaintained)/zed) job and new"},{"line_number":574,"context_line":"      # tox 4 require some changes in tox.ini to be compatible with it. Let\u0027s"},{"line_number":575,"context_line":"      # pin tox \u003c4 for stable branches testing (\u003c\u003d(stable|unmaintained)/zed)."},{"line_number":576,"context_line":"      ensure_tox_version: \u0027\u003c4\u0027"},{"line_number":577,"context_line":"    timeout: 3000"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"6a87bb9e_63298568","line":576,"updated":"2024-12-10 07:56:11.000000000","message":"same for thix pin, is this actually relevant?","commit_id":"226cc9d0372249ae52f0f4b6d69db86e21550164"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"538bd585b8e59c4e0939657920f4379d06bcebe6","unresolved":false,"context_lines":[{"line_number":573,"context_line":"      # NOTE(gmann): This is stable branch (\u003c\u003d(stable|unmaintained)/zed) job and new"},{"line_number":574,"context_line":"      # tox 4 require some changes in tox.ini to be compatible with it. Let\u0027s"},{"line_number":575,"context_line":"      # pin tox \u003c4 for stable branches testing (\u003c\u003d(stable|unmaintained)/zed)."},{"line_number":576,"context_line":"      ensure_tox_version: \u0027\u003c4\u0027"},{"line_number":577,"context_line":"    timeout: 3000"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f221c39d_db1598b1","line":576,"in_reply_to":"2424b6e2_31ccfadd","updated":"2024-12-10 21:23:49.000000000","message":"Done","commit_id":"226cc9d0372249ae52f0f4b6d69db86e21550164"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9352d6d868b90bfc1108712bbe27fcc56810dbe8","unresolved":true,"context_lines":[{"line_number":573,"context_line":"      # NOTE(gmann): This is stable branch (\u003c\u003d(stable|unmaintained)/zed) job and new"},{"line_number":574,"context_line":"      # tox 4 require some changes in tox.ini to be compatible with it. Let\u0027s"},{"line_number":575,"context_line":"      # pin tox \u003c4 for stable branches testing (\u003c\u003d(stable|unmaintained)/zed)."},{"line_number":576,"context_line":"      ensure_tox_version: \u0027\u003c4\u0027"},{"line_number":577,"context_line":"    timeout: 3000"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"- job:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2424b6e2_31ccfadd","line":576,"in_reply_to":"6a87bb9e_63298568","updated":"2024-12-10 15:33:22.000000000","message":"Again, I copy/pasted the *yoga job definition from above (and it worked). The repo that is consuming this pins as well, so it\u0027s not technically needed, I just wanted to be consistent.","commit_id":"226cc9d0372249ae52f0f4b6d69db86e21550164"}]}