)]}'
{"id":"openstack%2Fopenstackdocstheme~487103","triplet_id":"openstack%2Fopenstackdocstheme~master~I47222a70e58267c409c0d8d2f0f460d54c5fa5dd","project":"openstack/openstackdocstheme","branch":"master","topic":"move-page-toc","hashtags":[],"change_id":"I47222a70e58267c409c0d8d2f0f460d54c5fa5dd","subject":"move the localtoc for the page into the sidebar","status":"MERGED","created":"2017-07-25 14:23:11.000000000","updated":"2017-07-26 09:39:09.000000000","submitted":"2017-07-26 09:39:09.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8a8450629dee3c6209b4650a3b40e14d6947bec7","_number":487103,"virtual_id_number":487103,"owner":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2017-07-26 09:39:09.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},{"value":0,"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2017-07-25 15:40:22.000000000","_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":1,"date":"2017-07-25 18:15:09.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},{"value":2,"date":"2017-07-26 09:34:47.000000000","_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},{"value":1,"date":"2017-07-26 09:34:47.000000000","_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-07-25 15:40:22.000000000","updated_by":{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},"reviewer":{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},"state":"REVIEWER"},{"updated":"2017-07-25 18:15:09.000000000","updated_by":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"reviewer":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"state":"REVIEWER"},{"updated":"2017-07-26 09:34:47.000000000","updated_by":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"reviewer":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"state":"REVIEWER"},{"updated":"2017-07-26 09:39:09.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"51390b3060b563169cf0a9254bb4906e97d44671","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2017-07-25 14:23:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7a6187257ac70033d8daba937372f05290450789","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-25 14:28:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstackdocstheme-pep8-ubuntu-xenial http://logs.openstack.org/03/487103/1/check/gate-openstackdocstheme-pep8-ubuntu-xenial/8cda8b4/ : SUCCESS in 2m 34s\n- gate-openstackdocstheme-docs-ubuntu-xenial http://docs-draft.openstack.org/03/487103/1/check/gate-openstackdocstheme-docs-ubuntu-xenial/54f8b6e//doc/build/html/ : SUCCESS in 1m 55s\n- gate-openstackdocstheme-api-ref http://docs-draft.openstack.org/03/487103/1/check/gate-openstackdocstheme-api-ref/5e71dbd//api-ref/build/html/ : SUCCESS in 2m 19s\n- gate-openstackdocstheme-tox-doc-publish-buildpdf http://logs.openstack.org/03/487103/1/check/gate-openstackdocstheme-tox-doc-publish-buildpdf/923f581/ : SUCCESS in 1m 53s","accounts_in_message":[],"_revision_number":1},{"id":"72ab11146f64187098f72a6993dd6f19c90f33e7","author":{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},"date":"2017-07-25 14:35:14.000000000","message":"Patch Set 1:\n\nI like the idea, but it seems repetitive in its current form, and there are bullets in the top toc and none in the bottom toc. So the scrolling problem persists?","accounts_in_message":[],"_revision_number":1},{"id":"da3fd9323cf432add3cff6bef94fb78abf2c42c4","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2017-07-25 14:47:38.000000000","message":"Patch Set 1:\n\n\u003e I like the idea, but it seems repetitive in its current form, and\n\nThere seem to be multiple modes for the sidebar toc and I wasn\u0027t fully clear what those were for. The default seems to show the top level entries from a given page in context of all of the documents in the repo. So if a page only has 1 level of headings, then yes this will be a bit repetitive. An alternative would be to just remove it entirely, but that doesn\u0027t help for pages with more than 2 levels of headings.\n\n \u003e there are bullets in the top toc and none in the bottom toc. So the\n \u003e scrolling problem persists?\n\nSee http://docs-draft.openstack.org/51/486751/1/check/gate-governance-docs-ubuntu-xenial/5b634e5//doc/build/html/goals/ocata/remove-incubated-oslo-code.html for a somewhat extreme example of the scrolling problem.","accounts_in_message":[],"_revision_number":1},{"id":"1040d312550c96199fbfdf48989c62ea16120d8e","author":{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},"date":"2017-07-25 15:06:24.000000000","message":"Patch Set 1:\n\nAh, the scrolling problem for lots of content in the right-hand pane, got it. I thought you meant a scrolling problem for the toc itself. Okay, so this looks like a nice solution for most pages, and for the API docs the toc will already behave correctly. So my only suggestion would be to either remove the bullets from the top, or add alignment to the bottom, to show these two tocs are related but different?","accounts_in_message":[],"_revision_number":1},{"id":"a2900c53f0c3d42e7f3b2b38bb46317a93208860","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2017-07-25 15:28:42.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cb7cd131c52ced0813cd8e4055365bb44527cb96","author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"date":"2017-07-25 15:31:14.000000000","message":"Patch Set 2:\n\n\u003e Ah, the scrolling problem for lots of content in the right-hand\n \u003e pane, got it. I thought you meant a scrolling problem for the toc\n \u003e itself. Okay, so this looks like a nice solution for most pages,\n \u003e and for the API docs the toc will already behave correctly. So my\n \u003e only suggestion would be to either remove the bullets from the top,\n \u003e or add alignment to the bottom, to show these two tocs are related\n \u003e but different?\n\nI went ahead and removed the bullets, because that was easier for me to make look consistent. I\u0027m not sure what you meant about the alignment? Indent it some?","accounts_in_message":[],"_revision_number":2},{"id":"87921e4bf98c637d7d72409f6af3ed5e6b8f5b66","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-25 15:36:09.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-openstackdocstheme-pep8-ubuntu-xenial http://logs.openstack.org/03/487103/2/check/gate-openstackdocstheme-pep8-ubuntu-xenial/e809c05/ : SUCCESS in 1m 40s\n- gate-openstackdocstheme-docs-ubuntu-xenial http://docs-draft.openstack.org/03/487103/2/check/gate-openstackdocstheme-docs-ubuntu-xenial/d595f77//doc/build/html/ : SUCCESS in 4m 43s\n- gate-openstackdocstheme-api-ref http://docs-draft.openstack.org/03/487103/2/check/gate-openstackdocstheme-api-ref/17f2b90//api-ref/build/html/ : SUCCESS in 1m 24s\n- gate-openstackdocstheme-tox-doc-publish-buildpdf http://logs.openstack.org/03/487103/2/check/gate-openstackdocstheme-tox-doc-publish-buildpdf/9d4eec4/ : SUCCESS in 3m 09s","accounts_in_message":[],"_revision_number":2},{"id":"a19f0372772ca5a608b081b471613a101ab22397","author":{"_account_id":964,"name":"Anne Gentle","email":"annegentle@justwriteclick.com","username":"annegentle"},"date":"2017-07-25 15:40:22.000000000","message":"Patch Set 2: Code-Review+2\n\nYes, exactly! By removing the bullets and aligning the top level but not the secondary, you show they\u0027re different TOCs. Let\u0027s go with it.","accounts_in_message":[],"_revision_number":2},{"id":"83e024758a09333c81c7f603f6a0e151b1a6b0b0","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2017-07-25 18:15:09.000000000","message":"Patch Set 2: Code-Review+1\n\nhttp://docs-draft.openstack.org/03/487103/2/check/gate-openstackdocstheme-docs-ubuntu-xenial/d595f77/doc/build/html/demo/index.html looks much better--thanks!","accounts_in_message":[],"_revision_number":2},{"id":"976f516bbcea4816ccdc35b8a9517df53f25bef7","author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"date":"2017-07-26 09:34:47.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"291b6a0ff66e17cad0455b31755bcccc8f8f799a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-26 09:34:57.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"04c4772f7d34f7e793e1f6a74318c75190e257a9","date":"2017-07-26 09:39:09.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"b7fae71f0b727e5f2de95e8e03f3c1540c93bc8d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-26 09:39:09.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-openstackdocstheme-pep8-ubuntu-xenial http://logs.openstack.org/03/487103/2/gate/gate-openstackdocstheme-pep8-ubuntu-xenial/f28be25/ : SUCCESS in 2m 46s\n- gate-openstackdocstheme-docs-ubuntu-xenial http://docs-draft.openstack.org/03/487103/2/gate/gate-openstackdocstheme-docs-ubuntu-xenial/caedb50//doc/build/html/ : SUCCESS in 2m 41s\n- gate-openstackdocstheme-api-ref http://docs-draft.openstack.org/03/487103/2/gate/gate-openstackdocstheme-api-ref/dc7ca84//api-ref/build/html/ : SUCCESS in 2m 41s\n- gate-openstackdocstheme-tox-doc-publish-buildpdf http://logs.openstack.org/03/487103/2/gate/gate-openstackdocstheme-tox-doc-publish-buildpdf/7127693/ : SUCCESS in 2m 05s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9664113d83263c55a3051c8189d3782cf4e56278","revisions":{"5d8d6e86decf6d08a7ddeee3412d195d4c52945b":{"kind":"REWORK","_number":1,"created":"2017-07-25 14:23:11.000000000","uploader":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"ref":"refs/changes/03/487103/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstackdocstheme","ref":"refs/changes/03/487103/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/03/487103/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/03/487103/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/03/487103/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstackdocstheme refs/changes/03/487103/1"}}},"commit":{"parents":[{"commit":"d602fa119b1ae7daa2636543d3823ee73889c5b1","subject":"Merge \"Fix Added / Changed / Deprecated notices\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/d602fa119b1ae7daa2636543d3823ee73889c5b1"}]}],"author":{"name":"Doug Hellmann","email":"doug@doughellmann.com","date":"2017-07-25 14:20:44.000000000","tz":-240},"committer":{"name":"Doug Hellmann","email":"doug@doughellmann.com","date":"2017-07-25 14:20:44.000000000","tz":-240},"subject":"move the localtoc for the page into the sidebar","message":"move the localtoc for the page into the sidebar\n\nHaving a page table of contents at the top of pages with a lot of\nsections means that users have to scroll down significantly before\nthey see any real content. Move the page toc into the sidebar to avoid\nthe need for scrolling.\n\nThe old theme style information for the page toc is updated to reflect\nthe new location.\n\nThe example docs in demo/index.rst are updated to include nested\nheadings for testing the layout of the list.\n\nChange-Id: I47222a70e58267c409c0d8d2f0f460d54c5fa5dd\nSigned-off-by: Doug Hellmann \u003cdoug@doughellmann.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/5d8d6e86decf6d08a7ddeee3412d195d4c52945b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/5d8d6e86decf6d08a7ddeee3412d195d4c52945b"}]},"branch":"refs/heads/master"},"9664113d83263c55a3051c8189d3782cf4e56278":{"kind":"REWORK","_number":2,"created":"2017-07-25 15:28:42.000000000","uploader":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"ref":"refs/changes/03/487103/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstackdocstheme","ref":"refs/changes/03/487103/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/03/487103/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/03/487103/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/03/487103/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstackdocstheme refs/changes/03/487103/2"}}},"commit":{"parents":[{"commit":"d602fa119b1ae7daa2636543d3823ee73889c5b1","subject":"Merge \"Fix Added / Changed / Deprecated notices\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/d602fa119b1ae7daa2636543d3823ee73889c5b1"}]}],"author":{"name":"Doug Hellmann","email":"doug@doughellmann.com","date":"2017-07-25 14:20:44.000000000","tz":-240},"committer":{"name":"Doug Hellmann","email":"doug@doughellmann.com","date":"2017-07-25 15:27:54.000000000","tz":-240},"subject":"move the localtoc for the page into the sidebar","message":"move the localtoc for the page into the sidebar\n\nHaving a page table of contents at the top of the content section of\npages with a lot of section headings means that users have to scroll\ndown significantly before they see any real content. Move the page toc\ninto the sidebar to avoid the need for scrolling.\n\nThe old theme style information for the page toc is updated to reflect\nthe new location.\n\nThe example docs in demo/index.rst are updated to include nested\nheadings for testing the layout of the list.\n\nChange-Id: I47222a70e58267c409c0d8d2f0f460d54c5fa5dd\nSigned-off-by: Doug Hellmann \u003cdoug@doughellmann.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/9664113d83263c55a3051c8189d3782cf4e56278"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/9664113d83263c55a3051c8189d3782cf4e56278"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
