)]}'
{"id":"openstack%2Fopenstackdocstheme~534081","triplet_id":"openstack%2Fopenstackdocstheme~master~I65dd41cbd83dbf6c1ff78f3bb1a2f0e9dfe8c51c","project":"openstack/openstackdocstheme","branch":"master","topic":"giturl-neutron","hashtags":[],"change_id":"I65dd41cbd83dbf6c1ff78f3bb1a2f0e9dfe8c51c","subject":"Fix the Neutron API Reference cannot derive source file URL","status":"ABANDONED","created":"2018-01-16 05:18:44.000000000","updated":"2018-01-17 10:04:00.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6db9dd0bea85caae4820e8c239f9f8f2905323c7","_number":534081,"virtual_id_number":534081,"owner":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"date":"2018-01-17 10:02:49.000000000","_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},{"value":1,"date":"2018-01-16 06:15:14.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"all":[{"value":-2,"date":"2018-01-16 05:57:58.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-16 05:57:58.000000000","updated_by":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"reviewer":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"state":"REVIEWER"},{"updated":"2018-01-16 06:15:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6320bd68f01bc1e9941be5e68cd23b908f606a64","author":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"date":"2018-01-16 05:18:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c164fd213bffd3e0b415a3baf7430b10f1797ab9","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2018-01-16 05:57:58.000000000","message":"Patch Set 1: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b2cdb7113cb2b19fead109d84f85dcb380af082a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-16 06:15:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/81/534081/1/check/build-openstack-sphinx-docs/56e4631/html/ : SUCCESS in 5m 02s\n- openstack-tox-pep8 http://logs.openstack.org/81/534081/1/check/openstack-tox-pep8/74a3d87/ : SUCCESS in 4m 00s\n- build-tox-manuals-buildpdf http://logs.openstack.org/81/534081/1/check/build-tox-manuals-buildpdf/c0506fe/publish-docs/ : SUCCESS in 4m 44s","accounts_in_message":[],"_revision_number":1},{"id":"3c39a0c3486e55f9b92832c4370b6bf8c98babea","author":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"date":"2018-01-16 07:23:02.000000000","message":"Patch Set 1:\n\n\u003e (1 comment)\n\nIf you can, check https://developer.openstack.org/api-ref/network/ pls.","accounts_in_message":[],"_revision_number":1},{"id":"ea827099320329ca21ca18d3847fe9dff7ea6897","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2018-01-16 07:26:52.000000000","message":"Patch Set 1:\n\nPUblished from neutron-lib, see:\nhttps://developer.openstack.org/api-ref/network/.root-marker\n\nSo, fix neutron-lib.\n\nI expect that openstackdocstheme 1.18.1 fixes this...","accounts_in_message":[],"_revision_number":1},{"id":"3628d1782ef0f875df80cf84c570e94a9f0d6d7f","author":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"date":"2018-01-16 07:47:04.000000000","message":"Patch Set 1:\n\nMaybe not. I try to report a bug at https://developer.openstack.org/api-ref/network/. And the pre-filled bug description shows:\n\nSource: Can\u0027t derive source file URL\n\nPlease check line 40-52, the \"if giturl and pagename\" section is not excuted. \"giturl\" is none. We find the path by \"source\" directory[1]. And the \"api-ref\" directory doesn\u0027t contains a \"source\" dir in neutron repo. This is why giturl is none, and openstackdocstheme cannot derive source file URL.\n\nhttps://github.com/openstack/openstackdocstheme/blob/master/openstackdocstheme/__init__.py#L76","accounts_in_message":[],"_revision_number":1},{"id":"810ad50fa3f1778abf9c8b60ac46e30adcb2e50a","author":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"date":"2018-01-16 07:48:49.000000000","message":"Patch Set 1:\n\n\u003e Maybe not. I try to report a bug at https://developer.openstack.org/api-ref/network/.\n \u003e And the pre-filled bug description shows:\n \u003e \n \u003e Source: Can\u0027t derive source file URL\n \u003e \n \u003e Please check line 40-52, the \"if giturl and pagename\" section is\n \u003e not excuted. \"giturl\" is none. We find the path by \"source\"\n \u003e directory[1]. And the \"api-ref\" directory doesn\u0027t contains a\n \u003e \"source\" dir in neutron repo. This is why giturl is none, and\n \u003e openstackdocstheme cannot derive source file URL.\n \u003e \n \u003e https://github.com/openstack/openstackdocstheme/blob/master/openstackdocstheme/__init__.py#L76\n\nline 40-52 at https://github.com/openstack/openstackdocstheme/blob/master/openstackdocstheme/theme/openstackdocs/script_footer.html#L40","accounts_in_message":[],"_revision_number":1},{"id":"81fbb4e9b820e6a2a90b99c7b6bf12eab86d15a6","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2018-01-16 08:30:43.000000000","message":"Patch Set 1:\n\nthe string you cite was introduced in openstackdocstheme 1.18.0 and that change contained a bug that is fixed in 1.18.1.\n\nYou\u0027re changing the wrong thing. Test building of neutron-lib with openstackdocstheme 1.18.1 and see whether the problem still exists.","accounts_in_message":[],"_revision_number":1},{"id":"976eb9f0526f5a36e6a329bd2fbaf89753e9f9f7","author":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"date":"2018-01-16 09:30:25.000000000","message":"Patch Set 1:\n\n\u003e the string you cite was introduced in openstackdocstheme 1.18.0 and\n \u003e that change contained a bug that is fixed in 1.18.1.\n \u003e \n \u003e You\u0027re changing the wrong thing. Test building of neutron-lib with\n \u003e openstackdocstheme 1.18.1 and see whether the problem still exists.\n\nDid you mean this fix: https://review.openstack.org/#/c/532965/ ?","accounts_in_message":[],"_revision_number":1},{"id":"771a49da57fbcd6aa27df790e88d3f48f59b86c0","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2018-01-16 11:35:54.000000000","message":"Patch Set 1:\n\nyes, https://review.openstack.org/#/c/532163/ is the fix.","accounts_in_message":[],"_revision_number":1},{"id":"d64708546ed52720b50843213d34a79b2d16d850","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2018-01-17 08:40:00.000000000","message":"Patch Set 1:\n\nbtw. there is still an error - 532163 does not fix it. But this does not fix it either...","accounts_in_message":[],"_revision_number":1},{"id":"27ab6bffe200ddbeb478d5b2e5e3da4382f0a23e","author":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"date":"2018-01-17 10:02:49.000000000","message":"Patch Set 1:\n\nThx, Andreas, I will check it. :)","accounts_in_message":[],"_revision_number":1},{"id":"25e75abaa7da416ba05aa49c4eb31e9d5f1c0589","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2018-01-17 10:03:54.000000000","message":"Patch Set 1:\n\nSee here for fix details:\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2018-January/126297.html","accounts_in_message":[],"_revision_number":1},{"id":"3ece1a62c9c1dda862335df6ab1c33b59bd86c53","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2018-01-17 10:04:00.000000000","message":"Abandoned\n\nThis is wrong.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a0371a689a35ee6361b201b6110e2fee21299814","revisions":{"a0371a689a35ee6361b201b6110e2fee21299814":{"kind":"REWORK","_number":1,"created":"2018-01-16 05:18:44.000000000","uploader":{"_account_id":16523,"name":"ZhangLei","display_name":"ZhangLei","email":"zhang.lei@99cloud.net","username":"zhang.lei"},"ref":"refs/changes/81/534081/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstackdocstheme","ref":"refs/changes/81/534081/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/81/534081/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/81/534081/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/81/534081/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstackdocstheme refs/changes/81/534081/1"}}},"commit":{"parents":[{"commit":"93f717417b98a3527f922c11abb9f351068ebdfe","subject":"Fix giturl parsing","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/93f717417b98a3527f922c11abb9f351068ebdfe"}]}],"author":{"name":"zhang.lei","email":"zhang.lei@99cloud.net","date":"2018-01-16 05:04:46.000000000","tz":0},"committer":{"name":"zhang.lei","email":"zhang.lei@99cloud.net","date":"2018-01-16 05:04:46.000000000","tz":0},"subject":"Fix the Neutron API Reference cannot derive source file URL","message":"Fix the Neutron API Reference cannot derive source file URL\n\nThe neutron api-ref is moved to neutron-lib project. We should\ndeal with it specially.\n\nChange-Id: I65dd41cbd83dbf6c1ff78f3bb1a2f0e9dfe8c51c\nDepends-On: I918deba2392945c2cb366cfca84f1b8dccd0892a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/a0371a689a35ee6361b201b6110e2fee21299814"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/a0371a689a35ee6361b201b6110e2fee21299814"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
