)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2580c9417f06956ffdb8930ffd65c9a61efdf608","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"hint: ugly name like openstackdocumentationcontributorguide breaks"},{"line_number":10,"context_line":"the page layout, i.e."},{"line_number":11,"context_line":"http://logs.openstack.org/19/555819/2/check/build-tox-manuals-checkbuild/4d5500d/publish-docs/doc-contrib-guide/index.html"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"depends on the count of words and the length of the name it will use"},{"line_number":14,"context_line":"name or summary."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9f6a8fd7_2d8dbb30","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":122},"updated":"2018-05-02 16:24:15.000000000","message":"This won\u0027t work in a few weeks so I\u0027d drop it. What would be more useful is to give an example of the \u0027setup.cfg\u0027 file to show what we\u0027re going to use instead","commit_id":"34ce26a4c6907e9d44672e1e414736f30f2361b2"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"895f340a5c36388fed891cea49ecc4c5dcc89c4a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"hint: ugly name like openstackdocumentationcontributorguide breaks"},{"line_number":10,"context_line":"the page layout, i.e."},{"line_number":11,"context_line":"http://logs.openstack.org/19/555819/2/check/build-tox-manuals-checkbuild/4d5500d/publish-docs/doc-contrib-guide/index.html"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"depends on the count of words and the length of the name it will use"},{"line_number":14,"context_line":"name or summary."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_278b706e","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":122},"in_reply_to":"9f6a8fd7_2d8dbb30","updated":"2018-05-10 21:30:07.000000000","message":"Done","commit_id":"34ce26a4c6907e9d44672e1e414736f30f2361b2"}],"openstackdocstheme/ext.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2580c9417f06956ffdb8930ffd65c9a61efdf608","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            return None"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        try:"},{"line_number":187,"context_line":"            metadata \u003d parser.get(\u0027metadata\u0027, \u0027name\u0027)"},{"line_number":188,"context_line":"            if len(metadata.split()) \u003d\u003d 1 and len(metadata) \u003e 32:"},{"line_number":189,"context_line":"                project \u003d parser.get(\u0027metadata\u0027, \u0027summary\u0027)"},{"line_number":190,"context_line":"            else:"},{"line_number":191,"context_line":"                project \u003d parser.get(\u0027metadata\u0027, \u0027name\u0027)"},{"line_number":192,"context_line":"        except configparser.Error:"},{"line_number":193,"context_line":"            logger.info(\u0027Could not extract project metadata from setup.cfg\u0027)"},{"line_number":194,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_6dd5f3e4","line":191,"range":{"start_line":187,"start_character":0,"end_line":191,"end_character":56},"updated":"2018-05-02 16:24:15.000000000","message":"nit: You should add a comment explaining why this is done. Also, this could be simplified like so:\n\n    project \u003d parser.get(\u0027metadata\u0027, \u0027name\u0027)\n    if len(project.split()) \u003d\u003d 1 and len(project) \u003e 32:\n        project \u003d parser.get(\u0027metadata\u0027, \u0027summary\u0027)\n\nThis avoids extracting things twice","commit_id":"34ce26a4c6907e9d44672e1e414736f30f2361b2"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"895f340a5c36388fed891cea49ecc4c5dcc89c4a","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            return None"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        try:"},{"line_number":187,"context_line":"            metadata \u003d parser.get(\u0027metadata\u0027, \u0027name\u0027)"},{"line_number":188,"context_line":"            if len(metadata.split()) \u003d\u003d 1 and len(metadata) \u003e 32:"},{"line_number":189,"context_line":"                project \u003d parser.get(\u0027metadata\u0027, \u0027summary\u0027)"},{"line_number":190,"context_line":"            else:"},{"line_number":191,"context_line":"                project \u003d parser.get(\u0027metadata\u0027, \u0027name\u0027)"},{"line_number":192,"context_line":"        except configparser.Error:"},{"line_number":193,"context_line":"            logger.info(\u0027Could not extract project metadata from setup.cfg\u0027)"},{"line_number":194,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_476b0c84","line":191,"range":{"start_line":187,"start_character":0,"end_line":191,"end_character":56},"in_reply_to":"9f6a8fd7_6dd5f3e4","updated":"2018-05-10 21:30:07.000000000","message":"Done","commit_id":"34ce26a4c6907e9d44672e1e414736f30f2361b2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"25967e8953b7bfea248f1a3cd6dccfce245dbffc","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    # TODO(stephenfin): Once Sphinx 1.8 is released, we should move the below"},{"line_number":210,"context_line":"    # to a \u0027config-inited\u0027 handler"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    project_name \u003d _get_project_name(app.srcdir)"},{"line_number":213,"context_line":"    try:"},{"line_number":214,"context_line":"        version \u003d packaging.get_version(project_name)"},{"line_number":215,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_2d17fba5","line":212,"range":{"start_line":212,"start_character":4,"end_line":212,"end_character":48},"updated":"2018-05-02 16:25:40.000000000","message":"We could also check to see if this was configured already and use it if so. I opted not to do this as I figured automation was better, but it seems there are cases where that might not be true","commit_id":"34ce26a4c6907e9d44672e1e414736f30f2361b2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d4fc983a149194af4d892e98223acac4f29374ca","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    # TODO(stephenfin): Once Sphinx 1.8 is released, we should move the below"},{"line_number":210,"context_line":"    # to a \u0027config-inited\u0027 handler"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    project_name \u003d _get_project_name(app.srcdir)"},{"line_number":213,"context_line":"    try:"},{"line_number":214,"context_line":"        version \u003d packaging.get_version(project_name)"},{"line_number":215,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a932e9f0","line":212,"range":{"start_line":212,"start_character":4,"end_line":212,"end_character":48},"in_reply_to":"5f7c97a3_2735b08f","updated":"2018-05-11 13:04:40.000000000","message":"I was suggesting an alternative approach, though I left the comment in the wrong place...","commit_id":"34ce26a4c6907e9d44672e1e414736f30f2361b2"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"895f340a5c36388fed891cea49ecc4c5dcc89c4a","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    # TODO(stephenfin): Once Sphinx 1.8 is released, we should move the below"},{"line_number":210,"context_line":"    # to a \u0027config-inited\u0027 handler"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    project_name \u003d _get_project_name(app.srcdir)"},{"line_number":213,"context_line":"    try:"},{"line_number":214,"context_line":"        version \u003d packaging.get_version(project_name)"},{"line_number":215,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_2735b08f","line":212,"range":{"start_line":212,"start_character":4,"end_line":212,"end_character":48},"in_reply_to":"9f6a8fd7_2d17fba5","updated":"2018-05-10 21:30:07.000000000","message":"I don\u0027t know what is to do here.","commit_id":"34ce26a4c6907e9d44672e1e414736f30f2361b2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d4fc983a149194af4d892e98223acac4f29374ca","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    except Exception:"},{"line_number":216,"context_line":"        version \u003d None"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    # NOTE(stephenfin): Chances are that whatever\u0027s in \u0027conf.py\u0027 is probably"},{"line_number":219,"context_line":"    # wrong/outdated so, if we can, we intentionally overwrite it..."},{"line_number":220,"context_line":"    if project_name:"},{"line_number":221,"context_line":"        app.config.project \u003d project_name"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    app.config.html_last_updated_fmt \u003d \u0027%Y-%m-%d %H:%M\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_c944054a","line":220,"range":{"start_line":218,"start_character":0,"end_line":220,"end_character":20},"updated":"2018-05-11 13:04:40.000000000","message":"What I meant is that we could modify this like so:\n\n  if project_name and not app.config.project:\n      app.config.project \u003d project_name\n\nThat way, we\u0027d continue to use the manually defined setting if it\u0027s provided","commit_id":"34ce26a4c6907e9d44672e1e414736f30f2361b2"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"50585550d723c345a5c53a0398246bffc5051f70","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        try:"},{"line_number":187,"context_line":"            # for project name we use the name in setup.cfg, but if the"},{"line_number":188,"context_line":"            # length is longer then 32 we use summary. Otherwise thAe"},{"line_number":189,"context_line":"            # menu rendering looks brolen"},{"line_number":190,"context_line":"            project \u003d parser.get(\u0027metadata\u0027, \u0027name\u0027)"},{"line_number":191,"context_line":"            if len(project.split()) \u003d\u003d 1 and len(project) \u003e 32:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_e96a21b1","line":188,"range":{"start_line":188,"start_character":65,"end_line":188,"end_character":69},"updated":"2018-05-11 13:06:06.000000000","message":"the","commit_id":"445e7c1347fab245ce708fe6ebb16644a5a80931"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"50585550d723c345a5c53a0398246bffc5051f70","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        try:"},{"line_number":187,"context_line":"            # for project name we use the name in setup.cfg, but if the"},{"line_number":188,"context_line":"            # length is longer then 32 we use summary. Otherwise thAe"},{"line_number":189,"context_line":"            # menu rendering looks brolen"},{"line_number":190,"context_line":"            project \u003d parser.get(\u0027metadata\u0027, \u0027name\u0027)"},{"line_number":191,"context_line":"            if len(project.split()) \u003d\u003d 1 and len(project) \u003e 32:"},{"line_number":192,"context_line":"                project \u003d parser.get(\u0027metadata\u0027, \u0027summary\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_a960a9d0","line":189,"range":{"start_line":189,"start_character":35,"end_line":189,"end_character":41},"updated":"2018-05-11 13:06:06.000000000","message":"broken","commit_id":"445e7c1347fab245ce708fe6ebb16644a5a80931"}]}