)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"4e036e78b3173c3c8b5687409c5d58b5952d3cf5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix docstheme-build-translated.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"project docs will not built the different books in 1.28"},{"line_number":10,"context_line":"add missing releasenotes for new feature"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I1486139fdbdef5dd4e00a38c9cb751a5ed7881c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_2cea4076","line":9,"updated":"2018-12-09 09:47:50.000000000","message":"could you show me an example that does not work and explain what failed.","commit_id":"d78bc806edd2b99c94b9a3e15c178b1567c871f4"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"d160a1e47c60301754d8edc090b7593af102ee18","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix docstheme-build-translated.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"project docs will not built the different books in 1.28"},{"line_number":10,"context_line":"add missing releasenotes for new feature"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I1486139fdbdef5dd4e00a38c9cb751a5ed7881c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_47cd1590","line":9,"in_reply_to":"3f79a3b5_2cea4076","updated":"2018-12-09 12:35:41.000000000","message":"it won\u0027t work on any project repos whit the project doc structure. Because of that Ian made all that changes which I only copied here. \nexample: http://logs.openstack.org/29/623429/2/check/openstack-tox-docs/ebbf551/html/de/admin/index.html","commit_id":"d78bc806edd2b99c94b9a3e15c178b1567c871f4"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"4e036e78b3173c3c8b5687409c5d58b5952d3cf5","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix docstheme-build-translated.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"project docs will not built the different books in 1.28"},{"line_number":10,"context_line":"add missing releasenotes for new feature"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I1486139fdbdef5dd4e00a38c9cb751a5ed7881c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_6cda78e7","line":10,"updated":"2018-12-09 09:47:50.000000000","message":"Missing? Check http://git.openstack.org/cgit/openstack/openstackdocstheme/tree/releasenotes/notes/add-translations-9238b0f56b677a6b.yaml","commit_id":"d78bc806edd2b99c94b9a3e15c178b1567c871f4"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"d160a1e47c60301754d8edc090b7593af102ee18","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix docstheme-build-translated.sh"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"project docs will not built the different books in 1.28"},{"line_number":10,"context_line":"add missing releasenotes for new feature"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I1486139fdbdef5dd4e00a38c9cb751a5ed7881c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_07d39d37","line":10,"in_reply_to":"3f79a3b5_6cda78e7","updated":"2018-12-09 12:35:41.000000000","message":"indeed. Would then only add an example of usage.","commit_id":"d78bc806edd2b99c94b9a3e15c178b1567c871f4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"45c901526a70ce28a59b6f65295428da320f6154","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The user can choose"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- if warnings should be ignored (SKIP_SPHINX_WARNINGS\u003d1)"},{"line_number":12,"context_line":"- if warnings on translation build should be on (SPHINX_WARNINGS_TRANS\u003d1)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"added an example to the previously releasenotes"},{"line_number":15,"context_line":"remove the duplicate releasenote"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_0ac5a45e","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":73},"updated":"2018-12-12 09:33:15.000000000","message":"This doesn\u0027t explain _why_ we need this. Are there broken builds in the wild? Could we not fix those builds rather than encouraging broken behavior like this?","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"c4665e6ba5ab3b851857c310e092519f51b021a9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The user can choose"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- if warnings should be ignored (SKIP_SPHINX_WARNINGS\u003d1)"},{"line_number":12,"context_line":"- if warnings on translation build should be on (SPHINX_WARNINGS_TRANS\u003d1)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"added an example to the previously releasenotes"},{"line_number":15,"context_line":"remove the duplicate releasenote"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_25a4514d","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":73},"in_reply_to":"3f79a3b5_0ac5a45e","updated":"2018-12-12 10:35:00.000000000","message":"the current working build without -W but lot of warnings\n\nhttp://logs.openstack.org/46/611146/7/check/openstack-tox-docs/4475a4d/job-output.txt.gz#_2018-12-11_22_39_37_227482\n\nbroken build with -W\nhttp://logs.openstack.org/29/623429/1/check/openstack-tox-docs/be60c48/job-output.txt.gz#_2018-12-08_06_01_26_522782\n\nthat are mostly deeply errors like duplicate label on included rst files. I mentioned that before.It could be impossible to fix that kind of warnings, so it would be a good idea to have that option from user perspective.","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"45c901526a70ce28a59b6f65295428da320f6154","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- if warnings on translation build should be on (SPHINX_WARNINGS_TRANS\u003d1)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"added an example to the previously releasenotes"},{"line_number":15,"context_line":"remove the duplicate releasenote"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I1486139fdbdef5dd4e00a38c9cb751a5ed7881c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_0a3124f0","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":32},"updated":"2018-12-12 09:33:15.000000000","message":"I don\u0027t see anything being removed?","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"76ecc21853dfc34371bbf3eba86cacf8293093b9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- if warnings on translation build should be on (SPHINX_WARNINGS_TRANS\u003d1)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"added an example to the previously releasenotes"},{"line_number":15,"context_line":"remove the duplicate releasenote"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I1486139fdbdef5dd4e00a38c9cb751a5ed7881c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_ca580c28","line":15,"range":{"start_line":15,"start_character":1,"end_line":15,"end_character":32},"updated":"2018-12-12 09:24:04.000000000","message":"Remove? That line is wrong.","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"c4665e6ba5ab3b851857c310e092519f51b021a9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- if warnings on translation build should be on (SPHINX_WARNINGS_TRANS\u003d1)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"added an example to the previously releasenotes"},{"line_number":15,"context_line":"remove the duplicate releasenote"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I1486139fdbdef5dd4e00a38c9cb751a5ed7881c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_45d2ad34","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":32},"in_reply_to":"3f79a3b5_0a3124f0","updated":"2018-12-12 10:35:00.000000000","message":"it was in the previous patch version","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"4d19f8fa479acf859f30359cc9025d7d17b1a521","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- if warnings on translation build should be on (SPHINX_WARNINGS_TRANS\u003d1)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"added an example to the previously releasenotes"},{"line_number":15,"context_line":"remove the duplicate releasenote"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I1486139fdbdef5dd4e00a38c9cb751a5ed7881c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_c689e41d","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":32},"in_reply_to":"3f79a3b5_45d2ad34","updated":"2018-12-12 11:25:53.000000000","message":"a commit message is not the place to explain what you change between versions - add that as a comment instead.\n\nSo, remove the line - a first time reviewer needs to understand it.","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"d262abeb5388c3cd7296f56465ed30367aec8eb1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"- if warnings on translation build should be on (SPHINX_WARNINGS_TRANS\u003d1)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"added an example to the previously releasenotes"},{"line_number":15,"context_line":"remove the duplicate releasenote"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I1486139fdbdef5dd4e00a38c9cb751a5ed7881c6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1f769fc5_f7ba5ddc","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":32},"in_reply_to":"3f79a3b5_c689e41d","updated":"2019-01-02 10:51:26.000000000","message":"Done","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"}],"bin/docstheme-build-translated.sh":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"4e036e78b3173c3c8b5687409c5d58b5952d3cf5","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    done"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    # build translated guide"},{"line_number":143,"context_line":"    # TODO(amotoki): Enable -W option in translated version"},{"line_number":144,"context_line":"    sphinx-build -a -b html -D language\u003d${language} \\"},{"line_number":145,"context_line":"        -d ${DIRECTORY}/build/doctrees.languages/${language} \\"},{"line_number":146,"context_line":"        ${DIRECTORY}/source ${DIRECTORY}/build/html/${language}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_8ceef481","side":"PARENT","line":143,"updated":"2018-12-09 09:47:50.000000000","message":"this means that we will break most documents since many translated documents currently build with failures.\n\nMake it a command line switch or separate option.","commit_id":"a0684ace5e49ef935bd314928dc1acde3da6e11a"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"d160a1e47c60301754d8edc090b7593af102ee18","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    done"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    # build translated guide"},{"line_number":143,"context_line":"    # TODO(amotoki): Enable -W option in translated version"},{"line_number":144,"context_line":"    sphinx-build -a -b html -D language\u003d${language} \\"},{"line_number":145,"context_line":"        -d ${DIRECTORY}/build/doctrees.languages/${language} \\"},{"line_number":146,"context_line":"        ${DIRECTORY}/source ${DIRECTORY}/build/html/${language}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_87bfadc9","side":"PARENT","line":143,"in_reply_to":"3f79a3b5_8ceef481","updated":"2018-12-09 12:35:41.000000000","message":"ok","commit_id":"a0684ace5e49ef935bd314928dc1acde3da6e11a"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"4e036e78b3173c3c8b5687409c5d58b5952d3cf5","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    done"},{"line_number":101,"context_line":"}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"sphinx-build -a ${SPHINX_OPTIONS} -b gettext \\"},{"line_number":104,"context_line":"    -d ${DIRECTORY}/build/doctrees.gettext \\"},{"line_number":105,"context_line":"    ${DIRECTORY}/source ${DIRECTORY}/source/locale/"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_ecdf68d0","line":103,"updated":"2018-12-09 09:47:50.000000000","message":"I suggest to use \"-W\" as default. If you want to allow disabling it, then set it only if not set.","commit_id":"d78bc806edd2b99c94b9a3e15c178b1567c871f4"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"d2d5164d21eaee07c76c69bb290492f90b87fc61","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    done"},{"line_number":101,"context_line":"}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"sphinx-build -a ${SPHINX_OPTIONS} -b gettext \\"},{"line_number":104,"context_line":"    -d ${DIRECTORY}/build/doctrees.gettext \\"},{"line_number":105,"context_line":"    ${DIRECTORY}/source ${DIRECTORY}/source/locale/"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_475d1552","line":103,"in_reply_to":"3f79a3b5_6787f112","updated":"2018-12-09 13:14:10.000000000","message":"Exactly - we don\u0027t want regressions.\n\nSo, you need two switches/options: One for translated docs, one for English. For English the default needs to be -W, see below. For translations, the default should be without -W.\n\nthis is a new script and the -W should stay above for *gettext*.\n\nI\u0027m fine with adding an option to override the two switches/options. I disagree with a single option like your change does.\n\n\nI agree with your conclusion that building translated docs with warning is a major task - so, an option is fine.","commit_id":"d78bc806edd2b99c94b9a3e15c178b1567c871f4"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"d160a1e47c60301754d8edc090b7593af102ee18","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    done"},{"line_number":101,"context_line":"}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"sphinx-build -a ${SPHINX_OPTIONS} -b gettext \\"},{"line_number":104,"context_line":"    -d ${DIRECTORY}/build/doctrees.gettext \\"},{"line_number":105,"context_line":"    ${DIRECTORY}/source ${DIRECTORY}/source/locale/"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_6787f112","line":103,"in_reply_to":"3f79a3b5_ecdf68d0","updated":"2018-12-09 12:35:41.000000000","message":"This means to fix all that documentation first before activate translation, which is probably not possible. I tried this for one repo which tooks two days of work for me. I agree docs build should have no warnings, but our project goal is documentation translation and not documentaion fixes. Because of that I made this option for tox.ini, so translation build can activated and fix of warnings can make later on.","commit_id":"d78bc806edd2b99c94b9a3e15c178b1567c871f4"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"4e036e78b3173c3c8b5687409c5d58b5952d3cf5","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        resname\u003d${potname%.pot}"},{"line_number":131,"context_line":"        # merge all translation resources"},{"line_number":132,"context_line":"        # \"{resname}.pot\" needs to be merged with \"doc-{resname}.po\" if exists"},{"line_number":133,"context_line":"        if [ -e ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${DOCNAME}-${resname}.po ]; then"},{"line_number":134,"context_line":"            msgmerge -q -o \\"},{"line_number":135,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${resname}.po \\"},{"line_number":136,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${DOCNAME}-${resname}.po \\"},{"line_number":137,"context_line":"                ${DIRECTORY}/source/locale/${potname}"},{"line_number":138,"context_line":"        elif [ -e ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${DOCNAME}.po ]; then"},{"line_number":139,"context_line":"            msgmerge -q -o \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_ec9448e8","line":136,"range":{"start_line":133,"start_character":0,"end_line":136,"end_character":53},"updated":"2018-12-09 09:47:50.000000000","message":"this part is fine","commit_id":"d78bc806edd2b99c94b9a3e15c178b1567c871f4"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"4e036e78b3173c3c8b5687409c5d58b5952d3cf5","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${resname}.po \\"},{"line_number":136,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${DOCNAME}-${resname}.po \\"},{"line_number":137,"context_line":"                ${DIRECTORY}/source/locale/${potname}"},{"line_number":138,"context_line":"        elif [ -e ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${DOCNAME}.po ]; then"},{"line_number":139,"context_line":"            msgmerge -q -o \\"},{"line_number":140,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${resname}.po \\"},{"line_number":141,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${DOCNAME}.po \\"},{"line_number":142,"context_line":"                ${DIRECTORY}/source/locale/${potname}"},{"line_number":143,"context_line":"        else"},{"line_number":144,"context_line":"            msgcat ${DIRECTORY}/source/locale/${potname} \u003e \\"},{"line_number":145,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${resname}.po"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_ac82d0a4","line":142,"range":{"start_line":138,"start_character":12,"end_line":142,"end_character":53},"updated":"2018-12-09 09:47:50.000000000","message":"I don\u0027t see how you get here, could you point me to the code in openstack-zuul-jobs that creates such a file?","commit_id":"d78bc806edd2b99c94b9a3e15c178b1567c871f4"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"d2d5164d21eaee07c76c69bb290492f90b87fc61","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${resname}.po \\"},{"line_number":136,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${DOCNAME}-${resname}.po \\"},{"line_number":137,"context_line":"                ${DIRECTORY}/source/locale/${potname}"},{"line_number":138,"context_line":"        elif [ -e ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${DOCNAME}.po ]; then"},{"line_number":139,"context_line":"            msgmerge -q -o \\"},{"line_number":140,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${resname}.po \\"},{"line_number":141,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${DOCNAME}.po \\"},{"line_number":142,"context_line":"                ${DIRECTORY}/source/locale/${potname}"},{"line_number":143,"context_line":"        else"},{"line_number":144,"context_line":"            msgcat ${DIRECTORY}/source/locale/${potname} \u003e \\"},{"line_number":145,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${resname}.po"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_6760510d","line":142,"range":{"start_line":138,"start_character":12,"end_line":142,"end_character":53},"in_reply_to":"3f79a3b5_277c99e7","updated":"2018-12-09 13:14:10.000000000","message":"Then let\u0027s state this in the comment...","commit_id":"d78bc806edd2b99c94b9a3e15c178b1567c871f4"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"d160a1e47c60301754d8edc090b7593af102ee18","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${resname}.po \\"},{"line_number":136,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${DOCNAME}-${resname}.po \\"},{"line_number":137,"context_line":"                ${DIRECTORY}/source/locale/${potname}"},{"line_number":138,"context_line":"        elif [ -e ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${DOCNAME}.po ]; then"},{"line_number":139,"context_line":"            msgmerge -q -o \\"},{"line_number":140,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${resname}.po \\"},{"line_number":141,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${DOCNAME}.po \\"},{"line_number":142,"context_line":"                ${DIRECTORY}/source/locale/${potname}"},{"line_number":143,"context_line":"        else"},{"line_number":144,"context_line":"            msgcat ${DIRECTORY}/source/locale/${potname} \u003e \\"},{"line_number":145,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${resname}.po"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_277c99e7","line":142,"range":{"start_line":138,"start_character":12,"end_line":142,"end_character":53},"in_reply_to":"3f79a3b5_ac82d0a4","updated":"2018-12-09 12:35:41.000000000","message":"that shoud be the part for doc.po","commit_id":"d78bc806edd2b99c94b9a3e15c178b1567c871f4"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"4e036e78b3173c3c8b5687409c5d58b5952d3cf5","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${DOCNAME}.po \\"},{"line_number":142,"context_line":"                ${DIRECTORY}/source/locale/${potname}"},{"line_number":143,"context_line":"        else"},{"line_number":144,"context_line":"            msgcat ${DIRECTORY}/source/locale/${potname} \u003e \\"},{"line_number":145,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${resname}.po"},{"line_number":146,"context_line":"        fi"},{"line_number":147,"context_line":"        # compile all translation resources"},{"line_number":148,"context_line":"        msgfmt -o \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_cc7dccc3","line":145,"range":{"start_line":144,"start_character":9,"end_line":145,"end_character":80},"updated":"2018-12-09 09:47:50.000000000","message":"Similar here, will we get here?","commit_id":"d78bc806edd2b99c94b9a3e15c178b1567c871f4"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"4e036e78b3173c3c8b5687409c5d58b5952d3cf5","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        else"},{"line_number":144,"context_line":"            msgcat ${DIRECTORY}/source/locale/${potname} \u003e \\"},{"line_number":145,"context_line":"                ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${resname}.po"},{"line_number":146,"context_line":"        fi"},{"line_number":147,"context_line":"        # compile all translation resources"},{"line_number":148,"context_line":"        msgfmt -o \\"},{"line_number":149,"context_line":"            ${DIRECTORY}/source/locale/${language}/LC_MESSAGES/${resname}.mo \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_6c8838c3","line":146,"updated":"2018-12-09 09:47:50.000000000","message":"we have also doc/source/locale/doc.pot - how is that handled?","commit_id":"d78bc806edd2b99c94b9a3e15c178b1567c871f4"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"d2d5164d21eaee07c76c69bb290492f90b87fc61","unresolved":false,"context_lines":[{"line_number":170,"context_line":"add_language_index_to_original"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# build English document"},{"line_number":173,"context_line":"sphinx-build -a ${SPHINX_OPTIONS} -b html \\"},{"line_number":174,"context_line":"    -d ${DIRECTORY}/build/doctrees \\"},{"line_number":175,"context_line":"    ${DIRECTORY}/source ${DIRECTORY}/build/html/"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3f79a3b5_a79c2901","line":173,"updated":"2018-12-09 13:14:10.000000000","message":"This is the English Document, it needs -W.","commit_id":"d78bc806edd2b99c94b9a3e15c178b1567c871f4"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"c8e845df0af3ef7e465e7b54d11d82cd7b1fdada","unresolved":false,"context_lines":[{"line_number":26,"context_line":"SPHINX_BUILD_OPTION_TRANS\u003d\u0027-W\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Skip -W option for english and translation builds"},{"line_number":29,"context_line":"if [ ! -z \"${SKIP_SPHINX_WARNINGS}\" ]; then "},{"line_number":30,"context_line":"    SPHINX_BUILD_OPTION_ENG\u003d\u0027\u0027"},{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_ca11ec53","line":29,"updated":"2018-12-12 09:21:14.000000000","message":"extra whitespace at EOL, also line 33","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"c4665e6ba5ab3b851857c310e092519f51b021a9","unresolved":false,"context_lines":[{"line_number":26,"context_line":"SPHINX_BUILD_OPTION_TRANS\u003d\u0027-W\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Skip -W option for english and translation builds"},{"line_number":29,"context_line":"if [ ! -z \"${SKIP_SPHINX_WARNINGS}\" ]; then "},{"line_number":30,"context_line":"    SPHINX_BUILD_OPTION_ENG\u003d\u0027\u0027"},{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_0517d5f2","line":29,"in_reply_to":"3f79a3b5_ca11ec53","updated":"2018-12-12 10:35:00.000000000","message":"Done","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"45c901526a70ce28a59b6f65295428da320f6154","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    done"},{"line_number":114,"context_line":"}"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"sphinx-build -a -W -b gettext \\"},{"line_number":117,"context_line":"    -d ${DIRECTORY}/build/doctrees.gettext \\"},{"line_number":118,"context_line":"    ${DIRECTORY}/source ${DIRECTORY}/source/locale/"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_0a5fe411","line":116,"range":{"start_line":116,"start_character":16,"end_line":116,"end_character":18},"updated":"2018-12-12 09:33:15.000000000","message":"We run with the \u0027-W\u0027 flag here. What\u0027s the special reason for not just doing that by default below too?","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"c4665e6ba5ab3b851857c310e092519f51b021a9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    done"},{"line_number":114,"context_line":"}"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"sphinx-build -a -W -b gettext \\"},{"line_number":117,"context_line":"    -d ${DIRECTORY}/build/doctrees.gettext \\"},{"line_number":118,"context_line":"    ${DIRECTORY}/source ${DIRECTORY}/source/locale/"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_653569f5","line":116,"range":{"start_line":116,"start_character":16,"end_line":116,"end_character":18},"in_reply_to":"3f79a3b5_0a5fe411","updated":"2018-12-12 10:35:00.000000000","message":"it should be default if SKIP_SPHINX_WARNINGS is not set.","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"45c901526a70ce28a59b6f65295428da320f6154","unresolved":false,"context_lines":[{"line_number":172,"context_line":"add_language_index_to_original"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"# build English document"},{"line_number":175,"context_line":"sphinx-build -a ${SPHINX_BUILD_OPTION_ENG} -b html \\"},{"line_number":176,"context_line":"    -d ${DIRECTORY}/build/doctrees \\"},{"line_number":177,"context_line":"    ${DIRECTORY}/source ${DIRECTORY}/build/html/"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_aab6f0fa","line":175,"range":{"start_line":175,"start_character":16,"end_line":175,"end_character":42},"updated":"2018-12-12 09:33:15.000000000","message":"...yet we\u0027re removing it here. What\u0027s the difference?","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"c4665e6ba5ab3b851857c310e092519f51b021a9","unresolved":false,"context_lines":[{"line_number":172,"context_line":"add_language_index_to_original"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"# build English document"},{"line_number":175,"context_line":"sphinx-build -a ${SPHINX_BUILD_OPTION_ENG} -b html \\"},{"line_number":176,"context_line":"    -d ${DIRECTORY}/build/doctrees \\"},{"line_number":177,"context_line":"    ${DIRECTORY}/source ${DIRECTORY}/build/html/"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3f79a3b5_00082324","line":175,"range":{"start_line":175,"start_character":16,"end_line":175,"end_character":42},"in_reply_to":"3f79a3b5_aab6f0fa","updated":"2018-12-12 10:35:00.000000000","message":"The build script will touch the files to inject the language menu. So we check for warnings or not.","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"ec5edeb5812b2fd78432304376db92f70e2e937c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"SPHINX_BUILD_OPTION_ENG\u003d\u0027-W\u0027"},{"line_number":26,"context_line":"SPHINX_BUILD_OPTION_TRANS\u003d\u0027-W\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Skip -W option for english and translation builds"},{"line_number":29,"context_line":"if [ ! -z \"${SKIP_SPHINX_WARNINGS}\" ]; then"},{"line_number":30,"context_line":"    SPHINX_BUILD_OPTION_ENG\u003d\u0027\u0027"},{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"if [ -z \"${SPHINX_WARNINGS_TRANS}\" ]; then"},{"line_number":34,"context_line":"    SPHINX_BUILD_OPTION_TRANS\u003d\u0027\u0027"},{"line_number":35,"context_line":"fi"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# This function sets the following global variables"},{"line_number":38,"context_line":"# - LANG_INDEX : filename which contains the language index"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1f769fc5_9b4d5374","line":35,"range":{"start_line":28,"start_character":0,"end_line":35,"end_character":2},"updated":"2019-01-02 09:05:00.000000000","message":"Setting any value to \"0\" like in the release note will still trigger these. The above implementation does not correspond to the releasenotes","commit_id":"49c759f3d9b426b82abbbf8304e1ae8b7018f2b3"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"0f60fe3690b5f1d0dadb218f096a4f77c42fa24b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"SPHINX_BUILD_OPTION_TRANS\u003d\u0027-W\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Skip -W option for english and translation builds"},{"line_number":29,"context_line":"if [ ! -z \"${SKIP_SPHINX_WARNINGS}\" ]; then"},{"line_number":30,"context_line":"    SPHINX_BUILD_OPTION_ENG\u003d\u0027\u0027"},{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"if [ -z \"${SPHINX_WARNINGS_TRANS}\" ]; then"},{"line_number":34,"context_line":"    SPHINX_BUILD_OPTION_TRANS\u003d\u0027\u0027"},{"line_number":35,"context_line":"fi"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# This function sets the following global variables"}],"source_content_type":"text/x-sh","patch_set":5,"id":"1f769fc5_ca31b3a4","line":34,"range":{"start_line":29,"start_character":0,"end_line":34,"end_character":3},"updated":"2019-01-02 14:01:27.000000000","message":"-z is the wrong check, it will tread \"VAR\u003d0\" and \"VAR\u003d1\" the same way which is counterintuitive - as explained last time.","commit_id":"64c750ae16f7a02b2ff49a05148945510be5aa58"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"19104fad4d68c5c5d0f94735e7af751fdc9ae53d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"SPHINX_BUILD_OPTION_TRANS\u003d\u0027-W\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Skip -W option for english and translation builds"},{"line_number":29,"context_line":"if [ ! -z \"${SKIP_SPHINX_WARNINGS}\" ]; then"},{"line_number":30,"context_line":"    SPHINX_BUILD_OPTION_ENG\u003d\u0027\u0027"},{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"if [ -z \"${SPHINX_WARNINGS_TRANS}\" ]; then"},{"line_number":34,"context_line":"    SPHINX_BUILD_OPTION_TRANS\u003d\u0027\u0027"},{"line_number":35,"context_line":"fi"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# This function sets the following global variables"}],"source_content_type":"text/x-sh","patch_set":5,"id":"ffd0ebdf_419ddc57","line":34,"range":{"start_line":29,"start_character":0,"end_line":34,"end_character":3},"in_reply_to":"1f769fc5_ca31b3a4","updated":"2019-01-03 08:30:30.000000000","message":"Done","commit_id":"64c750ae16f7a02b2ff49a05148945510be5aa58"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"356bc0b545380f78bcf16ead9a08a06d6c37e9f9","unresolved":false,"context_lines":[{"line_number":26,"context_line":"SPHINX_BUILD_OPTION_TRANS\u003d\u0027-W\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Skip -W option for english and translation builds"},{"line_number":29,"context_line":"if [ ${SKIP_SPHINX_WARNINGS} \u003c 1 ]; then"},{"line_number":30,"context_line":"    SPHINX_BUILD_OPTION_ENG\u003d\u0027\u0027"},{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"ffd0ebdf_ace59f3a","line":29,"range":{"start_line":29,"start_character":29,"end_line":29,"end_character":30},"updated":"2019-01-03 09:22:32.000000000","message":"This is not C - but bash. Use \"-lt\"","commit_id":"3f35d22eb9d9d714898cc544366de0d9502d5d0c"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"5d3b989cc113a34a0d440dd4a4af2fa2e61c7b76","unresolved":false,"context_lines":[{"line_number":26,"context_line":"SPHINX_BUILD_OPTION_TRANS\u003d\u0027-W\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Skip -W option for english and translation builds"},{"line_number":29,"context_line":"if [ ${SKIP_SPHINX_WARNINGS} \u003c 1 ]; then"},{"line_number":30,"context_line":"    SPHINX_BUILD_OPTION_ENG\u003d\u0027\u0027"},{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"ffd0ebdf_12c2c186","line":29,"range":{"start_line":29,"start_character":29,"end_line":29,"end_character":30},"in_reply_to":"ffd0ebdf_8c09bbde","updated":"2019-01-03 14:04:53.000000000","message":"Done","commit_id":"3f35d22eb9d9d714898cc544366de0d9502d5d0c"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"29e2f0223ea15be2ce040a569e8043e046a8437c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"SPHINX_BUILD_OPTION_TRANS\u003d\u0027-W\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Skip -W option for english and translation builds"},{"line_number":29,"context_line":"if [ ${SKIP_SPHINX_WARNINGS} \u003c 1 ]; then"},{"line_number":30,"context_line":"    SPHINX_BUILD_OPTION_ENG\u003d\u0027\u0027"},{"line_number":31,"context_line":"fi"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"ffd0ebdf_8c09bbde","line":29,"range":{"start_line":29,"start_character":29,"end_line":29,"end_character":30},"in_reply_to":"ffd0ebdf_ace59f3a","updated":"2019-01-03 09:28:15.000000000","message":"Btw. this will cause an error if used.\n\nWhy not do the following:\n\nSKIP_SPHINX_WARNINGS\u003d${SKIP_SPHINX_WARNINGS:-0}\nto first initialize the value - and then you can safely test.\n\nSame for the other one..","commit_id":"3f35d22eb9d9d714898cc544366de0d9502d5d0c"}],"releasenotes/notes/add-translations-9238b0f56b677a6b.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"6c5a28020be0511e742b08068c780448a04aa80a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"          SKIP_SPHINX_WARNINGS\u003d1"},{"line_number":22,"context_line":"          SPHINX_WARNINGS_TRANS\u003d1"},{"line_number":23,"context_line":"      commands\u003d"},{"line_number":24,"context_line":"          doc8 doc"},{"line_number":25,"context_line":"          docstheme-build-translated.sh"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"      [doc8]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_8af45426","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":18},"updated":"2018-12-12 09:20:01.000000000","message":"doc8 belongs to pep8 according to PTI - so remove here.","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"c4665e6ba5ab3b851857c310e092519f51b021a9","unresolved":false,"context_lines":[{"line_number":21,"context_line":"          SKIP_SPHINX_WARNINGS\u003d1"},{"line_number":22,"context_line":"          SPHINX_WARNINGS_TRANS\u003d1"},{"line_number":23,"context_line":"      commands\u003d"},{"line_number":24,"context_line":"          doc8 doc"},{"line_number":25,"context_line":"          docstheme-build-translated.sh"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"      [doc8]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_e5f419d0","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":18},"in_reply_to":"3f79a3b5_8af45426","updated":"2018-12-12 10:35:00.000000000","message":"Done","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"6c5a28020be0511e742b08068c780448a04aa80a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"          doc8 doc"},{"line_number":25,"context_line":"          docstheme-build-translated.sh"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"      [doc8]"},{"line_number":28,"context_line":"      extensions \u003d .rst"},{"line_number":29,"context_line":"      ignore \u003d D001"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_cffc9e10","line":29,"range":{"start_line":27,"start_character":1,"end_line":29,"end_character":19},"updated":"2018-12-12 09:20:01.000000000","message":"remove doc8 section","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"d262abeb5388c3cd7296f56465ed30367aec8eb1","unresolved":false,"context_lines":[{"line_number":24,"context_line":"          doc8 doc"},{"line_number":25,"context_line":"          docstheme-build-translated.sh"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"      [doc8]"},{"line_number":28,"context_line":"      extensions \u003d .rst"},{"line_number":29,"context_line":"      ignore \u003d D001"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f769fc5_57f0f1c9","line":29,"range":{"start_line":27,"start_character":1,"end_line":29,"end_character":19},"in_reply_to":"3f79a3b5_06911c51","updated":"2019-01-02 10:51:26.000000000","message":"Done","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"4d19f8fa479acf859f30359cc9025d7d17b1a521","unresolved":false,"context_lines":[{"line_number":24,"context_line":"          doc8 doc"},{"line_number":25,"context_line":"          docstheme-build-translated.sh"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"      [doc8]"},{"line_number":28,"context_line":"      extensions \u003d .rst"},{"line_number":29,"context_line":"      ignore \u003d D001"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_06911c51","line":29,"range":{"start_line":27,"start_character":1,"end_line":29,"end_character":19},"in_reply_to":"3f79a3b5_25ebf1ee","updated":"2018-12-12 11:25:53.000000000","message":"there are better places for that - it does not belong into this snippet.","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"c4665e6ba5ab3b851857c310e092519f51b021a9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"          doc8 doc"},{"line_number":25,"context_line":"          docstheme-build-translated.sh"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"      [doc8]"},{"line_number":28,"context_line":"      extensions \u003d .rst"},{"line_number":29,"context_line":"      ignore \u003d D001"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f79a3b5_25ebf1ee","line":29,"range":{"start_line":27,"start_character":1,"end_line":29,"end_character":19},"in_reply_to":"3f79a3b5_cffc9e10","updated":"2018-12-12 10:35:00.000000000","message":"I want to point to possible D001 error (line too long) in this example caused by injected language menu by the build script. We have to check this on the first builds.","commit_id":"fd852e9110da475d9bb8f5072719295e2c47d0f1"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"70660eebe5a046974b4cac551c17711d10c88a56","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    build translated documents for all languages that exist."},{"line_number":7,"context_line":"    Invoke ``docstheme-build-translated.sh`` from tox.ini instead of running"},{"line_number":8,"context_line":"    ``sphinx-build`` directly."},{"line_number":9,"context_line":"    ``SKIP_SPHINX_WARNINGS`` will warnings by sphinx-build not treat"},{"line_number":10,"context_line":"    as an error"},{"line_number":11,"context_line":"    ``SPHINX_WARNINGS_TRANS`` will turn on warnings by sphinx-build as"},{"line_number":12,"context_line":"    an error on translation (use with caution!)"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_d08aefc1","line":10,"range":{"start_line":9,"start_character":34,"end_line":10,"end_character":15},"updated":"2018-12-12 17:17:38.000000000","message":"Grammatical error on the sentence - Please change this sentence like: \"not treat warnings from sphinx-build as an error\".","commit_id":"45c32d4fd2311667db026c74d5c7122dcca458e0"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"d262abeb5388c3cd7296f56465ed30367aec8eb1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    build translated documents for all languages that exist."},{"line_number":7,"context_line":"    Invoke ``docstheme-build-translated.sh`` from tox.ini instead of running"},{"line_number":8,"context_line":"    ``sphinx-build`` directly."},{"line_number":9,"context_line":"    ``SKIP_SPHINX_WARNINGS`` will warnings by sphinx-build not treat"},{"line_number":10,"context_line":"    as an error"},{"line_number":11,"context_line":"    ``SPHINX_WARNINGS_TRANS`` will turn on warnings by sphinx-build as"},{"line_number":12,"context_line":"    an error on translation (use with caution!)"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f769fc5_37d8d551","line":10,"range":{"start_line":9,"start_character":34,"end_line":10,"end_character":15},"in_reply_to":"3f79a3b5_d08aefc1","updated":"2019-01-02 10:51:26.000000000","message":"Done","commit_id":"45c32d4fd2311667db026c74d5c7122dcca458e0"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"d86d4ebd6d54e95a878542846f08d1e822c89f12","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      [testenv:docs]"},{"line_number":19,"context_line":"      deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":20,"context_line":"      setenv \u003d"},{"line_number":21,"context_line":"          SKIP_SPHINX_WARNINGS\u003d1"},{"line_number":22,"context_line":"          SPHINX_WARNINGS_TRANS\u003d1"},{"line_number":23,"context_line":"      commands\u003d"},{"line_number":24,"context_line":"          docstheme-build-translated.sh"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_a6adc887","line":22,"range":{"start_line":21,"start_character":8,"end_line":22,"end_character":33},"updated":"2018-12-12 11:27:07.000000000","message":"nobody should ever set both at the same time, this is a disaster.\n\nShow only the second one as recommendation.","commit_id":"45c32d4fd2311667db026c74d5c7122dcca458e0"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"d262abeb5388c3cd7296f56465ed30367aec8eb1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      [testenv:docs]"},{"line_number":19,"context_line":"      deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":20,"context_line":"      setenv \u003d"},{"line_number":21,"context_line":"          SKIP_SPHINX_WARNINGS\u003d1"},{"line_number":22,"context_line":"          SPHINX_WARNINGS_TRANS\u003d1"},{"line_number":23,"context_line":"      commands\u003d"},{"line_number":24,"context_line":"          docstheme-build-translated.sh"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f769fc5_f7e1fdff","line":22,"range":{"start_line":21,"start_character":8,"end_line":22,"end_character":33},"in_reply_to":"3f79a3b5_a6adc887","updated":"2019-01-02 10:51:26.000000000","message":"Done","commit_id":"45c32d4fd2311667db026c74d5c7122dcca458e0"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"ec5edeb5812b2fd78432304376db92f70e2e937c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    build translated documents for all languages that exist."},{"line_number":7,"context_line":"    Invoke ``docstheme-build-translated.sh`` from tox.ini instead of running"},{"line_number":8,"context_line":"    ``sphinx-build`` directly."},{"line_number":9,"context_line":"    ``SKIP_SPHINX_WARNINGS`` not treat warnings from sphinx-build as an"},{"line_number":10,"context_line":"    error"},{"line_number":11,"context_line":"    ``SPHINX_WARNINGS_TRANS`` will turn on warnings by sphinx-build as"},{"line_number":12,"context_line":"    an error on translation (use with caution!)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    Example for tox.ini:"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f769fc5_77040d18","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":47},"updated":"2019-01-02 09:05:00.000000000","message":"These should be complete sentences ending with a \".\".\n\nRemove the \"!\", it\u0027s not necessary for docs.\n\nWhat about adding an intro: \"The following environment variables control the script:...\"","commit_id":"49c759f3d9b426b82abbbf8304e1ae8b7018f2b3"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"ec5edeb5812b2fd78432304376db92f70e2e937c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      [testenv:docs]"},{"line_number":19,"context_line":"      deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":20,"context_line":"      setenv \u003d"},{"line_number":21,"context_line":"          SKIP_SPHINX_WARNINGS\u003d0"},{"line_number":22,"context_line":"          SPHINX_WARNINGS_TRANS\u003d1"},{"line_number":23,"context_line":"      commands\u003d"},{"line_number":24,"context_line":"          docstheme-build-translated.sh"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f769fc5_bb2b6f80","line":22,"range":{"start_line":21,"start_character":0,"end_line":22,"end_character":33},"updated":"2019-01-02 09:05:00.000000000","message":"This example will not work with your script.\n\nit will disable both settings.","commit_id":"49c759f3d9b426b82abbbf8304e1ae8b7018f2b3"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"0f60fe3690b5f1d0dadb218f096a4f77c42fa24b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    build translated documents for all languages that exist."},{"line_number":7,"context_line":"    Invoke ``docstheme-build-translated.sh`` from tox.ini instead of running"},{"line_number":8,"context_line":"    ``sphinx-build`` directly."},{"line_number":9,"context_line":"    ``SKIP_SPHINX_WARNINGS`` not treat warnings from sphinx-build as an"},{"line_number":10,"context_line":"    error."},{"line_number":11,"context_line":"    ``SPHINX_WARNINGS_TRANS`` will turn on warnings by sphinx-build as"},{"line_number":12,"context_line":"    an error on translation (use with caution!)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    Example for tox.ini:"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f769fc5_4af4c3cf","line":12,"range":{"start_line":9,"start_character":4,"end_line":12,"end_character":48},"updated":"2019-01-02 14:01:27.000000000","message":"These are still not complete sentences, see my comments from last time as well.","commit_id":"64c750ae16f7a02b2ff49a05148945510be5aa58"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"19104fad4d68c5c5d0f94735e7af751fdc9ae53d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    build translated documents for all languages that exist."},{"line_number":7,"context_line":"    Invoke ``docstheme-build-translated.sh`` from tox.ini instead of running"},{"line_number":8,"context_line":"    ``sphinx-build`` directly."},{"line_number":9,"context_line":"    ``SKIP_SPHINX_WARNINGS`` not treat warnings from sphinx-build as an"},{"line_number":10,"context_line":"    error."},{"line_number":11,"context_line":"    ``SPHINX_WARNINGS_TRANS`` will turn on warnings by sphinx-build as"},{"line_number":12,"context_line":"    an error on translation (use with caution!)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    Example for tox.ini:"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ffd0ebdf_41eb9caf","line":12,"range":{"start_line":9,"start_character":4,"end_line":12,"end_character":48},"in_reply_to":"1f769fc5_4af4c3cf","updated":"2019-01-03 08:30:30.000000000","message":"Done","commit_id":"64c750ae16f7a02b2ff49a05148945510be5aa58"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"5a5181f9ffdddd10c7ea12565441edaee22915e7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    Invoke ``docstheme-build-translated.sh`` from tox.ini instead of running"},{"line_number":8,"context_line":"    ``sphinx-build`` directly."},{"line_number":9,"context_line":"    The following environment variables control the script:"},{"line_number":10,"context_line":"    ``SKIP_SPHINX_WARNINGS`` not treat warnings from sphinx-build as an"},{"line_number":11,"context_line":"    error."},{"line_number":12,"context_line":"    ``SPHINX_WARNINGS_TRANS`` will turn on warnings by sphinx-build as"},{"line_number":13,"context_line":"    an error on translation (use with caution)."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ffd0ebdf_2ccbefa5","line":10,"updated":"2019-01-03 09:23:25.000000000","message":"\"to not treat...\" or \"does not treat\"","commit_id":"3f35d22eb9d9d714898cc544366de0d9502d5d0c"},{"author":{"_account_id":17765,"name":"Frank Kloeker","email":"f.kloeker@telekom.de","username":"eumel8"},"change_message_id":"5d3b989cc113a34a0d440dd4a4af2fa2e61c7b76","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    Invoke ``docstheme-build-translated.sh`` from tox.ini instead of running"},{"line_number":8,"context_line":"    ``sphinx-build`` directly."},{"line_number":9,"context_line":"    The following environment variables control the script:"},{"line_number":10,"context_line":"    ``SKIP_SPHINX_WARNINGS`` not treat warnings from sphinx-build as an"},{"line_number":11,"context_line":"    error."},{"line_number":12,"context_line":"    ``SPHINX_WARNINGS_TRANS`` will turn on warnings by sphinx-build as"},{"line_number":13,"context_line":"    an error on translation (use with caution)."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ffd0ebdf_32402508","line":10,"in_reply_to":"ffd0ebdf_2ccbefa5","updated":"2019-01-03 14:04:53.000000000","message":"Done","commit_id":"3f35d22eb9d9d714898cc544366de0d9502d5d0c"}]}