)]}'
{"id":"openstack%2Fopenstackdocstheme~662532","triplet_id":"openstack%2Fopenstackdocstheme~master~Ie0780e41194e5add90c8ea6f63dc496acbb0b85a","project":"openstack/openstackdocstheme","branch":"master","topic":"update-bootstrap","hashtags":[],"change_id":"Ie0780e41194e5add90c8ea6f63dc496acbb0b85a","subject":"js: Remove dead or unused JS","status":"MERGED","created":"2019-05-31 18:02:17.000000000","updated":"2019-06-05 09:06:59.000000000","submitted":"2019-06-05 09:06:59.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"662532-1559725619170-e3e99d52","meta_rev_id":"dad76eefe76e337785b4e10770563b73de4e612b","_number":662532,"virtual_id_number":662532,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-06-05 09:06:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-06-05 08:56:06.000000000","_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":2,"date":"2019-06-04 16:00:32.000000000","_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-05 08:56:06.000000000","_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-04 16:00:32.000000000","updated_by":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"reviewer":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"state":"REVIEWER"},{"updated":"2019-06-05 08:56:06.000000000","updated_by":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"reviewer":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"state":"REVIEWER"},{"updated":"2019-06-05 09:06:58.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c272f8021f87d340530964943423afa74960e989","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-05-31 18:02:17.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"681940bc363fcdeca83b92da6dde2ddae75d43e5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-31 18:12:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/32/662532/1/check/openstack-tox-docs/6af4f36/html/ : SUCCESS in 3m 32s\n- openstackdocsstheme-tox-manuals-buildpdf http://logs.openstack.org/32/662532/1/check/openstackdocsstheme-tox-manuals-buildpdf/fd5877d/publish-docs/ : SUCCESS in 3m 38s\n- openstackdocsstheme-tox-manuals-buildpdf-starlingxpdf http://logs.openstack.org/32/662532/1/check/openstackdocsstheme-tox-manuals-buildpdf-starlingxpdf/9f82c08/publish-docs/ : SUCCESS in 3m 49s\n- openstack-tox-pep8 http://logs.openstack.org/32/662532/1/check/openstack-tox-pep8/7413d63/ : SUCCESS in 3m 57s\n- build-openstack-api-ref http://logs.openstack.org/32/662532/1/check/build-openstack-api-ref/e2e7c05/html/ : SUCCESS in 3m 28s\n- openstack-tox-docs-starlingxdocs http://logs.openstack.org/32/662532/1/check/openstack-tox-docs-starlingxdocs/b2fc3fb/html/ : SUCCESS in 3m 38s","accounts_in_message":[],"_revision_number":1},{"id":"8c404e1a167df565d3ec1dcccd15485c2d3f836a","author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"date":"2019-06-01 04:31:23.000000000","message":"Patch Set 1: Code-Review-1\n\nThe patch idea looks good to me.\n\nJust one question: it seems that \"webui-popover.js\" file is referenced by https://opendev.org/openstack/openstackdocstheme/src/branch/master/openstackdocstheme/theme/openstackdocs/script_footer.html#L14 - do you think that this line also needs to be deleted?","accounts_in_message":[],"_revision_number":1},{"id":"215900833d5578e55bf2a03d4ee6494518df92f3","author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"date":"2019-06-03 12:15:35.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"31a7b3cbdb9893a243f92c1f24ec54a3fd4151f4","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-06-04 15:30:47.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4880f710bd52f6cc931e929b48a60c85e8b31343","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-06-04 15:30:51.000000000","message":"Patch Set 1:\n\n\u003e The patch idea looks good to me.\n \u003e \n \u003e Just one question: it seems that \"webui-popover.js\" file is\n \u003e referenced by https://opendev.org/openstack/openstackdocstheme/src/branch/master/openstackdocstheme/theme/openstackdocs/script_footer.html#L14\n \u003e - do you think that this line also needs to be deleted?\n\nAh, good spot. Fixed.","accounts_in_message":[],"_revision_number":1},{"id":"22ce26dc95bb3cb7c99c4bba12963928d0a41eb2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-04 15:56:30.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/32/662532/2/check/openstack-tox-docs/5857bed/html/ : SUCCESS in 3m 40s\n- openstackdocsstheme-tox-manuals-buildpdf http://logs.openstack.org/32/662532/2/check/openstackdocsstheme-tox-manuals-buildpdf/ad35bfc/publish-docs/ : SUCCESS in 4m 01s\n- openstackdocsstheme-tox-manuals-buildpdf-starlingxpdf http://logs.openstack.org/32/662532/2/check/openstackdocsstheme-tox-manuals-buildpdf-starlingxpdf/93c06bd/publish-docs/ : SUCCESS in 4m 05s\n- openstack-tox-pep8 http://logs.openstack.org/32/662532/2/check/openstack-tox-pep8/8303929/ : SUCCESS in 3m 57s\n- build-openstack-api-ref http://logs.openstack.org/32/662532/2/check/build-openstack-api-ref/258a606/html/ : SUCCESS in 3m 38s\n- openstack-tox-docs-starlingxdocs http://logs.openstack.org/32/662532/2/check/openstack-tox-docs-starlingxdocs/14251f9/html/ : SUCCESS in 3m 31s","accounts_in_message":[],"_revision_number":2},{"id":"3b12039e1420bb0b287850e5087929f83c36d17e","author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"date":"2019-06-04 16:00:32.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"1bf89876cd8e5d27c2c30ca78c084fe42bfb9831","author":{"_account_id":10607,"name":"Alexandra Settle","email":"a.settle@outlook.com","username":"asettle"},"date":"2019-06-05 08:56:06.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"b96b5cc19b82ae92c944b13fe2558f2df8933c77","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-05 08:56:18.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"c584b12187479a27ad42f354a94f509ddca7c03d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-05 09:06:58.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs http://logs.openstack.org/32/662532/2/gate/openstack-tox-docs/9b12954/html/ : SUCCESS in 3m 39s\n- openstackdocsstheme-tox-manuals-buildpdf http://logs.openstack.org/32/662532/2/gate/openstackdocsstheme-tox-manuals-buildpdf/f973eb2/publish-docs/ : SUCCESS in 4m 03s\n- openstackdocsstheme-tox-manuals-buildpdf-starlingxpdf http://logs.openstack.org/32/662532/2/gate/openstackdocsstheme-tox-manuals-buildpdf-starlingxpdf/e2d3a77/publish-docs/ : SUCCESS in 3m 48s\n- openstack-tox-pep8 http://logs.openstack.org/32/662532/2/gate/openstack-tox-pep8/63e13d4/ : SUCCESS in 3m 46s\n- build-openstack-api-ref http://logs.openstack.org/32/662532/2/gate/build-openstack-api-ref/9a7c166/html/ : SUCCESS in 3m 30s\n- openstack-tox-docs-starlingxdocs http://logs.openstack.org/32/662532/2/gate/openstack-tox-docs-starlingxdocs/c305897/html/ : SUCCESS in 3m 09s","accounts_in_message":[],"_revision_number":2},{"id":"8429b19b2959d1581256692952bb769745573440","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-05 09:06:59.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"9e64a25ec3c6af142b08f02146864e5745944de6","revisions":{"720b0772f5a14a3aa13f633f441bf8f3cee5050f":{"kind":"REWORK","_number":1,"created":"2019-05-31 18:02:17.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/32/662532/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstackdocstheme","ref":"refs/changes/32/662532/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/32/662532/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/32/662532/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/32/662532/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstackdocstheme refs/changes/32/662532/1"}}},"commit":{"parents":[{"commit":"be07b385a37cbf852a1c12e54c9a4792ee2758be","subject":"Merge \"Note External Link Helper is not compatible with project only master brach\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/be07b385a37cbf852a1c12e54c9a4792ee2758be"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-05-31 17:43:14.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-05-31 18:00:26.000000000","tz":60},"subject":"js: Remove dead or unused JS","message":"js: Remove dead or unused JS\n\nRemove all the commented out stuff, which is clearly not coming back,\nalong with code that was applied to elements with the ID of\n\u0027toggle-definitions\u0027, none of which exist. This in turns allows us to\nremove all the webuiPopover stuff since that only applied to elements\nwith the \u0027gloss\u0027 class, which the \u0027toggle-definitions\u0027 code was\ncreating.\n\nChange-Id: Ie0780e41194e5add90c8ea6f63dc496acbb0b85a\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/720b0772f5a14a3aa13f633f441bf8f3cee5050f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/720b0772f5a14a3aa13f633f441bf8f3cee5050f"}]},"branch":"refs/heads/master"},"9e64a25ec3c6af142b08f02146864e5745944de6":{"kind":"REWORK","_number":2,"created":"2019-06-04 15:30:47.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/32/662532/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstackdocstheme","ref":"refs/changes/32/662532/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/32/662532/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/32/662532/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/32/662532/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstackdocstheme refs/changes/32/662532/2"}}},"commit":{"parents":[{"commit":"be07b385a37cbf852a1c12e54c9a4792ee2758be","subject":"Merge \"Note External Link Helper is not compatible with project only master brach\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/be07b385a37cbf852a1c12e54c9a4792ee2758be"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-05-31 17:43:14.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-06-04 15:30:37.000000000","tz":60},"subject":"js: Remove dead or unused JS","message":"js: Remove dead or unused JS\n\nRemove all the commented out stuff, which is clearly not coming back,\nalong with code that was applied to elements with the ID of\n\u0027toggle-definitions\u0027, none of which exist. This in turns allows us to\nremove all the webuiPopover stuff since that only applied to elements\nwith the \u0027gloss\u0027 class, which the \u0027toggle-definitions\u0027 code was\ncreating.\n\nChange-Id: Ie0780e41194e5add90c8ea6f63dc496acbb0b85a\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/9e64a25ec3c6af142b08f02146864e5745944de6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/9e64a25ec3c6af142b08f02146864e5745944de6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}