)]}'
{"openstackdocstheme/__init__.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"81e84238624d4440ac6f484b6e13facbbcbae6f2","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def setup(app):"},{"line_number":21,"context_line":"    ext.setup(app)"},{"line_number":22,"context_line":"    page_context.setup(app)"},{"line_number":23,"context_line":"    return {"},{"line_number":24,"context_line":"        \u0027parallel_read_safe\u0027: True,"},{"line_number":25,"context_line":"        \u0027parallel_write_safe\u0027: True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_b9506d60","line":22,"updated":"2020-05-13 15:15:02.000000000","message":"Since the ext and page_context modules return metadata dicts, shouldn\u0027t we return those from here instead of ignoring them and duplicating below? That is, where else are the returned dicts used from the above modules?\n\nThis is how I was thinking to do it (without knowing this patch existed at the time):\n\nhttps://review.opendev.org/#/c/727641/1/openstackdocstheme/__init__.py","commit_id":"cab397da9398cb36f43673e67bcade428427c0cb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7a392263dad5b39fd65b70f9e909780b4ac11472","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def setup(app):"},{"line_number":21,"context_line":"    ext.setup(app)"},{"line_number":22,"context_line":"    page_context.setup(app)"},{"line_number":23,"context_line":"    return {"},{"line_number":24,"context_line":"        \u0027parallel_read_safe\u0027: True,"},{"line_number":25,"context_line":"        \u0027parallel_write_safe\u0027: True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_64a8e8da","line":22,"in_reply_to":"ff570b3c_5963111b","updated":"2020-05-13 15:27:15.000000000","message":"This change will definitely work as-is, what I\u0027m saying is that you\u0027re not using the values returned by ext.setup(app) and page_context.setup(app) so it seems like either (1) there\u0027s no need to return anything from them or (2) their returned values should be aggregated and returned from here instead of ignoring and duplicating.","commit_id":"cab397da9398cb36f43673e67bcade428427c0cb"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"eb61f48dc141f7bbadfdc70c3d77745d3acb5b2c","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def setup(app):"},{"line_number":21,"context_line":"    ext.setup(app)"},{"line_number":22,"context_line":"    page_context.setup(app)"},{"line_number":23,"context_line":"    return {"},{"line_number":24,"context_line":"        \u0027parallel_read_safe\u0027: True,"},{"line_number":25,"context_line":"        \u0027parallel_write_safe\u0027: True,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_5963111b","line":22,"in_reply_to":"ff570b3c_b9506d60","updated":"2020-05-13 15:20:11.000000000","message":"I\u0027m not sure, I\u0027ll have to look at that. This change worked for the local tests I had done. I will have to see what the difference is.","commit_id":"cab397da9398cb36f43673e67bcade428427c0cb"}]}