)]}'
{"id":"openstack%2Fopenstackdocstheme~742158","triplet_id":"openstack%2Fopenstackdocstheme~master~I9b979afcd45e6a51252ccccb686b01beeb9157f8","project":"openstack/openstackdocstheme","branch":"master","topic":"oslo-pre-commit","hashtags":[],"change_id":"I9b979afcd45e6a51252ccccb686b01beeb9157f8","subject":"Adding pre-commit","status":"MERGED","created":"2020-07-21 11:43:40.000000000","updated":"2020-09-22 11:47:02.000000000","submitted":"2020-09-22 11:44:54.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"742158-1600775094015-72df3f54","meta_rev_id":"97378cd2b959b8d97c6755f38cd862e37ba50dd8","_number":742158,"virtual_id_number":742158,"owner":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},{"value":0,"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-09-22 11:44:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"all":[{"value":2,"date":"2020-09-15 13:54:47.000000000","_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},{"value":1,"date":"2020-09-20 09:14:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},{"value":2,"date":"2020-09-22 11:11:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},{"value":0,"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},{"value":1,"date":"2020-09-22 11:11:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-15 13:54:47.000000000","updated_by":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"reviewer":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"state":"REVIEWER"},{"updated":"2020-09-20 09:14:56.000000000","updated_by":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"reviewer":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"state":"REVIEWER"},{"updated":"2020-09-22 11:11:47.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2020-09-22 11:44:53.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"915d66ea3715796040d6952432b6202daa12dfe3","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-07-21 11:43:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1b1bd11c473246a57745415c45664192c156166b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-21 12:03:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/21cc3be4bc36418ca70b6b30c591686b : SUCCESS in 7m 11s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2b7de75611014dbbb13eff74538babba : SUCCESS in 9m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bf12219804c04849953688ff660b4f27 : SUCCESS in 5m 56s\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/b553304185cc4d36908284ce572237a0 : SUCCESS in 5m 23s\n- openstackdocstheme-openstack-tox-docs-starlingxdocs https://zuul.opendev.org/t/openstack/build/f5dce48f90564459a1f32462a058cac7 : SUCCESS in 7m 54s\n- openstackdocstheme-cross-nova-tox-docs https://zuul.opendev.org/t/openstack/build/054391ac0c604519be025bf14303d3dd : SUCCESS in 12m 49s\n- openstackdocstheme-cross-octaviaclient-tox-docs https://zuul.opendev.org/t/openstack/build/2323bbd53c814045b293b7a5fa1da7c4 : SUCCESS in 9m 03s","accounts_in_message":[],"_revision_number":1},{"id":"5b8aa366af9273b19d7d48e7de385082a2855131","author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"date":"2020-07-22 08:43:07.000000000","message":"Patch Set 1: Code-Review-2\n\nWe should hold on in these patches for a while and observe oslo.cache for some time before spreading the change around all Oslo.","accounts_in_message":[],"_revision_number":1},{"id":"350cbe3944e618c62a1dfe3d2bf2f8cdeed3c385","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-09-15 12:46:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b25efc86a05e20832f3f017f4f3a36a155e4a5e7","author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"date":"2020-09-15 13:05:54.000000000","message":"Removed Code-Review-2 by Moisés Guimarães \u003cmoguimar@redhat.com\u003e\n","accounts_in_message":[],"_revision_number":2},{"id":"9d2ac165a58f7cf5a55224cb0ab551ddc7e37fbc","author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"date":"2020-09-15 13:06:32.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"f6b1cf80375e88742b987892bdbac6f8b569736a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-15 13:20:28.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- requirements-check https://zuul.opendev.org/t/openstack/build/71c24f82a43d42d1aa13ab4f222db667 : SUCCESS in 3m 36s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/97614af581c24e47a0ead99b8c564382 : SUCCESS in 12m 23s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d96b877a82bd4626b64877753ccc3f09 : SUCCESS in 3m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/aa8bdbf2c090404fa01e146ff351191c : SUCCESS in 4m 24s\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/fbe59b04dcac48c5a519167b2e2173c7 : SUCCESS in 5m 23s\n- openstackdocstheme-openstack-tox-docs-starlingxdocs https://zuul.opendev.org/t/openstack/build/301687c61f634110a5c717bca6e92275 : SUCCESS in 13m 09s\n- openstackdocstheme-cross-nova-tox-docs https://zuul.opendev.org/t/openstack/build/45ab83b8571947408767f29568a8c595 : SUCCESS in 24m 56s\n- openstackdocstheme-cross-octaviaclient-tox-docs https://zuul.opendev.org/t/openstack/build/8e23f3db54dc4e0ea656446f1cfd7582 : SUCCESS in 14m 18s","accounts_in_message":[],"_revision_number":2},{"id":"bea9b4b73c591e277fcc7bf82ef19114230f1951","author":{"_account_id":27954,"name":"Moisés Guimarães de Medeiros","email":"guimaraes@pm.me","username":"moguimar"},"date":"2020-09-15 13:54:47.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"d4e9aa530f13884cf45321426057ac94974a2a30","author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"date":"2020-09-20 09:14:56.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"d45d4a7e3cef5aa94287277a160b75614ce0ec28","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-09-22 11:11:47.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"afb9ec2d95f49f9b6a77f121aedbe0790e947c99","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-22 11:12:00.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"0d3e29bb7b2e4c8d51b2b540b0196b0beda05ddc","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-22 11:44:53.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- requirements-check https://zuul.opendev.org/t/openstack/build/5a009b9e835841a390242d919093c5e4 : SUCCESS in 4m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ea60d941c03b40d7a4964244f2e3cb97 : SUCCESS in 13m 21s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b80460cd6e1c424095fdd0e3afe39b21 : SUCCESS in 5m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/88d67914108b42ef84fae3341d398669 : SUCCESS in 4m 59s\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/e64096e4db0e462cbc3962827527ee40 : SUCCESS in 4m 38s\n- openstackdocstheme-openstack-tox-docs-starlingxdocs https://zuul.opendev.org/t/openstack/build/29b9e43698184e91b74ce85068215735 : SUCCESS in 28m 40s\n- openstackdocstheme-cross-nova-tox-docs https://zuul.opendev.org/t/openstack/build/e554f62ba11040bb8a0221d91e2532f9 : SUCCESS in 18m 35s\n- openstackdocstheme-cross-octaviaclient-tox-docs https://zuul.opendev.org/t/openstack/build/4a278db3fa954acb8b7cda7ec2bffdc6 : SUCCESS in 16m 00s","accounts_in_message":[],"_revision_number":2},{"id":"00f10f5bbccb579a8fdf25b80627dbf4dd88a78e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-22 11:44:54.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"c892b0b0e6809075a8d7b3e850d5e96bd1a7261d","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-22 11:47:02.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6e1e5b4129c84a37bafe02b620313775 : SUCCESS in 54s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2cbba7e7a1ea48b4aa3cbc3be0c78ed2 : SUCCESS in 1m 17s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"ff156664e6d388fe7310bb15b90e23aebee08f87","revisions":{"b5e4cfd3e6be3d8bed301c0aef8fb49c9675dc89":{"kind":"REWORK","_number":1,"created":"2020-07-21 11:43:40.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/58/742158/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstackdocstheme","ref":"refs/changes/58/742158/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/58/742158/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/58/742158/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/58/742158/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstackdocstheme refs/changes/58/742158/1"}}},"commit":{"parents":[{"commit":"0ef4eb20b4c74c70b934e6dca48525328c0577dd","subject":"Add version dropdown on docs.starlingx.io","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/0ef4eb20b4c74c70b934e6dca48525328c0577dd"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-07-21 11:43:23.000000000","tz":120},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-07-21 11:43:23.000000000","tz":120},"subject":"Add pre-commit","message":"Add pre-commit\n\npre-commit will be used to:\n- trailing whitespace [1].\n- Replaces or checks mixed line ending (mixed-line-ending) [1].\n- Forbid files which have a UTF-8 byte-order\n  marker (check-byte-order-marker) [1].\n- Checks that non-binary executables have a proper\n  shebang (check-executables-have-shebangs) [1].\n- Check for files that contain merge conflict\n  strings (check-merge-conflict) [1].\n- Check for debugger imports and py37+ breakpoint()\n  calls in python source (debug-statements) [1].\n- Attempts to load all yaml files to verify syntax (check-yaml) [1].\n- replace tabs by space (4 by default)(remove-tabs) [2].\n- Run flake8 checks (flake8) (local)\n\n[2] https://github.com/pre-commit/pre-commit-hooks\n[3] https://github.com/Lucas-C/pre-commit-hooks\n\nChange-Id: I9b979afcd45e6a51252ccccb686b01beeb9157f8\nSigned-off-by: Moisés Guimarães de Medeiros \u003cmoguimar@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/b5e4cfd3e6be3d8bed301c0aef8fb49c9675dc89"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/b5e4cfd3e6be3d8bed301c0aef8fb49c9675dc89"}]},"branch":"refs/heads/master"},"ff156664e6d388fe7310bb15b90e23aebee08f87":{"kind":"REWORK","_number":2,"created":"2020-09-15 12:46:34.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/58/742158/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstackdocstheme","ref":"refs/changes/58/742158/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/58/742158/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/58/742158/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/58/742158/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstackdocstheme refs/changes/58/742158/2"}}},"commit":{"parents":[{"commit":"0ef4eb20b4c74c70b934e6dca48525328c0577dd","subject":"Add version dropdown on docs.starlingx.io","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/0ef4eb20b4c74c70b934e6dca48525328c0577dd"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-07-21 11:43:23.000000000","tz":120},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-09-15 12:46:10.000000000","tz":120},"subject":"Adding pre-commit","message":"Adding pre-commit\n\nIntroduced changes:\n- pre-commit config and rules\n- Add pre-commit to pep8 gate, Flake8 is covered in the pre-commit hooks.\n- Applying fixes for pre-commit compliance in all code.\n\nAlso commit hash will be used instead of version tags in pre-commit to\nprevend arbitrary code from running in developer\u0027s machines.\n\npre-commit will be used to:\n- trailing whitespace;\n- Replaces or checks mixed line ending (mixed-line-ending);\n- Forbid files which have a UTF-8 byte-order marker (check-byte-order-marker);\n- Checks that non-binary executables have a proper\n  shebang (check-executables-have-shebangs);\n- Check for files that contain merge conflict strings (check-merge-conflict);\n- Check for debugger imports and py37+ breakpoint()\n  calls in python source (debug-statements);\n- Attempts to load all yaml files to verify syntax (check-yaml);\n- Run flake8 checks (flake8) (local)\n\nFor further details about tests please refer to:\nhttps://github.com/pre-commit/pre-commit-hooks\n\nChange-Id: I9b979afcd45e6a51252ccccb686b01beeb9157f8\nSigned-off-by: Moisés Guimarães de Medeiros \u003cmoguimar@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/ff156664e6d388fe7310bb15b90e23aebee08f87"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/ff156664e6d388fe7310bb15b90e23aebee08f87"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}