)]}'
{"id":"openstack%2Fopenstackdocstheme~753285","triplet_id":"openstack%2Fopenstackdocstheme~master~I08ef0fc6c7ebd2c0e7ba89bc42cc92176fec8ab8","project":"openstack/openstackdocstheme","branch":"master","topic":"trivial","hashtags":[],"change_id":"I08ef0fc6c7ebd2c0e7ba89bc42cc92176fec8ab8","subject":"js: Don\u0027t attempt to set bug, PDF links without configuration","status":"MERGED","created":"2020-09-22 11:08:57.000000000","updated":"2020-10-22 14:21:05.000000000","submitted":"2020-10-22 14:19:35.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"753285-1603376375662-469732fb","meta_rev_id":"dda28662354973dbb7a50df4b1a8855b522829ac","_number":753285,"virtual_id_number":753285,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-10-22 14:19:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"recommended":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-10-22 13:46:47.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},{"value":2,"date":"2020-09-25 16:25:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2020-09-25 20:03:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":1,"date":"2020-10-22 13:57:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"date":"2020-09-25 16:32:26.000000000","_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-25 16:25:55.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2020-09-25 16:32:26.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-09-25 20:03:39.000000000","updated_by":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"reviewer":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"state":"REVIEWER"},{"updated":"2020-10-22 13:46:47.000000000","updated_by":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"reviewer":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"state":"REVIEWER"},{"updated":"2020-10-22 14:19:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7307b4343e4fe13a37f56b2eb5bfe7efc330a99e","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-09-22 11:08:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"654f336c9e6da07e3e6a21c9f2ae20494dfb5c1c","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-09-22 11:10:51.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"60b12692e367321bc8cf22ce4b53beb2e405c237","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-22 11:32:26.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/678f9b949a66493fafcc3d2120b3319f : SUCCESS in 16m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d7565079af9e4ecfa046be300e680dc1 : SUCCESS in 4m 31s\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/9120773f0d454d3bb8ca50a060fb5778 : SUCCESS in 4m 32s\n- openstackdocstheme-openstack-tox-docs-starlingxdocs https://zuul.opendev.org/t/openstack/build/7939a1d2474349ee9417667da66ed46a : SUCCESS in 13m 43s\n- openstackdocstheme-cross-nova-tox-docs https://zuul.opendev.org/t/openstack/build/5640a55e22e2464584368b432f06c400 : SUCCESS in 18m 46s\n- openstackdocstheme-cross-octaviaclient-tox-docs https://zuul.opendev.org/t/openstack/build/1a3d736c697a48e7a52d4d890c6bd231 : SUCCESS in 13m 23s","accounts_in_message":[],"_revision_number":2},{"id":"2e439a7ce4853a96c7d3a2c76df676bdac427a22","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-09-25 16:25:55.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"469a2d8dcae98fd81017019be274a2b12201d7cc","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2020-09-25 20:03:39.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"9c74e4b7fed2be0cd03779da2224760512789220","author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"date":"2020-10-22 13:46:47.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"b9add471ae5de954f5b93ad88d68cd3601626ef3","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2020-10-22 13:57:20.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"613aebe8c8dabe4f6fdc3d367fb3b73f16510927","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-22 13:57:33.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"aa0bca3acf8b0239c94e12436cff93a082281b26","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-22 14:19:35.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"00caae157e9b19ca89047924b0f87e71ec7e546d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-22 14:19:35.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c5e93d1365f641d783bfc03947a8a9f4 : SUCCESS in 8m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7e36d53ff7c645f993f9c95eaee2a571 : SUCCESS in 10m 02s\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/3664747db5174a5d8ff7278dc467bc85 : SUCCESS in 7m 49s\n- openstackdocstheme-openstack-tox-docs-starlingxdocs https://zuul.opendev.org/t/openstack/build/73915b1f6e3949f69c841c128541635e : SUCCESS in 8m 51s\n- openstackdocstheme-cross-nova-tox-docs https://zuul.opendev.org/t/openstack/build/00fd307280454b8587bc82ff12853d07 : SUCCESS in 13m 05s\n- openstackdocstheme-cross-octaviaclient-tox-docs https://zuul.opendev.org/t/openstack/build/6467c0ee98ca47f0b49e06da129c59ec : SUCCESS in 9m 25s","accounts_in_message":[],"_revision_number":2},{"id":"6a1f0caa3f0584d29b8d169e62927932131a8a2d","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-22 14:21:05.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b2e6cede24134f2f9535f614ae3750de : SUCCESS in 1m 06s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8e6b9c524460edf1c3127fb1861acd13b17455c3","revisions":{"440a3aaecaf98d0234cb7dd3c81001db9c644b64":{"kind":"REWORK","_number":1,"created":"2020-09-22 11:08:57.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/85/753285/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstackdocstheme","ref":"refs/changes/85/753285/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/85/753285/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/85/753285/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/85/753285/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstackdocstheme refs/changes/85/753285/1"}}},"commit":{"parents":[{"commit":"6876b7276bed6432c30e2f46e8f7dd242113e067","subject":"Store empty string for release","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/6876b7276bed6432c30e2f46e8f7dd242113e067"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2020-09-22 10:32:23.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2020-09-22 11:08:35.000000000","tz":60},"subject":"js: Don\u0027t attempt to set bug, PDF links without configuration","message":"js: Don\u0027t attempt to set bug, PDF links without configuration\n\nGenerating both the bug link and PDF download link requires some\nconfiguration in \u0027conf.py\u0027: specifically, the \u0027openstack_bug_project\u0027\nand \u0027openstack_pdf_link\u0027 config options must be set. If these are not\npresent, the template doesn\u0027t include the relevant tags, which means\nattempts to look these up via \u0027getElementById\u0027 will return \u0027null\u0027,\ncausing ugly tracebacks like so in the console.\n\n  Uncaught ReferenceError: bugProject is not defined\n    \u003canonymous\u003e http://localhost:8000/search.html?q\u003dusage:395\n\nSimply surround these blocks with the same conditionals as the template,\navoiding the issue entirely.\n\nChange-Id: I08ef0fc6c7ebd2c0e7ba89bc42cc92176fec8ab8\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\nCloses-Bug: #1896609\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/440a3aaecaf98d0234cb7dd3c81001db9c644b64"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/440a3aaecaf98d0234cb7dd3c81001db9c644b64"}]},"branch":"refs/heads/master"},"8e6b9c524460edf1c3127fb1861acd13b17455c3":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-09-22 11:10:51.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/85/753285/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstackdocstheme","ref":"refs/changes/85/753285/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/85/753285/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/85/753285/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/85/753285/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstackdocstheme refs/changes/85/753285/2"}}},"commit":{"parents":[{"commit":"6876b7276bed6432c30e2f46e8f7dd242113e067","subject":"Store empty string for release","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/6876b7276bed6432c30e2f46e8f7dd242113e067"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2020-09-22 10:32:23.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2020-09-22 11:10:37.000000000","tz":60},"subject":"js: Don\u0027t attempt to set bug, PDF links without configuration","message":"js: Don\u0027t attempt to set bug, PDF links without configuration\n\nGenerating both the bug link and PDF download link requires some\nconfiguration in \u0027conf.py\u0027: specifically, the \u0027openstack_bug_project\u0027\nand \u0027openstack_pdf_link\u0027 config options must be set. If these are not\npresent, the template doesn\u0027t include the relevant tags, which means\nattempts to look these up via \u0027getElementById\u0027 will return \u0027null\u0027,\ncausing ugly tracebacks like so in the console.\n\n  Uncaught ReferenceError: bugProject is not defined\n    \u003canonymous\u003e http://localhost:8000/search.html?q\u003dusage:395\n\nSimply surround these blocks with the same conditionals as the template,\navoiding the issue entirely.\n\nChange-Id: I08ef0fc6c7ebd2c0e7ba89bc42cc92176fec8ab8\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\nCloses-Bug: #1896607\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/8e6b9c524460edf1c3127fb1861acd13b17455c3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/8e6b9c524460edf1c3127fb1861acd13b17455c3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}