)]}'
{"id":"openstack%2Fopenstackdocstheme~793822","triplet_id":"openstack%2Fopenstackdocstheme~master~Idc0e6c1d38407fdadc29ea710069e74243c5c89a","project":"openstack/openstackdocstheme","branch":"master","topic":"sphinx-4.x","hashtags":[],"change_id":"Idc0e6c1d38407fdadc29ea710069e74243c5c89a","subject":"Inherit from base \"basic\" template","status":"MERGED","created":"2021-05-31 15:53:52.000000000","updated":"2021-06-01 16:52:49.000000000","submitted":"2021-06-01 16:51:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"793822-sphinx-4.x","meta_rev_id":"cb483f357966ac89c6cb29d06d418e6b12306fca","_number":793822,"virtual_id_number":793822,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-06-01 16:51:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"recommended":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-06-01 09:04:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":2,"date":"2021-06-01 08:25:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":2,"date":"2021-06-01 14:36:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":1,"date":"2021-06-01 07:11:29.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":1,"date":"2021-06-01 14:36:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-31 16:05:42.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-06-01 07:11:29.000000000","updated_by":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"reviewer":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"state":"REVIEWER"},{"updated":"2021-06-01 08:25:51.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2021-06-01 09:04:29.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2021-06-01 14:36:39.000000000","updated_by":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"reviewer":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"state":"REVIEWER"}],"messages":[{"id":"6b5a7925dbb7c64b8468590f042a3f84ebf67115","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2021-05-31 15:53:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ee2ee7a3973b264dc08a11999726e1b48cd2af1d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-31 16:05:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bb96c08bd2cf4fa5a62cbe330b2ae33c : SUCCESS in 5m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d57b559b7d9b4ecd8cf7949c68d05405 : SUCCESS in 6m 15s\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/fd4972ce2ffd412286c26bd1f8047c5a : SUCCESS in 6m 24s\n- openstackdocstheme-openstack-tox-docs-starlingxdocs https://zuul.opendev.org/t/openstack/build/a0849fe09fed4f0b842ecd3068374e6b : SUCCESS in 6m 54s\n- openstackdocstheme-cross-nova-tox-docs https://zuul.opendev.org/t/openstack/build/8b11874f20564d9db7277946733ebe66 : SUCCESS in 10m 21s\n- openstackdocstheme-cross-octaviaclient-tox-docs https://zuul.opendev.org/t/openstack/build/70b1318890e24cbb892d83f6581db33f : SUCCESS in 8m 07s","accounts_in_message":[],"_revision_number":1},{"id":"66cfba8c4a342d3a21a68de10dac98b495af0b27","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2021-06-01 07:11:29.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"e4d5c58bfbe2c7e5a0ae1b636b831ee0d484836d","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2021-06-01 08:25:51.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"16d427751a9508ae824ed199059a87f145f796f6","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2021-06-01 09:04:29.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM. I like the idea to inherit the basic layout template.","accounts_in_message":[],"_revision_number":1},{"id":"a2f087319ce4c5a9619013c3c057006fdba11320","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2021-06-01 14:36:39.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"bafc93a8dc42b305fa5ac7d23647f6cdf8530a62","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-01 16:33:27.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"33bccfa623d79ebe172b9afdb6c451adda807e26","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-01 16:51:16.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fd11a7a0bef84c8eb28e101a1b963c1b : SUCCESS in 6m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/af4160c87fc64094bfde6a1575bbc71f : SUCCESS in 7m 12s\n- build-openstack-api-ref https://zuul.opendev.org/t/openstack/build/b6dde01432cf40e6bb48983a2e1936fe : SUCCESS in 6m 35s\n- openstackdocstheme-openstack-tox-docs-starlingxdocs https://zuul.opendev.org/t/openstack/build/1c8fa4344e3342a3b190cf0a8327ea05 : SUCCESS in 6m 59s\n- openstackdocstheme-cross-nova-tox-docs https://zuul.opendev.org/t/openstack/build/2979c819313945dd8f7c8bda5dd2cc38 : SUCCESS in 11m 28s\n- openstackdocstheme-cross-octaviaclient-tox-docs https://zuul.opendev.org/t/openstack/build/2e39d5c5183b48f6bbfcc32c0d589dd2 : SUCCESS in 8m 59s","accounts_in_message":[],"_revision_number":1},{"id":"7c7cc4dc1ba620dc27516cd46253720666320e16","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-01 16:51:17.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"cb483f357966ac89c6cb29d06d418e6b12306fca","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-01 16:52:49.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c67990a3631f409cbdefe3ed121af18b : SUCCESS in 1m 10s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"08461c5311aa692088a27eb40a87965fd8515aba","revisions":{"08461c5311aa692088a27eb40a87965fd8515aba":{"kind":"REWORK","_number":1,"created":"2021-05-31 15:53:52.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/22/793822/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstackdocstheme","ref":"refs/changes/22/793822/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/22/793822/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/22/793822/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstackdocstheme refs/changes/22/793822/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstackdocstheme refs/changes/22/793822/1"}}},"commit":{"parents":[{"commit":"9602f39783dec7f9c12aebe8152b4958b6a18e5f","subject":"sphinx 4.0: Handle HTML 5 changes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/9602f39783dec7f9c12aebe8152b4958b6a18e5f"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-05-31 15:10:49.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2021-05-31 15:45:40.000000000","tz":60},"subject":"Inherit from base \"basic\" template","message":"Inherit from base \"basic\" template\n\nSphinx 4.x changed how it includes some JavaScript files. Instead of\nincluding them via the template, they are now injected using the\n\u0027add_js_file\u0027 function [1]. This relies on a custom Jinja2 function,\n\u0027js_tag\u0027 to generate the correct element with necessary attributes set.\nFailure to use this results in missing attributes for some tags.\n\nRather than simply reworking our template to use this new function,\nchange how we use our \u0027layout.html\u0027 to instead override the \u0027basic\u0027\ntemplate that Sphinx provides. This means we should get these kinds of\nchanges \"for free\" in the future, rather than having to worry about\nthem.\n\n[1] https://github.com/sphinx-doc/sphinx/commit/a957d6f710\n\nChange-Id: Idc0e6c1d38407fdadc29ea710069e74243c5c89a\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/08461c5311aa692088a27eb40a87965fd8515aba"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstackdocstheme/commit/08461c5311aa692088a27eb40a87965fd8515aba"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}