)]}'
{"id":"openstack%2Fopenstacksdk~1007141","triplet_id":"openstack%2Fopenstacksdk~master~I1bfe86b430aaa0f3b94650dde1932de8bf443eda","project":"openstack/openstacksdk","branch":"master","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2026-09-25 20:22:00.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I1bfe86b430aaa0f3b94650dde1932de8bf443eda","subject":"Clean up connection resources upon garbage collection","status":"MERGED","created":"2026-09-24 12:13:27.000000000","updated":"2026-09-25 20:22:00.000000000","submitted":"2026-09-25 20:22:00.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"1007141","meta_rev_id":"2a160f1d87eac8ca6e665b88b7d5e2be69743e43","_number":1007141,"virtual_id_number":1007141,"owner":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-09-25 20:21:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"all":[{"value":2,"date":"2026-09-25 18:53:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"all":[{"value":1,"date":"2026-09-25 18:53:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-09-24 13:09:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-09-25 18:53:45.000000000","updated_by":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"reviewer":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"state":"REVIEWER"}],"messages":[{"id":"82d88bc8dd5d2c0aebedadea452a77b5c8a83e64","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-09-24 12:13:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1fe209472a66fdb9d02861484c2b017883e5cde8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-09-24 13:09:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4d26dea5ce77488994ad295a467d60ae\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/48bcb45bb7234ec3ba2279d002c03432 : SUCCESS in 6m 25s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/5ef9992d936e46d9bcff7a6ed5d2867d : SUCCESS in 3m 53s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/994002c3719b4db48408b7ead43d5890 : SUCCESS in 4m 58s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/dec56d36a88c4f5aba705256411fc8ef : SUCCESS in 6m 17s\n- openstack-tox-py315 https://zuul.opendev.org/t/openstack/build/7d7ca30a554349339338d579a15836e3 : SUCCESS in 7m 26s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/6b0dba66aa044562ac9e3d74316da839 : SUCCESS in 34m 10s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/1888ff838a13481c91d218dbeb3962aa : SUCCESS in 4m 30s\n- osc-tox-py311-tips https://zuul.opendev.org/t/openstack/build/cef1a255f12a4b3e9822bc1c74666445 : SUCCESS in 5m 49s\n- osc-tox-py314-tips https://zuul.opendev.org/t/openstack/build/d1b23e1b5fd648ad9450f70a648f0698 : SUCCESS in 4m 28s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9b3a97b0e5384ac9ae7ca361e58dfe50 : SUCCESS in 10m 33s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/26fd2f6ba30c4f8095963b5dbf062728 : SUCCESS in 6m 00s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/3d91e453c25c4980825501c2e91afdc0 : SUCCESS in 29m 01s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/5823b1bb3ed64685a6407a3d9085249a : SUCCESS in 51m 50s\n- openstacksdk-functional-devstack-networking-ext https://zuul.opendev.org/t/openstack/build/813ea370c3dd4a3294d89132e05a6305 : SUCCESS in 53m 20s\n- openstacksdk-functional-devstack-magnum https://zuul.opendev.org/t/openstack/build/b2747486b40a40dfac9fb52fe796d69d : SUCCESS in 22m 45s\n- openstacksdk-functional-devstack-manila https://zuul.opendev.org/t/openstack/build/62ff442050dd43ddb9a55fb3b2b81864 : SUCCESS in 22m 20s\n- openstacksdk-functional-devstack-compute-manila https://zuul.opendev.org/t/openstack/build/c0b5fbafe07b4e009f70a8b6e367026f : SUCCESS in 15m 46s\n- openstacksdk-functional-devstack-cyborg https://zuul.opendev.org/t/openstack/build/90a22f9066b64684a84045c32d8bc47c : SUCCESS in 15m 02s\n- openstacksdk-functional-devstack-masakari https://zuul.opendev.org/t/openstack/build/ca25ff6db5ac4a3fa928ef91d4785192 : SUCCESS in 15m 45s\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/29c5a8e3674c47e89800f3d223618a2a : SUCCESS in 35m 45s\n- osc-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/681e33b043cd4eee87b45b85351a6f1f : SUCCESS in 41m 20s (non-voting)\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/2e0de23a153d401f83f775ab4d6e537f : FAILURE in 27m 48s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"c89b8d26122088544b6a4e8553af71727990541a","author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"date":"2026-09-25 18:53:45.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"eae89bea57778ba72fc770b1d1513c60d4a18a79","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-09-25 18:54:38.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"d8e0d65c8da4f39ee093042001f51e13123423d0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-09-25 20:21:59.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/91970a0a7c5f4941bd0a160c0ebf7241\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/32249755608d4d568f4d85e53900f5d2 : SUCCESS in 4m 57s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/e5d454bc10b8479aa542eb3e11d6c590 : SUCCESS in 3m 42s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/7d5bf033abd747fa8b35a6b93f6ee898 : SUCCESS in 6m 40s\n- openstack-tox-py315 https://zuul.opendev.org/t/openstack/build/f7e29c259dc34602a8fd5ce86ddf58fa : SUCCESS in 9m 22s\n- openstacksdk-functional-devstack-tips https://zuul.opendev.org/t/openstack/build/ceb31e22f0ec45008182719f14debaac : SUCCESS in 42m 46s\n- os-client-config-tox-py311-tips https://zuul.opendev.org/t/openstack/build/060065a231954a118d86d208b517ca44 : SUCCESS in 4m 14s\n- osc-tox-py311-tips https://zuul.opendev.org/t/openstack/build/330eb3a51ac543c49929dfd73f443322 : SUCCESS in 3m 09s\n- osc-tox-py314-tips https://zuul.opendev.org/t/openstack/build/0ec622b679fd46cabbc7becba35c8599 : SUCCESS in 7m 30s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0ae3ad57bfbd41549342054cf5e0bf0d : SUCCESS in 11m 56s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/04ff63e705eb48388902ec355939bea9 : SUCCESS in 4m 44s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/40cb85aac19a436cbd407b8bd580a02d : SUCCESS in 54m 15s\n- openstacksdk-functional-devstack-networking https://zuul.opendev.org/t/openstack/build/e27c2a5e68ad4347b6bd530dd7fb7682 : SUCCESS in 1h 22m 05s\n- openstacksdk-functional-devstack-ironic https://zuul.opendev.org/t/openstack/build/d46da3232d734bfabdb31ce26bc615b6 : SUCCESS in 21m 36s","accounts_in_message":[],"_revision_number":1},{"id":"2a160f1d87eac8ca6e665b88b7d5e2be69743e43","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-09-25 20:22:00.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"07a03b0c672c8bb4b54609b4baa09bfd3cc3e8f8","revisions":{"07a03b0c672c8bb4b54609b4baa09bfd3cc3e8f8":{"kind":"REWORK","_number":1,"created":"2026-09-24 12:13:27.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/41/1007141/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/41/1007141/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/41/1007141/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/41/1007141/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/41/1007141/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/41/1007141/1"}}},"commit":{"parents":[{"commit":"c3f7f2a9534efe244ac7e7e964101712058f09b1","subject":"Replace atexit with weakref.finalize","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/c3f7f2a9534efe244ac7e7e964101712058f09b1"}]}],"author":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-09-24 10:58:36.000000000","tz":60},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2026-09-24 11:52:50.000000000","tz":60},"subject":"Clean up connection resources upon garbage collection","message":"Clean up connection resources upon garbage collection\n\nChange I586b20c368d89daa166d99aa898a7e2e986b92a3 addressed a memory\nleak by replacing atexit.register(self.close) with weakref.finalize.\nHowever, passing weakref.ref(self) to _run_close caused the weakref to\nbe cleared (None) before the finalizer fired during garbage collection.\n_run_close was therefore a no-op on GC, only running close() at\nshutdown for connections that remained alive.\n\nWhile this broke the reference cycle and allowed Python to collect the\nunderlying objects—with ThreadPoolExecutor threads terminating via its\ninternal weakref_cb and raw sockets eventually closed by socket\ndeallocators—relying on passive GC has drawbacks:\n- Sockets are closed abruptly without TLS close-notify and can trigger\n  ResourceWarning.\n- Sockets and threads linger until cascading (or cyclic) GC finishes.\n- set_auth_cache() is never called to persist tokens.\n\nRework _run_close to take the resources directly (config,\npool_executor_holder, and session_holder) rather than a weakref to\nself. Mutable single-element holders accommodate lazy instantiation\nwithout creating reference cycles back to the Connection instance.\n\nThis guarantees deterministic, prompt cleanup on GC and shutdown\nalike: flushing auth cache, cleanly closing pooled HTTP sessions, and\nimmediately terminating background worker threads.\n\nChange-Id: I1bfe86b430aaa0f3b94650dde1932de8bf443eda\nAssisted-By: Gemini 3.8 Flash \u003cnoreply@google.com\u003e\nSigned-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/07a03b0c672c8bb4b54609b4baa09bfd3cc3e8f8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/07a03b0c672c8bb4b54609b4baa09bfd3cc3e8f8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"}},{"label":"Allow-Post-Review","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Allow-Post-Review","description":"Allow Post Review","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}