)]}'
{"openstack/compute/v2/_proxy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d703a8af9eeeb369efae17e80f335e9e92f8cf71","unresolved":true,"context_lines":[{"line_number":3378,"context_line":"        if identified_resources is None:"},{"line_number":3379,"context_line":"            identified_resources \u003d {}"},{"line_number":3380,"context_line":""},{"line_number":3381,"context_line":"        def cleanup_server_trunks(server: _server.Server) -\u003e None:"},{"line_number":3382,"context_line":"            # Nova may delete the server\u0027s ports, so eligible trunks must"},{"line_number":3383,"context_line":"            # go first. Pre-existing ports can outlive the server."},{"line_number":3384,"context_line":"            for port in self._connection.network.ports(device_id\u003dserver.id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"caa504d5_1b74eac7","line":3381,"updated":"2026-11-12 22:52:46.000000000","message":"I know we do stuff like this in a few places already, but it would be much nicer if we were able to define this statically somehow, similar to how we already do service level dependencies. Perhaps one to investigate for a follow-up?","commit_id":"6ddebe99381bfc80f72423d488d8b883dfd0ce8f"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"d1c77a36658c72364fcb1d33dd7de7816461581c","unresolved":true,"context_lines":[{"line_number":3378,"context_line":"        if identified_resources is None:"},{"line_number":3379,"context_line":"            identified_resources \u003d {}"},{"line_number":3380,"context_line":""},{"line_number":3381,"context_line":"        def cleanup_server_trunks(server: _server.Server) -\u003e None:"},{"line_number":3382,"context_line":"            # Nova may delete the server\u0027s ports, so eligible trunks must"},{"line_number":3383,"context_line":"            # go first. Pre-existing ports can outlive the server."},{"line_number":3384,"context_line":"            for port in self._connection.network.ports(device_id\u003dserver.id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"cf9220b0_173aee7e","line":3381,"in_reply_to":"caa504d5_1b74eac7","updated":"2026-11-12 23:21:22.000000000","message":"Yeah I didn\u0027t love this. I\u0027m happy if we did this in another way.","commit_id":"6ddebe99381bfc80f72423d488d8b883dfd0ce8f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d703a8af9eeeb369efae17e80f335e9e92f8cf71","unresolved":true,"context_lines":[{"line_number":3395,"context_line":""},{"line_number":3396,"context_line":"        def delete_server_and_trunks(server: _server.Server) -\u003e None:"},{"line_number":3397,"context_line":"            cleanup_server_trunks(server)"},{"line_number":3398,"context_line":"            self.delete_server(server)"},{"line_number":3399,"context_line":""},{"line_number":3400,"context_line":"        servers \u003d []"},{"line_number":3401,"context_line":"        for obj in self.servers():"}],"source_content_type":"text/x-python","patch_set":1,"id":"46f2f7fe_a29b4a5d","line":3398,"updated":"2026-11-12 22:52:46.000000000","message":"Do we want to make this conditional on cleanup succeeding? I assume someone could skip deletion of trunk ports (or it could fail)?","commit_id":"6ddebe99381bfc80f72423d488d8b883dfd0ce8f"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"d1c77a36658c72364fcb1d33dd7de7816461581c","unresolved":true,"context_lines":[{"line_number":3395,"context_line":""},{"line_number":3396,"context_line":"        def delete_server_and_trunks(server: _server.Server) -\u003e None:"},{"line_number":3397,"context_line":"            cleanup_server_trunks(server)"},{"line_number":3398,"context_line":"            self.delete_server(server)"},{"line_number":3399,"context_line":""},{"line_number":3400,"context_line":"        servers \u003d []"},{"line_number":3401,"context_line":"        for obj in self.servers():"}],"source_content_type":"text/x-python","patch_set":1,"id":"0c934820_85f40d0e","line":3398,"in_reply_to":"46f2f7fe_a29b4a5d","updated":"2026-11-12 23:21:22.000000000","message":"yeah I can.","commit_id":"6ddebe99381bfc80f72423d488d8b883dfd0ce8f"}]}