)]}'
{"openstack/transport.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"a97b6a809a5d7c52b4d281b76beb1d6b68fa285c","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        except requests.RequestException as e:"},{"line_number":154,"context_line":"            raise exceptions.HttpException(six.text_type(e), details\u003dresp.text)"},{"line_number":155,"context_line":"        if accept \u003d\u003d JSON:"},{"line_number":156,"context_line":"            try:"},{"line_number":157,"context_line":"                resp.body \u003d resp.json()"},{"line_number":158,"context_line":"            except ValueError as e: # requests.JSONDecodeError:"},{"line_number":159,"context_line":"                # TODO(dtroyer): is this how we want to handle unexpected"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_c890f044","line":156,"updated":"2014-06-25 19:16:28.000000000","message":"The only other alternative that comes to mind is include this code here:\n\nhttps://github.com/kennethreitz/requests/blob/master/requests/models.py#L611","commit_id":"9a439a22f811940ded24f61a7bd3b095c6442cc6"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"8b8711047e53276cb8a5727f4e625a3b8b6a8494","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        except requests.RequestException as e:"},{"line_number":154,"context_line":"            raise exceptions.HttpException(six.text_type(e), details\u003dresp.text)"},{"line_number":155,"context_line":"        if accept \u003d\u003d JSON:"},{"line_number":156,"context_line":"            try:"},{"line_number":157,"context_line":"                resp.body \u003d resp.json()"},{"line_number":158,"context_line":"            except ValueError as e: # requests.JSONDecodeError:"},{"line_number":159,"context_line":"                # TODO(dtroyer): is this how we want to handle unexpected"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_c89630ef","line":156,"in_reply_to":"1ae5cdf2_c890f044","updated":"2014-06-25 19:23:30.000000000","message":"Part of the point here is to handle non-redirect-related responses of non-JSON, which is_redirect() does not do.\n\nMaybe we just should dump the idea of using resp.body in the first place?","commit_id":"9a439a22f811940ded24f61a7bd3b095c6442cc6"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"a97b6a809a5d7c52b4d281b76beb1d6b68fa285c","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        if accept \u003d\u003d JSON:"},{"line_number":156,"context_line":"            try:"},{"line_number":157,"context_line":"                resp.body \u003d resp.json()"},{"line_number":158,"context_line":"            except ValueError as e: # requests.JSONDecodeError:"},{"line_number":159,"context_line":"                # TODO(dtroyer): is this how we want to handle unexpected"},{"line_number":160,"context_line":"                # not-JSON when that is what is expected?"},{"line_number":161,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_a8864414","line":158,"updated":"2014-06-25 19:16:28.000000000","message":"I take it JSONDecodeError derives from ValueError, why not the requests exception here?","commit_id":"9a439a22f811940ded24f61a7bd3b095c6442cc6"},{"author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"change_message_id":"8b8711047e53276cb8a5727f4e625a3b8b6a8494","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        if accept \u003d\u003d JSON:"},{"line_number":156,"context_line":"            try:"},{"line_number":157,"context_line":"                resp.body \u003d resp.json()"},{"line_number":158,"context_line":"            except ValueError as e: # requests.JSONDecodeError:"},{"line_number":159,"context_line":"                # TODO(dtroyer): is this how we want to handle unexpected"},{"line_number":160,"context_line":"                # not-JSON when that is what is expected?"},{"line_number":161,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_a893a4fe","line":158,"in_reply_to":"1ae5cdf2_a8864414","updated":"2014-06-25 19:23:30.000000000","message":"The actual exception caught is simplejson.scanner.JSONDecodeError","commit_id":"9a439a22f811940ded24f61a7bd3b095c6442cc6"}]}