)]}'
{"id":"openstack%2Fopenstacksdk~102607","triplet_id":"openstack%2Fopenstacksdk~master~I9dd91ec3d803bf5cc0c12b8f10c1d9b7c6f28dcf","project":"openstack/openstacksdk","branch":"master","topic":"transport-json-redirect","hashtags":[],"change_id":"I9dd91ec3d803bf5cc0c12b8f10c1d9b7c6f28dcf","subject":"Change transport JSON handling","status":"MERGED","created":"2014-06-25 19:03:07.000000000","updated":"2014-07-01 19:22:50.000000000","submitted":"2014-07-01 19:22:49.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a7a4f7a0a9c1a5b554878363629387ac001f5b0e","_number":102607,"virtual_id_number":102607,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},{"value":2,"date":"2014-07-01 19:22:49.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"recommended":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"all":[{"value":1,"date":"2014-07-01 19:17:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":2,"date":"2014-07-01 19:19:26.000000000","_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":1,"date":"2014-07-01 19:19:26.000000000","_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Allow-Post-Review":{"all":[{"value":0,"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},{"value":0,"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"}],"values":{" 0":"Abstain","+1":"Approved for Zuul Post Review Pipeline"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-07-01 19:17:14.000000000","updated_by":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"reviewer":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"state":"REVIEWER"},{"updated":"2014-07-01 19:19:26.000000000","updated_by":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"reviewer":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"state":"REVIEWER"},{"updated":"2014-07-01 19:22:49.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"821fa1996540e3a91e71af7c73517d192ffd3af1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-25 19:03:07.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"5d22959cd85753b3f32763f9aed36d9b91ee8577","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-06-25 19:03:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a97b6a809a5d7c52b4d281b76beb1d6b68fa285c","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2014-06-25 19:16:28.000000000","message":"Patch Set 1: Code-Review+2\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"8b8711047e53276cb8a5727f4e625a3b8b6a8494","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-06-25 19:23:30.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"4655e4c27fa41d68cb11e3690122b9ad45efee9f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-25 19:25:18.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-python-openstacksdk-pep8 http://logs.openstack.org/07/102607/1/check/gate-python-openstacksdk-pep8/f94fa48 : FAILURE in 40s\n- gate-python-openstacksdk-docs http://docs-draft.openstack.org/07/102607/1/check/gate-python-openstacksdk-docs/6ed57c8/doc/build/html/ : SUCCESS in 1m 09s\n- gate-python-openstacksdk-python26 http://logs.openstack.org/07/102607/1/check/gate-python-openstacksdk-python26/4d25260 : SUCCESS in 1m 06s\n- gate-python-openstacksdk-python27 http://logs.openstack.org/07/102607/1/check/gate-python-openstacksdk-python27/0dc24fe : SUCCESS in 50s\n- gate-python-openstacksdk-python33 http://logs.openstack.org/07/102607/1/check/gate-python-openstacksdk-python33/2198677 : SUCCESS in 3m 15s\n- gate-python-openstacksdk-pypy http://logs.openstack.org/07/102607/1/check/gate-python-openstacksdk-pypy/c81d5e5 : SUCCESS in 1m 10s","accounts_in_message":[],"_revision_number":1},{"id":"41161e7a29dee7b3216e20220d471080efe14db6","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2014-06-27 16:41:08.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b6ec9ad9e41411455ac2da3fa8567b5b26a92d8b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-27 16:41:09.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"a8fd4b9cc3f86a94dc85625ac3f4b777920b65c0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-06-27 16:50:36.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-python-openstacksdk-pep8 http://logs.openstack.org/07/102607/2/check/gate-python-openstacksdk-pep8/bf73fb2 : SUCCESS in 57s\n- gate-python-openstacksdk-docs http://docs-draft.openstack.org/07/102607/2/check/gate-python-openstacksdk-docs/f27d612/doc/build/html/ : SUCCESS in 53s\n- gate-python-openstacksdk-python26 http://logs.openstack.org/07/102607/2/check/gate-python-openstacksdk-python26/cca8f60 : SUCCESS in 46s\n- gate-python-openstacksdk-python27 http://logs.openstack.org/07/102607/2/check/gate-python-openstacksdk-python27/fd3c3ca : SUCCESS in 1m 12s\n- gate-python-openstacksdk-python33 http://logs.openstack.org/07/102607/2/check/gate-python-openstacksdk-python33/5846441 : SUCCESS in 3m 04s\n- gate-python-openstacksdk-pypy http://logs.openstack.org/07/102607/2/check/gate-python-openstacksdk-pypy/92ce4d7 : SUCCESS in 1m 04s","accounts_in_message":[],"_revision_number":2},{"id":"a9f769f45aa9e56532f02e9c92f58fa05f4c209b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-01 17:26:34.000000000","message":"Patch Set 2: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"3cd60b11d4024c850d0ab39f95729dc3589351f9","author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"date":"2014-07-01 17:26:34.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"dfb43518b09aaff0ffa885a26fc614a96bcd7dc0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-01 17:30:59.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded.\n\n- gate-python-openstacksdk-pep8 http://logs.openstack.org/07/102607/2/check/gate-python-openstacksdk-pep8/c8a28b1 : SUCCESS in 53s\n- gate-python-openstacksdk-docs http://docs-draft.openstack.org/07/102607/2/check/gate-python-openstacksdk-docs/b6f22ea/doc/build/html/ : SUCCESS in 1m 47s\n- gate-python-openstacksdk-python26 http://logs.openstack.org/07/102607/2/check/gate-python-openstacksdk-python26/24f901d : SUCCESS in 1m 21s\n- gate-python-openstacksdk-python27 http://logs.openstack.org/07/102607/2/check/gate-python-openstacksdk-python27/98108e4 : SUCCESS in 1m 17s\n- gate-python-openstacksdk-python33 http://logs.openstack.org/07/102607/2/check/gate-python-openstacksdk-python33/87cb0a1 : SUCCESS in 3m 17s\n- gate-python-openstacksdk-pypy http://logs.openstack.org/07/102607/2/check/gate-python-openstacksdk-pypy/00f0ede : SUCCESS in 1m 31s","accounts_in_message":[],"_revision_number":2},{"id":"c7564be7312a938bd4ace93aa46eb280c178021c","author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"date":"2014-07-01 19:17:14.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"c1dbd22fe3eaaab51f92dd11aa6fd56b52ebda64","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-01 19:19:26.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"54b5b9114381d45fddde9e93766094c40730be72","author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"date":"2014-07-01 19:19:26.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"24cf5a7f91fe6253e6ec9851b5fa5073d2a64432","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-01 19:22:49.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded.\n\n- gate-python-openstacksdk-docs http://docs-draft.openstack.org/07/102607/2/gate/gate-python-openstacksdk-docs/344407c/doc/build/html/ : SUCCESS in 1m 42s\n- gate-python-openstacksdk-pep8 http://logs.openstack.org/07/102607/2/gate/gate-python-openstacksdk-pep8/625bbd4 : SUCCESS in 49s\n- gate-python-openstacksdk-python26 http://logs.openstack.org/07/102607/2/gate/gate-python-openstacksdk-python26/17af11b : SUCCESS in 1m 15s\n- gate-python-openstacksdk-python27 http://logs.openstack.org/07/102607/2/gate/gate-python-openstacksdk-python27/4f01028 : SUCCESS in 1m 01s\n- gate-python-openstacksdk-python33 http://logs.openstack.org/07/102607/2/gate/gate-python-openstacksdk-python33/4f332f3 : SUCCESS in 3m 20s\n- gate-python-openstacksdk-pypy http://logs.openstack.org/07/102607/2/gate/gate-python-openstacksdk-pypy/7a87f37 : SUCCESS in 1m 28s","accounts_in_message":[],"_revision_number":2},{"id":"c9fb87dd87e3be2e73a0a92693195d20c7b339fd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-01 19:22:50.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"49e871dc0bfcdccb723f2b569842c03aa3b1f2bb","revisions":{"9a439a22f811940ded24f61a7bd3b095c6442cc6":{"kind":"REWORK","_number":1,"created":"2014-06-25 19:03:07.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/07/102607/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/07/102607/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/07/102607/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/07/102607/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/07/102607/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/07/102607/1"}}},"commit":{"parents":[{"commit":"34084339c86d487e04487719bbd6bc332df3f2d1","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/34084339c86d487e04487719bbd6bc332df3f2d1"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-06-25 18:54:07.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-06-25 19:02:50.000000000","tz":-300},"subject":"Change transport JSON handling","message":"Change transport JSON handling\n\nTransport.request() was using a new attribute in a not-yet-released\nversion of requests (Response.is_redirect).  It skipped the JSON decode\nfor redirect responses which is really not what we want.\n\nThe tests for redirects have been duplicated for both JSON and text\nresponses.\n\nChange-Id: I9dd91ec3d803bf5cc0c12b8f10c1d9b7c6f28dcf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/9a439a22f811940ded24f61a7bd3b095c6442cc6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/9a439a22f811940ded24f61a7bd3b095c6442cc6"}]},"branch":"refs/heads/master"},"49e871dc0bfcdccb723f2b569842c03aa3b1f2bb":{"kind":"REWORK","_number":2,"created":"2014-06-27 16:41:08.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/07/102607/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/openstacksdk","ref":"refs/changes/07/102607/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/07/102607/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/07/102607/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/openstacksdk refs/changes/07/102607/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/openstacksdk refs/changes/07/102607/2"}}},"commit":{"parents":[{"commit":"34084339c86d487e04487719bbd6bc332df3f2d1","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/34084339c86d487e04487719bbd6bc332df3f2d1"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-06-25 18:54:07.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2014-06-27 16:38:19.000000000","tz":-300},"subject":"Change transport JSON handling","message":"Change transport JSON handling\n\nTransport.request() was using a new attribute in a not-yet-released\nversion of requests (Response.is_redirect).  It skipped the JSON decode\nfor redirect responses which is really not what we want anyway.\nInstead raise InvalidResponse on JSON decode error when JSON is expected.\n\nAll tests needed updating to properly handle the JSON default in Transport.\nIs that the right default at the transport level?\n\nThe tests for redirects have been duplicated for both JSON and text\nresponses.\n\nChange-Id: I9dd91ec3d803bf5cc0c12b8f10c1d9b7c6f28dcf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/49e871dc0bfcdccb723f2b569842c03aa3b1f2bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/openstacksdk/commit/49e871dc0bfcdccb723f2b569842c03aa3b1f2bb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
