)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"c5273c880043b88f6a3e5ba737ead0dca647b288","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add support for Samples coming from Ceilometer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Can add or list Samples only. Samples are a sub-resource under a Metric."},{"line_number":10,"context_line":"Query-String filtering is supported of samples."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia1f157bffcd74dde203488917f2d5fa1df7e44aa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1abeadc6_7f722412","line":10,"updated":"2014-08-27 16:45:41.000000000","message":"Should probably mention the resource change here.","commit_id":"8882de11fa06429ba438d95ad890fbdac3a685ca"}],"openstack/resource.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"147f09539a94836260240ab7df8b62e8b76fec4a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            raise AttributeError(\u0027Unset property: %s\u0027 % self.name)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"class compositeProp(object):"},{"line_number":87,"context_line":"    \"\"\"A helper for defining an attribute with an alternate deprecated name."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        By specifying an alias attribute name, that alias will be read when"}],"source_content_type":"text/x-python","patch_set":5,"id":"da9df570_c112ceb3","line":86,"updated":"2014-09-22 16:40:59.000000000","message":"I think I would rather see this supported directly inside `prop`, with `alias` being a named argument in prop.__init__","commit_id":"c0228501f610abb4f66c57c72bb6801f5f9c735f"}],"openstack/telemetry/v2/meter.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"147f09539a94836260240ab7df8b62e8b76fec4a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        path_args \u003d {\u0027meter_name\u0027: self.name}"},{"line_number":47,"context_line":"        statistics.Statistics.list(session, path_args, **params)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def samples(self, session, **params):"},{"line_number":50,"context_line":"        path_args \u003d {\u0027meter_name\u0027: self.name}"},{"line_number":51,"context_line":"        sample.Sample.list(session, path_args, **params)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da9df570_61d842f0","line":49,"updated":"2014-09-22 16:40:59.000000000","message":"I think this falls under the same thing as the other review that added the statistics method, attempting to keep functionality in this class only to Meters and adding other things at a higher level\n\n(please forgive me if I\u0027m misunderstanding this - that\u0027s very possible.)","commit_id":"c0228501f610abb4f66c57c72bb6801f5f9c735f"}],"openstack/tests/telemetry/v2/test_sample.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"c5273c880043b88f6a3e5ba737ead0dca647b288","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                \u0027volume\u0027: \u002798.6\u0027}"},{"line_number":131,"context_line":"        new_sample \u003d sample.Sample.new(**data)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        new_sample.create(sess)"},{"line_number":134,"context_line":"        self.assertEqual(IDENTIFIER, new_sample.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_5f49e8ce","line":133,"updated":"2014-08-27 16:45:41.000000000","message":"Need a sessl.post.assert_called_with here I think to verify the url and the reuqest body.  I see I didn\u0027t do that on some of the sess.get calls, but I think I should.","commit_id":"8882de11fa06429ba438d95ad890fbdac3a685ca"}]}