)]}'
{"openstack/telemetry/v2/meter.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"5e113bfcd4f6158c8f45ae1091e14be9d6ff86c1","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            val \u003d None"},{"line_number":42,"context_line":"        return val"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def statistics(self, session, **params):"},{"line_number":45,"context_line":"        path_args \u003d {\u0027meter_name\u0027: self.name}"},{"line_number":46,"context_line":"        statistics.Statistics.list(session, path_args, **params)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da9df570_e1799294","line":44,"updated":"2014-09-22 16:24:08.000000000","message":"I think this should be handled a level up from here in what Terry started building out. Back during my first iteration of the swift API we discussed keeping each resource completely isolated so Meter only ever does Meter stuff and Statistics does Statistics stuff.\n\nIn that swift iteration, doing Container.list() was directly creating Objects in a given container instead of what it does now, listing the available containers.","commit_id":"2e48fc29b0aa827f285e925f4b8a1baf66bf4001"}],"openstack/telemetry/v2/statistics.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"1b111b90d14444aa1e8df1e5318d03aeff94c450","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class Statistics(resource.Resource):"},{"line_number":18,"context_line":"    resource_key \u003d \u0027statistics\u0027"},{"line_number":19,"context_line":"    base_path \u003d \u0027/v2/meters/%(meter)s/statistics\u0027"},{"line_number":20,"context_line":"    service \u003d telemetry_service.TelemetryService()"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    # Supported Operations"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_8918b276","line":19,"updated":"2014-08-27 15:55:11.000000000","message":"I think it would be more clear to call this meter_name","commit_id":"275d0953418cf0ba5768887909646e26e94c009e"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"8c3cd1306e094cd9222534f461c04e3f145b45fe","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class Statistics(resource.Resource):"},{"line_number":18,"context_line":"    resource_key \u003d \u0027statistics\u0027"},{"line_number":19,"context_line":"    base_path \u003d \u0027/v2/meters/%(meter)s/statistics\u0027"},{"line_number":20,"context_line":"    service \u003d telemetry_service.TelemetryService()"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    # Supported Operations"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_df0fb8df","line":19,"in_reply_to":"1abeadc6_8918b276","updated":"2014-08-27 16:35:10.000000000","message":"I noticed in the samples section, the alt name for counter_name is meter?  Are they going to calling that \u0027meter\u0027 instead of \u0027meter_name\u0027.","commit_id":"275d0953418cf0ba5768887909646e26e94c009e"},{"author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"change_message_id":"dadf624694666a2e3b8da5802a1fb78f1ed7497a","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class Statistics(resource.Resource):"},{"line_number":18,"context_line":"    resource_key \u003d \u0027statistics\u0027"},{"line_number":19,"context_line":"    base_path \u003d \u0027/v2/meters/%(meter)s/statistics\u0027"},{"line_number":20,"context_line":"    service \u003d telemetry_service.TelemetryService()"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    # Supported Operations"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_a9cd6933","line":19,"in_reply_to":"1abeadc6_df0fb8df","updated":"2014-08-27 18:10:59.000000000","message":"I had the same concern and I elected to pick one and sort it out in review. \n\nThe published name of the attribute on samples is meter: http://docs.openstack.org/developer/ceilometer/webapi/v2.html#samples-and-statistics\n\nThis conflicts with the uri parameter of meter_name:\nhttp://docs.openstack.org/developer/ceilometer/webapi/v2.html#meters\n\nI feel more comfortable with using meter_name in resolving the path at this point.","commit_id":"275d0953418cf0ba5768887909646e26e94c009e"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"1b111b90d14444aa1e8df1e5318d03aeff94c450","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    def id(self):"},{"line_number":43,"context_line":"        return None"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    # FIXME copy-pasta"},{"line_number":46,"context_line":"    @classmethod"},{"line_number":47,"context_line":"    def list(cls, session, path_args\u003dNone, **params):"},{"line_number":48,"context_line":"        url \u003d cls.base_path % path_args"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_29af9ee4","line":45,"updated":"2014-08-27 15:55:11.000000000","message":"I\u0027m thinking we don\u0027t want to bother fixing this.","commit_id":"275d0953418cf0ba5768887909646e26e94c009e"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"78d5da5d9db29d0f290c59d388e0cd8523f32e47","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @property"},{"line_number":45,"context_line":"    def id(self):"},{"line_number":46,"context_line":"        return None"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @classmethod"},{"line_number":49,"context_line":"    def list(cls, session, path_args\u003dNone, **params):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da9df570_6e4981b6","line":46,"updated":"2014-09-26 19:03:14.000000000","message":"In a way, meter_name could be the key if that helps anything.","commit_id":"c0c04ec4dfd3a5510821b4898b076b99ba79090a"}]}