)]}'
{"openstack/object_store/v1/container.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"0233af9d21d7c0d31636260a561a7857d2365d7a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    if_none_match \u003d resource.prop(\"if-none-match\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @property"},{"line_number":62,"context_line":"    def id(self):"},{"line_number":63,"context_line":"        return None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _do_create_update(self, session, method):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_6e07fd1c","line":62,"updated":"2014-09-02 18:48:50.000000000","message":"https://review.openstack.org/#/c/116733/ this should get rid of this problem.  Instead of redefining id, just set id_attribute \u003d \u0027name\u0027","commit_id":"91c54dbc2f445439db5ad21fcb84b6430115b47f"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"3b46f62956d43366b0a402417d014e96127873b0","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    if_none_match \u003d resource.prop(\"if-none-match\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @property"},{"line_number":62,"context_line":"    def id(self):"},{"line_number":63,"context_line":"        return None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _do_create_update(self, session, method):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_d475a5cb","line":62,"in_reply_to":"fa98f980_6e07fd1c","updated":"2014-09-03 22:28:29.000000000","message":"Done","commit_id":"91c54dbc2f445439db5ad21fcb84b6430115b47f"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"0233af9d21d7c0d31636260a561a7857d2365d7a","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        if resp_id:"},{"line_number":77,"context_line":"            data[\"id\"] \u003d resp_id"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self._attrs[\u0027id\u0027] \u003d data[\u0027id\u0027]"},{"line_number":80,"context_line":"        self._reset_dirty()"},{"line_number":81,"context_line":"        return data"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_ae4ba585","line":79,"updated":"2014-09-02 18:48:50.000000000","message":"I don\u0027t think it makes sense to set \u0027id\u0027 to a transaction id that is just ephemeral debug information","commit_id":"91c54dbc2f445439db5ad21fcb84b6430115b47f"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"3b46f62956d43366b0a402417d014e96127873b0","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        if resp_id:"},{"line_number":77,"context_line":"            data[\"id\"] \u003d resp_id"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self._attrs[\u0027id\u0027] \u003d data[\u0027id\u0027]"},{"line_number":80,"context_line":"        self._reset_dirty()"},{"line_number":81,"context_line":"        return data"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_f47e29ae","line":79,"in_reply_to":"fa98f980_ae4ba585","updated":"2014-09-03 22:28:29.000000000","message":"Done","commit_id":"91c54dbc2f445439db5ad21fcb84b6430115b47f"}],"openstack/object_store/v1/obj.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"0233af9d21d7c0d31636260a561a7857d2365d7a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from openstack import resource"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class Object(resource.Resource):"},{"line_number":20,"context_line":"    base_path \u003d \"/%(container)s/%(name)s\""},{"line_number":21,"context_line":"    service \u003d object_store_service.ObjectStoreService()"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_09b90be9","line":19,"updated":"2014-09-02 18:48:50.000000000","message":"Wasn\u0027t there some talk at some point about calling this something other than Object?  Maybe Obj and that would match the file name.","commit_id":"91c54dbc2f445439db5ad21fcb84b6430115b47f"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"3b46f62956d43366b0a402417d014e96127873b0","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from openstack import resource"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class Object(resource.Resource):"},{"line_number":20,"context_line":"    base_path \u003d \"/%(container)s/%(name)s\""},{"line_number":21,"context_line":"    service \u003d object_store_service.ObjectStoreService()"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_1453ad39","line":19,"in_reply_to":"fa98f980_09b90be9","updated":"2014-09-03 22:28:29.000000000","message":"That was more of an issue when the file was called \u0027object\u0027, which obviously shadows the builtin name when you import it. Since \"Object\" doesn\u0027t shadow anything, I\u0027d prefer to stick with it, but if others want it to match that\u0027s fine as well.","commit_id":"91c54dbc2f445439db5ad21fcb84b6430115b47f"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"72d8b6c68f00b36f813b1858422768dc7e2a00d4","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # query parameters."},{"line_number":84,"context_line":"        headers \u003d self._attrs.copy()"},{"line_number":85,"context_line":"        for val in (\"container\", \"name\", \"hash\", \"bytes\", \"signature\","},{"line_number":86,"context_line":"                    \"expires\", \"multipart_manifest\"):"},{"line_number":87,"context_line":"            headers.pop(val, None)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        resp \u003d session.get(url, service\u003dself.service, accept\u003d\"bytes\","}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_d51ccbc4","line":86,"updated":"2014-08-28 18:24:56.000000000","message":"Note that I don\u0027t like this, but there isn\u0027t currently a way to separate out the properties that are sent/received in the body from the other values that are to be sent/received in headers. Technically nothing is stopping us from just not removing those, but I don\u0027t want to be storing things in headers that weren\u0027t set to be headers.\n\nI briefly looked at modifying Resource to separately store _attrs and _headers, but it seemed like a bit of a hassle.","commit_id":"91c54dbc2f445439db5ad21fcb84b6430115b47f"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"0233af9d21d7c0d31636260a561a7857d2365d7a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        # query parameters."},{"line_number":84,"context_line":"        headers \u003d self._attrs.copy()"},{"line_number":85,"context_line":"        for val in (\"container\", \"name\", \"hash\", \"bytes\", \"signature\","},{"line_number":86,"context_line":"                    \"expires\", \"multipart_manifest\"):"},{"line_number":87,"context_line":"            headers.pop(val, None)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        resp \u003d session.get(url, service\u003dself.service, accept\u003d\"bytes\","}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_696d3798","line":86,"in_reply_to":"1abeadc6_d51ccbc4","updated":"2014-09-02 18:48:50.000000000","message":"I think this is fine for now, but we should probably make a distinction in the future.  Maybe a ticket to do headers differently?","commit_id":"91c54dbc2f445439db5ad21fcb84b6430115b47f"}]}