)]}'
{"examples/common.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"61b975b89b722d67c2195267e6d2a5a1433222ef","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                continue"},{"line_number":108,"context_line":"            cls.set_option(v, values)"},{"line_number":109,"context_line":"            return cls.pref"},{"line_number":110,"context_line":"        return cls.pref"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @classmethod"},{"line_number":113,"context_line":"    def set_option(cls, var, values):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_44bc60dc","line":110,"updated":"2014-09-15 19:38:22.000000000","message":"This should be updated to the user preference review.","commit_id":"395809807c042f52afa30043f3d681b44568b5f8"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"33d5797e7bdb28fbbe5794c229d33da4b82b773d","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                continue"},{"line_number":108,"context_line":"            cls.set_option(v, values)"},{"line_number":109,"context_line":"            return cls.pref"},{"line_number":110,"context_line":"        return cls.pref"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @classmethod"},{"line_number":113,"context_line":"    def set_option(cls, var, values):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_c93d3991","line":110,"in_reply_to":"fa98f980_44bc60dc","updated":"2014-10-14 21:20:46.000000000","message":"Done","commit_id":"395809807c042f52afa30043f3d681b44568b5f8"}],"examples/find.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"61b975b89b722d67c2195267e6d2a5a1433222ef","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\"\"\""},{"line_number":14,"context_line":"Example Find Command"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"For example:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_0418981c","line":13,"updated":"2014-09-15 19:38:22.000000000","message":"This needs to be put into another commit","commit_id":"395809807c042f52afa30043f3d681b44568b5f8"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"33d5797e7bdb28fbbe5794c229d33da4b82b773d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\"\"\""},{"line_number":14,"context_line":"Example Find Command"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"For example:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_294c0542","line":13,"in_reply_to":"fa98f980_0418981c","updated":"2014-10-14 21:20:46.000000000","message":"Done","commit_id":"395809807c042f52afa30043f3d681b44568b5f8"}],"jenkins.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"61b975b89b722d67c2195267e6d2a5a1433222ef","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    conn \u003d connection.Connection()"},{"line_number":11,"context_line":"    conn.create_transport(verify\u003dopts.verify)"},{"line_number":12,"context_line":"    conn.create_authenticator(opts.auth_plugin, **args)"},{"line_number":13,"context_line":"    conn.create_session(preference\u003dopts.user_preferences)"},{"line_number":14,"context_line":"    conn.open()"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_c473f07d","line":13,"updated":"2014-09-15 19:38:22.000000000","message":"The 3 creates seem kind of awkward.  Might be nice if the Connection constructor would take a Namespace or dict and just do this, but it also might be nice if the user could build a connection with an existing transport, authenticator, or session from another connection.","commit_id":"395809807c042f52afa30043f3d681b44568b5f8"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"33d5797e7bdb28fbbe5794c229d33da4b82b773d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    conn \u003d connection.Connection()"},{"line_number":11,"context_line":"    conn.create_transport(verify\u003dopts.verify)"},{"line_number":12,"context_line":"    conn.create_authenticator(opts.auth_plugin, **args)"},{"line_number":13,"context_line":"    conn.create_session(preference\u003dopts.user_preferences)"},{"line_number":14,"context_line":"    conn.open()"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_a95f15e4","line":13,"in_reply_to":"da9df570_1de4563a","updated":"2014-10-14 21:20:46.000000000","message":"Done","commit_id":"395809807c042f52afa30043f3d681b44568b5f8"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"d4f5f450d60f1c5e43f168c122d9f85baf4b8b86","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    conn \u003d connection.Connection()"},{"line_number":11,"context_line":"    conn.create_transport(verify\u003dopts.verify)"},{"line_number":12,"context_line":"    conn.create_authenticator(opts.auth_plugin, **args)"},{"line_number":13,"context_line":"    conn.create_session(preference\u003dopts.user_preferences)"},{"line_number":14,"context_line":"    conn.open()"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_1de4563a","line":13,"in_reply_to":"fa98f980_66b4e8d4","updated":"2014-09-20 12:15:10.000000000","message":"I think what might be nice is if the user was allowed to pass transport, authenticator, and session in the Connection constructor and then have one create method that took all the options and would only create transport, authenticator and session if they did not already exist.","commit_id":"395809807c042f52afa30043f3d681b44568b5f8"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"2f6067d113bb79589095040cd458757d9a6eb545","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    conn \u003d connection.Connection()"},{"line_number":11,"context_line":"    conn.create_transport(verify\u003dopts.verify)"},{"line_number":12,"context_line":"    conn.create_authenticator(opts.auth_plugin, **args)"},{"line_number":13,"context_line":"    conn.create_session(preference\u003dopts.user_preferences)"},{"line_number":14,"context_line":"    conn.open()"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_de064221","line":13,"in_reply_to":"fa98f980_c473f07d","updated":"2014-09-16 18:27:03.000000000","message":"Yep, handling those calls inside Connection.__init__ would be great, either creating new trans/auth/sess given the parameters or using existing objects.","commit_id":"395809807c042f52afa30043f3d681b44568b5f8"},{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"47574df2ff3f6b54816b366514538117cf8bc7e1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    conn \u003d connection.Connection()"},{"line_number":11,"context_line":"    conn.create_transport(verify\u003dopts.verify)"},{"line_number":12,"context_line":"    conn.create_authenticator(opts.auth_plugin, **args)"},{"line_number":13,"context_line":"    conn.create_session(preference\u003dopts.user_preferences)"},{"line_number":14,"context_line":"    conn.open()"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_66b4e8d4","line":13,"in_reply_to":"fa98f980_de064221","updated":"2014-09-16 19:45:04.000000000","message":"Generally people don\u0027t expect exceptions to happen while initializing an object (i.e., in Connection.__init__) perhaps having just one method to call after that which would accept the options would be the best design","commit_id":"395809807c042f52afa30043f3d681b44568b5f8"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"33d5797e7bdb28fbbe5794c229d33da4b82b773d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            \"networks\": [{\"uuid\": network.id}],"},{"line_number":63,"context_line":"        }"},{"line_number":64,"context_line":"        server \u003d conn.compute.server_create(args)"},{"line_number":65,"context_line":"    print(str(server))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    return"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_69a7ed50","line":65,"updated":"2014-10-14 21:20:46.000000000","message":"Still need to assign the IP to the port and do some cloud-init think to \"apt-get install jenkins\"","commit_id":"395809807c042f52afa30043f3d681b44568b5f8"}],"openstack/auth/identity/v2.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"47574df2ff3f6b54816b366514538117cf8bc7e1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.user_name \u003d user_name"},{"line_number":72,"context_line":"        self.password \u003d password"},{"line_number":73,"context_line":"        if token:"},{"line_number":74,"context_line":"            self.token \u003d token"},{"line_number":75,"context_line":"        else:"},{"line_number":76,"context_line":"            self.token \u003d None"},{"line_number":77,"context_line":"        self.trust_id \u003d trust_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_e6c7f844","line":74,"updated":"2014-09-16 19:45:04.000000000","message":"Why not more simply\n\nself.token \u003d token or None","commit_id":"395809807c042f52afa30043f3d681b44568b5f8"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"33d5797e7bdb28fbbe5794c229d33da4b82b773d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.user_name \u003d user_name"},{"line_number":72,"context_line":"        self.password \u003d password"},{"line_number":73,"context_line":"        if token:"},{"line_number":74,"context_line":"            self.token \u003d token"},{"line_number":75,"context_line":"        else:"},{"line_number":76,"context_line":"            self.token \u003d None"},{"line_number":77,"context_line":"        self.trust_id \u003d trust_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_69f9ad4d","line":74,"in_reply_to":"fa98f980_e6c7f844","updated":"2014-10-14 21:20:46.000000000","message":"Done https://review.openstack.org/#/c/128447/","commit_id":"395809807c042f52afa30043f3d681b44568b5f8"}],"openstack/exceptions.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"33d5797e7bdb28fbbe5794c229d33da4b82b773d","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class HttpException(SDKException):"},{"line_number":61,"context_line":"    def __init__(self, message, details\u003dNone):"},{"line_number":62,"context_line":"        super(HttpException, self).__init__(message + \": \" + str(details))"},{"line_number":63,"context_line":"        self.details \u003d details"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_498789b5","line":62,"updated":"2014-10-14 21:20:46.000000000","message":"Handled in https://review.openstack.org/#/c/121411/","commit_id":"395809807c042f52afa30043f3d681b44568b5f8"}],"openstack/network/v2/potentate.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"2f6067d113bb79589095040cd458757d9a6eb545","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    def __init__(self, session):"},{"line_number":22,"context_line":"        self.session \u003d session"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def network_create(self, data\u003d{}):"},{"line_number":25,"context_line":"        obj \u003d network.Network(data)"},{"line_number":26,"context_line":"        obj.create(self.session)"},{"line_number":27,"context_line":"        return obj"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_0090644d","line":24,"updated":"2014-09-16 18:27:03.000000000","message":"These \u0027\u0027\u0027data\u003d{}\u0027\u0027\u0027 args should be \u003dNone and then in the body set them to an empty dict if data is None.","commit_id":"395809807c042f52afa30043f3d681b44568b5f8"}],"openstack/resource.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"61b975b89b722d67c2195267e6d2a5a1433222ef","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        return \"%s: %s\" % (self.get_resource_name(), self._attrs)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @classmethod"},{"line_number":137,"context_line":"    def get_resource_name(cls):"},{"line_number":138,"context_line":"        if cls.resource_name:"},{"line_number":139,"context_line":"            return cls.resource_name"},{"line_number":140,"context_line":"        if cls.resource_key:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_04efb8e9","line":137,"updated":"2014-09-15 19:38:22.000000000","message":"These fixes also need to be in another commit","commit_id":"395809807c042f52afa30043f3d681b44568b5f8"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"33d5797e7bdb28fbbe5794c229d33da4b82b773d","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        return \"%s: %s\" % (self.get_resource_name(), self._attrs)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @classmethod"},{"line_number":137,"context_line":"    def get_resource_name(cls):"},{"line_number":138,"context_line":"        if cls.resource_name:"},{"line_number":139,"context_line":"            return cls.resource_name"},{"line_number":140,"context_line":"        if cls.resource_key:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_2921654d","line":137,"in_reply_to":"fa98f980_04efb8e9","updated":"2014-10-14 21:20:46.000000000","message":"Done","commit_id":"395809807c042f52afa30043f3d681b44568b5f8"}]}
