)]}'
{"openstack/tests/functional/base.py":[{"author":{"_account_id":1112,"name":"Everett Toews","email":"everett.toews@rackspace.com","username":"everett-toews"},"change_message_id":"e7b79d4bf987aeae633a2c3b552538a28d29490a","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        self.conn \u003d connection.Connection("},{"line_number":30,"context_line":"            preference\u003dpref,"},{"line_number":31,"context_line":"            **test_cloud.config[\u0027auth\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_78065987","line":31,"updated":"2015-05-04 22:01:06.000000000","message":"When I initially wrote this in TestServer, I unpacked the config similarly like this. Then Brian asked me to set the kwargs directly [1]. I assumed it was to be more explicit and more illustrative to developers reading the test code later.\n\nShould we continue to set the kwargs directly in this base class?\n\n[1] https://review.openstack.org/#/c/170343/1/openstack/tests/functional/compute/v2/test_server.py","commit_id":"0b919b914f041c174d7b2787524b6e80e33db93e"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"2d11d7e9277c07c3b9331b6a4cf6fc642dfbba4e","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        self.conn \u003d connection.Connection("},{"line_number":30,"context_line":"            preference\u003dpref,"},{"line_number":31,"context_line":"            **test_cloud.config[\u0027auth\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_d85d6d48","line":31,"in_reply_to":"3acd31a7_78065987","updated":"2015-05-04 22:08:42.000000000","message":"Especially in examples, if we can be explicit I think we should be explicit. Without knowing what is actually being set in the Connection initializer through that unpacking, you can\u0027t directly take this into your code without also using OCC.","commit_id":"0b919b914f041c174d7b2787524b6e80e33db93e"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"7c126216b7332200fed15def8d59d41b6bb10c06","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        self.conn \u003d connection.Connection("},{"line_number":30,"context_line":"            preference\u003dpref,"},{"line_number":31,"context_line":"            **test_cloud.config[\u0027auth\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_27966793","line":31,"in_reply_to":"3acd31a7_c038c1f1","updated":"2015-05-05 15:09:28.000000000","message":"We do have valid_options in the plugins and we could use that to extract a \u0027valid\u0027 list.  I\u0027d sooner caveat emptor and trust the user.\n\nBTW, OCC added some code to extract and information from environment variables, but this won\u0027t use that right now since this is hard coded to \u0027test_cloud\u0027","commit_id":"0b919b914f041c174d7b2787524b6e80e33db93e"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"44357b92293213a53fbbfdd87c0803a8d3f12c3a","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        self.conn \u003d connection.Connection("},{"line_number":30,"context_line":"            preference\u003dpref,"},{"line_number":31,"context_line":"            **test_cloud.config[\u0027auth\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3acd31a7_c038c1f1","line":31,"in_reply_to":"3acd31a7_d85d6d48","updated":"2015-05-05 13:28:32.000000000","message":"1) This isn\u0027t technically isn\u0027t an example, it is a functional test\n2) The previous failed for me immediately because I was using v3 auth.\n3)  I don\u0027t think we should try to support parsing all the possible args for all the possible auth types and if we are going to do that, we shouldn\u0027t do that here.  The problem with doing that is we are going to block people getting their job done just because we are incorrect or not up to date with our parsing.","commit_id":"0b919b914f041c174d7b2787524b6e80e33db93e"}]}