)]}'
{"openstack/tests/functional/object/v1/test_container.py":[{"author":{"_account_id":1112,"name":"Everett Toews","email":"everett.toews@rackspace.com","username":"everett-toews"},"change_message_id":"b85cbf6ec6c71760f6448885b44f0d71400f3576","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    @classmethod"},{"line_number":23,"context_line":"    def setUpClass(cls):"},{"line_number":24,"context_line":"        super(TestContainer, cls).setUpClass()"},{"line_number":25,"context_line":"        rv \u003d cls.conn.object_store.create_container(cls.NAME)"},{"line_number":26,"context_line":"        cls.assertIs(\u0027openstack.object_store.v1.container\u0027, rv.__module__)"},{"line_number":27,"context_line":"        cls.assertIs(\u0027Container\u0027, rv.__class__.__name__)"},{"line_number":28,"context_line":"        cls.assertIs(cls.NAME, rv.name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9af37de9_6f48525c","line":25,"updated":"2015-05-11 15:20:49.000000000","message":"rv\u003d\u003dreturn value?\n\nPlease change this to something more straight-forward like \"container\"","commit_id":"38d5ad2757d329e0971ea5151a8c3b806ddc0dd0"},{"author":{"_account_id":1112,"name":"Everett Toews","email":"everett.toews@rackspace.com","username":"everett-toews"},"change_message_id":"b85cbf6ec6c71760f6448885b44f0d71400f3576","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        super(TestContainer, cls).setUpClass()"},{"line_number":25,"context_line":"        rv \u003d cls.conn.object_store.create_container(cls.NAME)"},{"line_number":26,"context_line":"        cls.assertIs(\u0027openstack.object_store.v1.container\u0027, rv.__module__)"},{"line_number":27,"context_line":"        cls.assertIs(\u0027Container\u0027, rv.__class__.__name__)"},{"line_number":28,"context_line":"        cls.assertIs(cls.NAME, rv.name)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"9af37de9_2fbfead1","line":27,"updated":"2015-05-11 15:20:49.000000000","message":"I have to ask...what\u0027s the value in these 2 assertIs tests?\n\nWe\u0027re just asserting that the container code is in the module/class it\u0027s already in. If we assert this sort of thing here, why not add these assertIs to every test?","commit_id":"38d5ad2757d329e0971ea5151a8c3b806ddc0dd0"},{"author":{"_account_id":1112,"name":"Everett Toews","email":"everett.toews@rackspace.com","username":"everett-toews"},"change_message_id":"b85cbf6ec6c71760f6448885b44f0d71400f3576","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        # cls.assertIs(None, rv)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_list(self):"},{"line_number":38,"context_line":"        names \u003d [o.name for o in self.conn.object_store.containers()]"},{"line_number":39,"context_line":"        self.assertIn(self.NAME, names)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9af37de9_6f9cd269","line":38,"updated":"2015-05-11 15:20:49.000000000","message":"IMO\n\n    list(self.conn.object_store.containers())\n\nis shorter and more readable. It would even fit in the assertIn below.","commit_id":"38d5ad2757d329e0971ea5151a8c3b806ddc0dd0"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"345a1158123ec6ec41307e0f1165f8ea20a93ee6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        # cls.assertIs(None, rv)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_list(self):"},{"line_number":38,"context_line":"        names \u003d [o.name for o in self.conn.object_store.containers()]"},{"line_number":39,"context_line":"        self.assertIn(self.NAME, names)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ad58531_b3d000cb","line":38,"in_reply_to":"9af37de9_6f9cd269","updated":"2015-05-11 20:17:30.000000000","message":"I\u0027m constructing an array of names out of the containers, not a list of containers.","commit_id":"38d5ad2757d329e0971ea5151a8c3b806ddc0dd0"}]}