)]}'
{"openstack/network/v2/_proxy.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"e14f345381642c86d3847c05069f1f3c22536722","unresolved":false,"context_lines":[{"line_number":815,"context_line":"        \"\"\""},{"line_number":816,"context_line":"        return self._update(subnet.Subnet, value, **attrs)"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    def create_vpnservice(self, **attrs):"},{"line_number":819,"context_line":"        \"\"\"Create a new vpnservice from attributes"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"        :param dict attrs: Keyword arguments which will be used to create a"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_df86e364","line":818,"updated":"2015-06-01 17:50:50.000000000","message":"See my later comment on renaming the module, but these methods would be better as \u003cverb\u003e_vpn_service so each word is spaced out by an underscore.","commit_id":"a1597ac3a24b1bd294475fb5e3f5b17d2ce14286"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"41c53c28b3e38060b7ae159b8294eb583da9ea97","unresolved":false,"context_lines":[{"line_number":815,"context_line":"        \"\"\""},{"line_number":816,"context_line":"        return self._update(subnet.Subnet, value, **attrs)"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    def create_vpnservice(self, **attrs):"},{"line_number":819,"context_line":"        \"\"\"Create a new vpnservice from attributes"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"        :param dict attrs: Keyword arguments which will be used to create a"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_0252d213","line":818,"in_reply_to":"5afe65bd_df86e364","updated":"2015-06-02 02:26:34.000000000","message":"Thanks, will change.","commit_id":"a1597ac3a24b1bd294475fb5e3f5b17d2ce14286"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"e14f345381642c86d3847c05069f1f3c22536722","unresolved":false,"context_lines":[{"line_number":844,"context_line":"        \"\"\""},{"line_number":845,"context_line":"        self._delete(vpnservice.VpnService, value, ignore_missing)"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"    def find_vpnservice(self, name_or_id):"},{"line_number":848,"context_line":"        return vpnservice.VpnService.find(self.session, name_or_id)"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    def get_vpnservice(self, **data):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_7fddaf6f","line":847,"updated":"2015-06-01 17:50:50.000000000","message":"Can you add a docstring here and to the following methods as well?","commit_id":"a1597ac3a24b1bd294475fb5e3f5b17d2ce14286"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"41c53c28b3e38060b7ae159b8294eb583da9ea97","unresolved":false,"context_lines":[{"line_number":844,"context_line":"        \"\"\""},{"line_number":845,"context_line":"        self._delete(vpnservice.VpnService, value, ignore_missing)"},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"    def find_vpnservice(self, name_or_id):"},{"line_number":848,"context_line":"        return vpnservice.VpnService.find(self.session, name_or_id)"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    def get_vpnservice(self, **data):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_c2727aad","line":847,"in_reply_to":"5afe65bd_7fddaf6f","updated":"2015-06-02 02:26:34.000000000","message":"Done","commit_id":"a1597ac3a24b1bd294475fb5e3f5b17d2ce14286"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"e14f345381642c86d3847c05069f1f3c22536722","unresolved":false,"context_lines":[{"line_number":848,"context_line":"        return vpnservice.VpnService.find(self.session, name_or_id)"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    def get_vpnservice(self, **data):"},{"line_number":851,"context_line":"        return vpnservice.VpnService(**data).get(self.session)"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"    def list_vpnservices(self, **params):"},{"line_number":854,"context_line":"        return vpnservice.VpnService.list(self.session, **params)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_5f9313a4","line":851,"updated":"2015-06-01 17:50:50.000000000","message":"This should be self._get and follow the same conventions we\u0027re using elsewhere.","commit_id":"a1597ac3a24b1bd294475fb5e3f5b17d2ce14286"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"41c53c28b3e38060b7ae159b8294eb583da9ea97","unresolved":false,"context_lines":[{"line_number":848,"context_line":"        return vpnservice.VpnService.find(self.session, name_or_id)"},{"line_number":849,"context_line":""},{"line_number":850,"context_line":"    def get_vpnservice(self, **data):"},{"line_number":851,"context_line":"        return vpnservice.VpnService(**data).get(self.session)"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"    def list_vpnservices(self, **params):"},{"line_number":854,"context_line":"        return vpnservice.VpnService.list(self.session, **params)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_a272de7a","line":851,"in_reply_to":"5afe65bd_5f9313a4","updated":"2015-06-02 02:26:34.000000000","message":"Done","commit_id":"a1597ac3a24b1bd294475fb5e3f5b17d2ce14286"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"e14f345381642c86d3847c05069f1f3c22536722","unresolved":false,"context_lines":[{"line_number":851,"context_line":"        return vpnservice.VpnService(**data).get(self.session)"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"    def list_vpnservices(self, **params):"},{"line_number":854,"context_line":"        return vpnservice.VpnService.list(self.session, **params)"},{"line_number":855,"context_line":""},{"line_number":856,"context_line":"    def update_vpnservice(self, value, **attrs):"},{"line_number":857,"context_line":"        \"\"\"Update a vpnservice"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_bff20705","line":854,"updated":"2015-06-01 17:50:50.000000000","message":"Same here - self._list will cover this.","commit_id":"a1597ac3a24b1bd294475fb5e3f5b17d2ce14286"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"41c53c28b3e38060b7ae159b8294eb583da9ea97","unresolved":false,"context_lines":[{"line_number":851,"context_line":"        return vpnservice.VpnService(**data).get(self.session)"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"    def list_vpnservices(self, **params):"},{"line_number":854,"context_line":"        return vpnservice.VpnService.list(self.session, **params)"},{"line_number":855,"context_line":""},{"line_number":856,"context_line":"    def update_vpnservice(self, value, **attrs):"},{"line_number":857,"context_line":"        \"\"\"Update a vpnservice"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_a2f9beca","line":854,"in_reply_to":"5afe65bd_bff20705","updated":"2015-06-02 02:26:34.000000000","message":"Done","commit_id":"a1597ac3a24b1bd294475fb5e3f5b17d2ce14286"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"b604d3d48fdaa9985e06c95dad8d40cf78f4e06f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        \"\"\"Find a single extension"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        :param name_or_id: The name or ID of a extension."},{"line_number":39,"context_line":"        :returns: One :class:`~openstack.compute.v2.extension.Extension`"},{"line_number":40,"context_line":"                  or None"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        return extension.Extension.find(self.session, name_or_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_4e0e5e3c","line":39,"updated":"2015-06-03 18:40:45.000000000","message":"You have a few places where openstack.compute instead of openstack.network","commit_id":"cb7ee2d31fe631ccbf291f249bc1edf715a06d11"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"399a807980bb3e4cedf2e3075c035ed11608f4eb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        \"\"\"Find a single extension"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        :param name_or_id: The name or ID of a extension."},{"line_number":39,"context_line":"        :returns: One :class:`~openstack.compute.v2.extension.Extension`"},{"line_number":40,"context_line":"                  or None"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        return extension.Extension.find(self.session, name_or_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_375929ff","line":39,"in_reply_to":"5afe65bd_4e0e5e3c","updated":"2015-06-04 04:33:02.000000000","message":"Sorry for this carelessness.  Will rebase to fix it.","commit_id":"cb7ee2d31fe631ccbf291f249bc1edf715a06d11"}],"openstack/network/v2/vpnservice.py":[{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"e14f345381642c86d3847c05069f1f3c22536722","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_df9f03b3","line":1,"updated":"2015-06-01 17:50:50.000000000","message":"Overall this file would be better as vpn_service.py instead of one word - a few other places, like floating_ip, separate the different words. That also makes it more clear in the proxy method naming.","commit_id":"a1597ac3a24b1bd294475fb5e3f5b17d2ce14286"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"41c53c28b3e38060b7ae159b8294eb583da9ea97","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_222b8eed","line":1,"in_reply_to":"5afe65bd_df9f03b3","updated":"2015-06-02 02:26:34.000000000","message":"Done","commit_id":"a1597ac3a24b1bd294475fb5e3f5b17d2ce14286"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"e14f345381642c86d3847c05069f1f3c22536722","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from openstack import resource"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class VpnService(resource.Resource):"},{"line_number":18,"context_line":"    resource_key \u003d \u0027vpnservice\u0027"},{"line_number":19,"context_line":"    resources_key \u003d \u0027vpnservices\u0027"},{"line_number":20,"context_line":"    base_path \u003d \u0027/vpn/vpnservices\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_df514310","line":17,"updated":"2015-06-01 17:50:50.000000000","message":"This would be better as VPNService","commit_id":"a1597ac3a24b1bd294475fb5e3f5b17d2ce14286"},{"author":{"_account_id":11034,"name":"Yanyan Hu","email":"huyanyan84@gmail.com","username":"yanyanhu"},"change_message_id":"41c53c28b3e38060b7ae159b8294eb583da9ea97","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from openstack import resource"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class VpnService(resource.Resource):"},{"line_number":18,"context_line":"    resource_key \u003d \u0027vpnservice\u0027"},{"line_number":19,"context_line":"    resources_key \u003d \u0027vpnservices\u0027"},{"line_number":20,"context_line":"    base_path \u003d \u0027/vpn/vpnservices\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5afe65bd_c20dda38","line":17,"in_reply_to":"5afe65bd_df514310","updated":"2015-06-02 02:26:34.000000000","message":"Done","commit_id":"a1597ac3a24b1bd294475fb5e3f5b17d2ce14286"}]}