)]}'
{"openstack/auth/access.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"00d3d9f66a7847dc49b1672e4314ff361aee44c5","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        super(AccessInfoV3, self).__init__(**kwargs)"},{"line_number":416,"context_line":"        self._info.update(version\u003d\u0027v3\u0027)"},{"line_number":417,"context_line":"        self.service_catalog \u003d catalog.ServiceCatalog("},{"line_number":418,"context_line":"            self._info.get(\u0027catalog\u0027))"},{"line_number":419,"context_line":"        if token:"},{"line_number":420,"context_line":"            self._info.update(auth_token\u003dtoken)"},{"line_number":421,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_4b63121b","line":418,"updated":"2015-05-27 14:16:59.000000000","message":"Should this be defaulted as {}?  If we don\u0027t find a catalog, we are pretty much done anyway, so KeyError isn\u0027t a bad thing.  Should there be a check that service_catalog \u003d\u003d None raise some error?","commit_id":"84bd54f66ef56035ab8e118f15af9c3d98f32cdb"},{"author":{"_account_id":8257,"name":"Brian Curtin","email":"brian@python.org","username":"briancurtin"},"change_message_id":"d9fd359e1946b3e44c90c9dafbc6da3383200795","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        super(AccessInfoV3, self).__init__(**kwargs)"},{"line_number":416,"context_line":"        self._info.update(version\u003d\u0027v3\u0027)"},{"line_number":417,"context_line":"        self.service_catalog \u003d catalog.ServiceCatalog("},{"line_number":418,"context_line":"            self._info.get(\u0027catalog\u0027))"},{"line_number":419,"context_line":"        if token:"},{"line_number":420,"context_line":"            self._info.update(auth_token\u003dtoken)"},{"line_number":421,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_ce26f015","line":418,"in_reply_to":"7a016987_4b63121b","updated":"2015-05-27 14:28:00.000000000","message":"This is a place we should raise exceptions.EmptyCatalog","commit_id":"84bd54f66ef56035ab8e118f15af9c3d98f32cdb"},{"author":{"_account_id":7404,"name":"Ethan Lynn","email":"xuanlangjian@gmail.com","username":"GaryLynn"},"change_message_id":"0e75e1f904b3cad54045bc4502eff7e6b21f9ca9","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        super(AccessInfoV3, self).__init__(**kwargs)"},{"line_number":416,"context_line":"        self._info.update(version\u003d\u0027v3\u0027)"},{"line_number":417,"context_line":"        self.service_catalog \u003d catalog.ServiceCatalog("},{"line_number":418,"context_line":"            self._info.get(\u0027catalog\u0027))"},{"line_number":419,"context_line":"        if token:"},{"line_number":420,"context_line":"            self._info.update(auth_token\u003dtoken)"},{"line_number":421,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a016987_3f02500a","line":418,"in_reply_to":"7a016987_ce26f015","updated":"2015-05-27 15:10:17.000000000","message":"@Terry, In some cases, token didn\u0027t contain catalog. See [1]. In that case, I get a KeyError: catalog instead of exception.EmptyCatalog.\n\n [1] http://developer.openstack.org/api-ref-identity-v3.html#tokens-v3\n\n@Brian, ServiceCatalog will raise exceptions.EmptyCatalog, See [2].\n\n [2] https://github.com/stackforge/python-openstacksdk/blob/master/openstack/auth/service_catalog.py#L34","commit_id":"84bd54f66ef56035ab8e118f15af9c3d98f32cdb"}]}
